Repository navigation
[backport cloud/1.58] fix(agent): withhold stale bound canvas drafts - #21867
Conversation
## Summary A bound canvas now withholds its turn draft only after the document socket drops, a sequence gap is detected, or a document reset begins. Healthy and never-subscribed canvases still post their live draft, while a fully successful catch-up projection clears the stale state. This prevents a question-only turn from replacing document edits that the canvas missed. The stale gate stays fail-closed across deferred or failed projection, schema failure, reseed-in-flight refusal, and reconnect frames whose sequence is not yet covered by the follower's integrated baseline. Switching away and back to the same bound workflow does not erase the signal. The implementation keeps the existing one-way follower and graph-API projection path; it adds no reconciliation pass or second graph mutation path. This standalone carrier incorporates and supersedes #21236’s healthy-draft contract. Tracks [PM-1890](https://linear.app/comfyorg/issue/PM-1890/fix-agent-graph-edits-do-not-all-show-on-the-canvas-only-one-of-two) and the current RC34 recurrence in [PM-2118](https://linear.app/comfyorg/issue/PM-2118/local-manual-parameter-edits-revert-after-agent-turns-even-when-only). ## Verification - Exact-head hosted Playwright video lane passes on `49d8ee6d9d9b5db9c06e86c22456aca1cd15954f`, including the stale-canvas and approval-response browser coverage. - Browser harness regression proves both missed canvas edits remain visible after catch-up; the original stale projection fails on the parent and passes here. - Unit: 689 focused Agent/CRDT tests pass. - Typecheck: app and browser configurations pass. - Pre-commit: formatting, type-aware lint, ESLint, stylelint, and app/browser typechecks pass. - Pre-push: dependency-cruiser, knip, and changed-file fallow audit pass. - Automated review: all actionable CodeRabbit findings were fixed with regression coverage; the six-model Cursor panel's valid fail-closed findings were fixed and its ADR-conflicting suggestions were declined with evidence. All review threads are resolved.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-24T01:07:40.588Z",
"gitSha": "4c0614d06040a776382dccc5a4a4f757b0b258ed",
"branch": "backport-21268-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.8329999999773,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.368,
"layouts": 10,
"layoutDurationMs": 2.68,
"taskDurationMs": 416.089,
"heapDeltaBytes": -23970932,
"heapUsedBytes": 80766656,
"domNodes": -200,
"jsHeapTotalBytes": 1642496,
"scriptDurationMs": 9.756999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2026.2099999999919,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.993,
"layouts": 9,
"layoutDurationMs": 2.4399999999999995,
"taskDurationMs": 371.793,
"heapDeltaBytes": 3907188,
"heapUsedBytes": 94151720,
"domNodes": -201,
"jsHeapTotalBytes": 319488,
"scriptDurationMs": 13.053999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.5790000000093,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.209,
"layouts": 10,
"layoutDurationMs": 2.692,
"taskDurationMs": 639.3059999999999,
"heapDeltaBytes": -744704,
"heapUsedBytes": 89918096,
"domNodes": -200,
"jsHeapTotalBytes": 3465216,
"scriptDurationMs": 124.00500000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1688.3579999999938,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.639,
"layouts": 10,
"layoutDurationMs": 2.76,
"taskDurationMs": 728.167,
"heapDeltaBytes": -1626096,
"heapUsedBytes": 88859056,
"domNodes": -180,
"jsHeapTotalBytes": 3821568,
"scriptDurationMs": 128.524,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.8959999999774,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.710999999999999,
"layouts": 11,
"layoutDurationMs": 3.194,
"taskDurationMs": 375.38300000000004,
"heapDeltaBytes": 1842916,
"heapUsedBytes": 106126828,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 15.431000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.0160000000196,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.736,
"layouts": 12,
"layoutDurationMs": 3.269,
"taskDurationMs": 304.515,
"heapDeltaBytes": -2253560,
"heapUsedBytes": 94179676,
"domNodes": 47,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 13.017999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 615.7610000000204,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.671,
"layouts": 10,
"layoutDurationMs": 2.8319999999999994,
"taskDurationMs": 445.552,
"heapDeltaBytes": 6432048,
"heapUsedBytes": 110717576,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 131.03500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66216216216216,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 533.506999999986,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.501,
"layouts": 10,
"layoutDurationMs": 2.881,
"taskDurationMs": 337.806,
"heapDeltaBytes": 3760848,
"heapUsedBytes": 93995932,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 118.54899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1034.7720000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 683.817,
"heapDeltaBytes": -9669736,
"heapUsedBytes": 102202236,
"domNodes": -210,
"jsHeapTotalBytes": 10825728,
"scriptDurationMs": 46.29900000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 374,
"frameDurationMs": 28.702777777777783,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 989.3690000000106,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.12,
"heapDeltaBytes": 9942700,
"heapUsedBytes": 128498516,
"domNodes": -150,
"jsHeapTotalBytes": 16211968,
"scriptDurationMs": 39.402,
"eventListeners": -168,
"totalBlockingTimeMs": 348,
"frameDurationMs": 28.917647058823537,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.7390000000082,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.9599999999998,
"heapDeltaBytes": -2147280,
"heapUsedBytes": 91510852,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.278,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 716.1980000000199,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.362,
"heapDeltaBytes": -2155620,
"heapUsedBytes": 90552732,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 103.998,
"eventListeners": 0,
"totalBlockingTimeMs": 99,
"frameDurationMs": 21.079411764705878,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6647.424000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5464.028,
"heapDeltaBytes": 60725244,
"heapUsedBytes": 148877668,
"domNodes": -276,
"jsHeapTotalBytes": 35651584,
"scriptDurationMs": 4227.007,
"eventListeners": 0,
"totalBlockingTimeMs": 42,
"frameDurationMs": 20.33577981651376,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6393.8249999999925,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3969999999999998,
"layouts": 1,
"layoutDurationMs": 0.3740000000000002,
"taskDurationMs": 5541.657,
"heapDeltaBytes": 25811380,
"heapUsedBytes": 135926860,
"domNodes": -296,
"jsHeapTotalBytes": 18145280,
"scriptDurationMs": 4194.754000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 29,
"frameDurationMs": 23.235401459854018,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6610.717999999992,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6759999999999995,
"layouts": 2,
"layoutDurationMs": 0.5400000000000001,
"taskDurationMs": 5891.889,
"heapDeltaBytes": 40412280,
"heapUsedBytes": 144713824,
"domNodes": -296,
"jsHeapTotalBytes": 18669568,
"scriptDurationMs": 4412.535,
"eventListeners": -130,
"totalBlockingTimeMs": 102,
"frameDurationMs": 24.78014981273408,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6628.048999999975,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2140000000000006,
"layouts": 3,
"layoutDurationMs": 0.9580000000000001,
"taskDurationMs": 5881.247,
"heapDeltaBytes": 37665060,
"heapUsedBytes": 147885144,
"domNodes": -296,
"jsHeapTotalBytes": 34660352,
"scriptDurationMs": 4305.272000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 2,
"frameDurationMs": 22.815172413793103,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 156.73699999999258,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.620000000000001,
"layouts": 12,
"layoutDurationMs": 3.1910000000000003,
"taskDurationMs": 111.51899999999999,
"heapDeltaBytes": 13297696,
"heapUsedBytes": 119282608,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.444999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 167.1220000000062,
"styleRecalcs": 21,
"styleRecalcDurationMs": 15,
"layouts": 11,
"layoutDurationMs": 3.3930000000000002,
"taskDurationMs": 122.39599999999997,
"heapDeltaBytes": 13249204,
"heapUsedBytes": 119812252,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 7.202,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.825000000000045,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2044.6279999999888,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3,
"layouts": 9,
"layoutDurationMs": 2.385,
"taskDurationMs": 513.5000000000001,
"heapDeltaBytes": -621832,
"heapUsedBytes": 102088252,
"domNodes": -296,
"jsHeapTotalBytes": -1765376,
"scriptDurationMs": 32.047,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.5570000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0609999999999995,
"layouts": 10,
"layoutDurationMs": 2.739,
"taskDurationMs": 423.64500000000004,
"heapDeltaBytes": 1129112,
"heapUsedBytes": 111701192,
"domNodes": -296,
"jsHeapTotalBytes": -729088,
"scriptDurationMs": 30.079,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2814.719000000025,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.323000000000002,
"layouts": 8,
"layoutDurationMs": 2.0149999999999992,
"taskDurationMs": 1270.0230000000001,
"heapDeltaBytes": -6936244,
"heapUsedBytes": 104003028,
"domNodes": -296,
"jsHeapTotalBytes": -765952,
"scriptDurationMs": 576.166,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666272189349115,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2965.8430000000067,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.8,
"layouts": 8,
"layoutDurationMs": 2.3669999999999995,
"taskDurationMs": 1377.203,
"heapDeltaBytes": 1715408,
"heapUsedBytes": 113156256,
"domNodes": -296,
"jsHeapTotalBytes": 20480,
"scriptDurationMs": 622.33,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665730337078653,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3952.019000000007,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.159999999999998,
"layouts": 64,
"layoutDurationMs": 12.057,
"taskDurationMs": 1462.157,
"heapDeltaBytes": -17079064,
"heapUsedBytes": 87893088,
"domNodes": -252,
"jsHeapTotalBytes": -1110016,
"scriptDurationMs": 598.364,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665822784810125,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3968.870000000038,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.049,
"layouts": 66,
"layoutDurationMs": 12.808,
"taskDurationMs": 1473.94,
"heapDeltaBytes": -17661836,
"heapUsedBytes": 87646288,
"domNodes": -272,
"jsHeapTotalBytes": -585728,
"scriptDurationMs": 605.722,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3038.876999999985,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.718,
"layouts": 6,
"layoutDurationMs": 1.673,
"taskDurationMs": 1601.0159999999998,
"heapDeltaBytes": -11681696,
"heapUsedBytes": 103000820,
"domNodes": 0,
"jsHeapTotalBytes": 5509120,
"scriptDurationMs": 777.024,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2976.4319999999884,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.181000000000001,
"layouts": 4,
"layoutDurationMs": 1.0800000000000003,
"taskDurationMs": 1575.472,
"heapDeltaBytes": -11402580,
"heapUsedBytes": 102756544,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 759.4269999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.854237288135593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2051.5480000000252,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.639,
"layouts": 8,
"layoutDurationMs": 2.347,
"taskDurationMs": 557.0619999999999,
"heapDeltaBytes": -1064660,
"heapUsedBytes": 102938644,
"domNodes": -296,
"jsHeapTotalBytes": -2027520,
"scriptDurationMs": 31.34700000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2052.3340000000303,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9610000000000003,
"layouts": 8,
"layoutDurationMs": 2.4270000000000005,
"taskDurationMs": 543.0409999999999,
"heapDeltaBytes": -27256540,
"heapUsedBytes": 86963576,
"domNodes": -296,
"jsHeapTotalBytes": -1777664,
"scriptDurationMs": 31.365000000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.4219999999873,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.337,
"layouts": 10,
"layoutDurationMs": 2.6350000000000002,
"taskDurationMs": 339.462,
"heapDeltaBytes": 705428,
"heapUsedBytes": 102833656,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 108.124,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.7239999999597,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.597,
"layouts": 9,
"layoutDurationMs": 3.009,
"taskDurationMs": 365.614,
"heapDeltaBytes": 22504244,
"heapUsedBytes": 113434444,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 112.339,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2025.3900000000158,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.19,
"layouts": 7,
"layoutDurationMs": 1.9940000000000002,
"taskDurationMs": 402.833,
"heapDeltaBytes": -14790732,
"heapUsedBytes": 91386240,
"domNodes": -198,
"jsHeapTotalBytes": 2691072,
"scriptDurationMs": 9.435,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.3869999999665,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4930000000000003,
"layouts": 10,
"layoutDurationMs": 2.975,
"taskDurationMs": 518.265,
"heapDeltaBytes": -15800324,
"heapUsedBytes": 90476288,
"domNodes": -198,
"jsHeapTotalBytes": 1904640,
"scriptDurationMs": 11.395999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.857999999997,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.231000000000002,
"layouts": 9,
"layoutDurationMs": 2.2740000000000005,
"taskDurationMs": 712.4169999999999,
"heapDeltaBytes": -5053524,
"heapUsedBytes": 85885348,
"domNodes": -210,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 100.64899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.2700000000132,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.428999999999998,
"layouts": 9,
"layoutDurationMs": 2.3789999999999996,
"taskDurationMs": 645.776,
"heapDeltaBytes": -2815748,
"heapUsedBytes": 89188436,
"domNodes": -211,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 104.737,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1318.0110000000127,
"styleRecalcs": 18,
"styleRecalcDurationMs": 18.9,
"layouts": 5,
"layoutDurationMs": 11.215,
"taskDurationMs": 837.867,
"heapDeltaBytes": 7149700,
"heapUsedBytes": 124976692,
"domNodes": 16030,
"jsHeapTotalBytes": 18489344,
"scriptDurationMs": 27.457999999999995,
"eventListeners": 3244,
"totalBlockingTimeMs": 102,
"frameDurationMs": 19.045714285714283,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8790.01999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.650999999999996,
"layouts": 10,
"layoutDurationMs": 2.769,
"taskDurationMs": 4383.998999999999,
"heapDeltaBytes": 3396364,
"heapUsedBytes": 113467672,
"domNodes": -296,
"jsHeapTotalBytes": -241664,
"scriptDurationMs": 2087.627,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666034155597725,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10505.288000000008,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.260999999999996,
"layouts": 7,
"layoutDurationMs": 2.4969999999999994,
"taskDurationMs": 4802.432,
"heapDeltaBytes": 10488096,
"heapUsedBytes": 113406668,
"domNodes": -276,
"jsHeapTotalBytes": -692224,
"scriptDurationMs": 2135.523,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69252782193959,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16632.660999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15984.033,
"heapDeltaBytes": -23056472,
"heapUsedBytes": 278791444,
"domNodes": -3344,
"jsHeapTotalBytes": 22532096,
"scriptDurationMs": 232.357,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.38621908127209,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 16757.475000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15969.076000000001,
"heapDeltaBytes": -18820020,
"heapUsedBytes": 288528324,
"domNodes": -3344,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 263.27199999999993,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.644778761061954,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 20386.282999999992,
"styleRecalcs": 148,
"styleRecalcDurationMs": 23.598999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20149.503,
"heapDeltaBytes": -27468608,
"heapUsedBytes": 304033720,
"domNodes": -3344,
"jsHeapTotalBytes": 19124224,
"scriptDurationMs": 755.193,
"eventListeners": -651,
"totalBlockingTimeMs": 32,
"frameDurationMs": 38.4165725047081,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 15314.628999999968,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.439000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14819.493000000002,
"heapDeltaBytes": -220716,
"heapUsedBytes": 300846524,
"domNodes": -3344,
"jsHeapTotalBytes": 7589888,
"scriptDurationMs": 642.74,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.515424610051994,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-node-resize-workload",
"durationMs": 6232.134000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.407000000000004,
"layouts": 20,
"layoutDurationMs": 23.789000000000005,
"taskDurationMs": 6130.471,
"heapDeltaBytes": -31881348,
"heapUsedBytes": 279626852,
"domNodes": -3344,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 121.65200000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.02947976878613,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6014.655999999945,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.236,
"layouts": 20,
"layoutDurationMs": 25.902999999999995,
"taskDurationMs": 5892.619,
"heapDeltaBytes": -21940300,
"heapUsedBytes": 302299256,
"domNodes": -3344,
"jsHeapTotalBytes": 23056384,
"scriptDurationMs": 97.61699999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.784883720930225,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6581.674000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6277.245000000001,
"heapDeltaBytes": 10033452,
"heapUsedBytes": 299133136,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.75899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.240202702702696,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8048.175000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7731.828,
"heapDeltaBytes": -3888904,
"heapUsedBytes": 275964244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.27199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.24456140350877,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 445.63999999996895,
"styleRecalcs": 16,
"styleRecalcDurationMs": 11.501999999999999,
"layouts": 11,
"layoutDurationMs": 3.874,
"taskDurationMs": 108.59299999999998,
"heapDeltaBytes": 7360792,
"heapUsedBytes": 97989888,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.116000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370367,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 436.38499999997293,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.398,
"layouts": 11,
"layoutDurationMs": 3.0700000000000003,
"taskDurationMs": 86.241,
"heapDeltaBytes": 6896924,
"heapUsedBytes": 97256896,
"domNodes": 95,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.200999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 280.85300000009283,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6629999999999999,
"layouts": 76,
"layoutDurationMs": 14.149000000000001,
"taskDurationMs": 237.642,
"heapDeltaBytes": 10327032,
"heapUsedBytes": 100429296,
"domNodes": 4,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 103.49600000000001,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 285.85500000008324,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.719,
"layouts": 76,
"layoutDurationMs": 14.645,
"taskDurationMs": 242.35299999999998,
"heapDeltaBytes": 10251152,
"heapUsedBytes": 98777920,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 107.669,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 321.38399999996636,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9980000000000002,
"layouts": 76,
"layoutDurationMs": 13.405999999999999,
"taskDurationMs": 277.422,
"heapDeltaBytes": -6089036,
"heapUsedBytes": 104059096,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 97.334,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000027,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 379.84400000004825,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.193,
"layouts": 76,
"layoutDurationMs": 16.962999999999997,
"taskDurationMs": 345.66200000000003,
"heapDeltaBytes": -754756,
"heapUsedBytes": 116038344,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 125.778,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2964 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 39f12a3bfe953cf3907c70507d706df340e6b16f
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (120)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
christian-byrne
left a comment
There was a problem hiding this comment.
Clean backport of #21268 to cloud/1.58.
- Patch identical to the merged source
- Required checks green at this head
- Agent unit suites pass locally
Full context for agent readers
- Head
ca2b7ee747fb0723a42a80bec4f5897143a11012, parent is the currentcloud/1.58tip;git diffof the commit matches11db769d0eline for line (index lines aside). - Required: lint-and-format, test, e2e-status pass; cloud shards 1-4 (where
agentStaleCanvasDraft.spec.tsruns) pass. upload-e2e-coverage / packagefails on every release-branch PR (lcov duplicate-function merge error), not required, tracked in https://linear.app/comfyorg/issue/FE-3596.- Local:
vitest run src/workbench/extensions/agent/crdt src/workbench/extensions/agent/AgentPanelRoot.test.ts→ 73 files pass. - 1.57/1.56 not backported: 12-file conflicts against a follower that differs by ~400 lines there.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #21867 +/- ##
=============================================
Coverage ? 85.78%
=============================================
Files ? 2588
Lines ? 134835
Branches ? 41181
=============================================
Hits ? 115674
Misses ? 18744
Partials ? 417
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21268 to
cloud/1.58Automatically created by backport workflow.