Repository navigation
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough
Merge Risk:
|
📦 Bundle: 11.9 MB gzipDetailsSummary
Category Glance App Entry Points — 6.65 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 2.57 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 149 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 871 kBConfiguration panels, inspectors, and settings screens
Status: 35 added User & Accounts — 154 kBAuthentication, profile, and account management bundles
Status: 17 added Editors & Dialogs — 572 kBModals, dialogs, drawers, and in-app editors
Status: 18 added UI Components — 276 kBReusable component library chunks
Status: 29 added Data & Services — 1.89 MBStores, services, APIs, and repositories
Status: 42 added Utilities & Hooks — 2.42 MBHelpers, composables, and utility bundles
Status: 83 added Vendor & Third-Party — 9.69 MBExternal libraries and shared vendor chunks
Status: 16 added Other — 34.8 MBBundles that do not match a named category
Status: 741 added ⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-28T04:27:21.511Z",
"gitSha": "3afaccd4fc6b5e4c1d4e9c316892225ed704469e",
"branch": "willie/des-1268-prompt-editor-panel",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.9569999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.487,
"layouts": 9,
"layoutDurationMs": 2.805,
"taskDurationMs": 512.824,
"heapDeltaBytes": 1280460,
"heapUsedBytes": 63284660,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 7.964000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2006.6770000000815,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.854,
"layouts": 10,
"layoutDurationMs": 2.576,
"taskDurationMs": 514.177,
"heapDeltaBytes": 4778792,
"heapUsedBytes": 74901000,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 8.007999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1777.1960000000036,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.65,
"layouts": 9,
"layoutDurationMs": 2.5269999999999997,
"taskDurationMs": 858.889,
"heapDeltaBytes": 22734428,
"heapUsedBytes": 83940268,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 155.728,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1901.1859999999388,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.02,
"layouts": 8,
"layoutDurationMs": 2.2830000000000004,
"taskDurationMs": 912.306,
"heapDeltaBytes": 23767236,
"heapUsedBytes": 84612736,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 169.118,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.8890000000424,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.966999999999999,
"layouts": 11,
"layoutDurationMs": 2.908,
"taskDurationMs": 395.8070000000001,
"heapDeltaBytes": 755860,
"heapUsedBytes": 70959308,
"domNodes": 57,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 11.370999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.6809999999368,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.496,
"layouts": 10,
"layoutDurationMs": 2.4619999999999997,
"taskDurationMs": 391.108,
"heapDeltaBytes": 23943672,
"heapUsedBytes": 85911840,
"domNodes": 57,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.641,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 627.112000000011,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.627,
"layouts": 9,
"layoutDurationMs": 2.339,
"taskDurationMs": 481.345,
"heapDeltaBytes": 3293824,
"heapUsedBytes": 64492616,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 169.959,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 658.3219999999983,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.352,
"layouts": 8,
"layoutDurationMs": 2.045,
"taskDurationMs": 483.417,
"heapDeltaBytes": 3432152,
"heapUsedBytes": 65216968,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 170.55100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.720000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 889.4780000000001,
"heapDeltaBytes": -13301456,
"heapUsedBytes": 75097372,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 70.619,
"eventListeners": -106,
"totalBlockingTimeMs": 516,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1213.5479999999461,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 899.741,
"heapDeltaBytes": -12510852,
"heapUsedBytes": 75059860,
"domNodes": -191,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 70.515,
"eventListeners": -106,
"totalBlockingTimeMs": 528,
"frameDurationMs": 32.88108108108108,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 895.1569999999833,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.04100000000017,
"heapDeltaBytes": -5240900,
"heapUsedBytes": 69268020,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.10199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.321621621621613,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 894.4240000000718,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.8899999999999,
"heapDeltaBytes": -27353664,
"heapUsedBytes": 66275128,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 169.118,
"eventListeners": -106,
"totalBlockingTimeMs": 224,
"frameDurationMs": 24.997222222222238,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11651.483000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10876.422,
"heapDeltaBytes": 64216864,
"heapUsedBytes": 157852668,
"domNodes": -257,
"jsHeapTotalBytes": 87683072,
"scriptDurationMs": 8822.042,
"eventListeners": -68,
"totalBlockingTimeMs": 1573,
"frameDurationMs": 32.63193277310924,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11082.621999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10324.434,
"heapDeltaBytes": 65484368,
"heapUsedBytes": 145707024,
"domNodes": -257,
"jsHeapTotalBytes": 79556608,
"scriptDurationMs": 8426.791,
"eventListeners": -68,
"totalBlockingTimeMs": 1413,
"frameDurationMs": 31.756160458452726,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10821.102999999994,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04799999999999943,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10015.908,
"heapDeltaBytes": 58586328,
"heapUsedBytes": 140333764,
"domNodes": -257,
"jsHeapTotalBytes": 72740864,
"scriptDurationMs": 8084.331999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1186,
"frameDurationMs": 30.950857142857146,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10304.153999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9566.071999999998,
"heapDeltaBytes": 37092352,
"heapUsedBytes": 130807708,
"domNodes": -257,
"jsHeapTotalBytes": 67497984,
"scriptDurationMs": 7709.585,
"eventListeners": -68,
"totalBlockingTimeMs": 1028,
"frameDurationMs": 31.59386503067485,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 204.79599999998754,
"styleRecalcs": 19,
"styleRecalcDurationMs": 11.473999999999998,
"layouts": 7,
"layoutDurationMs": 2.117000000000001,
"taskDurationMs": 151.356,
"heapDeltaBytes": 14589792,
"heapUsedBytes": 70214176,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.3,
"eventListeners": 205,
"totalBlockingTimeMs": 1,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 239.79700000001003,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.321000000000002,
"layouts": 13,
"layoutDurationMs": 4.044,
"taskDurationMs": 226.503,
"heapDeltaBytes": 2463492,
"heapUsedBytes": 70680024,
"domNodes": 713,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9.078000000000001,
"eventListeners": 73,
"totalBlockingTimeMs": 3,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2040.3969999999845,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3549999999999995,
"layouts": 8,
"layoutDurationMs": 2.3819999999999997,
"taskDurationMs": 643.116,
"heapDeltaBytes": -26526712,
"heapUsedBytes": 60759516,
"domNodes": -257,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 34.901,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.117999999946,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7229999999999996,
"layouts": 7,
"layoutDurationMs": 1.595,
"taskDurationMs": 620.337,
"heapDeltaBytes": -3981204,
"heapUsedBytes": 69773032,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 35.004999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2462.461000000019,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.302999999999999,
"layouts": 7,
"layoutDurationMs": 2.162,
"taskDurationMs": 1696.4519999999998,
"heapDeltaBytes": -12080684,
"heapUsedBytes": 61104884,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 823.727,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77959183673469,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2444.031999999993,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.949000000000002,
"layouts": 7,
"layoutDurationMs": 1.6589999999999998,
"taskDurationMs": 1695.2730000000001,
"heapDeltaBytes": -29014976,
"heapUsedBytes": 61239444,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 832.269,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780136986301372,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3631.430000000023,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.774999999999999,
"layouts": 64,
"layoutDurationMs": 9.937,
"taskDurationMs": 1700.859,
"heapDeltaBytes": 6522700,
"heapUsedBytes": 96523832,
"domNodes": 24,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 765.961,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3615.2940000000626,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.876999999999999,
"layouts": 64,
"layoutDurationMs": 10.136,
"taskDurationMs": 1720.5850000000003,
"heapDeltaBytes": 6729592,
"heapUsedBytes": 83218764,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 778.173,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635944700461,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3081.83600000001,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.231999999999999,
"layouts": 6,
"layoutDurationMs": 1.5280000000000002,
"taskDurationMs": 1944.7620000000004,
"heapDeltaBytes": -11176228,
"heapUsedBytes": 80566184,
"domNodes": 0,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 964.905,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757377049180327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2953.935999999999,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.808000000000001,
"layouts": 5,
"layoutDurationMs": 1.2699999999999998,
"taskDurationMs": 1919.664,
"heapDeltaBytes": 17628084,
"heapUsedBytes": 89321808,
"domNodes": 0,
"jsHeapTotalBytes": 3301376,
"scriptDurationMs": 962.596,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.856571428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3057.8929999999787,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9880000000000002,
"layouts": 8,
"layoutDurationMs": 1.8050000000000002,
"taskDurationMs": 769.6729999999999,
"heapDeltaBytes": -13387512,
"heapUsedBytes": 79102708,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 377.088,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3083.1590000000233,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6100000000000003,
"layouts": 6,
"layoutDurationMs": 1.5439999999999998,
"taskDurationMs": 776.125,
"heapDeltaBytes": -6119768,
"heapUsedBytes": 86909788,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 376.47200000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.5240000000335,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8140000000000005,
"layouts": 7,
"layoutDurationMs": 1.8419999999999999,
"taskDurationMs": 626.5240000000001,
"heapDeltaBytes": -15898260,
"heapUsedBytes": 75513224,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 30.904999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.266000000036,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9450000000000005,
"layouts": 7,
"layoutDurationMs": 1.9929999999999999,
"taskDurationMs": 632.29,
"heapDeltaBytes": -15451280,
"heapUsedBytes": 75991652,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 33.288000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2706.3819999999905,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.257999999999997,
"layouts": 9,
"layoutDurationMs": 2.056,
"taskDurationMs": 597.1400000000001,
"heapDeltaBytes": -22670448,
"heapUsedBytes": 67485720,
"domNodes": -255,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 186.781,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2791.481000000033,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.851,
"layouts": 6,
"layoutDurationMs": 1.35,
"taskDurationMs": 593.112,
"heapDeltaBytes": -18075612,
"heapUsedBytes": 72387580,
"domNodes": -253,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 188.325,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3248.995000000008,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5700000000000003,
"layouts": 6,
"layoutDurationMs": 1.3899999999999997,
"taskDurationMs": 924.3019999999998,
"heapDeltaBytes": 8711968,
"heapUsedBytes": 83526224,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 357.51200000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666494845360827,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3317.863999999986,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.4620000000000006,
"layouts": 6,
"layoutDurationMs": 1.6160000000000003,
"taskDurationMs": 953.3360000000001,
"heapDeltaBytes": -20379172,
"heapUsedBytes": 72692572,
"domNodes": -257,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 398.82900000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.83553299492386,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.9039999999713,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.087999999999999,
"layouts": 9,
"layoutDurationMs": 2.055,
"taskDurationMs": 429.05299999999994,
"heapDeltaBytes": -1755252,
"heapUsedBytes": 60714968,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 143.569,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 691.8739999999843,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.547,
"layouts": 8,
"layoutDurationMs": 2.439,
"taskDurationMs": 471.645,
"heapDeltaBytes": 2129672,
"heapUsedBytes": 73884896,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 154.407,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285718,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2023.8489999999842,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.651,
"layouts": 11,
"layoutDurationMs": 3.0700000000000007,
"taskDurationMs": 524.384,
"heapDeltaBytes": 4906048,
"heapUsedBytes": 76661300,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8.143999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.0410000000484,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.535,
"layouts": 9,
"layoutDurationMs": 2.7199999999999998,
"taskDurationMs": 509.14000000000004,
"heapDeltaBytes": 3892232,
"heapUsedBytes": 76453820,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 7.155000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.5340000000008,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.708,
"layouts": 9,
"layoutDurationMs": 2.2560000000000002,
"taskDurationMs": 809.808,
"heapDeltaBytes": 19005808,
"heapUsedBytes": 80814880,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 107.241,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.6190000000224,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.355000000000002,
"layouts": 8,
"layoutDurationMs": 2.109,
"taskDurationMs": 804.815,
"heapDeltaBytes": 17812888,
"heapUsedBytes": 80818952,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 104.21699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1537.239999999997,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.892,
"layouts": 5,
"layoutDurationMs": 16.857,
"taskDurationMs": 1237.354,
"heapDeltaBytes": 19106348,
"heapUsedBytes": 101883944,
"domNodes": 19230,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 31.478999999999992,
"eventListeners": 3566,
"totalBlockingTimeMs": 196,
"frameDurationMs": 20.66533333333333,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 9092.285000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.761,
"layouts": 8,
"layoutDurationMs": 1.8199999999999998,
"taskDurationMs": 6000.728999999999,
"heapDeltaBytes": -11157372,
"heapUsedBytes": 77728640,
"domNodes": -257,
"jsHeapTotalBytes": 5074944,
"scriptDurationMs": 2814.23,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696691176470587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9086.062999999967,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.32,
"layouts": 8,
"layoutDurationMs": 2.14,
"taskDurationMs": 6009.927000000001,
"heapDeltaBytes": -14454348,
"heapUsedBytes": 74102136,
"domNodes": -257,
"jsHeapTotalBytes": 6123520,
"scriptDurationMs": 2818.497,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23422.342000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22970.903,
"heapDeltaBytes": -14915828,
"heapUsedBytes": 280921936,
"domNodes": -3435,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 334.957,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.59094138543517,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 23364.196000000105,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22852.065,
"heapDeltaBytes": -1114352,
"heapUsedBytes": 285787016,
"domNodes": -3435,
"jsHeapTotalBytes": 10207232,
"scriptDurationMs": 322.03400000000005,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.29775474956822,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 28829.642000000036,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.46800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28394.801,
"heapDeltaBytes": -29610724,
"heapUsedBytes": 272970192,
"domNodes": -3435,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 860.887,
"eventListeners": -659,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.1959409594096,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28721.33500000007,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.081999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28364.499999999996,
"heapDeltaBytes": -25056104,
"heapUsedBytes": 276501980,
"domNodes": -3435,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 872.931,
"eventListeners": -659,
"totalBlockingTimeMs": 7,
"frameDurationMs": 53.17685185185186,
"p95FrameDurationMs": 116.5
},
{
"name": "vue-node-resize-workload",
"durationMs": 8501.849999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.098,
"layouts": 20,
"layoutDurationMs": 23.092000000000002,
"taskDurationMs": 8384.650000000001,
"heapDeltaBytes": -40976560,
"heapUsedBytes": 260453568,
"domNodes": -3435,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 125.34200000000001,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.84827586206898,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8329.018000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.80899999999998,
"layouts": 20,
"layoutDurationMs": 33.014,
"taskDurationMs": 8243.44,
"heapDeltaBytes": -30136364,
"heapUsedBytes": 271922612,
"domNodes": -3435,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 140.24900000000002,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.986781609195404,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11595.065999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11386.762,
"heapDeltaBytes": 5928216,
"heapUsedBytes": 282967796,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.58699999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.72465753424657,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11779.46499999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11561.893000000002,
"heapDeltaBytes": 33824344,
"heapUsedBytes": 289401676,
"domNodes": 0,
"jsHeapTotalBytes": -5767168,
"scriptDurationMs": 151.15099999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.630689655172404,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 483.161999999993,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.438,
"layouts": 14,
"layoutDurationMs": 4.877,
"taskDurationMs": 128.336,
"heapDeltaBytes": 7123500,
"heapUsedBytes": 67435808,
"domNodes": 138,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.954,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 111.88500000002932,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.649000000000001,
"layouts": 8,
"layoutDurationMs": 4.269,
"taskDurationMs": 80.66100000000002,
"heapDeltaBytes": 4616732,
"heapUsedBytes": 65480956,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.0939999999999985,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 454.19700000002194,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5770000000000001,
"layouts": 76,
"layoutDurationMs": 14.095,
"taskDurationMs": 408.632,
"heapDeltaBytes": -4630024,
"heapUsedBytes": 39883584,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 198.97600000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 485.37499999997635,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.648,
"layouts": 76,
"layoutDurationMs": 14.657,
"taskDurationMs": 435.464,
"heapDeltaBytes": -4247560,
"heapUsedBytes": 39878372,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 209.107,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 515.894000000003,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.57,
"layouts": 76,
"layoutDurationMs": 14.437999999999999,
"taskDurationMs": 476.70099999999996,
"heapDeltaBytes": 1039504,
"heapUsedBytes": 99162260,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 197.02199999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 516.4930000000822,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.462,
"layouts": 76,
"layoutDurationMs": 14.475,
"taskDurationMs": 482.116,
"heapDeltaBytes": 186556,
"heapUsedBytes": 94092888,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 197.163,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.20322580645162,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3153 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1225727093b9be36f0c21a875c4725b101294171
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (242)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
82a39e1 to
86a98e6
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 4 |
| 🟢 Low | 5 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
86a98e6 to
8eefb03
Compare
8eefb03 to
d71a7d8
Compare
d71a7d8 to
f17d58c
Compare
eec2ee6 to
1c35d05
Compare
0494796 to
c7e8af6
Compare
1e91610 to
2a9f6a5
Compare
2a9f6a5 to
2e69c3b
Compare
2e69c3b to
9ffdb9c
Compare
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed as the panel arm of the experiment, stacked on #21860 (diffed against that branch, not main).
Arm gating / population parity. canOpenPromptPanel in WidgetTextarea.vue (!hideLayoutField && !canvasStore.linearMode && !isBuilderMode && !promptPanelStore.isPanelHidden && !rightSidePanelStore.isLegacyMenu) correctly reproduces all five documented exclusions (app mode via linearMode, builder mode, focus mode + Agent node picking via isPanelHidden — set in LiteGraphCanvasSplitterOverlay.vue's watchEffect, and the legacy menu). I verified the "only on canvas nodes, not the panel's own parameters tab" claim concretely: SectionWidgets.vue provides HideLayoutFieldKey = true, which WidgetTextarea.vue (rendered through the same dynamic-component path in both places) picks up via useHideLayoutField(), so hideLayoutField is true and canOpenPromptPanel is false for parameters-tab-rendered widgets regardless of the node-id prop WidgetItem.vue also happens to pass down — it's the injection, not the prop's presence, that does the gating, and it holds up.
Server-determined state. openTextEditor()'s branch on promptEditorExperiment.assignment === 'panel' only decides which UI opens; the exposure/attribution going to PostHog still funnels through promptEditorExperiment.expose(...)/experimentPropertiesFor(...), which only ever attribute when isAttributedTo matches the server-served variant. A panel-arm user who falls through to the dialog (parameters tab, or openPromptPanel() returning false) calls expose('control'), which is a no-op since their real arm is panel — so that session is correctly excluded from both buckets, matching the PR's stated invariant. No frontend-invented arm logic.
Session lifecycle. promptPanelStore's open/moveSession/follow/close correctly collapse repeated Expand-into-the-panel into one session (node_switch_count bumping only on an actual node change, not a widget change on the same node), end on right-panel close / workflow switch / pagehide (deduped the same way as #21860's dialog, via clearing session after reportSessionEnd), and the graph-reload path (node:before-removed + configured listeners with findTargetAgain) correctly closes the session only when the same node+widget truly can't be found again after undo/redo reconfigures the graph. This is backed by solid test coverage in promptPanelStore.test.ts (open/close/session-count/page-hide/node-removal/reload cases).
CodeRabbit's still-open CHANGES_REQUESTED (Ctrl+Z/Ctrl+Y should not reach workflow undo while the prompt editor has focus): I checked this concretely. ChangeTracker.init()'s keydown handler already bails out before calling undoRedo() whenever document.activeElement is an INPUT/TEXTAREA/content-editable element (unless isAutoQueueOnChange()), and this guard is unchanged by this PR and pre-dates it on main. Since the panel's embedded editor (PromptEditor.vue) renders an actual <textarea>, it is already covered by that generic, pre-existing guard the same way the dialog's textarea already is — this PR doesn't regress or need to extend it, so I don't think this needs action before merging.
Validation performed:
pnpm vitest runonpromptPanelStore.test.ts,PromptEditor.test.ts,PromptPanel.test.ts,RightSidePanel.test.ts,WidgetTextarea.test.ts,changeTracker.test.ts: 233/233 pass.pnpm typecheck:app: clean.- Did not run the Playwright e2e spec (
promptEditorExperiment.spec.ts, tagged@cloud); the author notes it needs apnpm build:cloud+ ComfyUI-served setup that isn't available in this review environment. The unit coverage above exercises the same invariants it checks (event sequence,input_count,node_switch_count) at the store/component level. - Re-fetched head SHA immediately before approving; matches
9ffdb9cbc6e31621bd8139345ec879c0d1f8a561. Noneeds-human-reviewlabel; checks pass.
No blocking issues. Approving.
When the prompt-editor-surface arm is panel, Expand opens the prompt in the right side panel instead of the dialog. The panel floats over the canvas, follows the selected node, shows an empty state for a node without a prompt, and expands to the full-screen dialog. Node settings stays one click away, and a Prompt button returns to the prompt. App mode, builder mode and the legacy menu keep the dialog. The session reports prompt_editor_opened and prompt_editor_closed with its input and node switch counts.
… node goes Undo and redo reload the graph, which used to end the session. The panel now finds the same node and widget again after a reload, and closes only when they are gone. It listens for node:before-removed, which Clear Workflow and subgraph deletion also send, and closes a microtask later so a reload can re-point it first. Expand checks that the panel can show before it reports exposure or changes the selection: focus mode and Agent node picking hide the panel, and the overlay now reports that. The panel skips linked or hidden prompts when it follows the selection, returns to its prompt when the selection empties, reads the text live in the focus view and closes that view when the panel unmounts. A disabled widget opens read-only.
The focus view only checked read_only and disabled in the widget options, so a prompt disabled through its widget or widget state stayed editable there. The panel editor and the focus view now share one isWidgetReadOnly check.
A session now ends when another workflow becomes active or loads into the root graph under a different id, instead of rebinding to a node with the same id. A session still open at page hide reports its end by beacon. Requests for a specific side panel tab or section leave the prompt view. The editor takes focus only on its first mount after Expand, a linked input opens read-only, the panel does not follow selections while the workspace hides it, and Expand in the side panel, which also lists widgets of nodes inside subgraphs, opens the dialog. Builder mode keeps its own panel width.
The control arm reported exposure and attributed dialog sessions in app mode, builder mode, focus mode, Agent node picking, the legacy menu and the side panel, where a panel-arm user gets the dialog unattributed. Both arms now count only where the panel could have opened. Page hide closes the whole panel session, a selection made while the panel was hidden applies when it shows again, and Expand on the prompt the panel already shows focuses the editor.
Expand during a session now moves the session instead of closing and reopening it, so the panel arm's open count matches the dialog's. A reload rebinds only to a widget of the same type, the editor ends the session instead of writing to a widget its node dropped, and the focus view closes when the panel moves to another prompt. Node settings opens the parameters tab, and Expand on a read-only prompt leaves focus on the canvas.
The focus view now ends the session instead of writing to a widget its node dropped, through the same isWidgetAttached check as the panel editor.
- The prompt panel editor marks the workflow modified and saves its draft on each edit through ChangeTracker.refreshModifiedState, as the dialog does, and still records one undo step when focus leaves. - The panel header uses the textEditor.title message, so translations control its order and separator as they do for the dialog. - The widget no longer looks its node up a second time for the dialog title; the owning node's title arrives as a prop.
The prompt node locators, the Expand action and the event filter live in fixtures/utils, so the spec holds only the arm fixture and its tests.
The panel test reads the shared typed telemetry mock and narrows with assert.exists. The undo table presses Shift for its no-edit row instead of branching on an empty string.
… the canvas Each panel edit calls ChangeTracker.markModified, as the dialog does. Leaving the editor after an edit captures one undo step and then rechecks the modified flag against the saved state.
Main moved the ui components into @comfyorg/design-system in #21240.
Main made size-4 the Iconify default in #21949 and lints explicit size-4 on icons.
|
Rebased onto main to clear a conflict in #21460. |
dante01yoon
left a comment
There was a problem hiding this comment.
Re-approving. The force-push dismissed my earlier approval, but nothing in the PR changed.
I checked this myself: git range-diff bcc6cacef9..9ffdb9cbc6 74ae3950da..a1ec2ba6b3 shows every commit as = (identical) to the head I approved. Comparing the PR-only diff before and after the rebase shows no changed lines. The only change is the rebase onto the rebased #21860. There's no new discussion apart from bot reports, and all checks on a1ec2ba6b3 pass. My earlier review still stands.
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed in stack order after #21860. The panel arm reads the arm only from usePromptEditorExperimentStore().assignment (server-determined, not re-derived here). The control arm is unchanged apart from telemetry: when the panel cannot open, both arms get the dialog with no exposure and no $feature/ property, so the two arms count the same population. Events fire per action, not per render: open() records one opened event and moves an existing session instead of starting a new one; reportSessionEnd clears the session so close/pagehide cannot double-report. No new hand-declared server types in this PR. The blocking contract issue on the base (#21860, prompt-editor-surface typing) is tracked on that PR.
One non-blocking suggestion inline.
Validation: read-only review of the diff and PR description; no test run (CI checks show no failures).
| : canvasStore.currentGraph?.getNodeById(nodeId) | ||
| const target = node?.widgets?.find(({ name }) => name === widget.name) | ||
| if (!node || !target) return false | ||
| promptEditorExperiment.expose('panel') |
There was a problem hiding this comment.
suggestion: expose('panel') and selectItems([node]) run before promptPanelStore.open(...), but open() returns false when next.node.graph is null. In that case the user gets the dialog (via the fallthrough in openTextEditor), yet the panel arm was already reported as exposed and the canvas selection changed. It is a narrow edge, but it would put a dialog-rendering user into the panel exposure count. Could exposure move after a successful open()?
Summary
When the prompt editor experiment serves
panel, Expand opens the prompt in the right side panel instead of the dialog. This is the second arm of the A/B test.Part of DES-1268. Stacked on #21860, which is stacked on #21460. It replaces the sidebar tab in #21555, which is dropped from the test.
textEditor.titlemessage as the dialog, so translations control its order.$feature/prompt-editor-surface, so the two arms count the same population.prompt_editor_closedreportsinput_countandnode_switch_count. Undo and redo reload the same graph, so after a reload the panel finds the same node and widget again and only ends the session if they are gone. A graph that loads with a different id, or a widget of another type under the same name, ends it. Expand during a session moves the session to that prompt instead of starting a new one, so each arm reports one open per session.promptPanelStore(new) holds the session.rightSidePanelStoreonly adds an export ofisLegacyMenu.GraphCanvas's right panel slot rendersPromptPanelin place ofNodePropertiesPanelwhile the prompt shows.widgetValue.ts(getWidgetState,useSetWidgetValue) comes from feat: edit multiline text widgets in a properties panel Text tab #21555. It moves out ofSectionWidgets, so the panel writes values the same way as the parameters tab.mouseupcapture is skipped while the panel editor has focus. Leaving the editor after an edit records one undo step. Each edit still marks the workflow modified and updates its draft throughChangeTracker.markModified()from feat(widgets): expand a multiline text widget into a text editor dialog #21460, which does not add undo history. Leaving the editor also rechecks the flag, so text typed back to the original leaves the workflow clean.Look at this hardest
follow()changes the target only when the selected node changes. It counts node switches, but not re-selections of the same node.Verification
pnpm test:unit:promptPanelStore.test.ts(18): open, legacy menu, session counts, page hide, and the end of a session on panel close, workflow switch, a graph with another id, reload and node removal. Tab and section requests leave the prompt view.PromptEditor.test.ts(11) andPromptPanel.test.ts(10): editing, focus once, read-only, following, following while hidden, the empty state, Node settings, the focus view and the toggle.WidgetTextarea.test.ts: the panel arm opens the panel. App mode, focus mode and the side panel fall back to the dialog.RightSidePanel.test.ts: the Prompt button.changeTracker.test.ts: the undo guard for the dialog and the panel.SignUpForm.test.tsfails intermittently on its own; this stack does not touch it.promptEditorExperiment.spec.ts(@cloud) passed 2 of 2 locally before the latest round. I built it withpnpm build:cloudand served it with ComfyUI--front-end-root, as CI does. The spec serves each arm through/api/featuresand checks the full event sequence of each arm. In the panel arm that includesinput_count: 4andnode_switch_count: 1. The latest round only addsend_reason: 'close'to its expectations, and CI runs it.typecheck:app,typecheck:browser) passed.Screenshots