Repository navigation
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Telemetry contracts and provider dispatch src/platform/telemetry/types.ts, src/platform/telemetry/TelemetryRegistry.ts, src/platform/telemetry/providers/cloud/PostHogTelemetryProvider.ts, src/platform/telemetry/providers/host/HostTelemetrySink.ts, corresponding telemetry tests |
Adds prompt-editor exposure, opened, and closed metadata and events. The registry dispatches them to optional provider methods. The cloud provider uses immediate teardown capture for page-hide closes; the host sink captures the matching events. |
Experiment assignment and exposure src/platform/remoteConfig/types.ts, src/renderer/extensions/textEditor/promptEditorExperimentStore.ts, src/renderer/extensions/textEditor/promptEditorExperimentStore.test.ts |
Adds the remote-config variant field and a store that resolves attributed assignments from authenticated config, handles overrides, and tracks exposure for a matching rendered variant. Tests cover assignment, attribution, exposure, refresh failures, account changes, and overrides. |
Editor lifecycle telemetry src/renderer/extensions/textEditor/textEditorDialog.ts, src/renderer/extensions/textEditor/textEditorDialog.test.ts, src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue, src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.test.ts |
The dialog reports open and close metadata, including trigger, duration, edit count, and close reason. The widget reports control-arm exposure when opening the editor. |
Estimated code review effort: 3 (Moderate) | ~25 minutes
Change: Feature
Sequence Diagram(s)
sequenceDiagram
participant WidgetTextarea
participant usePromptEditorExperimentStore
participant TextEditorDialog
participant TelemetryRegistry
participant PostHogTelemetryProvider
participant HostTelemetrySink
WidgetTextarea->>usePromptEditorExperimentStore: expose control variant
usePromptEditorExperimentStore->>TelemetryRegistry: report exposure metadata
TextEditorDialog->>TelemetryRegistry: report open and close metadata
TelemetryRegistry->>PostHogTelemetryProvider: dispatch prompt-editor events
TelemetryRegistry->>HostTelemetrySink: dispatch prompt-editor events
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21862: Implements the
panelarm using this pull request’s assignment and telemetry contracts.
Merge Risk: 
Low · previous review 1a9d6
-
Runtime behavior is not implicated, but the new telemetry test should comply with the repository’s explicit testing rules before merging.
Pre-merge checks: 
5 · 
1
-
Failed checks: 1 warning Passed checks: 5 passed-
Full details: Title check
-
Explanation
The title "feat: add the prompt editor A/B experiment and its events" matches the main change: arm assignment via usePromptEditorExperimentStore, plus the exposure, opened, and closed telemetry events across the telemetry registry, PostHog provider, and host sink. It is specific and follows conventional commit style. It does not mention that the change is invisible to users, which is acceptable because the title need not cover every detail.
Full details: Description check
-
Explanation
The description follows the template. It has a Summary that explains the change and its non-user-visible behavior, and it names a known risk (the backend dependency for prompt-editor-surface, which is not yet filed). It includes a Verification section that lists the unit test commands, test counts, the browser e2e status, and the pre-commit results. It does not include an issue reference line, but the template marks that line as optional (it applies only when the PR fixes an issue). The description also adds a 'Look at this hardest' section, which is useful for reviewers. The Verification section has no after-release telemetry plan, but the template marks that item as optional.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
PASS. The PR does not modify
src/lib/litegraph/orsrc/ecs/. Its widget-related change only records prompt-editor exposure before opening the editor. The diff introduces no direct spatial mutation, entity method growth, ECS component methods or back-references, extension callback changes,node.widgetsaccess,serializeoverride, orgraph._version++change.
-
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes the main frontend under
src/and adds the user-triggered prompt editor experiment and telemetry. A user can trigger it by clicking Expand or opening the editor from the focus view. No changed file is underbrowser_tests/, so no browser spec exercises this trigger. This is a suggestion, not a merge requirement.Resolution
Extend an existing spec under
browser_tests/: - Open the text editor from the Expand action. - Verify the prompt editor opened event. - Close the prompt editor. - Verify the prompt editor closed event.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
📦 Bundle: 11.9 MB gzipDetailsSummary
Category Glance App Entry Points — 6.65 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 2.56 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 149 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 871 kBConfiguration panels, inspectors, and settings screens
Status: 35 added User & Accounts — 154 kBAuthentication, profile, and account management bundles
Status: 17 added Editors & Dialogs — 502 kBModals, dialogs, drawers, and in-app editors
Status: 17 added UI Components — 340 kBReusable component library chunks
Status: 30 added Data & Services — 1.88 MBStores, services, APIs, and repositories
Status: 42 added Utilities & Hooks — 2.42 MBHelpers, composables, and utility bundles
Status: 83 added Vendor & Third-Party — 9.69 MBExternal libraries and shared vendor chunks
Status: 16 added Other — 34.8 MBBundles that do not match a named category
Status: 741 added ⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-28T04:29:29.572Z",
"gitSha": "1225727093b9be36f0c21a875c4725b101294171",
"branch": "willie/des-1268-prompt-editor-experiment",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.7459999999796,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.999,
"layouts": 9,
"layoutDurationMs": 2.905,
"taskDurationMs": 662.3829999999999,
"heapDeltaBytes": 3351416,
"heapUsedBytes": 64793660,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 13.784,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.3639999999778,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.673,
"layouts": 9,
"layoutDurationMs": 2.703,
"taskDurationMs": 543.933,
"heapDeltaBytes": 5223852,
"heapUsedBytes": 75459684,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 10.043,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.4230000000202,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.503999999999998,
"layouts": 8,
"layoutDurationMs": 2.3289999999999997,
"taskDurationMs": 932.7959999999999,
"heapDeltaBytes": 23892112,
"heapUsedBytes": 84875040,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 167.642,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363634,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1847.4579999999605,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.545,
"layouts": 8,
"layoutDurationMs": 2.568,
"taskDurationMs": 969.017,
"heapDeltaBytes": 22899412,
"heapUsedBytes": 83365916,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 173.978,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864867,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.5469999999787,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.676,
"layouts": 11,
"layoutDurationMs": 3.0999999999999996,
"taskDurationMs": 456.91900000000004,
"heapDeltaBytes": 258992,
"heapUsedBytes": 69956760,
"domNodes": 57,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 14.177999999999995,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.6209999999037,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.640999999999999,
"layouts": 11,
"layoutDurationMs": 3.177,
"taskDurationMs": 449.709,
"heapDeltaBytes": 946268,
"heapUsedBytes": 71461912,
"domNodes": 57,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 13.340000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 716.3300000000277,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0660000000000003,
"layouts": 10,
"layoutDurationMs": 2.7360000000000007,
"taskDurationMs": 507.55499999999995,
"heapDeltaBytes": 3519316,
"heapUsedBytes": 64717704,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 172.467,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 740.9690000000637,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.038,
"layouts": 9,
"layoutDurationMs": 2.9879999999999995,
"taskDurationMs": 513.7100000000002,
"heapDeltaBytes": 5506736,
"heapUsedBytes": 66583864,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 171.35199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363636,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1239.4289999999728,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 958.804,
"heapDeltaBytes": -14041508,
"heapUsedBytes": 75042848,
"domNodes": -191,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 71.698,
"eventListeners": -106,
"totalBlockingTimeMs": 548,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1288.5459999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1014.421,
"heapDeltaBytes": -1321000,
"heapUsedBytes": 75050080,
"domNodes": -191,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 84.476,
"eventListeners": -106,
"totalBlockingTimeMs": 582,
"frameDurationMs": 33.768421052631595,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 952.2680000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.2019999999997,
"heapDeltaBytes": -28580076,
"heapUsedBytes": 66476356,
"domNodes": -191,
"jsHeapTotalBytes": 4587520,
"scriptDurationMs": 183.574,
"eventListeners": -106,
"totalBlockingTimeMs": 237,
"frameDurationMs": 24.997368421052624,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 920.4220000000305,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.5259999999998,
"heapDeltaBytes": -29865892,
"heapUsedBytes": 65904120,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 179.40800000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 248,
"frameDurationMs": 25.463888888888885,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12545.598000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11654.430000000002,
"heapDeltaBytes": 70811984,
"heapUsedBytes": 153313908,
"domNodes": -257,
"jsHeapTotalBytes": 86372352,
"scriptDurationMs": 9552.306999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 2452,
"frameDurationMs": 34.88873626373626,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10803.770999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9987.667,
"heapDeltaBytes": 58212788,
"heapUsedBytes": 137104732,
"domNodes": -257,
"jsHeapTotalBytes": 69595136,
"scriptDurationMs": 7969.8679999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 1026,
"frameDurationMs": 30.992550143266474,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10505.415999999968,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06799999999999948,
"layouts": 1,
"layoutDurationMs": 0.31899999999999984,
"taskDurationMs": 9729.132,
"heapDeltaBytes": 79085608,
"heapUsedBytes": 159542260,
"domNodes": -257,
"jsHeapTotalBytes": 67760128,
"scriptDurationMs": 7751.443,
"eventListeners": -68,
"totalBlockingTimeMs": 1063,
"frameDurationMs": 30.936950146627566,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11642.62599999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10804.166,
"heapDeltaBytes": 63187860,
"heapUsedBytes": 143111344,
"domNodes": -257,
"jsHeapTotalBytes": 70381568,
"scriptDurationMs": 8720.754,
"eventListeners": -68,
"totalBlockingTimeMs": 1461,
"frameDurationMs": 31.570460704607047,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 294.55999999998994,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.577,
"layouts": 11,
"layoutDurationMs": 3.6969999999999996,
"taskDurationMs": 255.348,
"heapDeltaBytes": -16330092,
"heapUsedBytes": 59612368,
"domNodes": 936,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 9.323000000000002,
"eventListeners": 205,
"totalBlockingTimeMs": 4,
"frameDurationMs": 23.07692307692304,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 285.54300000007515,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.492,
"layouts": 10,
"layoutDurationMs": 5.8340000000000005,
"taskDurationMs": 256.028,
"heapDeltaBytes": -9459552,
"heapUsedBytes": 67039096,
"domNodes": -2097,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.735999999999999,
"eventListeners": -514,
"totalBlockingTimeMs": 12,
"frameDurationMs": 21.792307692307705,
"p95FrameDurationMs": 83.40000000000055
},
{
"name": "large-graph-idle",
"durationMs": 2057.6790000000074,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.726,
"layouts": 8,
"layoutDurationMs": 2.757,
"taskDurationMs": 691.705,
"heapDeltaBytes": -9329972,
"heapUsedBytes": 64763312,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 36.176,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.992000000013,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.805,
"layouts": 8,
"layoutDurationMs": 2.5700000000000003,
"taskDurationMs": 760.1459999999998,
"heapDeltaBytes": -16581656,
"heapUsedBytes": 73606704,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 39.719,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3081.046000000015,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.419,
"layouts": 6,
"layoutDurationMs": 1.716,
"taskDurationMs": 1972.3980000000001,
"heapDeltaBytes": -29553180,
"heapUsedBytes": 61894792,
"domNodes": -257,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 961.0880000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84863387978142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2931.465000000003,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.539,
"layouts": 6,
"layoutDurationMs": 2.0379999999999994,
"taskDurationMs": 1900.954,
"heapDeltaBytes": -15708504,
"heapUsedBytes": 72160728,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 928.416,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666477272727274,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3910.3719999999953,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.082999999999998,
"layouts": 64,
"layoutDurationMs": 10.788,
"taskDurationMs": 1873.168,
"heapDeltaBytes": -6063268,
"heapUsedBytes": 84366124,
"domNodes": -233,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 810.7339999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3944.309999999973,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.515,
"layouts": 64,
"layoutDurationMs": 11.185,
"taskDurationMs": 1917.3840000000002,
"heapDeltaBytes": -10295760,
"heapUsedBytes": 83155824,
"domNodes": -233,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 845.123,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666244725738395,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3212.9830000000084,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.41,
"layouts": 5,
"layoutDurationMs": 1.461,
"taskDurationMs": 2075.616,
"heapDeltaBytes": 4712888,
"heapUsedBytes": 76893696,
"domNodes": -257,
"jsHeapTotalBytes": 2904064,
"scriptDurationMs": 994.5469999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.841578947368422,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3220.1800000000276,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.3629999999999995,
"layouts": 5,
"layoutDurationMs": 1.708,
"taskDurationMs": 2203.675,
"heapDeltaBytes": -7641160,
"heapUsedBytes": 70434312,
"domNodes": 0,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 1082.713,
"eventListeners": 182,
"totalBlockingTimeMs": 20,
"frameDurationMs": 16.92774869109948,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3106.4039999999977,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.936000000000001,
"layouts": 6,
"layoutDurationMs": 1.5530000000000002,
"taskDurationMs": 832.718,
"heapDeltaBytes": -2000100,
"heapUsedBytes": 74665584,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 384.308,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75537634408602,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3230.8470000000398,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.409999999999999,
"layouts": 7,
"layoutDurationMs": 2.5140000000000002,
"taskDurationMs": 932.18,
"heapDeltaBytes": -9374328,
"heapUsedBytes": 80718256,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 446.82099999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665979381443297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2046.0659999999962,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7809999999999997,
"layouts": 8,
"layoutDurationMs": 2.7420000000000004,
"taskDurationMs": 701.691,
"heapDeltaBytes": -9111920,
"heapUsedBytes": 82947628,
"domNodes": -257,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 40.51299999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.6799999999948,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7589999999999995,
"layouts": 8,
"layoutDurationMs": 2.187,
"taskDurationMs": 772.995,
"heapDeltaBytes": -10442488,
"heapUsedBytes": 64773360,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 40.227999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2861.439999999959,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.068000000000003,
"layouts": 5,
"layoutDurationMs": 1.404,
"taskDurationMs": 659.398,
"heapDeltaBytes": -16771708,
"heapUsedBytes": 72200676,
"domNodes": -254,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 207.23500000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608187134503,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2834.2429999999013,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.908,
"layouts": 6,
"layoutDurationMs": 2.046,
"taskDurationMs": 658.349,
"heapDeltaBytes": -7182228,
"heapUsedBytes": 85834136,
"domNodes": -243,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 211.422,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665882352941175,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3382.0650000000114,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0039999999999996,
"layouts": 8,
"layoutDurationMs": 2.078,
"taskDurationMs": 1009.908,
"heapDeltaBytes": -16844356,
"heapUsedBytes": 74854808,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 390.206,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600985221675,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3388.1999999999834,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7070000000000003,
"layouts": 6,
"layoutDurationMs": 1.5010000000000001,
"taskDurationMs": 1025.2620000000002,
"heapDeltaBytes": 7954772,
"heapUsedBytes": 83684220,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 408.89,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600985221675,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 691.299000000015,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.337,
"layouts": 9,
"layoutDurationMs": 3.15,
"taskDurationMs": 474.032,
"heapDeltaBytes": 24960432,
"heapUsedBytes": 86890508,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 155.998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 638.753999999949,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.178,
"layouts": 9,
"layoutDurationMs": 2.6510000000000002,
"taskDurationMs": 451.998,
"heapDeltaBytes": 1509392,
"heapUsedBytes": 73388696,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 149.242,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2020.8140000000299,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.092,
"layouts": 9,
"layoutDurationMs": 2.731,
"taskDurationMs": 558.0020000000001,
"heapDeltaBytes": 2205036,
"heapUsedBytes": 63699056,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 10.533000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.7049999999635,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8540000000000005,
"layouts": 9,
"layoutDurationMs": 2.718,
"taskDurationMs": 646.295,
"heapDeltaBytes": 5017496,
"heapUsedBytes": 77376260,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 12.788,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.0269999999878,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.675,
"layouts": 10,
"layoutDurationMs": 3.4170000000000003,
"taskDurationMs": 898.0010000000001,
"heapDeltaBytes": 17417544,
"heapUsedBytes": 80047360,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 116.50699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.7539999999708,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.279999999999998,
"layouts": 8,
"layoutDurationMs": 2.383,
"taskDurationMs": 923.808,
"heapDeltaBytes": 17053704,
"heapUsedBytes": 79007404,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 121.522,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1588.7859999999137,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.309,
"layouts": 5,
"layoutDurationMs": 18.900999999999996,
"taskDurationMs": 1418.3020000000001,
"heapDeltaBytes": -7007524,
"heapUsedBytes": 99658544,
"domNodes": 19310,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 35.775,
"eventListeners": 3566,
"totalBlockingTimeMs": 224,
"frameDurationMs": 21.05263157894737,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 10236.302000000023,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.463000000000005,
"layouts": 7,
"layoutDurationMs": 1.7510000000000003,
"taskDurationMs": 6318.134000000001,
"heapDeltaBytes": 3825276,
"heapUsedBytes": 77455736,
"domNodes": -257,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 2864.134,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66596091205212,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10253.639000000021,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.003,
"layouts": 8,
"layoutDurationMs": 2.1359999999999997,
"taskDurationMs": 6274.996,
"heapDeltaBytes": -5993184,
"heapUsedBytes": 81154536,
"domNodes": -257,
"jsHeapTotalBytes": 4026368,
"scriptDurationMs": 2833.321,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6660162601626,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24422.72600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23640.476,
"heapDeltaBytes": -34007768,
"heapUsedBytes": 274706680,
"domNodes": -3117,
"jsHeapTotalBytes": 8638464,
"scriptDurationMs": 335.084,
"eventListeners": -594,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.68461538461539,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24787.296999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24030.754999999997,
"heapDeltaBytes": -41483892,
"heapUsedBytes": 260697572,
"domNodes": -3117,
"jsHeapTotalBytes": 12042240,
"scriptDurationMs": 352.156,
"eventListeners": -594,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.05399305555555,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 29561.830999999984,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.08599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29206.082,
"heapDeltaBytes": -7109008,
"heapUsedBytes": 275424640,
"domNodes": -3121,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 885.457,
"eventListeners": -592,
"totalBlockingTimeMs": 33,
"frameDurationMs": 54.720000000000006,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 29507.161999999993,
"styleRecalcs": 181,
"styleRecalcDurationMs": 25.940999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29159.760000000002,
"heapDeltaBytes": -14519288,
"heapUsedBytes": 274170668,
"domNodes": -3117,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 903.134,
"eventListeners": -592,
"totalBlockingTimeMs": 147,
"frameDurationMs": 54.728756957328386,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8686.063999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.36,
"layouts": 20,
"layoutDurationMs": 22.24200000000001,
"taskDurationMs": 8588.423999999999,
"heapDeltaBytes": -8980364,
"heapUsedBytes": 279745932,
"domNodes": -3117,
"jsHeapTotalBytes": 19648512,
"scriptDurationMs": 137.00400000000002,
"eventListeners": -594,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.48197674418604,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8673.604999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.58100000000002,
"layouts": 20,
"layoutDurationMs": 30.35800000000001,
"taskDurationMs": 8559.688999999998,
"heapDeltaBytes": -27603668,
"heapUsedBytes": 274363736,
"domNodes": -3117,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 126.573,
"eventListeners": -594,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.777777777777764,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12367.390999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11997.734999999999,
"heapDeltaBytes": 6152416,
"heapUsedBytes": 285751508,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.92200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.9193220338983,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12625.602999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12210.286,
"heapDeltaBytes": 25712836,
"heapUsedBytes": 275878000,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 178.67600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.11535836177474,
"p95FrameDurationMs": 100
},
{
"name": "workflow-execution",
"durationMs": 144.06299999996008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.985,
"layouts": 10,
"layoutDurationMs": 4.627,
"taskDurationMs": 105.59100000000002,
"heapDeltaBytes": 4837668,
"heapUsedBytes": 65563024,
"domNodes": 105,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.265999999999998,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 132.82900000001518,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.337,
"layouts": 9,
"layoutDurationMs": 3.541,
"taskDurationMs": 91.753,
"heapDeltaBytes": -13259100,
"heapUsedBytes": 62243968,
"domNodes": 124,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 6.915000000000001,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 488.0749999999807,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.62,
"layouts": 76,
"layoutDurationMs": 15.243,
"taskDurationMs": 437.436,
"heapDeltaBytes": -4197256,
"heapUsedBytes": 40172092,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 211.981,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 532.224000000042,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.64,
"layouts": 76,
"layoutDurationMs": 16.738,
"taskDurationMs": 489.894,
"heapDeltaBytes": -3946400,
"heapUsedBytes": 41807808,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 234.351,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665624999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 672.9800000000523,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.022,
"layouts": 76,
"layoutDurationMs": 16.709000000000003,
"taskDurationMs": 632.655,
"heapDeltaBytes": 1814432,
"heapUsedBytes": 95708976,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 266.10200000000003,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 638.0990000000111,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.98,
"layouts": 76,
"layoutDurationMs": 15.907000000000002,
"taskDurationMs": 596.718,
"heapDeltaBytes": 2051020,
"heapUsedBytes": 93185608,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 241.61100000000002,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3155 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2ba0d38636ffb70705fbf6bb440cddc7ffec728c
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (242)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
c9bc96f to
49cb9af
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 3 |
Panel: 6/6 reviewers contributed findings.
01ad63e to
333c2b1
Compare
333c2b1 to
9d570a6
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
Round 2 — ledger: 6 prior finding(s) across 1 round(s) (6 never answered).
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 5 |
Panel: 6/6 reviewers contributed findings.
10377d5 to
a6faccd
Compare
a6faccd to
67d87a4
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
Round 3 — ledger: 14 prior finding(s) across 2 round(s) (8 never answered).
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 3 |
Panel: 6/6 reviewers contributed findings.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @shrimbly.
Round 4 — ledger: 18 prior finding(s) across 3 round(s) (12 never answered).
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 2 |
| ⚪ Nit | 2 |
Panel: 6/6 reviewers contributed findings.
67d87a4 to
9bd7688
Compare
…text editor WebKit fires compositionend before the keydown that ends a composition, so its Escape arrives with isComposing false and keyCode 229. The dialog escape guard now treats either as composing. Restoring the selection after an outside edit keeps its direction.
An execution that rewrites a read-only output used to leave the old selection offsets over unrelated text. The selection now survives only when the text up to its end is unchanged, and otherwise collapses at its start.
It restated the implementation and claimed one undo step per session, which a queue-time checkpoint during the session can split.
- Mark the workflow modified and save its draft while the dialog is open. ChangeTracker.refreshModifiedState updates the flag from the canvas and notifies graph listeners without moving the undo point, so closing still records one undo step from the start of the session. - Forward the widget's textarea attributes (maxlength, placeholder) to the dialog, as the inline textarea already gets them. - Title the dialog with the title of the node that owns the widget, passed from the canvas and the side panel, instead of looking a bare node id up in the graph on screen. - Bind the dialog to the widget text directly instead of a second draft, and leave the caret alone during an IME composition. The composed text wins over a change made elsewhere while composing. - Russian count uses an invariant abbreviation. - Tracker tests scope the listeners and prototype patches that init() installs, so they no longer leak into later tests.
Use the shared move-off-widget helper, split the multi-action cases into named steps, and add a screenshot of the opened dialog so its header, reading column and padding are covered.
Taken from the failed screenshot assertions of https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40375284137 without rerunning Playwright. | snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/vueNodes/widgets/text/textEditorDialog.spec.ts-snapshots/text-editor-dialog-chromium-linux.png` | new | n/a | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
Restores main's idle-overflow policy. Measured headless on an M5 Pro with 48 overflowing prompts, an always-scrollable textarea gives each prompt a compositor layer (17 -> 251) and raises GPU-process CPU while panning from 87 to 589 ms per second (6.8x; 10.8x at 96). Frame times did not change on that machine, but slower GPUs pay for every layer. The slight text shift on hover at a fractional zoom returns, as on main, so its e2e test goes too.
…live - Each edit in the dialog calls the new ChangeTracker.markModified at once. The 300 ms debounce it replaces kept postponing the graphChanged that draft persistence waits for, so a page hide in the middle of a typing burst kept the old draft. markModified sets the flag and sends graphChanged with the committed state, without serializing the canvas, so a keystroke stays cheap on a large graph. Persistence still debounces its own writes, and the undo point does not move. - On close the dialog captures as before and then rechecks the modified flag against the saved state, so text typed back to the original leaves the workflow clean. - The dialog reads the widget's textarea attributes through a getter, so a limit that changes while it is open applies at once. It no longer forwards disabled: the live read-only getter already locks a disabled widget, and a disabled textarea would make its text unselectable. - Tests cover the guards for an inactive tracker and a loading graph.
Main moved the ui components into @comfyorg/design-system in #21240.
| snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/appChrome/appChrome.spec.ts-snapshots/app-kitchen-sink-chromium-linux.png` | modified | 108892B -> 108989B | | `browser_tests/tests/nodeBadge.spec.ts-snapshots/api-pricing-on-vue-chromium-linux.png` | modified | 19897B -> 19871B | | `browser_tests/tests/vueNodes/interactions/canvas/zoom.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png` | modified | 30899B -> 30905B | | `browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-shift-output-multi-link-chromium-linux.png` | modified | 29203B -> 29193B | | `browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-node-chromium-linux.png` | modified | 26255B -> 26247B | | `browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-slot-chromium-linux.png` | modified | 25598B -> 25588B | | `browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-after-chromium-linux.png` | modified | 18252B -> 18258B | | `browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts-snapshots/bring-to-front-overlapped-before-chromium-linux.png` | modified | 20719B -> 20724B | | `browser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png` | modified | 74692B -> 74488B | | `browser_tests/tests/vueNodes/widgets/flux2ImagePromptRerun.spec.ts-snapshots/flux2-prompt-after-run-1-chromium-linux.png` | modified | 26723B -> 26680B | | `browser_tests/tests/vueNodes/widgets/flux2ImagePromptRerun.spec.ts-snapshots/flux2-prompt-after-run-2-chromium-linux.png` | modified | 26723B -> 26680B | | `browser_tests/tests/vueNodes/widgets/flux2ImagePromptRerun.spec.ts-snapshots/flux2-prompt-before-runs-chromium-linux.png` | modified | 15185B -> 15144B | | `browser_tests/tests/vueNodes/widgets/text/lockedWidgetHoverColor.spec.ts-snapshots/editable-widget-hover-color-chromium-linux.png` | modified | 6414B -> 7207B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
bcc6cac to
b783c14
Compare
Taken from the failed screenshot assertions of https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40629117182 without rerunning Playwright. | snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/agent/agentConversationReplay.spec.ts-snapshots/two-turn-dependent-edit-wired-cloud-linux.png` | modified | 67066B -> 66969B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
Reads the prompt-editor-surface arm from remote config, falls back to control until the authenticated config loads, and honours the session and dev overrides for QA. Expand reports exposure for the arm that rendered, once per session. The dialog reports prompt_editor_opened and prompt_editor_closed with the trigger, time open and input count.
A user with no arm served, or an unknown value, now gets control without the $feature property, so the control arm only counts users PostHog assigned. The QA override is read on every evaluation instead of once at store setup. Exposure is remembered per arm, so a new arm after a config refresh reports again, and it is only marked reported once telemetry is installed.
…ff by page hide The assignment now changes only when the authenticated config loads or is cleared. A failed refresh keeps the served arm, and an account switch clears the exposure latch and re-reads any QA override. A session still open when the page hides sends its closed event by beacon with end_reason pagehide, and the closed event goes out before the undo capture.
A dialog session counts for the control arm, and a panel or focus view session for the panel arm, the same rule exposure uses. A panel-arm user who gets the dialog, before the panel ships or where the panel cannot open, is no longer counted as panel usage. The config watcher runs synchronously, so an account switch that passes through the cleared state within one tick still resets the exposure latch.
A 401 or 403 refresh clears remoteConfig before it sets the error state. The served flag is now applied only while the config is authenticated when the change settles, so that clear no longer drops the arm. The state watcher stays synchronous for account switches.
The store and dialog tests read the shared typed telemetry mock instead of local untyped factories. The widget test checks that Expand reports the dialog arm to the experiment store, so it no longer sets remote config across the widget boundary. The registry dispatch test makes one assertion over every provider instead of looping.
b783c14 to
74ae395
Compare
|
Rebased onto main to clear a conflict in #21460. |
dante01yoon
left a comment
There was a problem hiding this comment.
Re-approving. The force-push dismissed my earlier approval, but nothing in the PR changed.
I checked this myself: git range-diff 13a1364fd3..bcc6cacef9 a896198043..74ae3950da shows all 8 commits as = (identical) to the head I approved. Comparing the PR-only diff before and after the rebase, only blob indexes and hunk offsets differ; every added or removed line is the same. There's no new discussion apart from bot reports, and all checks on 74ae3950da pass. My earlier review still stands.
dante01yoon
left a comment
There was a problem hiding this comment.
Thanks, the experiment plumbing is careful. Assignment is read only from the server-served /features value (the store never re-derives or overrides it, apart from the explicit QA overrides), unknown values fall back to control without attribution, and exposure/opened/closed fire once per action (the reportedExposure guard and hasReportedEnd guard, with pagehide listener removed on close). The control path only adds telemetry, so the dialog itself is unchanged. Stability per user across sessions rests on Cloud/PostHog assigning the variant, which is the right place for it.
One blocking item on the contract:
- issue:
prompt-editor-surfaceis a server response field declared by hand (see inline).
Validation: read-only review of the diff and PR description; I did not run the test suites (CI checks show no failures).
| // TurnstileMode — that resolver is the single narrowing boundary. | ||
| signup_turnstile?: string | ||
| /** Raw PostHog variant; read it through `usePromptEditorExperimentStore`. */ | ||
| 'prompt-editor-surface'?: string |
There was a problem hiding this comment.
issue: prompt-editor-surface is a field of Cloud's /features response, not a frontend-only extension, so declaring it here as a raw string is a hand-declared response type that is not backed by GetFeaturesResponses from @comfyorg/ingest-types. The PR description confirms the backend change is not filed yet. Because nothing checks this key against the OpenAPI schema, a rename or a different value shape on the Cloud side would silently fall through isPromptEditorSurfaceVariant to control and the experiment would run with no exposures and no error. Could we follow the contract-first flow: add prompt-editor-surface to the Cloud OpenAPI schema, regenerate ingest-types, and have RemoteConfig pick it up from the generated type (dropping this local field)? If the experiment has to ship first, please tell us why and where the follow-up to remove this field is tracked.
…og (#21460) ## Summary A multiline text widget on a Vue node now has a title rail above its text. The rail holds the widget label, a character count, a copy button and an expand button. The count and buttons show on hover only. Expand opens a larger, maximizable editor dialog that is easier to read. The editor is live, with no Save button. Each keystroke writes to the widget, and closing the dialog leaves the same text in the node. Closes [DES-1268](https://linear.app/comfyorg/issue/DES-1268) This is the control arm of an A/B test against a prompt panel in the right side panel. #21860 adds the experiment and its events, and #21862 adds the panel arm. The sidebar tab in #21555 is no longer part of the plan. - The dialog is the shared `GlobalDialog`, opened with `dialogStore.showDialog` at size `lg` (768px), `flush` and `maximizable`. A small header component sets the title in 14px medium text at 80% white. It uses that dialog's close button, maximize toggle and layering. `showLayoutDialog` is headless, so it has no header for these controls. - The title names the widget and the node, for example "text · CLIP Text Encode (Prompt)". It uses the widget label when there is one. The canvas and the side panel pass in the title of the node that owns the widget. The dialog does not look the node up by ID, because a node in another graph can have the same ID. - The editor is `ui/textarea/Textarea.vue`, set for reading: Inter at 15px with 24px line height. It has no box and no focus ring: the text sits on the dialog surface under a hairline below the header, and the caret shows focus. The text box is 600px tall, with 40px padding above and below the text. Side padding centres a 34em column (about 68 characters per line), so the maximized view keeps the same line length and only grows taller. On a window too short for the 85vh dialog limit, the box shrinks (to 160px at least), so only the text scrolls, not the dialog body. It gets focus on open, with the caret at the start, so a long prompt opens at the top. The size is fixed and does not follow `Comfy.TextareaWidget.FontSize`, which tunes the small box on the node. - Edits go through the widget's own `v-model`. The node, the right side panel and app mode update the same way as when you type in place. A promoted widget writes through its `WidgetId`-bound update handler. - When the dialog closes after an edit, it calls `captureCanvasState()` one time, in `onRemoved`, which runs on every close path, and then `updateModified()`. One Ctrl+Z on the canvas then reverts the whole edit, and text typed back to the original leaves the workflow clean. The exception is a checkpoint made during the session, such as queueing a prompt or saving. The edit then splits at that point, and a seed that changed at queue time keeps its own undo step. - While the dialog is open, each edit calls the new `ChangeTracker.markModified()`. It sets `isModified` and sends `graphChanged` with the committed state at once. It does not serialize the canvas or move the undo point, so a keystroke stays cheap on a large graph. Draft persistence then schedules its own write, and its page-hide flush keeps the text through a reload or a crash in the middle of an edit. - The rail is 24px tall and sits inside the field, above the textarea. The textarea scrolls below it, so the scrollbar starts under the rail and never runs under the buttons. The buttons are 20px ghost buttons, 12px in from the right edge, which lines the icon up with the end of the text column. This replaces the floating chips and the fade layers behind them. The field background moved from the textarea to a wrapper, so the rail and the text share it. Willie picked this layout from three options on a design canvas. - Copy is on every text widget now, not only read-only ones. A successful copy shows no toast: the button turns into a check labelled "Copied" for 2 seconds. A failed copy still shows the error toast. The count uses the locale's number format and plural rules, for example "6,615 chars". In the side panel and app mode the label stays hidden as before, because the panel shows its own, so the rail holds only the count and the buttons. - The textarea keeps main's overflow policy: `overflow: hidden` at rest, and scrollable on hover or focus. I tried an always-scrollable textarea to stop a slight text shift on hover at a fractional zoom. It gave each overflowing prompt a compositor layer: with 48 long prompts, panning cost 6.8x the GPU-process CPU of main. The shift is also on main, and it stays for now. The measurements are in the review reply. - A text widget can hold `null`, for example on a node the Agent adds. The widget reads it as empty text for the count, copy and Expand. - The count and buttons appear when the pointer is over the widget, not when the textarea only has focus. On a touch screen (`pointer: coarse`) they always show, because touch never matches hover. - The dialog binds the widget text through a getter, with no second copy, and follows writes made elsewhere while it is open, for example an execution that updates a read-only output. The caret, the selection with its direction, and the scroll position stay where they were. If the text before the selection end changed, the selection collapses. Read-only also follows the widget live. Tab from the textarea still reaches the buttons and shows them. - During an IME composition, the person typing wins: a write made elsewhere does not move the caret, and the composed text replaces it when the composition ends. - The dialog textarea gets the widget's attributes (`maxlength`, `placeholder` and the other widget options) through a getter, so a limit that changes while it is open applies at once. It does not get `disabled`: the live read-only getter locks a disabled widget, and its text stays selectable. - `GlobalDialog` no longer closes on an Escape that cancels an IME composition: `isComposing`, or `keyCode` 229 for Safari, which ends the composition before the keydown. The check is `onRekaEscapeKeyDown` in `dialogDismissGuards.ts` and applies to every dialog. - A linked input shows no button. A read-only widget opens a read-only editor, and its text stays selectable. - The dialog closes when its widget unmounts, for example when the node is deleted or the graph changes. Vue drops emits from an unmounted component, so the dialog must not outlive the widget. Changes from the brief: - There is no right-click menu item. Willie asked to drop the classic canvas path. That removed about 210 lines, and also the node-removal and graph-change listeners that only the menu path needed. - Known gap: the right side panel does not give `linkedUpstream` to its widgets. A linked textarea in that panel therefore shows the button and opens read-only. The fix belongs in `WidgetItem.vue`, but it also changes the curve, range and image-crop widgets in that panel. I left it out of scope. ## Look at this hardest `src/scripts/changeTracker.ts`: `markModified()` is new. It sets `isModified` and sends `graphChanged` with `activeState`, the committed state, as `updateModified()` does. It does not read the canvas or touch the undo queue. The listeners that read the payload only count its nodes, and an edit inside a widget does not change them. Draft persistence and autosave serialize the canvas themselves on their own debounce. The global `mouseup` listener now skips its capture while the editor is open. Without this, a click inside the editor records an extra undo step in the middle of an edit, and one Ctrl+Z no longer reverts the whole edit. The e2e test fails without this line. The `promptQueued` capture still runs while the dialog is open, so a seed that changes at queue time keeps its own undo step. ## Verification - `pnpm test:unit` on `src/renderer/extensions/vueNodes`, `src/renderer/extensions/textEditor`, `src/components/rightSidePanel`, `src/components/builder` and `useCanvasInteractions.test.ts`: 1,670 passed in 148 files. `WidgetTextarea.test.ts` covers copy on editable and read-only widgets, the copied state and its reset after 2 seconds (the test fails without the state), the count at 0, 1 and 6,644 characters, and the count updating while you type. I removed each guarded behavior one at a time (undo capture, linked check, unmount close, mouseup skip), and the matching test failed each time. - The pre-commit hook (oxfmt, oxlint, ESLint, stylelint, `typecheck:app`) passed on the rail commit. `pnpm typecheck:browser` and `pnpm deps:audit` passed on the earlier commits. - `textEditorDialog.spec.ts` (new, `@vue-nodes`): 2 of 2 pass. The second test opens a 60-line prompt and checks that the editor starts at `scrollTop` 0. With the old caret-at-end placement it reads 1001 and fails. It also checks that the actions stay hidden while the textarea has focus but no hover. Tab from the textarea focuses Expand and shows the group, and Enter opens the dialog (checked in the browser). With the `mouseup` skip removed, it fails with `Received: "text, watermark, at "`. All specs in `browser_tests/tests/vueNodes/widgets/text/`: 10 of 11 pass. `editable-widget-hover-color.png` fails as expected, because the old chip is now the rail. That baseline needs `/update-playwright`. - Manual, in the real app: Ctrl+Up in the editor gives `red (cat:1.05)` in the editor and on the node. Ctrl+Enter queued 0 prompts. Esc, the close button and a backdrop click all close the dialog. The browser's own undo works inside the editor. - Dialog size, measured in the browser: at 1440×900 the text box is 764×598px with 40px top and 128px side padding. At 1280×700 it shrinks to 535px, and the dialog body does not scroll in either case. Maximized at 1440×900 it is 1420×824px with 456px side padding. - The first CI run after the rebase onto main found a crash: the count read `null.length` on an Agent-added node, which broke 4 Agent e2e tests. A unit test now covers a `null` value. Against a local cloud build served like CI, 28 of 30 Agent tests pass. The other 2 are screenshot comparisons: one is the expected rail change, and the other passes in CI. - Rail, measured in the browser at canvas zoom 0.91: the expand button's right edge is 10.9px (12px unscaled) from the field edge, and the textarea starts 21.8px (24px) below the top of the field. With a macOS overlay scrollbar, the thumb starts below the rail. - Setup: my own ComfyUI backend with `--multi-user` and the devtools nodes on port 8190, and this branch's dev server on port 5190. I ran Playwright on Node 26.12.0, because the repo needs Node 26. Second review round: - `pnpm test:unit` on `changeTracker.test.ts`, `textEditorDialog.test.ts` and `WidgetTextarea.test.ts`: 176 passed. I removed each new fix and its test failed: the modified refresh on edit, the refresh moving the undo point, the IME guard, the forwarded attributes (dialog and widget) and the owner's title. - The tracker tests that call `init()` now redirect the window and document listeners and spy on the patched prototypes, so they no longer leak a listener into later tests. - `browser_tests/tests/vueNodes/widgets/text/`: all pass headless against my own backend and dev server, twice for the dialog spec, apart from a stale local macOS hover baseline. `textEditorDialog.spec.ts` now captures `text-editor-dialog.png`. The Linux baseline comes from the CI update. - The Russian count uses `{count} симв.`, because vue-i18n has no Russian plural rule here and gave `2 символов`. - Third review round: `markModified` replaced the debounced refresh, and the attributes became a getter. The tests that fail when each fix is removed: no mark on edit, a mark that reads the canvas, no recheck on close, an attributes snapshot, a forwarded `disabled`, and each refresh guard. `pnpm test:unit` on the three files: 180 passed. The text e2e specs pass headless. - Performance: base against head with 48 and 96 overflowing prompts, headless on an M5 Pro, 12 counterbalanced runs per arm. Frame times did not change, but the always-scrollable textarea raised composited layers from 17 to 251 and GPU-process CPU while panning from 87 to 589 ms/s. Restoring main's overflow policy brought both back to main's numbers, so this PR keeps main's policy. ## Screenshots | | | | --- | --- | | Rail at rest |  | | Rail on hover, focused and scrolled |  | | Dialog |  | | Dialog maximized |  | | Right side panel (the panel shows the label) |  | | App mode |  | The app mode capture predates the rail. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Summary
This PR adds the arm assignment and the analytics events for the A/B test of the expanded prompt editor: the dialog (#21460) against the prompt panel (#21862). It changes nothing a user sees. Every user keeps the dialog until the panel arm merges and Cloud serves an arm.
Part of DES-1268. Stacked on #21460.
/featuresmust returnprompt-editor-surface: 'control' | 'panel', split 50/50 by a PostHog experiment. Until that key is in the OpenAPI schema,RemoteConfigdeclares it locally as a raw string. Wheningest-typesregenerates with it, the local field can go.usePromptEditorExperimentStorereads the arm the same way as the Agent starter prompt experiment:controluntil the authenticated config loads. It changes only when that config loads again or is cleared, so a failed refresh keeps the arm.control, and its events carry no$feature/prompt-editor-surface, so the control arm only counts users PostHog assigned.?ff=prompt-editor-surface:panel(staff on Cloud) andff:(dev builds) set the arm, but events are then not attributed to the experiment. The override is checked again for each account.app:prompt_editor_exposure, at the first Expand, and only for the arm that rendered. It is sent once per arm per account on a tab, and only once telemetry is installed.app:prompt_editor_opened, withsurface(dialogorpanel) andtrigger(expand_buttonorfocus_view).app:prompt_editor_closed, withend_reason,duration_ms,input_countandnode_switch_count.input_countcounts input events, not characters. A session still open when the page hides (tab closed or reloaded) ends withend_reason: 'pagehide'and is sent bysendBeacon, asagent_panel_closeddoes. Without it, the longest sessions would be missing, more so in the panel arm, which stays open.$feature/prompt-editor-surfaceis set by hand on each event, and only when the session's surface matches the served arm: a dialog session forcontrol, a panel or focus view session forpanel. A panel-arm user who gets the dialog (before feat: add the prompt panel arm of the prompt editor experiment #21862, or where the panel cannot open) is not counted as panel usage.Look at this hardest
Exposure fires at the first Expand click, not on page load. The two arms look the same until that click, so a user who never clicks Expand is not in the experiment. For the same reason, the Expand click rate cannot differ between arms. Compare repeat opens,
input_count,duration_msandnode_switch_countinstead.Verification
pnpm test:unit:promptEditorExperimentStore.test.ts(17): arm resolution, attribution, exposure once and only for the rendered arm, a failed refresh, an account switch on the same tab, and the QA override.textEditorDialog.test.ts: opened and closed events for both triggers, and a page hide that ends the session once.WidgetTextarea.test.ts: Expand reports control exposure.TelemetryRegistry,PostHogTelemetryProvider(including thesendBeaconpath) andHostTelemetrySink.typecheck:app) passed.