Repository navigation
[backport core/1.58] FE-1908 fix(billing): retry top-up Pay after setting a default card - #21799
Conversation
…21694) C-05 on testcloud: after Set a default card, the top-up dialog stays on the no-card refusal. Billing charges a re-sent Pay once Stripe has the new default card. `GET /api/billing/payment-methods` is embedded-checkout-only and returns `FEATURE_DISABLED` on testcloud, so that read cannot tell the dialog the card is there. On return from the card portal the dialog re-read saved payment methods and cleared the refusal only when that list contained a default. The read does not succeed on testcloud, so Pay was never sent again. On return, skip payment methods and send Pay again for the same amount. Each legacy attempt now carries a new idempotency key; the SDK rail already mints one per checkout. A completed response uses the existing success path. `NO_PAYMENT_METHOD` leaves the refusal in place, without a purchase-error toast, and a later return tries again. Not verified in Ali's session. Placeholder until this is on testcloud. | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Retry Pay after the card portal | FE-1908 | **this PR** | in review | ```mermaid graph LR c05["FE-1908 retry Pay after the card portal"] style c05 fill:#f9f,stroke:#333 ```
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-25T21:50:16.342Z",
"gitSha": "0b97650bc8d8247464296e2eac04d208eb460575",
"branch": "dante/21694-backport-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.12999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.408,
"layouts": 9,
"layoutDurationMs": 2.2329999999999997,
"taskDurationMs": 493.79599999999994,
"heapDeltaBytes": -327620,
"heapUsedBytes": 90219504,
"domNodes": -200,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 8.956999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.4540000000247,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.3790000000000004,
"layouts": 10,
"layoutDurationMs": 2.295,
"taskDurationMs": 481.72700000000003,
"heapDeltaBytes": -20447168,
"heapUsedBytes": 84215924,
"domNodes": -200,
"jsHeapTotalBytes": 1904640,
"scriptDurationMs": 8.776000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.2589999999882,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.688,
"layouts": 9,
"layoutDurationMs": 2.3800000000000003,
"taskDurationMs": 664.475,
"heapDeltaBytes": 2296556,
"heapUsedBytes": 92409984,
"domNodes": -200,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 127.576,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.8320000000153,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.65,
"layouts": 10,
"layoutDurationMs": 2.234,
"taskDurationMs": 664.5110000000001,
"heapDeltaBytes": 2795308,
"heapUsedBytes": 93080848,
"domNodes": -200,
"jsHeapTotalBytes": 1630208,
"scriptDurationMs": 125.61,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82941176470588,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.3099999999595,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.281,
"layouts": 12,
"layoutDurationMs": 2.555,
"taskDurationMs": 243.389,
"heapDeltaBytes": -1306204,
"heapUsedBytes": 88836408,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.099,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.5559999999832,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.541,
"layouts": 11,
"layoutDurationMs": 2.517,
"taskDurationMs": 327.94500000000005,
"heapDeltaBytes": -390552,
"heapUsedBytes": 90667984,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.648,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 591.3209999999935,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0300000000000002,
"layouts": 10,
"layoutDurationMs": 2.613,
"taskDurationMs": 413.115,
"heapDeltaBytes": 672284,
"heapUsedBytes": 90395804,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 141.72500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 593.7040000000025,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.831,
"layouts": 10,
"layoutDurationMs": 2.4010000000000002,
"taskDurationMs": 412.34000000000003,
"heapDeltaBytes": 4229912,
"heapUsedBytes": 94035244,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 137.31500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1038.0550000000142,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.2539999999999,
"heapDeltaBytes": -15682704,
"heapUsedBytes": 102065264,
"domNodes": -230,
"jsHeapTotalBytes": 14221312,
"scriptDurationMs": 48.959,
"eventListeners": -168,
"totalBlockingTimeMs": 372,
"frameDurationMs": 29.519999999999996,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1062.8559999999538,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 746.5560000000002,
"heapDeltaBytes": -3291532,
"heapUsedBytes": 102417564,
"domNodes": -230,
"jsHeapTotalBytes": 8286208,
"scriptDurationMs": 57.897000000000006,
"eventListeners": -168,
"totalBlockingTimeMs": 386,
"frameDurationMs": 28.82702702702701,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.7110000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.2389999999999,
"heapDeltaBytes": -2776576,
"heapUsedBytes": 98068824,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.983,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 789.8569999999836,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.75199999999984,
"heapDeltaBytes": -4939544,
"heapUsedBytes": 97284468,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.26,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 23.04117647058825,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7317.983999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6410.152,
"heapDeltaBytes": 34635116,
"heapUsedBytes": 138451500,
"domNodes": -276,
"jsHeapTotalBytes": 22601728,
"scriptDurationMs": 5103.483000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 83,
"frameDurationMs": 25.228965517241377,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7258.481999999958,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06999999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6435.758,
"heapDeltaBytes": 36676592,
"heapUsedBytes": 140213156,
"domNodes": -276,
"jsHeapTotalBytes": 24961024,
"scriptDurationMs": 4929.777999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 77,
"frameDurationMs": 24.49256756756757,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7508.721000000009,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5599999999999997,
"layouts": 2,
"layoutDurationMs": 0.46199999999999974,
"taskDurationMs": 6710.909,
"heapDeltaBytes": 38426544,
"heapUsedBytes": 143739140,
"domNodes": -296,
"jsHeapTotalBytes": 17883136,
"scriptDurationMs": 5174.233,
"eventListeners": -130,
"totalBlockingTimeMs": 136,
"frameDurationMs": 24.75115511551155,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6847.481000000016,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06999999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6087.1140000000005,
"heapDeltaBytes": 25766136,
"heapUsedBytes": 135408504,
"domNodes": -296,
"jsHeapTotalBytes": 18669568,
"scriptDurationMs": 4836.529,
"eventListeners": -130,
"totalBlockingTimeMs": 63,
"frameDurationMs": 24.60794223826715,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 163.67199999999116,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.757000000000001,
"layouts": 11,
"layoutDurationMs": 2.805,
"taskDurationMs": 128.06,
"heapDeltaBytes": 13273128,
"heapUsedBytes": 118631176,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.745999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837499999999977,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 182.0369999999798,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.965000000000002,
"layouts": 12,
"layoutDurationMs": 3.2019999999999995,
"taskDurationMs": 133.098,
"heapDeltaBytes": 13341468,
"heapUsedBytes": 118675900,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.272,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2040.2070000000094,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.361,
"layouts": 9,
"layoutDurationMs": 2.0080000000000005,
"taskDurationMs": 559.438,
"heapDeltaBytes": 387292,
"heapUsedBytes": 110857540,
"domNodes": -296,
"jsHeapTotalBytes": -2039808,
"scriptDurationMs": 29.986000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2023.7760000000549,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.638,
"layouts": 10,
"layoutDurationMs": 2.306,
"taskDurationMs": 558.013,
"heapDeltaBytes": -18271156,
"heapUsedBytes": 104282984,
"domNodes": -296,
"jsHeapTotalBytes": -2170880,
"scriptDurationMs": 29.434,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2388.6959999999817,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.065,
"layouts": 7,
"layoutDurationMs": 1.623,
"taskDurationMs": 1406.222,
"heapDeltaBytes": 1641140,
"heapUsedBytes": 113420024,
"domNodes": -296,
"jsHeapTotalBytes": -503808,
"scriptDurationMs": 680.549,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666433566433565,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2787.8560000000334,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.472000000000001,
"layouts": 8,
"layoutDurationMs": 1.997,
"taskDurationMs": 1490.0689999999997,
"heapDeltaBytes": -35232812,
"heapUsedBytes": 88464496,
"domNodes": -296,
"jsHeapTotalBytes": 462848,
"scriptDurationMs": 684.84,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666467065868265,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3261.8929999999864,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.818999999999999,
"layouts": 65,
"layoutDurationMs": 10.456,
"taskDurationMs": 1321.637,
"heapDeltaBytes": -16844352,
"heapUsedBytes": 95995600,
"domNodes": -272,
"jsHeapTotalBytes": -73728,
"scriptDurationMs": 621.093,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75179487179487,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3520.535999999993,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.374,
"layouts": 66,
"layoutDurationMs": 10.908,
"taskDurationMs": 1544.0299999999997,
"heapDeltaBytes": -24784152,
"heapUsedBytes": 90841628,
"domNodes": -272,
"jsHeapTotalBytes": -1277952,
"scriptDurationMs": 648.999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665876777251185,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2418.231999999989,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.628,
"layouts": 6,
"layoutDurationMs": 1.477,
"taskDurationMs": 1606.8700000000001,
"heapDeltaBytes": -11726560,
"heapUsedBytes": 102454292,
"domNodes": 0,
"jsHeapTotalBytes": 6819840,
"scriptDurationMs": 775.47,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.898601398601397,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2804.2219999999816,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.001,
"layouts": 7,
"layoutDurationMs": 1.807,
"taskDurationMs": 1714.772,
"heapDeltaBytes": -11926228,
"heapUsedBytes": 102496072,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 825.129,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.764880952380953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2037.6830000000155,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5450000000000004,
"layouts": 9,
"layoutDurationMs": 1.883,
"taskDurationMs": 415.472,
"heapDeltaBytes": -16376484,
"heapUsedBytes": 99140000,
"domNodes": -296,
"jsHeapTotalBytes": -1683456,
"scriptDurationMs": 29.482000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2053.5409999999956,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8340000000000005,
"layouts": 9,
"layoutDurationMs": 2.4409999999999994,
"taskDurationMs": 421.121,
"heapDeltaBytes": -31798944,
"heapUsedBytes": 87983340,
"domNodes": -296,
"jsHeapTotalBytes": -2527232,
"scriptDurationMs": 29.135,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.3529999999946,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.141,
"layouts": 10,
"layoutDurationMs": 2.215,
"taskDurationMs": 411.505,
"heapDeltaBytes": 927988,
"heapUsedBytes": 102567504,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 121.92900000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.5829999999983,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.228999999999999,
"layouts": 10,
"layoutDurationMs": 2.678,
"taskDurationMs": 378.085,
"heapDeltaBytes": 3187528,
"heapUsedBytes": 112455892,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 123.591,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2022.5689999999759,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3699999999999997,
"layouts": 10,
"layoutDurationMs": 2.264,
"taskDurationMs": 480.93699999999995,
"heapDeltaBytes": -18944916,
"heapUsedBytes": 88552616,
"domNodes": -218,
"jsHeapTotalBytes": 1642496,
"scriptDurationMs": 7.816999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.2329999999906,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.292,
"layouts": 9,
"layoutDurationMs": 2.006,
"taskDurationMs": 483.591,
"heapDeltaBytes": 8676920,
"heapUsedBytes": 99054076,
"domNodes": -198,
"jsHeapTotalBytes": 1892352,
"scriptDurationMs": 8.453,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.8959999999904,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.405000000000001,
"layouts": 9,
"layoutDurationMs": 2.0439999999999996,
"taskDurationMs": 647.713,
"heapDeltaBytes": -689920,
"heapUsedBytes": 90137372,
"domNodes": -210,
"jsHeapTotalBytes": 2416640,
"scriptDurationMs": 97.61500000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1943.0879999999888,
"styleRecalcs": 85,
"styleRecalcDurationMs": 13.129000000000001,
"layouts": 10,
"layoutDurationMs": 2.216,
"taskDurationMs": 907.065,
"heapDeltaBytes": -6270088,
"heapUsedBytes": 96345684,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 92.01599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.1809999999928,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.329,
"layouts": 5,
"layoutDurationMs": 11.934000000000001,
"taskDurationMs": 809.5949999999998,
"heapDeltaBytes": 35686940,
"heapUsedBytes": 135149076,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 25.295000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 96,
"frameDurationMs": 18.691891891891903,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8195.517999999993,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.494,
"layouts": 8,
"layoutDurationMs": 1.8809999999999998,
"taskDurationMs": 4276.137000000001,
"heapDeltaBytes": 3517032,
"heapUsedBytes": 114584320,
"domNodes": -297,
"jsHeapTotalBytes": 20480,
"scriptDurationMs": 2201.425,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.700000000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8193.286999999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.248,
"layouts": 9,
"layoutDurationMs": 2.0159999999999996,
"taskDurationMs": 4209.788,
"heapDeltaBytes": -3226448,
"heapUsedBytes": 113747124,
"domNodes": -297,
"jsHeapTotalBytes": -204800,
"scriptDurationMs": 2140.828,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665987780040734,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18872.896999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18445.486,
"heapDeltaBytes": -12668456,
"heapUsedBytes": 293582420,
"domNodes": -3344,
"jsHeapTotalBytes": 23580672,
"scriptDurationMs": 252.037,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.21461267605634,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-large-graph-idle",
"durationMs": 14342.787000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13682.983999999999,
"heapDeltaBytes": -29291744,
"heapUsedBytes": 299990372,
"domNodes": -3344,
"jsHeapTotalBytes": 26988544,
"scriptDurationMs": 201.46500000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.71577060931899,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 23126.630000000034,
"styleRecalcs": 178,
"styleRecalcDurationMs": 19.496000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22799.573000000004,
"heapDeltaBytes": -954140,
"heapUsedBytes": 305079948,
"domNodes": -3344,
"jsHeapTotalBytes": 10665984,
"scriptDurationMs": 742.8509999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.51334586466165,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 16981.758000000013,
"styleRecalcs": 115,
"styleRecalcDurationMs": 12.718000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16553.93,
"heapDeltaBytes": -6026828,
"heapUsedBytes": 299431508,
"domNodes": -3344,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 670.614,
"eventListeners": -651,
"totalBlockingTimeMs": 5,
"frameDurationMs": 31.160733944954124,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 6869.13199999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.132,
"layouts": 20,
"layoutDurationMs": 24.494000000000003,
"taskDurationMs": 6757.068,
"heapDeltaBytes": -45347440,
"heapUsedBytes": 278846272,
"domNodes": -3344,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 120.45199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 27,
"frameDurationMs": 39.013068181818184,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6965.733,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.237,
"layouts": 20,
"layoutDurationMs": 21.093,
"taskDurationMs": 6860.592,
"heapDeltaBytes": -22269644,
"heapUsedBytes": 278437524,
"domNodes": -3344,
"jsHeapTotalBytes": 21745664,
"scriptDurationMs": 102.946,
"eventListeners": -653,
"totalBlockingTimeMs": 9,
"frameDurationMs": 41.36785714285715,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6777.164999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6364.810000000002,
"heapDeltaBytes": -8637444,
"heapUsedBytes": 299971164,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 87.416,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.838383838383837,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9407.240999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9190.126,
"heapDeltaBytes": -18643432,
"heapUsedBytes": 271004936,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 124.33899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.94275092936804,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 91.53800000001411,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.574999999999999,
"layouts": 6,
"layoutDurationMs": 2.117,
"taskDurationMs": 57.728,
"heapDeltaBytes": 4737300,
"heapUsedBytes": 95421488,
"domNodes": 116,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.1690000000000005,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 79.34799999998177,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.321000000000001,
"layouts": 5,
"layoutDurationMs": 1.891,
"taskDurationMs": 51.56199999999998,
"heapDeltaBytes": 4609040,
"heapUsedBytes": 94745496,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.276000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 268.6310000000276,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.622,
"layouts": 76,
"layoutDurationMs": 12.319,
"taskDurationMs": 237.107,
"heapDeltaBytes": -15035848,
"heapUsedBytes": 76484640,
"domNodes": 4,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 108.666,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 290.25400000000445,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.627,
"layouts": 76,
"layoutDurationMs": 11.825000000000001,
"taskDurationMs": 249.668,
"heapDeltaBytes": 10247536,
"heapUsedBytes": 99559356,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 117.018,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670588235294098,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 431.41800000000785,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5939999999999999,
"layouts": 76,
"layoutDurationMs": 12.486,
"taskDurationMs": 385.99100000000004,
"heapDeltaBytes": -4898636,
"heapUsedBytes": 105248372,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.818,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538459,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 332.62999999999465,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.848,
"layouts": 76,
"layoutDurationMs": 10.674,
"taskDurationMs": 297.03200000000004,
"heapDeltaBytes": -1345848,
"heapUsedBytes": 115352896,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 109.227,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999964,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2966 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since aa3e59e49994c8d4b00ad1f4df1b33334d25a041
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (116)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.58 #21799 +/- ##
=============================================
- Coverage 84.49% 84.48% -0.01%
=============================================
Files 2931 2931
Lines 160913 160946 +33
Branches 41402 41406 +4
=============================================
+ Hits 135963 135977 +14
- Misses 24559 24578 +19
Partials 391 391
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 🚀 New features to boost your workflow:
|
core/1.58 gained checkoutScope after this backport was cut. A workspace change now aborts that checkout and stops the Pay retry.
There was a problem hiding this comment.
Backport fidelity is sound at this head, but I cannot approve while the real coverage-packaging failure is red.
- An exact mechanical comparison against PR 21694 has identical sorted added and removed lines across the same seven files. No package manifest changed.
upload-e2e-coverage / packagegenuinely ran its packaging step and exited 1 because LCOV found duplicateinner_clickedfunction records inLGraphCanvas.ts. This is not cancellation debris.- The repair landed on
mainin PR 17623, butcore/1.58still lacks the--ignore-errors inconsistent,corruptmerge option. PR 21840 is now test-only, so merging it alone cannot unblock this backport.
Full context for agent readers
Please backport the minimal coverage-packaging script change from PR 17623 to core/1.58, then rerun this backport's matrix. Acceptance: upload-e2e-coverage / package combines all 16 shards under LCOV 2.4 without dropping valid line coverage, and the full matrix settles green. Please re-request review after that passes.
Why
PR 21694 is on main and on cloud/1.58 (PR 21734). The core/1.58 bot cherry-pick conflicted, so the same Pay retry is missing from this branch.
Root cause
The squash assumes main already watches
checkoutScopeand aborts it when the workspace changes. core/1.58 never had that hosted-checkout abort scope. The conflict is the unmount block inTopUpCreditsDialogContentWorkspace.vue.How
Cherry-pick PR 21694 onto core/1.58. On return from Set a default card, skip
GET /api/billing/payment-methodsand send Pay again for the same amount. Stop that retry when the workspace generation changes or the dialog unmounts.This branch has no
checkoutScopeto abort, so the watch only stops the Pay retry. It does not invent a hosted-checkout abort.AS IS / TO BE
AS IS: after Set a default card, returning to the dialog leaves the no-card refusal up. Pay is not sent again.
TO BE: return sends Pay for the same amount with a new idempotency key. 200 uses the existing success path.
NO_PAYMENT_METHODkeeps the refusal and does not toast a purchase error. Leaving the workspace or closing the dialog stops the retry.Plan position