Repository navigation
[backport core/1.57] fix(agent): move an agent-inserted workflow clear of the nodes it lands on (#21527) - #21628
Conversation
…ds on (#21527) When the agent inserts a workflow into a tab that already has nodes, the inserted nodes can land on top of the existing graph ([PM-2232](https://linear.app/comfyorg/issue/PM-2232/workflow-inserted-into-an-existing-tab-lands-on-top-of-the-existing)). `get_template` commits as one `insert_workflow` op that carries the template's baked-in coordinates, and neither cloud nor comfy-multi-player translates them. The follower's placement (ADR-CRDT-PLACEMENT-0035, from [PM-1142](https://linear.app/comfyorg/issue/PM-1142)) only moved a batch that landed far away and offscreen, so a batch landing on the user's nodes kept its overlapping position. The Z-Image template spans x −420 to 1350, the same region as the default workflow. Now, in a live frame written by an agent turn, a created batch with any node that intersects an existing node moves beside the existing content by the same single offset. The batch's internal layout is unchanged. Catch-up frames, tab-return applies and human writes are excluded, so a node a human pasted over another is not moved when the follower resubscribes (`agentPastedNodeOrphanedOnRetarget.spec.ts` catches that if the scope is dropped). Behavior change to an existing pin: `agentDuplicateInsertOpaqueWidgetWrite.spec.ts` asserted that two inserts of the same template render pixel-identically on top of each other. The second copy now lands beside the first. Its op fixture also used `agent:e2e`, which fails the actor grammar and is dropped by the follower; it now uses `agent:<thread>:<turn>` as cloud stamps it. Known limitation, recorded in the ADR: an agent insert that lands while its tab is inactive is applied on tab return without collision placement, because the collected changes do not record their writer. - New black-box case `browser_tests/tests/agent/agentInsertWorkflowOverlap.spec.ts`: a canvas with three nodes, then one `insert_workflow` carrying the Z-Image template's node rects. Fails on `main` (`inserted "Template note" at (-420, 200) overlaps existing "Existing node A" at (0, 180)`), passes here; also asserts the template's relative layout is preserved. - `agentDuplicateInsertOpaqueWidgetWrite.spec.ts` side-by-side assertion fails on `main`, passes here. - Unit: `batchPlacement.test.ts` (collision cases, hull-interior non-collision stays put) and `liveGraphApplier.test.ts` (a live agent batch moves, a replayed one does not). Both fail on `main`. - `pnpm exec vitest run src/workbench/extensions/agent`: 177 files, 4027 passed. - Full `browser_tests/tests/agent` on the `cloud` project locally: 352 of 355 passed. The three failures (two `agentConversationReplay` screenshot comparisons and `agentReplyDrafts` "keeps its run approval action live", which already passes under `test.fail`) fail identically on `main` in the same environment. - `pnpm typecheck`, `pnpm typecheck:browser`, oxlint, oxfmt clean. (cherry picked from commit bc0250c)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-22T01:34:19.400Z",
"gitSha": "8ceab9a658edd2de765497f3be59c449455d5d24",
"branch": "backport-21527-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.9550000000145,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5469999999999997,
"layouts": 10,
"layoutDurationMs": 2.6639999999999997,
"taskDurationMs": 344.976,
"heapDeltaBytes": 22151764,
"heapUsedBytes": 87837708,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.975999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.495000000049,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.301,
"layouts": 9,
"layoutDurationMs": 2.614,
"taskDurationMs": 499.514,
"heapDeltaBytes": 21656860,
"heapUsedBytes": 88052876,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 9.724999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1697.9840000000195,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.54,
"layouts": 10,
"layoutDurationMs": 2.692,
"taskDurationMs": 678.3889999999999,
"heapDeltaBytes": 15542912,
"heapUsedBytes": 81557876,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 137.64200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.6349999999247,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.099,
"layouts": 8,
"layoutDurationMs": 2.36,
"taskDurationMs": 706.397,
"heapDeltaBytes": 15134572,
"heapUsedBytes": 81871040,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 143.118,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.366999999987,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.978000000000001,
"layouts": 11,
"layoutDurationMs": 3.266,
"taskDurationMs": 384.84,
"heapDeltaBytes": 18785960,
"heapUsedBytes": 84543824,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.811000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1806.0809999999492,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.009,
"layouts": 13,
"layoutDurationMs": 3.501,
"taskDurationMs": 434.117,
"heapDeltaBytes": -4543468,
"heapUsedBytes": 69990704,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.64,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 649.1990000000101,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7270000000000003,
"layouts": 10,
"layoutDurationMs": 2.6580000000000004,
"taskDurationMs": 472.166,
"heapDeltaBytes": 1983444,
"heapUsedBytes": 77045876,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 157.808,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 611.0680000000457,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4599999999999995,
"layouts": 9,
"layoutDurationMs": 2.4550000000000005,
"taskDurationMs": 421.18799999999993,
"heapDeltaBytes": -581148,
"heapUsedBytes": 65625132,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 162.56400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1165.4950000000213,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 866.8039999999999,
"heapDeltaBytes": 820884,
"heapUsedBytes": 81063456,
"domNodes": -192,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 58.838,
"eventListeners": -106,
"totalBlockingTimeMs": 496,
"frameDurationMs": 32.405555555555566,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1179.9519999999575,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 859.6400000000001,
"heapDeltaBytes": -11190480,
"heapUsedBytes": 81529312,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 57.355000000000004,
"eventListeners": -106,
"totalBlockingTimeMs": 489,
"frameDurationMs": 31.981081081081072,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 799.6579999999653,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.08400000000046,
"heapDeltaBytes": -6412436,
"heapUsedBytes": 73118148,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 133.89999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 175,
"frameDurationMs": 23.526470588235284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 829.0000000000646,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.4100000000001,
"heapDeltaBytes": -4082296,
"heapUsedBytes": 76339580,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 130.93499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 178,
"frameDurationMs": 23.808571428571433,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9095.032000000003,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.03699999999999971,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8194.364,
"heapDeltaBytes": -16690588,
"heapUsedBytes": 82721788,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 6375.227,
"eventListeners": -68,
"totalBlockingTimeMs": 209,
"frameDurationMs": 27.913190184049082,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8959.257000000036,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.03899999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8031.234999999999,
"heapDeltaBytes": -3731504,
"heapUsedBytes": 96203928,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 6247.219,
"eventListeners": -68,
"totalBlockingTimeMs": 130,
"frameDurationMs": 27.707739938080497,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9496.732000000009,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.050000000000000565,
"layouts": 1,
"layoutDurationMs": 0.20300000000000007,
"taskDurationMs": 8534.594000000001,
"heapDeltaBytes": -10107788,
"heapUsedBytes": 83911240,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 6770.739,
"eventListeners": -68,
"totalBlockingTimeMs": 262,
"frameDurationMs": 28.13946587537092,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9388.830999999982,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.18899999999999995,
"layouts": 1,
"layoutDurationMs": 0.196,
"taskDurationMs": 8609.449,
"heapDeltaBytes": -15742044,
"heapUsedBytes": 84291004,
"domNodes": -258,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 6777.633000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 173,
"frameDurationMs": 28.99783281733746,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "large-combo-open",
"durationMs": 181.5019999999663,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.167,
"layouts": 11,
"layoutDurationMs": 3.0970000000000004,
"taskDurationMs": 148.07700000000003,
"heapDeltaBytes": -8242136,
"heapUsedBytes": 79616320,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.67,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.912500000000023,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 184.16799999999967,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.430000000000001,
"layouts": 11,
"layoutDurationMs": 3.2489999999999997,
"taskDurationMs": 145.75100000000003,
"heapDeltaBytes": -8246540,
"heapUsedBytes": 79077852,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.717,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.912500000000023,
"p95FrameDurationMs": 66.5
},
{
"name": "large-graph-idle",
"durationMs": 2056.93500000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.169,
"layouts": 8,
"layoutDurationMs": 2.162,
"taskDurationMs": 626.03,
"heapDeltaBytes": -25857464,
"heapUsedBytes": 71328184,
"domNodes": -278,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 33.559999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.1209999999328,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.255,
"layouts": 8,
"layoutDurationMs": 2.206,
"taskDurationMs": 608.9069999999999,
"heapDeltaBytes": -3196680,
"heapUsedBytes": 76163136,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 30.948999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2262.049999999988,
"styleRecalcs": 70,
"styleRecalcDurationMs": 5.8580000000000005,
"layouts": 9,
"layoutDurationMs": 2.0759999999999996,
"taskDurationMs": 1621.4259999999997,
"heapDeltaBytes": -30206532,
"heapUsedBytes": 67748540,
"domNodes": -258,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 755.874,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592592592593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2242.748000000006,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.519,
"layouts": 6,
"layoutDurationMs": 1.484,
"taskDurationMs": 1461.4630000000002,
"heapDeltaBytes": -11115452,
"heapUsedBytes": 68500072,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 753.7400000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.918181818181818,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3544.038999999998,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.311,
"layouts": 65,
"layoutDurationMs": 10.391000000000002,
"taskDurationMs": 1542.022,
"heapDeltaBytes": 10941700,
"heapUsedBytes": 93035932,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 725.522,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.744549763033177,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3561.239999999998,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.279,
"layouts": 65,
"layoutDurationMs": 10.61,
"taskDurationMs": 1724.1969999999997,
"heapDeltaBytes": -31823972,
"heapUsedBytes": 67631436,
"domNodes": -234,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 737.5749999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74433962264151,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2592.130999999995,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.792,
"layouts": 6,
"layoutDurationMs": 1.6150000000000002,
"taskDurationMs": 1658.163,
"heapDeltaBytes": 10619676,
"heapUsedBytes": 94076812,
"domNodes": 0,
"jsHeapTotalBytes": 4349952,
"scriptDurationMs": 896.336,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.883660130718955,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2905.462000000057,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.568,
"layouts": 5,
"layoutDurationMs": 1.0599999999999998,
"taskDurationMs": 1891.0459999999998,
"heapDeltaBytes": 7139976,
"heapUsedBytes": 84778396,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 909.267,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76300578034682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2049.5769999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0349999999999997,
"layouts": 8,
"layoutDurationMs": 2.516,
"taskDurationMs": 468.26200000000006,
"heapDeltaBytes": -1991200,
"heapUsedBytes": 79625116,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 28.893999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2031.3239999999269,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6830000000000005,
"layouts": 7,
"layoutDurationMs": 1.685,
"taskDurationMs": 606.951,
"heapDeltaBytes": -24808820,
"heapUsedBytes": 74136532,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 31.928000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.5799999999995,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.882000000000001,
"layouts": 10,
"layoutDurationMs": 2.469,
"taskDurationMs": 454.63699999999994,
"heapDeltaBytes": -1121592,
"heapUsedBytes": 76035164,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 136.804,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.0600000000923,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.8580000000000005,
"layouts": 10,
"layoutDurationMs": 2.653,
"taskDurationMs": 361.63800000000003,
"heapDeltaBytes": 21567224,
"heapUsedBytes": 88634556,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 137.03400000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66176470588235,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.27200000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8780000000000006,
"layouts": 11,
"layoutDurationMs": 3.109,
"taskDurationMs": 342.90700000000004,
"heapDeltaBytes": 22417604,
"heapUsedBytes": 89315892,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.967999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.4279999999571,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4300000000000006,
"layouts": 9,
"layoutDurationMs": 2.502,
"taskDurationMs": 488.98300000000006,
"heapDeltaBytes": 22412180,
"heapUsedBytes": 89815396,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.785999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.7109999999743,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.206,
"layouts": 9,
"layoutDurationMs": 2.1009999999999995,
"taskDurationMs": 737.749,
"heapDeltaBytes": 10895708,
"heapUsedBytes": 77798456,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 93.05099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.8939999999102,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.506000000000002,
"layouts": 10,
"layoutDurationMs": 2.6300000000000003,
"taskDurationMs": 652.908,
"heapDeltaBytes": 11273976,
"heapUsedBytes": 78726580,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 98.034,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.3449999999743,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.231,
"layouts": 5,
"layoutDurationMs": 13.738999999999997,
"taskDurationMs": 1003.033,
"heapDeltaBytes": 7436208,
"heapUsedBytes": 101714240,
"domNodes": 15953,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 29.396000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 148,
"frameDurationMs": 19.33066666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8341.264000000025,
"styleRecalcs": 250,
"styleRecalcDurationMs": 17.466,
"layouts": 8,
"layoutDurationMs": 2.373,
"taskDurationMs": 5748.328,
"heapDeltaBytes": -15420004,
"heapUsedBytes": 83094992,
"domNodes": -258,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 2635.493,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8290.82399999993,
"styleRecalcs": 250,
"styleRecalcDurationMs": 17.700999999999997,
"layouts": 8,
"layoutDurationMs": 2.165,
"taskDurationMs": 5964.067,
"heapDeltaBytes": -15202928,
"heapUsedBytes": 84012188,
"domNodes": -258,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 2736.933,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733131313131313,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13440.87300000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12872.582999999999,
"heapDeltaBytes": 9969732,
"heapUsedBytes": 281954088,
"domNodes": -3330,
"jsHeapTotalBytes": 13361152,
"scriptDurationMs": 211.098,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.877361563517915,
"p95FrameDurationMs": 33.5
},
{
"name": "vue-large-graph-idle",
"durationMs": 20408.274000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19783.598,
"heapDeltaBytes": -15352764,
"heapUsedBytes": 280321916,
"domNodes": -3330,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 280.81899999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.73715341959335,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 24929.577999999994,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.536999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24628.343,
"heapDeltaBytes": -22537576,
"heapUsedBytes": 268115004,
"domNodes": -3330,
"jsHeapTotalBytes": 3133440,
"scriptDurationMs": 840.344,
"eventListeners": -651,
"totalBlockingTimeMs": 8,
"frameDurationMs": 46.68951310861423,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24840.867000000002,
"styleRecalcs": 179,
"styleRecalcDurationMs": 16.294000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24574.414,
"heapDeltaBytes": -32682080,
"heapUsedBytes": 267665116,
"domNodes": -3330,
"jsHeapTotalBytes": 12046336,
"scriptDurationMs": 853.4580000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 47.66257197696737,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7261.6360000000095,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.91099999999999,
"layouts": 20,
"layoutDurationMs": 28.541999999999984,
"taskDurationMs": 7172.17,
"heapDeltaBytes": -37932580,
"heapUsedBytes": 263462728,
"domNodes": -3330,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 128.633,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.13229813664596,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7429.511000000048,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.97299999999998,
"layouts": 20,
"layoutDurationMs": 22.01800000000001,
"taskDurationMs": 7334.811,
"heapDeltaBytes": -21588812,
"heapUsedBytes": 269493416,
"domNodes": -3330,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 111.078,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.32378048780487,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10211.332000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9927.304000000002,
"heapDeltaBytes": 181840,
"heapUsedBytes": 264936240,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 132.99000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.285401459854,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10040.581999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9748.262,
"heapDeltaBytes": -15306780,
"heapUsedBytes": 251258664,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 132.21400000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.02007168458782,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 482.71199999999226,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.981,
"layouts": 12,
"layoutDurationMs": 4.901,
"taskDurationMs": 143.52200000000002,
"heapDeltaBytes": 6994960,
"heapUsedBytes": 79170728,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.064999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 111.23799999995754,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.183,
"layouts": 7,
"layoutDurationMs": 3.037,
"taskDurationMs": 82.356,
"heapDeltaBytes": -15510008,
"heapUsedBytes": 67894584,
"domNodes": 116,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 4.857,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.43333333333332,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 446.62399999992886,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.889,
"layouts": 76,
"layoutDurationMs": 15.133000000000001,
"taskDurationMs": 392.82300000000004,
"heapDeltaBytes": 10947608,
"heapUsedBytes": 100597344,
"domNodes": 4,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 182.32099999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 360.68599999998696,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.884,
"layouts": 76,
"layoutDurationMs": 13.945,
"taskDurationMs": 328.455,
"heapDeltaBytes": -14440888,
"heapUsedBytes": 80124108,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 149.701,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304317,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 514.4790000000512,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.835,
"layouts": 76,
"layoutDurationMs": 13.779,
"taskDurationMs": 481.75500000000005,
"heapDeltaBytes": 185412,
"heapUsedBytes": 122059656,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 194.858,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 473.93399999998564,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7799999999999998,
"layouts": 76,
"layoutDurationMs": 13.783999999999999,
"taskDurationMs": 444.145,
"heapDeltaBytes": -179080,
"heapUsedBytes": 118310916,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.38,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.237931034482745,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2280 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 234e7fa0fc3bffb5befa9346e0fd1629086624e8
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21628 +/- ##
=============================================
- Coverage 85.81% 85.81% -0.01%
=============================================
Files 2704 2704
Lines 151993 152004 +11
Branches 40579 40580 +1
=============================================
+ Hits 130439 130448 +9
- Misses 21166 21168 +2
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 3 |
Panel: 6/6 reviewers contributed findings.
christian-byrne
left a comment
There was a problem hiding this comment.
Backport review: faithful to the source, gates clean, merging under the release-backport grant.
Full context for agent readers
- Source: #21527, merged as
bc0250c6b3. This carrier is acherry-pick -xontocore/1.57(tip234e7fa0fc). Conflict resolutions are context-only and listed in the PR body. Applicability: both 1.57 trains carry ADR-CRDT-PLACEMENT-0035 with a byte-identicalbatchPlacement.ts, so the bug is present on this train. - Black-box proof at exact head
88842cc192: hostedplaywright-video-new-tests (cloud)ranagentInsertWorkflowOverlap.spec.tsandagentDuplicateInsertOpaqueWidgetWrite.spec.ts, 3 passed. The overlap spec was shown red on thecore/1.57parent with the same overlap message the source recorded onmain. - All 174 checks completed with success, neutral or skipped. The five required checks (
test,lint-and-format,e2e-status,website-e2e,cla-assistant) pass. - Cursor review round 1 (5 findings) re-raised design points the source author already ruled on in #21527, or cases that fall back to pre-fix behavior. Each thread has a reply with evidence. No code change, so the carrier stays identical to
main. - No human reviews or objections on this PR.
- Authority: the Agent release-backport grant covers
core/1.57(Christian, 2026-09-16; current trains per the 2026-10-10 ruling, 1.57 added 2026-10-17). This is a COMMENT, not an approval, because the authenticated account authored the PR.
…ar of the nodes it lands on (#21527) (#21627) Backport of #21527 to `cloud/1.57`. An Agent template inserted into a tab that already has nodes no longer lands on top of them. In a live agent-turn frame, a created batch that intersects an existing node moves beside the existing content by one shared offset, keeping its internal layout. Catch-up, tab-return and human frames are unchanged. Companion `core/1.57` carrier: #21628. Product code is the source change unchanged. The cherry-pick conflicted only on release-line context: a JSDoc next to the new helper, a test-mock refactor around this branch's older fixture shape, and this branch's `getWebSocket` fixture (main renamed it `getAgentSocket` in #17469). <details><summary>Full context for agent readers</summary> - Source: #21527, merged as bc0250c ([PM-2232](https://linear.app/comfyorg/issue/PM-2232/workflow-inserted-into-an-existing-tab-lands-on-top-of-the-existing)). Author and author date preserved; `-x` provenance kept. No AI co-author trailer. - Applicability: `cloud/1.57` already carries ADR-CRDT-PLACEMENT-0035 and `batchPlacement.ts` byte-identical to the source's parent, so it has the offscreen-only placement this fixes. The new black-box spec fails on this branch's product files with the same message as on `main`. - Conflict resolution, context only: - `layoutFollowerBridge.ts`: new `isLiveAgentUpdate` placed above this branch's existing `trySend` JSDoc. - `useAgentCrdtFollower.test.ts`: took the source's switch from a factory mock to `vi.mock(..., { spy: true })` + `mockImplementation` (needed so the real `isLiveAgentUpdate` export survives), without main's live-subscription counters, which this branch's tests do not use. - `agentDuplicateInsertOpaqueWidgetWrite.spec.ts`: kept this branch's inline `doc_subscribe` wait instead of the new `subscribeAgentWorkflow` helper; took the source's actor fix and side-by-side assertion. - New `agentInsertWorkflowOverlapFixture.ts` / `utils/agentInsertWorkflowOverlap.ts`: `getAgentSocket` → `getWebSocket` (this branch's agent doc frames ride `/ws`). - The `core/1.57` and `cloud/1.57` patches are byte-identical. - Black-box proof, `--project=cloud`, own ComfyUI CI container 0.0.27 plus a `DISTRIBUTION=cloud VITE_USE_LEGACY_DEFAULT_GRAPH=true` dev server: - parent (`cloud/1.57` product files, new specs kept): `agentInsertWorkflowOverlap.spec.ts` **fails** — `inserted "Template note" at (-420, 200) overlaps existing "Existing node A" at (0, 180)` plus four more overlaps. - this head: **passes**, along with both `agentDuplicateInsertOpaqueWidgetWrite` cases and `agentPastedNodeOrphanedOnRetarget` (the human-paste scope guard). - Unit: Agent unit suite (`src/workbench/extensions/agent`) all passed, 1 expected fail. `typecheck`, `typecheck:browser`, oxlint, oxfmt clean. - Not run: a packaged Desktop build or a hosted Agent turn. - Release-train scope: 1.57 only, per this program's current backport grant. `core/1.58` / `cloud/1.58` also lack #21527 and are not touched here. </details>
Backport of #21527 to
core/1.57.An Agent template inserted into a tab that already has nodes no longer lands on top of them. In a live agent-turn frame, a created batch that intersects an existing node moves beside the existing content by one shared offset, keeping its internal layout. Catch-up, tab-return and human frames are unchanged. Companion
cloud/1.57carrier: #21627.Product code is the source change unchanged. The cherry-pick conflicted only on release-line context: a JSDoc next to the new helper, a test-mock refactor around this branch's older fixture shape, and this branch's
getWebSocketfixture (main renamed itgetAgentSocketin #17469).Full context for agent readers
-xprovenance kept. No AI co-author trailer.core/1.57already carries ADR-CRDT-PLACEMENT-0035 andbatchPlacement.tsbyte-identical to the source's parent, so it has the offscreen-only placement this fixes. The new black-box spec fails on this branch's product files with the same message as onmain.layoutFollowerBridge.ts: newisLiveAgentUpdateplaced above this branch's existingtrySendJSDoc.useAgentCrdtFollower.test.ts: took the source's switch from a factory mock tovi.mock(..., { spy: true })+mockImplementation(needed so the realisLiveAgentUpdateexport survives), without main's live-subscription counters, which this branch's tests do not use.agentDuplicateInsertOpaqueWidgetWrite.spec.ts: kept this branch's inlinedoc_subscribewait instead of the newsubscribeAgentWorkflowhelper; took the source's actor fix and side-by-side assertion.agentInsertWorkflowOverlapFixture.ts/utils/agentInsertWorkflowOverlap.ts:getAgentSocket→getWebSocket(this branch's agent doc frames ride/ws).core/1.57andcloud/1.57patches are byte-identical.--project=cloud, own ComfyUI CI container 0.0.27 plus aDISTRIBUTION=cloud VITE_USE_LEGACY_DEFAULT_GRAPH=truedev server:core/1.57product files, new specs kept):agentInsertWorkflowOverlap.spec.tsfails —inserted "Template note" at (-420, 200) overlaps existing "Existing node A" at (0, 180)plus four more overlaps.agentDuplicateInsertOpaqueWidgetWritecases andagentPastedNodeOrphanedOnRetarget(the human-paste scope guard).src/workbench/extensions/agent) all passed, 1 expected fail.typecheck,typecheck:browser, oxlint, oxfmt clean.core/1.58/cloud/1.58also lack fix(agent): move an agent-inserted workflow clear of the nodes it lands on #21527 and are not touched here.