Repository navigation
[backport cloud/1.57] fix(agent): move an agent-inserted workflow clear of the nodes it lands on (#21527) - #21627
Conversation
…ds on (#21527) When the agent inserts a workflow into a tab that already has nodes, the inserted nodes can land on top of the existing graph ([PM-2232](https://linear.app/comfyorg/issue/PM-2232/workflow-inserted-into-an-existing-tab-lands-on-top-of-the-existing)). `get_template` commits as one `insert_workflow` op that carries the template's baked-in coordinates, and neither cloud nor comfy-multi-player translates them. The follower's placement (ADR-CRDT-PLACEMENT-0035, from [PM-1142](https://linear.app/comfyorg/issue/PM-1142)) only moved a batch that landed far away and offscreen, so a batch landing on the user's nodes kept its overlapping position. The Z-Image template spans x −420 to 1350, the same region as the default workflow. Now, in a live frame written by an agent turn, a created batch with any node that intersects an existing node moves beside the existing content by the same single offset. The batch's internal layout is unchanged. Catch-up frames, tab-return applies and human writes are excluded, so a node a human pasted over another is not moved when the follower resubscribes (`agentPastedNodeOrphanedOnRetarget.spec.ts` catches that if the scope is dropped). Behavior change to an existing pin: `agentDuplicateInsertOpaqueWidgetWrite.spec.ts` asserted that two inserts of the same template render pixel-identically on top of each other. The second copy now lands beside the first. Its op fixture also used `agent:e2e`, which fails the actor grammar and is dropped by the follower; it now uses `agent:<thread>:<turn>` as cloud stamps it. Known limitation, recorded in the ADR: an agent insert that lands while its tab is inactive is applied on tab return without collision placement, because the collected changes do not record their writer. - New black-box case `browser_tests/tests/agent/agentInsertWorkflowOverlap.spec.ts`: a canvas with three nodes, then one `insert_workflow` carrying the Z-Image template's node rects. Fails on `main` (`inserted "Template note" at (-420, 200) overlaps existing "Existing node A" at (0, 180)`), passes here; also asserts the template's relative layout is preserved. - `agentDuplicateInsertOpaqueWidgetWrite.spec.ts` side-by-side assertion fails on `main`, passes here. - Unit: `batchPlacement.test.ts` (collision cases, hull-interior non-collision stays put) and `liveGraphApplier.test.ts` (a live agent batch moves, a replayed one does not). Both fail on `main`. - `pnpm exec vitest run src/workbench/extensions/agent`: 177 files, 4027 passed. - Full `browser_tests/tests/agent` on the `cloud` project locally: 352 of 355 passed. The three failures (two `agentConversationReplay` screenshot comparisons and `agentReplyDrafts` "keeps its run approval action live", which already passes under `test.fail`) fail identically on `main` in the same environment. - `pnpm typecheck`, `pnpm typecheck:browser`, oxlint, oxfmt clean. (cherry picked from commit bc0250c)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-22T01:35:26.965Z",
"gitSha": "5e0f83b587b3ba5f877bfe50ad419534c8711441",
"branch": "backport-21527-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.9309999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.648,
"layouts": 9,
"layoutDurationMs": 2.371,
"taskDurationMs": 338.446,
"heapDeltaBytes": 22084532,
"heapUsedBytes": 87621084,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.544,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2030.206000000021,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9759999999999995,
"layouts": 10,
"layoutDurationMs": 2.913,
"taskDurationMs": 499.992,
"heapDeltaBytes": 22159588,
"heapUsedBytes": 88078284,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.171,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.65000000003,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.999,
"layouts": 11,
"layoutDurationMs": 2.8719999999999994,
"taskDurationMs": 839.274,
"heapDeltaBytes": -7313040,
"heapUsedBytes": 68150600,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 156.81499999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1977.6110000000244,
"styleRecalcs": 84,
"styleRecalcDurationMs": 15.028,
"layouts": 9,
"layoutDurationMs": 2.583,
"taskDurationMs": 1035.372,
"heapDeltaBytes": -7276840,
"heapUsedBytes": 68232560,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 160.061,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66638655462185,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.5319999999683,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.99,
"layouts": 11,
"layoutDurationMs": 2.852,
"taskDurationMs": 277.44900000000007,
"heapDeltaBytes": 18813824,
"heapUsedBytes": 84296240,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.499,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.6639999999798,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.328,
"layouts": 11,
"layoutDurationMs": 2.753,
"taskDurationMs": 378.0129999999999,
"heapDeltaBytes": 18329936,
"heapUsedBytes": 85031364,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.140999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 611.2799999999652,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7100000000000004,
"layouts": 9,
"layoutDurationMs": 2.493,
"taskDurationMs": 429.94,
"heapDeltaBytes": 25619764,
"heapUsedBytes": 91468488,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 169.66400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.13055555555555,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 629.045999999903,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.763000000000001,
"layouts": 9,
"layoutDurationMs": 2.699,
"taskDurationMs": 437.3090000000001,
"heapDeltaBytes": 25168508,
"heapUsedBytes": 91069496,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 175.703,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.11621621621622,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1185.5150000000094,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 835.876,
"heapDeltaBytes": -13269028,
"heapUsedBytes": 81095036,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 68.89799999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 516,
"frameDurationMs": 32.86666666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1213.9399999999796,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 904.4039999999999,
"heapDeltaBytes": -11169500,
"heapUsedBytes": 81486852,
"domNodes": -192,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 69.981,
"eventListeners": -106,
"totalBlockingTimeMs": 528,
"frameDurationMs": 32.881081081081064,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.8239999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.99500000000006,
"heapDeltaBytes": -5744832,
"heapUsedBytes": 75304040,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 162.44200000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.0410000000611,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.3740000000001,
"heapDeltaBytes": -3344976,
"heapUsedBytes": 76366328,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 156.33,
"eventListeners": 0,
"totalBlockingTimeMs": 210,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10400.222999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9485.734,
"heapDeltaBytes": -23075460,
"heapUsedBytes": 71790436,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 7713.717,
"eventListeners": -68,
"totalBlockingTimeMs": 928,
"frameDurationMs": 32.09753086419753,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10630.485000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9839.1,
"heapDeltaBytes": -9137756,
"heapUsedBytes": 90705664,
"domNodes": -258,
"jsHeapTotalBytes": 9302016,
"scriptDurationMs": 8046.28,
"eventListeners": -68,
"totalBlockingTimeMs": 1110,
"frameDurationMs": 31.645238095238092,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9575.891000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8769.553,
"heapDeltaBytes": -11766764,
"heapUsedBytes": 87411928,
"domNodes": -258,
"jsHeapTotalBytes": 6942720,
"scriptDurationMs": 7073.228,
"eventListeners": -64,
"totalBlockingTimeMs": 667,
"frameDurationMs": 31.627062706270628,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10373.144000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9596.264,
"heapDeltaBytes": -6081308,
"heapUsedBytes": 88394304,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 7844.576,
"eventListeners": -67,
"totalBlockingTimeMs": 1065,
"frameDurationMs": 31.130030030030035,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 207.78799999999364,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.308,
"layouts": 11,
"layoutDurationMs": 2.9619999999999997,
"taskDurationMs": 149.257,
"heapDeltaBytes": -8194864,
"heapUsedBytes": 79138912,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.221999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 1,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 202.25600000003396,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.667000000000002,
"layouts": 11,
"layoutDurationMs": 3.3859999999999997,
"taskDurationMs": 149.44599999999997,
"heapDeltaBytes": 13088088,
"heapUsedBytes": 92157440,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.63,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.211111111111173,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2039.9050000000898,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3000000000000007,
"layouts": 8,
"layoutDurationMs": 2.3919999999999995,
"taskDurationMs": 452.9740000000001,
"heapDeltaBytes": -2719992,
"heapUsedBytes": 76126688,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 31.051999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.8729999999196,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.503,
"layouts": 9,
"layoutDurationMs": 2.4469999999999996,
"taskDurationMs": 612.184,
"heapDeltaBytes": -23191496,
"heapUsedBytes": 73856992,
"domNodes": -278,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 35.60499999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2546.1099999999988,
"styleRecalcs": 69,
"styleRecalcDurationMs": 5.84,
"layouts": 7,
"layoutDurationMs": 2.9,
"taskDurationMs": 1685.267,
"heapDeltaBytes": 3311708,
"heapUsedBytes": 83105128,
"domNodes": -258,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 833.152,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66513157894737,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2277.912000000015,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.9430000000000005,
"layouts": 6,
"layoutDurationMs": 1.6099999999999999,
"taskDurationMs": 1497.319,
"heapDeltaBytes": -11541708,
"heapUsedBytes": 68274200,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 805.6540000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788888888888888,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3537.8580000000284,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.5040000000000004,
"layouts": 65,
"layoutDurationMs": 10.534999999999998,
"taskDurationMs": 1554.128,
"heapDeltaBytes": -13584660,
"heapUsedBytes": 67943024,
"domNodes": -234,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 770.513,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3524.5629999999437,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.398999999999999,
"layouts": 64,
"layoutDurationMs": 10.642,
"taskDurationMs": 1569.0460000000003,
"heapDeltaBytes": 925344,
"heapUsedBytes": 82640916,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 785.999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74571428571429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3007.355999999959,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.679000000000001,
"layouts": 5,
"layoutDurationMs": 1.2550000000000001,
"taskDurationMs": 1923.6449999999998,
"heapDeltaBytes": 5261044,
"heapUsedBytes": 83732724,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 955.7359999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.852513966480448,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2962.7409999999372,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.569000000000001,
"layouts": 5,
"layoutDurationMs": 1.1740000000000002,
"taskDurationMs": 1936.9999999999998,
"heapDeltaBytes": 6988008,
"heapUsedBytes": 84709736,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 955.3810000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.855113636363637,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.287999999956,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9850000000000008,
"layouts": 7,
"layoutDurationMs": 1.86,
"taskDurationMs": 607.6020000000001,
"heapDeltaBytes": -2039316,
"heapUsedBytes": 79292212,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.924999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.3360000001003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8800000000000006,
"layouts": 7,
"layoutDurationMs": 1.7499999999999998,
"taskDurationMs": 450.251,
"heapDeltaBytes": -2161824,
"heapUsedBytes": 78514504,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 33.90899999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 599.448999999936,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.031999999999999,
"layouts": 10,
"layoutDurationMs": 2.816,
"taskDurationMs": 435.55,
"heapDeltaBytes": 3096896,
"heapUsedBytes": 80153772,
"domNodes": 0,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 146.424,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66944444444444,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 599.3059999999559,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.754,
"layouts": 9,
"layoutDurationMs": 2.613,
"taskDurationMs": 417.049,
"heapDeltaBytes": 21136444,
"heapUsedBytes": 88584600,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 143.192,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.0179999999596,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6920000000000006,
"layouts": 10,
"layoutDurationMs": 2.921,
"taskDurationMs": 488.02500000000003,
"heapDeltaBytes": -254640,
"heapUsedBytes": 76634388,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.819,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2036.8589999999358,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.548000000000001,
"layouts": 9,
"layoutDurationMs": 2.402,
"taskDurationMs": 537.902,
"heapDeltaBytes": -6250788,
"heapUsedBytes": 60621808,
"domNodes": -180,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.321,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1960.833999999977,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.485,
"layouts": 9,
"layoutDurationMs": 2.6519999999999992,
"taskDurationMs": 882.9290000000001,
"heapDeltaBytes": 11356752,
"heapUsedBytes": 78314012,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 109.758,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1960.7669999999189,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.16,
"layouts": 9,
"layoutDurationMs": 2.534,
"taskDurationMs": 900.1320000000001,
"heapDeltaBytes": 11659408,
"heapUsedBytes": 79149976,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 114.253,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.434999999984,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.298999999999996,
"layouts": 5,
"layoutDurationMs": 16.131999999999998,
"taskDurationMs": 1005.778,
"heapDeltaBytes": 7193316,
"heapUsedBytes": 106288772,
"domNodes": 15953,
"jsHeapTotalBytes": 19009536,
"scriptDurationMs": 27.561999999999998,
"eventListeners": 3244,
"totalBlockingTimeMs": 158,
"frameDurationMs": 19.333333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9105.584999999905,
"styleRecalcs": 249,
"styleRecalcDurationMs": 17.593999999999998,
"layouts": 7,
"layoutDurationMs": 2.1420000000000003,
"taskDurationMs": 5871.895,
"heapDeltaBytes": -12500484,
"heapUsedBytes": 84725720,
"domNodes": -258,
"jsHeapTotalBytes": 5861376,
"scriptDurationMs": 2712.4330000000004,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757904411764706,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9273.799000000054,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.048,
"layouts": 7,
"layoutDurationMs": 2.249,
"taskDurationMs": 5854.641,
"heapDeltaBytes": -13448548,
"heapUsedBytes": 83405052,
"domNodes": -258,
"jsHeapTotalBytes": 5074944,
"scriptDurationMs": 2708.6890000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786437613019892,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23008.053000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22153.002,
"heapDeltaBytes": -16216540,
"heapUsedBytes": 260053816,
"domNodes": -3330,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 328.671,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.68224137931035,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 16287.797999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15256.291999999998,
"heapDeltaBytes": -7847992,
"heapUsedBytes": 268574148,
"domNodes": -3330,
"jsHeapTotalBytes": 22274048,
"scriptDurationMs": 275.709,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.833504273504275,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 19168.461999999978,
"styleRecalcs": 171,
"styleRecalcDurationMs": 13.361000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18711.904000000002,
"heapDeltaBytes": -10415104,
"heapUsedBytes": 293779412,
"domNodes": -3330,
"jsHeapTotalBytes": 16961536,
"scriptDurationMs": 833.422,
"eventListeners": -651,
"totalBlockingTimeMs": 24,
"frameDurationMs": 33.101727115716756,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 27850.790999999957,
"styleRecalcs": 181,
"styleRecalcDurationMs": 14.999999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27387.36,
"heapDeltaBytes": -18777804,
"heapUsedBytes": 272075952,
"domNodes": -3330,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 839.249,
"eventListeners": -651,
"totalBlockingTimeMs": 24,
"frameDurationMs": 50.7264116575592,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8307.061999999973,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.14599999999999,
"layouts": 20,
"layoutDurationMs": 21.328999999999986,
"taskDurationMs": 8115.790000000001,
"heapDeltaBytes": -37284984,
"heapUsedBytes": 258158944,
"domNodes": -3330,
"jsHeapTotalBytes": 21745664,
"scriptDurationMs": 130.442,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.36648044692738,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8310.193000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.04700000000001,
"layouts": 20,
"layoutDurationMs": 23.72300000000001,
"taskDurationMs": 8173.160000000001,
"heapDeltaBytes": -28156432,
"heapUsedBytes": 254490288,
"domNodes": -3330,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 159.261,
"eventListeners": -653,
"totalBlockingTimeMs": 9,
"frameDurationMs": 46.10888888888889,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7802.557999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7346.499000000002,
"heapDeltaBytes": 8744392,
"heapUsedBytes": 254736372,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.73999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.05466666666666,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11383.909000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11057.345,
"heapDeltaBytes": 4081476,
"heapUsedBytes": 253576268,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.39700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.22226148409893,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 150.2779999999575,
"styleRecalcs": 10,
"styleRecalcDurationMs": 13.318000000000001,
"layouts": 9,
"layoutDurationMs": 3.921,
"taskDurationMs": 116.321,
"heapDeltaBytes": 4768512,
"heapUsedBytes": 77448620,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.491,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 118.29800000009527,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.064,
"layouts": 8,
"layoutDurationMs": 3.4720000000000004,
"taskDurationMs": 86.516,
"heapDeltaBytes": 4456528,
"heapUsedBytes": 77233680,
"domNodes": 117,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.200000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 450.5219999999781,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.945,
"layouts": 76,
"layoutDurationMs": 14.033999999999999,
"taskDurationMs": 395.25,
"heapDeltaBytes": 10963904,
"heapUsedBytes": 82730160,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 189.718,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 478.80399999996825,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.019,
"layouts": 76,
"layoutDurationMs": 15.135,
"taskDurationMs": 423.25399999999996,
"heapDeltaBytes": 11395984,
"heapUsedBytes": 82661016,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 201.609,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 474.6020000000044,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.863,
"layouts": 76,
"layoutDurationMs": 13.158,
"taskDurationMs": 442.57099999999997,
"heapDeltaBytes": -399288,
"heapUsedBytes": 121450276,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.43800000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 555.6450000000268,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.824,
"layouts": 76,
"layoutDurationMs": 14.807,
"taskDurationMs": 505.982,
"heapDeltaBytes": -739276,
"heapUsedBytes": 107946836,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 211.784,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696982,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2283 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9b260204b9a30fb2ecc7665398103d158414825f
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21627 +/- ##
=============================================
Coverage ? 85.84%
=============================================
Files ? 2715
Lines ? 152616
Branches ? 40563
=============================================
Hits ? 131006
Misses ? 21220
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
…r of the nodes it lands on (#21527) (#21628) Backport of #21527 to `core/1.57`. An Agent template inserted into a tab that already has nodes no longer lands on top of them. In a live agent-turn frame, a created batch that intersects an existing node moves beside the existing content by one shared offset, keeping its internal layout. Catch-up, tab-return and human frames are unchanged. Companion `cloud/1.57` carrier: #21627. Product code is the source change unchanged. The cherry-pick conflicted only on release-line context: a JSDoc next to the new helper, a test-mock refactor around this branch's older fixture shape, and this branch's `getWebSocket` fixture (main renamed it `getAgentSocket` in #17469). <details><summary>Full context for agent readers</summary> - Source: #21527, merged as bc0250c ([PM-2232](https://linear.app/comfyorg/issue/PM-2232/workflow-inserted-into-an-existing-tab-lands-on-top-of-the-existing)). Author and author date preserved; `-x` provenance kept. No AI co-author trailer. - Applicability: `core/1.57` already carries ADR-CRDT-PLACEMENT-0035 and `batchPlacement.ts` byte-identical to the source's parent, so it has the offscreen-only placement this fixes. The new black-box spec fails on this branch's product files with the same message as on `main`. - Conflict resolution, context only: - `layoutFollowerBridge.ts`: new `isLiveAgentUpdate` placed above this branch's existing `trySend` JSDoc. - `useAgentCrdtFollower.test.ts`: took the source's switch from a factory mock to `vi.mock(..., { spy: true })` + `mockImplementation` (needed so the real `isLiveAgentUpdate` export survives), without main's live-subscription counters, which this branch's tests do not use. - `agentDuplicateInsertOpaqueWidgetWrite.spec.ts`: kept this branch's inline `doc_subscribe` wait instead of the new `subscribeAgentWorkflow` helper; took the source's actor fix and side-by-side assertion. - New `agentInsertWorkflowOverlapFixture.ts` / `utils/agentInsertWorkflowOverlap.ts`: `getAgentSocket` → `getWebSocket` (this branch's agent doc frames ride `/ws`). - The `core/1.57` and `cloud/1.57` patches are byte-identical. - Black-box proof, `--project=cloud`, own ComfyUI CI container 0.0.27 plus a `DISTRIBUTION=cloud VITE_USE_LEGACY_DEFAULT_GRAPH=true` dev server: - parent (`core/1.57` product files, new specs kept): `agentInsertWorkflowOverlap.spec.ts` **fails** — `inserted "Template note" at (-420, 200) overlaps existing "Existing node A" at (0, 180)` plus four more overlaps. - this head: **passes**, along with both `agentDuplicateInsertOpaqueWidgetWrite` cases and `agentPastedNodeOrphanedOnRetarget` (the human-paste scope guard). - Unit: Agent unit suite (`src/workbench/extensions/agent`) all passed, 1 expected fail. `typecheck`, `typecheck:browser`, oxlint, oxfmt clean. - Not run: a packaged Desktop build or a hosted Agent turn. - Release-train scope: 1.57 only, per this program's current backport grant. `core/1.58` / `cloud/1.58` also lack #21527 and are not touched here. </details>
christian-byrne
left a comment
There was a problem hiding this comment.
Backport review: clean, merging under the release-backport grant.
- Faithful carry of #21527 (
bc0250c6b3) ontocloud/1.57(9b260204b9). Product hunks identical to main; only test change isgetAgentSocket→getWebSocket(this train predates #17469). - Black-box proof red on parent, green on carrier; all exact-head checks green.
- 4 cursor-review findings answered in thread: 3 were already ruled on the source PR, 1 fixture nit is identical on main. No divergence from main.
Full context for agent readers
- Authority:
program/release-backport-authority.md(Agent backports tocloud/1.57are in the active train set). Author cannot self-approve, so this is a COMMENT review per that grant. - Applicability and conflict resolution: https://github.com/christian-byrne/in-app-agent-program/blob/main/reports/jobs/oploop-873a.md
- Exact head
5804c4ccde428a1178ae4550375f58f530501774, base tip9b260204b9a30fb2ecc7665398103d158414825f(ancestor of head). 129 checks pass, 30 skipped, 0 failing or pending, includingplaywright-tests-cloud-sharded1–4 ande2e-status. - Red on parent:
agentInsertWorkflowOverlap.spec.tsfails on the target's own product files withinserted "Template note" at (-420, 200) overlaps existing "Existing node A" at (0, 180); green on the carrier, plus bothagentDuplicateInsertOpaqueWidgetWritecases and theagentPastedNodeOrphanedOnRetargetguard. - No human objections on the PR.
Backport of #21527 to
cloud/1.57.An Agent template inserted into a tab that already has nodes no longer lands on top of them. In a live agent-turn frame, a created batch that intersects an existing node moves beside the existing content by one shared offset, keeping its internal layout. Catch-up, tab-return and human frames are unchanged. Companion
core/1.57carrier: #21628.Product code is the source change unchanged. The cherry-pick conflicted only on release-line context: a JSDoc next to the new helper, a test-mock refactor around this branch's older fixture shape, and this branch's
getWebSocketfixture (main renamed itgetAgentSocketin #17469).Full context for agent readers
-xprovenance kept. No AI co-author trailer.cloud/1.57already carries ADR-CRDT-PLACEMENT-0035 andbatchPlacement.tsbyte-identical to the source's parent, so it has the offscreen-only placement this fixes. The new black-box spec fails on this branch's product files with the same message as onmain.layoutFollowerBridge.ts: newisLiveAgentUpdateplaced above this branch's existingtrySendJSDoc.useAgentCrdtFollower.test.ts: took the source's switch from a factory mock tovi.mock(..., { spy: true })+mockImplementation(needed so the realisLiveAgentUpdateexport survives), without main's live-subscription counters, which this branch's tests do not use.agentDuplicateInsertOpaqueWidgetWrite.spec.ts: kept this branch's inlinedoc_subscribewait instead of the newsubscribeAgentWorkflowhelper; took the source's actor fix and side-by-side assertion.agentInsertWorkflowOverlapFixture.ts/utils/agentInsertWorkflowOverlap.ts:getAgentSocket→getWebSocket(this branch's agent doc frames ride/ws).core/1.57andcloud/1.57patches are byte-identical.--project=cloud, own ComfyUI CI container 0.0.27 plus aDISTRIBUTION=cloud VITE_USE_LEGACY_DEFAULT_GRAPH=truedev server:cloud/1.57product files, new specs kept):agentInsertWorkflowOverlap.spec.tsfails —inserted "Template note" at (-420, 200) overlaps existing "Existing node A" at (0, 180)plus four more overlaps.agentDuplicateInsertOpaqueWidgetWritecases andagentPastedNodeOrphanedOnRetarget(the human-paste scope guard).src/workbench/extensions/agent) all passed, 1 expected fail.typecheck,typecheck:browser, oxlint, oxfmt clean.core/1.58/cloud/1.58also lack fix(agent): move an agent-inserted workflow clear of the nodes it lands on #21527 and are not touched here.