Skip to content

[backport cloud/1.57] fix(agent): define a hand-added subgraph host's definitions in the bound document (#21576) - #21602

Merged
comfy-pr-bot merged 1 commit into
cloud/1.57from
backport-21576-to-cloud-1.57
Oct 21, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.57from
backport-21576-to-cloud-1.57

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #21576 to cloud/1.57.

A person who adds a subgraph blueprint while the Agent document is bound can now edit its promoted widgets: the edit is saved instead of refused with "Widget edit was rejected and was not saved". Production serves cloud/1.57, so Cloud gets the fix from the next cloud/1.57 patch promotion. Companion core/1.57 carrier: #21601.

Product code is the source change unchanged. The auto-backport conflicted only on neighbouring lines (this branch lacks #21335's longer JSDoc and #21270's notifyWidgetWriteRefused(nodeId, widgetName) signature), so each conflict was resolved by adding the one new docHasSubgraphDefinition line next to this branch's existing code.

Full context for agent readers
  • Source: fix(agent): define a hand-added subgraph host's definitions in the bound document #21576, merged as 44fb9d8. Author and author date preserved; -x provenance line kept. No AI co-author trailer.
  • Conflict resolution, all context-only: AgentPanelRoot.vue (destructure), useAgentCrdtFollower.ts (two dep objects), docOpMinter.ts (deps interface), agentDisplayIntAdd.regression.test.ts and docOpMinter.test.ts (test deps). Two test adaptations: refusals is a counter on this branch, so the new case asserts toBe(0) instead of toEqual([]); and the seededPromotedDocs cleanup set does not exist here, so that one line is dropped. The core/1.57 and cloud/1.57 carriers carry the identical patch.
  • Prerequisites already on this branch: the promoted-write refusal guard (fix(agent): notify refused promoted writes and refuse before the doc catches up #20516), readSubgraphDefinitionIds, reportError, the SubgraphDefinition wire type. Nothing else from main is pulled in.
  • Black-box proof, browser_tests/tests/agent/agentHumanAddedBlueprintPromotedWrite.spec.ts, --project=cloud, own ComfyUI CI container 0.0.27 plus a DISTRIBUTION=cloud VITE_USE_LEGACY_DEFAULT_GRAPH=true dev server:
    • parent (cloud/1.57 product files, new spec kept): fails — rejection toast shown, document keeps "a pasted prompt".
    • this head: passes, along with agentHumanAddTabSwitch, agentNestedSubgraphDocument and agentSubgraphFollower.
  • Unit: the three new docOpMinter cases fail on the parent and pass here. Agent unit suite (src/workbench/extensions/agent): 166 files, all passed, 1 expected fail. typecheck and typecheck:browser clean.
  • Not run: a packaged Desktop build or a hosted Agent turn.
  • Release-train scope: only the 1.57 trains, per the source PR's labels.

…und document (#21576)

Hand-added subgraph blueprint + Agent bound: promoted widget edits were
refused and lost on reload. Now saved.

- Cause: the minter sent only the host's `add_node`, never its
definition. The doc held the host's values but could not place them, so
every promoted write hit the existing refusal.
- Fix: an add batch now ends with `define_subgraph` for each definition
the added host needs and the doc lacks. Refusal guard unchanged.
- Live in prod on 1.55.18, 1.56.3 and 1.57.0: 4 Sentry issues, ~30
events, ~24 users.

<details><summary>Full context for agent readers</summary>

`agent_crdt_promoted_widget_order_drift` with `declared inputs []`, from
`reportOnce(docOpMinter)`:

| Sentry issue | Live promoted names | Events / users | Release |
| --- | --- | --- | --- |
|
[CLOUD-FRONTEND-PROD-2Z4](https://comfy-org.sentry.io/issues/7805196897/)
| `image, upload` | 1 / 1 | 1.57.0 (stable) |
|
[CLOUD-FRONTEND-PROD-2WK](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-2WK)
| the `Text to Image (Flux.2 Dev)` blueprint's 9 inputs | 3 / 1 | 1.57.0
|
|
[CLOUD-FRONTEND-PROD-2S7](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-2S7)
| 7 Z-Image names | 17 / 13 | 1.56.3 |
|
[CLOUD-FRONTEND-PROD-25R](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-25R)
| `value, value_1, model_name` | 9 / 9 | 1.55.18 |

Each event has `docDeclaredNames: []` and no `docPromotedNames`
(undefined), meaning the doc carries no definition for the host's type.
The live names match the inputs of core blueprints in
`ComfyUI/blueprints/` (2WK matches `Text to Image (Flux.2 Dev).json`
exactly).

1. A person adds a blueprint (or pastes a host). `_deserializeItems`
registers a fresh definition UUID live and adds the host.
2. `docOpMinter` mints `add_node` with the host's positional
`widgets_values`, but no frontend path ever minted `define_subgraph`.
The doc ends up with N stored values and no definition.
3. `readDocPromotedWidgets` returns `{ valueCount: N, declaredNames: [],
promotedNames: undefined }`. `documentAcceptsLiveIndex` requires
matching names whenever `valueCount > 0`, so every promoted write is
refused as `layout_drift`. That refusal is deliberate ("marks stored
values unreadable when their definition is unavailable") and is not
loosened here.

- `docOpMinter.flush()` collects the subgraph hosts in the batch and
appends one `define_subgraph` per missing definition: the host's own
plus nested ones via `findUsedSubgraphIds`, sorted dependency-first with
`topologicalSortSubgraphs`. The payload is a JSON copy of
`Subgraph.asSerialisable()`, the same definition shape the seed and
reseed paths already send.
- Definitions go after the adds and links. The applier aborts the rest
of a batch after a rejection, so a refused definition cannot take the
user's add down with it.
- New dep `docHasSubgraphDefinition(id)` (follower:
`readSubgraphDefinitionIds(doc)`) skips definitions the doc already
holds, so a clone of an existing host sends nothing extra.
- Echo is harmless: `registerDefinitions` skips ids the live graph
already has.
- Invariants: still one semantic path. The definition is minted at the
command site from the graph that just changed, with no store-first
write, reconcile, or raw Yjs. KEEP-ALIVE 1 and 14 hold.

- Convert-to-subgraph was not exercised. If it emits a local `add_node`
for the new host, it takes this same path, but that is unverified.
- Docs created before this fix still lack the definition for hosts
already added. Those hosts stay unwritable until a reseed or until the
host is re-added.

</details>

- Black-box
(`browser_tests/tests/agent/agentHumanAddedBlueprintPromotedWrite.spec.ts`,
`@cloud @agent`): adds a promoted blueprint during a bound session,
edits the promoted prompt by hand, and asserts no rejection toast and
that the shared document holds the edit. **Red on `main`** (rejection
toast; the browser log shows the exact prod message `Subgraph host …
promotes [text], which the document's 1 stored values and declared
inputs [] do not place`). **Green on this branch.**
- Unit (`docOpMinter.test.ts`, 2 new): a hand-added host with a nested
definition mints `[add_node, define inner, define outer]`, the real
applier applies all three, the promoted write then mints and applies,
and definitions the doc already holds are skipped. Both fail on `main`.
- Agent unit suite: 178 files, 4039 passed. `pnpm typecheck` and
`typecheck:browser` clean. Neighbouring specs green:
`agentHumanAddTabSwitch` (7/7, including both blueprint cases),
`agentNestedSubgraphDocument`, `agentSubgraphFollower`,
`agentPromotedSeedRunWidgetWrite`.
- After release: `agent_crdt_promoted_widget_order_drift` events with
`docDeclaredNames: []` should stop on builds that contain this change.

(cherry picked from commit 44fb9d8)
@christian-byrne
christian-byrne requested review from a team as code owners October 21, 2026 22:18
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 2aaf2d85-31e9-44e9-8d8b-f04d5bb6fe12

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.4 MB heap
dom-widget-order-dense-n200-w200-i120: · 34.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 384ms TBT · 77.6 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 46.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 114ms TBT · 72.4 MB heap
extension-clean-combined-draw: · 43.3 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 20ms TBT · 88.2 MB heap
extension-rgthree-prototype-draw: · 42.0 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 90ms TBT · 78.5 MB heap
large-combo-open: · 47.8 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 75.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
large-graph-zoom: · 59.8 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
legacy-node-drag: · 59.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
subgraph-transition-enter: · 48.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 115ms TBT · 99.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
vue-large-graph-idle: · 36.2 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 249.1 MB heap
vue-large-graph-pan: · 33.3 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 64ms TBT · 255.7 MB heap
vue-node-resize-workload: · 35.0 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 256.7 MB heap
vue-zoom-out-idle: · 36.5 avg FPS · 17.2 P5 FPS ❌ (target: ≥52) · 0ms TBT · 250.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.7 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.3 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 122.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 2ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 10
canvas-idle: style recalc count 11
canvas-idle: task duration 334ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 79.0 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 12ms
canvas-mouse-sweep: layout count 9
canvas-mouse-sweep: style recalc count 72
canvas-mouse-sweep: task duration 620ms
canvas-mouse-sweep: script duration 105ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 73.4 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 4ms
canvas-zoom-sweep: layout count 12
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 308ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 76.3 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 2ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 342ms
dom-widget-clipping: script duration 115ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 75.4 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 29ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 682ms
dom-widget-order-dense-n200-w200-i120: script duration 44ms
dom-widget-order-dense-n200-w200-i120: TBT 384ms
dom-widget-order-dense-n200-w200-i120: heap used 77.6 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -192
dom-widget-order-dense-n200-w200-i120: event listeners -106
dom-widget-order-sparse-n1000-w20-i120: avg frame time 22ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 324ms
dom-widget-order-sparse-n1000-w20-i120: script duration 103ms
dom-widget-order-sparse-n1000-w20-i120: TBT 114ms
dom-widget-order-sparse-n1000-w20-i120: heap used 72.4 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 23ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 1ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 3
extension-clean-combined-draw: style recalc count 3
extension-clean-combined-draw: task duration 5551ms
extension-clean-combined-draw: script duration 4250ms
extension-clean-combined-draw: TBT 20ms
extension-clean-combined-draw: heap used 88.2 MB
extension-clean-combined-draw: DOM nodes -258
extension-clean-combined-draw: event listeners -68
extension-rgthree-prototype-draw: avg frame time 24ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 2
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 5616ms
extension-rgthree-prototype-draw: script duration 4294ms
extension-rgthree-prototype-draw: TBT 90ms
extension-rgthree-prototype-draw: heap used 78.5 MB
extension-rgthree-prototype-draw: DOM nodes -258
extension-rgthree-prototype-draw: event listeners -68
large-combo-open: avg frame time 21ms
large-combo-open: p95 frame time 50ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 12ms
large-combo-open: layout count 11
large-combo-open: style recalc count 22
large-combo-open: task duration 122ms
large-combo-open: script duration 7ms
large-combo-open: TBT 0ms
large-combo-open: heap used 75.5 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 9
large-graph-idle: style recalc count 9
large-graph-idle: task duration 475ms
large-graph-idle: script duration 30ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 72.3 MB
large-graph-idle: DOM nodes -258
large-graph-idle: event listeners -68
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 6ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1254ms
large-graph-pan: script duration 584ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 74.0 MB
large-graph-pan: DOM nodes -258
large-graph-pan: event listeners -66
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 67
large-graph-zoom: style recalc count 73
large-graph-zoom: task duration 1298ms
large-graph-zoom: script duration 565ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 69.6 MB
large-graph-zoom: DOM nodes -234
large-graph-zoom: event listeners -68
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 7
legacy-node-drag: style recalc count 48
legacy-node-drag: task duration 1419ms
legacy-node-drag: script duration 674ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 75.9 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 9
minimap-idle: style recalc count 9
minimap-idle: task duration 466ms
minimap-idle: script duration 29ms
minimap-idle: TBT 0ms
minimap-idle: heap used 75.9 MB
minimap-idle: DOM nodes -258
minimap-idle: event listeners -68
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 4ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 303ms
subgraph-dom-widget-clipping: script duration 100ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.8 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 10
subgraph-idle: task duration 359ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 85.0 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 81
subgraph-mouse-sweep: task duration 741ms
subgraph-mouse-sweep: script duration 85ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 70.5 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 21ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 20ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 618ms
subgraph-transition-enter: script duration 23ms
subgraph-transition-enter: TBT 115ms
subgraph-transition-enter: heap used 99.0 MB
subgraph-transition-enter: DOM nodes 15953
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 19ms
viewport-pan-sweep: layout count 9
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4364ms
viewport-pan-sweep: script duration 1977ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.1 MB
viewport-pan-sweep: DOM nodes -258
viewport-pan-sweep: event listeners -66
vue-large-graph-idle: avg frame time 28ms
vue-large-graph-idle: p95 frame time 50ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15279ms
vue-large-graph-idle: script duration 221ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 249.1 MB
vue-large-graph-idle: DOM nodes -3330
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 30ms
vue-large-graph-pan: p95 frame time 58ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 12ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 116
vue-large-graph-pan: task duration 16273ms
vue-large-graph-pan: script duration 779ms
vue-large-graph-pan: TBT 64ms
vue-large-graph-pan: heap used 255.7 MB
vue-large-graph-pan: DOM nodes -3330
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 29ms
vue-node-resize-workload: p95 frame time 58ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 51ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4959ms
vue-node-resize-workload: script duration 90ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 256.7 MB
vue-node-resize-workload: DOM nodes -3330
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 27ms
vue-zoom-out-idle: p95 frame time 58ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7711ms
vue-zoom-out-idle: script duration 103ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 250.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 10ms
workflow-execution: layout count 9
workflow-execution: style recalc count 15
workflow-execution: task duration 86ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 74.7 MB
workflow-execution: DOM nodes 120
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 11ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 184ms
agent-composer-empty-conversation-typing: script duration 80ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 86.3 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 11ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 238ms
agent-composer-long-conversation-typing: script duration 83ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 122.1 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-21T22:30:03.622Z",
  "gitSha": "234c2e5c034fe49bd9055c7cbcd6627d1007dd4c",
  "branch": "backport-21576-to-cloud-1.57",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2011.1650000000054,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.2450000000000006,
      "layouts": 11,
      "layoutDurationMs": 2.2110000000000003,
      "taskDurationMs": 372.843,
      "heapDeltaBytes": 2940372,
      "heapUsedBytes": 77720488,
      "domNodes": 0,
      "jsHeapTotalBytes": 12058624,
      "scriptDurationMs": 9.070000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2009.4889999999737,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.9579999999999997,
      "layouts": 9,
      "layoutDurationMs": 1.903,
      "taskDurationMs": 294.528,
      "heapDeltaBytes": 21687200,
      "heapUsedBytes": 87993224,
      "domNodes": 0,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 10.591,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1693.5039999999617,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 9.915000000000001,
      "layouts": 9,
      "layoutDurationMs": 1.5849999999999997,
      "taskDurationMs": 568.346,
      "heapDeltaBytes": -3144424,
      "heapUsedBytes": 72594568,
      "domNodes": 0,
      "jsHeapTotalBytes": 12058624,
      "scriptDurationMs": 93.925,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1693.8139999999748,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 13.465000000000002,
      "layouts": 9,
      "layoutDurationMs": 2.0080000000000005,
      "taskDurationMs": 671.7169999999999,
      "heapDeltaBytes": 15615404,
      "heapUsedBytes": 81421672,
      "domNodes": 0,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 116.832,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.8629999999985,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.058000000000001,
      "layouts": 12,
      "layoutDurationMs": 2.302,
      "taskDurationMs": 271.154,
      "heapDeltaBytes": 18736920,
      "heapUsedBytes": 84563460,
      "domNodes": 47,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 9.700999999999999,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1809.1130000000248,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.249,
      "layouts": 11,
      "layoutDurationMs": 2.1679999999999997,
      "taskDurationMs": 344.137,
      "heapDeltaBytes": 130584,
      "heapUsedBytes": 75434180,
      "domNodes": 47,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 10.167999999999997,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666055045871556,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 544.7800000000029,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 1.8359999999999999,
      "layouts": 10,
      "layoutDurationMs": 1.7480000000000002,
      "taskDurationMs": 330.578,
      "heapDeltaBytes": 3528968,
      "heapUsedBytes": 78815036,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 110.36599999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669696969696968,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 544.2309999999679,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 2.2190000000000003,
      "layouts": 10,
      "layoutDurationMs": 2.059,
      "taskDurationMs": 353.34200000000004,
      "heapDeltaBytes": 3914724,
      "heapUsedBytes": 79270348,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 119.846,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663636363636368,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1024.4129999999814,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 642.9749999999999,
      "heapDeltaBytes": -11231640,
      "heapUsedBytes": 81291912,
      "domNodes": -192,
      "jsHeapTotalBytes": 22028288,
      "scriptDurationMs": 41.40899999999999,
      "eventListeners": -106,
      "totalBlockingTimeMs": 368,
      "frameDurationMs": 28.700000000000006,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1068.1720000000041,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 720.733,
      "heapDeltaBytes": 1233948,
      "heapUsedBytes": 81414064,
      "domNodes": -192,
      "jsHeapTotalBytes": 13901824,
      "scriptDurationMs": 47.102000000000004,
      "eventListeners": -106,
      "totalBlockingTimeMs": 400,
      "frameDurationMs": 29.627777777777776,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 716.0119999999779,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 294.4999999999998,
      "heapDeltaBytes": -3600656,
      "heapUsedBytes": 75745292,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 96.11799999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 106,
      "frameDurationMs": 21.076470588235306,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 745.4909999999586,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 353.0799999999998,
      "heapDeltaBytes": -5287804,
      "heapUsedBytes": 76044292,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 109.741,
      "eventListeners": 0,
      "totalBlockingTimeMs": 121,
      "frameDurationMs": 22.058823529411764,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6534.374000000014,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.8709999999999993,
      "layouts": 4,
      "layoutDurationMs": 0.8240000000000001,
      "taskDurationMs": 5620.893,
      "heapDeltaBytes": 32943980,
      "heapUsedBytes": 110351780,
      "domNodes": -258,
      "jsHeapTotalBytes": 12709888,
      "scriptDurationMs": 4326.896,
      "eventListeners": -68,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 23.843065693430653,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6451.481999999998,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.3439999999999997,
      "layouts": 2,
      "layoutDurationMs": 0.3900000000000002,
      "taskDurationMs": 5480.554,
      "heapDeltaBytes": -21742376,
      "heapUsedBytes": 74668728,
      "domNodes": -258,
      "jsHeapTotalBytes": 5369856,
      "scriptDurationMs": 4173.754,
      "eventListeners": -68,
      "totalBlockingTimeMs": 21,
      "frameDurationMs": 22.317301038062283,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6635.63000000002,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.23100000000000032,
      "layouts": 2,
      "layoutDurationMs": 0.3029999999999999,
      "taskDurationMs": 5779.2300000000005,
      "heapDeltaBytes": -10481176,
      "heapUsedBytes": 86120980,
      "domNodes": -258,
      "jsHeapTotalBytes": 5632000,
      "scriptDurationMs": 4469.909000000001,
      "eventListeners": -68,
      "totalBlockingTimeMs": 145,
      "frameDurationMs": 23.274035087719298,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6274.7880000000005,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.5819999999999992,
      "layouts": 2,
      "layoutDurationMs": 0.5060000000000003,
      "taskDurationMs": 5452.24,
      "heapDeltaBytes": 1577980,
      "heapUsedBytes": 78525736,
      "domNodes": -258,
      "jsHeapTotalBytes": 5369856,
      "scriptDurationMs": 4118.493,
      "eventListeners": -68,
      "totalBlockingTimeMs": 35,
      "frameDurationMs": 24.352713178294575,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-combo-open",
      "durationMs": 159.42000000001144,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 11.411000000000001,
      "layouts": 11,
      "layoutDurationMs": 2.381,
      "taskDurationMs": 111.00600000000001,
      "heapDeltaBytes": -8130604,
      "heapUsedBytes": 79006108,
      "domNodes": 917,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 6.331,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.44285714285713,
      "p95FrameDurationMs": 50.09999999999991
    },
    {
      "name": "large-combo-open",
      "durationMs": 179.64399999999614,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 13.408999999999997,
      "layouts": 11,
      "layoutDurationMs": 2.7490000000000006,
      "taskDurationMs": 133.40099999999998,
      "heapDeltaBytes": -8215508,
      "heapUsedBytes": 79295336,
      "domNodes": 917,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 7.592999999999999,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.377777777777787,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.6650000000036,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.627,
      "layouts": 9,
      "layoutDurationMs": 1.6769999999999998,
      "taskDurationMs": 462.95000000000005,
      "heapDeltaBytes": -18995600,
      "heapUsedBytes": 77245408,
      "domNodes": -258,
      "jsHeapTotalBytes": 3571712,
      "scriptDurationMs": 25.360999999999997,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.8770000000272,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.745,
      "layouts": 8,
      "layoutDurationMs": 1.818,
      "taskDurationMs": 487.864,
      "heapDeltaBytes": -24345012,
      "heapUsedBytes": 74292208,
      "domNodes": -258,
      "jsHeapTotalBytes": 1474560,
      "scriptDurationMs": 35.454,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2178.976999999975,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 4.986,
      "layouts": 8,
      "layoutDurationMs": 1.644,
      "taskDurationMs": 1155.2820000000002,
      "heapDeltaBytes": -30386036,
      "heapUsedBytes": 67983100,
      "domNodes": -258,
      "jsHeapTotalBytes": 4882432,
      "scriptDurationMs": 536.2790000000001,
      "eventListeners": -65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66641221374046,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2182.223000000022,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 6.8100000000000005,
      "layouts": 8,
      "layoutDurationMs": 1.58,
      "taskDurationMs": 1351.935,
      "heapDeltaBytes": 10371396,
      "heapUsedBytes": 87308740,
      "domNodes": -258,
      "jsHeapTotalBytes": 90112,
      "scriptDurationMs": 631.656,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66564885496183,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3208.781999999985,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 7.620000000000001,
      "layouts": 67,
      "layoutDurationMs": 10.421,
      "taskDurationMs": 1236.6829999999998,
      "heapDeltaBytes": -11200740,
      "heapUsedBytes": 70733932,
      "domNodes": -234,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 548.879,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666321243523317,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3253.5649999999805,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 8.274000000000001,
      "layouts": 66,
      "layoutDurationMs": 11.688,
      "taskDurationMs": 1360.128,
      "heapDeltaBytes": -2360856,
      "heapUsedBytes": 75124760,
      "domNodes": -234,
      "jsHeapTotalBytes": 1175552,
      "scriptDurationMs": 580.8709999999999,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.751546391752576,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2247.140999999999,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 4.931,
      "layouts": 7,
      "layoutDurationMs": 1.1129999999999998,
      "taskDurationMs": 1393.127,
      "heapDeltaBytes": -792980,
      "heapUsedBytes": 79745920,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 659.0820000000001,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.916541353383455,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2205.555000000004,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 5.824,
      "layouts": 6,
      "layoutDurationMs": 1.4409999999999998,
      "taskDurationMs": 1444.684,
      "heapDeltaBytes": 1126648,
      "heapUsedBytes": 79324848,
      "domNodes": 0,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 688.4559999999999,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.922307692307697,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.545000000051,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.755999999999999,
      "layouts": 7,
      "layoutDurationMs": 1.5740000000000003,
      "taskDurationMs": 464.71,
      "heapDeltaBytes": -2183396,
      "heapUsedBytes": 79356416,
      "domNodes": -258,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 27.064000000000004,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.0329999999512,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.693,
      "layouts": 10,
      "layoutDurationMs": 1.761,
      "taskDurationMs": 467.334,
      "heapDeltaBytes": -2227344,
      "heapUsedBytes": 79887520,
      "domNodes": -258,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 30.077999999999992,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 509.2910000000188,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.049999999999999,
      "layouts": 9,
      "layoutDurationMs": 1.8000000000000003,
      "taskDurationMs": 309.614,
      "heapDeltaBytes": 20274460,
      "heapUsedBytes": 87211504,
      "domNodes": 0,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 103.435,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667741935483864,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 465.27800000001207,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 3.5649999999999995,
      "layouts": 10,
      "layoutDurationMs": 1.921,
      "taskDurationMs": 296.34900000000005,
      "heapDeltaBytes": 21628012,
      "heapUsedBytes": 88533000,
      "domNodes": 0,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 97.37,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66428571428573,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.8420000000156,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 1.6340000000000001,
      "layouts": 11,
      "layoutDurationMs": 1.8760000000000001,
      "taskDurationMs": 340.418,
      "heapDeltaBytes": 22420080,
      "heapUsedBytes": 89742556,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 6.918,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.7830000000272,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.8889999999999991,
      "layouts": 9,
      "layoutDurationMs": 1.827,
      "taskDurationMs": 378.096,
      "heapDeltaBytes": 21677248,
      "heapUsedBytes": 88553632,
      "domNodes": 0,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 9.431000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.2150000000424,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 12.775000000000002,
      "layouts": 11,
      "layoutDurationMs": 2.192,
      "taskDurationMs": 624.7470000000001,
      "heapDeltaBytes": -7742896,
      "heapUsedBytes": 69261356,
      "domNodes": 0,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 78.85499999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66568627450981,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1945.2689999999961,
      "styleRecalcs": 85,
      "styleRecalcDurationMs": 15.822,
      "layouts": 9,
      "layoutDurationMs": 1.9180000000000001,
      "taskDurationMs": 857.379,
      "heapDeltaBytes": 11283140,
      "heapUsedBytes": 78662864,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 91.369,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665811965811965,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 865.1429999999891,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 20.107,
      "layouts": 5,
      "layoutDurationMs": 10.475999999999999,
      "taskDurationMs": 618.1439999999998,
      "heapDeltaBytes": 7321864,
      "heapUsedBytes": 103787744,
      "domNodes": 15953,
      "jsHeapTotalBytes": 17436672,
      "scriptDurationMs": 22.767000000000003,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 115,
      "frameDurationMs": 20.635714285714283,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8223.953999999992,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 18.159000000000002,
      "layouts": 9,
      "layoutDurationMs": 1.6229999999999998,
      "taskDurationMs": 4337.579,
      "heapDeltaBytes": -17812340,
      "heapUsedBytes": 79233492,
      "domNodes": -258,
      "jsHeapTotalBytes": 6156288,
      "scriptDurationMs": 1937.3100000000002,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666125760649088,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8192.563000000064,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 18.969,
      "layouts": 9,
      "layoutDurationMs": 1.517,
      "taskDurationMs": 4390.227000000001,
      "heapDeltaBytes": -4846188,
      "heapUsedBytes": 92949116,
      "domNodes": -258,
      "jsHeapTotalBytes": 6418432,
      "scriptDurationMs": 2016.998,
      "eventListeners": -65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66598778004073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16329.977999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15299.455000000002,
      "heapDeltaBytes": -42303508,
      "heapUsedBytes": 258092988,
      "domNodes": -3330,
      "jsHeapTotalBytes": 14929920,
      "scriptDurationMs": 227.01500000000001,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 27.701018675721564,
      "p95FrameDurationMs": 50.099999999998545
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16261.152999999922,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15258.985999999999,
      "heapDeltaBytes": -19271648,
      "heapUsedBytes": 264219972,
      "domNodes": -3330,
      "jsHeapTotalBytes": 13885440,
      "scriptDurationMs": 215.749,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 27.522842639593904,
      "p95FrameDurationMs": 50.099999999998545
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15160.881999999958,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 9.771000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14620.341999999999,
      "heapDeltaBytes": -31766032,
      "heapUsedBytes": 263314236,
      "domNodes": -3330,
      "jsHeapTotalBytes": 18866176,
      "scriptDurationMs": 774.729,
      "eventListeners": -651,
      "totalBlockingTimeMs": 75,
      "frameDurationMs": 27.015658362989324,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18392.05500000003,
      "styleRecalcs": 160,
      "styleRecalcDurationMs": 14.92099999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17926.589,
      "heapDeltaBytes": -22624288,
      "heapUsedBytes": 272841708,
      "domNodes": -3330,
      "jsHeapTotalBytes": 6279168,
      "scriptDurationMs": 783.1499999999999,
      "eventListeners": -651,
      "totalBlockingTimeMs": 53,
      "frameDurationMs": 33.00287253141832,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5899.130000000014,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 51.61599999999999,
      "layouts": 20,
      "layoutDurationMs": 23.586999999999996,
      "taskDurationMs": 5736.4929999999995,
      "heapDeltaBytes": -15760516,
      "heapUsedBytes": 275257648,
      "domNodes": -3330,
      "jsHeapTotalBytes": 17293312,
      "scriptDurationMs": 105.156,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.59502762430939,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4340.037000000052,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 50.543999999999976,
      "layouts": 20,
      "layoutDurationMs": 21.450999999999997,
      "taskDurationMs": 4181.25,
      "heapDeltaBytes": -18239732,
      "heapUsedBytes": 263000656,
      "domNodes": -3330,
      "jsHeapTotalBytes": 33546240,
      "scriptDurationMs": 75.29899999999999,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.480790960451973,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8879.251000000011,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8497.006999999998,
      "heapDeltaBytes": -5958712,
      "heapUsedBytes": 252183196,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 126.63999999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.363698630136987,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7312.96199999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6925.174,
      "heapDeltaBytes": 14509940,
      "heapUsedBytes": 272274172,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 79.044,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.41371237458194,
      "p95FrameDurationMs": 49.900000000001455
    },
    {
      "name": "workflow-execution",
      "durationMs": 100.56900000000724,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.778,
      "layouts": 6,
      "layoutDurationMs": 2.5650000000000004,
      "taskDurationMs": 73.52600000000001,
      "heapDeltaBytes": 4598376,
      "heapUsedBytes": 77165880,
      "domNodes": 118,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.951999999999999,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 456.5900000000056,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 9.636000000000001,
      "layouts": 11,
      "layoutDurationMs": 2.8840000000000003,
      "taskDurationMs": 97.57400000000001,
      "heapDeltaBytes": 6748088,
      "heapUsedBytes": 79426508,
      "domNodes": 121,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.546,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66428571428571,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 240.195999999969,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.1440000000000001,
      "layouts": 76,
      "layoutDurationMs": 10.905,
      "taskDurationMs": 184.89700000000002,
      "heapDeltaBytes": 9156168,
      "heapUsedBytes": 86099808,
      "domNodes": 4,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 80.389,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.671428571428578,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 237.97899999999572,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.79,
      "layouts": 76,
      "layoutDurationMs": 10.536,
      "taskDurationMs": 183.487,
      "heapDeltaBytes": 9160516,
      "heapUsedBytes": 94959100,
      "domNodes": 4,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 78.616,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.671428571428578,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 282.38199999998415,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.637,
      "layouts": 76,
      "layoutDurationMs": 11.446,
      "taskDurationMs": 239.72500000000002,
      "heapDeltaBytes": -3064284,
      "heapUsedBytes": 135737996,
      "domNodes": 4,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 83.17899999999999,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352898,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 278.97699999994074,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.601,
      "layouts": 76,
      "layoutDurationMs": 11.155,
      "taskDurationMs": 236.227,
      "heapDeltaBytes": -2055760,
      "heapUsedBytes": 120417592,
      "domNodes": 4,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 82.327,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352898,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Line coverage: 64.5%

Coverage totals
Metric Covered Total Pct
Lines 56137 87040 64.5% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.6% 1172
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.9% 375
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 47.5% 245
src/core/webSessionIdentity.ts 3.3% 231
src/core/graph/widgets/dynamicGroupWidget.ts 0.4% 224
src/scripts/pnginfo.ts 20.7% 222

🎭 Playwright: ✅ 2285 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2263 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/21/2026, 10:20:53 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 901f44589e3839524ba9fd2ed6bf3e22173338a3

Full docs: ADR-DEVEX-LINT-0015

@github-actions
github-actions Bot requested a review from thedatalife October 21, 2026 22:20
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 21, 2026
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 0.00% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.57   #21602   +/-   ##
=============================================
  Coverage              ?   85.84%           
=============================================
  Files                 ?     2715           
  Lines                 ?   152607           
  Branches              ?    38139           
=============================================
  Hits                  ?   131007           
  Misses                ?    21210           
  Partials              ?      390           
Flag Coverage Δ
e2e 64.66% <ø> (?)
unit 85.15% <94.44%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/AgentPanelRoot.vue 94.80% <ø> (ø)
src/workbench/extensions/agent/crdt/docOpMinter.ts 96.63% <100.00%> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 97.79% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 21, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 5 finding(s).

Severity Count
🟡 Medium 2
🟢 Low 3

Panel: 6/6 reviewers contributed findings.

@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation budget remaining for this pull request: 98 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@comfy-greenlight-bot comfy-greenlight-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request at head commit 4514c3d has been reviewed and approved by Swarmhost's agentic review process.

The detailed evaluation is available to employees in the internal Slack review thread.

@comfy-pr-bot
comfy-pr-bot merged commit 9b26020 into cloud/1.57 Oct 21, 2026
188 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-21576-to-cloud-1.57 branch October 21, 2026 23:37
comfy-pr-bot pushed a commit that referenced this pull request Oct 21, 2026
…definitions in the bound document (#21576) (#21601)

Backport of #21576 to `core/1.57`.

A person who adds a subgraph blueprint while the Agent document is bound
can now edit its promoted widgets: the edit is saved instead of refused
with "Widget edit was rejected and was not saved". Production serves
`cloud/1.57`; the companion carrier for that line is #21602.

Product code is the source change unchanged. The auto-backport
conflicted only on neighbouring lines (this branch lacks #21335's longer
JSDoc and #21270's `notifyWidgetWriteRefused(nodeId, widgetName)`
signature), so each conflict was resolved by adding the one new
`docHasSubgraphDefinition` line next to this branch's existing code.

<details><summary>Full context for agent readers</summary>

- Source: #21576, merged as 44fb9d8.
Author and author date preserved; `-x` provenance line kept. No AI
co-author trailer.
- Conflict resolution, all context-only: `AgentPanelRoot.vue`
(destructure), `useAgentCrdtFollower.ts` (two dep objects),
`docOpMinter.ts` (deps interface),
`agentDisplayIntAdd.regression.test.ts` and `docOpMinter.test.ts` (test
deps). Two test adaptations: `refusals` is a counter on this branch, so
the new case asserts `toBe(0)` instead of `toEqual([])`; and the
`seededPromotedDocs` cleanup set does not exist here, so that one line
is dropped. The `core/1.57` and `cloud/1.57` carriers carry the
identical patch.
- Prerequisites already on this branch: the promoted-write refusal guard
(#20516), `readSubgraphDefinitionIds`, `reportError`, the
`SubgraphDefinition` wire type. Nothing else from `main` is pulled in.
- Black-box proof,
`browser_tests/tests/agent/agentHumanAddedBlueprintPromotedWrite.spec.ts`,
`--project=cloud`, own ComfyUI CI container 0.0.27 plus a
`DISTRIBUTION=cloud VITE_USE_LEGACY_DEFAULT_GRAPH=true` dev server:
- parent (`core/1.57` product files, new spec kept): **fails** —
rejection toast shown, document keeps "a pasted prompt".
- this head: **passes**, along with `agentHumanAddTabSwitch`,
`agentNestedSubgraphDocument` and `agentSubgraphFollower`.
- Unit: the three new `docOpMinter` cases fail on the parent and pass
here. Agent unit suite (`src/workbench/extensions/agent`): 166 files,
all passed, 1 expected fail. `typecheck` and `typecheck:browser` clean.
- Not run: a packaged Desktop build or a hosted Agent turn.
- Release-train scope: only the 1.57 trains, per the source PR's labels.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants