Repository navigation
[backport core/1.57] fix(agent): define a hand-added subgraph host's definitions in the bound document (#21576) - #21601
Conversation
…und document (#21576) Hand-added subgraph blueprint + Agent bound: promoted widget edits were refused and lost on reload. Now saved. - Cause: the minter sent only the host's `add_node`, never its definition. The doc held the host's values but could not place them, so every promoted write hit the existing refusal. - Fix: an add batch now ends with `define_subgraph` for each definition the added host needs and the doc lacks. Refusal guard unchanged. - Live in prod on 1.55.18, 1.56.3 and 1.57.0: 4 Sentry issues, ~30 events, ~24 users. <details><summary>Full context for agent readers</summary> `agent_crdt_promoted_widget_order_drift` with `declared inputs []`, from `reportOnce(docOpMinter)`: | Sentry issue | Live promoted names | Events / users | Release | | --- | --- | --- | --- | | [CLOUD-FRONTEND-PROD-2Z4](https://comfy-org.sentry.io/issues/7805196897/) | `image, upload` | 1 / 1 | 1.57.0 (stable) | | [CLOUD-FRONTEND-PROD-2WK](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-2WK) | the `Text to Image (Flux.2 Dev)` blueprint's 9 inputs | 3 / 1 | 1.57.0 | | [CLOUD-FRONTEND-PROD-2S7](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-2S7) | 7 Z-Image names | 17 / 13 | 1.56.3 | | [CLOUD-FRONTEND-PROD-25R](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-25R) | `value, value_1, model_name` | 9 / 9 | 1.55.18 | Each event has `docDeclaredNames: []` and no `docPromotedNames` (undefined), meaning the doc carries no definition for the host's type. The live names match the inputs of core blueprints in `ComfyUI/blueprints/` (2WK matches `Text to Image (Flux.2 Dev).json` exactly). 1. A person adds a blueprint (or pastes a host). `_deserializeItems` registers a fresh definition UUID live and adds the host. 2. `docOpMinter` mints `add_node` with the host's positional `widgets_values`, but no frontend path ever minted `define_subgraph`. The doc ends up with N stored values and no definition. 3. `readDocPromotedWidgets` returns `{ valueCount: N, declaredNames: [], promotedNames: undefined }`. `documentAcceptsLiveIndex` requires matching names whenever `valueCount > 0`, so every promoted write is refused as `layout_drift`. That refusal is deliberate ("marks stored values unreadable when their definition is unavailable") and is not loosened here. - `docOpMinter.flush()` collects the subgraph hosts in the batch and appends one `define_subgraph` per missing definition: the host's own plus nested ones via `findUsedSubgraphIds`, sorted dependency-first with `topologicalSortSubgraphs`. The payload is a JSON copy of `Subgraph.asSerialisable()`, the same definition shape the seed and reseed paths already send. - Definitions go after the adds and links. The applier aborts the rest of a batch after a rejection, so a refused definition cannot take the user's add down with it. - New dep `docHasSubgraphDefinition(id)` (follower: `readSubgraphDefinitionIds(doc)`) skips definitions the doc already holds, so a clone of an existing host sends nothing extra. - Echo is harmless: `registerDefinitions` skips ids the live graph already has. - Invariants: still one semantic path. The definition is minted at the command site from the graph that just changed, with no store-first write, reconcile, or raw Yjs. KEEP-ALIVE 1 and 14 hold. - Convert-to-subgraph was not exercised. If it emits a local `add_node` for the new host, it takes this same path, but that is unverified. - Docs created before this fix still lack the definition for hosts already added. Those hosts stay unwritable until a reseed or until the host is re-added. </details> - Black-box (`browser_tests/tests/agent/agentHumanAddedBlueprintPromotedWrite.spec.ts`, `@cloud @agent`): adds a promoted blueprint during a bound session, edits the promoted prompt by hand, and asserts no rejection toast and that the shared document holds the edit. **Red on `main`** (rejection toast; the browser log shows the exact prod message `Subgraph host … promotes [text], which the document's 1 stored values and declared inputs [] do not place`). **Green on this branch.** - Unit (`docOpMinter.test.ts`, 2 new): a hand-added host with a nested definition mints `[add_node, define inner, define outer]`, the real applier applies all three, the promoted write then mints and applies, and definitions the doc already holds are skipped. Both fail on `main`. - Agent unit suite: 178 files, 4039 passed. `pnpm typecheck` and `typecheck:browser` clean. Neighbouring specs green: `agentHumanAddTabSwitch` (7/7, including both blueprint cases), `agentNestedSubgraphDocument`, `agentSubgraphFollower`, `agentPromotedSeedRunWidgetWrite`. - After release: `agent_crdt_promoted_widget_order_drift` events with `docDeclaredNames: []` should stop on builds that contain this change. (cherry picked from commit 44fb9d8)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-21T22:29:14.831Z",
"gitSha": "17303425817b4cb9b56af1809e7f374f8e01bc36",
"branch": "backport-21576-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.5569999999773,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8240000000000003,
"layouts": 9,
"layoutDurationMs": 2.4080000000000004,
"taskDurationMs": 363.524,
"heapDeltaBytes": 22086988,
"heapUsedBytes": 88299968,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.882,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.862999999972,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9790000000000008,
"layouts": 10,
"layoutDurationMs": 1.9369999999999998,
"taskDurationMs": 285.06199999999995,
"heapDeltaBytes": 21996220,
"heapUsedBytes": 88312860,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.513999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.6900000000173,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.012,
"layouts": 10,
"layoutDurationMs": 3.1409999999999996,
"taskDurationMs": 532.0630000000001,
"heapDeltaBytes": -3318288,
"heapUsedBytes": 71566680,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 101.453,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.1990000000064,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.239999999999998,
"layouts": 10,
"layoutDurationMs": 2.4520000000000004,
"taskDurationMs": 528.572,
"heapDeltaBytes": -3259656,
"heapUsedBytes": 71716640,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 99.76599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.1119999999714,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.731,
"layouts": 12,
"layoutDurationMs": 2.673,
"taskDurationMs": 240.246,
"heapDeltaBytes": -4535664,
"heapUsedBytes": 70770812,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.083,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.9310000000114,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.417999999999999,
"layouts": 14,
"layoutDurationMs": 2.6760000000000006,
"taskDurationMs": 223.28900000000002,
"heapDeltaBytes": 18801684,
"heapUsedBytes": 84565504,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.588000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 432.1160000000077,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.789,
"layouts": 10,
"layoutDurationMs": 2.405,
"taskDurationMs": 296.644,
"heapDeltaBytes": 24728900,
"heapUsedBytes": 90877472,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 103.104,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 514.7899999999481,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.815,
"layouts": 10,
"layoutDurationMs": 2.5170000000000003,
"taskDurationMs": 360.829,
"heapDeltaBytes": 2398004,
"heapUsedBytes": 76889236,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 101.265,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 956.3179999999818,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.0580000000001,
"heapDeltaBytes": -3783592,
"heapUsedBytes": 80916736,
"domNodes": -192,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 38.933,
"eventListeners": -106,
"totalBlockingTimeMs": 307,
"frameDurationMs": 27.140000000000004,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 874.2819999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.05699999999996,
"heapDeltaBytes": 1723980,
"heapUsedBytes": 81121108,
"domNodes": -192,
"jsHeapTotalBytes": 14688256,
"scriptDurationMs": 35.233,
"eventListeners": -105,
"totalBlockingTimeMs": 242,
"frameDurationMs": 25.237142857142864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 696.4490000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.32899999999984,
"heapDeltaBytes": -4740868,
"heapUsedBytes": 75828472,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 94.24099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 701.8970000000309,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.93799999999976,
"heapDeltaBytes": -4473332,
"heapUsedBytes": 76233788,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 85.71400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 84,
"frameDurationMs": 20.58529411764705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6639.433999999994,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9880000000000002,
"layouts": 3,
"layoutDurationMs": 0.8669999999999998,
"taskDurationMs": 5526.859,
"heapDeltaBytes": -22394144,
"heapUsedBytes": 71775628,
"domNodes": -258,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 4213.209999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 45,
"frameDurationMs": 20.66417445482866,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6153.307999999981,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8870000000000007,
"layouts": 3,
"layoutDurationMs": 0.8500000000000001,
"taskDurationMs": 4921.412,
"heapDeltaBytes": -22962500,
"heapUsedBytes": 77165088,
"domNodes": -258,
"jsHeapTotalBytes": 15593472,
"scriptDurationMs": 3954.5130000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 22,
"frameDurationMs": 20.512040133779266,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6380.383999999993,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2550000000000001,
"layouts": 5,
"layoutDurationMs": 1.2790000000000001,
"taskDurationMs": 5188.2080000000005,
"heapDeltaBytes": -2604792,
"heapUsedBytes": 96898636,
"domNodes": -258,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 3943.442,
"eventListeners": -67,
"totalBlockingTimeMs": 18,
"frameDurationMs": 19.054029850746268,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6002.316000000008,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1149999999999998,
"layouts": 4,
"layoutDurationMs": 0.9660000000000003,
"taskDurationMs": 5026.885,
"heapDeltaBytes": 20625696,
"heapUsedBytes": 97746492,
"domNodes": -258,
"jsHeapTotalBytes": 8777728,
"scriptDurationMs": 4006.131,
"eventListeners": -68,
"totalBlockingTimeMs": 24,
"frameDurationMs": 18.632919254658383,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 209.3500000000006,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.844999999999999,
"layouts": 13,
"layoutDurationMs": 3.511,
"taskDurationMs": 143.137,
"heapDeltaBytes": -8082732,
"heapUsedBytes": 79546984,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7.388,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 137.70099999999275,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.064,
"layouts": 12,
"layoutDurationMs": 2.6950000000000003,
"taskDurationMs": 100.837,
"heapDeltaBytes": -8153256,
"heapUsedBytes": 79029496,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 5.438,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2025.2140000000054,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2,
"layouts": 9,
"layoutDurationMs": 1.8099999999999998,
"taskDurationMs": 427.703,
"heapDeltaBytes": -2049436,
"heapUsedBytes": 76990320,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 27.267999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2027.1749999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8349999999999997,
"layouts": 9,
"layoutDurationMs": 1.705,
"taskDurationMs": 379.691,
"heapDeltaBytes": -25697872,
"heapUsedBytes": 72397740,
"domNodes": -258,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 23.956000000000003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2283.7670000000116,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.382,
"layouts": 10,
"layoutDurationMs": 2.226,
"taskDurationMs": 1116.0320000000002,
"heapDeltaBytes": -29062220,
"heapUsedBytes": 68143476,
"domNodes": -258,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 540.493,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665441176470587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2190.7789999999636,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.991,
"layouts": 9,
"layoutDurationMs": 2.065,
"taskDurationMs": 1096.042,
"heapDeltaBytes": -3013008,
"heapUsedBytes": 76593464,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 538.496,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564885496183,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3399.6569999999906,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.959999999999999,
"layouts": 66,
"layoutDurationMs": 12.034,
"taskDurationMs": 1231.071,
"heapDeltaBytes": 7174152,
"heapUsedBytes": 88681152,
"domNodes": -234,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 519.466,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3235.716000000025,
"styleRecalcs": 73,
"styleRecalcDurationMs": 8.055,
"layouts": 66,
"layoutDurationMs": 11.013,
"taskDurationMs": 1199.983,
"heapDeltaBytes": -24346988,
"heapUsedBytes": 75160304,
"domNodes": -234,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 518.4830000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665979381443297,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2621.2380000000053,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.6080000000000005,
"layouts": 6,
"layoutDurationMs": 1.5370000000000001,
"taskDurationMs": 1318.2969999999998,
"heapDeltaBytes": 10446896,
"heapUsedBytes": 93233624,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 656.8040000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666455696202533,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2413.0010000000084,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.07,
"layouts": 7,
"layoutDurationMs": 1.853,
"taskDurationMs": 1373.809,
"heapDeltaBytes": 10829704,
"heapUsedBytes": 94291292,
"domNodes": 0,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 672.434,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78194444444444,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.5520000000424,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2030000000000003,
"layouts": 9,
"layoutDurationMs": 2,
"taskDurationMs": 413.294,
"heapDeltaBytes": -2974844,
"heapUsedBytes": 78725596,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 27.207,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2021.3289999999802,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8259999999999994,
"layouts": 9,
"layoutDurationMs": 1.7249999999999999,
"taskDurationMs": 389.73600000000005,
"heapDeltaBytes": -1984452,
"heapUsedBytes": 79579760,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 24.687,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.21300000001384,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.515,
"layouts": 11,
"layoutDurationMs": 2.788,
"taskDurationMs": 289.715,
"heapDeltaBytes": -1078168,
"heapUsedBytes": 75748748,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 96.891,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 446.2080000000128,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.989,
"layouts": 9,
"layoutDurationMs": 2.3899999999999997,
"taskDurationMs": 285.15299999999996,
"heapDeltaBytes": 21511664,
"heapUsedBytes": 88437812,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 98.308,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.9709999999504,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1210000000000004,
"layouts": 10,
"layoutDurationMs": 2.033,
"taskDurationMs": 265.663,
"heapDeltaBytes": 22452476,
"heapUsedBytes": 89316328,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 5.195,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.3709999999542,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.2959999999999994,
"layouts": 11,
"layoutDurationMs": 2.2880000000000003,
"taskDurationMs": 293.85499999999996,
"heapDeltaBytes": 3719816,
"heapUsedBytes": 79924216,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 6.754,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.2370000000005,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.560000000000002,
"layouts": 11,
"layoutDurationMs": 2.3150000000000004,
"taskDurationMs": 505.379,
"heapDeltaBytes": -11415756,
"heapUsedBytes": 65459972,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 77.39800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1947.242000000017,
"styleRecalcs": 85,
"styleRecalcDurationMs": 13.229,
"layouts": 10,
"layoutDurationMs": 1.787,
"taskDurationMs": 730.4050000000001,
"heapDeltaBytes": 10857372,
"heapUsedBytes": 78151500,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 73.955,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581197,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 783.1879999999956,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.970999999999998,
"layouts": 5,
"layoutDurationMs": 9.370000000000001,
"taskDurationMs": 483.95199999999994,
"heapDeltaBytes": 7218704,
"heapUsedBytes": 102444544,
"domNodes": 15953,
"jsHeapTotalBytes": 17174528,
"scriptDurationMs": 17.869999999999997,
"eventListeners": 3244,
"totalBlockingTimeMs": 75,
"frameDurationMs": 19.582499999999982,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8221.257999999978,
"styleRecalcs": 250,
"styleRecalcDurationMs": 23.564,
"layouts": 8,
"layoutDurationMs": 2.0680000000000005,
"taskDurationMs": 3699.758,
"heapDeltaBytes": -68580,
"heapUsedBytes": 79572092,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 1870.126,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8202.79499999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.968999999999998,
"layouts": 9,
"layoutDurationMs": 1.9819999999999998,
"taskDurationMs": 3497.996,
"heapDeltaBytes": 3549868,
"heapUsedBytes": 82512788,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 1701.786,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666056910569107,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15685.13999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14887.063999999998,
"heapDeltaBytes": -12022844,
"heapUsedBytes": 284474164,
"domNodes": -3107,
"jsHeapTotalBytes": -10493952,
"scriptDurationMs": 206.537,
"eventListeners": -608,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.85393835616438,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14895.569000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14187.562,
"heapDeltaBytes": -5449956,
"heapUsedBytes": 276425808,
"domNodes": -3330,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 181.512,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.238578680203048,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 18412.96,
"styleRecalcs": 149,
"styleRecalcDurationMs": 14.304999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18048.825,
"heapDeltaBytes": -18737696,
"heapUsedBytes": 262296940,
"domNodes": -3330,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 638.1569999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 18,
"frameDurationMs": 34.166790352504634,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18146.917999999914,
"styleRecalcs": 157,
"styleRecalcDurationMs": 12.933,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17639.572,
"heapDeltaBytes": -3330796,
"heapUsedBytes": 278627936,
"domNodes": -3330,
"jsHeapTotalBytes": 10739712,
"scriptDurationMs": 619.211,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 32.29395017793595,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5839.505000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.437,
"layouts": 20,
"layoutDurationMs": 23.883000000000003,
"taskDurationMs": 5705.164,
"heapDeltaBytes": -22496136,
"heapUsedBytes": 259421408,
"domNodes": -3330,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 102.50299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.58715083798882,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 5464.712000000077,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.31199999999999,
"layouts": 20,
"layoutDurationMs": 18.132999999999996,
"taskDurationMs": 5346.093999999999,
"heapDeltaBytes": 20294828,
"heapUsedBytes": 297325160,
"domNodes": -3330,
"jsHeapTotalBytes": 35639296,
"scriptDurationMs": 79.58999999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.02848484848485,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7799.164000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7473.541000000001,
"heapDeltaBytes": 8479864,
"heapUsedBytes": 260631956,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.302,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.11744966442953,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7175.220999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6597.012,
"heapDeltaBytes": -10370128,
"heapUsedBytes": 258414804,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 80.162,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.292542372881353,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 88.82399999998825,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.313,
"layouts": 6,
"layoutDurationMs": 1.311,
"taskDurationMs": 51.387,
"heapDeltaBytes": 4591256,
"heapUsedBytes": 77136184,
"domNodes": 97,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.23,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.680000000000017,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 74.84800000008818,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.6530000000000005,
"layouts": 5,
"layoutDurationMs": 2.0869999999999997,
"taskDurationMs": 53.602999999999994,
"heapDeltaBytes": -15494552,
"heapUsedBytes": 68406584,
"domNodes": 116,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 3.2000000000000006,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 168.38700000005247,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8270000000000001,
"layouts": 76,
"layoutDurationMs": 9.312000000000001,
"taskDurationMs": 135.474,
"heapDeltaBytes": 8527068,
"heapUsedBytes": 85624392,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 57.417,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67272727272724,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 187.3199999999997,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8109999999999999,
"layouts": 76,
"layoutDurationMs": 9.635,
"taskDurationMs": 150.712,
"heapDeltaBytes": 8760316,
"heapUsedBytes": 100211128,
"domNodes": 4,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 63.632999999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.658333333333342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 224.81200000004264,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.355,
"layouts": 76,
"layoutDurationMs": 9.871,
"taskDurationMs": 195.12500000000003,
"heapDeltaBytes": -7468472,
"heapUsedBytes": 110478036,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 66.161,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67333333333333,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 228.1039999999166,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.435,
"layouts": 76,
"layoutDurationMs": 9.411,
"taskDurationMs": 197.41500000000002,
"heapDeltaBytes": 8021172,
"heapUsedBytes": 158483720,
"domNodes": 4,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 60.869,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2282 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4e2638e2b35bd95708ddb6d0ca2f76bff7e5eea9
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.57 #21601 +/- ##
============================================
Coverage 85.81% 85.81%
============================================
Files 2704 2704
Lines 151961 151993 +32
Branches 40571 38468 -2103
============================================
+ Hits 130406 130436 +30
- Misses 21167 21169 +2
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 4 |
| 🟢 Low | 3 |
Panel: 6/6 reviewers contributed findings.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 47626ed has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
… definitions in the bound document (#21576) (#21602) Backport of #21576 to `cloud/1.57`. A person who adds a subgraph blueprint while the Agent document is bound can now edit its promoted widgets: the edit is saved instead of refused with "Widget edit was rejected and was not saved". Production serves `cloud/1.57`, so Cloud gets the fix from the next `cloud/1.57` patch promotion. Companion `core/1.57` carrier: #21601. Product code is the source change unchanged. The auto-backport conflicted only on neighbouring lines (this branch lacks #21335's longer JSDoc and #21270's `notifyWidgetWriteRefused(nodeId, widgetName)` signature), so each conflict was resolved by adding the one new `docHasSubgraphDefinition` line next to this branch's existing code. <details><summary>Full context for agent readers</summary> - Source: #21576, merged as 44fb9d8. Author and author date preserved; `-x` provenance line kept. No AI co-author trailer. - Conflict resolution, all context-only: `AgentPanelRoot.vue` (destructure), `useAgentCrdtFollower.ts` (two dep objects), `docOpMinter.ts` (deps interface), `agentDisplayIntAdd.regression.test.ts` and `docOpMinter.test.ts` (test deps). Two test adaptations: `refusals` is a counter on this branch, so the new case asserts `toBe(0)` instead of `toEqual([])`; and the `seededPromotedDocs` cleanup set does not exist here, so that one line is dropped. The `core/1.57` and `cloud/1.57` carriers carry the identical patch. - Prerequisites already on this branch: the promoted-write refusal guard (#20516), `readSubgraphDefinitionIds`, `reportError`, the `SubgraphDefinition` wire type. Nothing else from `main` is pulled in. - Black-box proof, `browser_tests/tests/agent/agentHumanAddedBlueprintPromotedWrite.spec.ts`, `--project=cloud`, own ComfyUI CI container 0.0.27 plus a `DISTRIBUTION=cloud VITE_USE_LEGACY_DEFAULT_GRAPH=true` dev server: - parent (`cloud/1.57` product files, new spec kept): **fails** — rejection toast shown, document keeps "a pasted prompt". - this head: **passes**, along with `agentHumanAddTabSwitch`, `agentNestedSubgraphDocument` and `agentSubgraphFollower`. - Unit: the three new `docOpMinter` cases fail on the parent and pass here. Agent unit suite (`src/workbench/extensions/agent`): 166 files, all passed, 1 expected fail. `typecheck` and `typecheck:browser` clean. - Not run: a packaged Desktop build or a hosted Agent turn. - Release-train scope: only the 1.57 trains, per the source PR's labels. </details>
Backport of #21576 to
core/1.57.A person who adds a subgraph blueprint while the Agent document is bound can now edit its promoted widgets: the edit is saved instead of refused with "Widget edit was rejected and was not saved". Production serves
cloud/1.57; the companion carrier for that line is #21602.Product code is the source change unchanged. The auto-backport conflicted only on neighbouring lines (this branch lacks #21335's longer JSDoc and #21270's
notifyWidgetWriteRefused(nodeId, widgetName)signature), so each conflict was resolved by adding the one newdocHasSubgraphDefinitionline next to this branch's existing code.Full context for agent readers
-xprovenance line kept. No AI co-author trailer.AgentPanelRoot.vue(destructure),useAgentCrdtFollower.ts(two dep objects),docOpMinter.ts(deps interface),agentDisplayIntAdd.regression.test.tsanddocOpMinter.test.ts(test deps). Two test adaptations:refusalsis a counter on this branch, so the new case assertstoBe(0)instead oftoEqual([]); and theseededPromotedDocscleanup set does not exist here, so that one line is dropped. Thecore/1.57andcloud/1.57carriers carry the identical patch.readSubgraphDefinitionIds,reportError, theSubgraphDefinitionwire type. Nothing else frommainis pulled in.browser_tests/tests/agent/agentHumanAddedBlueprintPromotedWrite.spec.ts,--project=cloud, own ComfyUI CI container 0.0.27 plus aDISTRIBUTION=cloud VITE_USE_LEGACY_DEFAULT_GRAPH=truedev server:core/1.57product files, new spec kept): fails — rejection toast shown, document keeps "a pasted prompt".agentHumanAddTabSwitch,agentNestedSubgraphDocumentandagentSubgraphFollower.docOpMintercases fail on the parent and pass here. Agent unit suite (src/workbench/extensions/agent): 166 files, all passed, 1 expected fail.typecheckandtypecheck:browserclean.