Repository navigation
[backport cloud/1.57] fix: resolve the multiline widget store id from its current name - #21446
Conversation
) `addMultilineWidget` built its `getValue` / `setValue` closures around the widget name it was created with. When a DynamicGroup row shift renames the widget, the widget's name setter moves its store entry to the new id, but the textarea kept reading and writing the old one. After a middle row was removed, `loras.1.text` would still edit `loras.2.text`, and its writes could register an orphan entry that blocks a later rename into that slot. The closures now resolve the store id from the widget's current name. They find the widget instance once, by its textarea element, while `addDOMWidget` is still adding it, when `ensureUniqueWidgetNames` may already have renamed a duplicate (for example `prompt` to `prompt#1`). After that they keep the instance, so a replaced `element` doesn't matter. They also remember the `WidgetState` they last resolved, which `renameWidget` carries across renames. A widget counts as detached only when it is out of `node.widgets` and the entry at its id is no longer that state (deleted by `removeWidget`, or now owned by another widget). A detached widget reads and writes only its textarea. A widget an extension merely splices out keeps writing its own entry. This latent bug affects any DynamicGroup row with a multiline STRING field. No shipped node uses one yet. - Fixes #21093 - Follow-up: #21323 (the widget can't yet tell whether the store entry it resolves is its own after removal or replacement) | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: resolve a renamed multiline widget's store entry by its current name` (f7d6fc4) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39136256024) | Proves the test catches the bug | | `fix: resolve the multiline widget store id from its current name` (606901d) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39137177712) | Proves the fix resolves the bug | | `test: cover a multiline widget renamed to a unique name while it is added` (e8161b0) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39139714397) | A duplicate renamed during construction read its sibling's entry | | `fix: find the multiline widget by its element while it is being added` (d412e9d) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39140649304) | The current name is used during construction too | | `test: keep a multiline widget's store entry after it leaves the widget list` (077cf90) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39143211120) | A removed widget fell back to its creation name and read the sibling's entry | | `fix: keep the last resolved name when the multiline widget is not in the list` (4ac4f9f) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39143923582) | The last resolved name is kept | | `test: leave the store alone after a removed multiline widget's name is reused` (6754ed0) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39146616716) | A removed widget's cached name pointed at the widget that reused it | | `fix: stop using the store once the multiline widget leaves its node` (76d45d6) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39147540180) | A detached widget no longer reads or writes the store | | `test: keep a spliced-out or re-elemented multiline widget on its own entry` (c9ef031) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39150497995) | Splicing out or replacing the element stopped store writes | | `fix: track the multiline widget's own store entry instead of its listing` (1fd6eee) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39151317338) | Detachment is decided by state identity | - [x] CI red on test-only commit (only the new rename case fails) - [x] CI green on fix commit - Unit, on a real `LGraph` node: after a rename through the `BaseWidget` name setter, writes land on the moved entry and nothing is left under the old name. A multiline widget whose duplicate name is made unique while it is added starts from its own default and leaves the sibling's entry alone, keeps writing its own entry while spliced out or after its element is replaced, and once removed neither reads nor overwrites the entry of a widget that later takes its name. The existing case where a saved value is restored synchronously during construction still passes. (cherry picked from commit e7056e8)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-20T10:59:42.627Z",
"gitSha": "af5bf33d9e9e01ca5c4cae3a09459fd5e4cc979d",
"branch": "backport-21293-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.351999999974,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2980000000000005,
"layouts": 9,
"layoutDurationMs": 2.3750000000000004,
"taskDurationMs": 497.748,
"heapDeltaBytes": 22137236,
"heapUsedBytes": 88012344,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.123,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2015.8509999999978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4449999999999994,
"layouts": 9,
"layoutDurationMs": 2.392,
"taskDurationMs": 503.741,
"heapDeltaBytes": 22180280,
"heapUsedBytes": 88067396,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.360999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.3219999999837,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.736000000000002,
"layouts": 10,
"layoutDurationMs": 2.587,
"taskDurationMs": 827.958,
"heapDeltaBytes": -8282336,
"heapUsedBytes": 66691768,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 143.88400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.3790000000963,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.219000000000001,
"layouts": 9,
"layoutDurationMs": 2.7,
"taskDurationMs": 881.2860000000002,
"heapDeltaBytes": 15601756,
"heapUsedBytes": 81426052,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 156.784,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0329999999963,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.194,
"layouts": 12,
"layoutDurationMs": 2.9830000000000005,
"taskDurationMs": 386.748,
"heapDeltaBytes": -4542632,
"heapUsedBytes": 70011096,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 12.03,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.881999999956,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.253,
"layouts": 11,
"layoutDurationMs": 2.8409999999999997,
"taskDurationMs": 277.138,
"heapDeltaBytes": 18311388,
"heapUsedBytes": 84643604,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 12.223999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 698.7790000000018,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7390000000000003,
"layouts": 9,
"layoutDurationMs": 2.313,
"taskDurationMs": 501.84700000000004,
"heapDeltaBytes": 2447356,
"heapUsedBytes": 76968884,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 161.42199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.08499999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 708.7650000000849,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.935,
"layouts": 9,
"layoutDurationMs": 2.586,
"taskDurationMs": 506.1359999999999,
"heapDeltaBytes": 8107972,
"heapUsedBytes": 84054132,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 168.48,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1203.3999999999878,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 832.667,
"heapDeltaBytes": -11711496,
"heapUsedBytes": 81176700,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 56.254,
"eventListeners": -106,
"totalBlockingTimeMs": 512,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1163.9330000000427,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 870.974,
"heapDeltaBytes": 576716,
"heapUsedBytes": 81403964,
"domNodes": -192,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 58.13499999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 499,
"frameDurationMs": 32.40833333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.8760000000148,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.9370000000003,
"heapDeltaBytes": -4705196,
"heapUsedBytes": 74964400,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 137.30100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 213,
"frameDurationMs": 24.53611111111109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.7579999998898,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.0870000000004,
"heapDeltaBytes": -5212852,
"heapUsedBytes": 76183952,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 138.488,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9268.45400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8482.592999999999,
"heapDeltaBytes": -28110644,
"heapUsedBytes": 71900144,
"domNodes": -258,
"jsHeapTotalBytes": 14020608,
"scriptDurationMs": 6742.932,
"eventListeners": -68,
"totalBlockingTimeMs": 479,
"frameDurationMs": 31.688095238095237,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8946.504000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8121.220000000001,
"heapDeltaBytes": 8032924,
"heapUsedBytes": 96267440,
"domNodes": -278,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 6505.77,
"eventListeners": -68,
"totalBlockingTimeMs": 164,
"frameDurationMs": 28.05548589341693,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8929.365000000018,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5929999999999997,
"layouts": 2,
"layoutDurationMs": 0.6829999999999996,
"taskDurationMs": 8043.965,
"heapDeltaBytes": -10950396,
"heapUsedBytes": 88097148,
"domNodes": -258,
"jsHeapTotalBytes": 10612736,
"scriptDurationMs": 6729.557000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 259,
"frameDurationMs": 29.138562091503267,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9107.79500000001,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.209,
"layouts": 1,
"layoutDurationMs": 0.20799999999999985,
"taskDurationMs": 8147.136999999999,
"heapDeltaBytes": -4238260,
"heapUsedBytes": 83495980,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 6567.583,
"eventListeners": -68,
"totalBlockingTimeMs": 176,
"frameDurationMs": 28.050153846153844,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 227.79400000001715,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.192999999999998,
"layouts": 12,
"layoutDurationMs": 3.5010000000000003,
"taskDurationMs": 163.924,
"heapDeltaBytes": -8104408,
"heapUsedBytes": 79079776,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.887,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.670000000000027,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 206.68899999998303,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.636999999999999,
"layouts": 11,
"layoutDurationMs": 3.3080000000000003,
"taskDurationMs": 146.58799999999997,
"heapDeltaBytes": -7590604,
"heapUsedBytes": 80152552,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.365,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222227,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2055.3560000000175,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7590000000000012,
"layouts": 8,
"layoutDurationMs": 2.72,
"taskDurationMs": 645.3440000000002,
"heapDeltaBytes": -24938292,
"heapUsedBytes": 73811788,
"domNodes": -258,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 36.55199999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.3949999999895,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.333,
"layouts": 7,
"layoutDurationMs": 2.4299999999999997,
"taskDurationMs": 566.9040000000001,
"heapDeltaBytes": -3375276,
"heapUsedBytes": 76116784,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 34.474000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2340.842000000009,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.984,
"layouts": 9,
"layoutDurationMs": 2.1420000000000003,
"taskDurationMs": 1651.262,
"heapDeltaBytes": -29191152,
"heapUsedBytes": 68839324,
"domNodes": -258,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 813.692,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2635.711000000015,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.813,
"layouts": 6,
"layoutDurationMs": 1.6880000000000002,
"taskDurationMs": 1723.3719999999998,
"heapDeltaBytes": -1608776,
"heapUsedBytes": 78486864,
"domNodes": -258,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 795.388,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.771974522292993,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3428.752999999972,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.914999999999998,
"layouts": 64,
"layoutDurationMs": 11.118999999999998,
"taskDurationMs": 1495.766,
"heapDeltaBytes": 741352,
"heapUsedBytes": 82434524,
"domNodes": 24,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 755.755,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74731707317073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3936.25099999997,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.304,
"layouts": 64,
"layoutDurationMs": 11.549,
"taskDurationMs": 1839.6559999999997,
"heapDeltaBytes": 8274316,
"heapUsedBytes": 90459908,
"domNodes": -234,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 801.3240000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73659574468085,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2976.5879999999925,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.734999999999999,
"layouts": 6,
"layoutDurationMs": 1.6940000000000002,
"taskDurationMs": 1915.756,
"heapDeltaBytes": 2551332,
"heapUsedBytes": 81142544,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 963.3839999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3242.31199999997,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.027,
"layouts": 4,
"layoutDurationMs": 1.261,
"taskDurationMs": 2131.6440000000002,
"heapDeltaBytes": 6278156,
"heapUsedBytes": 85148748,
"domNodes": -258,
"jsHeapTotalBytes": 8409088,
"scriptDurationMs": 1061.268,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.839583333333334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.953000000025,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.85,
"layouts": 7,
"layoutDurationMs": 1.8420000000000003,
"taskDurationMs": 633.554,
"heapDeltaBytes": -18075824,
"heapUsedBytes": 80168408,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 32.85999999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2026.886999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9949999999999994,
"layouts": 8,
"layoutDurationMs": 2.169,
"taskDurationMs": 636.5730000000001,
"heapDeltaBytes": -23223772,
"heapUsedBytes": 75720248,
"domNodes": -258,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 37.87500000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 621.6469999999958,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.054,
"layouts": 9,
"layoutDurationMs": 2.5880000000000005,
"taskDurationMs": 425.014,
"heapDeltaBytes": 3319432,
"heapUsedBytes": 80073752,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 145.05,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.4329999999709,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.981999999999999,
"layouts": 8,
"layoutDurationMs": 2.451,
"taskDurationMs": 428.989,
"heapDeltaBytes": 20712372,
"heapUsedBytes": 87696800,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 149.34300000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.6469999999922,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8529999999999998,
"layouts": 10,
"layoutDurationMs": 2.869,
"taskDurationMs": 379.815,
"heapDeltaBytes": 22453416,
"heapUsedBytes": 89440748,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.405999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.0299999999488,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.999000000000001,
"layouts": 10,
"layoutDurationMs": 2.6769999999999996,
"taskDurationMs": 537.764,
"heapDeltaBytes": 3751696,
"heapUsedBytes": 80874556,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 10.591999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.2620000000434,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.741000000000001,
"layouts": 9,
"layoutDurationMs": 2.328,
"taskDurationMs": 815.237,
"heapDeltaBytes": 15703168,
"heapUsedBytes": 92193992,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 107.501,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.4970000000694,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.113,
"layouts": 9,
"layoutDurationMs": 2.523,
"taskDurationMs": 691.917,
"heapDeltaBytes": 11259696,
"heapUsedBytes": 78759188,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 111.42099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 966.9579999999769,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.730000000000004,
"layouts": 5,
"layoutDurationMs": 14.994,
"taskDurationMs": 764.3210000000003,
"heapDeltaBytes": 7230936,
"heapUsedBytes": 103083152,
"domNodes": 15953,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 25.226,
"eventListeners": 3244,
"totalBlockingTimeMs": 143,
"frameDurationMs": 21.480000000000008,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "viewport-pan-sweep",
"durationMs": 8537.683999999956,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.889,
"layouts": 7,
"layoutDurationMs": 1.9300000000000002,
"taskDurationMs": 5583.159000000001,
"heapDeltaBytes": 9437576,
"heapUsedBytes": 88606824,
"domNodes": -258,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 2530.862,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.731311154598828,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9930.778000000031,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.48,
"layouts": 8,
"layoutDurationMs": 2.077,
"taskDurationMs": 6122.948,
"heapDeltaBytes": -4755796,
"heapUsedBytes": 92561176,
"domNodes": -258,
"jsHeapTotalBytes": 6123520,
"scriptDurationMs": 2886.58,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.722091062394604,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23237.934999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22822.824,
"heapDeltaBytes": -14654444,
"heapUsedBytes": 286234560,
"domNodes": -3330,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 342.603,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.29289428076257,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 23403.009999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23009.191000000003,
"heapDeltaBytes": 2115924,
"heapUsedBytes": 285078992,
"domNodes": -3330,
"jsHeapTotalBytes": 9166848,
"scriptDurationMs": 371.344,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.93653846153846,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 27902.751999999964,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.832000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27549.855,
"heapDeltaBytes": -2339480,
"heapUsedBytes": 288326540,
"domNodes": -3330,
"jsHeapTotalBytes": 10665984,
"scriptDurationMs": 851.8019999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 34,
"frameDurationMs": 52.50866290018832,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 28273.57500000005,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27930.999999999996,
"heapDeltaBytes": -25842116,
"heapUsedBytes": 271139924,
"domNodes": -3330,
"jsHeapTotalBytes": 10739712,
"scriptDurationMs": 926.0500000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 20,
"frameDurationMs": 53.331320754716984,
"p95FrameDurationMs": 116.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 8270.207000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.70700000000001,
"layouts": 20,
"layoutDurationMs": 22.615999999999996,
"taskDurationMs": 8164.020999999998,
"heapDeltaBytes": -8551332,
"heapUsedBytes": 273199208,
"domNodes": -3330,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 129.911,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.62588235294116,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6067.608000000064,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.76299999999999,
"layouts": 20,
"layoutDurationMs": 23.656999999999982,
"taskDurationMs": 5945.015,
"heapDeltaBytes": -41730088,
"heapUsedBytes": 259924740,
"domNodes": -3330,
"jsHeapTotalBytes": 18862080,
"scriptDurationMs": 107.34299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 21,
"frameDurationMs": 35.68529411764706,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11371.321999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11142.669999999998,
"heapDeltaBytes": -4952012,
"heapUsedBytes": 248006248,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.481,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.66020408163266,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8284.09899999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7802.105000000001,
"heapDeltaBytes": -18664660,
"heapUsedBytes": 259074064,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.59499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.1734693877551,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 108.77000000004955,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.446,
"layouts": 8,
"layoutDurationMs": 2.681,
"taskDurationMs": 83.225,
"heapDeltaBytes": 4605464,
"heapUsedBytes": 77691312,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.013000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 461.7520000000468,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.139,
"layouts": 11,
"layoutDurationMs": 3.471,
"taskDurationMs": 112.63199999999999,
"heapDeltaBytes": -13459396,
"heapUsedBytes": 70082048,
"domNodes": 95,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.702,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660714285714285,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 478.54800000004616,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5150000000000001,
"layouts": 76,
"layoutDurationMs": 16.673000000000002,
"taskDurationMs": 440.564,
"heapDeltaBytes": 11419444,
"heapUsedBytes": 84581148,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 210.41,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 503.96999999998116,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.027,
"layouts": 76,
"layoutDurationMs": 15.032,
"taskDurationMs": 454.10599999999994,
"heapDeltaBytes": -21123680,
"heapUsedBytes": 70828980,
"domNodes": 4,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 221.669,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 601.951999999983,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2929999999999997,
"layouts": 76,
"layoutDurationMs": 16.034,
"taskDurationMs": 564.75,
"heapDeltaBytes": 1108348,
"heapUsedBytes": 123506200,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 234.042,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.594444444444434,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 597.5399999999809,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.166,
"layouts": 76,
"layoutDurationMs": 15.471,
"taskDurationMs": 547.2230000000001,
"heapDeltaBytes": -106480,
"heapUsedBytes": 131300152,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 217.147,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.140000000000015,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2285 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f0acebb826e9ce86097db63213a3bc9e07f1a520
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21446 +/- ##
=============================================
Coverage ? 86.73%
=============================================
Files ? 2663
Lines ? 149441
Branches ? 38643
=============================================
Hits ? 129613
Misses ? 19438
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #21293 to
cloud/1.57.The cherry-pick conflicted on one import in
useStringWidget.ts: #19189, which movedDOMWidgetOptionsto@/types/domWidget, is not on this branch, so the backport keeps importing it from@/scripts/domWidget.useStringWidget.test.tspasses (10 tests), andpnpm typecheckpasses.