Repository navigation
[backport cloud/1.56] fix(agent): send human links into widget inputs the agent-built doc lacks (PM-1897) - #21260
Conversation
…acks (PM-1897) (#21244) *PR Created by the Glary-Bot Agent* --- Reported for local rc34: the agent said `frame_load_cap` on Load Video (VHS) and an agent-made custom node was "a plain widget = 1000" when the user had wired a PrimitiveInt into both. Linear: PM-1897. ## Cause - When the agent creates a node, comfy-cli `workflow_ops._build_node` puts only its link inputs (`p.is_link`) into the CRDT doc. Widget-backed inputs like `frame_load_cap` get no input slot. - On the canvas, the same node does have a `frame_load_cap` socket. - When the user wires into that socket, `mintConnect` resolves the target by name against the doc's inputs (`docInputIndex`) and finds nothing. It only reports `agent_crdt_link_slot_not_in_doc` and never sends the connect. - So the doc, and the agent's `workflow print`, keep showing the static widget value. ## Commits 1. **Failing regression test** (`agentBuiltWidgetInputLink.regression.test.ts`). It sends a human connect through the real `attachDocOpMinter`, applies it with the pinned `comfy-multi-player` applier, then runs `project()` on the doc. On this commit no ops are minted, so the test fails. 2. **Fix** (pushed as a follow-up commit). When the doc has no slot for a widget-backed input, `mintConnect` sends a `grow` connect carrying the widget name. This is the same payload already used for autogrow inputs. The applier appends a named, widget-backed slot, and peers resolve it by name. The bypass half of the same report (Video Combine shown as bypassed) did not reproduce, so it is out of scope here. ## Status The fix commit is pushed. The regression test fails without the fix and passes with it. All other `agent/crdt` tests still pass, except `agentSubgraphDefinitions.test.ts > scans deeply nested definition ids`, which already fails on `main` with a stack overflow. ## Known limitation (follow-up) There is a narrow window after the user draws the link and before the server echoes the new slot back. During it, the local doc has no slot for this input yet: - **Disconnect in that window:** the disconnect is dropped, so the doc keeps a link the user already removed. - **Replace in that window:** a second grow is sent, so the doc ends up with two slots (`frame_load_cap` and `frame_load_cap.frame_load_cap0`). `main` already has the same weakness for autogrow inputs. The proper fix is to track grows that haven't been echoed yet, keyed by node and input name, and let a later disconnect or reconnect act on that pending slot. It could also be fixed on the applier side: comfy-multi-player could treat a grow that carries `widget` as a claim on an existing slot with the same name. ## Follow-ups (tracked) - Grow echo window (disconnect/replace before the echo): https://linear.app/comfyorg/issue/FE-3472 - Undo/redo restore drops a link into a doc-absent slot: https://linear.app/comfyorg/issue/FE-3473 - Root-cause companion for new agent-built nodes: Comfy-Org/comfy-cli#1028. A third test case pins that once the doc carries the widget socket (the shape that PR writes), the minter sends an ordinary connect with no grow. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-18T06:26:22.776Z",
"gitSha": "9d6d12e50b2ee547cb2d6bce8feb16dcadb56be1",
"branch": "backport-21244-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.207000000004,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.6480000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.84999999999997,
"heapDeltaBytes": 1313928,
"heapUsedBytes": 69066136,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.367000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2014.6369999999933,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.139,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.57900000000006,
"heapDeltaBytes": 635416,
"heapUsedBytes": 68842972,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.790000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1836.277999999993,
"styleRecalcs": 76,
"styleRecalcDurationMs": 20.737,
"layouts": 12,
"layoutDurationMs": 4.682,
"taskDurationMs": 888.966,
"heapDeltaBytes": -28531560,
"heapUsedBytes": 73765864,
"domNodes": -232,
"jsHeapTotalBytes": -4194304,
"scriptDurationMs": 169.59199999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.7880000000287,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.339,
"layouts": 12,
"layoutDurationMs": 4.267,
"taskDurationMs": 810.8590000000002,
"heapDeltaBytes": -2508000,
"heapUsedBytes": 65238836,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 167.319,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.3439999999914,
"styleRecalcs": 29,
"styleRecalcDurationMs": 10.833,
"layouts": 6,
"layoutDurationMs": 1.4110000000000003,
"taskDurationMs": 386.044,
"heapDeltaBytes": 3577608,
"heapUsedBytes": 70597404,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.285000000000007,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.4730000000409,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.145,
"layouts": 6,
"layoutDurationMs": 1.031,
"taskDurationMs": 268.43300000000005,
"heapDeltaBytes": 4159180,
"heapUsedBytes": 72191756,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.070000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 706.7000000000121,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.106999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.518,
"heapDeltaBytes": -6701820,
"heapUsedBytes": 60831200,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 167.711,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 708.9479999999639,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.728,
"heapDeltaBytes": -6746500,
"heapUsedBytes": 60285596,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 167.457,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1201.7119999999863,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 887.67,
"heapDeltaBytes": 15643548,
"heapUsedBytes": 85265804,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 80.66000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 571,
"frameDurationMs": 35.291176470588226,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1157.289999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 823.6410000000001,
"heapDeltaBytes": 15622080,
"heapUsedBytes": 83999060,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 68.22,
"eventListeners": 0,
"totalBlockingTimeMs": 536,
"frameDurationMs": 34.851515151515166,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.789999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.8199999999998,
"heapDeltaBytes": 17274556,
"heapUsedBytes": 101922392,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.88099999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 899.8300000000654,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.85100000000034,
"heapDeltaBytes": 17623324,
"heapUsedBytes": 103480392,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 202.79100000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 259,
"frameDurationMs": 25.71142857142856,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11401.708000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10380.358999999999,
"heapDeltaBytes": 20414900,
"heapUsedBytes": 104732080,
"domNodes": -142,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 8671.245,
"eventListeners": -78,
"totalBlockingTimeMs": 1839,
"frameDurationMs": 34.8611620795107,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10414.744999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9487.064,
"heapDeltaBytes": 18257548,
"heapUsedBytes": 87014264,
"domNodes": -142,
"jsHeapTotalBytes": -5640192,
"scriptDurationMs": 7869.860999999999,
"eventListeners": -70,
"totalBlockingTimeMs": 1147,
"frameDurationMs": 32.65266457680251,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10202.61800000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9219.752,
"heapDeltaBytes": 16283292,
"heapUsedBytes": 94269444,
"domNodes": -142,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 7615.897,
"eventListeners": -78,
"totalBlockingTimeMs": 1200,
"frameDurationMs": 33.115584415584415,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9370.846000000029,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5669999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8546.890000000001,
"heapDeltaBytes": 17574568,
"heapUsedBytes": 94972140,
"domNodes": -142,
"jsHeapTotalBytes": -4591616,
"scriptDurationMs": 6994.927,
"eventListeners": -74,
"totalBlockingTimeMs": 879,
"frameDurationMs": 32.521874999999994,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2015.3829999999857,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.541000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.5620000000001,
"heapDeltaBytes": -7486252,
"heapUsedBytes": 77040692,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 37.519999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2017.353000000071,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.157000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.88199999999995,
"heapDeltaBytes": -10322084,
"heapUsedBytes": 77203592,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.705,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2375.201000000004,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.932,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1590.6239999999998,
"heapDeltaBytes": 2026332,
"heapUsedBytes": 65102528,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 830.964,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78439716312057,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2511.3549999999805,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.924000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1623.44,
"heapDeltaBytes": -17973220,
"heapUsedBytes": 70002276,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 853.3340000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3719.494999999995,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.371,
"layouts": 60,
"layoutDurationMs": 15.053,
"taskDurationMs": 1709.597,
"heapDeltaBytes": 5942840,
"heapUsedBytes": 73457116,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 795.202,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66547085201794,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3608.159999999998,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.087,
"layouts": 60,
"layoutDurationMs": 14.587,
"taskDurationMs": 1703.1140000000003,
"heapDeltaBytes": -19999876,
"heapUsedBytes": 69898560,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 806.179,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3136.7400000000316,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.4479999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2021.627,
"heapDeltaBytes": 18982196,
"heapUsedBytes": 101899336,
"domNodes": 0,
"jsHeapTotalBytes": 1503232,
"scriptDurationMs": 1058.9070000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84462365591398,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3104.7549999999546,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.989999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1882.4889999999998,
"heapDeltaBytes": 8178216,
"heapUsedBytes": 77398096,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 982.2109999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756216216216213,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2013.054000000011,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.3500000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.288,
"heapDeltaBytes": -10482328,
"heapUsedBytes": 78666536,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.44099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2013.1920000000036,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.076000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.4749999999999,
"heapDeltaBytes": -9992312,
"heapUsedBytes": 77963704,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 33.32800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 636.3139999999703,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.958000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.78900000000004,
"heapDeltaBytes": -12208076,
"heapUsedBytes": 57873168,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 155.572,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.1959999999926,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.91,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.39799999999997,
"heapDeltaBytes": -11674724,
"heapUsedBytes": 57974272,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 147.079,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.6979999999576,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.907,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.05800000000005,
"heapDeltaBytes": 1166436,
"heapUsedBytes": 71340560,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.946000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.3989999999785,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.183999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.15000000000003,
"heapDeltaBytes": 1207656,
"heapUsedBytes": 71254048,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.002000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.1270000000186,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.207,
"layouts": 16,
"layoutDurationMs": 5.707,
"taskDurationMs": 792.36,
"heapDeltaBytes": -5886848,
"heapUsedBytes": 64557064,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 116.02199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.0020000000886,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.724999999999998,
"layouts": 16,
"layoutDurationMs": 5.452999999999999,
"taskDurationMs": 766.5970000000001,
"heapDeltaBytes": -5817796,
"heapUsedBytes": 63662592,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 116.60000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.814000000074,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.877000000000002,
"layouts": 5,
"layoutDurationMs": 14.409999999999998,
"taskDurationMs": 968.1220000000002,
"heapDeltaBytes": 1304908,
"heapUsedBytes": 95353972,
"domNodes": 14227,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 30.819999999999986,
"eventListeners": 2463,
"totalBlockingTimeMs": 137,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8589.796999999977,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.568,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5681.355,
"heapDeltaBytes": -18007424,
"heapUsedBytes": 69583892,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2782.9990000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698443579766536,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9062.434999999936,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.275999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6007.936,
"heapDeltaBytes": 22094920,
"heapUsedBytes": 110482008,
"domNodes": 0,
"jsHeapTotalBytes": 753664,
"scriptDurationMs": 3087.0640000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696863468634685,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18667.783999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17898.896999999997,
"heapDeltaBytes": -32555812,
"heapUsedBytes": 180520372,
"domNodes": -3045,
"jsHeapTotalBytes": 7950336,
"scriptDurationMs": 294.983,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.01680960548885,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 18484.52599999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17583.430999999997,
"heapDeltaBytes": -33941948,
"heapUsedBytes": 180374924,
"domNodes": -3045,
"jsHeapTotalBytes": 6983680,
"scriptDurationMs": 290.579,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.5401023890785,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 23147.051999999974,
"styleRecalcs": 178,
"styleRecalcDurationMs": 23.001999999999967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22706.118,
"heapDeltaBytes": -43546416,
"heapUsedBytes": 166899124,
"domNodes": -3045,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 947.111,
"eventListeners": -14915,
"totalBlockingTimeMs": 12,
"frameDurationMs": 42.63186003683241,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23120.29400000006,
"styleRecalcs": 182,
"styleRecalcDurationMs": 22.687999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22629.376,
"heapDeltaBytes": -36285412,
"heapUsedBytes": 190060044,
"domNodes": -3045,
"jsHeapTotalBytes": 6766592,
"scriptDurationMs": 911.9979999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.87626811594203,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6652.59199999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.21999999999996,
"layouts": 20,
"layoutDurationMs": 25.023000000000003,
"taskDurationMs": 6582.656,
"heapDeltaBytes": 1014256,
"heapUsedBytes": 213519280,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 122.79399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.99885714285715,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6560.094000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.559,
"layouts": 20,
"layoutDurationMs": 25.660000000000004,
"taskDurationMs": 6420.541,
"heapDeltaBytes": -12984384,
"heapUsedBytes": 213788512,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 113.77900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.88932584269663,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9448.622999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8947.545999999998,
"heapDeltaBytes": -30767496,
"heapUsedBytes": 185839932,
"domNodes": -3046,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 151.54100000000003,
"eventListeners": -14926,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.81717171717172,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9360.935000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8892.997000000001,
"heapDeltaBytes": -32726436,
"heapUsedBytes": 180413968,
"domNodes": -3045,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 146.63700000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.643243243243248,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 474.94300000005296,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.019999999999998,
"layouts": 3,
"layoutDurationMs": 0.9950000000000002,
"taskDurationMs": 119.47700000000003,
"heapDeltaBytes": 5785284,
"heapUsedBytes": 71496120,
"domNodes": 104,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.149999999999995,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 477.55100000006223,
"styleRecalcs": 16,
"styleRecalcDurationMs": 14.941,
"layouts": 3,
"layoutDurationMs": 0.8830000000000001,
"taskDurationMs": 118.429,
"heapDeltaBytes": 5642084,
"heapUsedBytes": 72185932,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.107,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 999.9139999999898,
"styleRecalcs": 78,
"styleRecalcDurationMs": 107.511,
"layouts": 76,
"layoutDurationMs": 28.238,
"taskDurationMs": 977.94,
"heapDeltaBytes": 19042136,
"heapUsedBytes": 90279816,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 409.334,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491793,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1056.5179999999827,
"styleRecalcs": 78,
"styleRecalcDurationMs": 120.009,
"layouts": 76,
"layoutDurationMs": 29.772,
"taskDurationMs": 1019.236,
"heapDeltaBytes": 18541048,
"heapUsedBytes": 90333032,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 422.894,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.5,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1496.8850000000202,
"styleRecalcs": 78,
"styleRecalcDurationMs": 282.785,
"layouts": 76,
"layoutDurationMs": 30.863000000000003,
"taskDurationMs": 1470.009,
"heapDeltaBytes": 8544952,
"heapUsedBytes": 115091152,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 492.44899999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1447.6459999999634,
"styleRecalcs": 78,
"styleRecalcDurationMs": 274.444,
"layouts": 76,
"layoutDurationMs": 30.151,
"taskDurationMs": 1421.379,
"heapDeltaBytes": 8339164,
"heapUsedBytes": 115389024,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 471.678,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.35316455696202,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E CoverageLine coverage: 64.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2203 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c9dc174043ba214bab762f514edc85b202fb43a9
Full docs: ADR-DEVEX-LINT-0015 |
This comment has been minimized.
This comment has been minimized.
christian-byrne
left a comment
There was a problem hiding this comment.
The production change looks sound, but this backport is not compatible with the older branch yet.
The copied regression fixture passes mayWritePromotedHost and onWidgetWriteRefused, while this branch's dependency type defines neither property. TypeScript reports TS2353 at both fixture constructions (lines 164 and 229); after the first key is removed, the second remains an excess key too. Please remove both unused fixture properties and let the required CI settle green before re-requesting review.
Full context for agent readers
The backport is mechanically faithful to merged PR 21244: all 310 sorted changed lines and the three-file statistics match. The issue is branch compatibility, not backport drift. lint-pr / typecheck is the root failure; setup, perf-tests, scan, and validate-fonts independently encounter the same compile error, while lint-and-format, preflight, test, and e2e-status are short-circuit derivatives.
…ted regression test
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #21260 +/- ##
=============================================
Coverage ? 85.93%
=============================================
Files ? 2504
Lines ? 142854
Branches ? 36649
=============================================
Hits ? 122756
Misses ? 19712
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Both fixture keys removed in df116ec. Required CI green at that head (82 pass, 0 fail). Ready for re-review. |
christian-byrne
left a comment
There was a problem hiding this comment.
Requested change done; approving at this head.
- Both fixture keys removed (df116ec); branch updated with cloud/1.56
- Fix identical to main; regression cases fail without it, pass with it
- CI green at 6418cb1
Full context for agent readers
Independent re-review (fresh Claude reviewer, read-only, not cross-model: the other model CLIs were unavailable on this host): diff against cloud/1.56 touches only the 3 expected files; docOpMinter.ts added/removed lines identical to fcbe553; df116ec only drops mayWritePromotedHost and onWidgetWriteRefused, which this branch's DocOpMinterDeps lacks; cloud pins comfy-multi-player 0.3.10 like main. Targeted vitest on this branch: 72/72 pass with the fix; with the minter fix reverted the 2 regression cases (VHS_LoadVideo, CSVCVColumn) fail. Merged under the 1.56 Agent backport grant after check-merge-ready.sh --target-branch cloud/1.56.
Backport of #21244 to
cloud/1.56Automatically created by backport workflow.