Repository navigation
[backport core/1.57] fix(agent): report the follower's schema version on doc_subscribe - #21256
Conversation
…1078) ## Summary `doc_subscribe` now sends `schema_version`: the comfy-multi-player `SCHEMA_VERSION` this build's follower reads (currently 5). Cloud already accepts and relays the field (`DocSubscribeFrame.SchemaVersion`, Comfy-Org/cloud#12677). The agent compares it with the doc host's version and counts a mismatch as `comfy.agent.doc.client_schema_skew{client_schema,host_schema}`. Without it, the detector is blind. Since it shipped on Oct 11, all ~1.78M subscribes counted have been `client_schema:unknown`, and the runbook says to filter that tag out. Meanwhile a real skew happened on Oct 9. Frontend `7774606` (reads v4) received v5 documents from the doc host and refused to project them ("CRDT follower: doc meta.schema_version is not the layout this build reads"). That showed up as 271 RUM errors in 204 sessions, and users reported an empty canvas after the agent had built their workflow. Only the browser-side RUM assert caught it. The field is observability only. Cloud never refuses or changes a subscribe because of it, and a malformed or unknown value decodes as 0. The frontend and cloud can therefore deploy in either order. ## Verification - Tests: - Added `schema_version: SCHEMA_VERSION` to the exact-frame assertions in `docFrameClient.test.ts` and `docFrameClient.reseed.test.ts`. - The first assertion failed on `main` (`- "schema_version": 5`) and passes with this change. - `vitest run src/workbench/extensions/agent`: 163 files, 3483 tests passed. - `pnpm typecheck`, `oxlint` and `oxfmt --check` are clean. - After release: - `sum:comfy.agent.doc.client_schema_skew{env:prod-v2,!client_schema:unknown} by {client_schema,host_schema}` should stay empty while the two sides agree. - The `client_schema:unknown` share should fall as tabs reload onto the new build. - A non-empty series means real skew.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-18T03:13:49.077Z",
"gitSha": "c672408650f4f13b1bfb8d3bfbccbac069880477",
"branch": "backport-21078-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.3290000000366,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.016,
"layouts": 10,
"layoutDurationMs": 1.98,
"taskDurationMs": 270.64,
"heapDeltaBytes": 22167840,
"heapUsedBytes": 87855012,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 5.913,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2010.4209999999512,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.818,
"layouts": 10,
"layoutDurationMs": 1.9240000000000002,
"taskDurationMs": 288.634,
"heapDeltaBytes": -862908,
"heapUsedBytes": 74029584,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 6.027000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1945.4190000000153,
"styleRecalcs": 81,
"styleRecalcDurationMs": 13.271,
"layouts": 10,
"layoutDurationMs": 2.279,
"taskDurationMs": 720.933,
"heapDeltaBytes": -7776352,
"heapUsedBytes": 66684128,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 96.59100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665811965811965,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1680.5759999999736,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.608,
"layouts": 10,
"layoutDurationMs": 2.117,
"taskDurationMs": 486.486,
"heapDeltaBytes": 15658160,
"heapUsedBytes": 81394756,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 91.412,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.2560000000062,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.566,
"layouts": 12,
"layoutDurationMs": 2.572,
"taskDurationMs": 223.47099999999998,
"heapDeltaBytes": 18793704,
"heapUsedBytes": 84029456,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.786,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.090999999944,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.876,
"layouts": 12,
"layoutDurationMs": 2.1010000000000004,
"taskDurationMs": 158.927,
"heapDeltaBytes": 19074776,
"heapUsedBytes": 84946636,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.266000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 494.32500000000346,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.1310000000000002,
"layouts": 10,
"layoutDurationMs": 2.5449999999999995,
"taskDurationMs": 324.67,
"heapDeltaBytes": 24818088,
"heapUsedBytes": 90916420,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 111.587,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 432.59499999999207,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.843,
"layouts": 11,
"layoutDurationMs": 2.7170000000000005,
"taskDurationMs": 297.11699999999996,
"heapDeltaBytes": 1594108,
"heapUsedBytes": 76461168,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 103.37,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 874.9569999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.68,
"heapDeltaBytes": 2049224,
"heapUsedBytes": 81584380,
"domNodes": -192,
"jsHeapTotalBytes": 12591104,
"scriptDurationMs": 34.235,
"eventListeners": -106,
"totalBlockingTimeMs": 236,
"frameDurationMs": 24.536111111111104,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 893.769999999904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.81199999999995,
"heapDeltaBytes": 1528228,
"heapUsedBytes": 81310168,
"domNodes": -192,
"jsHeapTotalBytes": 13901824,
"scriptDurationMs": 37.44499999999999,
"eventListeners": -105,
"totalBlockingTimeMs": 254,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.4109999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 257.5919999999998,
"heapDeltaBytes": -5284348,
"heapUsedBytes": 74646008,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 85.922,
"eventListeners": 0,
"totalBlockingTimeMs": 84,
"frameDurationMs": 20.585294117647074,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 701.5669999999545,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.0769999999999,
"heapDeltaBytes": -4459336,
"heapUsedBytes": 76189932,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 91.76499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 89,
"frameDurationMs": 20.585294117647074,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6326.77000000001,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.1149999999999998,
"layouts": 2,
"layoutDurationMs": 0.6379999999999997,
"taskDurationMs": 5190.369,
"heapDeltaBytes": -11204964,
"heapUsedBytes": 84983764,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 4027.113999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 34,
"frameDurationMs": 19.02530120481928,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5640.901999999983,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7409999999999994,
"layouts": 3,
"layoutDurationMs": 0.7000000000000001,
"taskDurationMs": 4658.155,
"heapDeltaBytes": -16177848,
"heapUsedBytes": 83566084,
"domNodes": -258,
"jsHeapTotalBytes": 8777728,
"scriptDurationMs": 3677.308,
"eventListeners": -68,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.822397476340694,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5606.197999999949,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8369999999999992,
"layouts": 3,
"layoutDurationMs": 0.7329999999999998,
"taskDurationMs": 4699.003000000001,
"heapDeltaBytes": -14415748,
"heapUsedBytes": 84803056,
"domNodes": -258,
"jsHeapTotalBytes": 10612736,
"scriptDurationMs": 3677.5510000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 16,
"frameDurationMs": 17.948076923076922,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6434.67499999997,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1579999999999993,
"layouts": 4,
"layoutDurationMs": 1.0030000000000003,
"taskDurationMs": 5155.827,
"heapDeltaBytes": -1769972,
"heapUsedBytes": 85734268,
"domNodes": -258,
"jsHeapTotalBytes": 11137024,
"scriptDurationMs": 4098.56,
"eventListeners": -68,
"totalBlockingTimeMs": 17,
"frameDurationMs": 19.68251533742331,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 153.6090000000172,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.172000000000002,
"layouts": 13,
"layoutDurationMs": 3.067,
"taskDurationMs": 107.30199999999999,
"heapDeltaBytes": -7483920,
"heapUsedBytes": 80136320,
"domNodes": 917,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6.002999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.76249999999999,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 142.36299999993207,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.167000000000002,
"layouts": 13,
"layoutDurationMs": 3.0280000000000005,
"taskDurationMs": 105.438,
"heapDeltaBytes": -8346260,
"heapUsedBytes": 79112768,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6.298000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.76249999999999,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2027.1270000000072,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.1919999999999993,
"layouts": 10,
"layoutDurationMs": 2.115,
"taskDurationMs": 367.46999999999997,
"heapDeltaBytes": -20089220,
"heapUsedBytes": 75954760,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 22.174,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2010.4880000000094,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.783,
"layouts": 9,
"layoutDurationMs": 1.6490000000000002,
"taskDurationMs": 347.35099999999994,
"heapDeltaBytes": -16479140,
"heapUsedBytes": 79208448,
"domNodes": -258,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 21.150000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2235.036999999977,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.482999999999999,
"layouts": 9,
"layoutDurationMs": 1.977,
"taskDurationMs": 1147.7440000000001,
"heapDeltaBytes": -29156136,
"heapUsedBytes": 68529372,
"domNodes": -258,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 584.11,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666417910447763,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2180.6589999999915,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.7200000000000015,
"layouts": 10,
"layoutDurationMs": 2.706,
"taskDurationMs": 1016.3389999999998,
"heapDeltaBytes": -9116652,
"heapUsedBytes": 70560100,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 550.157,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538461,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3437.635,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.386000000000001,
"layouts": 66,
"layoutDurationMs": 11.504999999999999,
"taskDurationMs": 1218.896,
"heapDeltaBytes": 7694464,
"heapUsedBytes": 89891544,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 523.887,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3239.7489999999607,
"styleRecalcs": 73,
"styleRecalcDurationMs": 7.925,
"layouts": 67,
"layoutDurationMs": 11.152000000000001,
"taskDurationMs": 1106.4370000000001,
"heapDeltaBytes": -2653424,
"heapUsedBytes": 79417940,
"domNodes": -234,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 486.02,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153843,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2314.53700000003,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.473999999999999,
"layouts": 8,
"layoutDurationMs": 1.736,
"taskDurationMs": 1224.5949999999998,
"heapDeltaBytes": 1410000,
"heapUsedBytes": 78745172,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 616.325,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618705035971,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2166.95500000003,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.423,
"layouts": 7,
"layoutDurationMs": 1.6300000000000001,
"taskDurationMs": 1108.8580000000002,
"heapDeltaBytes": 3365616,
"heapUsedBytes": 86789280,
"domNodes": 0,
"jsHeapTotalBytes": 5730304,
"scriptDurationMs": 594.101,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153847,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2005.548000000033,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.018,
"layouts": 9,
"layoutDurationMs": 1.906,
"taskDurationMs": 369.563,
"heapDeltaBytes": -18465880,
"heapUsedBytes": 79735224,
"domNodes": -258,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 23.781,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2023.349000000053,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4250000000000003,
"layouts": 10,
"layoutDurationMs": 2.3870000000000005,
"taskDurationMs": 315.13800000000003,
"heapDeltaBytes": -1204960,
"heapUsedBytes": 80374568,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 26.543000000000003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 398.10799999997926,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.6659999999999995,
"layouts": 10,
"layoutDurationMs": 2.3800000000000003,
"taskDurationMs": 253.23499999999999,
"heapDeltaBytes": 19915160,
"heapUsedBytes": 86733264,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 89.76899999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67083333333333,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 414.0260000000353,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.446,
"layouts": 10,
"layoutDurationMs": 2.3230000000000004,
"taskDurationMs": 258.058,
"heapDeltaBytes": 21189976,
"heapUsedBytes": 88443436,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 90.483,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.0099999999893,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.0960000000000005,
"layouts": 11,
"layoutDurationMs": 2.227,
"taskDurationMs": 277.406,
"heapDeltaBytes": -666844,
"heapUsedBytes": 76585844,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 5.188999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2012.1149999999943,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9459999999999997,
"layouts": 10,
"layoutDurationMs": 1.76,
"taskDurationMs": 189.31800000000004,
"heapDeltaBytes": 22467016,
"heapUsedBytes": 89732636,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 4.914,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.0900000000306,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.410999999999998,
"layouts": 11,
"layoutDurationMs": 2.214,
"taskDurationMs": 494.408,
"heapDeltaBytes": -6539576,
"heapUsedBytes": 70976412,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 74.752,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.5659999999561,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.229,
"layouts": 10,
"layoutDurationMs": 2.119,
"taskDurationMs": 487.931,
"heapDeltaBytes": -11357316,
"heapUsedBytes": 65905660,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 72.655,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 817.5780000000259,
"styleRecalcs": 21,
"styleRecalcDurationMs": 15.629000000000001,
"layouts": 5,
"layoutDurationMs": 9.004,
"taskDurationMs": 586.2239999999998,
"heapDeltaBytes": 9553852,
"heapUsedBytes": 109418052,
"domNodes": 15953,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 16.182000000000002,
"eventListeners": 3244,
"totalBlockingTimeMs": 73,
"frameDurationMs": 18.99069767441859,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "viewport-pan-sweep",
"durationMs": 8221.138999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.658,
"layouts": 9,
"layoutDurationMs": 2.108,
"taskDurationMs": 3807.304,
"heapDeltaBytes": 4521924,
"heapUsedBytes": 83319956,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 1785.774,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8238.187999999922,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.465999999999998,
"layouts": 9,
"layoutDurationMs": 2.129,
"taskDurationMs": 3741.745,
"heapDeltaBytes": 9865152,
"heapUsedBytes": 88437984,
"domNodes": -258,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 1838.984,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665991902834005,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14862.986000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13933.071,
"heapDeltaBytes": -7013336,
"heapUsedBytes": 284251104,
"domNodes": -3330,
"jsHeapTotalBytes": 11001856,
"scriptDurationMs": 204.94600000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.412136752136753,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14994.37999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14281.412000000002,
"heapDeltaBytes": -40431560,
"heapUsedBytes": 260369260,
"domNodes": -3330,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 186.498,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.336824324324322,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 13858.965999999953,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.748000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13146.688999999998,
"heapDeltaBytes": -4705704,
"heapUsedBytes": 286434004,
"domNodes": -3330,
"jsHeapTotalBytes": 22274048,
"scriptDurationMs": 586.585,
"eventListeners": -651,
"totalBlockingTimeMs": 26,
"frameDurationMs": 24.39859402460457,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17427.51999999996,
"styleRecalcs": 147,
"styleRecalcDurationMs": 11.959999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17073.974,
"heapDeltaBytes": -28668732,
"heapUsedBytes": 267696244,
"domNodes": -3330,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 590.322,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.695818181818183,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 5057.299000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.34899999999999,
"layouts": 20,
"layoutDurationMs": 17.179,
"taskDurationMs": 4989.786,
"heapDeltaBytes": -22440880,
"heapUsedBytes": 273224944,
"domNodes": -3330,
"jsHeapTotalBytes": 36954112,
"scriptDurationMs": 69.299,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.57870967741936,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 5446.76000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.385999999999996,
"layouts": 20,
"layoutDurationMs": 18.917999999999992,
"taskDurationMs": 5261.280000000001,
"heapDeltaBytes": 11682464,
"heapUsedBytes": 288952736,
"domNodes": -3330,
"jsHeapTotalBytes": 36425728,
"scriptDurationMs": 76.224,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.61902173913043,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7083.587000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6545.785000000001,
"heapDeltaBytes": -4151160,
"heapUsedBytes": 257274320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 79.299,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.476744186046506,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5266.4760000000115,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4981.439,
"heapDeltaBytes": 3971320,
"heapUsedBytes": 288976492,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 59.10099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.917747440273043,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 89.12999999995463,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.877999999999999,
"layouts": 6,
"layoutDurationMs": 2.162,
"taskDurationMs": 59.053999999999995,
"heapDeltaBytes": 4677004,
"heapUsedBytes": 77159912,
"domNodes": 97,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.317000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 89.54099999994014,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.694,
"layouts": 6,
"layoutDurationMs": 2.225,
"taskDurationMs": 59.588,
"heapDeltaBytes": -11352088,
"heapUsedBytes": 68399128,
"domNodes": 94,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 4.240000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 194.46800000002895,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.0399999999999998,
"layouts": 76,
"layoutDurationMs": 9.96,
"taskDurationMs": 159.186,
"heapDeltaBytes": 8838716,
"heapUsedBytes": 101947208,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 70.078,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 191.6559999999663,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.869,
"layouts": 76,
"layoutDurationMs": 9.43,
"taskDurationMs": 149.999,
"heapDeltaBytes": 8635012,
"heapUsedBytes": 94002152,
"domNodes": 4,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 62.795,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 214.95800000002419,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.436,
"layouts": 76,
"layoutDurationMs": 8.661,
"taskDurationMs": 182.18400000000003,
"heapDeltaBytes": 25498572,
"heapUsedBytes": 142274056,
"domNodes": 4,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 58.95,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 227.5560000000496,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.474,
"layouts": 76,
"layoutDurationMs": 9.4,
"taskDurationMs": 189.63200000000003,
"heapDeltaBytes": -2650268,
"heapUsedBytes": 119513720,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 61.134,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E CoverageLine coverage: 64.8% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2278 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0182a2a294e8d6bcdddb947804ee1449742878ca
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21256 +/- ##
============================================
Coverage 87.16% 87.17%
============================================
Files 2616 2616
Lines 147129 147129
Branches 40354 38270 -2084
============================================
+ Hits 128250 128257 +7
+ Misses 18491 18484 -7
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…n on doc_subscribe (#21078) (#21258) Backport of #21078 to `cloud/1.56`. The auto-backport hit a one-line import conflict: `cloud/1.56` already imports `type { Op }` from `@comfyorg/comfy-multi-player`. Resolved by keeping both imports. No other change; the rest of the patch applied cleanly. <details><summary>Full context for agent readers</summary> - Why: production serves `cloud/1.56`, and its `doc_subscribe` does not report `schema_version`, so cloud's `client_schema_skew` metric counts every prod subscribe as `unknown`. Shipping this makes a frontend/doc-host schema skew (the cause of PM-2072's "agent says it added nodes, canvas empty" report and PM-2052) visible server-side. Observability only: cloud never refuses a subscribe on this field. - `core/1.56` intentionally skipped: that branch predates the reseed protocol and the doc host this reports to (3-file modify/delete conflict). - Sibling backports: #21256 (core/1.57), #21257 (cloud/1.57); reload prompt #21084 -> #21252..#21255. </details> Co-authored-by: skishore23 <shimikeri.kishore@gmail.com>
Backport of #21078 to
core/1.57Automatically created by backport workflow.