Repository navigation
[backport cloud/1.56] fix(agent): report the follower's schema version on doc_subscribe (#21078) - #21258
Conversation
…1078) `doc_subscribe` now sends `schema_version`: the comfy-multi-player `SCHEMA_VERSION` this build's follower reads (currently 5). Cloud already accepts and relays the field (`DocSubscribeFrame.SchemaVersion`, Comfy-Org/cloud#12677). The agent compares it with the doc host's version and counts a mismatch as `comfy.agent.doc.client_schema_skew{client_schema,host_schema}`. Without it, the detector is blind. Since it shipped on Oct 11, all ~1.78M subscribes counted have been `client_schema:unknown`, and the runbook says to filter that tag out. Meanwhile a real skew happened on Oct 9. Frontend `7774606` (reads v4) received v5 documents from the doc host and refused to project them ("CRDT follower: doc meta.schema_version is not the layout this build reads"). That showed up as 271 RUM errors in 204 sessions, and users reported an empty canvas after the agent had built their workflow. Only the browser-side RUM assert caught it. The field is observability only. Cloud never refuses or changes a subscribe because of it, and a malformed or unknown value decodes as 0. The frontend and cloud can therefore deploy in either order. - Tests: - Added `schema_version: SCHEMA_VERSION` to the exact-frame assertions in `docFrameClient.test.ts` and `docFrameClient.reseed.test.ts`. - The first assertion failed on `main` (`- "schema_version": 5`) and passes with this change. - `vitest run src/workbench/extensions/agent`: 163 files, 3483 tests passed. - `pnpm typecheck`, `oxlint` and `oxfmt --check` are clean. - After release: - `sum:comfy.agent.doc.client_schema_skew{env:prod-v2,!client_schema:unknown} by {client_schema,host_schema}` should stay empty while the two sides agree. - The `client_schema:unknown` share should fall as tabs reload onto the new build. - A non-empty series means real skew. (cherry picked from commit a3e2bbd)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-18T03:36:40.038Z",
"gitSha": "d2744726c6192d04918479b89cbc615ba9533cdf",
"branch": "backport-21078-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.9950000000272,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.902,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.49399999999997,
"heapDeltaBytes": 953584,
"heapUsedBytes": 68747712,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.020999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2019.3080000000236,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.9900000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.936,
"heapDeltaBytes": -3125632,
"heapUsedBytes": 58852224,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.958,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1717.503000000022,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.124000000000002,
"layouts": 12,
"layoutDurationMs": 3.8529999999999998,
"taskDurationMs": 710.6439999999999,
"heapDeltaBytes": -2047068,
"heapUsedBytes": 66057896,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 131.72799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.674000000011,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.146,
"layouts": 12,
"layoutDurationMs": 4.0409999999999995,
"taskDurationMs": 717.6510000000001,
"heapDeltaBytes": 20404080,
"heapUsedBytes": 80599248,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.382,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1690.339999999992,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.853,
"layouts": 6,
"layoutDurationMs": 1.1340000000000001,
"taskDurationMs": 306.184,
"heapDeltaBytes": 251864,
"heapUsedBytes": 62125568,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.864,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1695.1629999999795,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.588999999999999,
"layouts": 6,
"layoutDurationMs": 1.3169999999999997,
"taskDurationMs": 330.994,
"heapDeltaBytes": 25890220,
"heapUsedBytes": 80494600,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.103000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 562.9460000000108,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.424,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.87,
"heapDeltaBytes": -6734604,
"heapUsedBytes": 61117664,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 138.252,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 611.5700000000288,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.633000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.70099999999996,
"heapDeltaBytes": -6391600,
"heapUsedBytes": 61124540,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 142.374,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1111.331000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 757.0690000000001,
"heapDeltaBytes": 16151940,
"heapUsedBytes": 84629176,
"domNodes": 0,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 56.31700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 450,
"frameDurationMs": 31.016666666666676,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1124.5509999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 809.0999999999999,
"heapDeltaBytes": 12298808,
"heapUsedBytes": 92414520,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 56.80500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 487,
"frameDurationMs": 32.844117647058816,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 797.365999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.1899999999998,
"heapDeltaBytes": 17788404,
"heapUsedBytes": 100770296,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 135.314,
"eventListeners": 0,
"totalBlockingTimeMs": 171,
"frameDurationMs": 23.526470588235284,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.0729999999685,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.578,
"heapDeltaBytes": 16781956,
"heapUsedBytes": 100729720,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 121.58099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.03529411764708,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7342.571000000021,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.730999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6477.451999999999,
"heapDeltaBytes": -5837672,
"heapUsedBytes": 71885424,
"domNodes": -142,
"jsHeapTotalBytes": -12455936,
"scriptDurationMs": 5318.459,
"eventListeners": -74,
"totalBlockingTimeMs": 71,
"frameDurationMs": 26.568840579710145,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8213.197999999977,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.41300000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7349.6050000000005,
"heapDeltaBytes": 13139880,
"heapUsedBytes": 89847980,
"domNodes": -142,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 5939.458,
"eventListeners": -78,
"totalBlockingTimeMs": 40,
"frameDurationMs": 25.866561514195585,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7765.569999999969,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.103999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6819.8730000000005,
"heapDeltaBytes": -14468100,
"heapUsedBytes": 69413308,
"domNodes": -142,
"jsHeapTotalBytes": -11669504,
"scriptDurationMs": 5425.735000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 72,
"frameDurationMs": 24.972347266881027,
"p95FrameDurationMs": 49.900000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7123.4020000000555,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.2570000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6318.891,
"heapDeltaBytes": 8525116,
"heapUsedBytes": 93535424,
"domNodes": -143,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 5022.768999999999,
"eventListeners": -82,
"totalBlockingTimeMs": 31,
"frameDurationMs": 24.709722222222222,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2008.2670000000462,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.790999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.1189999999999,
"heapDeltaBytes": -10302120,
"heapUsedBytes": 77586096,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.379999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2023.4769999999571,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.927,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.0590000000001,
"heapDeltaBytes": -10244620,
"heapUsedBytes": 77925368,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.765,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2184.763000000032,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.131000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1382.2620000000004,
"heapDeltaBytes": -18454932,
"heapUsedBytes": 70878492,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 703.3670000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564885496183,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2118.4749999999894,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.644,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1384.849,
"heapDeltaBytes": -17530716,
"heapUsedBytes": 68134504,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 704.163,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66614173228346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3336.880000000008,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.58,
"layouts": 60,
"layoutDurationMs": 14.921,
"taskDurationMs": 1537.6029999999998,
"heapDeltaBytes": -20318920,
"heapUsedBytes": 69461704,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 721.519,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74974874371859,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3283.702000000062,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.524000000000001,
"layouts": 60,
"layoutDurationMs": 14.426000000000002,
"taskDurationMs": 1469.916,
"heapDeltaBytes": 1592584,
"heapUsedBytes": 69118028,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 682.604,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665989847715736,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2641.3840000000164,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.4620000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1677.615,
"heapDeltaBytes": 4800136,
"heapUsedBytes": 72686308,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 870.301,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.771974522292993,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2587.611000000038,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.516,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1701.1759999999997,
"heapDeltaBytes": 14489664,
"heapUsedBytes": 93038080,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 862.9169999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.774675324675325,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.9609999999948,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.4149999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.3259999999999,
"heapDeltaBytes": -11193764,
"heapUsedBytes": 68637628,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.123,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2015.1220000000194,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.566999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.7909999999999,
"heapDeltaBytes": -10030984,
"heapUsedBytes": 79332904,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 35.77200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.9800000000091,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.419000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.30899999999997,
"heapDeltaBytes": -11584672,
"heapUsedBytes": 57669472,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 121.41499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 544.6589999999105,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.70200000000006,
"heapDeltaBytes": 10024460,
"heapUsedBytes": 72322920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 124.701,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.3020000000388,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.710999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.72600000000006,
"heapDeltaBytes": 1361712,
"heapUsedBytes": 70995476,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.460999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.5629999999574,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6869999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.53299999999996,
"heapDeltaBytes": 1485096,
"heapUsedBytes": 71033020,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.193999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.5969999999975,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.72,
"layouts": 16,
"layoutDurationMs": 5.299999999999999,
"taskDurationMs": 676.939,
"heapDeltaBytes": -5978420,
"heapUsedBytes": 64131156,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 97.996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.2149999999056,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.543,
"layouts": 16,
"layoutDurationMs": 5.161,
"taskDurationMs": 678.6139999999999,
"heapDeltaBytes": -6079444,
"heapUsedBytes": 64849344,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 100.253,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1301.2540000000286,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.615999999999993,
"layouts": 5,
"layoutDurationMs": 11.147,
"taskDurationMs": 846.822,
"heapDeltaBytes": 3200900,
"heapUsedBytes": 95036648,
"domNodes": 14227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.533,
"eventListeners": 2463,
"totalBlockingTimeMs": 98,
"frameDurationMs": 18.808571428571433,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8147.388000000035,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.574,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4941.283,
"heapDeltaBytes": 11614872,
"heapUsedBytes": 85584052,
"domNodes": 0,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 2358.867,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598360655738,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8182.645999999977,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.039,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5006.144,
"heapDeltaBytes": 8708936,
"heapUsedBytes": 95969028,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 2394.933,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665784114052954,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16420.933999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15769.316,
"heapDeltaBytes": -35869332,
"heapUsedBytes": 180527748,
"domNodes": -3045,
"jsHeapTotalBytes": 6955008,
"scriptDurationMs": 240.09199999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.209964412811395,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16127.218999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15464.61,
"heapDeltaBytes": -21540044,
"heapUsedBytes": 180715024,
"domNodes": -3045,
"jsHeapTotalBytes": 4653056,
"scriptDurationMs": 243.68800000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.173236889692586,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 18191.111999999976,
"styleRecalcs": 145,
"styleRecalcDurationMs": 19.116999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17950.445000000003,
"heapDeltaBytes": -40691212,
"heapUsedBytes": 166560832,
"domNodes": -3044,
"jsHeapTotalBytes": 6434816,
"scriptDurationMs": 735.241,
"eventListeners": -14915,
"totalBlockingTimeMs": 18,
"frameDurationMs": 35.234042553191486,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18646.248000000014,
"styleRecalcs": 151,
"styleRecalcDurationMs": 20.022000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18373.476,
"heapDeltaBytes": -30799372,
"heapUsedBytes": 167854888,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 763.783,
"eventListeners": -14915,
"totalBlockingTimeMs": 15,
"frameDurationMs": 35.49066666666666,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5883.816000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.404,
"layouts": 20,
"layoutDurationMs": 25.57899999999999,
"taskDurationMs": 5761.782999999999,
"heapDeltaBytes": 14994556,
"heapUsedBytes": 217291224,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 100.478,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.050561797752806,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5682.324999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.83199999999997,
"layouts": 20,
"layoutDurationMs": 25.217000000000002,
"taskDurationMs": 5640.348,
"heapDeltaBytes": -12785140,
"heapUsedBytes": 215513208,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 98.39,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.638364779874216,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8078.462000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7841.245000000001,
"heapDeltaBytes": -4416796,
"heapUsedBytes": 198504352,
"domNodes": -3046,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 120.63599999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.04832713754647,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8184.256000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7829.868000000001,
"heapDeltaBytes": -20845952,
"heapUsedBytes": 181776752,
"domNodes": -3045,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 120.17299999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.330107526881715,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 441.32700000000114,
"styleRecalcs": 16,
"styleRecalcDurationMs": 17.659000000000002,
"layouts": 4,
"layoutDurationMs": 1.843,
"taskDurationMs": 116.649,
"heapDeltaBytes": 5850684,
"heapUsedBytes": 64135852,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.034999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 101.80000000002565,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.374,
"layouts": 3,
"layoutDurationMs": 0.9370000000000002,
"taskDurationMs": 67.59499999999998,
"heapDeltaBytes": 3769636,
"heapUsedBytes": 69019804,
"domNodes": 94,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.887000000000003,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 642.1789999999419,
"styleRecalcs": 78,
"styleRecalcDurationMs": 89.053,
"layouts": 76,
"layoutDurationMs": 23.359,
"taskDurationMs": 613.684,
"heapDeltaBytes": -16271468,
"heapUsedBytes": 70309864,
"domNodes": 76,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 239.88099999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 620.2570000000378,
"styleRecalcs": 78,
"styleRecalcDurationMs": 86.997,
"layouts": 76,
"layoutDurationMs": 22.77,
"taskDurationMs": 589.048,
"heapDeltaBytes": -16730276,
"heapUsedBytes": 68856504,
"domNodes": 76,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 219.443,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1248.7939999999753,
"styleRecalcs": 78,
"styleRecalcDurationMs": 261.046,
"layouts": 76,
"layoutDurationMs": 26.738000000000003,
"taskDurationMs": 1226.086,
"heapDeltaBytes": -13248092,
"heapUsedBytes": 108068584,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 374.70400000000006,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.888000000000005,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1257.5089999999136,
"styleRecalcs": 78,
"styleRecalcDurationMs": 257.455,
"layouts": 76,
"layoutDurationMs": 27.181,
"taskDurationMs": 1232.574,
"heapDeltaBytes": -19483272,
"heapUsedBytes": 108034792,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 382.229,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2205 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 061a50b0ef2cf7e6471d97a8c72359f987dc94f4
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #21258 +/- ##
=============================================
Coverage ? 85.93%
=============================================
Files ? 2504
Lines ? 142831
Branches ? 38931
=============================================
Hits ? 122741
Misses ? 19704
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| state_vector_b64: encodeBase64(stateVector), | ||
| supports_reseed: true | ||
| supports_reseed: true, | ||
| schema_version: SCHEMA_VERSION |
There was a problem hiding this comment.
🟡 Medium — This makes a client-declared value an input to a destructive host-side path: a stale_schema_reseed_required refusal authorizes the follower to answer with doc_reseed, which re-mints the shared document from that one tab's canvas and announces a new lineage to all collaborators. A stale tab (cached assets, long-lived session, canary rollback) that honestly reports an older SCHEMA_VERSION can now induce that refusal and clobber a document that is actually newer, and nothing in onDocSubscribed distinguishes "doc too old for the host" from "client too old for the doc". Confirm the host treats this field as an untrusted hint and keeps re-mint authority in its own stored-document inspection. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| @@ -1,3 +1,4 @@ | |||
| import { SCHEMA_VERSION } from '@comfyorg/comfy-multi-player' | |||
There was a problem hiding this comment.
🟡 Medium — The value every client advertises on the wire is now whatever @comfyorg/comfy-multi-player (catalog-pinned at 0.3.10) defines as SCHEMA_VERSION, so a routine dependency bump silently changes the protocol with no local gate. Because schema_version_mismatch is in PERMANENT_SUBSCRIBE_REFUSAL_CODES in agentCrdtDocLifecycle.ts, a host that rejects the new value skips the retry ladder entirely and latches gaveUp, killing the agent CRDT follower for every user on that build until a redeploy. Worth a contract test that fails when the constant moves, or an explicit host-side compatibility window. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| state_vector_b64: encodeBase64(stateVector), | ||
| supports_reseed: true | ||
| supports_reseed: true, | ||
| schema_version: SCHEMA_VERSION |
There was a problem hiding this comment.
🟢 Low — The handshake is now asymmetric: subscribe() declares the reader's schema version, but reseed() just below it still omits it. If the host needs the requesting follower's schema when answering a reseed, confirm it can recover that from the subscribe state — otherwise the recovery path carries less information than the refusal that triggered it. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| state_vector_b64: encodeBase64(stateVector), | ||
| supports_reseed: true | ||
| supports_reseed: true, | ||
| schema_version: SCHEMA_VERSION |
There was a problem hiding this comment.
⚪ Nit — This assertion (and the matching one in docFrameClient.reseed.test.ts) compares the sent frame against the same SCHEMA_VERSION the production code imports, so both sides move together. It can only detect the field going missing, never a change in the value that actually ships on the wire — which is the drift that would permanently refuse every subscribe; asserting a literal would catch it. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
|
Cursor findings: no change — backport stays identical to #21078 on main/1.57.
Full context for agent readers
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 0d0caa0 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Backport of #21078 to
cloud/1.56.The auto-backport hit a one-line import conflict:
cloud/1.56already importstype { Op }from@comfyorg/comfy-multi-player. Resolved by keeping both imports. No other change; the rest of the patch applied cleanly.Full context for agent readers
cloud/1.56, and itsdoc_subscribedoes not reportschema_version, so cloud'sclient_schema_skewmetric counts every prod subscribe asunknown. Shipping this makes a frontend/doc-host schema skew (the cause of PM-2072's "agent says it added nodes, canvas empty" report and PM-2052) visible server-side. Observability only: cloud never refuses a subscribe on this field.core/1.56intentionally skipped: that branch predates the reseed protocol and the doc host this reports to (3-file modify/delete conflict).