Repository navigation
[backport cloud/1.59] fix: Fix consent card layout (#22077) - #22869
Conversation
This change fixes the Agent consent card layout. The card now fits stacked, compact, and columns layouts. - The video has an 8px inset and rounded corners in all layouts. On short screens the video keeps a 16:9 ratio and fits inside its wrap, so the heading, copy, and actions stay on screen. - The buttons hug their text. On a wide footer they sit on one line with the docs link and are vertically centered. The wide check uses the card shell width so a 576px card stays wide. - Narrow width (576px breakpoint, from #17908) stacks full-width buttons with the primary first. It moves the docs link under the copy. - The dialog centers on the viewport. It zeros `--workspace-inset-right` and ignores the docked agent panel inset (`centerOnViewport`). - The signed-out button says "Agree and continue with sign in". The separate sign-in hint is gone. The error toast is in a stacked PR: #22079. Linear: https://linear.app/comfyorg/issue/DES-1291/des-fix-consent-card-layout - `pnpm test:unit` on `AgentConsentCard.test.ts` and `GlobalDialog.test.ts`. - New E2E test `browser_tests/tests/dialogs/globalDialogViewportCenter.spec.ts` checks that a dialog stays centered with a docked panel inset, when maximized and after restore. - `browser_tests/tests/agent/agentConsent.spec.ts` is the layout contract. CI is the signal (this VM cannot run the E2E container). - `pnpm typecheck` and lint on the changed files. Storybook stories to review: - `agent-consentcard--default` - `agent-consentcard--signed-out` - `agent-consentcard--in-narrow-panel` - `agent-consentcard--in-light-app` Short-screen columns: Default story at about 1280×600. Compact: Default story at about 640×660. | State | Dark | Light | | --- | --- | --- | | Default (stacked, wide) | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/default-dark.png"> | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/default-light.png"> | | Signed out | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/signed-out-dark.png"> | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/signed-out-light.png"> | | In narrow panel | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/narrow-dark.png"> | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/narrow-light.png"> | | Short screen (columns) | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/columns-dark.png"> | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/69367a6b64b68d47db50f202284dd876a2203f66/.github/pr-images/DES-1291/columns-light.png"> | | Compact | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/c7f00f0ce812bb85670dcef97126e1cac6198ea1/.github/pr-images/DES-1291/compact-dark.png"> | <img width="240" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/c7f00f0ce812bb85670dcef97126e1cac6198ea1/.github/pr-images/DES-1291/compact-light.png"> | --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit cc1a808)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-04T01:08:06.300Z",
"gitSha": "8cb9b5cbdfe8bd2e67603cfe089b36ced2454751",
"branch": "backport/oploop-1018-consent-card-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.0380000000187,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1650000000000005,
"layouts": 9,
"layoutDurationMs": 2.8319999999999994,
"taskDurationMs": 554.184,
"heapDeltaBytes": 1734432,
"heapUsedBytes": 63638816,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.357999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4450000000000003,
"layouts": 8,
"layoutDurationMs": 2.222,
"taskDurationMs": 586.666,
"heapDeltaBytes": 4251040,
"heapUsedBytes": 66128072,
"domNodes": -161,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 10.498999999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.5300000000123,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.579999999999998,
"layouts": 9,
"layoutDurationMs": 2.5919999999999996,
"taskDurationMs": 898.7839999999999,
"heapDeltaBytes": 23733076,
"heapUsedBytes": 85623396,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 165.629,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.8489999999938,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.534999999999998,
"layouts": 9,
"layoutDurationMs": 2.757,
"taskDurationMs": 865.7790000000001,
"heapDeltaBytes": 21937480,
"heapUsedBytes": 83892988,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 157.724,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8829999999812,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.978,
"layouts": 10,
"layoutDurationMs": 2.934,
"taskDurationMs": 405.937,
"heapDeltaBytes": -14520,
"heapUsedBytes": 62186596,
"domNodes": 56,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 10.982,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.8880000000117,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.043,
"layouts": 10,
"layoutDurationMs": 3.366,
"taskDurationMs": 464.95799999999997,
"heapDeltaBytes": 24045084,
"heapUsedBytes": 86367768,
"domNodes": 56,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 14.984999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 692.3400000000015,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0109999999999997,
"layouts": 10,
"layoutDurationMs": 3.0239999999999996,
"taskDurationMs": 515.162,
"heapDeltaBytes": 6937816,
"heapUsedBytes": 76663452,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 175.60500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 660.1950000000443,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9520000000000004,
"layouts": 10,
"layoutDurationMs": 2.646,
"taskDurationMs": 490.812,
"heapDeltaBytes": 6660116,
"heapUsedBytes": 77129776,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 165.554,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1206.070000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 911.111,
"heapDeltaBytes": -13082236,
"heapUsedBytes": 75162392,
"domNodes": -191,
"jsHeapTotalBytes": 22290432,
"scriptDurationMs": 74.717,
"eventListeners": -107,
"totalBlockingTimeMs": 519,
"frameDurationMs": 32.43243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1236.6080000000466,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 948.687,
"heapDeltaBytes": -12841512,
"heapUsedBytes": 75153588,
"domNodes": -191,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 71.148,
"eventListeners": -107,
"totalBlockingTimeMs": 536,
"frameDurationMs": 33.32972972972973,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.8700000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.8570000000001,
"heapDeltaBytes": -4368068,
"heapUsedBytes": 70502816,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.105,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.9810000000089,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.41099999999994,
"heapDeltaBytes": -5267224,
"heapUsedBytes": 69414836,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.72000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12286.562000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11431.037999999999,
"heapDeltaBytes": 5323232,
"heapUsedBytes": 80467728,
"domNodes": -257,
"jsHeapTotalBytes": 19787776,
"scriptDurationMs": 9343.693,
"eventListeners": -69,
"totalBlockingTimeMs": 1750,
"frameDurationMs": 33.46811989100818,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10462.71200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9681.001,
"heapDeltaBytes": 16146464,
"heapUsedBytes": 77828108,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 7826.222000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 959,
"frameDurationMs": 31.14970238095238,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9578.057999999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.03799999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8752.584,
"heapDeltaBytes": 54993936,
"heapUsedBytes": 128571316,
"domNodes": -257,
"jsHeapTotalBytes": 50458624,
"scriptDurationMs": 7240.313,
"eventListeners": -69,
"totalBlockingTimeMs": 853,
"frameDurationMs": 32.10167785234899,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10484.346000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9695.678,
"heapDeltaBytes": 65583268,
"heapUsedBytes": 148795252,
"domNodes": -257,
"jsHeapTotalBytes": 71430144,
"scriptDurationMs": 7744.963000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 857,
"frameDurationMs": 31.385928143712572,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 287.2440000000154,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.301,
"layouts": 11,
"layoutDurationMs": 3.302,
"taskDurationMs": 240.20900000000003,
"heapDeltaBytes": -16826148,
"heapUsedBytes": 58800300,
"domNodes": 936,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.075,
"eventListeners": 205,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25,
"p95FrameDurationMs": 116.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 213.75299999999697,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.764,
"layouts": 9,
"layoutDurationMs": 2.681,
"taskDurationMs": 163.032,
"heapDeltaBytes": 14616020,
"heapUsedBytes": 73120052,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.849,
"eventListeners": 205,
"totalBlockingTimeMs": 3,
"frameDurationMs": 24.055555555555557,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2056.727999999964,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.444,
"layouts": 8,
"layoutDurationMs": 2.051,
"taskDurationMs": 673.195,
"heapDeltaBytes": -15771876,
"heapUsedBytes": 59269796,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 33.919,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.5680000000975,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5329999999999995,
"layouts": 8,
"layoutDurationMs": 2.4530000000000003,
"taskDurationMs": 637.782,
"heapDeltaBytes": -31763736,
"heapUsedBytes": 60202916,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 32.885000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2697.223000000008,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.807,
"layouts": 7,
"layoutDurationMs": 2.3120000000000003,
"taskDurationMs": 1788.4009999999998,
"heapDeltaBytes": -30504620,
"heapUsedBytes": 62071928,
"domNodes": -257,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 852.987,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2514.3860000000586,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.651,
"layouts": 8,
"layoutDurationMs": 2.047,
"taskDurationMs": 1684.2990000000002,
"heapDeltaBytes": -1156352,
"heapUsedBytes": 76296164,
"domNodes": -257,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 812.192,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77733333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3941.641000000004,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.915999999999999,
"layouts": 64,
"layoutDurationMs": 11.018,
"taskDurationMs": 1908.814,
"heapDeltaBytes": 5839676,
"heapUsedBytes": 85026720,
"domNodes": -233,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 843.313,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66582278481013,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3730.921999999964,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.187000000000001,
"layouts": 65,
"layoutDurationMs": 10.758000000000001,
"taskDurationMs": 1779.6790000000003,
"heapDeltaBytes": 9535528,
"heapUsedBytes": 80412784,
"domNodes": -233,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 780.269,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74144144144144,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3230.1760000000286,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.531000000000001,
"layouts": 5,
"layoutDurationMs": 1.3009999999999997,
"taskDurationMs": 2108.107,
"heapDeltaBytes": -335452,
"heapUsedBytes": 78790468,
"domNodes": -257,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 1003.7449999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.840837696335075,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3002.057000000036,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.956000000000001,
"layouts": 5,
"layoutDurationMs": 1.3650000000000004,
"taskDurationMs": 1936.5229999999997,
"heapDeltaBytes": 17343592,
"heapUsedBytes": 99515176,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 939.172,
"eventListeners": 182,
"totalBlockingTimeMs": 7,
"frameDurationMs": 16.94333333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3073.8409999999876,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8110000000000002,
"layouts": 7,
"layoutDurationMs": 1.607,
"taskDurationMs": 788.203,
"heapDeltaBytes": 2542568,
"heapUsedBytes": 79776856,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 357.44399999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3140.544000000034,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.267,
"layouts": 7,
"layoutDurationMs": 2.211,
"taskDurationMs": 816.4760000000001,
"heapDeltaBytes": -12883416,
"heapUsedBytes": 67072352,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 388.735,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.1479999999738,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2299999999999995,
"layouts": 7,
"layoutDurationMs": 2.03,
"taskDurationMs": 633.5310000000001,
"heapDeltaBytes": -13383632,
"heapUsedBytes": 65558456,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 31.841,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2046.6470000000072,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.456999999999999,
"layouts": 7,
"layoutDurationMs": 2.312,
"taskDurationMs": 730.0289999999999,
"heapDeltaBytes": -28379408,
"heapUsedBytes": 64588720,
"domNodes": -257,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 37.136,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2745.0080000000125,
"styleRecalcs": 27,
"styleRecalcDurationMs": 13.105,
"layouts": 7,
"layoutDurationMs": 2.3489999999999998,
"taskDurationMs": 520.8399999999999,
"heapDeltaBytes": -1031868,
"heapUsedBytes": 79332656,
"domNodes": -238,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 193.964,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2721.600999999964,
"styleRecalcs": 22,
"styleRecalcDurationMs": 10.566,
"layouts": 3,
"layoutDurationMs": 0.9499999999999998,
"taskDurationMs": 541.5340000000001,
"heapDeltaBytes": 376816,
"heapUsedBytes": 62692928,
"domNodes": 19,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 184.03,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665644171779142,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3322.4400000000005,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7939999999999996,
"layouts": 7,
"layoutDurationMs": 2.117,
"taskDurationMs": 963.866,
"heapDeltaBytes": -17183052,
"heapUsedBytes": 63614604,
"domNodes": -257,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 394.997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.750505050505048,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-topology-cadence",
"durationMs": 3286.0350000000267,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1580000000000004,
"layouts": 8,
"layoutDurationMs": 2.341,
"taskDurationMs": 975.4770000000001,
"heapDeltaBytes": 6499040,
"heapUsedBytes": 84945572,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 377.81,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598984771574,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.689999999981,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.857,
"layouts": 9,
"layoutDurationMs": 2.3230000000000004,
"taskDurationMs": 439.53200000000004,
"heapDeltaBytes": 323040,
"heapUsedBytes": 62570128,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 146.416,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 725.7889999999634,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.313999999999999,
"layouts": 9,
"layoutDurationMs": 2.548,
"taskDurationMs": 479.9030000000001,
"heapDeltaBytes": 490564,
"heapUsedBytes": 63247260,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 151.388,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069764,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2058.1599999999867,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0509999999999997,
"layouts": 10,
"layoutDurationMs": 3.1399999999999997,
"taskDurationMs": 600.914,
"heapDeltaBytes": 7791004,
"heapUsedBytes": 70097260,
"domNodes": -183,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 10.333,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.5840000000653,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.711,
"layouts": 10,
"layoutDurationMs": 2.912,
"taskDurationMs": 527.62,
"heapDeltaBytes": 2546752,
"heapUsedBytes": 65255040,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.805,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.809999999995,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.328999999999999,
"layouts": 9,
"layoutDurationMs": 2.977,
"taskDurationMs": 877.329,
"heapDeltaBytes": 17999188,
"heapUsedBytes": 80267744,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 114.84799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.9499999999598,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.367999999999999,
"layouts": 8,
"layoutDurationMs": 2.469,
"taskDurationMs": 865.054,
"heapDeltaBytes": 13274820,
"heapUsedBytes": 73376480,
"domNodes": -183,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 109.20500000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1453.1319999999823,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.010999999999996,
"layouts": 5,
"layoutDurationMs": 14.471000000000002,
"taskDurationMs": 1145.634,
"heapDeltaBytes": 40473256,
"heapUsedBytes": 118307692,
"domNodes": 16030,
"jsHeapTotalBytes": 16125952,
"scriptDurationMs": 47.362,
"eventListeners": 3246,
"totalBlockingTimeMs": 153,
"frameDurationMs": 19.554666666666673,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10107.950000000017,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.479,
"layouts": 8,
"layoutDurationMs": 2.139,
"taskDurationMs": 6206.054,
"heapDeltaBytes": -3181948,
"heapUsedBytes": 72419800,
"domNodes": -257,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2807.225,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666006600660065,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10595.010000000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.134999999999998,
"layouts": 8,
"layoutDurationMs": 2.2749999999999995,
"taskDurationMs": 6324.071999999999,
"heapDeltaBytes": -18725484,
"heapUsedBytes": 61580572,
"domNodes": -257,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 2830.362,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.692271293375395,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23217.714,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22823.777,
"heapDeltaBytes": 9783728,
"heapUsedBytes": 287027480,
"domNodes": -307,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 334.5439999999999,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.456607142857145,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 23974.312999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23405.117000000002,
"heapDeltaBytes": -5151248,
"heapUsedBytes": 277768616,
"domNodes": -3343,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 361.21799999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.59733570159858,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28220.132999999976,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.072000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27862.024,
"heapDeltaBytes": -13240528,
"heapUsedBytes": 263372436,
"domNodes": -3343,
"jsHeapTotalBytes": 14409728,
"scriptDurationMs": 896.586,
"eventListeners": -651,
"totalBlockingTimeMs": 22,
"frameDurationMs": 51.962246777163905,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 28873.76299999994,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.661999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28513.509000000002,
"heapDeltaBytes": -6011192,
"heapUsedBytes": 270659508,
"domNodes": -3343,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 929.6099999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 54.05524344569288,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8235.770000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.04599999999999,
"layouts": 20,
"layoutDurationMs": 23.66700000000001,
"taskDurationMs": 8117.879,
"heapDeltaBytes": -20285668,
"heapUsedBytes": 252213084,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 119.59599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.25280898876404,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8398.139000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.382,
"layouts": 20,
"layoutDurationMs": 28.487,
"taskDurationMs": 8269.579,
"heapDeltaBytes": -24621268,
"heapUsedBytes": 267131344,
"domNodes": -3343,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 152.058,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.18932584269663,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11600.936999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11359.152999999998,
"heapDeltaBytes": 61716,
"heapUsedBytes": 280772984,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.78500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.279359430604984,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11712.504999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11487.365999999998,
"heapDeltaBytes": -6920080,
"heapUsedBytes": 264303900,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.38400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.07463235294117,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 141.9920000000161,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.531999999999998,
"layouts": 10,
"layoutDurationMs": 4.285,
"taskDurationMs": 128.902,
"heapDeltaBytes": -14041596,
"heapUsedBytes": 61127380,
"domNodes": 138,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 12.817999999999998,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555566,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 142.879999999991,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.931,
"layouts": 10,
"layoutDurationMs": 3.4379999999999997,
"taskDurationMs": 106.52,
"heapDeltaBytes": -12478916,
"heapUsedBytes": 61691704,
"domNodes": 99,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 8.841,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 505.11999999991986,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.651,
"layouts": 76,
"layoutDurationMs": 15.969000000000001,
"taskDurationMs": 459.801,
"heapDeltaBytes": -3993248,
"heapUsedBytes": 40699124,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 224.688,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 500.08200000002034,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.732,
"layouts": 76,
"layoutDurationMs": 15.613999999999999,
"taskDurationMs": 442.22499999999997,
"heapDeltaBytes": -4289568,
"heapUsedBytes": 40931564,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 213.639,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 670.4740000000129,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.5820000000000003,
"layouts": 76,
"layoutDurationMs": 16.7,
"taskDurationMs": 641.28,
"heapDeltaBytes": 1751376,
"heapUsedBytes": 96054044,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 260.383,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.073170731707318,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 532.9810000000634,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.694,
"layouts": 76,
"layoutDurationMs": 14.606,
"taskDurationMs": 490.233,
"heapDeltaBytes": 507048,
"heapUsedBytes": 103585164,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 195.692,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 59.7% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3136 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9da8a5031f3915b4ecb110b2ff60dcfc8dfdf48f
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (282)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22869 +/- ##
=============================================
Coverage ? 87.29%
=============================================
Files ? 3069
Lines ? 160776
Branches ? 40446
=============================================
Hits ? 140354
Misses ? 19745
Partials ? 677
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22077 (
fix: Fix consent card layout, DES-1291 / PM-2286) tocloud/1.59, the branchcloud.comfy.orgcurrently serves.Why this target, and why it is not blocked on #21933
The audited plan for this work said #22077 must not be backported alone because #21933 (
feat(agent): one consent onboarding for Cloud and Desktop) is its consent-architecture prerequisite and is absent from every older line. That framing turns out to be wrong for this file, and the measurement is simple:#21933 does not touch
AgentConsentCard.vueat all. Its 27 files are the consent flow —useAgentConsent,agentPanelStore,agentConsentIntroductionStore, the settings and telemetry types, and the deletion ofconsentOfferDeclined. #22077 is a layout change to the card plus a viewport-centring capability onGlobalDialog. They are independent surfaces.cloud/1.59'sAgentConsentCard.vuediffers from #22077's own parent commit by 7 added and 4 removed lines, all of which are unrelated refactors that have not reached this train:@comfyorg/design-system/{media/Video,button/Button,dialog/DialogTitle}→ the local@/components/...paths (refactor: move pure components into design system #21240, refactor: move remaining pure components into design system #22140 moved these into the design-system package after this train forked).<span class="icon-[…] size-3">instead of<i aria-hidden class="icon-[…] size-3">(refactor: default Iconify icons to size-4 #21949 defaulted Iconify icons tosize-4).So the card this PR rewrites is, for practical purposes, the same card #22077 was written against.
The one adaptation
#22077 drops the explicit size from the docs-link icon (
<i class="icon-[lucide--square-arrow-out-up-right]" />), because #21949 — merged 2026-10-27, one day before #22077 — had already madesize-4the Iconify default. #21949 is not oncloud/1.59, so carrying that line verbatim would leave the icon with no dimensions. This PR restores an explicitsize-4and thearia-hidden="true"that the pre-#22077 markup carried:size-4rather than the oldsize-3becausesize-4is the size #22077 intends onmain. That is the entire deviation fromcherry-pick -x cc1a808b65; everything else, including thebrowser_testshunks, the updated visual snapshot and the.github/pr-images/DES-1291/*assets, is carried unchanged.What this fixes on the served cloud line
cloud/v1.60.0(testcloud)cloud/v1.59.5(production)v1.60.0(core)v1.58.5,v1.57.7(core)cloud/v1.60.0is the first released artifact carrying the consent stack, and it is on testcloud, not production. Production cloud iscloud/1.59(frontend-version.jsonreleaseBranch, rotated 2026-10-31), and it has the pre-#22077 layout. This PR is what closes that gap without waiting for the 1.60 promotion.Verification on this head
pnpm typecheckandpnpm typecheck:browser: 0 errors.oxfmt,stylelint,oxlint --type-aware,eslint,lint:server-facts,typecheck:app, unused-i18n-keys, frozen-dirs.AgentConsentCard,useAgentConsent,GlobalDialog,AgentPanelRoot,extensions/core/agentPanel.browser_tests/tests/agent/agentConsent.spec.ts --project=cloud— the spec fix: Fix consent card layout #22077's own description calls "the layout contract", and the target branch's own consent path exercised against the old consent architecture, with feat(agent): one consent onboarding for Cloud and Desktop #21933 not imported:@screenshotvisual-regression casewith the light palette › keeps the dark card readableagainst fix: Fix consent card layout #22077's updated snapshot. The layout renders as intended on this train.dismisses without consent and persists acceptance before reopening, failed insidecomfyPagefixture setup withapp never became ready— a cold dev server, not an assertion. It passes 2/2 on a re-run against the same warm server, and the same test also fails on unmodifiedorigin/cloud/1.59on this host.browser_tests/tests/dialogs/globalDialogViewportCenter.spec.ts, the spec fix: Fix consent card layout #22077 adds for the viewport-centring half: 1/1 passed under--project=chromium(it is@ui, not@cloud, so it needs a dev server withoutDISTRIBUTION=cloud).Baseline control:
agentConsent.spec.tswas also run on unmodifiedorigin/cloud/1.59on the same host, backend and dev server (21 passed / 5 failed, all five fixture-setup or 15s-timeout failures). So the comparison is like-for-like against this train rather than againstmain-era expectations, and the probe is strictly better than the branch it targets.Authority: the program's release-backport grant for the current trains.
Labels deliberately not applied
No trigger label is on this PR.
cursor-reviewis withheld on purpose: it is one-shot, and R-513 is still live — acursor-review-labelled PR merged today (#22858) has zero Cursor comments or review cells, so applying it here would consume this PR's only use for nothing.greenlightis left unspent for whoever lands it.comfy-greenlight-botis healthy and approving on this repo, so that path is available.