Repository navigation
[backport core/1.56] ING-212 fix(auth): keep asset redirects off credentialed CORS - #21149
Conversation
## Summary Cloud asset downloads now keep the session cookie on the same-origin ingest request without requiring credentialed CORS after ingest redirects to a signed storage URL. Workspace/CSRF headers and retries are preserved; genuinely cross-origin ingest requests retain the authorizer's `include` policy. Fixes https://linear.app/comfyorg/issue/ING-212/bug-cloud-completed-video-download-fails-with-cors-redirect-error **Root cause / why now:** the existing download path already used `api.fetchApi` to preserve workspace authentication (PR 18421). PR 18716 introduced `credentials: 'include'` for session authorization, and PR 18875 routed Cloud ingest requests through it. With `unified_web_session` enabled, `/api/assets/{id}/content` still returns a 302 to GCS, but the followed fetch remains credentialed. GCS's XML API does not support `Access-Control-Allow-Credentials`, so the browser rejects the bytes. This was a latent flag-on incompatibility, not a newly changed download button: [Oct 15 QA records the 100% ramp at 10:04 EDT](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1792075311777139), and a [later update explicitly confirms 100% in production](https://comfy-organization.slack.com/archives/C0C6V3NUXPU/p1792093817831899). The previous tests checked authenticated requests against fetch doubles without exercising a storage redirect in a browser. **How:** select `same-origin` at the Cloud session transport boundary when the request URL resolves to the page's origin. Keep the shared account-core authorizer unchanged for clients that need cookies across origins. Passing a download-only option to `fetchApi` would not fix this because the transport overwrites it with the authorizer's credentials. ## Verification - RED: with the original source, the new actual-app browser test fails to download and Chromium logs the missing `Access-Control-Allow-Credentials` error with credentials mode `include`. Restoring the fix makes it pass. - Browser: 2 passed, personal and team workspaces. Actual Media Assets context-menu Download, authenticated ingest 302 double, separate real HTTP storage server without ACAC, saved filename and byte comparison. A cookie seeded for the storage host is not sent; the first hop retains the session cookie and selected workspace. - Unit: 364 passed in the 5 affected session/auth, asset-action and download-utility suites. The URL table covers relative, absolute same-origin and remote ingest requests. Existing flag-off, CSRF retry and workspace-denial coverage passes. - App + browser typechecks, touched-file oxlint/ESLint/oxfmt and knip passed. Commit and push hooks run without bypasses. - Browser proof uses the repository-pinned Chromium 153. System Chrome 155 aborts Playwright-intercepted redirects before reaching the storage server; it is not used as a passing regression result. ### AS IS / TO BE AS IS: [production report with the PNG screenshot](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1792109025101229). TO BE: actual-app Download regressions pass for personal/team workspaces with this PR. Live production-storage check also passed from `https://cloud.comfy.org`: a DevTools request using the PR's `same-origin` credentials policy and workspace/client headers followed the real authenticated asset-content redirect to `storage.googleapis.com`, returned HTTP 200 (`image/png`, 2,620,563 bytes), and saved `Nano_Banana_2_00002_.png` (1024 x 1024; SHA-256 `54e4dc472f12a02c702ef71f0853490132e116b84475a9480ab0b03b3e3a9971`). This validates the production request policy, not a deployed PR bundle or production UI rollout. The local PR frontend cannot complete that live GCS check because the production bucket does not allow the localhost origin; an OPTIONS probe returned ACAO for Cloud but none for localhost. No signed URL or credentials are included in the evidence. Follow-up validation: 243 affected session/remote-widget unit tests and both personal/team browser regressions passed. CI exposed an additional remote-widget `include` expectation, now aligned with the same-origin policy. The fixture also handles a missing cookie header via `Headers.get()` before returning its intended 401 (CodeRabbit feedback). ### Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Session authorization policy | FE-2895 | [PR 18716](#18716) | Merged | | Cloud ingest on web session | FE-2904 | [PR 18875](#18875) | Merged | | **Storage redirect compatibility + browser regression** | **ING-212** | **This PR** | **Ready for review** | ```mermaid flowchart LR auth["FE-2895 / PR 18716"] --> ingest["FE-2904 / PR 18875"] ingest --> fix["ING-212 / this PR"] classDef current fill:#ffe08a,stroke:#b8860b,stroke-width:3px,color:#000 class fix current ``` --------- Co-authored-by: GitHub Action <action@github.com>
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-16T13:14:54.111Z",
"gitSha": "97f976256b78a80f32fceafdb27cf7b8f5c9c7c6",
"branch": "backport-21145-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.88000000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.426,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.788,
"heapDeltaBytes": 969996,
"heapUsedBytes": 68522868,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.224000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2015.3159999999843,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.4990000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.73400000000004,
"heapDeltaBytes": 1333856,
"heapUsedBytes": 68108128,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.636999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1794.114000000036,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.551000000000002,
"layouts": 12,
"layoutDurationMs": 4.757000000000001,
"taskDurationMs": 787.921,
"heapDeltaBytes": 20552372,
"heapUsedBytes": 81003612,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.328,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1788.3970000000318,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.887,
"layouts": 12,
"layoutDurationMs": 4.251,
"taskDurationMs": 781.8430000000001,
"heapDeltaBytes": -5894548,
"heapUsedBytes": 56516220,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.67999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.170999999993,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.921999999999999,
"layouts": 6,
"layoutDurationMs": 1.0710000000000002,
"taskDurationMs": 325.198,
"heapDeltaBytes": 4139604,
"heapUsedBytes": 72183224,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.597000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.3279999999377,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.996999999999998,
"layouts": 6,
"layoutDurationMs": 1.1949999999999998,
"taskDurationMs": 328.79099999999994,
"heapDeltaBytes": 4202788,
"heapUsedBytes": 72933332,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.836999999999993,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 671.7710000000352,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.222000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.6110000000001,
"heapDeltaBytes": -6788200,
"heapUsedBytes": 61037644,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 161.14299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 665.2309999999488,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.911999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.26400000000007,
"heapDeltaBytes": -7115384,
"heapUsedBytes": 61034356,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 161.625,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1125.4390000000285,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 788.0910000000001,
"heapDeltaBytes": 38667192,
"heapUsedBytes": 108079732,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 68.73400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 509,
"frameDurationMs": 33.329411764705874,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1146.3139999998475,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 790.7359999999999,
"heapDeltaBytes": 15127536,
"heapUsedBytes": 85097136,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 65.356,
"eventListeners": 0,
"totalBlockingTimeMs": 511,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.892000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.0760000000001,
"heapDeltaBytes": 17814844,
"heapUsedBytes": 105165440,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 174.79599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.5960000000669,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.63100000000026,
"heapDeltaBytes": 17738340,
"heapUsedBytes": 105080560,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.97299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.997058823529454,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9542.524999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8708.303,
"heapDeltaBytes": -12683388,
"heapUsedBytes": 72612960,
"domNodes": -143,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 7157.638000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 617,
"frameDurationMs": 32.872068965517244,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10032.862999999907,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9151.798999999999,
"heapDeltaBytes": -8761996,
"heapUsedBytes": 77447268,
"domNodes": -172,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 7645.633,
"eventListeners": -86,
"totalBlockingTimeMs": 1298,
"frameDurationMs": 33.27641196013289,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9585.469999999987,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9370000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8858.095,
"heapDeltaBytes": 5384896,
"heapUsedBytes": 84094056,
"domNodes": -142,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 7356.42,
"eventListeners": -74,
"totalBlockingTimeMs": 838,
"frameDurationMs": 33.15916955017301,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9882.851999999957,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05999999999999929,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9077.755,
"heapDeltaBytes": 11256204,
"heapUsedBytes": 89647512,
"domNodes": -142,
"jsHeapTotalBytes": -3805184,
"scriptDurationMs": 7549.21,
"eventListeners": -74,
"totalBlockingTimeMs": 1020,
"frameDurationMs": 33.388175675675676,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2009.604999999965,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.646000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.07800000000003,
"heapDeltaBytes": -7314328,
"heapUsedBytes": 78951132,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.07500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2013.1260000000566,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.11400000000003,
"heapDeltaBytes": 15062608,
"heapUsedBytes": 91158680,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.931000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2377.475000000004,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.773000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1583.9500000000003,
"heapDeltaBytes": -20659704,
"heapUsedBytes": 68923588,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 842.992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78380281690141,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2244.4550000000163,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.271,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1541.369,
"heapDeltaBytes": -20154144,
"heapUsedBytes": 69065816,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 819.6759999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.791044776119396,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3567.3799999999574,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.013,
"layouts": 60,
"layoutDurationMs": 13.568999999999999,
"taskDurationMs": 1646.2280000000003,
"heapDeltaBytes": 1816980,
"heapUsedBytes": 70822652,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 797.2090000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3569.5550000000367,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.561999999999998,
"layouts": 60,
"layoutDurationMs": 13.501000000000001,
"taskDurationMs": 1627.8209999999997,
"heapDeltaBytes": 866824,
"heapUsedBytes": 69614332,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 785.927,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3086.3709999999855,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.724000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1877.994,
"heapDeltaBytes": 17998132,
"heapUsedBytes": 86928328,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 979.9989999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756284153005463,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3159.445999999889,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.982999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1923.7210000000002,
"heapDeltaBytes": 5062316,
"heapUsedBytes": 74404840,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 1020.297,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.844385026737967,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2014.1840000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1149999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.684,
"heapDeltaBytes": -8977408,
"heapUsedBytes": 81059444,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.41300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.921000000053,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.3270000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.1750000000001,
"heapDeltaBytes": -9445428,
"heapUsedBytes": 80311980,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.248000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 604.4409999999516,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.246999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.61300000000006,
"heapDeltaBytes": -12034764,
"heapUsedBytes": 58059624,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 142.59199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.7560000000594,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.142999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.0009999999999,
"heapDeltaBytes": -12723432,
"heapUsedBytes": 58212020,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 143.95000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670588235294122,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.7389999999677,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.621999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.43700000000007,
"heapDeltaBytes": 1140140,
"heapUsedBytes": 70327628,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.731000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.2950000000656,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.2909999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.011,
"heapDeltaBytes": 1364060,
"heapUsedBytes": 71621768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.465,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.7700000000768,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.966999999999995,
"layouts": 16,
"layoutDurationMs": 5.25,
"taskDurationMs": 731.773,
"heapDeltaBytes": -5965240,
"heapUsedBytes": 63808540,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.36400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.072000000153,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.689000000000004,
"layouts": 16,
"layoutDurationMs": 5.247,
"taskDurationMs": 733.0490000000001,
"heapDeltaBytes": -5950072,
"heapUsedBytes": 64208664,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 108.77299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.801000000205,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.268,
"layouts": 5,
"layoutDurationMs": 14.319000000000003,
"taskDurationMs": 894.8539999999998,
"heapDeltaBytes": 2882560,
"heapUsedBytes": 96840360,
"domNodes": 14227,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 28.709,
"eventListeners": 2463,
"totalBlockingTimeMs": 130,
"frameDurationMs": 19.143243243243237,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8489.860000000022,
"styleRecalcs": 251,
"styleRecalcDurationMs": 34.001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5644.084000000001,
"heapDeltaBytes": -14288280,
"heapUsedBytes": 74309432,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2887.121,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6988188976378,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8312.920000000076,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.657999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5495.648,
"heapDeltaBytes": -18812996,
"heapUsedBytes": 69785336,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2761.406,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699597585513075,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17213.77700000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16493.054,
"heapDeltaBytes": -33869528,
"heapUsedBytes": 179530324,
"domNodes": -3045,
"jsHeapTotalBytes": 5591040,
"scriptDurationMs": 304.952,
"eventListeners": -14915,
"totalBlockingTimeMs": 1,
"frameDurationMs": 28.809547738693468,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17859.735,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16981.572,
"heapDeltaBytes": -33176904,
"heapUsedBytes": 179466956,
"domNodes": -3045,
"jsHeapTotalBytes": 5001216,
"scriptDurationMs": 310.715,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 30.51162393162393,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 21335.060999999994,
"styleRecalcs": 179,
"styleRecalcDurationMs": 17.830000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20903.077,
"heapDeltaBytes": -35444672,
"heapUsedBytes": 175515572,
"domNodes": -3045,
"jsHeapTotalBytes": 8704000,
"scriptDurationMs": 844.361,
"eventListeners": -14915,
"totalBlockingTimeMs": 54,
"frameDurationMs": 38.161896243291594,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 22563.513000000057,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22070.16,
"heapDeltaBytes": -22815516,
"heapUsedBytes": 193008380,
"domNodes": -3045,
"jsHeapTotalBytes": 5574656,
"scriptDurationMs": 949.1440000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 12,
"frameDurationMs": 41.32930402930403,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6507.247000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.97299999999998,
"layouts": 20,
"layoutDurationMs": 23.923,
"taskDurationMs": 6358.5779999999995,
"heapDeltaBytes": 6206720,
"heapUsedBytes": 217544096,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 113.026,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.02443181818182,
"p95FrameDurationMs": 83.19999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 6352.421999999933,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.426,
"layouts": 20,
"layoutDurationMs": 22.308000000000007,
"taskDurationMs": 6238.532,
"heapDeltaBytes": -9109100,
"heapUsedBytes": 212410168,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 106.74,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.796428571428564,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9120.646999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8697.257000000001,
"heapDeltaBytes": -38502844,
"heapUsedBytes": 179154048,
"domNodes": -3045,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 176.98499999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.90305084745762,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9232.24099999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8739.761,
"heapDeltaBytes": -37952652,
"heapUsedBytes": 179468520,
"domNodes": -3045,
"jsHeapTotalBytes": 4595712,
"scriptDurationMs": 143.38400000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.08720538720539,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 142.8369999998722,
"styleRecalcs": 10,
"styleRecalcDurationMs": 16.361,
"layouts": 5,
"layoutDurationMs": 2.4819999999999998,
"taskDurationMs": 105.217,
"heapDeltaBytes": 3873656,
"heapUsedBytes": 69684252,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.424000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 102.26799999986724,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.849,
"layouts": 3,
"layoutDurationMs": 1.7309999999999999,
"taskDurationMs": 76.79000000000002,
"heapDeltaBytes": 3669160,
"heapUsedBytes": 69422880,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.099,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65714285714278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 787.3010000000704,
"styleRecalcs": 78,
"styleRecalcDurationMs": 97.656,
"layouts": 76,
"layoutDurationMs": 23.335,
"taskDurationMs": 755.33,
"heapDeltaBytes": 16956280,
"heapUsedBytes": 81219716,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 307.76200000000006,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 865.5610000000706,
"styleRecalcs": 78,
"styleRecalcDurationMs": 101.20400000000001,
"layouts": 76,
"layoutDurationMs": 24.357,
"taskDurationMs": 840.611,
"heapDeltaBytes": 18015012,
"heapUsedBytes": 85572488,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 357.93800000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1392.991999999822,
"styleRecalcs": 78,
"styleRecalcDurationMs": 256.01,
"layouts": 76,
"layoutDurationMs": 28.363,
"taskDurationMs": 1363.579,
"heapDeltaBytes": 8709404,
"heapUsedBytes": 115644028,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 454.776,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.510126582278495,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1357.8319999999167,
"styleRecalcs": 78,
"styleRecalcDurationMs": 250.457,
"layouts": 76,
"layoutDurationMs": 28.355,
"taskDurationMs": 1337.309,
"heapDeltaBytes": 8561784,
"heapUsedBytes": 114351472,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 444.894,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.51012658227847,
"p95FrameDurationMs": 33.29999999999927
}
]
}🎭 Playwright: ✅ 2204 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 5773588f827d35c4fb3d54769da8161f047c4b95
Full docs: ADR-DEVEX-LINT-0015 |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #21149 +/- ##
=============================================
- Coverage 85.95% 85.93% -0.02%
=============================================
Files 2482 2482
Lines 141719 141759 +40
Branches 38583 38591 +8
=============================================
+ Hits 121813 121827 +14
- Misses 19522 19548 +26
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
1.56's network setup assigns a plain fetch, so vi.mocked(fetch) has no mockResolvedValue.
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of #21145. The 1.56 unit failure was vi.mocked(fetch) against a plain fetch guard; the test now stubs fetch. Auto-merge once the new checks are green.
Backport of #21145 to
core/1.56Automatically created by backport workflow.