Skip to content

[backport cloud/1.56] ING-212 fix(auth): keep asset redirects off credentialed CORS - #21150

Merged
comfy-pr-bot merged 2 commits into
cloud/1.56from
backport-21145-to-cloud-1.56
Oct 16, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.56from
backport-21145-to-cloud-1.56

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #21145 to cloud/1.56

Automatically created by backport workflow.

## Summary

Cloud asset downloads now keep the session cookie on the same-origin
ingest request without requiring credentialed CORS after ingest
redirects to a signed storage URL. Workspace/CSRF headers and retries
are preserved; genuinely cross-origin ingest requests retain the
authorizer's `include` policy.

Fixes
https://linear.app/comfyorg/issue/ING-212/bug-cloud-completed-video-download-fails-with-cors-redirect-error

**Root cause / why now:** the existing download path already used
`api.fetchApi` to preserve workspace authentication (PR 18421). PR 18716
introduced `credentials: 'include'` for session authorization, and PR
18875 routed Cloud ingest requests through it. With
`unified_web_session` enabled, `/api/assets/{id}/content` still returns
a 302 to GCS, but the followed fetch remains credentialed. GCS's XML API
does not support `Access-Control-Allow-Credentials`, so the browser
rejects the bytes. This was a latent flag-on incompatibility, not a
newly changed download button: [Oct 15 QA records the 100% ramp at 10:04
EDT](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1792075311777139),
and a [later update explicitly confirms 100% in
production](https://comfy-organization.slack.com/archives/C0C6V3NUXPU/p1792093817831899).
The previous tests checked authenticated requests against fetch doubles
without exercising a storage redirect in a browser.

**How:** select `same-origin` at the Cloud session transport boundary
when the request URL resolves to the page's origin. Keep the shared
account-core authorizer unchanged for clients that need cookies across
origins. Passing a download-only option to `fetchApi` would not fix this
because the transport overwrites it with the authorizer's credentials.

## Verification

- RED: with the original source, the new actual-app browser test fails
to download and Chromium logs the missing
`Access-Control-Allow-Credentials` error with credentials mode
`include`. Restoring the fix makes it pass.
- Browser: 2 passed, personal and team workspaces. Actual Media Assets
context-menu Download, authenticated ingest 302 double, separate real
HTTP storage server without ACAC, saved filename and byte comparison. A
cookie seeded for the storage host is not sent; the first hop retains
the session cookie and selected workspace.
- Unit: 364 passed in the 5 affected session/auth, asset-action and
download-utility suites. The URL table covers relative, absolute
same-origin and remote ingest requests. Existing flag-off, CSRF retry
and workspace-denial coverage passes.
- App + browser typechecks, touched-file oxlint/ESLint/oxfmt and knip
passed. Commit and push hooks run without bypasses.
- Browser proof uses the repository-pinned Chromium 153. System Chrome
155 aborts Playwright-intercepted redirects before reaching the storage
server; it is not used as a passing regression result.

### AS IS / TO BE

AS IS: [production report with the PNG
screenshot](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1792109025101229).

TO BE: actual-app Download regressions pass for personal/team workspaces
with this PR. Live production-storage check also passed from
`https://cloud.comfy.org`: a DevTools request using the PR's
`same-origin` credentials policy and workspace/client headers followed
the real authenticated asset-content redirect to
`storage.googleapis.com`, returned HTTP 200 (`image/png`, 2,620,563
bytes), and saved `Nano_Banana_2_00002_.png` (1024 x 1024; SHA-256
`54e4dc472f12a02c702ef71f0853490132e116b84475a9480ab0b03b3e3a9971`).
This validates the production request policy, not a deployed PR bundle
or production UI rollout. The local PR frontend cannot complete that
live GCS check because the production bucket does not allow the
localhost origin; an OPTIONS probe returned ACAO for Cloud but none for
localhost. No signed URL or credentials are included in the evidence.


Follow-up validation: 243 affected session/remote-widget unit tests and
both personal/team browser regressions passed. CI exposed an additional
remote-widget `include` expectation, now aligned with the same-origin
policy. The fixture also handles a missing cookie header via
`Headers.get()` before returning its intended 401 (CodeRabbit feedback).

### Plan position

| Item | Ticket | PR | Status |
| --- | --- | --- | --- |
| Session authorization policy | FE-2895 | [PR
18716](#18716) |
Merged |
| Cloud ingest on web session | FE-2904 | [PR
18875](#18875) |
Merged |
| **Storage redirect compatibility + browser regression** | **ING-212**
| **This PR** | **Ready for review** |

```mermaid
flowchart LR
  auth["FE-2895 / PR 18716"] --> ingest["FE-2904 / PR 18875"]
  ingest --> fix["ING-212 / this PR"]
  classDef current fill:#ffe08a,stroke:#b8860b,stroke-width:3px,color:#000
  class fix current
```

---------

Co-authored-by: GitHub Action <action@github.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 16, 2026
@comfy-pr-bot
comfy-pr-bot requested a review from a team as a code owner October 16, 2026 02:02
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 16, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) October 16, 2026 02:02
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.6 MB heap
dom-widget-order-dense-n200-w200-i120: · 29.8 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 510ms TBT · 81.3 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 39.2 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 233ms TBT · 80.1 MB heap
extension-clean-combined-draw: · 32.5 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 265ms TBT · 84.5 MB heap
extension-rgthree-prototype-draw: · 31.6 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 248ms TBT · 83.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
large-graph-pan: · 59.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap
legacy-node-drag: · 59.5 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
subgraph-transition-enter: · 51.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 133ms TBT · 90.2 MB heap
viewport-pan-sweep: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
vue-large-graph-idle: · 29.3 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 172.0 MB heap
vue-large-graph-pan: · 21.5 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 51ms TBT · 167.7 MB heap
vue-node-resize-workload: · 22.7 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 13ms TBT · 204.0 MB heap
vue-zoom-out-idle: · 28.7 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 173.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
agent-composer-empty-conversation-typing: · 59.6 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
agent-composer-long-conversation-typing: · 52.2 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 109.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 464ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.5 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 19ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 832ms
canvas-mouse-sweep: script duration 162ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.9 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 11ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 378ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 69.1 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 472ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 58.6 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 34ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 813ms
dom-widget-order-dense-n200-w200-i120: script duration 63ms
dom-widget-order-dense-n200-w200-i120: TBT 510ms
dom-widget-order-dense-n200-w200-i120: heap used 81.3 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 499ms
dom-widget-order-sparse-n1000-w20-i120: script duration 154ms
dom-widget-order-sparse-n1000-w20-i120: TBT 233ms
dom-widget-order-sparse-n1000-w20-i120: heap used 80.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 31ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 2
extension-clean-combined-draw: task duration 8306ms
extension-clean-combined-draw: script duration 6678ms
extension-clean-combined-draw: TBT 265ms
extension-clean-combined-draw: heap used 84.5 MB
extension-clean-combined-draw: DOM nodes -142
extension-clean-combined-draw: event listeners -72
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 7994ms
extension-rgthree-prototype-draw: script duration 6449ms
extension-rgthree-prototype-draw: TBT 248ms
extension-rgthree-prototype-draw: heap used 83.0 MB
extension-rgthree-prototype-draw: DOM nodes -143
extension-rgthree-prototype-draw: event listeners -78
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 547ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 73.7 MB
large-graph-idle: DOM nodes 0
large-graph-idle: event listeners 0
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1619ms
large-graph-pan: script duration 844ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 78.2 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 17ms
large-graph-zoom: style recalc duration 16ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1743ms
large-graph-zoom: script duration 825ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.5 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1991ms
legacy-node-drag: script duration 1056ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 595ms
minimap-idle: script duration 42ms
minimap-idle: TBT 0ms
minimap-idle: heap used 75.0 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 439ms
subgraph-dom-widget-clipping: script duration 154ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 62.3 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 471ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.6 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 22ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 810ms
subgraph-mouse-sweep: script duration 118ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.0 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1042ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 133ms
subgraph-transition-enter: heap used 90.2 MB
subgraph-transition-enter: DOM nodes 14227
subgraph-transition-enter: event listeners 2463
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 44ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 252
viewport-pan-sweep: task duration 5837ms
viewport-pan-sweep: script duration 2883ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 67.6 MB
viewport-pan-sweep: DOM nodes 0
viewport-pan-sweep: event listeners 0
vue-large-graph-idle: avg frame time 34ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18478ms
vue-large-graph-idle: script duration 315ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.0 MB
vue-large-graph-idle: DOM nodes -3045
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 47ms
vue-large-graph-pan: p95 frame time 100ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 28ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 23892ms
vue-large-graph-pan: script duration 937ms
vue-large-graph-pan: TBT 51ms
vue-large-graph-pan: heap used 167.7 MB
vue-large-graph-pan: DOM nodes -3060
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 44ms
vue-node-resize-workload: p95 frame time 83ms
vue-node-resize-workload: layout duration 29ms
vue-node-resize-workload: style recalc duration 78ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6965ms
vue-node-resize-workload: script duration 127ms
vue-node-resize-workload: TBT 13ms
vue-node-resize-workload: heap used 204.0 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 35ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 9503ms
vue-zoom-out-idle: script duration 169ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.9 MB
vue-zoom-out-idle: DOM nodes -3045
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 118ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.5 MB
workflow-execution: DOM nodes 102
workflow-execution: event listeners 73
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 32ms
agent-composer-empty-conversation-typing: style recalc duration 124ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 1121ms
agent-composer-empty-conversation-typing: script duration 455ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 83.5 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 19ms
agent-composer-long-conversation-typing: p95 frame time 33ms
agent-composer-long-conversation-typing: layout duration 33ms
agent-composer-long-conversation-typing: style recalc duration 302ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1502ms
agent-composer-long-conversation-typing: script duration 481ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 109.3 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-16T13:15:05.997Z",
  "gitSha": "b1db9b7228ab6c694a1cd9989b8d976187d54871",
  "branch": "backport-21145-to-cloud-1.56",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2021.8459999999823,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.157,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 430.89300000000003,
      "heapDeltaBytes": 962536,
      "heapUsedBytes": 69098116,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.840999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2018.466999999987,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.581,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 497.454,
      "heapDeltaBytes": 714260,
      "heapUsedBytes": 68336172,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 12.591999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1796.799999999962,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 19.415000000000003,
      "layouts": 12,
      "layoutDurationMs": 4.543,
      "taskDurationMs": 815.663,
      "heapDeltaBytes": -2342712,
      "heapUsedBytes": 65202484,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 161.20299999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665740740740745,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1822.9129999999714,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 19.448,
      "layouts": 12,
      "layoutDurationMs": 4.873,
      "taskDurationMs": 847.362,
      "heapDeltaBytes": -2083400,
      "heapUsedBytes": 66659260,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 163.39499999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666055045871563,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1736.8930000000091,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 10.181999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.251,
      "taskDurationMs": 354.63800000000003,
      "heapDeltaBytes": 4087404,
      "heapUsedBytes": 72678172,
      "domNodes": 53,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 13.946999999999997,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66538461538462,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1716.965000000073,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 10.822,
      "layouts": 6,
      "layoutDurationMs": 1.3169999999999997,
      "taskDurationMs": 401.5970000000001,
      "heapDeltaBytes": 4193508,
      "heapUsedBytes": 72330180,
      "domNodes": 53,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 16.691,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66504854368932,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 722.5389999999834,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 4.021999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.51,
      "heapDeltaBytes": -7548852,
      "heapUsedBytes": 61554164,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 167.262,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662790697674417,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 710.6089999999767,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 4.197000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.722,
      "heapDeltaBytes": -6720664,
      "heapUsedBytes": 61409776,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 166.441,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66428571428573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1140.9499999999753,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 798.2380000000002,
      "heapDeltaBytes": 16758368,
      "heapUsedBytes": 85581028,
      "domNodes": 0,
      "jsHeapTotalBytes": 4358144,
      "scriptDurationMs": 64.273,
      "eventListeners": 0,
      "totalBlockingTimeMs": 498,
      "frameDurationMs": 33.33235294117645,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1144.8740000000726,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 827.8280000000001,
      "heapDeltaBytes": 16058872,
      "heapUsedBytes": 85002248,
      "domNodes": 0,
      "jsHeapTotalBytes": 3571712,
      "scriptDurationMs": 62.48100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 521,
      "frameDurationMs": 33.82058823529413,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 847.327000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.0409999999998,
      "heapDeltaBytes": -14631132,
      "heapUsedBytes": 83634168,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 144.32899999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 225,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 877.1369999999479,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 524.2009999999997,
      "heapDeltaBytes": -14423356,
      "heapUsedBytes": 84451280,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 164.387,
      "eventListeners": 0,
      "totalBlockingTimeMs": 241,
      "frameDurationMs": 25.976470588235316,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9160.552999999993,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.4670000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8240.261,
      "heapDeltaBytes": 16311952,
      "heapUsedBytes": 93161920,
      "domNodes": -142,
      "jsHeapTotalBytes": -9310208,
      "scriptDurationMs": 6637.781,
      "eventListeners": -74,
      "totalBlockingTimeMs": 319,
      "frameDurationMs": 31.17823129251701,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9202.255000000037,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.5120000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8371.693000000001,
      "heapDeltaBytes": 15931980,
      "heapUsedBytes": 83997848,
      "domNodes": -142,
      "jsHeapTotalBytes": -10883072,
      "scriptDurationMs": 6718.108,
      "eventListeners": -70,
      "totalBlockingTimeMs": 210,
      "frameDurationMs": 30.361716171617164,
      "p95FrameDurationMs": 50.099999999999454
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 8556.415000000015,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.8769999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7827.589999999999,
      "heapDeltaBytes": 15204504,
      "heapUsedBytes": 93307236,
      "domNodes": -143,
      "jsHeapTotalBytes": -6950912,
      "scriptDurationMs": 6363.18,
      "eventListeners": -82,
      "totalBlockingTimeMs": 239,
      "frameDurationMs": 31.721189591078065,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 8944.786000000022,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.5969999999999969,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8160.626,
      "heapDeltaBytes": 2963320,
      "heapUsedBytes": 80777648,
      "domNodes": -142,
      "jsHeapTotalBytes": -14553088,
      "scriptDurationMs": 6534.309,
      "eventListeners": -74,
      "totalBlockingTimeMs": 256,
      "frameDurationMs": 31.51302816901409,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2020.4980000000319,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.052000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.513,
      "heapDeltaBytes": -10455260,
      "heapUsedBytes": 77479476,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 35.732,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2021.4600000000473,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.417999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 577.9159999999999,
      "heapDeltaBytes": -10088748,
      "heapUsedBytes": 77128952,
      "domNodes": 0,
      "jsHeapTotalBytes": 299008,
      "scriptDurationMs": 41.02400000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2462.6539999999864,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 12.909,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1610.056,
      "heapDeltaBytes": -19432068,
      "heapUsedBytes": 69139236,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 848.5939999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.77891156462585,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2563.7269999999717,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.494000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1627.8899999999999,
      "heapDeltaBytes": 9907984,
      "heapUsedBytes": 94905368,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 840.097,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.775163398692808,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3692.8859999999872,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 16.192999999999998,
      "layouts": 60,
      "layoutDurationMs": 16.707,
      "taskDurationMs": 1715.9909999999998,
      "heapDeltaBytes": -20538724,
      "heapUsedBytes": 70303428,
      "domNodes": 24,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 817.0310000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66576576576577,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3804.9369999999954,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 16.112000000000002,
      "layouts": 60,
      "layoutDurationMs": 16.729,
      "taskDurationMs": 1770.7959999999998,
      "heapDeltaBytes": -20611508,
      "heapUsedBytes": 69159588,
      "domNodes": 24,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 833.861,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666228070175443,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3139.2019999999548,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.418999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1997.3719999999998,
      "heapDeltaBytes": 18345748,
      "heapUsedBytes": 86536380,
      "domNodes": 0,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 1073.41,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.755080213903742,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3125.846000000024,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.613999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1985.05,
      "heapDeltaBytes": -11250804,
      "heapUsedBytes": 76452072,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 1039.35,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.845945945945946,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2014.2199999999661,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 565.457,
      "heapDeltaBytes": -10207076,
      "heapUsedBytes": 78693884,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 40.343999999999994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.8129999999373,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.096000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 623.8419999999999,
      "heapDeltaBytes": -10488036,
      "heapUsedBytes": 78532236,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 42.83100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 605.5270000000519,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.117999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.43399999999997,
      "heapDeltaBytes": 9784064,
      "heapUsedBytes": 72511192,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 150.41199999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 718.4780000000046,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 8.184000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.93600000000004,
      "heapDeltaBytes": -11909596,
      "heapUsedBytes": 58162104,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 156.996,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665116279069775,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2013.700999999969,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.745,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.87700000000007,
      "heapDeltaBytes": -2591320,
      "heapUsedBytes": 61365068,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.723999999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.5299999999606,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.2189999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.356,
      "heapDeltaBytes": -2946100,
      "heapUsedBytes": 59410828,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.021999999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.471999999968,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 21.605999999999998,
      "layouts": 16,
      "layoutDurationMs": 6.3500000000000005,
      "taskDurationMs": 776.822,
      "heapDeltaBytes": 16970560,
      "heapUsedBytes": 80729672,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 115.722,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1774.6349999999893,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 21.560999999999996,
      "layouts": 16,
      "layoutDurationMs": 6.578,
      "taskDurationMs": 843.1510000000001,
      "heapDeltaBytes": -6159160,
      "heapUsedBytes": 63878076,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 120.43100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666037735849052,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1420.2150000000984,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.71100000000001,
      "layouts": 5,
      "layoutDurationMs": 14.347999999999999,
      "taskDurationMs": 1042.0479999999998,
      "heapDeltaBytes": 1304352,
      "heapUsedBytes": 94563436,
      "domNodes": 14227,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 32.04399999999999,
      "eventListeners": 2463,
      "totalBlockingTimeMs": 133,
      "frameDurationMs": 19.368918918918933,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8494.553999999993,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 42.303,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5591.351,
      "heapDeltaBytes": -17475544,
      "heapUsedBytes": 70948220,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 2801.772,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.69882121807466,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9861.233000000084,
      "styleRecalcs": 252,
      "styleRecalcDurationMs": 45.96,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6083.204000000001,
      "heapDeltaBytes": -16604564,
      "heapUsedBytes": 70836892,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 2963.681,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.722410865874362,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18732.235000000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18228.345,
      "heapDeltaBytes": -40600596,
      "heapUsedBytes": 179982168,
      "domNodes": -3045,
      "jsHeapTotalBytes": 7163904,
      "scriptDurationMs": 313.83399999999995,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.24316163410302,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19177.437999999936,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18727.654000000002,
      "heapDeltaBytes": -40818816,
      "heapUsedBytes": 180742196,
      "domNodes": -3045,
      "jsHeapTotalBytes": 8474624,
      "scriptDurationMs": 316.43,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 35.1025641025641,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24348.22600000001,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 28.24099999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24093.956000000002,
      "heapDeltaBytes": -45828948,
      "heapUsedBytes": 175613888,
      "domNodes": -3074,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 945.778,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 56,
      "frameDurationMs": 47.03803088803088,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23979.76200000005,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 28.608000000000022,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23690.109,
      "heapDeltaBytes": -58296268,
      "heapUsedBytes": 176142612,
      "domNodes": -3045,
      "jsHeapTotalBytes": 4128768,
      "scriptDurationMs": 929.2170000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 45,
      "frameDurationMs": 45.99942418426104,
      "p95FrameDurationMs": 99.89999999999964
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7062.35700000002,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.299,
      "layouts": 20,
      "layoutDurationMs": 28.885999999999996,
      "taskDurationMs": 6969.467,
      "heapDeltaBytes": 993696,
      "heapUsedBytes": 214073920,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 128.34200000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 25,
      "frameDurationMs": 43.41358024691358,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7026.562000000013,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.575,
      "layouts": 20,
      "layoutDurationMs": 29.808,
      "taskDurationMs": 6960.165999999999,
      "heapDeltaBytes": 777052,
      "heapUsedBytes": 213707168,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 124.725,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 44.51329113924051,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9778.390000000058,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9558.079,
      "heapDeltaBytes": -21834692,
      "heapUsedBytes": 184146992,
      "domNodes": -3045,
      "jsHeapTotalBytes": 11206656,
      "scriptDurationMs": 167.20100000000005,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 35.38478260869565,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9672.294999999962,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9447.202000000001,
      "heapDeltaBytes": -31016860,
      "heapUsedBytes": 180553560,
      "domNodes": -3045,
      "jsHeapTotalBytes": 6225920,
      "scriptDurationMs": 169.832,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 34.39928825622776,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "workflow-execution",
      "durationMs": 469.32399999991503,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 19.407999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.9470000000000002,
      "taskDurationMs": 129.41199999999998,
      "heapDeltaBytes": 5738852,
      "heapUsedBytes": 70541996,
      "domNodes": 104,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.76,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667857142857137,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 471.24699999994846,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 14.243,
      "layouts": 3,
      "layoutDurationMs": 1.0039999999999998,
      "taskDurationMs": 107.32600000000001,
      "heapDeltaBytes": 5524240,
      "heapUsedBytes": 71056960,
      "domNodes": 99,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.247000000000007,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667857142857137,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1088.3620000000747,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 122.295,
      "layouts": 76,
      "layoutDurationMs": 31.322000000000003,
      "taskDurationMs": 1064.0130000000001,
      "heapDeltaBytes": 19683884,
      "heapUsedBytes": 85985836,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 425.965,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664615384615395,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1193.7169999999924,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 125.37599999999999,
      "layouts": 76,
      "layoutDurationMs": 33.539,
      "taskDurationMs": 1178.967,
      "heapDeltaBytes": 20864360,
      "heapUsedBytes": 89210344,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 484.114,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.90000000000001,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1517.0750000000908,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 292.243,
      "layouts": 76,
      "layoutDurationMs": 32.641000000000005,
      "taskDurationMs": 1489.6419999999998,
      "heapDeltaBytes": 8498936,
      "heapUsedBytes": 113817396,
      "domNodes": 76,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 473.72299999999996,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.958749999999988,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1540.4570000000604,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 310.87,
      "layouts": 76,
      "layoutDurationMs": 33.29,
      "taskDurationMs": 1514.276,
      "heapDeltaBytes": 8517360,
      "heapUsedBytes": 115331112,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 488.942,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.373749999999994,
      "p95FrameDurationMs": 33.30000000000109
    }
  ]
}

🎭 Playwright: ✅ 2205 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2183 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/16/2026, 01:02:09 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since a0531c7e44209e133b6b967ddd586565970091ae

Full docs: ADR-DEVEX-LINT-0015

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 16, 2026
@github-actions
github-actions Bot requested a review from thedatalife October 16, 2026 02:03
@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.56   #21150   +/-   ##
=============================================
  Coverage              ?   85.91%           
=============================================
  Files                 ?     2502           
  Lines                 ?   142734           
  Branches              ?    36601           
=============================================
  Hits                  ?   122634           
  Misses                ?    19714           
  Partials              ?      386           
Flag Coverage Δ
unit 83.08% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/auth/session/webSessionFetch.ts 92.45% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

1.56's network setup assigns a plain fetch, so vi.mocked(fetch) has no mockResolvedValue.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport of #21145. Same 1.56 fetch-stub fix as #21149. Auto-merge once the new checks are green.

@comfy-pr-bot
comfy-pr-bot merged commit 07ca10e into cloud/1.56 Oct 16, 2026
128 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-21145-to-cloud-1.56 branch October 16, 2026 13:22

This branch was previously deployed

1 inactive deployment
website-approval — 8ad32bab Deployed Oct 16, 2026 by dante01yoon via fast-lane #5565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants