Repository navigation
[backport cloud/1.56] fix(agent): mint a promoted host write so prompt-node edits aren't rejected (#20377) - #21082
Conversation
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-15T04:36:43.063Z",
"gitSha": "ab97427ab886c029f038bc34f5d54fdc081cef8d",
"branch": "kishore/backport-20377-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.2840000000033,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.3,
"heapDeltaBytes": 1072308,
"heapUsedBytes": 68230904,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.953999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.2779999999711,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.7040000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.329,
"heapDeltaBytes": 1010440,
"heapUsedBytes": 69317296,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.081000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1706.1029999999846,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.713999999999999,
"layouts": 12,
"layoutDurationMs": 3.6419999999999995,
"taskDurationMs": 701.305,
"heapDeltaBytes": -2328312,
"heapUsedBytes": 65453824,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 129.462,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1721.4109999999891,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.840000000000003,
"layouts": 12,
"layoutDurationMs": 4.394,
"taskDurationMs": 687.888,
"heapDeltaBytes": -2139428,
"heapUsedBytes": 66105260,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 129.629,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.0099999999875,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.690999999999999,
"layouts": 6,
"layoutDurationMs": 1.1009999999999998,
"taskDurationMs": 268.82099999999997,
"heapDeltaBytes": -362340,
"heapUsedBytes": 59810448,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.3310000000492,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.974999999999998,
"layouts": 6,
"layoutDurationMs": 1.0799999999999998,
"taskDurationMs": 267.37699999999995,
"heapDeltaBytes": 216032,
"heapUsedBytes": 62196680,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.751,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 576.3719999999921,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2750000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.21299999999997,
"heapDeltaBytes": -6726492,
"heapUsedBytes": 61090072,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 134.683,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66764705882355,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 561.898000000042,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.38,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.258,
"heapDeltaBytes": -6752728,
"heapUsedBytes": 60835152,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.656,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1055.2089999999907,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 722.2090000000001,
"heapDeltaBytes": 16413888,
"heapUsedBytes": 85699548,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 52.397,
"eventListeners": 0,
"totalBlockingTimeMs": 427,
"frameDurationMs": 31.818181818181817,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 999.3009999999458,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.241,
"heapDeltaBytes": 16101148,
"heapUsedBytes": 84238680,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 48.57300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 366,
"frameDurationMs": 29.40882352941178,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 783.0860000000257,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.8800000000002,
"heapDeltaBytes": 18289440,
"heapUsedBytes": 100412656,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 125.077,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 800.6500000000187,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.20799999999974,
"heapDeltaBytes": 17764344,
"heapUsedBytes": 99169256,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 119.893,
"eventListeners": 0,
"totalBlockingTimeMs": 163,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7659.904999999981,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0159999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6675.803,
"heapDeltaBytes": -16704196,
"heapUsedBytes": 67511824,
"domNodes": -142,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 5342.9929999999995,
"eventListeners": -78,
"totalBlockingTimeMs": 80,
"frameDurationMs": 25.08098360655738,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6749.448000000029,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9370000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6131.151,
"heapDeltaBytes": -9977304,
"heapUsedBytes": 74506420,
"domNodes": -143,
"jsHeapTotalBytes": -3018752,
"scriptDurationMs": 4931.725,
"eventListeners": -82,
"totalBlockingTimeMs": 23,
"frameDurationMs": 25.279775280898875,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6890.67700000004,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0819999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6207.521,
"heapDeltaBytes": -9812348,
"heapUsedBytes": 68239548,
"domNodes": -143,
"jsHeapTotalBytes": -6950912,
"scriptDurationMs": 4959.7699999999995,
"eventListeners": -82,
"totalBlockingTimeMs": 85,
"frameDurationMs": 25.029090909090908,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6503.214000000071,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.978999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5947.854,
"heapDeltaBytes": 1671576,
"heapUsedBytes": 86536148,
"domNodes": -172,
"jsHeapTotalBytes": -3805184,
"scriptDurationMs": 4805.799999999999,
"eventListeners": -86,
"totalBlockingTimeMs": 30,
"frameDurationMs": 24.999230769230767,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2009.4910000000255,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7409999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.4029999999999,
"heapDeltaBytes": -10188620,
"heapUsedBytes": 77748024,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.117,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.5989999999802,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1559999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.409,
"heapDeltaBytes": -10117660,
"heapUsedBytes": 77263524,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.06600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2137.1560000000045,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.052000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1224.8890000000001,
"heapDeltaBytes": -19906364,
"heapUsedBytes": 68620720,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 640.9970000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2114.7589999999354,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.516000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1181.241,
"heapDeltaBytes": -19934476,
"heapUsedBytes": 68662020,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 621.3649999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3242.1150000000125,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.92,
"layouts": 60,
"layoutDurationMs": 13.369000000000002,
"taskDurationMs": 1399.4529999999997,
"heapDeltaBytes": -19957332,
"heapUsedBytes": 70108676,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 669.65,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665979381443297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3191.8550000000323,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.345999999999998,
"layouts": 60,
"layoutDurationMs": 13.354,
"taskDurationMs": 1301.782,
"heapDeltaBytes": 3879644,
"heapUsedBytes": 83689632,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 620.981,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665968586387432,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2207.898,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.010000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1493.709,
"heapDeltaBytes": 5523604,
"heapUsedBytes": 73889160,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 778.8689999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793129770992362,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2333.721999999966,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.2250000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1526.3050000000003,
"heapDeltaBytes": -13755956,
"heapUsedBytes": 68850752,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 803.862,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.030656934306567,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2012.1020000000271,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.777,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.74300000000005,
"heapDeltaBytes": -10656980,
"heapUsedBytes": 78155864,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 31.450000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.5139999999583,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.122,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.19899999999996,
"heapDeltaBytes": -12319408,
"heapUsedBytes": 68256224,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.641000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 511.4409999999907,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.295999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.39500000000004,
"heapDeltaBytes": -11854928,
"heapUsedBytes": 57592004,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 120.126,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 499.3859999999586,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.768000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.746,
"heapDeltaBytes": 10064616,
"heapUsedBytes": 72159788,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.127,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.8549999999923,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.7010000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.09299999999996,
"heapDeltaBytes": 1200408,
"heapUsedBytes": 71012136,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.389000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.1330000000435,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0889999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.792,
"heapDeltaBytes": 1151312,
"heapUsedBytes": 71335580,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.607000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.0099999999957,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.889000000000001,
"layouts": 16,
"layoutDurationMs": 4.718,
"taskDurationMs": 656.6759999999999,
"heapDeltaBytes": 17372540,
"heapUsedBytes": 81426076,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 94.46000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.0880000000025,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.380000000000003,
"layouts": 16,
"layoutDurationMs": 4.228,
"taskDurationMs": 586.561,
"heapDeltaBytes": -5806144,
"heapUsedBytes": 64980356,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 85.545,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 884.2599999999265,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.083000000000006,
"layouts": 5,
"layoutDurationMs": 10.73,
"taskDurationMs": 686.761,
"heapDeltaBytes": -648196,
"heapUsedBytes": 93352764,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 21.194,
"eventListeners": 2463,
"totalBlockingTimeMs": 89,
"frameDurationMs": 19.62888888888889,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8144.781999999964,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.195,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4366.986,
"heapDeltaBytes": 7961664,
"heapUsedBytes": 95974752,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 2188.9190000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666053169734152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8143.592000000012,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4211.657999999999,
"heapDeltaBytes": -18147260,
"heapUsedBytes": 69595328,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2146.33,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666188524590165,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14695.88299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14214.911,
"heapDeltaBytes": -33633988,
"heapUsedBytes": 179087748,
"domNodes": -3045,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 244.326,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.242685025817558,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14963.131000000089,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14443.451000000001,
"heapDeltaBytes": -26996084,
"heapUsedBytes": 178973464,
"domNodes": -3045,
"jsHeapTotalBytes": 4149248,
"scriptDurationMs": 260.57399999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.412544169611305,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17311.236000000008,
"styleRecalcs": 134,
"styleRecalcDurationMs": 14.840999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16929.356000000003,
"heapDeltaBytes": -32945140,
"heapUsedBytes": 183807248,
"domNodes": -3045,
"jsHeapTotalBytes": 5906432,
"scriptDurationMs": 698.289,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.49360465116279,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17739.738999999987,
"styleRecalcs": 141,
"styleRecalcDurationMs": 16.13300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17387.177,
"heapDeltaBytes": -67583924,
"heapUsedBytes": 166513092,
"domNodes": -3045,
"jsHeapTotalBytes": 4673536,
"scriptDurationMs": 712.381,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 33.05270018621974,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5238.200000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.10199999999999,
"layouts": 20,
"layoutDurationMs": 22.136000000000003,
"taskDurationMs": 5187.45,
"heapDeltaBytes": 820840,
"heapUsedBytes": 217285624,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 82.871,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.706875000000004,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 5511.071000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.111000000000026,
"layouts": 20,
"layoutDurationMs": 21.60999999999999,
"taskDurationMs": 5380.487999999999,
"heapDeltaBytes": 1037556,
"heapUsedBytes": 213957932,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 87.54,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.05185185185185,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7642.381,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7296.1539999999995,
"heapDeltaBytes": -29094500,
"heapUsedBytes": 185715764,
"domNodes": -3045,
"jsHeapTotalBytes": 13012992,
"scriptDurationMs": 108.06299999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.051535836177468,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7840.628000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7496.9209999999985,
"heapDeltaBytes": -26599200,
"heapUsedBytes": 180300484,
"domNodes": -3045,
"jsHeapTotalBytes": 5177344,
"scriptDurationMs": 107.89999999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.10346020761245,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 457.55099999996673,
"styleRecalcs": 22,
"styleRecalcDurationMs": 18.055000000000003,
"layouts": 5,
"layoutDurationMs": 2.1260000000000003,
"taskDurationMs": 115.183,
"heapDeltaBytes": 6025880,
"heapUsedBytes": 71421584,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.930999999999997,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 455.8349999999791,
"styleRecalcs": 17,
"styleRecalcDurationMs": 14.911000000000003,
"layouts": 3,
"layoutDurationMs": 1.254,
"taskDurationMs": 102.67200000000001,
"heapDeltaBytes": 5792440,
"heapUsedBytes": 71001412,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.017000000000003,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660714285714285,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 525.9439999999813,
"styleRecalcs": 78,
"styleRecalcDurationMs": 76.794,
"layouts": 76,
"layoutDurationMs": 19.220000000000002,
"taskDurationMs": 495.89,
"heapDeltaBytes": -10516992,
"heapUsedBytes": 77431572,
"domNodes": 76,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 180.847,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000017,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 521.0650000000214,
"styleRecalcs": 78,
"styleRecalcDurationMs": 77.642,
"layouts": 76,
"layoutDurationMs": 19.074,
"taskDurationMs": 488.37800000000004,
"heapDeltaBytes": -17812144,
"heapUsedBytes": 66724656,
"domNodes": 76,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 181.572,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 936.5830000000415,
"styleRecalcs": 78,
"styleRecalcDurationMs": 207.404,
"layouts": 76,
"layoutDurationMs": 22.761,
"taskDurationMs": 912.3279999999999,
"heapDeltaBytes": 11204896,
"heapUsedBytes": 126005984,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 266.789,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66491228070175,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1155.9129999999413,
"styleRecalcs": 78,
"styleRecalcDurationMs": 243.368,
"layouts": 76,
"layoutDurationMs": 25.500999999999998,
"taskDurationMs": 1138.59,
"heapDeltaBytes": -20243144,
"heapUsedBytes": 107251000,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 361.673,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.149275362318843,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2203 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a026d54d10a6d584b526646f5b48320f12183e5e
Full docs: ADR-DEVEX-LINT-0015 |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.56 #21082 +/- ##
=============================================
Coverage ? 85.91%
=============================================
Files ? 2501
Lines ? 142620
Branches ? 36576
=============================================
Hits ? 122537
Misses ? 19697
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Faithful backport of #20377 to cloud/1.56, with one test hunk correctly dropped.
I compared this branch against the merged source commit a0261ac from #20377. All seven files in this PR carry exactly the source's added and removed lines: AgentPanelRoot.vue, agentSubgraphDefinitions.ts, docOpMinter.ts, docOpMinter.test.ts, linkMintOutboundPositionCorruption.test.ts, useAgentCrdtFollower.ts, and useAgentCrdtFollower.humanAddTabSwitch.test.ts. The source's tests come along unchanged.
The one adaptation is the dropped docPromotedWidgets: () => null line in liveGraphApplier.changeTracker.test.ts. On main, that line feeds the new required docPromotedWidgets dependency to an attachDocOpMinter call in the DynamicGroup change-tracker case. On cloud/1.56 that file has no such case and never calls attachDocOpMinter, so the line has nowhere to go. Every minter call site that does exist on the target (AgentPanelRoot.vue, useAgentCrdtFollower.ts, and the three test files) gets the new dependency through the carried hunks.
CI on this head passes lint, typecheck, the unit shards, and e2e. Locally, with the target's own dependencies installed, docOpMinter.test.ts, linkMintOutboundPositionCorruption.test.ts, useAgentCrdtFollower.humanAddTabSwitch.test.ts, liveGraphApplier.changeTracker.test.ts, and AgentPanelRoot.test.ts pass: 471 tests.
christian-byrne
left a comment
There was a problem hiding this comment.
Checked this as a backport-fidelity question, not a fresh review: diffed every carried-over file against the merged source (#20377) and the +/- lines are identical except for one file this base is too old to have (liveGraphApplier.changeTracker.test.ts — the DynamicGroup change-tracker test that attachDocOpMinter call doesn't exist on cloud/1.56, confirmed by fetching that file at the base commit). No product code differs from the source PR.
CI is settled green except create-tag (Cloud Backport Tag workflow), which failed on a GitHub API rate limit (403) while verifying the commit belongs to cloud/1.56 — an infra flake unrelated to this diff, not a required check.
Approving as a faithful backport of already-reviewed work.
…#21096) Fixes typecheck on `cloud/1.56`. #21082 (backport of #20377) made `docPromotedWidgets` a required `DocOpMinterDeps` field, and #21038 (backport of #20181) added a test that builds the minter without it. Each passed CI on its own; together they break `pnpm typecheck` on the branch. This adds `docPromotedWidgets: () => null` to that test, same as on `main`. Tested: `pnpm typecheck`, `vitest run liveGraphApplier.changeTracker.test.ts`.
Summary
Backports #20377 to
cloud/1.56, the line production runs, so users' edits to promoted subgraph widgets are kept instead of rejected.cloud/1.56was cut on Oct 5, before #20377 merged on Oct 7. #20377 was backported tocloud/1.54,cloud/1.55,core/1.54andcore/1.55, but not to 1.56, andcloud/1.57already contains it. Shipping 1.56 brought the bug back.Since Oct 11, Datadog RUM shows 1,899
agent_crdt_human_ops_rejectederrors from 124 users, growing from 19 to 39 sessions a day. 88% of them are the PM-1995 rejection: "widget write 'prompt' on node … (<definition uuid>) is absent from the pinned catalog, so its widgets_values is stored opaquely … not name-addressable". Every one comes from a 1.56.3 build (d27dab04,6d339786,6e4716b1,0aa88cc3). Users see the "Widget edit was rejected and was not saved" banner, and are asking the agent how to change their prompt.Changes
docPromotedWidgetsstub inside the DynamicGroup change-tracker case, becausecloud/1.56doesn't have that test. No product code was removed.Verification
docOpMinter.test.tsoncloud/1.56and without the fix, 18 PM-1995 cases fail, including "PM-1995: mints a promoted host write the doc host accepts".vitest run src/workbench/extensions/agentpasses 145 files and 2870 tests.pnpm typecheckandoxlintare clean, and the pre-commit hooks pass.@context.error_type:agent_crdt_human_ops_rejected @error.message:*pinned\ catalog*should drop toward zero on the new 1.56 build.Source: #20377