Repository navigation
[backport cloud/1.57] fix: remove orphaned promoted inputs when a DynamicGroup row is deleted - #21081
Conversation
…ed (#21050) ## Summary Deleting a DynamicGroup row whose field is promoted through nested subgraphs left an unconnected input for the deleted row on every enclosing host. Reported in 1.57 QA: https://comfy-organization.slack.com/archives/C0932CGKT5K/p1792020581765129 `disconnectOrphanedPromotion` (#20181, #20708) disconnected each host input once the inner subgraph input had no remaining links, but never removed that subgraph input. Hosts mirror subgraph inputs, so the socket stayed. It now removes the orphaned subgraph input after disconnecting the hosts, at each level it walks. ## Review focus - The input is removed even when an outer node is connected to the host input; the row it fed no longer exists. An input that still has another consumer inside the subgraph is kept, as before. - Two existing tests asserted the old disconnect-only behavior and now assert the inputs are gone. ## Tests - New: `removes the deleted row inputs from both hosts while keeping the next row`, which follows the QA repro (three rows, rows 2 and 3 promoted through two boundaries, delete row 2). - `dynamicGroupWidget.test.ts`: 3 failed / 42 passed on main, 45 passed with the fix. - `src/core`, `src/lib/litegraph/src/subgraph`, `src/workbench/extensions/agent`, `src/renderer/extensions/vueNodes`: 5,316 passed. One timing test in `useAgentSession.test.ts` failed once under load and passed on two isolated reruns.
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-15T03:56:55.623Z",
"gitSha": "261acd198c92ee6617adb052060276d5224821a6",
"branch": "backport-21050-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.1049999999532,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4040000000000004,
"layouts": 10,
"layoutDurationMs": 2.543,
"taskDurationMs": 493.05400000000003,
"heapDeltaBytes": -921072,
"heapUsedBytes": 74458984,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.011000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.2919999999594,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3480000000000003,
"layouts": 10,
"layoutDurationMs": 2.6169999999999995,
"taskDurationMs": 337.007,
"heapDeltaBytes": 21592520,
"heapUsedBytes": 87951516,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 8.616000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.318999999905,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.187999999999999,
"layouts": 9,
"layoutDurationMs": 2.5639999999999996,
"taskDurationMs": 814.152,
"heapDeltaBytes": 15634408,
"heapUsedBytes": 81420436,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 150.549,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1973.4879999999748,
"styleRecalcs": 84,
"styleRecalcDurationMs": 14.842,
"layouts": 9,
"layoutDurationMs": 2.1990000000000003,
"taskDurationMs": 1020.191,
"heapDeltaBytes": 15201744,
"heapUsedBytes": 81007040,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 158.388,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.7699999999868,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.729000000000001,
"layouts": 11,
"layoutDurationMs": 2.349,
"taskDurationMs": 265.714,
"heapDeltaBytes": 18709988,
"heapUsedBytes": 84548708,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.723000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1808.2600000000184,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.282,
"layouts": 12,
"layoutDurationMs": 2.723,
"taskDurationMs": 445.11699999999996,
"heapDeltaBytes": -4534484,
"heapUsedBytes": 70077536,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.927999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064217,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 642.4820000000864,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.329,
"layouts": 8,
"layoutDurationMs": 2.4740000000000006,
"taskDurationMs": 477.116,
"heapDeltaBytes": 25699228,
"heapUsedBytes": 91372372,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 167.36599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.118918918918922,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 680.6910000000244,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.461,
"layouts": 10,
"layoutDurationMs": 2.512,
"taskDurationMs": 501.0520000000001,
"heapDeltaBytes": 25659820,
"heapUsedBytes": 91911704,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 182.90300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307678,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1179.363999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 873.993,
"heapDeltaBytes": -11044980,
"heapUsedBytes": 81560488,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 65.663,
"eventListeners": -106,
"totalBlockingTimeMs": 506,
"frameDurationMs": 31.981081081081086,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1148.2070000000704,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 848.8449999999999,
"heapDeltaBytes": 1237836,
"heapUsedBytes": 81049580,
"domNodes": -192,
"jsHeapTotalBytes": 13115392,
"scriptDurationMs": 65.77100000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 484,
"frameDurationMs": 31.941666666666656,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.6930000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.71899999999965,
"heapDeltaBytes": -5253000,
"heapUsedBytes": 76077332,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 150.893,
"eventListeners": 0,
"totalBlockingTimeMs": 209,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.0709999999808,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.99699999999984,
"heapDeltaBytes": -6375288,
"heapUsedBytes": 74400532,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 155.83,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25.0029411764706,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10225.007000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9373.409,
"heapDeltaBytes": -25465168,
"heapUsedBytes": 70677896,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 7613.823,
"eventListeners": -68,
"totalBlockingTimeMs": 741,
"frameDurationMs": 32.33006329113924,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9428.44100000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8585.528,
"heapDeltaBytes": -3308240,
"heapUsedBytes": 96399164,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 6945.070000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 535,
"frameDurationMs": 31.548160535117056,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8571.497000000021,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.35399999999999926,
"layouts": 1,
"layoutDurationMs": 0.33500000000000024,
"taskDurationMs": 7850.476,
"heapDeltaBytes": -6652660,
"heapUsedBytes": 92053416,
"domNodes": -258,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 6607.697,
"eventListeners": -68,
"totalBlockingTimeMs": 614,
"frameDurationMs": 32.821072796934864,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9317.753999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8533.534,
"heapDeltaBytes": -16421064,
"heapUsedBytes": 82879792,
"domNodes": -258,
"jsHeapTotalBytes": 6942720,
"scriptDurationMs": 7215.504,
"eventListeners": -68,
"totalBlockingTimeMs": 808,
"frameDurationMs": 32.34826388888889,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 229.67799999992167,
"styleRecalcs": 25,
"styleRecalcDurationMs": 13.919,
"layouts": 12,
"layoutDurationMs": 3.236,
"taskDurationMs": 170.15800000000002,
"heapDeltaBytes": -8176644,
"heapUsedBytes": 79022736,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.411999999999997,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 226.46700000007058,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.694999999999999,
"layouts": 11,
"layoutDurationMs": 3.044,
"taskDurationMs": 160.17800000000003,
"heapDeltaBytes": -8363164,
"heapUsedBytes": 79651644,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.163,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2039.0979999999672,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1609999999999996,
"layouts": 8,
"layoutDurationMs": 2.2660000000000005,
"taskDurationMs": 447.082,
"heapDeltaBytes": -2246516,
"heapUsedBytes": 76552828,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 30.201000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.3240000000078,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.13,
"layouts": 8,
"layoutDurationMs": 2.265,
"taskDurationMs": 450.75399999999996,
"heapDeltaBytes": -2409988,
"heapUsedBytes": 76463904,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 29.038999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2384.561000000076,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.5680000000000005,
"layouts": 7,
"layoutDurationMs": 1.6949999999999998,
"taskDurationMs": 1612.7520000000002,
"heapDeltaBytes": 517332,
"heapUsedBytes": 77388948,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 784.101,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665734265734265,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2220.0239999999667,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.323,
"layouts": 6,
"layoutDurationMs": 1.6860000000000002,
"taskDurationMs": 1415.9119999999998,
"heapDeltaBytes": -9701996,
"heapUsedBytes": 70316168,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 789.4830000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79236641221374,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3449.1160000000036,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.462,
"layouts": 63,
"layoutDurationMs": 9.924999999999999,
"taskDurationMs": 1455.9869999999999,
"heapDeltaBytes": 1661208,
"heapUsedBytes": 83128120,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 746.794,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665700483091783,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3537.4369999999544,
"styleRecalcs": 72,
"styleRecalcDurationMs": 6.850999999999999,
"layouts": 65,
"layoutDurationMs": 10.096,
"taskDurationMs": 1535.246,
"heapDeltaBytes": 11437188,
"heapUsedBytes": 93114676,
"domNodes": -234,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 770.166,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74549763033175,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2609.4810000000734,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.397,
"layouts": 5,
"layoutDurationMs": 1.3950000000000005,
"taskDurationMs": 1677.217,
"heapDeltaBytes": 13750364,
"heapUsedBytes": 96540920,
"domNodes": 0,
"jsHeapTotalBytes": 7495680,
"scriptDurationMs": 909.2900000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.881818181818183,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2818.6050000000478,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.497999999999999,
"layouts": 5,
"layoutDurationMs": 1.3,
"taskDurationMs": 1870.8999999999999,
"heapDeltaBytes": 10461840,
"heapUsedBytes": 94462384,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 939.587,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86586826347305,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2053.213000000028,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0540000000000003,
"layouts": 8,
"layoutDurationMs": 2.249,
"taskDurationMs": 426.466,
"heapDeltaBytes": -2090672,
"heapUsedBytes": 78333144,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 27.544000000000008,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2008.9809999999488,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6830000000000005,
"layouts": 7,
"layoutDurationMs": 1.7000000000000002,
"taskDurationMs": 602.616,
"heapDeltaBytes": -2209944,
"heapUsedBytes": 78898476,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 28.36500000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.7350000000724,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.757999999999999,
"layouts": 10,
"layoutDurationMs": 2.8489999999999998,
"taskDurationMs": 460.504,
"heapDeltaBytes": -1093424,
"heapUsedBytes": 75876696,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 147.563,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631583,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.0930000000462,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.114999999999999,
"layouts": 9,
"layoutDurationMs": 2.2009999999999996,
"taskDurationMs": 363.807,
"heapDeltaBytes": 21618596,
"heapUsedBytes": 88988412,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 142.616,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.187500000000014,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.1069999999718,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.184,
"layouts": 10,
"layoutDurationMs": 2.374,
"taskDurationMs": 483.0799999999999,
"heapDeltaBytes": 22387440,
"heapUsedBytes": 89226952,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.337999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2022.1520000000055,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0680000000000005,
"layouts": 9,
"layoutDurationMs": 2.129,
"taskDurationMs": 475.993,
"heapDeltaBytes": 22406756,
"heapUsedBytes": 89780912,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.008999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.0920000000178,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.315000000000001,
"layouts": 10,
"layoutDurationMs": 2.3890000000000007,
"taskDurationMs": 807.136,
"heapDeltaBytes": -371812,
"heapUsedBytes": 66285480,
"domNodes": -172,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 101.073,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.9759999999442,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.656000000000002,
"layouts": 9,
"layoutDurationMs": 2.2700000000000005,
"taskDurationMs": 616.4879999999999,
"heapDeltaBytes": 11715680,
"heapUsedBytes": 78589372,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 100.633,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.5110000000195,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.617999999999995,
"layouts": 5,
"layoutDurationMs": 15.591000000000001,
"taskDurationMs": 995.1290000000001,
"heapDeltaBytes": 7724212,
"heapUsedBytes": 106133588,
"domNodes": 15953,
"jsHeapTotalBytes": 18751488,
"scriptDurationMs": 26.325000000000003,
"eventListeners": 3244,
"totalBlockingTimeMs": 153,
"frameDurationMs": 19.59324324324325,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8799.63399999997,
"styleRecalcs": 249,
"styleRecalcDurationMs": 16.527,
"layouts": 7,
"layoutDurationMs": 1.9149999999999996,
"taskDurationMs": 5614.554,
"heapDeltaBytes": 5442104,
"heapUsedBytes": 84209644,
"domNodes": -258,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2549.925,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69753320683112,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8684.818999999949,
"styleRecalcs": 250,
"styleRecalcDurationMs": 16.316999999999997,
"layouts": 7,
"layoutDurationMs": 1.723,
"taskDurationMs": 5623.405,
"heapDeltaBytes": 15219332,
"heapUsedBytes": 94154980,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 2586.6310000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.762862669245646,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14972.441000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14097.878999999999,
"heapDeltaBytes": -27431576,
"heapUsedBytes": 267824868,
"domNodes": -3330,
"jsHeapTotalBytes": 22532096,
"scriptDurationMs": 216.19299999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.366271186440677,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 15010.235999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14344.810000000003,
"heapDeltaBytes": -29477496,
"heapUsedBytes": 266835956,
"domNodes": -3330,
"jsHeapTotalBytes": 23056384,
"scriptDurationMs": 250.803,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.537414965986393,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 27596.302000000036,
"styleRecalcs": 181,
"styleRecalcDurationMs": 14.238000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27110.420000000006,
"heapDeltaBytes": 727192,
"heapUsedBytes": 276934076,
"domNodes": -3330,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 849.497,
"eventListeners": -651,
"totalBlockingTimeMs": 20,
"frameDurationMs": 50.64036697247706,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 19189.828000000034,
"styleRecalcs": 179,
"styleRecalcDurationMs": 13.09200000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18772.683,
"heapDeltaBytes": -27033024,
"heapUsedBytes": 268365416,
"domNodes": -3330,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 818.3480000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 21,
"frameDurationMs": 33.56520979020979,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5669.4689999999355,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.31099999999998,
"layouts": 20,
"layoutDurationMs": 21.451999999999998,
"taskDurationMs": 5512.913,
"heapDeltaBytes": -9683384,
"heapUsedBytes": 291553976,
"domNodes": -3330,
"jsHeapTotalBytes": 28037120,
"scriptDurationMs": 90.213,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.398342541436467,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 7875.897000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.005,
"layouts": 20,
"layoutDurationMs": 26.882000000000016,
"taskDurationMs": 7730.3060000000005,
"heapDeltaBytes": 3211364,
"heapUsedBytes": 279099568,
"domNodes": -3330,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 111.04299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.794444444444444,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7421.3490000000775,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7029.382000000001,
"heapDeltaBytes": -8575528,
"heapUsedBytes": 261657864,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 102.63500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.803678929765884,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10970.778999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10589.178,
"heapDeltaBytes": 8936480,
"heapUsedBytes": 279749840,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.156,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.047972972972964,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 126.36800000007042,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.145000000000001,
"layouts": 8,
"layoutDurationMs": 4.247,
"taskDurationMs": 106.288,
"heapDeltaBytes": -15300216,
"heapUsedBytes": 68018564,
"domNodes": 124,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 14.832,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 114.64599999999336,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.803999999999998,
"layouts": 7,
"layoutDurationMs": 3.436,
"taskDurationMs": 82.53399999999999,
"heapDeltaBytes": 4452900,
"heapUsedBytes": 76968372,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.0169999999999995,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 522.2769999998036,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.949,
"layouts": 76,
"layoutDurationMs": 14.253,
"taskDurationMs": 459.809,
"heapDeltaBytes": -18185684,
"heapUsedBytes": 69756152,
"domNodes": 4,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 226.834,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483896,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 475.1329999999143,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.057,
"layouts": 76,
"layoutDurationMs": 13.581,
"taskDurationMs": 419.95300000000003,
"heapDeltaBytes": 11474372,
"heapUsedBytes": 100767928,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 211.665,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 464.3750000000182,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.686,
"layouts": 76,
"layoutDurationMs": 12.935,
"taskDurationMs": 424.748,
"heapDeltaBytes": -465524,
"heapUsedBytes": 121350744,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 171.103,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 541.1639999999807,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.875,
"layouts": 76,
"layoutDurationMs": 14.465,
"taskDurationMs": 512.461,
"heapDeltaBytes": 11010464,
"heapUsedBytes": 161339460,
"domNodes": 4,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 207.747,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.1875,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
🎭 Playwright: ❌ 2278 passed, 1 failed❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 29272f6d50731d781245f9102ba4d1b5c347eedf
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21081 +/- ##
=============================================
Coverage ? 87.18%
=============================================
Files ? 2624
Lines ? 147489
Branches ? 38380
=============================================
Hits ? 128595
Misses ? 18504
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
🔗 Commit SHA: 5433ba9 | Docs | View more details | Give us feedback! |
Backport of #21050 to
cloud/1.57Automatically created by backport workflow.