Repository navigation
fix: mint shifted DynamicGroup row values after a middle-row removal - #21057
Conversation
📦 Bundle: 9.47 MB gzip 🔴 +112 BDetailsSummary
Category Glance App Entry Points — 5.25 kB (baseline 5.25 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.45 MB (baseline 2.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 670 kB (baseline 670 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 18 unchanged User & Accounts — 293 kB (baseline 293 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 10 added / 10 removed / 8 unchanged Editors & Dialogs — 345 kB (baseline 345 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed / 4 unchanged UI Components — 212 kB (baseline 212 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 17 unchanged Data & Services — 2.19 MB (baseline 2.19 MB) • 🔴 +285 BStores, services, APIs, and repositories
Status: 21 added / 21 removed / 4 unchanged Utilities & Hooks — 984 kB (baseline 984 kB) • 🟢 -17 BHelpers, composables, and utility bundles
Status: 37 added / 37 removed / 31 unchanged Vendor & Third-Party — 13.9 MB (baseline 13.9 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 19.5 MB (baseline 19.5 MB) • 🟢 -161 BBundles that do not match a named category
Status: 98 added / 98 removed / 254 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-15T03:21:21.577Z",
"gitSha": "980cf159c784ff77d5d2c9191eda44f123832ca8",
"branch": "jaeone94/dynamic-group-mint-shifted-rows",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.315999999989,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.773,
"layouts": 10,
"layoutDurationMs": 2.531,
"taskDurationMs": 330.675,
"heapDeltaBytes": 1057408,
"heapUsedBytes": 79356308,
"domNodes": -162,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.291,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2011.6280000000302,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.3240000000000003,
"layouts": 10,
"layoutDurationMs": 2.088,
"taskDurationMs": 335.344,
"heapDeltaBytes": 2197388,
"heapUsedBytes": 80538608,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.063,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.063000000004,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.310999999999998,
"layouts": 11,
"layoutDurationMs": 2.5919999999999996,
"taskDurationMs": 553.0459999999999,
"heapDeltaBytes": 1762012,
"heapUsedBytes": 79553308,
"domNodes": -162,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 98.67200000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.669000000004,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.075,
"layouts": 10,
"layoutDurationMs": 2.4739999999999998,
"taskDurationMs": 543.6659999999999,
"heapDeltaBytes": 623188,
"heapUsedBytes": 78959900,
"domNodes": -162,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 97.19200000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.4119999999862,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.114,
"layouts": 12,
"layoutDurationMs": 2.421,
"taskDurationMs": 230.59700000000004,
"heapDeltaBytes": -2557860,
"heapUsedBytes": 75700120,
"domNodes": 47,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8.365,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.9199999999873,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.6049999999999995,
"layouts": 13,
"layoutDurationMs": 2.871,
"taskDurationMs": 243.63899999999998,
"heapDeltaBytes": -2452292,
"heapUsedBytes": 75408736,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.2,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 516.2119999999959,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8679999999999994,
"layouts": 10,
"layoutDurationMs": 2.6479999999999997,
"taskDurationMs": 360.311,
"heapDeltaBytes": 5512356,
"heapUsedBytes": 83773780,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 108.301,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 399.7009999999932,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9209999999999994,
"layouts": 10,
"layoutDurationMs": 2.437,
"taskDurationMs": 272.922,
"heapDeltaBytes": 5836420,
"heapUsedBytes": 84245912,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 102.711,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67083333333333,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 877.6909999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.39500000000004,
"heapDeltaBytes": 16375988,
"heapUsedBytes": 96003100,
"domNodes": 0,
"jsHeapTotalBytes": 16678912,
"scriptDurationMs": 39.06,
"eventListeners": 0,
"totalBlockingTimeMs": 276,
"frameDurationMs": 26.76666666666666,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 879.2100000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.97999999999996,
"heapDeltaBytes": 15007416,
"heapUsedBytes": 95018196,
"domNodes": 0,
"jsHeapTotalBytes": 15368192,
"scriptDurationMs": 39.127,
"eventListeners": 0,
"totalBlockingTimeMs": 270,
"frameDurationMs": 25.979411764705887,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 678.6419999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 261.80700000000013,
"heapDeltaBytes": -4507360,
"heapUsedBytes": 73466536,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 85.61100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 80,
"frameDurationMs": 20.097058823529416,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 688.8629999999694,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 252.02399999999957,
"heapDeltaBytes": -4485768,
"heapUsedBytes": 73056080,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 91.36899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6585.3390000000045,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6430000000000003,
"layouts": 2,
"layoutDurationMs": 0.4879999999999997,
"taskDurationMs": 5390.7210000000005,
"heapDeltaBytes": -556276,
"heapUsedBytes": 82407424,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 4105.718000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 20,
"frameDurationMs": 19.651044776119402,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6036.327999999969,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.556,
"layouts": 3,
"layoutDurationMs": 0.6639999999999997,
"taskDurationMs": 4991.418,
"heapDeltaBytes": -10984288,
"heapUsedBytes": 72953188,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 3879.254,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.337689969604863,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6386.898999999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2900000000000003,
"layouts": 1,
"layoutDurationMs": 0.29100000000000004,
"taskDurationMs": 5256.219,
"heapDeltaBytes": 6679128,
"heapUsedBytes": 90202792,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 4047.721,
"eventListeners": 0,
"totalBlockingTimeMs": 12,
"frameDurationMs": 19.833333333333336,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5943.754000000013,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8099999999999999,
"layouts": 3,
"layoutDurationMs": 0.7329999999999998,
"taskDurationMs": 4741.581,
"heapDeltaBytes": 748316,
"heapUsedBytes": 83688380,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 3795.0939999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.82848101265823,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 165.7549999999901,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.040999999999999,
"layouts": 8,
"layoutDurationMs": 2.114,
"taskDurationMs": 121.68599999999999,
"heapDeltaBytes": 13212256,
"heapUsedBytes": 77541460,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.509000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.73750000000001,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "large-combo-open",
"durationMs": 144.13899999999558,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.110999999999999,
"layouts": 10,
"layoutDurationMs": 2.3559999999999994,
"taskDurationMs": 103.761,
"heapDeltaBytes": 13197632,
"heapUsedBytes": 77729316,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.163,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2030.8139999999923,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2700000000000005,
"layouts": 8,
"layoutDurationMs": 1.95,
"taskDurationMs": 381.93300000000005,
"heapDeltaBytes": -27065208,
"heapUsedBytes": 70778428,
"domNodes": -258,
"jsHeapTotalBytes": -749568,
"scriptDurationMs": 29.254,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.5350000000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.686,
"layouts": 9,
"layoutDurationMs": 2.444,
"taskDurationMs": 387.342,
"heapDeltaBytes": -33317048,
"heapUsedBytes": 70299480,
"domNodes": -258,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 28.408,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2132.5589999999866,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.0809999999999995,
"layouts": 7,
"layoutDurationMs": 1.307,
"taskDurationMs": 969.8740000000001,
"heapDeltaBytes": 10954980,
"heapUsedBytes": 76261236,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 497.625,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2380.002999999988,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.226999999999999,
"layouts": 5,
"layoutDurationMs": 1.334,
"taskDurationMs": 1168.6399999999999,
"heapDeltaBytes": 10620596,
"heapUsedBytes": 76746588,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 578.502,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665734265734265,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3470.3020000000038,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.104,
"layouts": 64,
"layoutDurationMs": 11.495000000000001,
"taskDurationMs": 1216.216,
"heapDeltaBytes": 22084804,
"heapUsedBytes": 89137580,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 534.787,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.746376811594207,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3240.3489999999806,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.341000000000001,
"layouts": 65,
"layoutDurationMs": 11.746999999999998,
"taskDurationMs": 1125.1419999999998,
"heapDeltaBytes": 21701748,
"heapUsedBytes": 88957232,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 513.184,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665641025641026,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2488.968,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.8,
"layouts": 4,
"layoutDurationMs": 0.9069999999999998,
"taskDurationMs": 1288.5460000000003,
"heapDeltaBytes": 906388,
"heapUsedBytes": 67871324,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 645.113,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665999999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2352.4400000000014,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.916,
"layouts": 4,
"layoutDurationMs": 1.0270000000000001,
"taskDurationMs": 1255.628,
"heapDeltaBytes": 942608,
"heapUsedBytes": 68259440,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 639.3939999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.7889999999838,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5599999999999998,
"layouts": 5,
"layoutDurationMs": 1.2789999999999997,
"taskDurationMs": 349.441,
"heapDeltaBytes": 6785928,
"heapUsedBytes": 72262480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.281000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2021.2530000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8609999999999998,
"layouts": 8,
"layoutDurationMs": 1.783,
"taskDurationMs": 343.98099999999994,
"heapDeltaBytes": -29353252,
"heapUsedBytes": 71563864,
"domNodes": -258,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 25.779999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 461.371999999983,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.7410000000000005,
"layouts": 11,
"layoutDurationMs": 2.7960000000000007,
"taskDurationMs": 308.658,
"heapDeltaBytes": 90644,
"heapUsedBytes": 80452304,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 100.472,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 414.5340000000033,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.57,
"layouts": 11,
"layoutDurationMs": 2.8019999999999996,
"taskDurationMs": 271.891,
"heapDeltaBytes": 1000780,
"heapUsedBytes": 80439504,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 92.867,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.6770000000106,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.698,
"layouts": 10,
"layoutDurationMs": 2.3750000000000004,
"taskDurationMs": 309.38100000000003,
"heapDeltaBytes": -23586220,
"heapUsedBytes": 56329540,
"domNodes": -180,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 6.096000000000001,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.525999999994,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.7410000000000005,
"layouts": 10,
"layoutDurationMs": 2.425,
"taskDurationMs": 361.55199999999996,
"heapDeltaBytes": -23180700,
"heapUsedBytes": 57178520,
"domNodes": -180,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8.67,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1993.9159999999845,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.093,
"layouts": 10,
"layoutDurationMs": 2.6169999999999995,
"taskDurationMs": 896.616,
"heapDeltaBytes": -1265720,
"heapUsedBytes": 79010132,
"domNodes": -180,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 96.83800000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665833333333335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.7989999999713,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.754999999999999,
"layouts": 10,
"layoutDurationMs": 2.645,
"taskDurationMs": 711.046,
"heapDeltaBytes": -2253684,
"heapUsedBytes": 78117072,
"domNodes": -180,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 100.122,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 801.7510000000243,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.311999999999998,
"layouts": 5,
"layoutDurationMs": 9.363,
"taskDurationMs": 505.11799999999994,
"heapDeltaBytes": 5166132,
"heapUsedBytes": 103325140,
"domNodes": 15950,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 18.000000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 70,
"frameDurationMs": 19.047619047619047,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8645.781999999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.256,
"layouts": 7,
"layoutDurationMs": 1.7969999999999995,
"taskDurationMs": 3998.7120000000004,
"heapDeltaBytes": 22414524,
"heapUsedBytes": 86278096,
"domNodes": -258,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 1892.9120000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665830115830115,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8647.545000000036,
"styleRecalcs": 248,
"styleRecalcDurationMs": 22.163999999999998,
"layouts": 7,
"layoutDurationMs": 1.5079999999999998,
"taskDurationMs": 3961.92,
"heapDeltaBytes": -7037088,
"heapUsedBytes": 91225744,
"domNodes": -258,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 1885.894,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666088631984586,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15623.275999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15025.72,
"heapDeltaBytes": -24820308,
"heapUsedBytes": 279159756,
"domNodes": -3330,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 207.87699999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.425789473684212,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 15316.20099999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14708.420000000002,
"heapDeltaBytes": -26406268,
"heapUsedBytes": 257965788,
"domNodes": -3330,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 226.404,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.97521222410866,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17836.89399999997,
"styleRecalcs": 145,
"styleRecalcDurationMs": 12.617000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17410.961,
"heapDeltaBytes": -4164488,
"heapUsedBytes": 284483748,
"domNodes": -3330,
"jsHeapTotalBytes": 7520256,
"scriptDurationMs": 636.814,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.600731261425956,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17994.73599999999,
"styleRecalcs": 150,
"styleRecalcDurationMs": 14.055000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17564.498999999996,
"heapDeltaBytes": -9170084,
"heapUsedBytes": 280408664,
"domNodes": -3330,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 619.0600000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.209225092250925,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5550.898000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.057999999999986,
"layouts": 20,
"layoutDurationMs": 20.314,
"taskDurationMs": 5433.5380000000005,
"heapDeltaBytes": -25457252,
"heapUsedBytes": 262986164,
"domNodes": -3330,
"jsHeapTotalBytes": 36163584,
"scriptDurationMs": 103.73299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.89540229885057,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5678.88599999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 44.41699999999999,
"layouts": 20,
"layoutDurationMs": 20.358,
"taskDurationMs": 5517.345,
"heapDeltaBytes": -4503796,
"heapUsedBytes": 286698632,
"domNodes": -3330,
"jsHeapTotalBytes": 35901440,
"scriptDurationMs": 101.96900000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.62781065088757,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7533.9910000000145,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7240.169,
"heapDeltaBytes": 14512124,
"heapUsedBytes": 280055108,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.16800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.62278911564626,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7903.386000000069,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7420.437,
"heapDeltaBytes": 4549616,
"heapUsedBytes": 284825396,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 102.661,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.5983164983165,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 459.5610000000079,
"styleRecalcs": 20,
"styleRecalcDurationMs": 11.198,
"layouts": 12,
"layoutDurationMs": 4.092999999999999,
"taskDurationMs": 120.97200000000001,
"heapDeltaBytes": -12812420,
"heapUsedBytes": 63159424,
"domNodes": 126,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.918,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 89.93099999997867,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.951,
"layouts": 6,
"layoutDurationMs": 2.361,
"taskDurationMs": 56.702000000000005,
"heapDeltaBytes": 4438168,
"heapUsedBytes": 80560232,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.715999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 189.0210000000252,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7929999999999999,
"layouts": 76,
"layoutDurationMs": 9.106,
"taskDurationMs": 151.281,
"heapDeltaBytes": -20743980,
"heapUsedBytes": 69135564,
"domNodes": 4,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 62.370000000000005,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 194.6690000000899,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.675,
"layouts": 76,
"layoutDurationMs": 9.863,
"taskDurationMs": 151.116,
"heapDeltaBytes": 8804648,
"heapUsedBytes": 82499640,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 63.892,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 236.4949999999908,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.198,
"layouts": 76,
"layoutDurationMs": 8.809000000000001,
"taskDurationMs": 188.218,
"heapDeltaBytes": -7434468,
"heapUsedBytes": 104157400,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 62.64199999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 222.76399999998375,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.348,
"layouts": 76,
"layoutDurationMs": 9.539000000000001,
"taskDurationMs": 192.14399999999998,
"heapDeltaBytes": 25645432,
"heapUsedBytes": 134427760,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 60.437999999999995,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2279 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3da607ac16d6400401992367023eab1b200ee0a4
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21057.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-j06c404pr-comfyui.vercel.app Last updated: 2026-10-15T02:44:03Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21057 +/- ##
==========================================
+ Coverage 86.42% 87.23% +0.80%
==========================================
Files 3702 2635 -1067
Lines 176121 147726 -28395
Branches 46557 38468 -8089
==========================================
- Hits 152219 128865 -23354
+ Misses 21848 18471 -3377
+ Partials 2054 390 -1664
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1094 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @jaeone94.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
| if (widget.name !== oldPrefix && !widget.name.startsWith(`${oldPrefix}.`)) | ||
| continue | ||
| widget.name = newPrefix + widget.name.slice(oldPrefix.length) | ||
| if (widget.serialize !== false && widget.widgetId) |
There was a problem hiding this comment.
🟢 Low — The BaseWidget.name setter can refuse a rename without reporting it. This happens when store.renameWidget fails because the target id is still registered, or when the registered state is not this widget's _state. The announce still runs, so widget.widgetId resolves to the OLD id and announceValue mints a set_widget under the stale name. That can bring a just-removed row's value back into the shared document while the widget and input names drift apart. Only announce once widget.name === newPrefix + widget.name.slice(oldPrefix.length) (i.e. the rename really happened), and surface the failure otherwise. Raised by 4 of 6 reviewers (claude-opus-5-5-xhigh adversarial, kimi-k3-high adversarial, claude-opus-5-5-xhigh edge-case, kimi-k3-high edge-case).
There was a problem hiding this comment.
Fixed in 6e06059. renameRowWidgets announces only when widget.name actually equals the new name after assignment, and it also skips button widgets, matching #20992. New test does not mint a shifted field whose rename was refused makes renameWidget fail. Before the fix it minted the stale loras.2.* keys; now only the count change goes out.
| continue | ||
| widget.name = newPrefix + widget.name.slice(oldPrefix.length) | ||
| if (widget.serialize !== false && widget.widgetId) | ||
| store.announceValue(widget.widgetId) |
There was a problem hiding this comment.
🟢 Low — announceValue hardcodes previous: undefined, which fits a newly created widget. A shifted row's destination key, though, already has a value in the document (e.g. loras.1.seed was 11 before row 2 shifts into it). The minted op therefore says old: undefined, and the new test locks that in. Undo, history, or conflict checks that read old (as restoreOpMinter populates it) will treat the overwrite as a create, and a concurrent remote write to a shifted slot is lost silently. Capture the store value at the destination name before the rename and pass it as previous. Raised by 3 of 6 reviewers (claude-opus-5-5-xhigh adversarial, claude-opus-5-5-xhigh edge-case, kimi-k3-high edge-case).
There was a problem hiding this comment.
Keeping previous: undefined, for the same reason as on #20992: the doc host resolves set_widget by stamp, and no consumer of these minted ops reads old. A concurrent remote write to a shifted slot is a last-writer-wins race, the same as any concurrent field edit.
| if (widget.name === oldPrefix || widget.name.startsWith(`${oldPrefix}.`)) | ||
| widget.name = newPrefix + widget.name.slice(oldPrefix.length) | ||
| } | ||
| renameRowWidgets(oldPrefix, newPrefix) |
There was a problem hiding this comment.
⚪ Nit — After a middle row is removed, the shifted values are announced, but nothing clears the vacated tail slot (e.g. loras.2.seed, loras.2.seed.0) in the document. The test's expected mint list confirms this. Those stale named values stay behind with the lower row count. Peers or restore logic that count or read named values directly (e.g. getRestoredWidgetValueCount) can see them again. Consider minting removals for the last row's keys. Raised by 1 of 6 reviewers (claude-opus-5-5-xhigh adversarial).
There was a problem hiding this comment.
Known, and listed as a follow-up in the PR body. This PR only re-syncs the shifted rows. Clearing the vacated tail keys needs a removal op for named values, which is a separate change.
6851752 to
a8a82da
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @jaeone94.
Round 2 — ledger: 3 prior finding(s) across 1 round(s) (0 never answered).
Found 2 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 2 |
Panel: 6/6 reviewers contributed findings.
| const name = newPrefix + widget.name.slice(oldPrefix.length) | ||
| widget.name = name | ||
| if ( | ||
| widget.name === name && |
There was a problem hiding this comment.
🟢 Low — 6e06059's widget.name === name check does stop the stale loras.2.* mint, but it covers only half of the original finding: a refused rename is still silent and the removal still goes ahead. renameRow renames the row's inputs regardless, so a widget can keep loras.2.seed while its input becomes loras.1.seed, and publish() mints the lower count. Peers then drop the tail row and keep the deleted row's value in the shifted slot (for example loras.1.seed stays 11 while the local value is 12). The new test does not mint a shifted field whose rename was refused asserts only the mint list, so it locks in that split. Abort the removal or reportError() when any row-widget rename is refused, and assert the resulting local and doc state in that test. Raised by 4 of 6 reviewers (claude-opus-5-5-xhigh adversarial, gpt-5.6-sol-xhigh adversarial, kimi-k3-high adversarial, kimi-k3-high edge-case).
↩︎ re-raise of #21057 (comment) (round 1)
There was a problem hiding this comment.
Keeping this as is. removeRow deletes the removed row's widgets before renaming, so the target ids are free. A refused rename means the widget store invariant is already broken, and aborting halfway through a removal would leave a worse partial state. This PR only makes sure such a widget isn't minted under its stale key.
| widget.type !== 'button' && | ||
| widget.widgetId | ||
| ) | ||
| store.announceValue(widget.widgetId) |
There was a problem hiding this comment.
🟢 Low — Multiline STRING fields (addMultilineWidget in useStringWidget.ts) are reported to bind getValue/setValue to widgetId(graphId, node.id, name) using the name they were created with. If so, after a shift the textarea now named loras.1.text still reads and writes the loras.2.text entry, which belongs to the next row. This announce sends the moved entry's correct value, but later edits and local serialization go through the stale key. Those edits can also register orphan entries that make later renames into that slot fail. Have such widgets resolve their id from the current widget.name, or add a multiline field to the shift test to confirm it round-trips. Raised by 2 of 6 reviewers (claude-opus-5-5-xhigh adversarial, claude-opus-5-5-xhigh edge-case).
There was a problem hiding this comment.
Out of scope here. If multiline STRING widgets keep their creation-time id, then local row renumbering is affected independently of this PR, and this PR only mints the moved values. I'll check that binding separately rather than widen this change.
christian-byrne
left a comment
There was a problem hiding this comment.
Read the diff, the merged dependency (#20992, merged into this PR's base), and all 5 open Cursor-panel threads before approving.
renameRowWidgets only announces a shifted widget's CRDT value after confirming widget.name === name post-assignment — so a refused store-level rename (the original stale-mint finding) can no longer mint a set_widget under the wrong key. New test does not mint a shifted field whose rename was refused goes red without the guard and green with it; the baseline mints the shifted field values after a middle row is removed test is also red on main and green here.
On the still-open threads:
previous: undefinedon the minted op — same deliberate choice as #20992: the doc host resolves by stamp, nothing readsold. Consistent precedent, not a new gap.- Vacated tail-slot keys not cleared — explicitly called out as a follow-up in the PR body itself, not a hidden gap.
- Refused-rename-still-proceeds re-raise — checked
widgetValueStore.renameWidget: it only refuses when the destination id is already registered, andremoveRowfully removes the deleted row's widgets before any rename runs, so a refusal here means the widget-store invariant is already broken upstream of this code, not something this diff introduces. Aborting mid-removal on that signal would trade a CRDT-mint bug for a worse half-removed node state, per the author's own reasoning — reasonable non-blocking trade-off. - Multiline STRING widget id binding — orthogonal to this change (affects local rename regardless of CRDT mint), author committed to checking separately.
CI settled green at full head, non-draft, mergeable. Approving.
|
|
Summary
In a doc-bound workflow, deleting a middle DynamicGroup row only minted the row-count
set_widget. The later rows were renamed locally, but nothing was minted for the shiftedgroup.N.*fields, so the document and peers dropped the last row and kept the deleted row's values (3 rows, delete row 0: this tab shows[r1, r2], the doc ends up[r0, r1]).Each serializable widget renamed by a row shift now announces its current value (
announceValue) under its new name. The minter still mints only local writes, so remote and load removals mint nothing.Stacked on #20992. Fixes #20992 (comment)
Review focus
set_widgets are minted before the count decrement. The doc host resolves each register by stamp, so the order does not change the final state.Tests
mints the shifted field values after a middle row is removedfailed on the base branch. Onlyset_widget loras 3 -> 2was minted, with noloras.1.*ops.pnpm -s vitest run src/core/graph src/workbench/extensions/agent/crdt src/stores/widgetValueStore.test.ts: 89 files, 1375 passed, 1 expected fail.mints nothing for a row removed by a agent-remote/load write.