Skip to content

refactor(website): render link sentences and hero highlights as complete messages - #21055

Open
benceruleanlu wants to merge 1 commit into
bl/website-heading-placeholdersfrom
bl/website-link-sentences
Open

benceruleanlu wants to merge 1 commit into
bl/website-heading-placeholdersfrom
bl/website-link-sentences

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Summary

Website sentences that wrapped a link or a styled count were still translated as a prefix and a suffix around it. Each is now one message with a {link}, {email}, {models} or {highlight} placeholder rendered through I18nT slots: the home get-started step, the HubSpot load error, the CLI and MCP setup requirements, the CLI key, docs and skills lines, the sign-in free-runs prompt, and the router coverage footer. zh-CN and ja copy is joined from the old fragments under new keys (no retranslation), and the CLI and MCP requirement footnotes fold into their sentence instead of being appended with a leading space.

  • HeroSplit01 takes the title as a #title slot instead of a titleHighlight prop; the affiliate and cloud-nodes heroes render the I18nT there.
  • The README convention now covers links as well as styled words.
  • Left as is: lines where a complete sentence is followed by a standalone link (mcp.setup.skillsNote), and the platform closing CTA, which stacks a lead line, the Developer Platform badge component and a follow-up line. Turning that badge into a slot is a layout change that needs a visual check, so it gets its own PR.

Part of FE-3069. Stacked on #21052.

Verification

  • New interpolatedLinks.test.ts table checks the whole sentence and the link inside it for the get-started, CLI skills, CLI setup and MCP setup sentences in en plus zh-CN or ja. The CLI setup, sign-in, HubSpot and router-coverage tests now assert the full sentence around their link or count. interpolatedHeadings.test.ts gains h1 rows for the affiliate and cloud-nodes heroes. Renamed slots and keypath typos fail these tests (checked by mutating four sites).
  • Website unit tests for the touched areas pass (492). Website typecheck and lint pass in the pre-commit hook. locale:check shows 0 protected-token violations; the 136 pending ja strings are the same as on the base branch.
  • Not checked visually in a browser.

…ete messages

Sentences that wrapped a link or a styled count were translated as a
prefix and a suffix around it, so each locale had to break where English
did. Each is now one message with a {link}, {email}, {models} or
{highlight} placeholder rendered through I18nT slots: the get-started
step, the HubSpot load error, the CLI and MCP setup requirements, the CLI
key, docs and skills lines, the sign-in free-runs prompt and the router
coverage footer. The CLI and MCP requirement footnotes fold into their
sentence instead of being appended with a leading space.

HeroSplit01 takes its title as a slot instead of a titleHighlight prop,
and the affiliate and cloud-nodes heroes render the I18nT there.

zh-CN and ja copy is joined from the old fragments under new keys, and
the README convention now covers links.
@benceruleanlu benceruleanlu changed the title bl/website link sentences refactor(website): render link sentences and hero highlights as complete messages Oct 15, 2026
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 24
  • apps/website/README.md is excluded by !apps/website/**
  • apps/website/e2e/affiliates.spec.ts is excluded by !apps/website/**
  • apps/website/src/components/auth/AuthSignIn.test.ts is excluded by !apps/website/**
  • apps/website/src/components/auth/AuthSignInPanel.vue is excluded by !apps/website/**
  • apps/website/src/components/blocks/HeroSplit01.stories.ts is excluded by !apps/website/**
  • apps/website/src/components/blocks/HeroSplit01.vue is excluded by !apps/website/**
  • apps/website/src/components/common/HubspotFormEmbed.test.ts is excluded by !apps/website/**
  • apps/website/src/components/common/HubspotFormEmbed.vue is excluded by !apps/website/**
  • apps/website/src/components/home/GetStartedSection.vue is excluded by !apps/website/**
  • apps/website/src/components/interpolatedHeadings.test.ts is excluded by !apps/website/**
  • apps/website/src/components/interpolatedLinks.test.ts is excluded by !apps/website/**
  • apps/website/src/locales/en/main.json is excluded by !apps/website/**
  • apps/website/src/locales/ja/main.json is excluded by !apps/website/**
  • apps/website/src/locales/zh-CN/main.json is excluded by !apps/website/**
  • apps/website/src/templates/affiliate/HeroSection.vue is excluded by !apps/website/**
  • apps/website/src/templates/cli/SetupSection.test.ts is excluded by !apps/website/**
  • apps/website/src/templates/cli/SetupSection.vue is excluded by !apps/website/**
  • apps/website/src/templates/cli/SkillsSection.vue is excluded by !apps/website/**
  • apps/website/src/templates/cloud-nodes/HeroSection.vue is excluded by !apps/website/**
  • apps/website/src/templates/cloud-nodes/copy.test.ts is excluded by !apps/website/**
  • apps/website/src/templates/mcp/SetupSection.vue is excluded by !apps/website/**
  • apps/website/src/templates/platform/RouterProviderCoverageSection.test.ts is excluded by !apps/website/**
  • apps/website/src/templates/platform/RouterProviderCoverageSection.vue is excluded by !apps/website/**
  • apps/website/src/test/wholeText.ts is excluded by !apps/website/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0d0981f0-b2b5-4b08-b6fe-28b3a52f7233

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T00:39:30.442658Z ea59d12 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (28 changed files).

Kind Finding Where Usual remedy
Duplication 3-way clone apps/website/src/components/blocks/BuildConfiguratorSplit01.stories.ts:8-78
apps/website/src/components/blocks/HeroProduct01.stories.ts:10-42
apps/website/src/components/blocks/HeroSplit01.stories.ts:11-60
Extract the shared fragment into one function the sites call.
Complexity <template>() — cyclomatic 26, CRAP undefined apps/website/src/components/auth/AuthSignInPanel.vue:62 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 17, CRAP undefined apps/website/src/components/blocks/HeroSplit01.vue:98 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 13, CRAP undefined apps/website/src/templates/mcp/SetupSection.vue:87 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since dfc337bc11ca15866b73cd3d55b89b34169fa5f0

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21055.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-3edipi3bo-comfyui.vercel.app

Last updated: 2026-10-15T00:38:43Z for ea59d12

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 15, 2026
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                         Coverage Diff                         @@
##           bl/website-heading-placeholders   #21055      +/-   ##
===================================================================
+ Coverage                            86.36%   86.39%   +0.03%     
===================================================================
  Files                                 3582     3582              
  Lines                               172268   172280      +12     
  Branches                             47330    47329       -1     
===================================================================
+ Hits                                148780   148843      +63     
+ Misses                               21587    21538      -49     
+ Partials                              1901     1899       -2     
Flag Coverage Δ
website-unit 81.77% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ps/website/src/components/auth/AuthSignInPanel.vue 100.00% <100.00%> (ø)
apps/website/src/components/blocks/HeroSplit01.vue 91.66% <100.00%> (-0.34%) ⬇️
...website/src/components/common/HubspotFormEmbed.vue 100.00% <100.00%> (ø)
.../website/src/components/home/GetStartedSection.vue 100.00% <100.00%> (+100.00%) ⬆️
...ps/website/src/templates/affiliate/HeroSection.vue 100.00% <100.00%> (+100.00%) ⬆️
apps/website/src/templates/cli/SetupSection.vue 96.96% <100.00%> (+5.03%) ⬆️
apps/website/src/templates/cli/SkillsSection.vue 100.00% <100.00%> (+100.00%) ⬆️
.../website/src/templates/cloud-nodes/HeroSection.vue 100.00% <100.00%> (ø)
apps/website/src/templates/mcp/SetupSection.vue 94.82% <100.00%> (+0.18%) ⬆️
...mplates/platform/RouterProviderCoverageSection.vue 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was previously deployed

1 inactive deployment
website-approval — ea59d128 Deployed Oct 15, 2026 by benceruleanlu via fast-lane #3508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant