Repository navigation
refactor(website): render link sentences and hero highlights as complete messages - #21055
benceruleanlu wants to merge 1 commit into
Conversation
…ete messages
Sentences that wrapped a link or a styled count were translated as a
prefix and a suffix around it, so each locale had to break where English
did. Each is now one message with a {link}, {email}, {models} or
{highlight} placeholder rendered through I18nT slots: the get-started
step, the HubSpot load error, the CLI and MCP setup requirements, the CLI
key, docs and skills lines, the sign-in free-runs prompt and the router
coverage footer. The CLI and MCP requirement footnotes fold into their
sentence instead of being appended with a leading space.
HeroSplit01 takes its title as a slot instead of a titleHighlight prop,
and the affiliate and cloud-nodes heroes render the I18nT there.
zh-CN and ja copy is joined from the old fragments under new keys, and
the README convention now covers links.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 24
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (28 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since dfc337bc11ca15866b73cd3d55b89b34169fa5f0
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21055.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-3edipi3bo-comfyui.vercel.app Last updated: 2026-10-15T00:38:43Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## bl/website-heading-placeholders #21055 +/- ##
===================================================================
+ Coverage 86.36% 86.39% +0.03%
===================================================================
Files 3582 3582
Lines 172268 172280 +12
Branches 47330 47329 -1
===================================================================
+ Hits 148780 148843 +63
+ Misses 21587 21538 -49
+ Partials 1901 1899 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Website sentences that wrapped a link or a styled count were still translated as a prefix and a suffix around it. Each is now one message with a
{link},{email},{models}or{highlight}placeholder rendered throughI18nTslots: the home get-started step, the HubSpot load error, the CLI and MCP setup requirements, the CLI key, docs and skills lines, the sign-in free-runs prompt, and the router coverage footer. zh-CN and ja copy is joined from the old fragments under new keys (no retranslation), and the CLI and MCP requirement footnotes fold into their sentence instead of being appended with a leading space.HeroSplit01takes the title as a#titleslot instead of atitleHighlightprop; the affiliate and cloud-nodes heroes render theI18nTthere.mcp.setup.skillsNote), and the platform closing CTA, which stacks a lead line, the Developer Platform badge component and a follow-up line. Turning that badge into a slot is a layout change that needs a visual check, so it gets its own PR.Part of FE-3069. Stacked on #21052.
Verification
interpolatedLinks.test.tstable checks the whole sentence and the link inside it for the get-started, CLI skills, CLI setup and MCP setup sentences in en plus zh-CN or ja. The CLI setup, sign-in, HubSpot and router-coverage tests now assert the full sentence around their link or count.interpolatedHeadings.test.tsgains h1 rows for the affiliate and cloud-nodes heroes. Renamed slots and keypath typos fail these tests (checked by mutating four sites).locale:checkshows 0 protected-token violations; the 136 pending ja strings are the same as on the base branch.