Skip to content

refactor(website): render reason and launch-hero headings as complete messages - #21052

Open
benceruleanlu wants to merge 1 commit into
bl/website-complete-headingsfrom
bl/website-heading-placeholders
Open

benceruleanlu wants to merge 1 commit into
bl/website-complete-headingsfrom
bl/website-heading-placeholders

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Summary

ReasonSection (cloud and download), ReasonsSplit01 (CLI, MCP and cloud-nodes "why" sections) and ModelLaunchHeroSection (Flux 3, Gemini Omni, MiniMax H3, MiniMax Music 3, Fish Audio heroes) built their headings from a lead fragment plus a styled highlight or muted rest. Each heading is now one headline message with a {highlight} or {model} placeholder rendered through I18nT slots, following #21034. zh-CN and ja copy is joined from the old fragments under the new key, so generation keeps it.

  • ReasonsSplit01 takes the heading as a #heading slot so the block stays i18n-free; its three callers render the I18nT. Its heading, headingHighlight and highlightClass props are gone.
  • ReasonSection drops the never-passed headingSuffixKey; headingHighlightKey is now required.
  • Model-launch heroes replace titleRestKey with titleModelKey; titleKey names the complete headline. With a model slot, the heading text is the muted color and the model name keeps full color, so the two-tone look is unchanged.

Part of FE-3069. Link sentences split as Prefix/Suffix pairs and the HeroSplit01 heroes follow in #21055, stacked on this one.

Verification

  • interpolatedHeadings.test.ts gains en plus zh-CN or ja rows for both reason sections and all three "why" sections. ModelLaunchHeroSection.test.ts covers the title in each of the three hero layouts across en, zh-CN and ja. A renamed slot or keypath typo fails them (checked by mutating the CLI slot name and one hero slot).
  • Website unit tests for the touched areas pass (344). Website typecheck passes in the pre-commit hook. locale:check shows 0 protected-token violations; its 136 pending ja strings are the same as on the base branch.
  • Not checked visually in a browser.

… messages

ReasonSection, ReasonsSplit01 and ModelLaunchHeroSection built their
headings from a lead fragment plus a styled highlight (or a muted rest),
so every locale had to break the sentence where English did. Each heading
is now one message with a named placeholder ({highlight} or {model})
rendered through I18nT slots.

ReasonsSplit01 takes the heading as a slot so the block stays free of
i18n; its three WhySection callers render the I18nT. The unused
headingSuffixKey prop is gone. Model-launch heroes swap titleRestKey for
titleModelKey, with titleKey pointing at the complete headline.

New keys (headline) carry the zh-CN and ja copy joined from the old
fragments, so generation keeps it.
@benceruleanlu benceruleanlu changed the title bl/website heading placeholders refactor(website): render reason and launch-hero headings as complete messages Oct 15, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T00:30:12.931156Z b64f972 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 25
  • apps/website/e2e/gemini-omni.spec.ts is excluded by !apps/website/**
  • apps/website/e2e/minimax-h3.spec.ts is excluded by !apps/website/**
  • apps/website/src/components/blocks/ReasonsSplit01.stories.ts is excluded by !apps/website/**
  • apps/website/src/components/blocks/ReasonsSplit01.vue is excluded by !apps/website/**
  • apps/website/src/components/interpolatedHeadings.test.ts is excluded by !apps/website/**
  • apps/website/src/components/product/cloud/ReasonSection.vue is excluded by !apps/website/**
  • apps/website/src/components/product/local/ReasonSection.vue is excluded by !apps/website/**
  • apps/website/src/components/product/shared/ReasonSection.stories.ts is excluded by !apps/website/**
  • apps/website/src/components/product/shared/ReasonSection.vue is excluded by !apps/website/**
  • apps/website/src/data/fishAudio.ts is excluded by !apps/website/**
  • apps/website/src/data/flux3.ts is excluded by !apps/website/**
  • apps/website/src/data/geminiOmni.ts is excluded by !apps/website/**
  • apps/website/src/data/minimax.ts is excluded by !apps/website/**
  • apps/website/src/data/minimaxMusic3.ts is excluded by !apps/website/**
  • apps/website/src/locales/en/main.json is excluded by !apps/website/**
  • apps/website/src/locales/ja/main.json is excluded by !apps/website/**
  • apps/website/src/locales/zh-CN/main.json is excluded by !apps/website/**
  • apps/website/src/templates/cli/WhySection.vue is excluded by !apps/website/**
  • apps/website/src/templates/cloud-nodes/WhySection.vue is excluded by !apps/website/**
  • apps/website/src/templates/cloud-nodes/copy.test.ts is excluded by !apps/website/**
  • apps/website/src/templates/mcp/WhySection.vue is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/ModelLaunchHeroSection.test.ts is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/ModelLaunchHeroSection.vue is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/modelLaunchPages.test.ts is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/types.ts is excluded by !apps/website/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d8822712-4619-496c-a0b8-19b35c9c779f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since e13897f270c84cd64d4d42d0655bf6b9ba84ab7a

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21052.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-cao4uirx4-comfyui.vercel.app

Last updated: 2026-10-15T00:29:44Z for b64f972

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 15, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b64f9722f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

videoSrc: media.hero.src,
titleKey: 'flux3.hero.title',
titleRestKey: 'flux3.hero.titleRest',
titleKey: 'flux3.hero.headline',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Interpolate model names in hero video labels

When this and the other four migrated launch configurations render a hero video, ModelLaunchHeroSection.vue still creates its accessible label with t(hero.titleKey) at lines 146, 157, 274, and 284. Because titleKey now points to a message containing {model}, the <video> is labeled with an unresolved placeholder such as “{model} is here” instead of the localized model name. Interpolate titleModelKey through t, or provide a separate non-parameterized media label.

AGENTS.md reference: apps/website/AGENTS.md:L35-L40

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../templates/model-launch/ModelLaunchHeroSection.vue 87.50% 0 Missing and 1 partial ⚠️
@@                       Coverage Diff                        @@
##           bl/website-complete-headings   #21052      +/-   ##
================================================================
+ Coverage                         86.34%   86.36%   +0.02%     
================================================================
  Files                              3582     3582              
  Lines                            172258   172268      +10     
  Branches                          47332    47330       -2     
================================================================
+ Hits                             148732   148780      +48     
+ Misses                            21619    21587      -32     
+ Partials                           1907     1901       -6     
Flag Coverage Δ
website-unit 81.56% <95.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/website/src/components/blocks/ReasonsSplit01.vue 90.00% <ø> (+8.18%) ⬆️
...ite/src/components/product/cloud/ReasonSection.vue 100.00% <ø> (+100.00%) ⬆️
...ite/src/components/product/local/ReasonSection.vue 100.00% <ø> (+100.00%) ⬆️
...te/src/components/product/shared/ReasonSection.vue 90.00% <100.00%> (+90.00%) ⬆️
apps/website/src/data/fishAudio.ts 100.00% <ø> (ø)
apps/website/src/data/flux3.ts 100.00% <ø> (ø)
apps/website/src/data/geminiOmni.ts 100.00% <ø> (ø)
apps/website/src/data/minimax.ts 100.00% <ø> (ø)
apps/website/src/data/minimaxMusic3.ts 100.00% <ø> (ø)
apps/website/src/templates/cli/WhySection.vue 100.00% <100.00%> (+100.00%) ⬆️
... and 4 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was previously deployed

1 inactive deployment
website-approval — b64f9722 Deployed Oct 15, 2026 by benceruleanlu via fast-lane #3509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant