Repository navigation
refactor(website): render reason and launch-hero headings as complete messages - #21052
benceruleanlu wants to merge 1 commit into
Conversation
… messages
ReasonSection, ReasonsSplit01 and ModelLaunchHeroSection built their
headings from a lead fragment plus a styled highlight (or a muted rest),
so every locale had to break the sentence where English did. Each heading
is now one message with a named placeholder ({highlight} or {model})
rendered through I18nT slots.
ReasonsSplit01 takes the heading as a slot so the block stays free of
i18n; its three WhySection callers render the I18nT. The unused
headingSuffixKey prop is gone. Model-launch heroes swap titleRestKey for
titleModelKey, with titleKey pointing at the complete headline.
New keys (headline) carry the zh-CN and ja copy joined from the old
fragments, so generation keeps it.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 25
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e13897f270c84cd64d4d42d0655bf6b9ba84ab7a
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21052.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-cao4uirx4-comfyui.vercel.app Last updated: 2026-10-15T00:29:44Z for |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b64f9722f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| videoSrc: media.hero.src, | ||
| titleKey: 'flux3.hero.title', | ||
| titleRestKey: 'flux3.hero.titleRest', | ||
| titleKey: 'flux3.hero.headline', |
There was a problem hiding this comment.
Interpolate model names in hero video labels
When this and the other four migrated launch configurations render a hero video, ModelLaunchHeroSection.vue still creates its accessible label with t(hero.titleKey) at lines 146, 157, 274, and 284. Because titleKey now points to a message containing {model}, the <video> is labeled with an unresolved placeholder such as “{model} is here” instead of the localized model name. Interpolate titleModelKey through t, or provide a separate non-parameterized media label.
AGENTS.md reference: apps/website/AGENTS.md:L35-L40
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## bl/website-complete-headings #21052 +/- ##
================================================================
+ Coverage 86.34% 86.36% +0.02%
================================================================
Files 3582 3582
Lines 172258 172268 +10
Branches 47332 47330 -2
================================================================
+ Hits 148732 148780 +48
+ Misses 21619 21587 -32
+ Partials 1907 1901 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
ReasonSection(cloud and download),ReasonsSplit01(CLI, MCP and cloud-nodes "why" sections) andModelLaunchHeroSection(Flux 3, Gemini Omni, MiniMax H3, MiniMax Music 3, Fish Audio heroes) built their headings from a lead fragment plus a styled highlight or muted rest. Each heading is now oneheadlinemessage with a{highlight}or{model}placeholder rendered throughI18nTslots, following #21034. zh-CN and ja copy is joined from the old fragments under the new key, so generation keeps it.ReasonsSplit01takes the heading as a#headingslot so the block stays i18n-free; its three callers render theI18nT. Itsheading,headingHighlightandhighlightClassprops are gone.ReasonSectiondrops the never-passedheadingSuffixKey;headingHighlightKeyis now required.titleRestKeywithtitleModelKey;titleKeynames the complete headline. With a model slot, the heading text is the muted color and the model name keeps full color, so the two-tone look is unchanged.Part of FE-3069. Link sentences split as Prefix/Suffix pairs and the
HeroSplit01heroes follow in #21055, stacked on this one.Verification
interpolatedHeadings.test.tsgains en plus zh-CN or ja rows for both reason sections and all three "why" sections.ModelLaunchHeroSection.test.tscovers the title in each of the three hero layouts across en, zh-CN and ja. A renamed slot or keypath typo fails them (checked by mutating the CLI slot name and one hero slot).locale:checkshows 0 protected-token violations; its 136 pending ja strings are the same as on the base branch.