Skip to content

refactor(website): render split headings as complete messages - #21034

Open
benceruleanlu wants to merge 2 commits into
mainfrom
bl/website-complete-headings
Open

benceruleanlu wants to merge 2 commits into
mainfrom
bl/website-complete-headings

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Summary

Five website headings were translated as before/after fragments around a styled span (about.values, about.story, cloud.audience, the careers "Why join" title, and the models hero), so every language had to break its sentence where English did. Each is now one message with named placeholders ({highlight}, {logo}, {br}, {comfyui}), rendered through vue-i18n's I18nT slots, so word order and the careers line break belong to the locale. The existing Chinese and Japanese copy is joined into the new messages, not retranslated; every heading uses a new key, so generation keeps that copy. The README documents the slot convention.

I18nT's i18n prop only accepts an untyped composer, so the website catalogs are now typed as string-keyed message dictionaries. t() already accepted any string key, so only the locale-name typing on t's options is lost.

Part of FE-3069 and FE-2045. ReasonSection, ModelLaunchHeroSection and ReasonsSplit01 still render split fragments and follow separately.

Verification

  • interpolatedHeadings.test.ts checks the values, story and audience headings in en and zh-CN (exact text, highlight as its own element) and the careers title card. Keypath typos and renamed slots in each component fail it. The models hero test covers en, zh-CN and ja order and the ComfyUI brand element.
  • Website typecheck passes, and locale:check reports 0 protected-token violations and nothing pending for zh-CN.
  • Not rechecked visually after the review changes; the rendered DOM is the same as the previous head, which was compared pixel-for-pixel against production.

@benceruleanlu
benceruleanlu requested a review from a team October 14, 2026 21:44
@benceruleanlu
benceruleanlu requested review from a team and dante01yoon as code owners October 14, 2026 21:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T21:47:01.719548Z fbcf793 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Five headings were translated as before/after fragments around a styled
span, so each locale had to split its sentence where English did. Each is
now one message with a named placeholder, rendered with vue-i18n's I18nT
slots, so word order belongs to the locale. Existing Chinese and Japanese
copy is joined into the new messages rather than retranslated.

The website catalogs are typed as string-keyed message dictionaries so the
per-locale composer satisfies I18nT's i18n prop.
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 13
  • apps/website/README.md is excluded by !apps/website/**
  • apps/website/src/components/about/OurValuesSection.vue is excluded by !apps/website/**
  • apps/website/src/components/about/StorySection.vue is excluded by !apps/website/**
  • apps/website/src/components/common/WireNodeLayout.vue is excluded by !apps/website/**
  • apps/website/src/components/interpolatedHeadings.test.ts is excluded by !apps/website/**
  • apps/website/src/components/models/ModelsHeroSection.test.ts is excluded by !apps/website/**
  • apps/website/src/components/models/ModelsHeroSection.vue is excluded by !apps/website/**
  • apps/website/src/components/product/cloud/AudienceSection.vue is excluded by !apps/website/**
  • apps/website/src/i18n/translations.ts is excluded by !apps/website/**
  • apps/website/src/locales/.source-manifest.json is excluded by !apps/website/**
  • apps/website/src/locales/en/main.json is excluded by !apps/website/**
  • apps/website/src/locales/ja/main.json is excluded by !apps/website/**
  • apps/website/src/locales/zh-CN/main.json is excluded by !apps/website/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ed37bacc-b2eb-435b-b4ec-28c90e8a52f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@benceruleanlu
benceruleanlu force-pushed the bl/website-complete-headings branch from fbcf793 to 5b9f4bb Compare October 14, 2026 21:44
@benceruleanlu benceruleanlu changed the title bl/website complete headings refactor(website): render split headings as complete messages Oct 14, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (17 changed files).

Kind Finding Where Usual remedy
Complexity <template>() — cyclomatic 22, CRAP undefined apps/website/src/components/common/WireNodeLayout.vue:149 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since f3bf32f94c0a0d0bc350b2500427a49b4439f1fb

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21034.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-98848qq77-comfyui.vercel.app

Last updated: 2026-10-14T23:57:42Z for a85eef5

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #21034      +/-   ##
==========================================
- Coverage   86.40%   86.34%   -0.07%     
==========================================
  Files        3687     3582     -105     
  Lines      175499   172258    -3241     
  Branches    48434    47332    -1102     
==========================================
- Hits       151636   148732    -2904     
+ Misses      21812    21619     -193     
+ Partials     2051     1907     -144     
Flag Coverage Δ
billing-web-unit ?
website-unit 81.40% <100.00%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../website/src/components/about/OurValuesSection.vue 100.00% <100.00%> (+100.00%) ⬆️
apps/website/src/components/about/StorySection.vue 100.00% <100.00%> (+100.00%) ⬆️
...s/website/src/components/common/WireNodeLayout.vue 46.06% <100.00%> (+46.06%) ⬆️
...ebsite/src/components/models/ModelsHeroSection.vue 88.88% <100.00%> (ø)
...e/src/components/product/cloud/AudienceSection.vue 100.00% <100.00%> (+100.00%) ⬆️
apps/website/src/i18n/translations.ts 100.00% <100.00%> (ø)

... and 113 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 14, 2026
@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL October 14, 2026 22:11

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: no blocking defects; two P2 test gaps and some P3 items to settle before human review

I compared the preview deployment with comfy.org for the changed headings. Text matches on /about, /careers and /cloud in en and zh-CN, and on /zh-CN/models. Element screenshots of the careers "Why join" card, the cloud audience heading and the zh-CN about values heading are pixel-identical (ImageMagick AE 0). The only text difference is the careers title losing a space before the <br>, which does not render. So the refactor holds up at runtime. What it lacks is protection. keypath is typed string, so a typo or a renamed slot in three of the five headings passes typecheck and the whole website suite. The other items are a translation-pipeline consequence of reusing about.careers.whyTitle, overlap with three of your open PRs, and test and style nits.

Findings without an anchorable line (6)
  1. P2, open PR overlap with #20943. Draft #20943 adds a messageGroups entry that validates models.list.heroTitleBefore and heroTitleAfter as one joined string. It also drops the heroTitleAfter known violation and rewrites the ja heroTitle* values. This PR deletes both keys. If this lands first, that group points at missing keys and its check returns [] without an error, and the manifest and ja models.list hunks conflict. #20943 should drop that group entry and the ja hunk.
  2. P3, open PR overlap with #20585. Draft #20585 rewrites ja copy for the split headingBefore/headingAfter keys this PR deletes, and edits OurValuesSection.vue and StorySection.vue. Rebased after this merges, its ja heading copy lands on deleted keys and gets pruned. No ja about page is live yet (src/pages/ja/ has only index.astro), so nobody sees it today.
  3. P3, FE-3069 is not fully resolved. The body says "Resolves FE-3069". That issue's acceptance criteria say no translated message is split. src/components/product/shared/ReasonSection.vue:42-48 still renders headingKey + headingHighlightKey + headingSuffixKey fragments. cloud.reason and download.reason use it ("Why professionals choose " + "Cloud"), and zh-CN cloud.reason.heading is a locked-order fragment. ModelLaunchHeroSection.vue (titleKey + titleRestKey) and ReasonsSplit01.vue have the same shape. Either migrate ReasonSection here or change "Resolves" to "Part of" and track the rest. The README Localization section also does not mention the I18nT slot convention yet, so the next heading will probably copy ReasonSection.
  4. P3 Nit, comments left in WireNodeLayout.vue blocks the diff edits. The diff deletes the <!-- Left column … --> label but keeps its siblings <!-- Center column: Reasons card --> (L218) and <!-- Right column: slot for card content --> (L255), plus <!-- Desktop layout --> (L144) and <!-- Mobile layout --> (L282). Each restates the markup under it. The variant JSDoc at L26-30, in the defineProps block the diff edits, lists consumer routes (/careers, /about, /forward-deployed-creatives) that go stale when another page adopts the layout. Cut it to one contract line. These lines sit outside the diff hunks, so I can't attach suggestions.
  5. P3, visual baselines. No toHaveScreenshot golden covers any of the five headings. e2e/visual-responsive.spec.ts's About block captures only the hero, and the diff updates no goldens. An element-level screenshot of the values or story heading in that About block, and of the audience heading in e2e/cloud.spec.ts, would add a baseline without another page load. Context only: the existing cloud.spec.ts:68 check getByText(/creators/i).first() also matches the "CREATORS" card label, so it passes even with the heading broken.
  6. P3, test count in the description. "Website unit tests pass (3,141)". A full website run at this head reports 612 files and 11,805 tests.
Unverified (1)
  • P3, #20366 merge fit. #20366 removes messages from createI18n in translations.ts, which conflicts with the messages constant added here. Without a typed messages, the composer should still fit I18nT's i18n?: Composer, but I have not checked it. To settle it, merge #20366 onto 5b9f4bb and run pnpm typecheck:website.
Checked and cleared (5)
  • Careers title whitespace. Base renders "Why join ?" / "为什么加入 ?" and head renders "Why join?" / "为什么加入?". The space sat before a forced <br>, and preview vs production screenshots of the card are pixel-identical.
  • Hardcoded about.careers.whyTitle in a common/ layout. On base the removed titleBeforeKey/titleAfterKey props already defaulted to about.careers.*, and no caller passed them. BuildersSection uses variant="node", which never renders the title. Deleting the props is right.
  • ja row in the models hero table. ja has the same order as zh-CN, but #21033 just fixed the ja hero order in the catalog. The row pins that fix, and it can regress without zh-CN changing.
  • The messages annotation in translations.ts. Without it, the composer is not assignable to I18nT's i18n?: Composer (TS2322 on the locale union), so the widening is needed. TranslationKey still derives from the English JSON, and unknown keys compiled before too.
  • cloud.spec.ts:68 loose match. Pre-existing and untouched; noted under item 5.

Also checked with no finding: SSR of all five components in three locales (I18nT reads the i18n prop directly, no plugin needed); hydration of WireNodeLayout from server HTML with no mismatch warnings, against a control that does warn; a model name containing <b>, {name}, @: and | renders as literal text; nothing outside the catalogs reads any removed key; removing heroTitleAfter from knownViolations matches locale:check (0 violations).

Coverage

Depth standard. Lanes: correctness, maintainability, tests, each over all 12 files. Lenses: blast-radius, boundary-discipline, fix-root-causes, regression-risk blame (correctness); ponytail, no-comments (0 comments added, 1 removed, 5 left in edited blocks), reader-load, migrate-callers, type-system-discipline (maintainability); designing-test-suites, reviewing-unit-tests (partially applicable to apps/website), test-mock-quality-analysis (0 mocks in either file) (tests). No Playwright spec changed. Fallow: only the WireNodeLayout template complexity, unchanged from base. Run at 5b9f4bb: vitest on the changed tests plus about, careers, common (196 pass); mutation runs for keypath typos and slot renames; locale:check; base vs head SSR and hydration comparison; preview vs production text and screenshots. CI at this head is green. Existing feedback: CodeRabbit skipped the path and Codex left no findings, so nothing to confirm or contest.

Comment on lines +43 to +44
<I18nT
keypath="about.values.heading"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: three of the five converted headings have no test. keypath is typed string in vue-i18n 11.4.10, so typecheck can't catch a typo here. I renamed this slot to #hl, changed StorySection's keypath to about.story.headng, and changed WireNodeLayout's to about.careers.whyTitl. The heading then rendered "We believe , own their process…", the raw key about.story.headng, and the raw key twice in the careers card. The full website suite (11,805 tests) still passed, and no e2e spec asserts these headings.

One table covering every heading component catches all three. Each row would be { component, locale, heading, highlight } with the exact-text and highlight-element assertions AudienceSection.test.ts already makes, and AudienceSection can become a row in it. FE-3069's acceptance criteria ask for this component-level coverage too. Prose because the fix is a new test file.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added interpolatedHeadings.test.ts in a85eef5: one table over OurValuesSection, StorySection and AudienceSection in en and zh-CN (exact text plus the highlight as its own element), and a WireNodeLayout title-card case. Your three mutations, plus an Audience keypath typo, now each fail two rows. AudienceSection.test.ts folded into it.

class="text-2xl font-light text-primary-comfy-canvas"
>
<template #logo>
<br />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3, question: the line break now lives inside the #logo slot, so it always renders right before the logo, wherever a locale puts {logo}. A translation that opens with the logo gets an empty first line in the card. That is a likely output. The ja whyTitle this PR replaces was machine-generated as "Comfyに参加する理由は?", brand first, and the next generation run will retranslate this key (see my comment on en/main.json). Can the break move out of the placeholder? For example, render the logo as its own line with CSS, or split the title so the break is not part of {logo}. The same applies to the copy at L316. Prose because where the break lives is a design call.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the break into its own {br} placeholder, so each locale places it: Why join{br}{logo}?, 为什么加入{br}{logo}?, なぜ{br}{logo}に参加するのか?. Rendering is unchanged for all three today.

Comment on lines +309 to +322
<I18nT
keypath="about.careers.whyTitle"
tag="p"
:i18n
class="text-2xl font-light text-primary-comfy-canvas"
>
<template #logo>
<br />
<span
class="mb-0.5 inline-block h-5 w-16 bg-primary-comfy-yellow align-middle"
style="mask: url(/icons/logo.svg) no-repeat center / contain"
/>
</template>
</I18nT>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Nit: this block is a 14-line copy of L176-189. The duplication was already there, but the diff grows each copy from 8 lines to 14, and the two have to change together (the keypath, the slot, the logo mask). The file already imports @vueuse/core. const [DefineWhyTitle, WhyTitle] = createReusableTemplate() lets the desktop and mobile layouts render one definition. Prose because the change touches both template sites and the script.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: createReusableTemplate defines the title card once and both layouts render <WhyJoinTitle />.

Comment on lines 4 to 7
import { externalLinks } from '@/config/routes'
import { I18nT } from 'vue-i18n'

import { translationsFor } from '@/i18n/translations'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Nit: the vue-i18n import sits between two @/ imports here. The other four migrated files put it in its own group above the @/ imports. No configured rule orders these, so lint passes either way.

Suggested change
import { externalLinks } from '@/config/routes'
import { I18nT } from 'vue-i18n'
import { translationsFor } from '@/i18n/translations'
import { I18nT } from 'vue-i18n'
import { externalLinks } from '@/config/routes'
import { translationsFor } from '@/i18n/translations'

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Comment on lines +12 to +13
const i18n = translationsFor(locale)
const { t } = i18n

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Nit: const i18n = translationsFor(locale) followed by const { t } = i18n repeats in all five files only to feed the :i18n shorthand. Keeping the base line const { t } = translationsFor(locale) and writing :i18n="translationsFor(locale)" on the I18nT drops the extra name and shrinks the diff. translationsFor returns a cached composer, so the second call costs nothing. Prose because the change spans the script and the template, and the same edit applies in OurValuesSection, StorySection, WireNodeLayout and ModelsHeroSection.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in all five files.

Comment on lines +24 to +26
expect(title).toHaveTextContent(new RegExp(`^${heading}$`), {
normalizeWhitespace: false
})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: the RegExp is built from the raw heading, so . matches any character. I changed the en catalog to "…control, and simplicity!" and both rows still passed. ^…$ with normalizeWhitespace: false amounts to exact text equality, which toBe states directly. I ran the replacement at this head and both rows pass.

Suggested change
expect(title).toHaveTextContent(new RegExp(`^${heading}$`), {
normalizeWhitespace: false
})
expect(title.textContent).toBe(heading)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied (now toBe in the shared table).

expect(title).toHaveTextContent(new RegExp(`^${heading}$`), {
normalizeWhitespace: false
})
expect(within(title).getByText(highlight)).toHaveClass('text-white')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: toHaveClass('text-white') copies the production class string and uses it as a stand-in for "the highlight is styled", which docs/guidance/testing-principles.md asks us not to do. within(title).getByText(highlight) already fails when the highlight stops being its own element, because no element's full text is then "creators". The class check adds only a failure on a colour-token rename. I ran the replacement at this head and both rows pass.

Suggested change
expect(within(title).getByText(highlight)).toHaveClass('text-white')
expect(within(title).getByText(highlight)).toBeInTheDocument()

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied; the table only asserts the highlight is its own element.

{ locale: 'zh-CN', title: 'ComfyUI 中的 Flux' },
{ locale: 'ja', title: 'ComfyUIのFlux' }
] as const)(
'places the brand where the $locale title puts it',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: the title says "places the brand", but the body only checks the heading text. I removed the yellow span from the #comfyui slot and all three rows still passed. One more line after the text assertion (L23-26) fails on that mutation 3/3 and passes at this head:

      expect(screen.getByText('ComfyUI')).toBeInTheDocument()

No other element in the section has the exact text "ComfyUI", so screen is enough here and within isn't needed. Prose because L23-26 is outside the diff hunk.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added; removing the span now fails all three rows.

Comment thread apps/website/src/locales/en/main.json Outdated
"whyTitle": "Why join Comfy?",
"whyTitleBefore": "Why join",
"whyTitleAfter": "?",
"whyTitle": "Why join{logo}?",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: this reuses about.careers.whyTitle, which already existed with the English "Why join Comfy?", so generation treats it as modified English. The README's Localization rule says that when English is modified, "generation replaces the matching eligible translations, including locale edits made in the same change". locale:check at this head lists about.careers.whyTitle as pending for zh-CN (the only zh-CN entry) and for ja. The next run will overwrite the hand-joined "为什么加入{logo}?" and "なぜ{logo}に参加するのか?" with machine output that only has to contain {logo} somewhere. The four other headings use new keys, so their joined copy is kept.

Nothing reads the old whyTitle on base, so a new key such as about.careers.whyJoinTitle (in all three catalogs and both keypaths in WireNodeLayout), with the dead whyTitle deleted, keeps the copy you verified. Prose because the change spans three catalogs and the component.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to a new about.careers.whyJoinTitle key and dropped whyTitle. locale:check no longer lists anything pending for zh-CN.

- Move the careers title to a new about.careers.whyJoinTitle key so the
  hand-joined zh-CN and ja copy is kept instead of regenerated, and give
  the line break its own {br} placeholder so locales that open with the
  logo do not get an empty first line.
- Render the Why-join title card from one reusable template.
- Pass translationsFor(locale) straight to I18nT.
- Cover every highlighted heading in one table test that fails on keypath
  typos and renamed slots, and assert the ComfyUI brand in the models hero.
- Document the I18nT slot convention in the website README.

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: one P2 test gap left (the careers card's logo and line break are untested); every other round-1 finding is addressed

a85eef5 addresses almost everything from my last review, and CI is green at this head. The new {br} placeholder, the whyJoinTitle key and the shared createReusableTemplate card hold up in practice. Server rendering at this head gives two title cards with the logo and break in en, zh-CN and ja, with no VueUse warnings. Hydrating that HTML produces no mismatch warnings, while a control with altered text does. The only difference in server HTML from 5b9f4bb is Vue's fragment comment markers. locale:check exits 0 with nothing pending for zh-CN. The open item is inline. The careers title-card case passes with the logo or the break removed, so the description's "renamed slots in each component fail it" does not hold for WireNodeLayout.

Round-1 findings at this head
  • P2, three headings untested: addressed in a85eef5 for values, story and audience. A renamed #highlight, a keypath typo or an unwrapped highlight now each fail two rows. For WireNodeLayout, a keypath typo and a missing mobile card now fail, but the slots don't (inline).
  • P2, toHaveClass('text-white'): addressed in a85eef5. The table asserts the highlight is its own element.
  • P3, about.careers.whyTitle reuse: addressed in a85eef5 with the new whyJoinTitle key. whyTitle is gone from every catalog.
  • P3, <br> inside #logo: addressed in a85eef5 with the {br} placeholder.
  • P3, unescaped RegExp in the audience test: addressed. The table uses toBe.
  • P3, models hero brand element: addressed. Unwrapping or renaming #comfyui fails all three rows.
  • P3, FE-3069 overclaim: addressed. The description now says "Part of", names the three components still split, and the README documents the slot convention.
  • P3, test count in the description: addressed (removed).
  • P3 Nits (duplicated card, AudienceSection import order, const i18n destructure, WireNodeLayout comments): addressed in a85eef5.
  • P2, overlap with #20943: superseded. #20943 is closed.
  • P3, overlap with #20585: still open, now with specifics. #20585 adds reviewed ja copy under the split keys this PR deletes: about.careers.whyTitleBefore/After ("なぜ" … "で働くのか"), about.story.heading*, about.values.heading* and cloud.audience.heading*. This head's ja catalog holds different joined copy ("なぜ{br}{logo}に参加するのか?", and different story and values wording). Whichever merges second has to port #20585's ja wording into the joined messages. Otherwise generation prunes the split keys and the reviewed copy is lost. No ja about or careers page is live yet.
  • P3, visual baselines: unchanged and optional. No golden covers the five headings. That matters less now that the rendered DOM is unchanged.
  • Unverified, #20366 merge fit: git merge-tree of this head and #20366 conflicts in apps/website/src/i18n/translations.ts. main and #20366 merge clean. #20366 keeps translationsFor(locale) synchronous and returning a createI18n().global composer, so taking its side and dropping messages should keep :i18n="translationsFor(locale)" working. Running pnpm typecheck:website on that resolution settles it.
Checked and cleared
  • ModelsHeroSection.test.ts still builds new RegExp(`^${title}$`). Those lines are unchanged from main, and none of the titles contains a metacharacter.
  • interpolatedHeadings.test.ts sits at the src/components/ root and imports from three subfolders. That follows my round-1 request for one table across the heading components.
  • StorySection and OurValuesSection keep 12 template comments from main. The diff edits only the heading element, not the blocks those comments label.
  • DefineWhyJoinTitle adds a template root, but WireNodeLayout was already multi-root and its callers pass only declared props, so attribute fallthrough is unchanged.
Coverage

Follow-up delta review of 5b9f4bb..a85eef5 (12 files, +141/-92) by one subagent applying the correctness, maintainability and tests briefs. Run at a85eef5: vitest on both changed test files (11 pass); 12 mutation runs (logo or br slot renamed, logo span deleted, br emptied, mobile card dropped, keypath typos, renamed highlight slots, unwrapped highlight and brand); SSR renderToString plus createSSRApp hydration at both heads, with a positive control; locale:check; git merge-tree against #20366. CI at this head: 50 success, 50 skipped, none failing. The author answered every round-1 thread, so I replied in none.

Comment on lines +81 to +92
it.for([
{ locale: 'en', title: 'Why join?' },
{ locale: 'zh-CN', title: '为什么加入?' }
] as const)(
'WireNodeLayout renders the $locale title card as one message',
({ locale, title }) => {
render(WireNodeLayout, { props: { locale, reasons: [] } })

const cards = screen.getAllByText(title)
expect(cards.map((card) => card.textContent)).toEqual([title, title])
}
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: this case passes when the card loses its logo or its line break. The logo span and the <br> contribute no text, so getAllByText('Why join?') and the textContent check match either way. Each of these mutations still passes all 11 tests at this head: renaming #logo to #logoo, renaming #br to #brr, emptying the #logo slot, and emptying #br. A keypath typo and a dropped mobile card do fail. So the description's "Keypath typos and renamed slots in each component fail it" holds for values, story, audience and models but not here. The case also can't tell the joined message from a split implementation written without whitespace, so "as one message" claims more than it checks.

The logo has no accessible name either (same as main), so screen readers already read this card as "Why join?" with the brand missing. That is also why no semantic query can reach it. Giving the span role="img" and an aria-label from a new key (for example about.careers.logoLabel: "Comfy" in all three catalogs) fixes both. The case can then assert within(card).getByRole('img', { name: 'Comfy' }) for each of the two cards. The {br} slot is presentational. Either drop it from the description's claim or accept that it is untested. Prose because the fix spans WireNodeLayout.vue, three catalogs and this test.

Comment thread apps/website/README.md
Comment on lines +49 to +52
- Styled words inside a sentence are a named placeholder, never a message
split around them: `"Built for {highlight} who need quality."`, rendered with
`<I18nT keypath="…" :i18n="translationsFor(locale)">` and a `#highlight`
slot, so each locale decides where the styled word sits.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Nit: the convention covers styled words, but not the rule that fixed the careers title: an inline image or a line break is its own placeholder too, never part of another slot. Without it, the next author can bake a <br> into a slot again and lock the break for every locale. One clause and the whyJoinTitle example cover it.

Suggested change
- Styled words inside a sentence are a named placeholder, never a message
split around them: `"Built for {highlight} who need quality."`, rendered with
`<I18nT keypath="…" :i18n="translationsFor(locale)">` and a `#highlight`
slot, so each locale decides where the styled word sits.
- Styled words, inline images and line breaks inside a sentence are named
placeholders, never a message split around them: `"Built for {highlight} who
need quality."` or `"Why join{br}{logo}?"`, rendered with
`<I18nT keypath="…" :i18n="translationsFor(locale)">` and one slot per
placeholder, so each locale decides where each one sits.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: apps/website no longer exists on main. #21861 (merged 2026-10-26) removed the monorepo copy now that comfy.org deploys from Comfy-Org/comfy-website, which is also why this PR now conflicts. Could it be ported there (and this one closed)?

I did read the change at a85eef55, so here is what carries over to the port:

  • Turning the five split headings into single messages with named I18nT slots is the right fix. The {br} placeholder lets each locale place the careers line break, which addresses the earlier brand-first concern.
  • No remaining reader of the removed keys (*.headingBefore/After, about.careers.whyTitle*, models.list.heroTitleBefore/After) or of the removed titleBeforeKey/titleAfterKey props. Both split consumers (WhyJoinSection, ValuesSection) use the defaults. This matters because t() accepts any string, so typecheck would not catch a stale key.
  • TranslationKey is still MessageKey<typeof en>, so loosening the messages record type for I18nT keeps key checking for typed key props.

No blocking findings on the change itself. I would approve it in the new repo.

This branch was previously deployed

1 inactive deployment
website-approval — a85eef55 Deployed Oct 14, 2026 by benceruleanlu via fast-lane #3426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants