Repository navigation
fix(website): localize the pricing unit and Japanese models hero - #21033
Conversation
Chinese and Japanese model meta descriptions now name the pricing unit in the page language (每张图像, 画像1枚あたり) instead of the English word, and Chinese no longer drops the unit. The Japanese models hero title rendered ComfyUI twice; its name now follows the highlighted ComfyUI.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 6
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d0afe383f4c79f20617902007463929b160cd073
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21033.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-poczeq5ro-comfyui.vercel.app Last updated: 2026-10-14T21:13:16Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21033 +/- ##
==========================================
- Coverage 86.40% 86.29% -0.12%
==========================================
Files 3680 3575 -105
Lines 175372 172137 -3235
Branches 48395 47293 -1102
==========================================
- Hits 151532 148543 -2989
+ Misses 21798 21708 -90
+ Partials 2042 1886 -156
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 105 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Chinese and Japanese model meta descriptions named the pricing unit with the English word (and Chinese dropped it), and the Japanese models hero title rendered ComfyUI twice. Units now come from
workshop.model.meta.units, falling back to the raw unit when the catalog has none, and the Japanese hero puts the model name after the highlighted ComfyUI. The healedworkshop.model.meta.priceentry leavesknownViolations.Split from #20943 without its validator changes. Part of FE-2045.
Verification
model-meta-descriptionand website catalog tests pass (33), including the Chinese unit and an unnamed-unit fallback.pnpm --filter @comfyorg/website locale:check: 0 protected-token violations; the 31 pending ja strings already pend on main.