Skip to content

fix(website): localize the pricing unit and Japanese models hero - #21033

Merged
DrJKL merged 1 commit into
mainfrom
bl/website-copy-fixes
Oct 14, 2026
Merged

DrJKL merged 1 commit into
mainfrom
bl/website-copy-fixes

Conversation

@benceruleanlu

Copy link
Copy Markdown
Member

Summary

Chinese and Japanese model meta descriptions named the pricing unit with the English word (and Chinese dropped it), and the Japanese models hero title rendered ComfyUI twice. Units now come from workshop.model.meta.units, falling back to the raw unit when the catalog has none, and the Japanese hero puts the model name after the highlighted ComfyUI. The healed workshop.model.meta.price entry leaves knownViolations.

Split from #20943 without its validator changes. Part of FE-2045.

Verification

  • model-meta-description and website catalog tests pass (33), including the Chinese unit and an unnamed-unit fallback.
  • pnpm --filter @comfyorg/website locale:check: 0 protected-token violations; the 31 pending ja strings already pend on main.

Chinese and Japanese model meta descriptions now name the pricing unit in
the page language (每张图像, 画像1枚あたり) instead of the English word, and
Chinese no longer drops the unit. The Japanese models hero title rendered
ComfyUI twice; its name now follows the highlighted ComfyUI.
@benceruleanlu
benceruleanlu requested a review from a team October 14, 2026 21:11
@benceruleanlu
benceruleanlu requested review from a team and dante01yoon as code owners October 14, 2026 21:11
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T21:13:20.968592Z 861a54e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 6
  • apps/website/src/lib/workshop/model-meta-description.test.ts is excluded by !apps/website/**
  • apps/website/src/lib/workshop/model-meta-description.ts is excluded by !apps/website/**
  • apps/website/src/locales/.source-manifest.json is excluded by !apps/website/**
  • apps/website/src/locales/en/main.json is excluded by !apps/website/**
  • apps/website/src/locales/ja/main.json is excluded by !apps/website/**
  • apps/website/src/locales/zh-CN/main.json is excluded by !apps/website/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5af58b2c-e232-4fee-b07c-4e0acffd60e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since d0afe383f4c79f20617902007463929b160cd073

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21033.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-poczeq5ro-comfyui.vercel.app

Last updated: 2026-10-14T21:13:16Z for 861a54e

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #21033      +/-   ##
==========================================
- Coverage   86.40%   86.29%   -0.12%     
==========================================
  Files        3680     3575     -105     
  Lines      175372   172137    -3235     
  Branches    48395    47293    -1102     
==========================================
- Hits       151532   148543    -2989     
+ Misses      21798    21708      -90     
+ Partials     2042     1886     -156     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...website/src/lib/workshop/model-meta-description.ts 97.56% <100.00%> (+0.19%) ⬆️

... and 105 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 14, 2026
@DrJKL
DrJKL added this pull request to the merge queue Oct 14, 2026
Merged via the queue into main with commit d4c7744 Oct 14, 2026
101 checks passed
@DrJKL
DrJKL deleted the bl/website-copy-fixes branch October 14, 2026 21:41

This branch was previously deployed

1 inactive deployment
website-approval — 861a54e8 Deployed Oct 14, 2026 by benceruleanlu via fast-lane #3173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants