Repository navigation
Conversation
The unit and e2e tests for the stacked HDR viewer, preview and drop fixes, kept separate so the fixes read as product code alone.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-12T00:24:19.709Z",
"gitSha": "48153d88679b99672e56200b2e1358d35b3841ef",
"branch": "synap5e/test/exr-preview-fe-tests",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2075.648000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.535000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.939,
"heapDeltaBytes": -49306496,
"heapUsedBytes": 60391980,
"domNodes": -212,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 11.716000000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666400000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.4029999999211,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.256,
"heapDeltaBytes": 8860116,
"heapUsedBytes": 73491272,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.781,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1794.085999999993,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.084000000000003,
"layouts": 12,
"layoutDurationMs": 4.617,
"taskDurationMs": 856.2330000000001,
"heapDeltaBytes": 4350244,
"heapUsedBytes": 68972156,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.90099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.3830000000844,
"styleRecalcs": 56,
"styleRecalcDurationMs": 14.068000000000003,
"layouts": 12,
"layoutDurationMs": 4.433000000000001,
"taskDurationMs": 805.1089999999999,
"heapDeltaBytes": 3667212,
"heapUsedBytes": 65825960,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.154,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.227000000014,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.42,
"layouts": 3,
"layoutDurationMs": 1.0849999999999997,
"taskDurationMs": 354.95199999999994,
"heapDeltaBytes": -48830492,
"heapUsedBytes": 61642828,
"domNodes": -167,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 12.336,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.32599999999,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.377000000000001,
"layouts": 3,
"layoutDurationMs": 0.8099999999999999,
"taskDurationMs": 386.0060000000001,
"heapDeltaBytes": 13121428,
"heapUsedBytes": 84315668,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.134000000000007,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 636.5690000000086,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.354000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.958,
"heapDeltaBytes": -3724904,
"heapUsedBytes": 66840896,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 168.354,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 677.3369999999659,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.863,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.85600000000005,
"heapDeltaBytes": -2704104,
"heapUsedBytes": 68326572,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 172.159,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1148.635000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 808.5899999999999,
"heapDeltaBytes": 24181604,
"heapUsedBytes": 110293804,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 71.31800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 519,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1174.7870000000376,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 844.108,
"heapDeltaBytes": 15961964,
"heapUsedBytes": 98688496,
"domNodes": 0,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 70.736,
"eventListeners": 0,
"totalBlockingTimeMs": 541,
"frameDurationMs": 35.351515151515166,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.6740000000173,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.1289999999998,
"heapDeltaBytes": 20871792,
"heapUsedBytes": 104535716,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.87800000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 24.762857142857165,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.6540000000541,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.95100000000014,
"heapDeltaBytes": 19549528,
"heapUsedBytes": 104523652,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 168.84700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.538888888888877,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10689.607999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9726.432,
"heapDeltaBytes": -1656732,
"heapUsedBytes": 82730432,
"domNodes": 0,
"jsHeapTotalBytes": -20185088,
"scriptDurationMs": 7921.082,
"eventListeners": 0,
"totalBlockingTimeMs": 1314,
"frameDurationMs": 32.17740963855422,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10462.18399999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9547.921,
"heapDeltaBytes": -6926952,
"heapUsedBytes": 76515876,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 8209.456,
"eventListeners": 0,
"totalBlockingTimeMs": 1346,
"frameDurationMs": 32.15261538461539,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9384.498000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8532.627999999999,
"heapDeltaBytes": -389376,
"heapUsedBytes": 82865672,
"domNodes": 0,
"jsHeapTotalBytes": -21233664,
"scriptDurationMs": 7213.066000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 765,
"frameDurationMs": 32.355172413793106,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9767.568999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8946.778,
"heapDeltaBytes": 13544188,
"heapUsedBytes": 86315588,
"domNodes": -141,
"jsHeapTotalBytes": -9048064,
"scriptDurationMs": 7287.587,
"eventListeners": -65,
"totalBlockingTimeMs": 787,
"frameDurationMs": 31.202236421725242,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 221.11400000000003,
"styleRecalcs": 24,
"styleRecalcDurationMs": 17.29,
"layouts": 5,
"layoutDurationMs": 2.083,
"taskDurationMs": 165.07699999999997,
"heapDeltaBytes": 12230168,
"heapUsedBytes": 78174988,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.615,
"eventListeners": 202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 216.542000000004,
"styleRecalcs": 24,
"styleRecalcDurationMs": 17.999000000000002,
"layouts": 5,
"layoutDurationMs": 2.019,
"taskDurationMs": 157.787,
"heapDeltaBytes": -11047340,
"heapUsedBytes": 76333844,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.798,
"eventListeners": 202,
"totalBlockingTimeMs": 3,
"frameDurationMs": 24.066666666666706,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2007.255999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.9509999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.3929999999999,
"heapDeltaBytes": 809720,
"heapUsedBytes": 83746180,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 41.003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2024.167000000034,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7440000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.3119999999999,
"heapDeltaBytes": 885604,
"heapUsedBytes": 84158972,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 38.516999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2427.948000000015,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.588000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1654.703,
"heapDeltaBytes": 687852,
"heapUsedBytes": 85168576,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 844.0699999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.781379310344835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2442.678000000001,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.8950000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1625.232,
"heapDeltaBytes": -9541936,
"heapUsedBytes": 71583956,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 832.041,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780136986301372,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3761.727999999948,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.700000000000001,
"layouts": 60,
"layoutDurationMs": 16.526,
"taskDurationMs": 1776.1529999999998,
"heapDeltaBytes": -9547768,
"heapUsedBytes": 74120872,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 829.497,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665929203539818,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3502.2480000000087,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.864,
"layouts": 60,
"layoutDurationMs": 15.266000000000002,
"taskDurationMs": 1642.4120000000003,
"heapDeltaBytes": 8704360,
"heapUsedBytes": 75715656,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 746.838,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66619047619048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3098.8009999999804,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.267999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1955.587,
"heapDeltaBytes": -245656,
"heapUsedBytes": 88251588,
"domNodes": 0,
"jsHeapTotalBytes": 1241088,
"scriptDurationMs": 999.3860000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846739130434784,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2923.347000000035,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.026000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1886.2779999999998,
"heapDeltaBytes": -488176,
"heapUsedBytes": 87830592,
"domNodes": 0,
"jsHeapTotalBytes": 978944,
"scriptDurationMs": 963.3320000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761142857142858,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2012.6980000000003,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.4339999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.7109999999999,
"heapDeltaBytes": 627096,
"heapUsedBytes": 86974384,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.00899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.225999999956,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.2830000000001,
"heapDeltaBytes": 23163452,
"heapUsedBytes": 89077256,
"domNodes": -308,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.451,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.360999999973,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.664999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.712,
"heapDeltaBytes": -8784888,
"heapUsedBytes": 64130768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.256,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.0440000000253,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.406999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.097,
"heapDeltaBytes": 14203608,
"heapUsedBytes": 80949828,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 148.398,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.6559999999736,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.360000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.278,
"heapDeltaBytes": 9595696,
"heapUsedBytes": 76960736,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.984,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.488999999974,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.255,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.7049999999999,
"heapDeltaBytes": 9572256,
"heapUsedBytes": 76323276,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.936000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.9250000000138,
"styleRecalcs": 79,
"styleRecalcDurationMs": 16.95,
"layouts": 16,
"layoutDurationMs": 6.654999999999999,
"taskDurationMs": 858.126,
"heapDeltaBytes": -11003784,
"heapUsedBytes": 81152396,
"domNodes": -230,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 109.41899999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1765.942999999993,
"styleRecalcs": 60,
"styleRecalcDurationMs": 18.19,
"layouts": 16,
"layoutDurationMs": 6.552,
"taskDurationMs": 888.753,
"heapDeltaBytes": -11173360,
"heapUsedBytes": 80690956,
"domNodes": -230,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 111.574,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7029999999977,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.955999999999996,
"layouts": 6,
"layoutDurationMs": 14.424,
"taskDurationMs": 941.206,
"heapDeltaBytes": 33957704,
"heapUsedBytes": 114677196,
"domNodes": 14650,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 30.51100000000001,
"eventListeners": 2456,
"totalBlockingTimeMs": 129,
"frameDurationMs": 19.4054794520548,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8256.387000000017,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.655,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5173.474999999999,
"heapDeltaBytes": 2802080,
"heapUsedBytes": 83598336,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2789.114,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9537.904000000026,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.193999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5817.813999999999,
"heapDeltaBytes": -20081348,
"heapUsedBytes": 71954308,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2725.7039999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666024518388795,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17680.165999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16956.697,
"heapDeltaBytes": -44275132,
"heapUsedBytes": 185593144,
"domNodes": -3046,
"jsHeapTotalBytes": 9617408,
"scriptDurationMs": 262.052,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.869256756756755,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 18178.892000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17329.001,
"heapDeltaBytes": -46747776,
"heapUsedBytes": 183332944,
"domNodes": -3046,
"jsHeapTotalBytes": 7520256,
"scriptDurationMs": 296.587,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.87028862478778,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 22705.709000000013,
"styleRecalcs": 176,
"styleRecalcDurationMs": 15.793000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22203.54,
"heapDeltaBytes": -26738740,
"heapUsedBytes": 189725140,
"domNodes": -3046,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 899.9240000000001,
"eventListeners": -14913,
"totalBlockingTimeMs": 8,
"frameDurationMs": 42.538764044943825,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23038.005999999994,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.671000000000019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22676.407000000003,
"heapDeltaBytes": -36066632,
"heapUsedBytes": 189523612,
"domNodes": -3046,
"jsHeapTotalBytes": 1679360,
"scriptDurationMs": 964.1610000000001,
"eventListeners": -14913,
"totalBlockingTimeMs": 47,
"frameDurationMs": 42.762708719851574,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6619.925000000023,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.00399999999999,
"layouts": 20,
"layoutDurationMs": 23.883000000000003,
"taskDurationMs": 6485.92,
"heapDeltaBytes": 1064156,
"heapUsedBytes": 218140292,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 109.778,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.1551912568306,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6426.706000000081,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.28400000000002,
"layouts": 20,
"layoutDurationMs": 22.842000000000002,
"taskDurationMs": 6316.56,
"heapDeltaBytes": -13465952,
"heapUsedBytes": 216072952,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 102.41999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.52155688622756,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9364.158999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8914.22,
"heapDeltaBytes": -20531636,
"heapUsedBytes": 196893892,
"domNodes": -3046,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 147.25499999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.966894197952215,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9480.060999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8991.048,
"heapDeltaBytes": -35899372,
"heapUsedBytes": 182913208,
"domNodes": -3046,
"jsHeapTotalBytes": 3837952,
"scriptDurationMs": 136.33599999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.5872852233677,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 528.4940000000233,
"styleRecalcs": 22,
"styleRecalcDurationMs": 21.444000000000003,
"layouts": 5,
"layoutDurationMs": 2.5260000000000007,
"taskDurationMs": 237.53000000000003,
"heapDeltaBytes": -50084600,
"heapUsedBytes": 58417012,
"domNodes": -100,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 17.279999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 499.8679999999922,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.946,
"layouts": 4,
"layoutDurationMs": 1.8190000000000002,
"taskDurationMs": 212.238,
"heapDeltaBytes": -49684132,
"heapUsedBytes": 58392776,
"domNodes": -103,
"jsHeapTotalBytes": -4980736,
"scriptDurationMs": 10.588000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 873.5699999999724,
"styleRecalcs": 77,
"styleRecalcDurationMs": 89.768,
"layouts": 76,
"layoutDurationMs": 25.005,
"taskDurationMs": 840.9830000000001,
"heapDeltaBytes": -6979632,
"heapUsedBytes": 71416792,
"domNodes": 77,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 347.23900000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 869.4289999999683,
"styleRecalcs": 77,
"styleRecalcDurationMs": 89.444,
"layouts": 76,
"layoutDurationMs": 25.413,
"taskDurationMs": 840.763,
"heapDeltaBytes": 18227988,
"heapUsedBytes": 90650088,
"domNodes": 77,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 340.919,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1417.0080000000098,
"styleRecalcs": 77,
"styleRecalcDurationMs": 253.289,
"layouts": 76,
"layoutDurationMs": 29.19,
"taskDurationMs": 1398.858,
"heapDeltaBytes": -19323392,
"heapUsedBytes": 118512332,
"domNodes": 77,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 490.682,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.141772151898742,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1406.808999999953,
"styleRecalcs": 77,
"styleRecalcDurationMs": 248.581,
"layouts": 76,
"layoutDurationMs": 28.473,
"taskDurationMs": 1387.956,
"heapDeltaBytes": 10334772,
"heapUsedBytes": 123435848,
"domNodes": 77,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 480.554,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.707500000000003,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2250 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 67e3f7171a3a8169af47adf5a0529e91ca7545df
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## synap5e/fix/exr-preview-fe #20809 +/- ##
==============================================================
+ Coverage 86.59% 86.74% +0.15%
==============================================================
Files 2539 2542 +3
Lines 143875 143972 +97
Branches 37800 37800
==============================================================
+ Hits 124589 124891 +302
+ Misses 18899 18695 -204
+ Partials 387 386 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a44016f92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function hdrViewer(comfyPage: ComfyPage) { | ||
| return comfyPage.page.getByRole('dialog').filter({ hasText: 'sky.exr' }) | ||
| } | ||
|
|
||
| async function expectHdrViewerLoaded(comfyPage: ComfyPage) { |
There was a problem hiding this comment.
Move HDR viewer wiring into a page object
Move hdrViewer and expectHdrViewerLoaded into the browser fixture/page-object layer. The scoped browser-test conventions require spec files to contain only tests, hooks, configuration, and imports, with reusable locator and assertion wiring owned by a page object; keeping the dialog locator and readiness contract here duplicates UI knowledge and will make this coverage diverge when the viewer markup changes.
AGENTS.md reference: browser_tests/AGENTS.md:L3-L8
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Taken: the dialog locator and the decoded-and-alone check now live in an HdrViewerDialog page object under fixtures/components/ (2acc664).
|
Closing along with #20781, which these tests covered. The tests that still apply will move to the fresh PR on main, alongside the fixes they cover. |
Tests for #20781, split out so that PR shows only the product changes. Stacked on its branch; this PR adds no product code.
browser_tests/tests/sidebar/hdrOutputViewer.spec.tshdrViewerService,HdrViewerContent,useHdrVieweruseResultGalleryAssetsSidebarTab,MediaAssetCard,loaderNodeUtilfe-previewtag and list exclusionhdrPreviewGeneration,attachPreview,useAssetsQuerypreview_id; previews matched by asset id in the node preview, job row and Download Assets dialogassetMappers,outputAssetUtil,useGeneratedPreviewLookup,ImagePreview,JobAssetsList,useNodeOutputsExport,NodeOutputsExportDialog.exr/.hdrdrops typed as imageseventUtils,useNodeDragAndDrop