Repository navigation
Conversation
- Open the HDR viewer by asset id and keep the filename for loader, title and download - Stop scaling gain-map thumbnail bases by an auto-exposure - Label client-uploaded previews and leave them out of asset lists - Let one tab generate a preview per asset and skip assets that gained one meanwhile - Route HDR outputs from the job queue, asset double click and Inspect to the HDR viewer - Keep a stacked output's preview id so its preview shows - Offer HDR assets as Load Image nodes - Type untyped .exr/.hdr drops by extension
- A tab that finds another tab generating a preview now waits for it and picks up that preview instead of keeping a placeholder - Opening an HDR output supersedes a gallery that is still loading another job - Test the granted-lock path, filename forwarding into the HDR loader, and that the e2e viewer actually finishes decoding
A job whose last output is HDR now opens the gallery on its other outputs; only a job with nothing but HDR outputs opens the HDR viewer. Resolving the outputs first also lets the existing request supersede replace the local view token. Tests pin the by-id viewer URL in assets mode and a failed asset lookup.
The duplicate-preview checks are best effort: if the asset lookup fails, generate the preview rather than leave the asset without one.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 Walkthrough
|
Follow-up fixes for the EXR/HDR preview work in #19710, stacked on its branch. They fix problems found by testing that branch end to end against a backend that generates HDR previews: HDR files that open the wrong URL or the image lightbox instead of the HDR viewer, HDR assets missing actions or previews in some asset-panel views, client-generated thumbnails that look too dark, those thumbnails showing up as the user's own outputs, duplicate thumbnails when several tabs are open, and HDR files dropped from the OS with no MIME type not being recognised as images.
/api/viewwithout the subfolder (or withtype=outputfor an input) and got 404/api/assets/<id>/content) and uses the asset's filename to pick the loader, title and download name<img>shows; scenes brighter than 1.0 rendered several times too darkfe-previewtag, which the asset panel and widget lists exclude (tags_none).hdrproduced a single previewpreview_id, so the preview shows.exrwith an empty MIME type (canvas or node) showed "Unable to find workflow".exr/.hdrfiles are typedimage/x-exr/image/vnd.radianceby extension/api/view?...&preview=webpthumbnail request fails for EXR)Tests: #20809
Known limitations:
fe-previewtag and stay visible; client previews are stored underoutput/.