Repository navigation
ci: run the server-fact gate inside the lint job - #20759
Conversation
The standalone server-facts job spent 80-120 s of runner time to run a 1 s check: a full-history clone (~46 s) and its own setup and install. Run it as a step in the lint job, which already has node_modules, and check out with a blobless full history so merge-base still resolves. Amp-Thread-ID: https://ampcode.com/threads/T-3ccbfb7b-6a44-46b2-b77c-661380842fcc
📦 Bundle: 9.36 MB gzip 🔴 +2 BDetailsSummary
Category Glance App Entry Points — 4.87 kB (baseline 4.87 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 54.3 kB (baseline 54.3 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 14 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 211 kB (baseline 211 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 3.07 MB (baseline 3.07 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 22 unchanged Utilities & Hooks — 822 kB (baseline 822 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 55 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.8 MB (baseline 18.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 346 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-11T00:50:36.601Z",
"gitSha": "f0a6e357ead9a6542de915c664adb3e26ed37503",
"branch": "ci/fold-server-facts-into-lint",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2012.8139999999917,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.439,
"layouts": 7,
"layoutDurationMs": 1.9319999999999997,
"taskDurationMs": 482.96100000000007,
"heapDeltaBytes": 15752408,
"heapUsedBytes": 73422292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.170000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.7429999999813,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.5899999999999985,
"layouts": 6,
"layoutDurationMs": 1.686,
"taskDurationMs": 485.33200000000005,
"heapDeltaBytes": 15770716,
"heapUsedBytes": 73377752,
"domNodes": -162,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.273,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.6990000000078,
"styleRecalcs": 53,
"styleRecalcDurationMs": 13.902,
"layouts": 8,
"layoutDurationMs": 2.0000000000000004,
"taskDurationMs": 896.494,
"heapDeltaBytes": -24231936,
"heapUsedBytes": 65423132,
"domNodes": -162,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 159.22799999999998,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.9210000000803,
"styleRecalcs": 79,
"styleRecalcDurationMs": 21.675,
"layouts": 10,
"layoutDurationMs": 3.0810000000000004,
"taskDurationMs": 936.2109999999999,
"heapDeltaBytes": -24256880,
"heapUsedBytes": 65035164,
"domNodes": -162,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 166.25,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.7340000000318,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.9940000000000015,
"layouts": 14,
"layoutDurationMs": 4.401999999999999,
"taskDurationMs": 406.454,
"heapDeltaBytes": -1587192,
"heapUsedBytes": 102905740,
"domNodes": 47,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 11.643,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1765.3929999999036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 9.922,
"layouts": 14,
"layoutDurationMs": 5.7,
"taskDurationMs": 478.723,
"heapDeltaBytes": -20463252,
"heapUsedBytes": 68429048,
"domNodes": -115,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 13.386000000000003,
"eventListeners": -31,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 658.8390000000004,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.638999999999999,
"layouts": 7,
"layoutDurationMs": 1.9500000000000004,
"taskDurationMs": 464.09499999999997,
"heapDeltaBytes": 22202828,
"heapUsedBytes": 80529336,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.87099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 717.8889999999001,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.298,
"layouts": 9,
"layoutDurationMs": 2.942,
"taskDurationMs": 535.1179999999999,
"heapDeltaBytes": -29804796,
"heapUsedBytes": 75493360,
"domNodes": -162,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 182.62,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1168.756999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 799.776,
"heapDeltaBytes": 18444188,
"heapUsedBytes": 101059204,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 67.47299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 541,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1146.408000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 832.485,
"heapDeltaBytes": 12717460,
"heapUsedBytes": 94187204,
"domNodes": 0,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 63.69799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 519,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.0540000000378,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.6419999999998,
"heapDeltaBytes": 23158176,
"heapUsedBytes": 97120204,
"domNodes": 0,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 164.98799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.5140000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.2539999999996,
"heapDeltaBytes": -10177824,
"heapUsedBytes": 82587872,
"domNodes": 0,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 162.28499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10699.055000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9723.107,
"heapDeltaBytes": 3167248,
"heapUsedBytes": 87969236,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 7887.048,
"eventListeners": 0,
"totalBlockingTimeMs": 1060,
"frameDurationMs": 31.194169096209915,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11206.28499999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10383.238000000001,
"heapDeltaBytes": -5459796,
"heapUsedBytes": 78690396,
"domNodes": 0,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 8570.594,
"eventListeners": 0,
"totalBlockingTimeMs": 1496,
"frameDurationMs": 32.18247126436781,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8943.857999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8146.307999999999,
"heapDeltaBytes": -13846400,
"heapUsedBytes": 70586716,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 6833.5419999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 649,
"frameDurationMs": 32.309386281588445,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10245.667000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9445.158000000001,
"heapDeltaBytes": 10822528,
"heapUsedBytes": 95285672,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 7694.483,
"eventListeners": 0,
"totalBlockingTimeMs": 1024,
"frameDurationMs": 31.24878048780488,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 222.9199999999878,
"styleRecalcs": 24,
"styleRecalcDurationMs": 17.339,
"layouts": 12,
"layoutDurationMs": 3.873,
"taskDurationMs": 169.46399999999997,
"heapDeltaBytes": 12905180,
"heapUsedBytes": 84049232,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.647000000000002,
"eventListeners": 195,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.077777777777857,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 227.0210000000361,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.899000000000003,
"layouts": 11,
"layoutDurationMs": 3.124,
"taskDurationMs": 165.49699999999999,
"heapDeltaBytes": 12886440,
"heapUsedBytes": 82327828,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.546,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090843,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2050.9229999999548,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8140000000000005,
"layouts": 8,
"layoutDurationMs": 2.266,
"taskDurationMs": 599.6899999999999,
"heapDeltaBytes": -57291860,
"heapUsedBytes": 70573012,
"domNodes": -258,
"jsHeapTotalBytes": -4554752,
"scriptDurationMs": 32.542,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2056.5290000000687,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.9010000000000007,
"layouts": 7,
"layoutDurationMs": 1.9569999999999996,
"taskDurationMs": 613.953,
"heapDeltaBytes": -57896568,
"heapUsedBytes": 70362236,
"domNodes": -278,
"jsHeapTotalBytes": -5341184,
"scriptDurationMs": 36.36000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2339.364000000046,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.811000000000002,
"layouts": 5,
"layoutDurationMs": 1.243,
"taskDurationMs": 1585.865,
"heapDeltaBytes": 695484,
"heapUsedBytes": 67053304,
"domNodes": -258,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 792.052,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7863309352518,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2361.0800000000154,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.439,
"layouts": 7,
"layoutDurationMs": 1.7049999999999998,
"taskDurationMs": 1632.3220000000003,
"heapDeltaBytes": 1205388,
"heapUsedBytes": 67374400,
"domNodes": -258,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 816.6600000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.785000000000004,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3641.5949999999953,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.633000000000002,
"layouts": 63,
"layoutDurationMs": 9.738,
"taskDurationMs": 1697.14,
"heapDeltaBytes": 22307204,
"heapUsedBytes": 90594600,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 778.203,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666513761467893,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3649.270999999999,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.112,
"layouts": 63,
"layoutDurationMs": 10.477,
"taskDurationMs": 1737.069,
"heapDeltaBytes": -22420172,
"heapUsedBytes": 87236820,
"domNodes": -234,
"jsHeapTotalBytes": -1708032,
"scriptDurationMs": 772.791,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3158.2820000000424,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.497000000000001,
"layouts": 4,
"layoutDurationMs": 0.9399999999999998,
"taskDurationMs": 1958.5359999999998,
"heapDeltaBytes": 6197772,
"heapUsedBytes": 74717452,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 997.8380000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.934946236559142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3074.196000000029,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.204,
"layouts": 3,
"layoutDurationMs": 0.941,
"taskDurationMs": 1957.3220000000001,
"heapDeltaBytes": 3057244,
"heapUsedBytes": 71974512,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 968.7260000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.848901098901106,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.5039999999894,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.0469999999999993,
"layouts": 7,
"layoutDurationMs": 1.9620000000000002,
"taskDurationMs": 594.6259999999999,
"heapDeltaBytes": -59036772,
"heapUsedBytes": 70770264,
"domNodes": -258,
"jsHeapTotalBytes": -2719744,
"scriptDurationMs": 32.52499999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.3979999999347,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.418,
"layouts": 6,
"layoutDurationMs": 1.5330000000000006,
"taskDurationMs": 604.2429999999999,
"heapDeltaBytes": -38317080,
"heapUsedBytes": 71588088,
"domNodes": -278,
"jsHeapTotalBytes": -4329472,
"scriptDurationMs": 32.08699999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 602.5210000000243,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.3420000000000005,
"layouts": 11,
"layoutDurationMs": 2.962,
"taskDurationMs": 446.878,
"heapDeltaBytes": -18500004,
"heapUsedBytes": 72795020,
"domNodes": -180,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 153.721,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 632.2199999999611,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.3100000000000005,
"layouts": 12,
"layoutDurationMs": 3.1180000000000003,
"taskDurationMs": 493.78600000000006,
"heapDeltaBytes": -36438488,
"heapUsedBytes": 70432436,
"domNodes": -180,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 148.18,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2056.869000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.101000000000001,
"layouts": 10,
"layoutDurationMs": 2.578,
"taskDurationMs": 544.788,
"heapDeltaBytes": -36370024,
"heapUsedBytes": 70671008,
"domNodes": -180,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.979000000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2056.338000000096,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.593,
"layouts": 10,
"layoutDurationMs": 4.798,
"taskDurationMs": 543.1779999999999,
"heapDeltaBytes": -18920940,
"heapUsedBytes": 71460664,
"domNodes": -180,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 9.503999999999998,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1697.7559999999698,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.546,
"layouts": 8,
"layoutDurationMs": 1.849,
"taskDurationMs": 659.645,
"heapDeltaBytes": 5766000,
"heapUsedBytes": 63476888,
"domNodes": -180,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.83900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.1800000000185,
"styleRecalcs": 79,
"styleRecalcDurationMs": 18.813999999999997,
"layouts": 10,
"layoutDurationMs": 3.2840000000000003,
"taskDurationMs": 709.769,
"heapDeltaBytes": -29699480,
"heapUsedBytes": 62576608,
"domNodes": -180,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 111.63800000000002,
"eventListeners": -108,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1251.42900000003,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.935,
"layouts": 5,
"layoutDurationMs": 16.727000000000004,
"taskDurationMs": 878.1990000000002,
"heapDeltaBytes": 35808556,
"heapUsedBytes": 123192896,
"domNodes": 15956,
"jsHeapTotalBytes": 13504512,
"scriptDurationMs": 31.16100000000001,
"eventListeners": 3244,
"totalBlockingTimeMs": 169,
"frameDurationMs": 20.430645161290336,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9101.18399999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.168,
"layouts": 8,
"layoutDurationMs": 2.5530000000000004,
"taskDurationMs": 5851.164,
"heapDeltaBytes": -49026996,
"heapUsedBytes": 78577888,
"domNodes": -258,
"jsHeapTotalBytes": -2789376,
"scriptDurationMs": 2711.4590000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758195211786372,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9385.467000000062,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.805,
"layouts": 7,
"layoutDurationMs": 1.951,
"taskDurationMs": 5931.5,
"heapDeltaBytes": -24810928,
"heapUsedBytes": 82183312,
"domNodes": -258,
"jsHeapTotalBytes": -2039808,
"scriptDurationMs": 2744.217,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755178571428573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 24128.915000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23192.825,
"heapDeltaBytes": 1399840,
"heapUsedBytes": 289325072,
"domNodes": -3232,
"jsHeapTotalBytes": 28311552,
"scriptDurationMs": 336.27899999999994,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.65060449050087,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24194.882000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23304.294,
"heapDeltaBytes": -10083120,
"heapUsedBytes": 275555860,
"domNodes": -3232,
"jsHeapTotalBytes": 16953344,
"scriptDurationMs": 336.122,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.01215277777778,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28685.459999999977,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.16200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28249.874000000003,
"heapDeltaBytes": -41230996,
"heapUsedBytes": 251572456,
"domNodes": -3232,
"jsHeapTotalBytes": 18350080,
"scriptDurationMs": 975.206,
"eventListeners": -651,
"totalBlockingTimeMs": 92,
"frameDurationMs": 53.01700554528651,
"p95FrameDurationMs": 100.10000000000582
},
{
"name": "vue-large-graph-pan",
"durationMs": 29057.344000000056,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.252000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28658.633,
"heapDeltaBytes": -16269196,
"heapUsedBytes": 273585656,
"domNodes": -3036,
"jsHeapTotalBytes": 9625600,
"scriptDurationMs": 985.425,
"eventListeners": -648,
"totalBlockingTimeMs": 4,
"frameDurationMs": 53.82500000000001,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8407.075999999961,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.53199999999998,
"layouts": 20,
"layoutDurationMs": 22.87399999999999,
"taskDurationMs": 8307.81,
"heapDeltaBytes": 5842468,
"heapUsedBytes": 305378060,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 126.616,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.397005988023956,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8399.091999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.58000000000004,
"layouts": 20,
"layoutDurationMs": 22.52799999999999,
"taskDurationMs": 8249.295,
"heapDeltaBytes": 14740900,
"heapUsedBytes": 304538336,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 130.252,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.40941176470587,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12127.61499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11801.351,
"heapDeltaBytes": -23822256,
"heapUsedBytes": 260973424,
"domNodes": -209,
"jsHeapTotalBytes": 19738624,
"scriptDurationMs": 172.15900000000002,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.63676975945018,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8666.621999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8356.802,
"heapDeltaBytes": -26179036,
"heapUsedBytes": 276395496,
"domNodes": -3232,
"jsHeapTotalBytes": 22433792,
"scriptDurationMs": 138.68600000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.22162162162163,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 528.2059999999547,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.324,
"layouts": 11,
"layoutDurationMs": 4.350999999999999,
"taskDurationMs": 187.24200000000002,
"heapDeltaBytes": -28404748,
"heapUsedBytes": 62566564,
"domNodes": -60,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 15.404,
"eventListeners": -63,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 470.12099999994916,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.848999999999998,
"layouts": 12,
"layoutDurationMs": 4.2139999999999995,
"taskDurationMs": 195.47,
"heapDeltaBytes": -45157872,
"heapUsedBytes": 57393612,
"domNodes": -101,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.543000000000001,
"eventListeners": -63,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 567.2439999999597,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.304,
"layouts": 76,
"layoutDurationMs": 15.396,
"taskDurationMs": 517.678,
"heapDeltaBytes": -12018388,
"heapUsedBytes": 80345972,
"domNodes": 4,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 248.204,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 490.96799999995255,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.021,
"layouts": 76,
"layoutDurationMs": 14.535,
"taskDurationMs": 437.365,
"heapDeltaBytes": -12791332,
"heapUsedBytes": 79549512,
"domNodes": 4,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 205.458,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 602.025000000026,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.263,
"layouts": 76,
"layoutDurationMs": 15.056999999999999,
"taskDurationMs": 563.4939999999999,
"heapDeltaBytes": 559292,
"heapUsedBytes": 121215828,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 222.64899999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 674.808999999982,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.127,
"layouts": 76,
"layoutDurationMs": 15.713999999999999,
"taskDurationMs": 613.668,
"heapDeltaBytes": 903252,
"heapUsedBytes": 121865028,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 243.335,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.082500000000003,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2255 passed, 0 failed · 2 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 35d80236390f9aba4409f5b28b4e0966c9c0b830
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20759 +/- ##
==========================================
+ Coverage 86.05% 86.85% +0.79%
==========================================
Files 3631 2581 -1050
Lines 173457 145244 -28213
Branches 47843 39805 -8038
==========================================
- Hits 149273 126153 -23120
+ Misses 22176 18705 -3471
+ Partials 2008 386 -1622
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head review: 7112ad0 against base 35d8023. The workflow-only change keeps pull-request and merge-queue base selection distinct, runs server-facts after setup/lint formatting, preserves the required lint-and-format gate, and keeps the existing cache save path. Independent required CI is green; no actionable findings.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
Panel: 6/6 reviewers contributed findings.
| if: hashFiles('tools/architecture/src/cli.ts') != '' | ||
| run: pnpm architecture:check | ||
|
|
||
| - name: Check server facts on changed lines |
There was a problem hiding this comment.
🟡 Medium — The server-facts step now sits after the ESLint, Stylelint and oxfmt auto-fix steps but before Check for changes, Commit changes, the fork-error step and the PR comment. None of those later steps use !cancelled()/always(), so any server-fact finding fails the job and throws away the auto-fix commit for same-repo PRs. Fork authors also lose the "unfixed lint/format issues" message. When this was its own job, it could not block auto-fixes. Restore it as a separate job, or run it after the commit/fork steps with an if: ${{ !cancelled() }} guard. Raised by 3 of 6 reviewers (claude-opus-5-5-xhigh adversarial, claude-opus-5-5-xhigh edge-case, kimi-k3-high edge-case).
| - name: Check server facts on changed lines | ||
| env: | ||
| BASE_SHA: ${{ github.event.pull_request.base.sha }} | ||
| run: pnpm lint:server-facts --base "$BASE_SHA" |
There was a problem hiding this comment.
🟢 Low — By the time lint:server-facts --base runs, lint:fix:ci, stylelint:fix and oxfmt have already rewritten the working tree. The changed-line ranges and file contents it checks can therefore differ from the PR commit. Lines touched only by the fixers may be flagged, reported line numbers may not match the pushed code, and a reformat can move a violation outside the diffed range. The merge-queue run still runs on a clean checkout, which limits the impact. Fix this by running the gate on the unmodified checkout (as its own job, or before the fixers) or after the fix commit, when HEAD matches the working tree. Raised by 2 of 6 reviewers (gpt-5.6-sol-xhigh adversarial, claude-opus-5-5-xhigh edge-case).
|
|
||
| # Push runs gate the pushed range; a branch-creation push has no base. | ||
| - name: Check server facts on changed lines | ||
| if: ${{ (github.event.merge_group.base_sha || github.event.before) != '0000000000000000000000000000000000000000' }} |
There was a problem hiding this comment.
🟢 Low — Moving the server-facts check into the lint job means it is skipped whenever pnpm lint:ci or format:check fails earlier in the job. Merge-queue and push runs then report no server-fact violations until the other failures are fixed and the PR is requeued. The gate still fails closed, but the independent signal is gone. The PR workflow has the same problem when an earlier fixer step exits non-zero. Prefix the existing condition with !cancelled() && to keep it running regardless of earlier lint failures. Raised by 3 of 6 reviewers (claude-opus-5-5-xhigh adversarial, claude-opus-5-5-xhigh edge-case, kimi-k3-high edge-case).
…mfy-Org#20760) ## Summary Comfy-Org#20679 registered `no-capability-recombination` and `no-server-fact-literals` in the shared `comfy` plugin. `.oxlintrc.json` never enables them; only `pnpm lint:server-facts` does, through `serverFacts.oxlintrc.json`. This PR exports a plugin from `serverFacts.ts` and points that config at it. The main run no longer carries the two rules, and the gate no longer loads every `comfy` rule module. Rule IDs stay `comfy/*`, so disable directives and the write hook's rule matching are unchanged. The new default export is only reached from config, so knip and fallow are told about it the same way as the other plugin files. This is a cleanup, not a speedup. With the rules registered, `oxlint . --type-aware` took 38-49 s at 4.6-4.7 GB peak; with them removed, 41-44 s at 4.6-5.3 GB, which is within noise. The CI cost of the gate is addressed separately in Comfy-Org#20759. ## Verification - `pnpm test:unit tools/oxlint-plugins scripts/hooks scripts/server-fact-gate.test.ts`: 15 files, 276 tests pass. - `pnpm lint:server-facts --base HEAD~30` still reports the two existing `useBillingDialogs.ts` findings through the new plugin entry. - `pnpm knip`, the fallow pre-push audit, and `pnpm typecheck:tools` pass. https://ampcode.com/threads/T-3ccbfb7b-6a44-46b2-b77c-661380842fcc
Summary
The
server-factsjob added in #20679 spends 80-120 s of runner time to run a check that takes about 1 s: about 46 s goes to a full-history clone (fetch-depth: 0) and about 30 s to its own setup andpnpm install. This PR runspnpm lint:server-factsas a step in the existinglintjob of both lint workflows. Those jobs now check out the full history without file contents (filter: blob:none), sogit merge-basestill resolves the base.server-factswas not a required context. Branch protection requireslint-and-format, which still covers the step through thelintjob.Verification
actionlintandoxfmt --checkpass on both workflows..git).pnpm lint:server-facts --base HEAD~30in a fresh blobless clone finishes in 2.2 s, including merge-base, diff, and lint. Git fetches the changed files' contents in one batch.https://ampcode.com/threads/T-3ccbfb7b-6a44-46b2-b77c-661380842fcc