Repository navigation
refactor: load the server-fact rules from their own oxlint plugin - #20760
Conversation
The shared comfy plugin registered no-capability-recombination and no-server-fact-literals although .oxlintrc.json never enables them; only the changed-line gate does, through serverFacts.oxlintrc.json. Export the plugin from serverFacts.ts and point that config at it, so the main run no longer carries the rules and the gate no longer loads every comfy rule module. Rule IDs stay comfy/*, so existing disable directives still match. Amp-Thread-ID: https://ampcode.com/threads/T-3ccbfb7b-6a44-46b2-b77c-661380842fcc
📦 Bundle: 9.36 MB gzip 🔴 +2 BDetailsSummary
Category Glance App Entry Points — 4.87 kB (baseline 4.87 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 54.3 kB (baseline 54.3 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 14 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 211 kB (baseline 211 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 3.07 MB (baseline 3.07 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 22 unchanged Utilities & Hooks — 822 kB (baseline 822 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 55 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.8 MB (baseline 18.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 346 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-11T00:54:09.604Z",
"gitSha": "b310ea204771419db7091d83e7c5a743427e97e6",
"branch": "refactor/server-facts-own-oxlint-plugin",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.364999999995,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.427,
"layouts": 12,
"layoutDurationMs": 4.08,
"taskDurationMs": 568.7469999999998,
"heapDeltaBytes": -36361684,
"heapUsedBytes": 68669744,
"domNodes": -182,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.100000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2054.8200000000634,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.414000000000001,
"layouts": 11,
"layoutDurationMs": 3.9579999999999997,
"taskDurationMs": 562.1800000000001,
"heapDeltaBytes": -36250476,
"heapUsedBytes": 68985028,
"domNodes": -162,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.517999999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.7380000000412,
"styleRecalcs": 54,
"styleRecalcDurationMs": 13.477,
"layouts": 9,
"layoutDurationMs": 2.984,
"taskDurationMs": 845.084,
"heapDeltaBytes": -24881912,
"heapUsedBytes": 66944912,
"domNodes": -162,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 149.081,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1769.256999999925,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.907,
"layouts": 9,
"layoutDurationMs": 3.319999999999999,
"taskDurationMs": 813.6430000000001,
"heapDeltaBytes": -25218940,
"heapUsedBytes": 66478520,
"domNodes": -162,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 169.132,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.540000000019,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.909999999999999,
"layouts": 12,
"layoutDurationMs": 3.116,
"taskDurationMs": 413.93,
"heapDeltaBytes": -21517644,
"heapUsedBytes": 70310048,
"domNodes": -115,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 10.582,
"eventListeners": -31,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.0929999999298,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.018999999999999,
"layouts": 11,
"layoutDurationMs": 2.73,
"taskDurationMs": 318.00300000000004,
"heapDeltaBytes": -20691724,
"heapUsedBytes": 71018764,
"domNodes": -115,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 12.122999999999998,
"eventListeners": -31,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 677.1079999999756,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.2379999999999995,
"layouts": 10,
"layoutDurationMs": 6.124999999999999,
"taskDurationMs": 535.885,
"heapDeltaBytes": -31786036,
"heapUsedBytes": 73522016,
"domNodes": -162,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 175.68299999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926822,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 737.1650000000045,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.8850000000000002,
"layouts": 9,
"layoutDurationMs": 2.506,
"taskDurationMs": 560.57,
"heapDeltaBytes": -12070868,
"heapUsedBytes": 78334940,
"domNodes": -162,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 179.396,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1164.604000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 786.7529999999999,
"heapDeltaBytes": 18838348,
"heapUsedBytes": 101441548,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 67.956,
"eventListeners": 0,
"totalBlockingTimeMs": 535,
"frameDurationMs": 34.31470588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1160.3939999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 851.6940000000001,
"heapDeltaBytes": 12741456,
"heapUsedBytes": 94258996,
"domNodes": 0,
"jsHeapTotalBytes": 7766016,
"scriptDurationMs": 75.184,
"eventListeners": 0,
"totalBlockingTimeMs": 539,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.9150000000104,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.81399999999974,
"heapDeltaBytes": -5954192,
"heapUsedBytes": 79895160,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 162.18000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 24.762857142857165,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.0269999999591,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.5580000000003,
"heapDeltaBytes": 22099376,
"heapUsedBytes": 96080956,
"domNodes": 0,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 159.573,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10547.128000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9610.654,
"heapDeltaBytes": -2556536,
"heapUsedBytes": 81814300,
"domNodes": 0,
"jsHeapTotalBytes": -15728640,
"scriptDurationMs": 7833.442,
"eventListeners": 0,
"totalBlockingTimeMs": 954,
"frameDurationMs": 31.535628742514973,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8794.486000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7980.682999999999,
"heapDeltaBytes": -13740832,
"heapUsedBytes": 70645716,
"domNodes": 0,
"jsHeapTotalBytes": -17825792,
"scriptDurationMs": 6660.062,
"eventListeners": 0,
"totalBlockingTimeMs": 625,
"frameDurationMs": 31.767870036101087,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9140.710000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8302.667,
"heapDeltaBytes": 11882376,
"heapUsedBytes": 95755372,
"domNodes": 0,
"jsHeapTotalBytes": -15990784,
"scriptDurationMs": 7025.152,
"eventListeners": 0,
"totalBlockingTimeMs": 779,
"frameDurationMs": 32.045614035087716,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9868.978000000083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9021.689999999999,
"heapDeltaBytes": -14469420,
"heapUsedBytes": 69974188,
"domNodes": 0,
"jsHeapTotalBytes": -17825792,
"scriptDurationMs": 7286.093,
"eventListeners": 0,
"totalBlockingTimeMs": 713,
"frameDurationMs": 31.42133757961783,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 225.8820000000128,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.716,
"layouts": 11,
"layoutDurationMs": 3.0660000000000003,
"taskDurationMs": 173.215,
"heapDeltaBytes": 12928228,
"heapUsedBytes": 86321988,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.067000000000002,
"eventListeners": 195,
"totalBlockingTimeMs": 2,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 223.46600000003036,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.276000000000002,
"layouts": 13,
"layoutDurationMs": 3.4330000000000003,
"taskDurationMs": 158.14700000000002,
"heapDeltaBytes": 12991772,
"heapUsedBytes": 82671732,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.777999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.670000000000073,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2036.8459999999686,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.588,
"layouts": 7,
"layoutDurationMs": 1.7469999999999999,
"taskDurationMs": 583.0369999999999,
"heapDeltaBytes": -36214136,
"heapUsedBytes": 70260596,
"domNodes": -258,
"jsHeapTotalBytes": -4853760,
"scriptDurationMs": 36.339000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2044.854999999984,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3899999999999997,
"layouts": 7,
"layoutDurationMs": 2.069,
"taskDurationMs": 603.818,
"heapDeltaBytes": -36889764,
"heapUsedBytes": 69701496,
"domNodes": -258,
"jsHeapTotalBytes": -3280896,
"scriptDurationMs": 34.547000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2331.549999999993,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.684999999999999,
"layouts": 5,
"layoutDurationMs": 1.2479999999999996,
"taskDurationMs": 1607.9289999999999,
"heapDeltaBytes": 702792,
"heapUsedBytes": 67089864,
"domNodes": -258,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 805.299,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665467625899282,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2426.0849999999436,
"styleRecalcs": 65,
"styleRecalcDurationMs": 5.627,
"layouts": 4,
"layoutDurationMs": 0.8739999999999998,
"taskDurationMs": 1665.022,
"heapDeltaBytes": 10361628,
"heapUsedBytes": 77109624,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 829.3170000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.899300699300703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3720.957999999996,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.899999999999999,
"layouts": 63,
"layoutDurationMs": 9.920000000000002,
"taskDurationMs": 1715.1490000000003,
"heapDeltaBytes": 19599100,
"heapUsedBytes": 86909460,
"domNodes": -234,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 767.914,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666367713004487,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3719.8640000000296,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.9879999999999995,
"layouts": 63,
"layoutDurationMs": 9.838,
"taskDurationMs": 1739.0250000000003,
"heapDeltaBytes": 22556384,
"heapUsedBytes": 90757940,
"domNodes": -234,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 786.883,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665919282511215,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3016.1959999999794,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.590000000000001,
"layouts": 3,
"layoutDurationMs": 0.7429999999999998,
"taskDurationMs": 1943.902,
"heapDeltaBytes": 4293024,
"heapUsedBytes": 72323020,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 974.947,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.947191011235958,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3084.9940000000515,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.473000000000002,
"layouts": 3,
"layoutDurationMs": 0.7159999999999996,
"taskDurationMs": 1955.823,
"heapDeltaBytes": 1241716,
"heapUsedBytes": 69279864,
"domNodes": -258,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 966.843,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130438,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2034.579000000008,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.561,
"layouts": 5,
"layoutDurationMs": 1.0789999999999997,
"taskDurationMs": 403.91200000000003,
"heapDeltaBytes": -37402028,
"heapUsedBytes": 71510328,
"domNodes": -258,
"jsHeapTotalBytes": -2494464,
"scriptDurationMs": 31.491,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.553999999981,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.1460000000000004,
"layouts": 6,
"layoutDurationMs": 1.3660000000000005,
"taskDurationMs": 568.342,
"heapDeltaBytes": -38449644,
"heapUsedBytes": 71170304,
"domNodes": -258,
"jsHeapTotalBytes": -4591616,
"scriptDurationMs": 29.941999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.0139999999874,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.1850000000000005,
"layouts": 7,
"layoutDurationMs": 2.7079999999999997,
"taskDurationMs": 451.38100000000003,
"heapDeltaBytes": -17923980,
"heapUsedBytes": 74062744,
"domNodes": -180,
"jsHeapTotalBytes": -4718592,
"scriptDurationMs": 144.412,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 636.7549999999937,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.196,
"layouts": 10,
"layoutDurationMs": 3.212,
"taskDurationMs": 483.013,
"heapDeltaBytes": -17717400,
"heapUsedBytes": 73495640,
"domNodes": -180,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 146.363,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2046.0939999999823,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.853999999999999,
"layouts": 11,
"layoutDurationMs": 5.306,
"taskDurationMs": 378.561,
"heapDeltaBytes": -18437212,
"heapUsedBytes": 73498060,
"domNodes": -180,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 8.847000000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2033.015999999975,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.999,
"layouts": 9,
"layoutDurationMs": 2.278,
"taskDurationMs": 349.843,
"heapDeltaBytes": 15724388,
"heapUsedBytes": 73736408,
"domNodes": -178,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.765000000000002,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1966.5999999999713,
"styleRecalcs": 86,
"styleRecalcDurationMs": 17.452,
"layouts": 8,
"layoutDurationMs": 2.2190000000000003,
"taskDurationMs": 997.0980000000001,
"heapDeltaBytes": 5781896,
"heapUsedBytes": 63770532,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.43099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.0379999999923,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.416,
"layouts": 8,
"layoutDurationMs": 2.1410000000000005,
"taskDurationMs": 827.569,
"heapDeltaBytes": 5405000,
"heapUsedBytes": 62658140,
"domNodes": -200,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.04899999999999,
"eventListeners": -108,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.4430000000166,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.602000000000004,
"layouts": 5,
"layoutDurationMs": 16.519000000000002,
"taskDurationMs": 1107.701,
"heapDeltaBytes": 35801536,
"heapUsedBytes": 126108488,
"domNodes": 15956,
"jsHeapTotalBytes": 11669504,
"scriptDurationMs": 31.322999999999997,
"eventListeners": 3244,
"totalBlockingTimeMs": 169,
"frameDurationMs": 19.820270270270257,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8289.508000000013,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.425,
"layouts": 7,
"layoutDurationMs": 1.4379999999999995,
"taskDurationMs": 4958.447,
"heapDeltaBytes": -39677580,
"heapUsedBytes": 67758408,
"domNodes": -258,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 2637.194,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66579476861167,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9487.565000000017,
"styleRecalcs": 250,
"styleRecalcDurationMs": 18.610000000000003,
"layouts": 8,
"layoutDurationMs": 1.8409999999999997,
"taskDurationMs": 5859.99,
"heapDeltaBytes": -45743304,
"heapUsedBytes": 82173468,
"domNodes": -258,
"jsHeapTotalBytes": -2265088,
"scriptDurationMs": 2700.7980000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666080843585238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23288.847999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22771.066000000003,
"heapDeltaBytes": -5626176,
"heapUsedBytes": 267748404,
"domNodes": -3232,
"jsHeapTotalBytes": 27787264,
"scriptDurationMs": 333.14200000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.86695205479452,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 23875.211000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23023.563,
"heapDeltaBytes": -18216444,
"heapUsedBytes": 277995460,
"domNodes": -3036,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 333.73900000000003,
"eventListeners": -650,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.006529209621995,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 30786.512000000017,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.817999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 30483.443,
"heapDeltaBytes": -42142940,
"heapUsedBytes": 254483584,
"domNodes": -3232,
"jsHeapTotalBytes": 16928768,
"scriptDurationMs": 1061.916,
"eventListeners": -651,
"totalBlockingTimeMs": 177,
"frameDurationMs": 57.892293233082704,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 28776.778000000035,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.30899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28409.278000000002,
"heapDeltaBytes": -8184164,
"heapUsedBytes": 284478808,
"domNodes": -3232,
"jsHeapTotalBytes": 16523264,
"scriptDurationMs": 906.219,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.6669776119403,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8671.903999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.25999999999996,
"layouts": 20,
"layoutDurationMs": 26.313000000000002,
"taskDurationMs": 8568.812000000002,
"heapDeltaBytes": -3712220,
"heapUsedBytes": 295787660,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 138.948,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.77777777777778,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8343.027000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.87299999999999,
"layouts": 20,
"layoutDurationMs": 21.901000000000018,
"taskDurationMs": 8214.922999999999,
"heapDeltaBytes": -18112680,
"heapUsedBytes": 280224956,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 130.852,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.645810055865915,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8584.122999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8282.045,
"heapDeltaBytes": -29098756,
"heapUsedBytes": 263131008,
"domNodes": -3036,
"jsHeapTotalBytes": 30146560,
"scriptDurationMs": 133.38299999999998,
"eventListeners": -650,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.705685618729095,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11820.39999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11580.081,
"heapDeltaBytes": -18084392,
"heapUsedBytes": 283383416,
"domNodes": -3034,
"jsHeapTotalBytes": 22724608,
"scriptDurationMs": 167.72400000000005,
"eventListeners": -650,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.028124999999996,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 195.71699999994507,
"styleRecalcs": 10,
"styleRecalcDurationMs": 15.627000000000002,
"layouts": 10,
"layoutDurationMs": 4.108,
"taskDurationMs": 177.70500000000004,
"heapDeltaBytes": -45106260,
"heapUsedBytes": 56971504,
"domNodes": -67,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 10.15,
"eventListeners": -63,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 190.2820000000247,
"styleRecalcs": 12,
"styleRecalcDurationMs": 15.318999999999999,
"layouts": 11,
"layoutDurationMs": 3.39,
"taskDurationMs": 169.69299999999998,
"heapDeltaBytes": -44376408,
"heapUsedBytes": 58089204,
"domNodes": -41,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 8.16,
"eventListeners": -63,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.35,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 580.838999999969,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.474,
"layouts": 76,
"layoutDurationMs": 16.156,
"taskDurationMs": 535.7369999999999,
"heapDeltaBytes": -12698356,
"heapUsedBytes": 80551268,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 259.36800000000005,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 477.1130000000312,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.075,
"layouts": 76,
"layoutDurationMs": 14.818,
"taskDurationMs": 423.076,
"heapDeltaBytes": -14081108,
"heapUsedBytes": 79727544,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 201.761,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 620.757000000026,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.214,
"layouts": 76,
"layoutDurationMs": 14.882,
"taskDurationMs": 589.448,
"heapDeltaBytes": 533528,
"heapUsedBytes": 123330968,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 227.189,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 596.2729999999965,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.965,
"layouts": 76,
"layoutDurationMs": 15.313,
"taskDurationMs": 566.5160000000001,
"heapDeltaBytes": 705076,
"heapUsedBytes": 124386312,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 212.82299999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.127777777777787,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2259 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 35d80236390f9aba4409f5b28b4e0966c9c0b830
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20760 +/- ##
==========================================
+ Coverage 86.05% 86.85% +0.79%
==========================================
Files 3631 2581 -1050
Lines 173457 145244 -28213
Branches 47843 37752 -10091
==========================================
- Hits 149273 126147 -23126
+ Misses 22176 18711 -3465
+ Partials 2008 386 -1622
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
✅ No high-signal findings.
Panel: 6/6 reviewers contributed findings.
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 3fb04bc has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Summary
#20679 registered
no-capability-recombinationandno-server-fact-literalsin the sharedcomfyplugin..oxlintrc.jsonnever enables them; onlypnpm lint:server-factsdoes, throughserverFacts.oxlintrc.json. This PR exports a plugin fromserverFacts.tsand points that config at it. The main run no longer carries the two rules, and the gate no longer loads everycomfyrule module. Rule IDs staycomfy/*, so disable directives and the write hook's rule matching are unchanged. The new default export is only reached from config, so knip and fallow are told about it the same way as the other plugin files.This is a cleanup, not a speedup. With the rules registered,
oxlint . --type-awaretook 38-49 s at 4.6-4.7 GB peak; with them removed, 41-44 s at 4.6-5.3 GB, which is within noise. The CI cost of the gate is addressed separately in #20759.Verification
pnpm test:unit tools/oxlint-plugins scripts/hooks scripts/server-fact-gate.test.ts: 15 files, 276 tests pass.pnpm lint:server-facts --base HEAD~30still reports the two existinguseBillingDialogs.tsfindings through the new plugin entry.pnpm knip, the fallow pre-push audit, andpnpm typecheck:toolspass.https://ampcode.com/threads/T-3ccbfb7b-6a44-46b2-b77c-661380842fcc