Repository navigation
[backport cloud/1.56] FE-3350 / FE-3351 / FE-3352 / FE-3353 feat: server-fact guardrails (ADR, changed-line lint gate, agent hooks) - #20713
Conversation
…DR, changed-line lint gate, agent hooks) (#20679) > **This PR now carries the whole short-term stack.** The approved children were folded into this branch: #20681 (S2 server-fact oxlint rules + changed-line gate, FE-3351) and #20682 (S3/S4 write and approve hooks, FE-3352 / FE-3353). Each was reviewed and approved on its own PR. The reviewer-visible diff since the docs-only version is those two PRs plus two ADR wording commits: `83e85827ef` (rule 1 scoped to entitlement; local UI state may only narrow) and `2c6455a3bd` (enforcement described as planned per ticket, per CodeRabbit). Agents keep writing, and approving, frontend code that recombines server facts (capabilities, role, tier, plan status, seats, timestamps) into decisions the backend owns. The latest case shipped two billing P0s (BE-19903, BE-19904) through #15675, #18662 and #19455. About 20 fixes since April moved a decision back to the server. There is no repo-level rule for this. The one piece of guidance that touches it points the other way: `docs/guidance/state-and-effects.md` says "Derive everything derivable", and its first example is a `can*` flag. A reviewer-side prose rule existed, and #18662 and #19455 were approved anyway. - **`docs/adr/API-SERVER-FACTS-0042`** records the rule (R1–R5): a gate renders one server fact as received; `isCloud` picks the build, not the permission; failed reads use contract defaults, never role or tier fallbacks; a missing fact is a backend ticket plus `pendingServerFact`. It also records the rejected alternatives. - **`AGENTS.md`** gets one Common Pitfalls line linking the ADR, so every author's agent reads it. - **`state-and-effects.md` §4** now scopes "derive everything derivable" to state the feature owns, and sends server facts to the API. The `canTransition` example is dropped. Enforcement (lint rules, write and approve hooks, orthogonality tests, the `pendingServerFact` expiry check) follows in the sibling tickets below. This PR is the text those checks link to. Docs only. There is no UI change. | | AS IS | TO BE | |---|---|---| | Repo rule | none | ADR + `AGENTS.md` line | | `state-and-effects.md` §4 | "derive everything derivable", `canTransition` example | feature-owned state only; server facts render the API field | TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3349. | Item | Ticket | PR | Status | |---|---|---|---| | **S1 ADR + AGENTS.md + guidance** | **FE-3350** | **this PR** | **In review** | | S2 oxlint rules, diff-scoped gate | FE-3351 | — | Next | | S3 write hook | FE-3352 | — | Blocked by S2 | | S4 approve hook | FE-3353 | — | Blocked by S2 | | S5 `pendingServerFact` + expiry CI | FE-3354 | — | Needs `LINEAR_API_KEY` secret | | S6 orthogonality tests + CODEOWNERS | FE-3355 | — | After #20674 | | S7 cloud agent instructions | FE-3356 | — | Blocked by S1 | ```mermaid graph LR S1["S1 ADR (this PR)"]:::current --> S7["S7 cloud AGENTS.md"] S2["S2 oxlint rules"] --> S3["S3 write hook"] S2 --> S4["S4 approve hook"] S5["S5 pendingServerFact"] S6["S6 orthogonality tests"] P20674["PR 20674 member capabilities"] --> S6 classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ``` (cherry picked from commit a679531)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-10T11:15:40.578Z",
"gitSha": "f42863e688434f93c491c3ea2dd9d817326c1dcb",
"branch": "backport-20679-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.8999999999596,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.603,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.74800000000005,
"heapDeltaBytes": 535020,
"heapUsedBytes": 68709000,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.172000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2021.2790000000496,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.391000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.1330000000001,
"heapDeltaBytes": 849540,
"heapUsedBytes": 69653280,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.613999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.649999999995,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.174,
"layouts": 12,
"layoutDurationMs": 3.869999999999999,
"taskDurationMs": 679.536,
"heapDeltaBytes": 19937240,
"heapUsedBytes": 79976988,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 126.79000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1729.5550000000048,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.893,
"layouts": 12,
"layoutDurationMs": 4.161,
"taskDurationMs": 701.219,
"heapDeltaBytes": -2473568,
"heapUsedBytes": 65637152,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 131.61499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.20799999998,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.696,
"layouts": 6,
"layoutDurationMs": 1.1189999999999998,
"taskDurationMs": 338.8,
"heapDeltaBytes": 3802800,
"heapUsedBytes": 70942360,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.277999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.115000000087,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.951999999999998,
"layouts": 6,
"layoutDurationMs": 1.164,
"taskDurationMs": 350.754,
"heapDeltaBytes": 3760328,
"heapUsedBytes": 71579208,
"domNodes": 53,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 15.330999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 601.0689999999954,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.9050000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.31000000000006,
"heapDeltaBytes": -6452340,
"heapUsedBytes": 60523820,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 146.088,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66944444444443,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 577.7790000000778,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.291999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.314,
"heapDeltaBytes": -6792648,
"heapUsedBytes": 61316920,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 140.706,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1002.2179999999707,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.7139999999999,
"heapDeltaBytes": 15117264,
"heapUsedBytes": 85498060,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 48.846000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 386,
"frameDurationMs": 30.303030303030305,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1015.8139999999776,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 652.616,
"heapDeltaBytes": 15613412,
"heapUsedBytes": 86130152,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 49.259,
"eventListeners": 0,
"totalBlockingTimeMs": 389,
"frameDurationMs": 29.902941176470584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 784.5749999999612,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.72100000000023,
"heapDeltaBytes": 17286208,
"heapUsedBytes": 104929296,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 121.91,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 783.3120000000235,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.05,
"heapDeltaBytes": 17186204,
"heapUsedBytes": 104269368,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 124.73899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7749.418000000049,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.1879999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6835.461,
"heapDeltaBytes": -14058484,
"heapUsedBytes": 70284752,
"domNodes": -142,
"jsHeapTotalBytes": -7999488,
"scriptDurationMs": 5450.727,
"eventListeners": -78,
"totalBlockingTimeMs": 48,
"frameDurationMs": 25.832,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7614.507000000003,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1009999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6709.235,
"heapDeltaBytes": 15479656,
"heapUsedBytes": 93228904,
"domNodes": -143,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 5336.071000000001,
"eventListeners": -82,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.594498381877024,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7714.055999999971,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9980000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6951.877,
"heapDeltaBytes": -1805532,
"heapUsedBytes": 83161840,
"domNodes": -142,
"jsHeapTotalBytes": -8523776,
"scriptDurationMs": 5573.977,
"eventListeners": -78,
"totalBlockingTimeMs": 64,
"frameDurationMs": 25.751505016722408,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7596.774000000039,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7030000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6823.972000000001,
"heapDeltaBytes": 243240,
"heapUsedBytes": 86288548,
"domNodes": -143,
"jsHeapTotalBytes": -6688768,
"scriptDurationMs": 5541.483,
"eventListeners": -82,
"totalBlockingTimeMs": 53,
"frameDurationMs": 25.792517006802722,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2020.6119999999714,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.634,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.83199999999994,
"heapDeltaBytes": -9881784,
"heapUsedBytes": 79159644,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.721000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2013.6829999999009,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6069999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.85699999999997,
"heapDeltaBytes": -9795816,
"heapUsedBytes": 78846248,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.314,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2135.044999999991,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.826,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1351.523,
"heapDeltaBytes": -18974368,
"heapUsedBytes": 71060720,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 688.725,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2140.4629999999543,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.656999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1392.5320000000002,
"heapDeltaBytes": -19688236,
"heapUsedBytes": 70729772,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 709.709,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66614173228346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3235.130999999967,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.863000000000001,
"layouts": 60,
"layoutDurationMs": 14.202,
"taskDurationMs": 1414.571,
"heapDeltaBytes": 1255780,
"heapUsedBytes": 69780632,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 649.941,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666494845360827,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3336.5909999999985,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.887,
"layouts": 60,
"layoutDurationMs": 14.528,
"taskDurationMs": 1500.766,
"heapDeltaBytes": 1600352,
"heapUsedBytes": 69711772,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 691.4559999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2645.153999999991,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.293000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1669.6619999999998,
"heapDeltaBytes": 6575568,
"heapUsedBytes": 75158736,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 864.5540000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666455696202533,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2609.2330000000175,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.4289999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1666.188,
"heapDeltaBytes": 6244180,
"heapUsedBytes": 74757104,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 849.1120000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77354838709677,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2012.1859999999856,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.3219999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.50800000000004,
"heapDeltaBytes": -8617900,
"heapUsedBytes": 81724848,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.336999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.4689999999628,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.32,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.9840000000001,
"heapDeltaBytes": -9092600,
"heapUsedBytes": 80706940,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.467,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 554.5680000000175,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.009999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.51499999999993,
"heapDeltaBytes": -11975188,
"heapUsedBytes": 57533136,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 124.851,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 545.4260000000204,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.94,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.633,
"heapDeltaBytes": -12050632,
"heapUsedBytes": 57575140,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 128.135,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669696969696968,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2010.5849999999919,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.259,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.872,
"heapDeltaBytes": 1055604,
"heapUsedBytes": 70848056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.430999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.620000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.8589999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.41400000000004,
"heapDeltaBytes": -3025960,
"heapUsedBytes": 58393752,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.158,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.6849999999968,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.102,
"layouts": 16,
"layoutDurationMs": 5.111,
"taskDurationMs": 664.6560000000001,
"heapDeltaBytes": -5935776,
"heapUsedBytes": 62988408,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.357,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.142000000027,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.396,
"layouts": 16,
"layoutDurationMs": 5.216,
"taskDurationMs": 675.75,
"heapDeltaBytes": -5973784,
"heapUsedBytes": 63565716,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.73700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1303.4100000000421,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.418000000000003,
"layouts": 5,
"layoutDurationMs": 10.818999999999999,
"taskDurationMs": 801.466,
"heapDeltaBytes": 1170876,
"heapUsedBytes": 95958296,
"domNodes": 14227,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 26.707,
"eventListeners": 2463,
"totalBlockingTimeMs": 93,
"frameDurationMs": 18.545070422535208,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8147.132,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.149,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4658.794,
"heapDeltaBytes": -18013500,
"heapUsedBytes": 70535312,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 2260.41,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666257668711655,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8245.597999999973,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.66,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4980.635,
"heapDeltaBytes": -18628144,
"heapUsedBytes": 69612980,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2390.121,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15776.503999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15055.156999999997,
"heapDeltaBytes": -27165812,
"heapUsedBytes": 180422164,
"domNodes": -3044,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 228.533,
"eventListeners": -14906,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.18339285714286,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 15258.676000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14711.055000000002,
"heapDeltaBytes": -35974028,
"heapUsedBytes": 181829444,
"domNodes": -3045,
"jsHeapTotalBytes": 9981952,
"scriptDurationMs": 221.885,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.97173144876325,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 18541.956000000027,
"styleRecalcs": 142,
"styleRecalcDurationMs": 19.038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18346.125999999997,
"heapDeltaBytes": -55079704,
"heapUsedBytes": 166932932,
"domNodes": -3046,
"jsHeapTotalBytes": 630784,
"scriptDurationMs": 726.304,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 35.2328897338403,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18174.828999999932,
"styleRecalcs": 140,
"styleRecalcDurationMs": 19.732,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17878.898,
"heapDeltaBytes": -37666756,
"heapUsedBytes": 175805940,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 753.783,
"eventListeners": -14915,
"totalBlockingTimeMs": 14,
"frameDurationMs": 34.0185393258427,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5542.079999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.91499999999997,
"layouts": 20,
"layoutDurationMs": 24.284,
"taskDurationMs": 5426.971,
"heapDeltaBytes": -12884764,
"heapUsedBytes": 214344112,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 90.335,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.738414634146345,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5867.208000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.10200000000002,
"layouts": 20,
"layoutDurationMs": 25.195999999999998,
"taskDurationMs": 5771.837,
"heapDeltaBytes": 718368,
"heapUsedBytes": 222733696,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 99.17,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.71734104046243,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7567.177000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7341.269,
"heapDeltaBytes": -23034184,
"heapUsedBytes": 180496368,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 108.08400000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.315523465703976,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8020.149999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7744.071000000002,
"heapDeltaBytes": -26387668,
"heapUsedBytes": 182211216,
"domNodes": -3046,
"jsHeapTotalBytes": 8933376,
"scriptDurationMs": 121.41399999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.628518518518522,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 109.73099999995384,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.780999999999999,
"layouts": 4,
"layoutDurationMs": 1.8580000000000003,
"taskDurationMs": 81.32800000000002,
"heapDeltaBytes": 3827368,
"heapUsedBytes": 62113212,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.670999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 112.9720000000134,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.697000000000001,
"layouts": 4,
"layoutDurationMs": 1.9549999999999996,
"taskDurationMs": 76.48299999999996,
"heapDeltaBytes": 3690668,
"heapUsedBytes": 68897856,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.742000000000004,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 890.3470000000198,
"styleRecalcs": 78,
"styleRecalcDurationMs": 108.308,
"layouts": 76,
"layoutDurationMs": 28.277,
"taskDurationMs": 855.2839999999999,
"heapDeltaBytes": -14225388,
"heapUsedBytes": 73189976,
"domNodes": 76,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 333.763,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667924528301896,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 719.5819999999458,
"styleRecalcs": 78,
"styleRecalcDurationMs": 96.661,
"layouts": 76,
"layoutDurationMs": 24.837,
"taskDurationMs": 683.036,
"heapDeltaBytes": 16222928,
"heapUsedBytes": 83959876,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 255.51800000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1271.3089999999738,
"styleRecalcs": 78,
"styleRecalcDurationMs": 259.774,
"layouts": 76,
"layoutDurationMs": 27.024,
"taskDurationMs": 1241.061,
"heapDeltaBytes": 8140256,
"heapUsedBytes": 114294320,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 376.702,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1253.7499999999682,
"styleRecalcs": 78,
"styleRecalcDurationMs": 265.569,
"layouts": 76,
"layoutDurationMs": 26.977999999999998,
"taskDurationMs": 1234.47,
"heapDeltaBytes": 7463752,
"heapUsedBytes": 114748768,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 376.24,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.35068493150684,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e51dc0beec34b6aa8805a59c22ae10ff69b8ad4c
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #20713 +/- ##
=============================================
Coverage ? 85.15%
=============================================
Files ? 3522
Lines ? 169216
Branches ? 46402
=============================================
Hits ? 144093
Misses ? 23133
Partials ? 1990
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Manual backport of the consolidated server-fact guardrails stack (PR 20679) onto cloud/1.56, after the automated backport hit a conflict.
- The only conflict is in
package.json: the newlint:server-factsscript lands next to the already-backportedcheck:pending-server-factsscript. Confirmed both scripts coexist at this head, and noexportsentry or other field was touched or dropped. - Everything else in the diff matches the stack already reviewed and approved on
mainat PR 20679 (ADR, the changed-line oxlint gate, the Claude write/approve hooks).
Zero open review threads, CI green. Approved.
Manual backport of #20679 to
cloud/1.56. The auto-backport hit a cherry-pick conflict.Conflict:
package.jsononly.cloud/1.56already hascheck:pending-server-facts(backport of #20680) next to where #20679 addslint:server-facts. Resolved by keeping both scripts. The rest of the cherry-pick (-xofa679531) applied cleanly.Verification on this branch:
vitest run tools/oxlint-plugins/serverFacts.test.ts scripts/server-fact-gate.test.ts scripts/lint-staged-config.test.ts scripts/hookspasses, 134 tests in 6 files.Original: #20679 (FE-3350 / FE-3351 / FE-3352 / FE-3353, parent FE-3349).