Skip to content

[backport cloud/1.56] FE-3354 feat(serverFacts): pendingServerFact bridge that expires with its backend ticket - #20693

Merged
comfy-pr-bot merged 1 commit into
cloud/1.56from
backport-20680-to-cloud-1.56
Oct 10, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.56from
backport-20680-to-cloud-1.56

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #20680 to cloud/1.56

Automatically created by backport workflow.

… its backend ticket (#20680)

## Why

ADR-API-SERVER-FACTS-0042 (#20679) says the frontend renders server
facts as received. When the UI needs a fact the API doesn't emit yet,
agents have so far reached for the nearest field as a proxy, as #15675
did with `can_change_seats` for member management (BE-19904). That needs
a legal interim path, and the path has to expire, or the proxy becomes
permanent.

## How

- **`pendingServerFact(ticket, value)`** (`src/platform/serverFacts/`)
returns `value` unchanged. The ticket type is `` `BE-${number}` ``, so
only a backend ticket typechecks. The server-fact lint rules (S2,
FE-3351) ignore anything inside this call.
- **`pnpm check:pending-server-facts`** collects every call site and
asks Linear for each ticket's state. It fails when a ticket is Done or
Canceled, when Linear doesn't know the ticket (a typo must not bridge
forever), or when the first argument isn't a `'BE-<n>'` literal. Each
failure prints the `file:line` that still uses the bridge.
- It uses one `issues(filter: { team: BE, number: { in } })` query,
because `issue(id:)` nulls the whole aliased response for one unknown
ID.
- `--offline` checks only that every ticket is a `'BE-<n>'` literal. It
never reads `LINEAR_API_KEY` and makes no network call.
- The pure parts (`extractTickets`, `expiredTickets`, `preflight`) are
unit-tested.
- **`.github/workflows/ci-pending-server-facts.yaml`** has two jobs:
- `shape` runs on PRs touching source, with no secret, and runs the
check with `--offline`.
- `expiry` runs daily and on `workflow_dispatch`, checks out the default
branch, and gets `LINEAR_API_KEY`.
- The PR job never receives the secret; only scheduled/dispatch runs on
default-branch code query Linear.
- **Admin step needed:** a `LINEAR_API_KEY` repo secret. Without it,
`expiry` passes while there are no call sites (main today) and fails
closed as soon as one appears.

## AS IS / TO BE

There is no UI change.

| | AS IS | TO BE |
|---|---|---|
| Missing server fact | The agent improvises a proxy field |
`pendingServerFact('BE-123', expr)` plus a backend ticket |
| Ticket closes | The proxy stays forever | CI goes red at the exact
`file:line` until the field is rendered |

## Verification

- `vitest run scripts/pending-server-facts.test.ts
src/platform/serverFacts`: 24 passed.
- With no call sites, `--offline`: `No pendingServerFact call sites.
Nothing to check.`, exit 0.
- With a temporary `pendingServerFact('BE-19904', 1)`:
- `--offline`: `1 pendingServerFact ticket(s) are well-formed; expiry is
checked by the scheduled job on main.`, exit 0.
- Online with no key: names the missing secret, exit 1. BE-19904 is
Done, so with the key it would fail as expired.
- With a non-literal ticket, `--offline`: needs-a-literal message with
`file:line`, exit 1.
- `grep LINEAR_API_KEY` on the workflow matches only the `expiry` job.
`actionlint` is clean.
- Not verified: the success path against live Linear, because no key is
available locally.

## Plan position

TDD: [Server-fact
guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b).
Parent: FE-3349.

| Item | Ticket | PR | Status |
|---|---|---|---|
| S1 ADR + AGENTS.md + guidance | FE-3350 | #20679 | In review |
| S2 oxlint rules, diff-scoped gate | FE-3351 | — | In progress |
| S3 write hook | FE-3352 | — | Blocked by S2 |
| S4 approve hook | FE-3353 | — | Blocked by S2 |
| **S5 `pendingServerFact` + expiry CI** | **FE-3354** | **this PR** |
**In review** |
| S6 orthogonality tests + CODEOWNERS | FE-3355 | — | After #20674 |
| S7 cloud agent instructions | FE-3356 | cloud#12741 | In review |

```mermaid
graph LR
  S1["S1 ADR (PR 20679)"] --> S7["S7 cloud AGENTS.md (cloud PR 12741)"]
  S2["S2 oxlint rules"] --> S3["S3 write hook"]
  S2 --> S4["S4 approve hook"]
  S5["S5 pendingServerFact (this PR)"]:::current
  S5 -. "exempted by" .-> S2
  P20674["PR 20674 member capabilities"] --> S6["S6 orthogonality tests"]
  classDef current fill:#f9d71c,stroke:#333,stroke-width:2px
```
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/10/2026, 12:00:49 AM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 2d2809d8024aed5a7f34cdf0c488056557ceef84

Full docs: ADR-DEVEX-LINT-0015

🎭 Playwright: ✅ 2202 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2180 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.1 MB heap
dom-widget-order-dense-n200-w200-i120: · 27.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 597ms TBT · 82.4 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 39.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 230ms TBT · 99.8 MB heap
extension-clean-combined-draw: · 31.2 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 665ms TBT · 82.0 MB heap
extension-rgthree-prototype-draw: · 32.2 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 225ms TBT · 82.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
large-graph-pan: · 59.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap
legacy-node-drag: · 59.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.9 MB heap
subgraph-transition-enter: · 49.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 138ms TBT · 93.7 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
vue-large-graph-idle: · 29.5 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 172.9 MB heap
vue-large-graph-pan: · 25.6 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 52ms TBT · 163.6 MB heap
vue-node-resize-workload: · 25.1 avg FPS · 10.9 P5 FPS ❌ (target: ≥52) · 13ms TBT · 201.8 MB heap
vue-zoom-out-idle: · 29.2 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 172.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.9 MB heap
agent-composer-empty-conversation-typing: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
agent-composer-long-conversation-typing: · 52.5 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 106.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 500ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.6 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 19ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 859ms
canvas-mouse-sweep: script duration 162ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.9 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 11ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 392ms
canvas-zoom-sweep: script duration 16ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.5 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 484ms
dom-widget-clipping: script duration 172ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 65.1 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 36ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 937ms
dom-widget-order-dense-n200-w200-i120: script duration 69ms
dom-widget-order-dense-n200-w200-i120: TBT 597ms
dom-widget-order-dense-n200-w200-i120: heap used 82.4 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 516ms
dom-widget-order-sparse-n1000-w20-i120: script duration 153ms
dom-widget-order-sparse-n1000-w20-i120: TBT 230ms
dom-widget-order-sparse-n1000-w20-i120: heap used 99.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 58ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 1
extension-clean-combined-draw: task duration 8651ms
extension-clean-combined-draw: script duration 7004ms
extension-clean-combined-draw: TBT 665ms
extension-clean-combined-draw: heap used 82.0 MB
extension-clean-combined-draw: DOM nodes -157
extension-clean-combined-draw: event listeners -80
extension-rgthree-prototype-draw: avg frame time 31ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 8161ms
extension-rgthree-prototype-draw: script duration 6566ms
extension-rgthree-prototype-draw: TBT 225ms
extension-rgthree-prototype-draw: heap used 82.4 MB
extension-rgthree-prototype-draw: DOM nodes -142
extension-rgthree-prototype-draw: event listeners -76
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 604ms
large-graph-idle: script duration 41ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 69.4 MB
large-graph-idle: DOM nodes 0
large-graph-idle: event listeners 0
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1706ms
large-graph-pan: script duration 886ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 77.8 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 17ms
large-graph-zoom: style recalc duration 17ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1803ms
large-graph-zoom: script duration 860ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.5 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 2038ms
legacy-node-drag: script duration 1101ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.0 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 601ms
minimap-idle: script duration 39ms
minimap-idle: TBT 0ms
minimap-idle: heap used 76.6 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 439ms
subgraph-dom-widget-clipping: script duration 152ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 55.4 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 5ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 520ms
subgraph-idle: script duration 13ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.8 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 7ms
subgraph-mouse-sweep: style recalc duration 22ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 830ms
subgraph-mouse-sweep: script duration 122ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.9 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 14
subgraph-transition-enter: task duration 1055ms
subgraph-transition-enter: script duration 36ms
subgraph-transition-enter: TBT 138ms
subgraph-transition-enter: heap used 93.7 MB
subgraph-transition-enter: DOM nodes 14227
subgraph-transition-enter: event listeners 2463
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 45ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 6040ms
viewport-pan-sweep: script duration 2963ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 66.7 MB
viewport-pan-sweep: DOM nodes 0
viewport-pan-sweep: event listeners 0
vue-large-graph-idle: avg frame time 34ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18255ms
vue-large-graph-idle: script duration 327ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.9 MB
vue-large-graph-idle: DOM nodes -3045
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 39ms
vue-large-graph-pan: p95 frame time 83ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 25ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 151
vue-large-graph-pan: task duration 20039ms
vue-large-graph-pan: script duration 933ms
vue-large-graph-pan: TBT 52ms
vue-large-graph-pan: heap used 163.6 MB
vue-large-graph-pan: DOM nodes -3045
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 40ms
vue-node-resize-workload: p95 frame time 92ms
vue-node-resize-workload: layout duration 30ms
vue-node-resize-workload: style recalc duration 79ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6789ms
vue-node-resize-workload: script duration 128ms
vue-node-resize-workload: TBT 13ms
vue-node-resize-workload: heap used 201.8 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 34ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 9391ms
vue-zoom-out-idle: script duration 161ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.8 MB
vue-zoom-out-idle: DOM nodes -3045
vue-zoom-out-idle: event listeners -14916
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 4
workflow-execution: style recalc count 16
workflow-execution: task duration 125ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 64.9 MB
workflow-execution: DOM nodes 102
workflow-execution: event listeners 65
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 31ms
agent-composer-empty-conversation-typing: style recalc duration 124ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 1033ms
agent-composer-empty-conversation-typing: script duration 409ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 82.7 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 19ms
agent-composer-long-conversation-typing: p95 frame time 33ms
agent-composer-long-conversation-typing: layout duration 33ms
agent-composer-long-conversation-typing: style recalc duration 301ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1509ms
agent-composer-long-conversation-typing: script duration 484ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 106.5 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-10T00:13:25.301Z",
  "gitSha": "88fbe40542ad5b186d380c6aae3b714ffc5c0e2c",
  "branch": "backport-20680-to-cloud-1.56",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2022.8250000000116,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.212,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.296,
      "heapDeltaBytes": 573832,
      "heapUsedBytes": 69383240,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 13.558,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2023.65199999997,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 3.066000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.32300000000004,
      "heapDeltaBytes": 585148,
      "heapUsedBytes": 68104808,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 11.933,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1785.4330000000118,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 19.375999999999998,
      "layouts": 12,
      "layoutDurationMs": 4.885,
      "taskDurationMs": 875.51,
      "heapDeltaBytes": -2133056,
      "heapUsedBytes": 65886404,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 164.108,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66635514018692,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1791.1090000000058,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 19.535999999999998,
      "layouts": 12,
      "layoutDurationMs": 4.9239999999999995,
      "taskDurationMs": 841.724,
      "heapDeltaBytes": -2179476,
      "heapUsedBytes": 66027424,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 159.704,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665420560747663,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1698.2779999999593,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 11.691000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.73,
      "taskDurationMs": 403.97999999999996,
      "heapDeltaBytes": 4133320,
      "heapUsedBytes": 71572384,
      "domNodes": 53,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 16.550999999999995,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66568627450981,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.070000000007,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 10.587000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.2429999999999999,
      "taskDurationMs": 379.49999999999994,
      "heapDeltaBytes": 4063596,
      "heapUsedBytes": 72184152,
      "domNodes": 53,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 15.494000000000007,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 727.121000000011,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 4.033,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.865,
      "heapDeltaBytes": -6478808,
      "heapUsedBytes": 61285312,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 172.344,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665116279069753,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 725.422999999978,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 4.178000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 476.87,
      "heapDeltaBytes": 15573400,
      "heapUsedBytes": 75220864,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 171.19299999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667441860465132,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1165.3929999999946,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 878.1850000000001,
      "heapDeltaBytes": 15457572,
      "heapUsedBytes": 84430940,
      "domNodes": 0,
      "jsHeapTotalBytes": 2523136,
      "scriptDurationMs": 62.531000000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 537,
      "frameDurationMs": 34.31470588235294,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1314.1840000000684,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 995.8639999999999,
      "heapDeltaBytes": 19403668,
      "heapUsedBytes": 88419748,
      "domNodes": 0,
      "jsHeapTotalBytes": 6717440,
      "scriptDurationMs": 75.03999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 657,
      "frameDurationMs": 37.617142857142866,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 859.4569999999635,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.5820000000002,
      "heapDeltaBytes": 17384876,
      "heapUsedBytes": 104598304,
      "domNodes": 0,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 152.933,
      "eventListeners": 0,
      "totalBlockingTimeMs": 230,
      "frameDurationMs": 25.488235294117658,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 877.8320000000122,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.9100000000003,
      "heapDeltaBytes": 17745644,
      "heapUsedBytes": 104790380,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 153.555,
      "eventListeners": 0,
      "totalBlockingTimeMs": 230,
      "frameDurationMs": 25.237142857142835,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9630.845000000023,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8687.65,
      "heapDeltaBytes": 13668176,
      "heapUsedBytes": 98683452,
      "domNodes": -142,
      "jsHeapTotalBytes": -921600,
      "scriptDurationMs": 7014.598,
      "eventListeners": -78,
      "totalBlockingTimeMs": 792,
      "frameDurationMs": 31.897019867549673,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9468.759000000091,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.07000000000000062,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8613.758,
      "heapDeltaBytes": -5020072,
      "heapUsedBytes": 73233080,
      "domNodes": -172,
      "jsHeapTotalBytes": -1970176,
      "scriptDurationMs": 6993.9929999999995,
      "eventListeners": -82,
      "totalBlockingTimeMs": 537,
      "frameDurationMs": 32.30819112627986,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9121.34900000001,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.037999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8230.247000000001,
      "heapDeltaBytes": -4897904,
      "heapUsedBytes": 79815396,
      "domNodes": -142,
      "jsHeapTotalBytes": -9572352,
      "scriptDurationMs": 6602.624000000001,
      "eventListeners": -78,
      "totalBlockingTimeMs": 256,
      "frameDurationMs": 31.056996587030714,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 8840.836999999965,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.541999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8091.804,
      "heapDeltaBytes": 14597116,
      "heapUsedBytes": 93057192,
      "domNodes": -142,
      "jsHeapTotalBytes": -11407360,
      "scriptDurationMs": 6529.807999999999,
      "eventListeners": -74,
      "totalBlockingTimeMs": 194,
      "frameDurationMs": 30.99298245614035,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2013.0929999999694,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.099,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 600.5169999999999,
      "heapDeltaBytes": -11642024,
      "heapUsedBytes": 68133544,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 40.059999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2031.5790000000788,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.7869999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 606.8059999999999,
      "heapDeltaBytes": -7939044,
      "heapUsedBytes": 77308948,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 42.580999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2814.481999999998,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.539,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1689.0780000000002,
      "heapDeltaBytes": 11378900,
      "heapUsedBytes": 93884556,
      "domNodes": 0,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 863.0500000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.765476190476193,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2704.4610000000375,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.459,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1722.022,
      "heapDeltaBytes": -20254592,
      "heapUsedBytes": 69283368,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 908.166,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.874374999999997,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3884.4739999999547,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 16.777,
      "layouts": 60,
      "layoutDurationMs": 16.858999999999998,
      "taskDurationMs": 1827.9800000000002,
      "heapDeltaBytes": 1462168,
      "heapUsedBytes": 69785708,
      "domNodes": 24,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 880.293,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666094420600857,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3805.001999999945,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 17.034,
      "layouts": 60,
      "layoutDurationMs": 17.964000000000002,
      "taskDurationMs": 1778.9050000000002,
      "heapDeltaBytes": 1600816,
      "heapUsedBytes": 69660752,
      "domNodes": 24,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 840.1599999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666228070175436,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3141.5189999999598,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.220000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1990.923,
      "heapDeltaBytes": 17899192,
      "heapUsedBytes": 87836016,
      "domNodes": 0,
      "jsHeapTotalBytes": 1990656,
      "scriptDurationMs": 1080.6820000000002,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.84438502673797,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3227.439000000004,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.701,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2084.2099999999996,
      "heapDeltaBytes": 9109244,
      "heapUsedBytes": 77843092,
      "domNodes": 0,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 1121.996,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.8390625,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.9780000000092,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.018999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 618.7609999999999,
      "heapDeltaBytes": -9499856,
      "heapUsedBytes": 80401372,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 40.147000000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2011.3839999999072,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.4589999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 583.475,
      "heapDeltaBytes": -9698944,
      "heapUsedBytes": 80344600,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 38.01700000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 683.838000000037,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 7.436999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.33900000000006,
      "heapDeltaBytes": -11976900,
      "heapUsedBytes": 58712012,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 157.053,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536566,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 674.1690000000062,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.983000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 429.847,
      "heapDeltaBytes": -12298680,
      "heapUsedBytes": 57499600,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 147.47100000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664999999999985,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.9019999999878,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.970000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 545.1189999999999,
      "heapDeltaBytes": 1062660,
      "heapUsedBytes": 70739448,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 12.869000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.6339999999063,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.244000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.292,
      "heapDeltaBytes": 1057404,
      "heapUsedBytes": 71469892,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.401000000000009,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1727.1640000000161,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 21.939999999999998,
      "layouts": 16,
      "layoutDurationMs": 6.7749999999999995,
      "taskDurationMs": 837.8180000000002,
      "heapDeltaBytes": -5950992,
      "heapUsedBytes": 63573076,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 124.355,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475724,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.7970000000141,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 21.892,
      "layouts": 16,
      "layoutDurationMs": 6.597,
      "taskDurationMs": 822.235,
      "heapDeltaBytes": -5983940,
      "heapUsedBytes": 64140512,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 120.63099999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1435.3499999999713,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 31.185,
      "layouts": 5,
      "layoutDurationMs": 14.251,
      "taskDurationMs": 1054.791,
      "heapDeltaBytes": 3353768,
      "heapUsedBytes": 98214972,
      "domNodes": 14227,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 35.577000000000005,
      "eventListeners": 2463,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 20.13888888888889,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9763.725000000022,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 45.668,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6095.165,
      "heapDeltaBytes": -18963788,
      "heapUsedBytes": 69715636,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 2989.798,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665982905982908,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9206.782999999974,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 44.67,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5984.245000000001,
      "heapDeltaBytes": -18319036,
      "heapUsedBytes": 70168104,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 2935.228,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.696370235934666,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18930.488999999965,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18580.418999999998,
      "heapDeltaBytes": -37817704,
      "heapUsedBytes": 180441076,
      "domNodes": -3045,
      "jsHeapTotalBytes": 7098368,
      "scriptDurationMs": 328.731,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.71818181818181,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18433.28500000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17928.889000000003,
      "heapDeltaBytes": -35900140,
      "heapUsedBytes": 182131400,
      "domNodes": -3045,
      "jsHeapTotalBytes": 9195520,
      "scriptDurationMs": 325.023,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 34.13425925925927,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23647.853999999938,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 29.89999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23390.606,
      "heapDeltaBytes": -46198796,
      "heapUsedBytes": 167249624,
      "domNodes": -3045,
      "jsHeapTotalBytes": 7098368,
      "scriptDurationMs": 996.1070000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 59,
      "frameDurationMs": 46.222265625000006,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17016.301999999996,
      "styleRecalcs": 122,
      "styleRecalcDurationMs": 19.28000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16688.334000000003,
      "heapDeltaBytes": -51230848,
      "heapUsedBytes": 175840844,
      "domNodes": -3045,
      "jsHeapTotalBytes": 7622656,
      "scriptDurationMs": 869.586,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 44,
      "frameDurationMs": 32.045197740113,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6789.255000000026,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.575,
      "layouts": 20,
      "layoutDurationMs": 27.981999999999992,
      "taskDurationMs": 6688.414,
      "heapDeltaBytes": 760408,
      "heapUsedBytes": 214266004,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 124.66099999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 39.20867052023121,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6995.83999999993,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.33600000000001,
      "layouts": 20,
      "layoutDurationMs": 31.81500000000001,
      "taskDurationMs": 6889.048000000001,
      "heapDeltaBytes": 902036,
      "heapUsedBytes": 209030248,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 131.21699999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 26,
      "frameDurationMs": 40.59941860465116,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9918.215000000033,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9718.399000000001,
      "heapDeltaBytes": -43386244,
      "heapUsedBytes": 180676808,
      "domNodes": -3045,
      "jsHeapTotalBytes": 2203648,
      "scriptDurationMs": 166.31799999999996,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 35.288967971530255,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9312.08300000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9062.708,
      "heapDeltaBytes": -32481936,
      "heapUsedBytes": 181798172,
      "domNodes": -3045,
      "jsHeapTotalBytes": 8146944,
      "scriptDurationMs": 156.33299999999994,
      "eventListeners": -14917,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.27214285714286,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "workflow-execution",
      "durationMs": 480.59599999999136,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 20.555,
      "layouts": 4,
      "layoutDurationMs": 1.977,
      "taskDurationMs": 129.53,
      "heapDeltaBytes": 5703048,
      "heapUsedBytes": 72252008,
      "domNodes": 104,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.452999999999994,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667857142857137,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 464.56100000000333,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 17.12,
      "layouts": 4,
      "layoutDurationMs": 1.751,
      "taskDurationMs": 121.14300000000003,
      "heapDeltaBytes": 5512728,
      "heapUsedBytes": 63811476,
      "domNodes": 99,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.441999999999998,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.671428571428578,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1075.1109999999926,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 120.75,
      "layouts": 76,
      "layoutDurationMs": 31.466,
      "taskDurationMs": 1036.243,
      "heapDeltaBytes": 19163156,
      "heapUsedBytes": 87877752,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 414.802,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.1952380952381,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1070.9699999999884,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 128.09300000000002,
      "layouts": 76,
      "layoutDurationMs": 31.467000000000002,
      "taskDurationMs": 1029.409,
      "heapDeltaBytes": 18996368,
      "heapUsedBytes": 85561488,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 402.952,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.203225806451606,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1522.619000000077,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 302.753,
      "layouts": 76,
      "layoutDurationMs": 32.523,
      "taskDurationMs": 1494.7820000000002,
      "heapDeltaBytes": 8475928,
      "heapUsedBytes": 114844260,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 472.843,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.92839506172838,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1539.1730000000052,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 300.14099999999996,
      "layouts": 76,
      "layoutDurationMs": 33.721000000000004,
      "taskDurationMs": 1523.088,
      "heapDeltaBytes": -18893776,
      "heapUsedBytes": 108485812,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 496.096,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.134567901234565,
      "p95FrameDurationMs": 33.399999999999636
    }
  ]
}

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions
github-actions Bot requested a review from thedatalife October 9, 2026 23:59
@codecov

codecov Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.56   #20693   +/-   ##
=============================================
  Coverage              ?   82.68%           
=============================================
  Files                 ?     3414           
  Lines                 ?   153981           
  Branches              ?    44124           
=============================================
  Hits                  ?   127324           
  Misses                ?    24642           
  Partials              ?     2015           
Flag Coverage Δ
billing-web-unit 92.39% <ø> (?)
unit 82.98% <100.00%> (?)
website-unit 79.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/serverFacts/pendingServerFact.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport: the diff is identical to #20680.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 10, 2026
@comfy-pr-bot
comfy-pr-bot merged commit e51dc0b into cloud/1.56 Oct 10, 2026
147 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-20680-to-cloud-1.56 branch October 10, 2026 00:19
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 10, 2026
…-fact gates (Comfy-Org#20694)

## Why

BE-19903 and BE-19904 shipped because members-panel gates recombined a
server capability with plan state, seats and role. Comfy-Org#19455 hid the
derivation behind a helper and an `if`/`return`, so the lint rules
(Comfy-Org#20679) can't see it. The existing tests also didn't catch it: they
mocked the capability at the composable, and one asserted the derivation
as expected behaviour.

## Root cause

No test asserted the property that matters: **a gate's output depends
only on its server fact.** Each test pinned one combination of inputs,
so a gate that also read `isPlanEnded` passed every test that didn't
happen to flip it.

## How

- **`describeServerFactGate`** (`src/utils/__tests__/serverFactGate.ts`,
about 50 lines). Given a fact setter, a list of non-fact perturbations,
`mount` and `read`, it generates `it.for` cases over both fact values
and every perturbation:
  - Each perturbation must leave `read()` unchanged.
  - Flipping only the fact must change it.
- The fact is set after the perturbation, so a perturbation can't
override it.
- **Applied to the Cloud members-panel gates** in
`useMembersPanel.test.ts`:

  | Gate | Fact | Reads |
  |---|---|---|
| Invite | `can_invite_members` | `showInviteButton`,
`isInviteDisabled`, `permissions.canInviteMembers` |
| Member management | `can_manage_members` | `canManageMembers`,
`canViewPendingInvites`, `uiConfig.showPendingTab`, member menu
non-empty |
| Roster visibility | members response (`membersLoaded`) |
`canViewOtherMembers`, `showMembersList` |

  Shared perturbations:
- plan ended, Enterprise, ended Enterprise with `maxSeats` 1, `maxSeats`
1
  - personal plan, cancel scheduled
  - not a billing manager, member role
  - `can_change_seats` flipped

Each gate also flips the capabilities it must not depend on. Invite
flips `can_manage_members`, management flips `can_invite_members`, and
roster flips both, so one capability can't stand in for another.
- **`CODEOWNERS`**: `/src/platform/workspace/` gets the billing owners.
The incident lived there, and it was the only billing-adjacent path
without owners.

## AS IS / TO BE

There is no UI change. These are test outcomes on the two historical
defects, each reintroduced by hand and not committed:

| Mutation | AS IS (tests before this PR) | TO BE |
|---|---|---|
| Comfy-Org#18662 disjunct back on Cloud `showInviteButton` (`canInviteMembers
\|\| (isPlanEnded && canManageSubscription)`) | Existing suite still
asserted it pre-Comfy-Org#20674 | 4 failures, including "ignores an ended plan
when the fact is false" and "ignores an ended Enterprise plan with one
seat when the fact is false" |
| Comfy-Org#15675 substitution (`canManageMembers` ← `canChangeSeats`) | Not
caught by an orthogonality case | 27 failures, including "ignores a
flipped can_change_seats" (fact true and false) and "changes when the
fact flips" |
| After revert | — | 158 passed |

## Verification

- `vitest run
src/platform/workspace/composables/useMembersPanel.test.ts`: 158 passed.
- oxlint `--type-aware` and oxfmt `--check` pass on touched files. The
pre-commit hook ran `typecheck:app`.
- No existing Cloud test still asserts a derivation (Comfy-Org#20674 already
flipped them), so none were rewritten.

## Plan position

TDD: [Server-fact
guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b).
Parent: FE-3349.

| Item | Ticket | PR | Status |
|---|---|---|---|
| S1 ADR + S2 lint gate + S3/S4 hooks (folded) | FE-3350..FE-3353 |
Comfy-Org#20679 | In review |
| S5 `pendingServerFact` + expiry CI | FE-3354 | Comfy-Org#20680 | Merged
(backports Comfy-Org#20692, Comfy-Org#20693) |
| **S6 orthogonality tests + CODEOWNERS** | **FE-3355** | **this PR** |
**In review** |
| S7 cloud agent instructions | FE-3356 | cloud#12741 | Merged |

```mermaid
graph LR
  S1["S1-S4 ADR, lint gate, hooks (PR 20679)"]
  S5["S5 pendingServerFact (PR 20680, merged)"] -. "exempted by" .-> S1
  P20674["PR 20674 member capabilities (merged)"] --> S6["S6 orthogonality tests (this PR)"]:::current
  S6 -. "covers what lint cannot" .-> S1
  S7["S7 cloud AGENTS.md (merged)"]
  classDef current fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants