Repository navigation
[backport core/1.56] FE-3354 feat(serverFacts): pendingServerFact bridge that expires with its backend ticket - #20692
Conversation
… its backend ticket (#20680) ## Why ADR-API-SERVER-FACTS-0042 (#20679) says the frontend renders server facts as received. When the UI needs a fact the API doesn't emit yet, agents have so far reached for the nearest field as a proxy, as #15675 did with `can_change_seats` for member management (BE-19904). That needs a legal interim path, and the path has to expire, or the proxy becomes permanent. ## How - **`pendingServerFact(ticket, value)`** (`src/platform/serverFacts/`) returns `value` unchanged. The ticket type is `` `BE-${number}` ``, so only a backend ticket typechecks. The server-fact lint rules (S2, FE-3351) ignore anything inside this call. - **`pnpm check:pending-server-facts`** collects every call site and asks Linear for each ticket's state. It fails when a ticket is Done or Canceled, when Linear doesn't know the ticket (a typo must not bridge forever), or when the first argument isn't a `'BE-<n>'` literal. Each failure prints the `file:line` that still uses the bridge. - It uses one `issues(filter: { team: BE, number: { in } })` query, because `issue(id:)` nulls the whole aliased response for one unknown ID. - `--offline` checks only that every ticket is a `'BE-<n>'` literal. It never reads `LINEAR_API_KEY` and makes no network call. - The pure parts (`extractTickets`, `expiredTickets`, `preflight`) are unit-tested. - **`.github/workflows/ci-pending-server-facts.yaml`** has two jobs: - `shape` runs on PRs touching source, with no secret, and runs the check with `--offline`. - `expiry` runs daily and on `workflow_dispatch`, checks out the default branch, and gets `LINEAR_API_KEY`. - The PR job never receives the secret; only scheduled/dispatch runs on default-branch code query Linear. - **Admin step needed:** a `LINEAR_API_KEY` repo secret. Without it, `expiry` passes while there are no call sites (main today) and fails closed as soon as one appears. ## AS IS / TO BE There is no UI change. | | AS IS | TO BE | |---|---|---| | Missing server fact | The agent improvises a proxy field | `pendingServerFact('BE-123', expr)` plus a backend ticket | | Ticket closes | The proxy stays forever | CI goes red at the exact `file:line` until the field is rendered | ## Verification - `vitest run scripts/pending-server-facts.test.ts src/platform/serverFacts`: 24 passed. - With no call sites, `--offline`: `No pendingServerFact call sites. Nothing to check.`, exit 0. - With a temporary `pendingServerFact('BE-19904', 1)`: - `--offline`: `1 pendingServerFact ticket(s) are well-formed; expiry is checked by the scheduled job on main.`, exit 0. - Online with no key: names the missing secret, exit 1. BE-19904 is Done, so with the key it would fail as expired. - With a non-literal ticket, `--offline`: needs-a-literal message with `file:line`, exit 1. - `grep LINEAR_API_KEY` on the workflow matches only the `expiry` job. `actionlint` is clean. - Not verified: the success path against live Linear, because no key is available locally. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3349. | Item | Ticket | PR | Status | |---|---|---|---| | S1 ADR + AGENTS.md + guidance | FE-3350 | #20679 | In review | | S2 oxlint rules, diff-scoped gate | FE-3351 | — | In progress | | S3 write hook | FE-3352 | — | Blocked by S2 | | S4 approve hook | FE-3353 | — | Blocked by S2 | | **S5 `pendingServerFact` + expiry CI** | **FE-3354** | **this PR** | **In review** | | S6 orthogonality tests + CODEOWNERS | FE-3355 | — | After #20674 | | S7 cloud agent instructions | FE-3356 | cloud#12741 | In review | ```mermaid graph LR S1["S1 ADR (PR 20679)"] --> S7["S7 cloud AGENTS.md (cloud PR 12741)"] S2["S2 oxlint rules"] --> S3["S3 write hook"] S2 --> S4["S4 approve hook"] S5["S5 pendingServerFact (this PR)"]:::current S5 -. "exempted by" .-> S2 P20674["PR 20674 member capabilities"] --> S6["S6 orthogonality tests"] classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ```
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 11f32c7f6bdcb2d1a600f181eebe877d8aae1c94
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2200 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-10T00:10:57.481Z",
"gitSha": "bb3b9cf7764f025e21b8e318792294bea090f95b",
"branch": "backport-20680-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.9160000000088,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7090000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.43300000000005,
"heapDeltaBytes": 592108,
"heapUsedBytes": 69150836,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.238999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.1729999999761,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.553000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.11400000000003,
"heapDeltaBytes": 889924,
"heapUsedBytes": 68263032,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.537999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1720.7260000000133,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.799999999999999,
"layouts": 12,
"layoutDurationMs": 3.877,
"taskDurationMs": 637.751,
"heapDeltaBytes": -2104604,
"heapUsedBytes": 65857308,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 117.62,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.1469999999063,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.086999999999998,
"layouts": 12,
"layoutDurationMs": 3.6,
"taskDurationMs": 622.4949999999999,
"heapDeltaBytes": -2375596,
"heapUsedBytes": 65982016,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.416,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823533,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.595999999996,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.106,
"layouts": 6,
"layoutDurationMs": 1.198,
"taskDurationMs": 289.573,
"heapDeltaBytes": 4064716,
"heapUsedBytes": 72280388,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.727,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.8189999999913,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.247,
"layouts": 6,
"layoutDurationMs": 1.119,
"taskDurationMs": 286.051,
"heapDeltaBytes": 3815120,
"heapUsedBytes": 70897976,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.887999999999995,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 591.3039999999796,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.909000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.56100000000004,
"heapDeltaBytes": -6426528,
"heapUsedBytes": 61905116,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 136.716,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 550.151000000028,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.91100000000006,
"heapDeltaBytes": -7722256,
"heapUsedBytes": 61456276,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 129.464,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669696969696982,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1026.5459999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.748,
"heapDeltaBytes": 16401432,
"heapUsedBytes": 85644552,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 44.303,
"eventListeners": 0,
"totalBlockingTimeMs": 422,
"frameDurationMs": 31.312121212121216,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1046.3229999999726,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.5219999999999,
"heapDeltaBytes": 39225668,
"heapUsedBytes": 108224552,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 54.989,
"eventListeners": 0,
"totalBlockingTimeMs": 427,
"frameDurationMs": 30.8794117647059,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 749.3649999999548,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.7560000000003,
"heapDeltaBytes": 16086660,
"heapUsedBytes": 103572160,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 118.56,
"eventListeners": 0,
"totalBlockingTimeMs": 127,
"frameDurationMs": 22.058823529411764,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 748.2169999999542,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.82500000000005,
"heapDeltaBytes": 18348828,
"heapUsedBytes": 103999852,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 114.481,
"eventListeners": 0,
"totalBlockingTimeMs": 124,
"frameDurationMs": 22.058823529411764,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6909.144000000026,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3130000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6129.517,
"heapDeltaBytes": -15884924,
"heapUsedBytes": 69170048,
"domNodes": -142,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 4768.304,
"eventListeners": -74,
"totalBlockingTimeMs": 42,
"frameDurationMs": 26.135227272727267,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6660.958999999992,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9200000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5898.492,
"heapDeltaBytes": 9887804,
"heapUsedBytes": 94139932,
"domNodes": -142,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 4790.8730000000005,
"eventListeners": -78,
"totalBlockingTimeMs": 32,
"frameDurationMs": 26.179921259842523,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6623.0949999999775,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0179999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6052.737999999999,
"heapDeltaBytes": 7443292,
"heapUsedBytes": 93590780,
"domNodes": -143,
"jsHeapTotalBytes": -8261632,
"scriptDurationMs": 4698.336,
"eventListeners": -82,
"totalBlockingTimeMs": 118,
"frameDurationMs": 26.466,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6509.719999999959,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9119999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5981.9259999999995,
"heapDeltaBytes": -16858824,
"heapUsedBytes": 68719076,
"domNodes": -143,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 4658.4580000000005,
"eventListeners": -82,
"totalBlockingTimeMs": 42,
"frameDurationMs": 26.103212851405626,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2008.305000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5900000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.1760000000001,
"heapDeltaBytes": -9815276,
"heapUsedBytes": 79900344,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.101000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.3030000000454,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0830000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.84600000000006,
"heapDeltaBytes": -9331516,
"heapUsedBytes": 77995372,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.399,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2143.417999999997,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.242,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1278.8999999999999,
"heapDeltaBytes": -19072780,
"heapUsedBytes": 70891172,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 656.239,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2161.832000000004,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.331000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1301.231,
"heapDeltaBytes": 13263184,
"heapUsedBytes": 94051796,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 676.384,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665891472868214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3349.5379999999955,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.997999999999998,
"layouts": 60,
"layoutDurationMs": 14.860999999999999,
"taskDurationMs": 1380.658,
"heapDeltaBytes": 1321964,
"heapUsedBytes": 69874200,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 633.694,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666169154228857,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3407.6670000000604,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.87,
"layouts": 60,
"layoutDurationMs": 15.120999999999999,
"taskDurationMs": 1433.8339999999998,
"heapDeltaBytes": 2475668,
"heapUsedBytes": 84786116,
"domNodes": 24,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 660.576,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588233,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2328.2580000000053,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.007999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1508.8560000000002,
"heapDeltaBytes": 5126168,
"heapUsedBytes": 73582588,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 769.433,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786956521739132,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2507.8190000000404,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.029000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1610.163,
"heapDeltaBytes": 6189304,
"heapUsedBytes": 75755664,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 845.207,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666000000000004,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2016.0439999999653,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.156,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.28600000000006,
"heapDeltaBytes": -8238028,
"heapUsedBytes": 82191968,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 31.346,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.894000000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6249999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.43699999999995,
"heapDeltaBytes": -8583392,
"heapUsedBytes": 81139336,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.89699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.1460000000116,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.5169999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.02799999999996,
"heapDeltaBytes": -12284264,
"heapUsedBytes": 58486668,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 115.96500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.9040000000541,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.239000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.83699999999993,
"heapDeltaBytes": -11667176,
"heapUsedBytes": 58320384,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 106.66600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.6130000000394,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.7479999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.271,
"heapDeltaBytes": 1197304,
"heapUsedBytes": 71668000,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.2329999999383,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8199999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.688,
"heapDeltaBytes": 1024864,
"heapUsedBytes": 70516000,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.037000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.0720000000197,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.331999999999999,
"layouts": 16,
"layoutDurationMs": 4.783,
"taskDurationMs": 600.243,
"heapDeltaBytes": -5995704,
"heapUsedBytes": 64052264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.49100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.224999999974,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.627,
"layouts": 16,
"layoutDurationMs": 4.348,
"taskDurationMs": 594.0620000000001,
"heapDeltaBytes": -5951972,
"heapUsedBytes": 63570896,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.08000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 900.2619999999979,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.729999999999993,
"layouts": 5,
"layoutDurationMs": 10.110999999999999,
"taskDurationMs": 721.795,
"heapDeltaBytes": 1253000,
"heapUsedBytes": 92035548,
"domNodes": 14227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 22.915000000000006,
"eventListeners": 2463,
"totalBlockingTimeMs": 111,
"frameDurationMs": 20.454545454545453,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8169.720999999981,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.246,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4520.1539999999995,
"heapDeltaBytes": -17749516,
"heapUsedBytes": 71288224,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 2195.484,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665918367346936,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8130.454999999984,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.397999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4565.9,
"heapDeltaBytes": -19059416,
"heapUsedBytes": 69647416,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2211.4960000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66577868852459,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13980.93,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13033.918,
"heapDeltaBytes": -17683856,
"heapUsedBytes": 179029892,
"domNodes": -3045,
"jsHeapTotalBytes": 8728576,
"scriptDurationMs": 218.134,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.393969849246233,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 14192.821999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13161.851999999999,
"heapDeltaBytes": -20426956,
"heapUsedBytes": 178744796,
"domNodes": -3045,
"jsHeapTotalBytes": 7012352,
"scriptDurationMs": 269.53499999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.985472972972975,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 12910.696999999971,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.595999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12448.111,
"heapDeltaBytes": -29028244,
"heapUsedBytes": 183938388,
"domNodes": -3045,
"jsHeapTotalBytes": 7798784,
"scriptDurationMs": 702.881,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 23.105724508050088,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 16702.989,
"styleRecalcs": 119,
"styleRecalcDurationMs": 16.872,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16259.698,
"heapDeltaBytes": -32355444,
"heapUsedBytes": 183912016,
"domNodes": -3046,
"jsHeapTotalBytes": 6750208,
"scriptDurationMs": 775.162,
"eventListeners": -14915,
"totalBlockingTimeMs": 1,
"frameDurationMs": 30.554395604395605,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4949.185999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.95199999999998,
"layouts": 20,
"layoutDurationMs": 24.527000000000008,
"taskDurationMs": 4827.852999999999,
"heapDeltaBytes": 1306384,
"heapUsedBytes": 212266264,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 86.135,
"eventListeners": 0,
"totalBlockingTimeMs": 4,
"frameDurationMs": 29.817469879518075,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 4875.5840000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.55100000000002,
"layouts": 20,
"layoutDurationMs": 24.39999999999999,
"taskDurationMs": 4777.069,
"heapDeltaBytes": -12746608,
"heapUsedBytes": 214819656,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 85.832,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.59515151515152,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7336.294000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6744.865000000001,
"heapDeltaBytes": -37957272,
"heapUsedBytes": 179002596,
"domNodes": -3045,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 110.655,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.964052287581705,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7329.115999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6714.734,
"heapDeltaBytes": -26522736,
"heapUsedBytes": 179195208,
"domNodes": -3046,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 133.26399999999992,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.113013698630137,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 440.83100000000286,
"styleRecalcs": 16,
"styleRecalcDurationMs": 12.445,
"layouts": 2,
"layoutDurationMs": 0.7210000000000001,
"taskDurationMs": 102.547,
"heapDeltaBytes": 5599956,
"heapUsedBytes": 71690548,
"domNodes": 102,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.307000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 99.30899999994836,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.559,
"layouts": 3,
"layoutDurationMs": 0.9549999999999998,
"taskDurationMs": 63.30900000000003,
"heapDeltaBytes": 3765460,
"heapUsedBytes": 69020284,
"domNodes": 94,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.360999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.640000000000054,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 494.27400000001853,
"styleRecalcs": 78,
"styleRecalcDurationMs": 73.42999999999999,
"layouts": 76,
"layoutDurationMs": 16.965,
"taskDurationMs": 457.535,
"heapDeltaBytes": 13919344,
"heapUsedBytes": 95810376,
"domNodes": 76,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 161.60100000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 460.2019999999811,
"styleRecalcs": 78,
"styleRecalcDurationMs": 72.118,
"layouts": 76,
"layoutDurationMs": 16.727,
"taskDurationMs": 431.888,
"heapDeltaBytes": 13618768,
"heapUsedBytes": 95920224,
"domNodes": 76,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 151.51000000000002,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 837.032000000022,
"styleRecalcs": 78,
"styleRecalcDurationMs": 185.483,
"layouts": 76,
"layoutDurationMs": 18.01,
"taskDurationMs": 806.057,
"heapDeltaBytes": 10067904,
"heapUsedBytes": 127981100,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 227.44400000000002,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 831.6569999999501,
"styleRecalcs": 78,
"styleRecalcDurationMs": 182.578,
"layouts": 76,
"layoutDurationMs": 18.006999999999998,
"taskDurationMs": 802.855,
"heapDeltaBytes": 4327336,
"heapUsedBytes": 111005408,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 227.6,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17,
"p95FrameDurationMs": 16.800000000000182
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20692 +/- ##
=============================================
- Coverage 85.85% 85.11% -0.75%
=============================================
Files 2470 3513 +1043
Lines 141057 168869 +27812
Branches 36416 44332 +7916
=============================================
+ Hits 121110 143736 +22626
- Misses 19564 23143 +3579
- Partials 383 1990 +1607
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1043 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport: the diff is identical to #20680.
…-fact gates (Comfy-Org#20694) ## Why BE-19903 and BE-19904 shipped because members-panel gates recombined a server capability with plan state, seats and role. Comfy-Org#19455 hid the derivation behind a helper and an `if`/`return`, so the lint rules (Comfy-Org#20679) can't see it. The existing tests also didn't catch it: they mocked the capability at the composable, and one asserted the derivation as expected behaviour. ## Root cause No test asserted the property that matters: **a gate's output depends only on its server fact.** Each test pinned one combination of inputs, so a gate that also read `isPlanEnded` passed every test that didn't happen to flip it. ## How - **`describeServerFactGate`** (`src/utils/__tests__/serverFactGate.ts`, about 50 lines). Given a fact setter, a list of non-fact perturbations, `mount` and `read`, it generates `it.for` cases over both fact values and every perturbation: - Each perturbation must leave `read()` unchanged. - Flipping only the fact must change it. - The fact is set after the perturbation, so a perturbation can't override it. - **Applied to the Cloud members-panel gates** in `useMembersPanel.test.ts`: | Gate | Fact | Reads | |---|---|---| | Invite | `can_invite_members` | `showInviteButton`, `isInviteDisabled`, `permissions.canInviteMembers` | | Member management | `can_manage_members` | `canManageMembers`, `canViewPendingInvites`, `uiConfig.showPendingTab`, member menu non-empty | | Roster visibility | members response (`membersLoaded`) | `canViewOtherMembers`, `showMembersList` | Shared perturbations: - plan ended, Enterprise, ended Enterprise with `maxSeats` 1, `maxSeats` 1 - personal plan, cancel scheduled - not a billing manager, member role - `can_change_seats` flipped Each gate also flips the capabilities it must not depend on. Invite flips `can_manage_members`, management flips `can_invite_members`, and roster flips both, so one capability can't stand in for another. - **`CODEOWNERS`**: `/src/platform/workspace/` gets the billing owners. The incident lived there, and it was the only billing-adjacent path without owners. ## AS IS / TO BE There is no UI change. These are test outcomes on the two historical defects, each reintroduced by hand and not committed: | Mutation | AS IS (tests before this PR) | TO BE | |---|---|---| | Comfy-Org#18662 disjunct back on Cloud `showInviteButton` (`canInviteMembers \|\| (isPlanEnded && canManageSubscription)`) | Existing suite still asserted it pre-Comfy-Org#20674 | 4 failures, including "ignores an ended plan when the fact is false" and "ignores an ended Enterprise plan with one seat when the fact is false" | | Comfy-Org#15675 substitution (`canManageMembers` ← `canChangeSeats`) | Not caught by an orthogonality case | 27 failures, including "ignores a flipped can_change_seats" (fact true and false) and "changes when the fact flips" | | After revert | — | 158 passed | ## Verification - `vitest run src/platform/workspace/composables/useMembersPanel.test.ts`: 158 passed. - oxlint `--type-aware` and oxfmt `--check` pass on touched files. The pre-commit hook ran `typecheck:app`. - No existing Cloud test still asserts a derivation (Comfy-Org#20674 already flipped them), so none were rewritten. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3349. | Item | Ticket | PR | Status | |---|---|---|---| | S1 ADR + S2 lint gate + S3/S4 hooks (folded) | FE-3350..FE-3353 | Comfy-Org#20679 | In review | | S5 `pendingServerFact` + expiry CI | FE-3354 | Comfy-Org#20680 | Merged (backports Comfy-Org#20692, Comfy-Org#20693) | | **S6 orthogonality tests + CODEOWNERS** | **FE-3355** | **this PR** | **In review** | | S7 cloud agent instructions | FE-3356 | cloud#12741 | Merged | ```mermaid graph LR S1["S1-S4 ADR, lint gate, hooks (PR 20679)"] S5["S5 pendingServerFact (PR 20680, merged)"] -. "exempted by" .-> S1 P20674["PR 20674 member capabilities (merged)"] --> S6["S6 orthogonality tests (this PR)"]:::current S6 -. "covers what lint cannot" .-> S1 S7["S7 cloud AGENTS.md (merged)"] classDef current fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ```
Backport of #20680 to
core/1.56Automatically created by backport workflow.