Repository navigation
[backport cloud/1.56] fix(execution): land run outputs on agent-inserted nodes (PM-2037) (#20601) - #20690
Conversation
…20601) ## Summary Fixes [PM-2037](https://linear.app/comfyorg/issue/PM-2037): outputs from an Agent-inserted workflow now reach the matching canvas node when multiplayer remaps the node to a delimiter-bearing ID such as `insert:<opId>:root:node:<originalId>`. The repair makes the locator contract explicit: - ordinary root and subgraph nodes keep their existing locator keys; - delimiter-bearing, empty, and non-integer local IDs use canonical `~root:<encoded-id>` or `~subgraph:<uuid>:<encoded-id>` keys; - every `createNodeLocatorId` caller gets that behavior, so previews, promoted previews, minimap state, cleanup, node progress, widget rendering, compositor layers, and Agent selection cannot silently mint `null` for the same ID class; - execution paths resolve in one recursive walk, with real subgraph traversal taking precedence over a literal root ID; a missing leaf remains unresolved; - workflow-path rewrites stay synchronous without restoring the former workflow-store/execution-store dependency cycle; - the Vue renderer reads output through the same canonical locator used by the store. The change also removes the obsolete split/fallback resolver paths and their duplicate tests. No feature flag, exposure, workflow content, model choice, or credit behavior changes. ## Verification - Focused locator and all direct strict-caller suites: 8 files, 189 tests passed. - Broader workflow, execution, output-store, renderer, Agent, media, and widget suites on the preceding repair head: 176 files, 3,928 tests passed. - `src/stores/nodeOutputStore.insertWorkflowOutputs.test.ts` drives the real output store and traversal path for remapped root nodes. - `browser_tests/tests/vueNodes/agentInsertedNodeOutputs.spec.ts` loads a remapped Save Image node, delivers backend-style execution frames, and asserts the rendered node image. - Repository hooks pass formatting, type-aware lint, ESLint, and app typecheck for the current change; the pre-push hook runs the repository fallow audit. ## Compatibility Legacy colon-free locator strings still parse unchanged. Encoded locators are canonical and round-trip the raw local ID, including literal percent escapes. Backend execution IDs remain unchanged; the tagged encoding is only the frontend locator-key format. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2d2809d8024aed5a7f34cdf0c488056557ceef84
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2203 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-09T23:55:02.923Z",
"gitSha": "980e1a60ff47fed3aa34f736240e7afac7cd369a",
"branch": "christian/backport-20601-cloud-1.56-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.5560000000464,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.535999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.11500000000007,
"heapDeltaBytes": 610328,
"heapUsedBytes": 68025156,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.938999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.215999999934,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.5869999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.361,
"heapDeltaBytes": 567552,
"heapUsedBytes": 67495876,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.859,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.4809999999939,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.790000000000003,
"layouts": 12,
"layoutDurationMs": 4.8549999999999995,
"taskDurationMs": 774.45,
"heapDeltaBytes": -2479828,
"heapUsedBytes": 65614616,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 144.20100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1821.3729999999941,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.364,
"layouts": 12,
"layoutDurationMs": 5.2379999999999995,
"taskDurationMs": 774.9870000000001,
"heapDeltaBytes": -1815900,
"heapUsedBytes": 65917616,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 147.292,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.4020000000078,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.488,
"layouts": 6,
"layoutDurationMs": 1.3010000000000002,
"taskDurationMs": 343.16999999999996,
"heapDeltaBytes": 4030000,
"heapUsedBytes": 73247680,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.225999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.6130000000048,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.466,
"layouts": 6,
"layoutDurationMs": 1.4849999999999999,
"taskDurationMs": 350.99199999999996,
"heapDeltaBytes": 4057536,
"heapUsedBytes": 72194372,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.745000000000008,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 713.4449999999788,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.8340000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.264,
"heapDeltaBytes": -6423868,
"heapUsedBytes": 60783824,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 163.302,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 723.4829999999874,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.469,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.075,
"heapDeltaBytes": -6516656,
"heapUsedBytes": 61066744,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 152.47,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1107.1479999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 769.2850000000001,
"heapDeltaBytes": 16075240,
"heapUsedBytes": 85050984,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 64.879,
"eventListeners": 0,
"totalBlockingTimeMs": 489,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1078.2839999999396,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 753.3810000000001,
"heapDeltaBytes": 15424136,
"heapUsedBytes": 85157652,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 49.610000000000014,
"eventListeners": 0,
"totalBlockingTimeMs": 469,
"frameDurationMs": 32.827272727272735,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 778.8850000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.93,
"heapDeltaBytes": 17774716,
"heapUsedBytes": 105253008,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 132.04399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 151,
"frameDurationMs": 23.03529411764708,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 791.0510000000386,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.4770000000001,
"heapDeltaBytes": 17422632,
"heapUsedBytes": 95506328,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 141.63600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8668.403999999953,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.29599999999999765,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7763.321,
"heapDeltaBytes": -16194648,
"heapUsedBytes": 68615708,
"domNodes": -142,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 6085.773999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 246,
"frameDurationMs": 30.349824561403505,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7938.459999999964,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.261,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7240.637000000001,
"heapDeltaBytes": -10443200,
"heapUsedBytes": 74064484,
"domNodes": -142,
"jsHeapTotalBytes": -5902336,
"scriptDurationMs": 5669.779,
"eventListeners": -78,
"totalBlockingTimeMs": 77,
"frameDurationMs": 29.05824175824176,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8473.790000000008,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9439999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7788.452000000001,
"heapDeltaBytes": 6132456,
"heapUsedBytes": 75356556,
"domNodes": -142,
"jsHeapTotalBytes": -2494464,
"scriptDurationMs": 6156.586000000001,
"eventListeners": -70,
"totalBlockingTimeMs": 252,
"frameDurationMs": 31.294814814814817,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7597.778999999946,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9220000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6922.286000000001,
"heapDeltaBytes": -4133004,
"heapUsedBytes": 80961200,
"domNodes": -143,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 5357.838,
"eventListeners": -82,
"totalBlockingTimeMs": 69,
"frameDurationMs": 29.053639846743295,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2020.228999999972,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5820000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.46,
"heapDeltaBytes": -10026240,
"heapUsedBytes": 78201444,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.324,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.8710000000328,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.304000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.09199999999987,
"heapDeltaBytes": -11019876,
"heapUsedBytes": 78154884,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.419999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2410.556999999983,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.804999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1499.8899999999996,
"heapDeltaBytes": -18842852,
"heapUsedBytes": 70922948,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 770.211,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783216783216783,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2412.23100000002,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.32,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1511.2969999999998,
"heapDeltaBytes": -18999712,
"heapUsedBytes": 71012476,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 771.6110000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3705.4750000000354,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.623,
"layouts": 60,
"layoutDurationMs": 16.174,
"taskDurationMs": 1591.9319999999998,
"heapDeltaBytes": 1281992,
"heapUsedBytes": 69733044,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 727.9639999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66621621621622,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3773.2770000000073,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.962999999999997,
"layouts": 60,
"layoutDurationMs": 16.298,
"taskDurationMs": 1636.4669999999999,
"heapDeltaBytes": 1249800,
"heapUsedBytes": 69193484,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 748.979,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665638766519823,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3116.6429999999536,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.346999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1859.632,
"heapDeltaBytes": 17630256,
"heapUsedBytes": 85941776,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 934.1210000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75621621621622,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3083.3670000000666,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.044,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1841.335,
"heapDeltaBytes": 8838264,
"heapUsedBytes": 76940832,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 928.9349999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757065217391304,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2016.9680000000199,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.184000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.4149999999999,
"heapDeltaBytes": -9550972,
"heapUsedBytes": 80281860,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 34.437,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.7420000000693,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.5109999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.0009999999999,
"heapDeltaBytes": -9270904,
"heapUsedBytes": 80576412,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 33.886,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.4620000000268,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.658999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.699,
"heapDeltaBytes": -12430160,
"heapUsedBytes": 57775704,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 129.887,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.8480000000282,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.384,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.348,
"heapDeltaBytes": -11785624,
"heapUsedBytes": 57515972,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 130.96,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2009.4940000000179,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.641000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.657,
"heapDeltaBytes": 1029440,
"heapUsedBytes": 71159264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.244999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.2610000000095,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.3649999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.142,
"heapDeltaBytes": -3252036,
"heapUsedBytes": 59219492,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.446,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1696.3480000000004,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.812999999999995,
"layouts": 16,
"layoutDurationMs": 5.851999999999999,
"taskDurationMs": 713.7610000000001,
"heapDeltaBytes": -6312812,
"heapUsedBytes": 63762368,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.947,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.7189999999928,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.973,
"layouts": 16,
"layoutDurationMs": 6.2139999999999995,
"taskDurationMs": 752.215,
"heapDeltaBytes": -5930476,
"heapUsedBytes": 63803988,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.443,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.9669999999978,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.842999999999996,
"layouts": 5,
"layoutDurationMs": 11.134000000000002,
"taskDurationMs": 875.0399999999998,
"heapDeltaBytes": 3190640,
"heapUsedBytes": 98106984,
"domNodes": 14227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.004999999999995,
"eventListeners": 2463,
"totalBlockingTimeMs": 127,
"frameDurationMs": 19.213888888888896,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8466.557000000023,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.954,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5281.651,
"heapDeltaBytes": -19160580,
"heapUsedBytes": 69557184,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2574.621,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66587771203156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9204.138999999941,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.324,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5585.193,
"heapDeltaBytes": -18596684,
"heapUsedBytes": 70049204,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2695.1679999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665880217785844,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14808.617000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14329.153,
"heapDeltaBytes": -37702188,
"heapUsedBytes": 179301472,
"domNodes": -3045,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 287.20099999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.34143835616438,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14722.223999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14236.028999999999,
"heapDeltaBytes": -33622628,
"heapUsedBytes": 179312952,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 294.452,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.328743545611015,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 18448.83699999997,
"styleRecalcs": 144,
"styleRecalcDurationMs": 21.12900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18075.228,
"heapDeltaBytes": -32191660,
"heapUsedBytes": 166642568,
"domNodes": -3045,
"jsHeapTotalBytes": 6864896,
"scriptDurationMs": 843.835,
"eventListeners": -14919,
"totalBlockingTimeMs": 9,
"frameDurationMs": 34.102218114602586,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18259.89400000003,
"styleRecalcs": 152,
"styleRecalcDurationMs": 20.488000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17881.9,
"heapDeltaBytes": -40889280,
"heapUsedBytes": 175411152,
"domNodes": -3045,
"jsHeapTotalBytes": 4071424,
"scriptDurationMs": 824.577,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.27140255009108,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5561.462000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.29299999999999,
"layouts": 20,
"layoutDurationMs": 25.713,
"taskDurationMs": 5484.33,
"heapDeltaBytes": 6184032,
"heapUsedBytes": 216563316,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 98.188,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.14969325153374,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5541.786000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.636,
"layouts": 20,
"layoutDurationMs": 25.705000000000005,
"taskDurationMs": 5378.027999999999,
"heapDeltaBytes": 723956,
"heapUsedBytes": 224081912,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 98.256,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.07976878612716,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7674.906000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7426.305000000001,
"heapDeltaBytes": -32478696,
"heapUsedBytes": 180180448,
"domNodes": -3045,
"jsHeapTotalBytes": 8966144,
"scriptDurationMs": 124.96000000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.712195121951225,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7498.395000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7181.956000000001,
"heapDeltaBytes": -23168660,
"heapUsedBytes": 179469852,
"domNodes": -3045,
"jsHeapTotalBytes": 5853184,
"scriptDurationMs": 118.30100000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.452380952380953,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 458.1510000000435,
"styleRecalcs": 14,
"styleRecalcDurationMs": 17.7,
"layouts": 4,
"layoutDurationMs": 1.9729999999999999,
"taskDurationMs": 128.86099999999996,
"heapDeltaBytes": 5651392,
"heapUsedBytes": 70021768,
"domNodes": 102,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.305000000000003,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 475.3650000000107,
"styleRecalcs": 19,
"styleRecalcDurationMs": 14.673,
"layouts": 3,
"layoutDurationMs": 1.4300000000000002,
"taskDurationMs": 113.49299999999998,
"heapDeltaBytes": 5775604,
"heapUsedBytes": 72526252,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.586,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.28148148148146,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 840.6770000000279,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.312,
"layouts": 76,
"layoutDurationMs": 26.33,
"taskDurationMs": 813.7249999999999,
"heapDeltaBytes": 17549720,
"heapUsedBytes": 86144440,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 309.88100000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 886.5020000000641,
"styleRecalcs": 78,
"styleRecalcDurationMs": 112.175,
"layouts": 76,
"layoutDurationMs": 28.541,
"taskDurationMs": 854.8789999999999,
"heapDeltaBytes": 17686960,
"heapUsedBytes": 84619928,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 326.341,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1393.7990000000582,
"styleRecalcs": 78,
"styleRecalcDurationMs": 262.459,
"layouts": 76,
"layoutDurationMs": 31.314,
"taskDurationMs": 1372.885,
"heapDeltaBytes": 8807348,
"heapUsedBytes": 115514064,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 438.671,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.28395061728395,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1419.2079999999123,
"styleRecalcs": 78,
"styleRecalcDurationMs": 263.09900000000005,
"layouts": 76,
"layoutDurationMs": 30.916,
"taskDurationMs": 1377.881,
"heapDeltaBytes": 8412464,
"heapUsedBytes": 119530256,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 425.439,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.707500000000003,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #20690 +/- ##
=============================================
Coverage ? 85.89%
=============================================
Files ? 2479
Lines ? 141415
Branches ? 38493
=============================================
Hits ? 121467
Misses ? 19565
Partials ? 383
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #20601 to
cloud/1.56.The automated backport conflicted in
src/stores/previewExposureStore.test.ts. This resolves that conflict with the same delimiter-bearing locator expectation already reviewed and merged in cloud/1.55 #20654 and core/1.55 #20657; the product/source diff is otherwise the source squash commit.Verified:
src/stores/previewExposureStore.test.tsandsrc/stores/nodeOutputStore.insertWorkflowOutputs.test.tspass (19/19) on this branch.Source: #20601
Siblings: #20654 (cloud/1.55), #20657 (core/1.55), #20689 (core/1.56)