Repository navigation
[backport core/1.56] fix(execution): land run outputs on agent-inserted nodes (PM-2037) (#20601) - #20689
Conversation
…20601) ## Summary Fixes [PM-2037](https://linear.app/comfyorg/issue/PM-2037): outputs from an Agent-inserted workflow now reach the matching canvas node when multiplayer remaps the node to a delimiter-bearing ID such as `insert:<opId>:root:node:<originalId>`. The repair makes the locator contract explicit: - ordinary root and subgraph nodes keep their existing locator keys; - delimiter-bearing, empty, and non-integer local IDs use canonical `~root:<encoded-id>` or `~subgraph:<uuid>:<encoded-id>` keys; - every `createNodeLocatorId` caller gets that behavior, so previews, promoted previews, minimap state, cleanup, node progress, widget rendering, compositor layers, and Agent selection cannot silently mint `null` for the same ID class; - execution paths resolve in one recursive walk, with real subgraph traversal taking precedence over a literal root ID; a missing leaf remains unresolved; - workflow-path rewrites stay synchronous without restoring the former workflow-store/execution-store dependency cycle; - the Vue renderer reads output through the same canonical locator used by the store. The change also removes the obsolete split/fallback resolver paths and their duplicate tests. No feature flag, exposure, workflow content, model choice, or credit behavior changes. ## Verification - Focused locator and all direct strict-caller suites: 8 files, 189 tests passed. - Broader workflow, execution, output-store, renderer, Agent, media, and widget suites on the preceding repair head: 176 files, 3,928 tests passed. - `src/stores/nodeOutputStore.insertWorkflowOutputs.test.ts` drives the real output store and traversal path for remapped root nodes. - `browser_tests/tests/vueNodes/agentInsertedNodeOutputs.spec.ts` loads a remapped Save Image node, delivers backend-style execution frames, and asserts the rendered node image. - Repository hooks pass formatting, type-aware lint, ESLint, and app typecheck for the current change; the pre-push hook runs the repository fallow audit. ## Compatibility Legacy colon-free locator strings still parse unchanged. Encoded locators are canonical and round-trip the raw local ID, including literal percent escapes. Backend execution IDs remain unchanged; the tagged encoding is only the frontend locator-key format. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 11f32c7f6bdcb2d1a600f181eebe877d8aae1c94
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2203 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-09T23:55:21.791Z",
"gitSha": "36bf2b212bebca9ca62017cd6ac7b05478746996",
"branch": "christian/backport-20601-core-1.56-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.9950000000085,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9109999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.274,
"heapDeltaBytes": 554028,
"heapUsedBytes": 68458064,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.268000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2023.6770000000206,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.455000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.591,
"heapDeltaBytes": 556404,
"heapUsedBytes": 68100784,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.418999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.213000000008,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.223000000000003,
"layouts": 12,
"layoutDurationMs": 4.999,
"taskDurationMs": 784.124,
"heapDeltaBytes": -2147708,
"heapUsedBytes": 65910848,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 168.434,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.8030000000354,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.108,
"layouts": 12,
"layoutDurationMs": 4.5760000000000005,
"taskDurationMs": 852.429,
"heapDeltaBytes": -2084304,
"heapUsedBytes": 66043336,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.42000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.5549999999807,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.479000000000001,
"layouts": 6,
"layoutDurationMs": 1.2860000000000003,
"taskDurationMs": 367.75699999999995,
"heapDeltaBytes": 4080912,
"heapUsedBytes": 72112988,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.144999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.9300000000803,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.892,
"layouts": 6,
"layoutDurationMs": 1.3629999999999998,
"taskDurationMs": 377.96200000000005,
"heapDeltaBytes": 4064724,
"heapUsedBytes": 73109864,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.312000000000006,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.5929999999935,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.614999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.6549999999999,
"heapDeltaBytes": -7123748,
"heapUsedBytes": 60928148,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 168.66400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 729.0739999999687,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.706,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.398,
"heapDeltaBytes": 15003284,
"heapUsedBytes": 76552172,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 177.443,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1162.9159999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 862.1379999999998,
"heapDeltaBytes": 14889768,
"heapUsedBytes": 84339900,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 67.641,
"eventListeners": 0,
"totalBlockingTimeMs": 543,
"frameDurationMs": 35.35151515151514,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1150.6310000000894,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.882,
"heapDeltaBytes": 38854560,
"heapUsedBytes": 108332152,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 67.78,
"eventListeners": 0,
"totalBlockingTimeMs": 513,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.3900000000326,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.5259999999999,
"heapDeltaBytes": 17302092,
"heapUsedBytes": 104754648,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.657,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 25.0029411764706,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.0519999999487,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.42199999999957,
"heapDeltaBytes": 17921884,
"heapUsedBytes": 104029648,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 173.44000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.485294117647058,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9268.061999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8427.468,
"heapDeltaBytes": 10230012,
"heapUsedBytes": 95044472,
"domNodes": -142,
"jsHeapTotalBytes": -6688768,
"scriptDurationMs": 7175.852,
"eventListeners": -78,
"totalBlockingTimeMs": 1151,
"frameDurationMs": 35.503065134099614,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8919.804,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8196.154999999999,
"heapDeltaBytes": -4380204,
"heapUsedBytes": 80312420,
"domNodes": -142,
"jsHeapTotalBytes": -11669504,
"scriptDurationMs": 6953.1900000000005,
"eventListeners": -78,
"totalBlockingTimeMs": 955,
"frameDurationMs": 34.36100386100386,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9773.32100000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8972.059,
"heapDeltaBytes": -11589448,
"heapUsedBytes": 72797532,
"domNodes": -142,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 7425.191000000001,
"eventListeners": -74,
"totalBlockingTimeMs": 963,
"frameDurationMs": 32.6628762541806,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10124.797000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9221.49,
"heapDeltaBytes": -11351620,
"heapUsedBytes": 73554704,
"domNodes": -142,
"jsHeapTotalBytes": -8261632,
"scriptDurationMs": 7608.688000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 1201,
"frameDurationMs": 33.33223684210526,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2014.6540000000073,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.275999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.147,
"heapDeltaBytes": -10128328,
"heapUsedBytes": 78379108,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.149999999999984,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.270000000015,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.029,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.7779999999999,
"heapDeltaBytes": -9489308,
"heapUsedBytes": 78965432,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 42.547000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2410.907000000009,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.741,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1566.2589999999998,
"heapDeltaBytes": -17190572,
"heapUsedBytes": 69835436,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 830.8629999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2847.8900000000067,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.597999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1688.049,
"heapDeltaBytes": 9725252,
"heapUsedBytes": 88246664,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 881.595,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3676.174000000003,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.037,
"layouts": 60,
"layoutDurationMs": 14.199,
"taskDurationMs": 1699.672,
"heapDeltaBytes": -20420852,
"heapUsedBytes": 70372816,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 797.581,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666063348416287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3654.6500000000606,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.049,
"layouts": 60,
"layoutDurationMs": 14.552,
"taskDurationMs": 1601.351,
"heapDeltaBytes": 1252260,
"heapUsedBytes": 69476016,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 829.585,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3144.483999999977,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.36,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1901.232,
"heapDeltaBytes": 9240180,
"heapUsedBytes": 77598948,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 999.3839999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84438502673797,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3111.6040000000567,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.627000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1977.88,
"heapDeltaBytes": 8168596,
"heapUsedBytes": 77868332,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 1032.864,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755913978494625,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.9949999999849,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.908000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.9380000000001,
"heapDeltaBytes": -9262832,
"heapUsedBytes": 79704968,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.574,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.3369999999977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.87,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.5490000000001,
"heapDeltaBytes": -8944332,
"heapUsedBytes": 80830980,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 35.483000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.0039999999562,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.797,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.83000000000004,
"heapDeltaBytes": -12343192,
"heapUsedBytes": 57482968,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 146.264,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 678.3850000000484,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.338000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.314,
"heapDeltaBytes": -12000416,
"heapUsedBytes": 58081256,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 150.053,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.6630000000127,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.987000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.4720000000001,
"heapDeltaBytes": -2755364,
"heapUsedBytes": 61651316,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.720999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2010.2720000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.332999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.66299999999995,
"heapDeltaBytes": 1101376,
"heapUsedBytes": 70227096,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.515999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.4529999999536,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.689,
"layouts": 16,
"layoutDurationMs": 5.901,
"taskDurationMs": 744.068,
"heapDeltaBytes": 16939492,
"heapUsedBytes": 81110924,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.229,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1713.339000000019,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.619999999999997,
"layouts": 16,
"layoutDurationMs": 5.6579999999999995,
"taskDurationMs": 783.543,
"heapDeltaBytes": -5941264,
"heapUsedBytes": 64864504,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 116.56400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1420.5160000000205,
"styleRecalcs": 16,
"styleRecalcDurationMs": 31.144,
"layouts": 5,
"layoutDurationMs": 15.400000000000004,
"taskDurationMs": 1017.217,
"heapDeltaBytes": 2910880,
"heapUsedBytes": 99210548,
"domNodes": 14227,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 30.57,
"eventListeners": 2463,
"totalBlockingTimeMs": 140,
"frameDurationMs": 19.906944444444434,
"p95FrameDurationMs": 33.19999999999891
},
{
"name": "viewport-pan-sweep",
"durationMs": 8494.372999999996,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.237,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5639.818,
"heapDeltaBytes": -17700100,
"heapUsedBytes": 70804236,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2754.773,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69882121807466,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9002.135000000068,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.282000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5886.098,
"heapDeltaBytes": -16350132,
"heapUsedBytes": 72540336,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2930.654,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697031539888684,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18605.344,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17867.839,
"heapDeltaBytes": -34080824,
"heapUsedBytes": 181603168,
"domNodes": -3045,
"jsHeapTotalBytes": 5906432,
"scriptDurationMs": 285.171,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.06758620689655,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 17965.50500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17026.704999999998,
"heapDeltaBytes": -38992908,
"heapUsedBytes": 173932132,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 289.029,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.172147651006714,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 23007.501000000047,
"styleRecalcs": 180,
"styleRecalcDurationMs": 23.780999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22633.982,
"heapDeltaBytes": -46604332,
"heapUsedBytes": 174998612,
"domNodes": -3045,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 904.709,
"eventListeners": -14915,
"totalBlockingTimeMs": 30,
"frameDurationMs": 42.98897196261682,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 22199.242000000027,
"styleRecalcs": 170,
"styleRecalcDurationMs": 21.46899999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21862.043,
"heapDeltaBytes": -45644056,
"heapUsedBytes": 167695672,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 915.391,
"eventListeners": -14915,
"totalBlockingTimeMs": 9,
"frameDurationMs": 40.76275229357799,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6625.238000000081,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.31,
"layouts": 20,
"layoutDurationMs": 26.897999999999993,
"taskDurationMs": 6531.5120000000015,
"heapDeltaBytes": 979892,
"heapUsedBytes": 224344676,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 113.04099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.025287356321826,
"p95FrameDurationMs": 83.19999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 6444.977999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.36500000000002,
"layouts": 20,
"layoutDurationMs": 25.238999999999997,
"taskDurationMs": 6329.045999999999,
"heapDeltaBytes": -3267260,
"heapUsedBytes": 214150692,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 116.31400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.85361445783132,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9198.295000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8781.144999999999,
"heapDeltaBytes": -33744904,
"heapUsedBytes": 180616452,
"domNodes": -3046,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 141.43799999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.18542372881356,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8944.411000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8639.420000000002,
"heapDeltaBytes": -22659508,
"heapUsedBytes": 180627268,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 137.63800000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.281694915254246,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 152.94200000005276,
"styleRecalcs": 9,
"styleRecalcDurationMs": 20.014,
"layouts": 4,
"layoutDurationMs": 2.092,
"taskDurationMs": 116.788,
"heapDeltaBytes": 3992628,
"heapUsedBytes": 69947984,
"domNodes": 97,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.516999999999994,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555516,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 466.7450000000599,
"styleRecalcs": 14,
"styleRecalcDurationMs": 17.072999999999997,
"layouts": 4,
"layoutDurationMs": 1.7979999999999998,
"taskDurationMs": 121.63100000000001,
"heapDeltaBytes": 5578784,
"heapUsedBytes": 59985168,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.334999999999997,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660714285714285,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1117.986999999971,
"styleRecalcs": 78,
"styleRecalcDurationMs": 113.765,
"layouts": 76,
"layoutDurationMs": 29.776,
"taskDurationMs": 1090.9419999999998,
"heapDeltaBytes": 20130776,
"heapUsedBytes": 86669348,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 461.368,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667164179104475,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1096.324000000095,
"styleRecalcs": 78,
"styleRecalcDurationMs": 113.452,
"layouts": 76,
"layoutDurationMs": 29.22,
"taskDurationMs": 1075.9530000000002,
"heapDeltaBytes": 19551832,
"heapUsedBytes": 86058652,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 458.835,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.185937499999994,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1470.0010000000248,
"styleRecalcs": 78,
"styleRecalcDurationMs": 273.144,
"layouts": 76,
"layoutDurationMs": 29.416,
"taskDurationMs": 1449.7080000000003,
"heapDeltaBytes": 8649392,
"heapUsedBytes": 115185044,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 482.00300000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.31234567901236,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1432.1330000000216,
"styleRecalcs": 78,
"styleRecalcDurationMs": 268.198,
"layouts": 76,
"layoutDurationMs": 28.684,
"taskDurationMs": 1403.2359999999999,
"heapDeltaBytes": 8454772,
"heapUsedBytes": 114915648,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 467.055,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.91500000000001,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20689 +/- ##
=============================================
- Coverage 85.85% 85.85% -0.01%
=============================================
Files 2470 2470
Lines 141057 141066 +9
Branches 36416 36423 +7
=============================================
+ Hits 121110 121112 +2
- Misses 19564 19571 +7
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@DrJKL review ownership is rotating to you for the paired PM-2037 1.56 backports after the previous owner window elapsed without a disposition. Both exact heads are mergeable and final required checks are green with no pending aggregate: #20689 ( |
…ted nodes (PM-2037) (#20601) (#20690) Backport of #20601 to `cloud/1.56`. The automated backport conflicted in `src/stores/previewExposureStore.test.ts`. This resolves that conflict with the same delimiter-bearing locator expectation already reviewed and merged in cloud/1.55 #20654 and core/1.55 #20657; the product/source diff is otherwise the source squash commit. Verified: `src/stores/previewExposureStore.test.ts` and `src/stores/nodeOutputStore.insertWorkflowOutputs.test.ts` pass (19/19) on this branch. Source: #20601 Siblings: #20654 (cloud/1.55), #20657 (core/1.55), #20689 (core/1.56) Co-authored-by: comfy-operator-agent <agent@comfy.org> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Backport of #20601 to
core/1.56.The automated backport conflicted in
src/stores/previewExposureStore.test.ts. This resolves that conflict with the same delimiter-bearing locator expectation already reviewed and merged in cloud/1.55 #20654 and core/1.55 #20657; the product/source diff is otherwise the source squash commit.Verified:
src/stores/previewExposureStore.test.tsandsrc/stores/nodeOutputStore.insertWorkflowOutputs.test.tspass (19/19) on this branch.Source: #20601
Siblings: #20654 (cloud/1.55), #20657 (core/1.55)