Repository navigation
[backport core/1.56] FE-3297 refactor(auth): use bridge types 0.5.0 and report Desktop workspace refresh failures (#20531) - #20579
Conversation
…kspace refresh failures (#20531) This PR closes out two follow-ups from FE-3297. It moves the Desktop host bridge types to `@comfyorg/comfyui-desktop-bridge-types` 0.5.0, and it reports a refresh failure that was previously swallowed. **Why:** - 0.5.0, published with Comfy-Org/Comfy-Desktop#1671, adds `switchWorkspace` to `ComfyDesktop2AuthBridge`. Since #20500 we have kept a local copy of that one member, which can now go. - A CodeRabbit finding on #20484 (deferred so the approved head would not be reset): when the tab follows a Desktop workspace switch and the list refresh fails, the failure was swallowed by `.catch(() => undefined)`. **How:** - Pin 0.5.0, with the release-age exclusion moved from 0.4.0 to 0.5.0. `DesktopHostAuthBridge` is now the package type with `switchWorkspace` made optional. Desktop builds older than #1671 do not ship that method, and the account menu already falls back to a fixed workspace row for them. - `followDesktopHostWorkspace` reports the refresh failure via `reportError` (`error_refreshing_workspaces_for_desktop_host`). The tab still keeps no active workspace, which is the fail-closed behaviour Christian asked for on #20484. No UI change, so there are no AS IS/TO BE screenshots. - The new store test (a failed refresh is reported and the active workspace stays null) fails on `main` and passes here. - Desktop host, auth store, workspace store and account popover suites: 318 tests pass. - `pnpm typecheck:app` is clean. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 45e4e16)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 10f72b441c22c12f24ae4cb8196f9ba20971311a
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2198 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T20:28:58.063Z",
"gitSha": "3881850dd691e2e756be04df86ffb340037caa83",
"branch": "backport-20531-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.1339999999846,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.575999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.20000000000005,
"heapDeltaBytes": 522036,
"heapUsedBytes": 68743420,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.431,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2011.2950000000183,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8249999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.44,
"heapDeltaBytes": -3787600,
"heapUsedBytes": 56095896,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.351999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.6169999999702,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.434999999999999,
"layouts": 12,
"layoutDurationMs": 3.843,
"taskDurationMs": 621.474,
"heapDeltaBytes": -2110664,
"heapUsedBytes": 66010332,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 125.607,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1697.2710000000006,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.862999999999998,
"layouts": 12,
"layoutDurationMs": 3.668,
"taskDurationMs": 636.932,
"heapDeltaBytes": -2108800,
"heapUsedBytes": 65437748,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 123.528,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.7050000000186,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.197999999999999,
"layouts": 6,
"layoutDurationMs": 1.044,
"taskDurationMs": 293.34700000000004,
"heapDeltaBytes": 3752524,
"heapUsedBytes": 70970220,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.975999999999994,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.1919999999454,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.030999999999999,
"layouts": 6,
"layoutDurationMs": 1.0090000000000001,
"taskDurationMs": 262.551,
"heapDeltaBytes": 3761484,
"heapUsedBytes": 71230360,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.928000000000006,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 534.3139999999948,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.9859999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.463,
"heapDeltaBytes": -7101460,
"heapUsedBytes": 61685764,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 132.275,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 555.0459999999475,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.384,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.86899999999997,
"heapDeltaBytes": -6814308,
"heapUsedBytes": 61207424,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 133.937,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 997.4189999999794,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.819,
"heapDeltaBytes": 15516032,
"heapUsedBytes": 85202852,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 50.82399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 370,
"frameDurationMs": 29.41176470588235,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1021.6970000000174,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.2750000000001,
"heapDeltaBytes": 15666444,
"heapUsedBytes": 85427464,
"domNodes": 0,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 52.36800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 384,
"frameDurationMs": 29.902941176470584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 784.3710000000215,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.341,
"heapDeltaBytes": 16719876,
"heapUsedBytes": 104126980,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 114.61699999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 801.5609999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.6240000000002,
"heapDeltaBytes": 17371432,
"heapUsedBytes": 103672072,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 113.039,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6597.442000000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.697999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5860.405,
"heapDeltaBytes": -367256,
"heapUsedBytes": 84707708,
"domNodes": -173,
"jsHeapTotalBytes": -8523776,
"scriptDurationMs": 4690.529,
"eventListeners": -82,
"totalBlockingTimeMs": 42,
"frameDurationMs": 25.48146718146718,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6686.227000000031,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0670000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6033.762,
"heapDeltaBytes": 8343408,
"heapUsedBytes": 93532892,
"domNodes": -143,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 4874.2080000000005,
"eventListeners": -82,
"totalBlockingTimeMs": 53,
"frameDurationMs": 24.936940298507462,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6554.982000000053,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9439999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6039.567,
"heapDeltaBytes": -2491604,
"heapUsedBytes": 82224096,
"domNodes": -142,
"jsHeapTotalBytes": -9048064,
"scriptDurationMs": 4837.776,
"eventListeners": -74,
"totalBlockingTimeMs": 35,
"frameDurationMs": 25.48560311284047,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6254.252000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5706.303999999999,
"heapDeltaBytes": -352276,
"heapUsedBytes": 84537140,
"domNodes": -142,
"jsHeapTotalBytes": -11407360,
"scriptDurationMs": 4600.002,
"eventListeners": -78,
"totalBlockingTimeMs": 47,
"frameDurationMs": 25.099196787148593,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2010.5230000000347,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0110000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.11800000000005,
"heapDeltaBytes": -9168220,
"heapUsedBytes": 79244212,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.968000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.903000000032,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1719999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.31899999999996,
"heapDeltaBytes": -9409548,
"heapUsedBytes": 79097236,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.972999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2126.640000000009,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.431,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1278.5120000000002,
"heapDeltaBytes": -18146844,
"heapUsedBytes": 71860020,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 704.675,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2139.120999999932,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.378999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1295.0030000000002,
"heapDeltaBytes": -18848368,
"heapUsedBytes": 70684104,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 676.8230000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3184.0329999999994,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.186,
"layouts": 60,
"layoutDurationMs": 13.256,
"taskDurationMs": 1328.7,
"heapDeltaBytes": 1231204,
"heapUsedBytes": 69984184,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 631.995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665445026178013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3252.6710000000776,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.595999999999998,
"layouts": 60,
"layoutDurationMs": 13.364,
"taskDurationMs": 1368.866,
"heapDeltaBytes": 25853888,
"heapUsedBytes": 94297928,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 657.8389999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2209.0160000000196,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.5909999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1495.8700000000001,
"heapDeltaBytes": 2278652,
"heapUsedBytes": 70894848,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 790.381,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793893129770993,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2377.5419999999485,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.399999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1579.062,
"heapDeltaBytes": 5993532,
"heapUsedBytes": 75458732,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 842.931,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78368794326241,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2020.8480000000009,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.928,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.764,
"heapDeltaBytes": -8675172,
"heapUsedBytes": 81954124,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.29500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2020.1739999999972,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.865000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.324,
"heapDeltaBytes": -8518160,
"heapUsedBytes": 81833480,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.673000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 507.0529999999849,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.534000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.589,
"heapDeltaBytes": 10756100,
"heapUsedBytes": 74146492,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.632,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 506.54199999996763,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.510000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.53400000000005,
"heapDeltaBytes": 10363340,
"heapUsedBytes": 71948892,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.314,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2020.4380000000128,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.6689999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.442,
"heapDeltaBytes": 1122924,
"heapUsedBytes": 71845432,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.881,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.045000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.881,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.141,
"heapDeltaBytes": 1095048,
"heapUsedBytes": 72120636,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.248999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.2909999999642,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.263,
"layouts": 16,
"layoutDurationMs": 4.718,
"taskDurationMs": 566.92,
"heapDeltaBytes": -5996276,
"heapUsedBytes": 63524492,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 83.482,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.391999999917,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.298,
"layouts": 16,
"layoutDurationMs": 5.003,
"taskDurationMs": 507.54699999999997,
"heapDeltaBytes": -5891912,
"heapUsedBytes": 65106024,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 84.968,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 833.6229999999887,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.581999999999997,
"layouts": 5,
"layoutDurationMs": 10.623999999999999,
"taskDurationMs": 558.279,
"heapDeltaBytes": 1255084,
"heapUsedBytes": 92030200,
"domNodes": 14227,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 20.63799999999999,
"eventListeners": 2463,
"totalBlockingTimeMs": 84,
"frameDurationMs": 19.840476190476195,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8147.906999999976,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.44799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4326.6050000000005,
"heapDeltaBytes": -18478284,
"heapUsedBytes": 70802888,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2215.783,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666053169734152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8212.740999999936,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.137,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4505.927,
"heapDeltaBytes": -15149236,
"heapUsedBytes": 73669408,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2319.1759999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659229208925,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14702.112999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14175.830000000002,
"heapDeltaBytes": -31328724,
"heapUsedBytes": 182437064,
"domNodes": -3045,
"jsHeapTotalBytes": 9981952,
"scriptDurationMs": 209.299,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.743432574430823,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14386.72500000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13839.38,
"heapDeltaBytes": -32676736,
"heapUsedBytes": 180738784,
"domNodes": -3045,
"jsHeapTotalBytes": 8671232,
"scriptDurationMs": 203.904,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.440636042402822,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17984.59300000002,
"styleRecalcs": 138,
"styleRecalcDurationMs": 15.464000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17602.014,
"heapDeltaBytes": -27611216,
"heapUsedBytes": 174979880,
"domNodes": -3045,
"jsHeapTotalBytes": 4915200,
"scriptDurationMs": 724.143,
"eventListeners": -14915,
"totalBlockingTimeMs": 2,
"frameDurationMs": 34.317938931297704,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17327.00299999999,
"styleRecalcs": 139,
"styleRecalcDurationMs": 15.193000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16902.927000000003,
"heapDeltaBytes": -28920464,
"heapUsedBytes": 184642396,
"domNodes": -3045,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 698.0360000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 8,
"frameDurationMs": 32.368097014925375,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5352.0589999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.30400000000002,
"layouts": 20,
"layoutDurationMs": 22.231,
"taskDurationMs": 5277.339000000001,
"heapDeltaBytes": 1048736,
"heapUsedBytes": 214310908,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 85.784,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.718404907975454,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 5151.036999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.336,
"layouts": 20,
"layoutDurationMs": 22.378999999999998,
"taskDurationMs": 5071.681,
"heapDeltaBytes": 1207356,
"heapUsedBytes": 214870108,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 81.14200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.788271604938277,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7445.713000000069,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7144.876000000002,
"heapDeltaBytes": -23849528,
"heapUsedBytes": 179606980,
"domNodes": -3046,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 106.32800000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.73741007194244,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7685.976000000096,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7462.5419999999995,
"heapDeltaBytes": -18039108,
"heapUsedBytes": 185481052,
"domNodes": -3045,
"jsHeapTotalBytes": 14368768,
"scriptDurationMs": 108.11099999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.863636363636356,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 97.63899999995829,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.261999999999999,
"layouts": 3,
"layoutDurationMs": 1.6039999999999996,
"taskDurationMs": 77.765,
"heapDeltaBytes": 3846052,
"heapUsedBytes": 70736704,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.684999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 89.42999999999302,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.466,
"layouts": 3,
"layoutDurationMs": 1.1769999999999998,
"taskDurationMs": 59.056,
"heapDeltaBytes": 3740444,
"heapUsedBytes": 63013264,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.293000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 565.394000000083,
"styleRecalcs": 78,
"styleRecalcDurationMs": 82.187,
"layouts": 76,
"layoutDurationMs": 20.374,
"taskDurationMs": 539.685,
"heapDeltaBytes": -17414904,
"heapUsedBytes": 68043628,
"domNodes": 76,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 200.62099999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 563.3909999999105,
"styleRecalcs": 78,
"styleRecalcDurationMs": 82.387,
"layouts": 76,
"layoutDurationMs": 20.562,
"taskDurationMs": 532.54,
"heapDeltaBytes": -17434580,
"heapUsedBytes": 67357188,
"domNodes": 76,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 196.25400000000002,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1172.6240000000416,
"styleRecalcs": 78,
"styleRecalcDurationMs": 246.16,
"layouts": 76,
"layoutDurationMs": 25.529,
"taskDurationMs": 1141.7030000000002,
"heapDeltaBytes": -20275888,
"heapUsedBytes": 109278816,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 347.42,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1131.864999999948,
"styleRecalcs": 78,
"styleRecalcDurationMs": 242.73,
"layouts": 76,
"layoutDurationMs": 25.977,
"taskDurationMs": 1097.0849999999998,
"heapDeltaBytes": 6828248,
"heapUsedBytes": 113242988,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 335.306,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.91176470588235,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20579 +/- ##
=============================================
- Coverage 85.85% 85.11% -0.75%
=============================================
Files 2465 3504 +1039
Lines 140908 168662 +27754
Branches 36358 44261 +7903
=============================================
+ Hits 120979 143549 +22570
- Misses 19549 23127 +3578
- Partials 380 1986 +1606
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1048 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport of already-approved #20531 (bridge types 0.5.0 bump + optional switchWorkspace + surfaced refreshWorkspaces failure reporting) onto core/1.56. Diff is byte-identical to #20531's +/- lines (same files: desktopHostAuthBridge.ts, teamWorkspaceStore.ts/test, pnpm-lock.yaml, pnpm-workspace.yaml); no package.json exports touched. CI green (112 success, 23 skipped). No open review threads. Verified at exact head c1e912becaf5b061786861b6e6ba3e95f09fd5ff.
Backport of #20531 to
core/1.56.Why: the bot's cherry-pick failed, and the 1.56 line should carry the bridge types 0.5.0 bump and the reported Desktop workspace refresh failure before 1.56.3 is cut for the Desktop SSO internal test.
Root cause (of the conflict):
pnpm-workspace.yamlminimumReleaseAgeExcludeoncore/1.56also lists@comfyorg/comfy-multi-player@0.3.6, next to the bridge-types0.4.0entry that #20531 replaces.How: cherry-picked the merge commit and kept the multi-player entry, replacing bridge-types
0.4.0with0.5.0. The rest applied cleanly.pnpm install --frozen-lockfileresolves; the workspace store and Desktop host suites pass (125 tests).AS IS / TO BE: no UI change.