Repository navigation
[backport cloud/1.56] fix: only create async work for extensions that define the hook (#20522) - #20787
Conversation
<!-- claude-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1791441407831319?thread_ts=1791441407.831319&cid=C0A4XMHANP3)_ Refs #17124 **Before:** `invokeExtensionsAsync` mapped every enabled extension through an `async` function, so each call allocated a wrapper promise per extension even when the extension had no such hook, or the hook returned synchronously. It runs once per node def (`beforeRegisterNodeDef`), so nodes x extensions promises (about 6M on a 6k-node, 1k-extension install) piled onto the microtask queue at startup. **After:** a plain synchronous loop. Extensions without the hook do no work, hooks that return synchronously are never wrapped or awaited, and only promises that hooks actually return are awaited. Based on the shape suggested by Austin Mroz. How: per extension, read `ext[method]` and skip it if it is not a function, call it, and collect the result. If the result is a promise or thenable it gets a `.catch` that logs the error (same message as before). The call resolves with `Promise.all` over the collected results. `setup` keeps its `legacyMenuCompat` set/clear via a small async wrapper (set before the call, cleared in `finally`, so also on throw or rejection). The property read and call are inside a per-extension try/catch, so a throwing getter or Proxy trap is logged for that extension only, where previously a throwing `in` check rejected the whole call. Preserved: same snapshot of `enabledExtensions` per call, in-order concurrent invocation, inherited prototype hooks, hooks added by an earlier hook mid-call, and the same error log message and context. Hook return values (sync or async, falsy values included) are still returned. Behavior differences: - The resolved array contains only the results of extensions that define the hook, so it is no longer index-aligned with the extensions (before, extensions without the hook left an `undefined` slot). Nothing in this repo uses the return value; all call sites discard it. - Hooks that return synchronously are not awaited. They were already invoked synchronously within the call before, so start timing is unchanged. - The hook is detected by reading the property rather than `in`, so a Proxy that only defines a `has` trap is no longer consulted. Non-function values are still skipped silently, as before. Limitation: this only partially fixes the Firefox slowness (reporter measured about 110s to 61s on a real install); the remainder looks like a separate Firefox/SpiderMonkey issue. The unbounded `Promise.all` over node defs in `registerNodesFromDefs` (`app.ts`) is intentionally left as-is: chunking it was tried and dropped pending a Firefox and Chromium startup benchmark. - Tests: reworked `invokeExtensionsAsync` suite in `src/services/extensionService.test.ts` (35 tests pass), plus `src/services`, `app.test.ts` and `SelectionToolbox.test.ts`. - `pnpm typecheck`, oxlint, eslint and oxfmt are clean. --------- Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 902a740)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-12T18:42:44.433Z",
"gitSha": "28f476bef72db23bb915a812205cdf7f01ba6c16",
"branch": "be5708-backport-20522-cloud-156",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.7430000000145,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.352,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 267.353,
"heapDeltaBytes": 700100,
"heapUsedBytes": 68488676,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.895,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.3330000000265,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.1400000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 257.413,
"heapDeltaBytes": 677648,
"heapUsedBytes": 67279512,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.094999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1679.1089999999826,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.393,
"layouts": 12,
"layoutDurationMs": 4.314,
"taskDurationMs": 575.615,
"heapDeltaBytes": -2323004,
"heapUsedBytes": 66315464,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 121.03999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1672.8460000000496,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.220000000000002,
"layouts": 12,
"layoutDurationMs": 4.176,
"taskDurationMs": 516.025,
"heapDeltaBytes": -2168712,
"heapUsedBytes": 64461344,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 109.067,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.1480000000038,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.548000000000002,
"layouts": 6,
"layoutDurationMs": 1.1500000000000001,
"taskDurationMs": 234.67,
"heapDeltaBytes": 3887200,
"heapUsedBytes": 71921764,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.26,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.0659999999461,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.418,
"layouts": 6,
"layoutDurationMs": 1.409,
"taskDurationMs": 238.701,
"heapDeltaBytes": 3922540,
"heapUsedBytes": 70732232,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.144999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 527.8059999999982,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.152999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.527,
"heapDeltaBytes": -6679900,
"heapUsedBytes": 61084328,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 111.453,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66250000000001,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 526.4329999999973,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.428,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.983,
"heapDeltaBytes": -6466784,
"heapUsedBytes": 61656700,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 112.698,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 910.1420000000076,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.86,
"heapDeltaBytes": 12133048,
"heapUsedBytes": 92340476,
"domNodes": 0,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 42.824000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 297,
"frameDurationMs": 26.958823529411774,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 881.5500000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.65099999999995,
"heapDeltaBytes": 11773576,
"heapUsedBytes": 92486544,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 40.336,
"eventListeners": 0,
"totalBlockingTimeMs": 271,
"frameDurationMs": 26.766666666666673,
"p95FrameDurationMs": 33.5
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 720.0220000000286,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.9179999999999,
"heapDeltaBytes": 17642088,
"heapUsedBytes": 97991316,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 105.547,
"eventListeners": 0,
"totalBlockingTimeMs": 94,
"frameDurationMs": 20.474285714285724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 701.4120000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 272.28200000000015,
"heapDeltaBytes": 17169264,
"heapUsedBytes": 97015264,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 98.50200000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 92,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6141.638999999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0270000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5137.275,
"heapDeltaBytes": 2641264,
"heapUsedBytes": 87017348,
"domNodes": -142,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 4007.528,
"eventListeners": -74,
"totalBlockingTimeMs": 28,
"frameDurationMs": 21.353124999999995,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6188.785999999993,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.557000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5130.329,
"heapDeltaBytes": -6897232,
"heapUsedBytes": 77218708,
"domNodes": -171,
"jsHeapTotalBytes": -3018752,
"scriptDurationMs": 4018.4819999999995,
"eventListeners": -78,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.61923076923077,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5815.525000000036,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0679999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4983.85,
"heapDeltaBytes": 8142180,
"heapUsedBytes": 85470352,
"domNodes": -142,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 3900.902,
"eventListeners": -78,
"totalBlockingTimeMs": 4,
"frameDurationMs": 20.998194945848375,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5747.382000000016,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.448999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4864.478,
"heapDeltaBytes": -9263044,
"heapUsedBytes": 67764240,
"domNodes": -142,
"jsHeapTotalBytes": -11669504,
"scriptDurationMs": 3771.604,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.75703971119134,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2008.9130000000068,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7219999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.49499999999995,
"heapDeltaBytes": -10695324,
"heapUsedBytes": 76412396,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 28.480999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2010.2729999999838,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0860000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.62999999999994,
"heapDeltaBytes": 14770376,
"heapUsedBytes": 88139184,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 28.488000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2117.3459999999977,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.192,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1119.725,
"heapDeltaBytes": -19899648,
"heapUsedBytes": 68773808,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 584.149,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873018,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2177.794000000006,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.139,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1187.707,
"heapDeltaBytes": 9315080,
"heapUsedBytes": 83209448,
"domNodes": 0,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 616.4229999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153847,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3089.556000000016,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.333,
"layouts": 60,
"layoutDurationMs": 15.239,
"taskDurationMs": 1156.7620000000002,
"heapDeltaBytes": -20640868,
"heapUsedBytes": 69329944,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 533.435,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3099.462000000017,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.018,
"layouts": 60,
"layoutDurationMs": 15.76,
"taskDurationMs": 1187.576,
"heapDeltaBytes": 5721604,
"heapUsedBytes": 91656072,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 542.073,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2288.607000000013,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.565999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1371.736,
"heapDeltaBytes": 4654620,
"heapUsedBytes": 72876052,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 705.582,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788235294117648,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2235.8879999999886,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.199000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1396.671,
"heapDeltaBytes": 4349836,
"heapUsedBytes": 72584968,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 732.418,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666165413533832,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.430000000033,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6300000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.85800000000006,
"heapDeltaBytes": -9387148,
"heapUsedBytes": 79773620,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 27.118000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.448999999985,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.6109999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 304.694,
"heapDeltaBytes": -9283308,
"heapUsedBytes": 79155856,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.628000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 509.7949999999969,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.096,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.463,
"heapDeltaBytes": -12549620,
"heapUsedBytes": 58210188,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 114.70100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 443.88600000002043,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.775000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 281.242,
"heapDeltaBytes": -11898356,
"heapUsedBytes": 57888184,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 98.165,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.069999999956,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.441000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 267.949,
"heapDeltaBytes": 1215548,
"heapUsedBytes": 71226248,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.174999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2009.947000000011,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.9629999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 251.19599999999997,
"heapDeltaBytes": 1171072,
"heapUsedBytes": 72024332,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.153000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.2910000000347,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.466,
"layouts": 16,
"layoutDurationMs": 5.0569999999999995,
"taskDurationMs": 560.169,
"heapDeltaBytes": -6163612,
"heapUsedBytes": 63601444,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 87.51700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.710000000006,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.982,
"layouts": 16,
"layoutDurationMs": 5.221,
"taskDurationMs": 577.5989999999999,
"heapDeltaBytes": -5888992,
"heapUsedBytes": 64116588,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.26,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 816.519000000028,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.709000000000007,
"layouts": 5,
"layoutDurationMs": 9.290999999999999,
"taskDurationMs": 569.8990000000001,
"heapDeltaBytes": -535412,
"heapUsedBytes": 89528464,
"domNodes": 14227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 20.921999999999997,
"eventListeners": 2463,
"totalBlockingTimeMs": 63,
"frameDurationMs": 19.44285714285715,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 8282.492999999988,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.788,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4285.391,
"heapDeltaBytes": 13171544,
"heapUsedBytes": 97707468,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 2175.935,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699596774193548,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8175.489999999968,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.364,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4146.26,
"heapDeltaBytes": -17629832,
"heapUsedBytes": 69652596,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2056.639,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666326530612242,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12499.633000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11707.522,
"heapDeltaBytes": -46727232,
"heapUsedBytes": 179820412,
"domNodes": -3045,
"jsHeapTotalBytes": 6721536,
"scriptDurationMs": 217.24300000000002,
"eventListeners": -14914,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.40308219178082,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 12538.53499999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11954.989999999998,
"heapDeltaBytes": -45748620,
"heapUsedBytes": 181465512,
"domNodes": -3050,
"jsHeapTotalBytes": 8671232,
"scriptDurationMs": 175.839,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.350596252129474,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 14642.074999999977,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.996999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14002.005000000001,
"heapDeltaBytes": -24766604,
"heapUsedBytes": 174791036,
"domNodes": -3045,
"jsHeapTotalBytes": 4739072,
"scriptDurationMs": 660.54,
"eventListeners": -14915,
"totalBlockingTimeMs": 47,
"frameDurationMs": 26.00354609929078,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 14863.430999999991,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.278999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14231.442,
"heapDeltaBytes": -37856884,
"heapUsedBytes": 175195864,
"domNodes": -3045,
"jsHeapTotalBytes": 6901760,
"scriptDurationMs": 628.947,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.405150976909415,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4530.732999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.793000000000006,
"layouts": 20,
"layoutDurationMs": 23.27799999999999,
"taskDurationMs": 4410.206999999999,
"heapDeltaBytes": -6212256,
"heapUsedBytes": 215591260,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 78.18999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.771584699453545,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4579.633000000058,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.91799999999999,
"layouts": 20,
"layoutDurationMs": 23.442000000000004,
"taskDurationMs": 4475.788,
"heapDeltaBytes": 14729180,
"heapUsedBytes": 213085120,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 73.20400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.60391061452514,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6415.401000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6037.23,
"heapDeltaBytes": -25748392,
"heapUsedBytes": 182642228,
"domNodes": -3045,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 91.107,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.604040404040408,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6352.737000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5939.505,
"heapDeltaBytes": -27695480,
"heapUsedBytes": 180333184,
"domNodes": -3045,
"jsHeapTotalBytes": 7536640,
"scriptDurationMs": 91.32700000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.165666666666663,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 447.5259999999821,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.104999999999997,
"layouts": 4,
"layoutDurationMs": 1.7910000000000004,
"taskDurationMs": 111.145,
"heapDeltaBytes": 6079220,
"heapUsedBytes": 71733924,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.984999999999996,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 442.8940000000239,
"styleRecalcs": 17,
"styleRecalcDurationMs": 16.912000000000003,
"layouts": 3,
"layoutDurationMs": 1.4460000000000002,
"taskDurationMs": 95.887,
"heapDeltaBytes": 5724964,
"heapUsedBytes": 70986216,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.43,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 452.7219999999943,
"styleRecalcs": 78,
"styleRecalcDurationMs": 82.651,
"layouts": 76,
"layoutDurationMs": 20.022000000000002,
"taskDurationMs": 411.665,
"heapDeltaBytes": -10912032,
"heapUsedBytes": 77655520,
"domNodes": 76,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 130.325,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962983,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 446.16499999995085,
"styleRecalcs": 78,
"styleRecalcDurationMs": 84.335,
"layouts": 76,
"layoutDurationMs": 20.797,
"taskDurationMs": 412.48999999999995,
"heapDeltaBytes": 13466160,
"heapUsedBytes": 88742640,
"domNodes": 76,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 134.272,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 832.7729999999747,
"styleRecalcs": 78,
"styleRecalcDurationMs": 228.78699999999998,
"layouts": 76,
"layoutDurationMs": 25.261,
"taskDurationMs": 814.097,
"heapDeltaBytes": -17728832,
"heapUsedBytes": 106857848,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 203.27599999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665999999999986,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 859.5510000000104,
"styleRecalcs": 78,
"styleRecalcDurationMs": 227.352,
"layouts": 76,
"layoutDurationMs": 25.047,
"taskDurationMs": 826.3130000000001,
"heapDeltaBytes": -17678512,
"heapUsedBytes": 108747188,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 210.74499999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2203 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 645ba9a6b49f255af363c5f7378e4d8242ec4847
Full docs: ADR-DEVEX-LINT-0015 |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.56 #20787 +/- ##
=============================================
Coverage ? 85.88%
=============================================
Files ? 2484
Lines ? 141675
Branches ? 36271
=============================================
Hits ? 121677
Misses ? 19615
Partials ? 383
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Manual backport of #20522 to
cloud/1.56for BE-5708. The automated backport detected release-line conflicts insrc/services/extensionService.tsand its tests; this PR preserves the release branch's existing bootstrap tracing and carries the hook fan-out optimization.Validation
pnpm exec vitest run src/services/extensionService.test.ts --pool=forks --maxWorkers=2— 17 passedpnpm exec oxfmt --check src/services/extensionService.ts src/services/extensionService.test.ts— passedgit diff --check— passedOriginal: #20522
Issue: BE-5708