Repository navigation
[backport cloud/1.55] feat(agent): add an asset tray with independent inline references (#20156) - #20518
Conversation
…0156) Separate attached assets from inline references so users can build a prompt naturally while keeping their files in a visible asset tray. - **A separate asset tray.** Added assets appear above the prompt as thumbnails or type icons, with transparent backgrounds and no borders. Filenames appear on hover. The circular × appears on hover or keyboard focus, and stays visible on touch devices. The extra node-reference row is removed. - **Assets referenced inline with `@`.** Users can search by asset name and select with the mouse or keyboard to insert at the caret. The same asset can be referenced unlimited times. Assets sit alongside the existing node and workflow options. - **Consistent, compact inline chips.** Asset, node and workflow chips share the same appearance and removal interaction, with no left/right padding. Chips fit within the compact composer line height. Removing a chip deletes only that occurrence, supports Undo and returns focus for continued typing. - **Different hover behavior for tray and inline.** Tray hover shows the filename and a large image or media preview. Click, keyboard and touch can open an interactive preview. Activating another asset replaces the current preview, so only one stays open. Inline hover/focus highlights the corresponding tray asset without opening a preview, so inserting a chip beneath the pointer doesn't interrupt typing. - **Video and audio support.** Videos share one thumbnail across the tray, `@` menu and inline chips. Audio uses the music icon throughout, including renamed files. Tray previews provide native playback controls with no autoplay. Closing, replacing or removing a preview stops and resets playback, including quick close/reopen. Audio controls are inset within the card’s corners. - **Discoverable tray scrolling.** Many assets stay in one horizontally scrollable row at a consistent size. Arrows and edge fades indicate additional content. Controls reflect scroll boundaries and update as assets or panel width change. - **The whole chat panel accepts drops.** Users can drop supported files or drag assets from the in-app library anywhere in the panel. Drop feedback covers the panel while preserving composer layout and input. Library drops work for unnamed assets and re-additions after removal or sending; already included library assets remain deduplicated. - **Duplicate additions stay clear.** Adding an included file or library asset again keeps one tray item and shows a brief filename notice; a batch reports the number skipped while unique files continue uploading. Removing an asset and adding it again is allowed, and repeated inline mentions remain unlimited. - **Stable composer sizing.** Production-style compact text spacing is retained. Inline chips don't expand the line height. Starting to type doesn't shrink the composer when its placeholder wraps onto multiple lines. - **Clear attachment and removal rules.** Adding an asset doesn't automatically mention it. Removing an inline occurrence keeps the asset in the tray; removing the tray asset removes all its mentions. Sending includes each tray asset once, even when unmentioned or referenced repeatedly. Asset-only messages work. Failed sends restore an untouched draft; newer input takes priority. - **Visible upload feedback.** Pending-upload status stays visible outside the horizontally scrolling tray. Users can see why Send is unavailable, and pressing Enter preserves their draft while uploads are pending. - **Theme-aware styling and fresh node references.** Asset surfaces, previews, highlights and controls follow the active theme. The `@` node list follows the eligible viewed graph as nodes are added, renamed or removed, and updates when switching graphs without another keystroke. Check the distinction between tray inclusion and inline occurrences, draft recovery after a failed send, and preview cleanup after removal, replacement or successful sending. Preserve the bulk-layout/action guarantees from #20110 and the upload-feedback behavior overlapping Validation: 553 tests pass across ten focused unit/component suites after merging latest main. All 14 focused Chromium browser regressions pass with retries disabled: exclusive previews, native media close/reopen and replacement, single/plural duplicate notices, mixed pending batches, grid/list null-name library re-addition, touch disclosure/removal, node rename/delete/undo freshness, shared posters and short-panel geometry. Touch was emulated; physical devices were not exercised. Normal commit and Knip/Fallow push gates pass without added suppressions or baseline changes. Remote CI is pending for this update. this PR. File deduplication uses browser file metadata (name, size, lastModified and MIME type); library additions use stable source identity. It does not hash local file bytes or retroactively remove duplicates from an already-open draft. - Upgrade and full related-ticket map: [FE-3219](https://linear.app/comfyorg/issue/FE-3219/agent-composer-asset-tray-with-independent-inline-references). - Fixes tracked within this PR: [FE-3220](https://linear.app/comfyorg/issue/FE-3220/fix-stale-node-candidates-in-the-agent-picker) (stale `@` node candidates) and [FE-3221](https://linear.app/comfyorg/issue/FE-3221/fix-unnamed-and-re-added-library-asset-drops-into-agent-chat) (unnamed/re-added library drops). - QA: [CQA-1080](https://linear.app/comfyorg/issue/CQA-1080/asset-tray-independent-inline-asset-references-in-agent-composer-20156). Related product reports: [PM-1230](https://linear.app/comfyorg/issue/PM-1230) / [PM-1231](https://linear.app/comfyorg/issue/PM-1231) cover attachment/reference confusion. [PM-1126](https://linear.app/comfyorg/issue/PM-1126) / [PM-1127](https://linear.app/comfyorg/issue/PM-1127) are partially aligned: mentions become optional, but this PR uses a tray rather than their proposed Reference-panel section. [FE-2209](https://linear.app/comfyorg/issue/FE-2209) was reopened for the approved composer rework and is In Review: show nodes once inline, keep useful asset previews, and preserve sent-message rendering. This upgrade also changes asset removal so deleting an inline occurrence keeps the included file. Upstream overlap: [PM-1954](https://linear.app/comfyorg/issue/PM-1954) / [FE-3202](https://linear.app/comfyorg/issue/FE-3202) retain ownership of bulk-layout/upload-feedback fixes (#20110, #20150, #20152); their guarantees are preserved here. These related links do not assert that every older ticket is fully resolved. Media scope from #20157 is included here, with QA in [CQA-1081](https://linear.app/comfyorg/issue/CQA-1081/shared-video-posters-and-hover-playback-for-agent-media-attachments). --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2152 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b5e42d186818656836d7679deb08d5a999e416e3
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-08T07:06:20.108Z",
"gitSha": "79d1c1329dc7d660c91e74a41c001f4527803ec8",
"branch": "backport-20156-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.1020000000317,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.512,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.69100000000003,
"heapDeltaBytes": -10760320,
"heapUsedBytes": 58547508,
"domNodes": -262,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.081999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.076000000031,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.969,
"heapDeltaBytes": 8205836,
"heapUsedBytes": 77372992,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.269,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1738.129000000015,
"styleRecalcs": 44,
"styleRecalcDurationMs": 15.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 816.168,
"heapDeltaBytes": 11528208,
"heapUsedBytes": 80634056,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 166.71800000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.0680000000702,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.725,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 816.855,
"heapDeltaBytes": 2717648,
"heapUsedBytes": 71516068,
"domNodes": -264,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 163.94400000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.0419999999876,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.571000000000002,
"layouts": 6,
"layoutDurationMs": 0.9809999999999999,
"taskDurationMs": 333.49700000000007,
"heapDeltaBytes": 3329328,
"heapUsedBytes": 72619052,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.838000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.5380000000123,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.245999999999999,
"layouts": 6,
"layoutDurationMs": 1.0559999999999996,
"taskDurationMs": 339.056,
"heapDeltaBytes": 3546304,
"heapUsedBytes": 73041400,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.122,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 672.2050000000195,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.454999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.11300000000006,
"heapDeltaBytes": -7384560,
"heapUsedBytes": 61862036,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 176.216,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 634.3819999999596,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.975999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.83099999999996,
"heapDeltaBytes": -7758352,
"heapUsedBytes": 61412924,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 168.52100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1270.7189999999855,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 922.008,
"heapDeltaBytes": 29473716,
"heapUsedBytes": 101023148,
"domNodes": -295,
"jsHeapTotalBytes": 17453056,
"scriptDurationMs": 73.864,
"eventListeners": -217,
"totalBlockingTimeMs": 628,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1271.449999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 940.266,
"heapDeltaBytes": -17556312,
"heapUsedBytes": 73701860,
"domNodes": -294,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 75.38199999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 591,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.368999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.4900000000004,
"heapDeltaBytes": 15067792,
"heapUsedBytes": 92062360,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.255,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.1709999999603,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.45399999999927,
"heapDeltaBytes": 15229152,
"heapUsedBytes": 92435576,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.23100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11083.743999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10065.125,
"heapDeltaBytes": -1030948,
"heapUsedBytes": 80566772,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8483.751999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1633,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11084.573999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10186.114,
"heapDeltaBytes": 19709812,
"heapUsedBytes": 94637248,
"domNodes": -4,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8576.568,
"eventListeners": 0,
"totalBlockingTimeMs": 1461,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10135.18499999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9215.462000000001,
"heapDeltaBytes": 3101220,
"heapUsedBytes": 84665352,
"domNodes": -18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7707.986,
"eventListeners": 0,
"totalBlockingTimeMs": 1107,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10478.301999999985,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.1439999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9581.279999999999,
"heapDeltaBytes": -9866316,
"heapUsedBytes": 69714732,
"domNodes": -271,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 8016.426000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 1165,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2028.568000000007,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.559999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.2780000000001,
"heapDeltaBytes": -16394840,
"heapUsedBytes": 73615820,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 35.14,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.8480000000063,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.080999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.267,
"heapDeltaBytes": -19070768,
"heapUsedBytes": 71010036,
"domNodes": -244,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 33.186,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2247.7219999999534,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.86,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1622.5550000000003,
"heapDeltaBytes": -2123016,
"heapUsedBytes": 88188356,
"domNodes": -256,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 859.58,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2283.959999999979,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.298000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1625.4470000000001,
"heapDeltaBytes": -1852116,
"heapUsedBytes": 88207924,
"domNodes": -256,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 876.2030000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3651.949000000002,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.671000000000001,
"layouts": 60,
"layoutDurationMs": 13.629999999999999,
"taskDurationMs": 1659.8400000000001,
"heapDeltaBytes": -275548,
"heapUsedBytes": 65610496,
"domNodes": 28,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 814.457,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3549.0859999999884,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.448000000000002,
"layouts": 60,
"layoutDurationMs": 13.636000000000001,
"taskDurationMs": 1635.3990000000001,
"heapDeltaBytes": -234824,
"heapUsedBytes": 65798468,
"domNodes": -227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 801.394,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3093.245999999965,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.325999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1883.3739999999998,
"heapDeltaBytes": 17555400,
"heapUsedBytes": 83501440,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1014.64,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3040.8949999999777,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.49,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1752.3190000000002,
"heapDeltaBytes": 16865580,
"heapUsedBytes": 82622236,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1018.697,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.5779999999681,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.512000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.545,
"heapDeltaBytes": -23317236,
"heapUsedBytes": 68117808,
"domNodes": -257,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 36.532,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.9559999999892,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.799000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.2450000000001,
"heapDeltaBytes": -17297976,
"heapUsedBytes": 73624464,
"domNodes": -241,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.67399999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.7440000000056,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.999999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.42599999999993,
"heapDeltaBytes": 13587888,
"heapUsedBytes": 83863760,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.901,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.440000000086,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.116999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.32699999999994,
"heapDeltaBytes": 14256928,
"heapUsedBytes": 85572612,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.394,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.8910000000196,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.196000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.099,
"heapDeltaBytes": 6970516,
"heapUsedBytes": 77760576,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.752000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.5170000000644,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.768999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.947,
"heapDeltaBytes": -13485412,
"heapUsedBytes": 57648440,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.8409999999999975,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.2709999999724,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.294000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.381,
"heapDeltaBytes": -9897956,
"heapUsedBytes": 61286388,
"domNodes": -273,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.747,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.317999999963,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.798,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 754.3340000000001,
"heapDeltaBytes": 5183384,
"heapUsedBytes": 75524012,
"domNodes": -276,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 109.23399999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.544000000029,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.552999999999994,
"layouts": 5,
"layoutDurationMs": 13.173,
"taskDurationMs": 889.6709999999998,
"heapDeltaBytes": -6515204,
"heapUsedBytes": 85853488,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.790000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8320.357000000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.242,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5577.085,
"heapDeltaBytes": 3276672,
"heapUsedBytes": 92425120,
"domNodes": -240,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2841.246,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8509.78299999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.599000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5889.655000000001,
"heapDeltaBytes": -1789916,
"heapUsedBytes": 88504528,
"domNodes": -250,
"jsHeapTotalBytes": 4939776,
"scriptDurationMs": 3029.6339999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17646.753999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16960.647999999997,
"heapDeltaBytes": -35698632,
"heapUsedBytes": 192593236,
"domNodes": -8061,
"jsHeapTotalBytes": -18026496,
"scriptDurationMs": 306.44300000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17325.08800000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16771.308,
"heapDeltaBytes": -69378228,
"heapUsedBytes": 172314628,
"domNodes": -8061,
"jsHeapTotalBytes": -17502208,
"scriptDurationMs": 284.49199999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21866.637000000024,
"styleRecalcs": 171,
"styleRecalcDurationMs": 18.110000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21525.061,
"heapDeltaBytes": -46041768,
"heapUsedBytes": 194424460,
"domNodes": -8061,
"jsHeapTotalBytes": -17350656,
"scriptDurationMs": 910.087,
"eventListeners": -14928,
"totalBlockingTimeMs": 60,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16318.051000000083,
"styleRecalcs": 100,
"styleRecalcDurationMs": 13.692999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15872.229,
"heapDeltaBytes": -70846932,
"heapUsedBytes": 169167780,
"domNodes": -8061,
"jsHeapTotalBytes": -16756736,
"scriptDurationMs": 846.7669999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6294.472000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.546,
"layouts": 20,
"layoutDurationMs": 22.933999999999997,
"taskDurationMs": 6207.14,
"heapDeltaBytes": -36043352,
"heapUsedBytes": 184087836,
"domNodes": -8061,
"jsHeapTotalBytes": 14176256,
"scriptDurationMs": 112.64,
"eventListeners": -14928,
"totalBlockingTimeMs": 428,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6137.818999999922,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.10699999999999,
"layouts": 20,
"layoutDurationMs": 22.436999999999998,
"taskDurationMs": 6064.348,
"heapDeltaBytes": -30241276,
"heapUsedBytes": 184005388,
"domNodes": -8061,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 112.80700000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 434,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8756.661000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8475.622000000001,
"heapDeltaBytes": -10036008,
"heapUsedBytes": 172376136,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 131.30600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8744.539000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8419.633,
"heapDeltaBytes": -19566544,
"heapUsedBytes": 170028168,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 137.54100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 145.2719999999772,
"styleRecalcs": 10,
"styleRecalcDurationMs": 22.519,
"layouts": 5,
"layoutDurationMs": 2.636,
"taskDurationMs": 106.32300000000001,
"heapDeltaBytes": 3359040,
"heapUsedBytes": 69459792,
"domNodes": 116,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.381,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 113.85900000004767,
"styleRecalcs": 9,
"styleRecalcDurationMs": 18.148000000000003,
"layouts": 3,
"layoutDurationMs": 1.5469999999999997,
"taskDurationMs": 84.99699999999999,
"heapDeltaBytes": 3005324,
"heapUsedBytes": 69833804,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.634000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.55 #20518 +/- ##
=============================================
Coverage ? 85.07%
=============================================
Files ? 2357
Lines ? 135131
Branches ? 34600
=============================================
Hits ? 114969
Misses ? 19797
Partials ? 365
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
Required-E2E repair is published at fa107a3. The cloud/1.55 global keybinding now yields Escape to dialogs, matching the behavior already shipped on main in #16272, so the media preview can dismiss without also executing ExitSubgraph behind it. The focused keybinding suite passes 16/16; removing the dialog selector makes the new table row fail. Changed-file lint/format, app typecheck, commit hooks, and pre-push knip pass. Fresh hosted preview validation is running; Ryan remains the sole human owner. |
ryan-di
left a comment
There was a problem hiding this comment.
The Escape-dismissal fix addresses the backport blocker, and the regression tests and required checks are passing.
Summary
Backports #20156 to cloud/1.55 after its required release-branch predecessor #20512 landed.
Conflict resolution
Validation
Source: #20156