Skip to content

[backport cloud/1.54] feat(agent): build a multimodal composer with independent assets and prompt references (#20156) - #20537

Closed
christian-byrne wants to merge 1 commit into
cloud/1.54from
backport-20156-to-cloud-1.54-manual
Closed

christian-byrne wants to merge 1 commit into
cloud/1.54from
backport-20156-to-cloud-1.54-manual

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #20156 to cloud/1.54 after #20518 landed on cloud/1.55.\n\nTarget-aware adaptations:\n- preserve cloud/1.54 workflow and test fixture APIs while adding the node-mention freshness contract\n- use release-line design-system exports\n- exercise drag/drop without newer jsdom DataTransfer globals\n- omit the browser spec whose prerequisite fixture is absent from this release branch\n\nValidation:\n- focused unit/component coverage: 17 suites, 688 tests passed\n- pnpm typecheck passed\n- pnpm typecheck:browser passed\n- full pre-commit format/style/type-aware lint/typecheck hooks passed across 69 files\n\nNo exposure or feature flags changed.

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) cloud/1.54 Backport PRs for cloud 1.54 labels Oct 8, 2026
@vercel

vercel Bot commented Oct 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 8, 2026 9:36am UTC
billing-web-test Ignored Ignored Oct 8, 2026 9:36am UTC

Request Review

@christian-byrne
christian-byrne enabled auto-merge (squash) October 8, 2026 09:36
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: f3039e48-0b8a-4e48-bc4a-6e4ee7bb6e77

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/08/2026, 09:38:17 AM UTC

Links

🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1969 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 127ms TBT · 83.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.8 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 1ms TBT · 170.2 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 7ms TBT · 173.5 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 174ms TBT · 170.2 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 174.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 491ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 62.7 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -196
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 24ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 754ms
canvas-mouse-sweep: script duration 123ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.0 MB
canvas-mouse-sweep: DOM nodes -278
canvas-mouse-sweep: event listeners -196
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 330ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 74.0 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 394ms
dom-widget-clipping: script duration 138ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.4 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 500ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 71.8 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1389ms
large-graph-pan: script duration 673ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 76.1 MB
large-graph-pan: DOM nodes -286
large-graph-pan: event listeners -193
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 70
large-graph-zoom: task duration 1473ms
large-graph-zoom: script duration 651ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 78.5 MB
large-graph-zoom: DOM nodes -115
large-graph-zoom: event listeners -92
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1528ms
legacy-node-drag: script duration 763ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 90.4 MB
legacy-node-drag: DOM nodes 9
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 487ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.0 MB
minimap-idle: DOM nodes -281
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 358ms
subgraph-dom-widget-clipping: script duration 118ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 74.5 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 451ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 73.8 MB
subgraph-idle: DOM nodes -293
subgraph-idle: event listeners -227
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 21ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 691ms
subgraph-mouse-sweep: script duration 82ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.0 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -211
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 27ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 781ms
subgraph-transition-enter: script duration 25ms
subgraph-transition-enter: TBT 127ms
subgraph-transition-enter: heap used 83.8 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 4735ms
viewport-pan-sweep: script duration 2223ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 77.8 MB
viewport-pan-sweep: DOM nodes -128
viewport-pan-sweep: event listeners -62
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13349ms
vue-large-graph-idle: script duration 252ms
vue-large-graph-idle: TBT 1ms
vue-large-graph-idle: heap used 170.2 MB
vue-large-graph-idle: DOM nodes -8070
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 129
vue-large-graph-pan: task duration 16484ms
vue-large-graph-pan: script duration 820ms
vue-large-graph-pan: TBT 7ms
vue-large-graph-pan: heap used 173.5 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14929
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 67ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4809ms
vue-node-resize-workload: script duration 98ms
vue-node-resize-workload: TBT 174ms
vue-node-resize-workload: heap used 170.2 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6721ms
vue-zoom-out-idle: script duration 112ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 174.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 10ms
workflow-execution: layout count 2
workflow-execution: style recalc count 6
workflow-execution: task duration 58ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.0 MB
workflow-execution: DOM nodes 113
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-10-08T09:46:52.537Z",
  "gitSha": "a43be24361817c138428cfd28a12746ab7524d32",
  "branch": "backport-20156-to-cloud-1.54-manual",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2009.2899999999645,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.303000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 545.086,
      "heapDeltaBytes": -9023612,
      "heapUsedBytes": 64295588,
      "domNodes": -279,
      "jsHeapTotalBytes": 3440640,
      "scriptDurationMs": 9.812000000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2020.9780000000137,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.256999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.636,
      "heapDeltaBytes": -5989692,
      "heapUsedBytes": 67244080,
      "domNodes": -282,
      "jsHeapTotalBytes": 3440640,
      "scriptDurationMs": 8.468,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1714.0259999999898,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 26.580000000000002,
      "layouts": 14,
      "layoutDurationMs": 3.751,
      "taskDurationMs": 761.435,
      "heapDeltaBytes": -3858416,
      "heapUsedBytes": 67393712,
      "domNodes": -276,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 121.26999999999998,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1808.6569999999824,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 22.043,
      "layouts": 14,
      "layoutDurationMs": 3.586,
      "taskDurationMs": 746.985,
      "heapDeltaBytes": -2155512,
      "heapUsedBytes": 71112908,
      "domNodes": -280,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 124.737,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1674.1890000000126,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 13.762000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.3119999999999998,
      "taskDurationMs": 339.245,
      "heapDeltaBytes": 4799700,
      "heapUsedBytes": 79187828,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.254999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.706000000083,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.690000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.038,
      "taskDurationMs": 321.56800000000004,
      "heapDeltaBytes": 4505008,
      "heapUsedBytes": 76096520,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.580999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 599.4450000000029,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.642000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 395.707,
      "heapDeltaBytes": -8225260,
      "heapUsedBytes": 63338140,
      "domNodes": 18,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 141.568,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 576.7799999999852,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 5.439000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 391.78999999999996,
      "heapDeltaBytes": -8190660,
      "heapUsedBytes": 63314616,
      "domNodes": 18,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 134.972,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2057.1990000000255,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 532.882,
      "heapDeltaBytes": -6515108,
      "heapUsedBytes": 73748496,
      "domNodes": -270,
      "jsHeapTotalBytes": -2326528,
      "scriptDurationMs": 38.885999999999996,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.63200000004,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.2559999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.6999999999999,
      "heapDeltaBytes": -2973064,
      "heapUsedBytes": 76885448,
      "domNodes": -269,
      "jsHeapTotalBytes": -2850816,
      "scriptDurationMs": 36.12,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2152.575000000013,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.157000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1391.6179999999997,
      "heapDeltaBytes": 3053948,
      "heapUsedBytes": 81616252,
      "domNodes": -287,
      "jsHeapTotalBytes": 118784,
      "scriptDurationMs": 669.383,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2170.209,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.661,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1386.236,
      "heapDeltaBytes": -311296,
      "heapUsedBytes": 77882332,
      "domNodes": -285,
      "jsHeapTotalBytes": -1454080,
      "scriptDurationMs": 675.678,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3405.200999999977,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 15.652,
      "layouts": 60,
      "layoutDurationMs": 13.795,
      "taskDurationMs": 1471.386,
      "heapDeltaBytes": 5067536,
      "heapUsedBytes": 84817312,
      "domNodes": 34,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 656.745,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3308.700999999928,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.79,
      "layouts": 60,
      "layoutDurationMs": 12.565999999999999,
      "taskDurationMs": 1473.9759999999999,
      "heapDeltaBytes": -2074320,
      "heapUsedBytes": 79845296,
      "domNodes": -263,
      "jsHeapTotalBytes": 3440640,
      "scriptDurationMs": 645.36,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2431.8230000000085,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.431,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1565.225,
      "heapDeltaBytes": 10263708,
      "heapUsedBytes": 93017632,
      "domNodes": 8,
      "jsHeapTotalBytes": 5660672,
      "scriptDurationMs": 783.775,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2320.3329999998914,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 6.985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1490.993,
      "heapDeltaBytes": 14407860,
      "heapUsedBytes": 96521980,
      "domNodes": 10,
      "jsHeapTotalBytes": 6184960,
      "scriptDurationMs": 742.6809999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.0349999999694,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.386,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 457.3650000000001,
      "heapDeltaBytes": 11198352,
      "heapUsedBytes": 76869472,
      "domNodes": -272,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.659999999999993,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2013.253000000077,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.156000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 517.126,
      "heapDeltaBytes": 10828940,
      "heapUsedBytes": 90801040,
      "domNodes": -289,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 33.538000000000004,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 585.7629999999858,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.723999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 352.904,
      "heapDeltaBytes": -10410592,
      "heapUsedBytes": 65481092,
      "domNodes": 20,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 115.08099999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 551.9080000000258,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.09,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.12500000000006,
      "heapDeltaBytes": 14790200,
      "heapUsedBytes": 90700596,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 120.21300000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2019.6220000000267,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.71,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.88399999999996,
      "heapDeltaBytes": -2827092,
      "heapUsedBytes": 73246836,
      "domNodes": -292,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 8.55,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2019.3980000000238,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.832,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.078,
      "heapDeltaBytes": 5796620,
      "heapUsedBytes": 81474636,
      "domNodes": -294,
      "jsHeapTotalBytes": 4227072,
      "scriptDurationMs": 8.361,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.1139999999996,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 22.418,
      "layouts": 18,
      "layoutDurationMs": 3.92,
      "taskDurationMs": 698.166,
      "heapDeltaBytes": -16411752,
      "heapUsedBytes": 59522872,
      "domNodes": -295,
      "jsHeapTotalBytes": 4489216,
      "scriptDurationMs": 84.005,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.7900000000022,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 19.922,
      "layouts": 18,
      "layoutDurationMs": 3.4549999999999996,
      "taskDurationMs": 683.963,
      "heapDeltaBytes": -5065464,
      "heapUsedBytes": 68494920,
      "domNodes": -294,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 79.298,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 982.8989999999749,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 26.726,
      "layouts": 15,
      "layoutDurationMs": 11.506000000000002,
      "taskDurationMs": 781.2669999999997,
      "heapDeltaBytes": -5220552,
      "heapUsedBytes": 87841764,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 24.752999999999997,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 127,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8177.926000000014,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 37.451,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4773.159,
      "heapDeltaBytes": 14010656,
      "heapUsedBytes": 94994232,
      "domNodes": 12,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 2275.522,
      "eventListeners": 20,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8187.35700000002,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.436,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4696.402,
      "heapDeltaBytes": -12050924,
      "heapUsedBytes": 68189924,
      "domNodes": -267,
      "jsHeapTotalBytes": -2064384,
      "scriptDurationMs": 2170.3010000000004,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14085.379999999986,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13261.837,
      "heapDeltaBytes": -49010740,
      "heapUsedBytes": 178181316,
      "domNodes": -8072,
      "jsHeapTotalBytes": -17436672,
      "scriptDurationMs": 271.91700000000003,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14376.765999999974,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13436.287,
      "heapDeltaBytes": -51461408,
      "heapUsedBytes": 178782532,
      "domNodes": -8068,
      "jsHeapTotalBytes": -7741440,
      "scriptDurationMs": 231.64100000000002,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16913.337000000014,
      "styleRecalcs": 126,
      "styleRecalcDurationMs": 16.767999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16406.009,
      "heapDeltaBytes": -43130608,
      "heapUsedBytes": 183860752,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18485248,
      "scriptDurationMs": 792.4100000000001,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17066.140000000018,
      "styleRecalcs": 131,
      "styleRecalcDurationMs": 17.487000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16561.76,
      "heapDeltaBytes": -54570756,
      "heapUsedBytes": 179900612,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10498048,
      "scriptDurationMs": 846.763,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 11,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4894.307000000026,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 66.397,
      "layouts": 20,
      "layoutDurationMs": 23.21999999999999,
      "taskDurationMs": 4775.093999999999,
      "heapDeltaBytes": -42359940,
      "heapUsedBytes": 181749648,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10682368,
      "scriptDurationMs": 89.11699999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 207,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4944.964000000027,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 67.576,
      "layouts": 20,
      "layoutDurationMs": 23.273000000000003,
      "taskDurationMs": 4841.996,
      "heapDeltaBytes": -46371620,
      "heapUsedBytes": 175152804,
      "domNodes": -8068,
      "jsHeapTotalBytes": 7327744,
      "scriptDurationMs": 107.34799999999998,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6877.3679999999895,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6495.825000000002,
      "heapDeltaBytes": 18241908,
      "heapUsedBytes": 188558876,
      "domNodes": 0,
      "jsHeapTotalBytes": -16252928,
      "scriptDurationMs": 106.88799999999998,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7316.937000000053,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6946.500000000002,
      "heapDeltaBytes": -6904756,
      "heapUsedBytes": 177429000,
      "domNodes": 0,
      "jsHeapTotalBytes": -13369344,
      "scriptDurationMs": 118.00699999999998,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 82.49499999999443,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 10.591000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.899,
      "taskDurationMs": 56.39900000000001,
      "heapDeltaBytes": 3040996,
      "heapUsedBytes": 67555036,
      "domNodes": 123,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.186,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 84.31200000006811,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 9.841000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.7710000000000002,
      "taskDurationMs": 59.405000000000015,
      "heapDeltaBytes": 3003612,
      "heapUsedBytes": 74975756,
      "domNodes": 102,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.333,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51191 76666 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@datadog-official

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

CI: Tests E2E | playwright-tests (cloud) — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

CI: Tests E2E | e2e-status

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c76e11f | Docs | View more details | Give us feedback!

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.21875% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...xtensions/agent/stores/agent/agentComposerStore.ts 97.95% 2 Missing ⚠️
src/platform/assets/utils/assetDragUtil.ts 95.83% 1 Missing ⚠️
...t/components/agent/composer/InlinePromptEditor.vue 98.33% 1 Missing ⚠️
...workbench/extensions/agent/utils/videoThumbnail.ts 97.56% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #20537   +/-   ##
=============================================
  Coverage              ?   84.25%           
=============================================
  Files                 ?     2142           
  Lines                 ?   129146           
  Branches              ?    35160           
=============================================
  Hits                  ?   108814           
  Misses                ?    20151           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.77% <72.72%> (?)
unit 79.76% <99.37%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/assets/schemas/mediaAssetSchema.ts 100.00% <100.00%> (ø)
src/utils/eventUtils.ts 100.00% <ø> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 93.53% <100.00%> (ø)
...h/extensions/agent/components/agent/AgentPanel.vue 96.75% <ø> (ø)
...nch/extensions/agent/components/agent/Composer.vue 98.76% <100.00%> (ø)
...nt/components/agent/composer/AssetHoverPreview.vue 100.00% <100.00%> (ø)
...nt/components/agent/composer/AssetMediaPreview.vue 100.00% <100.00%> (ø)
...agent/components/agent/composer/AssetThumbnail.vue 100.00% <100.00%> (ø)
...ions/agent/components/agent/composer/AssetTray.vue 100.00% <100.00%> (ø)
...agent/components/agent/composer/AttachmentChip.vue 100.00% <100.00%> (ø)
... and 15 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing because the core/cloud 1.54 trains are retired as of 2026-10-09. Any still-applicable change should be carried to the current 1.55 and 1.56 targets instead.

auto-merge was automatically disabled October 9, 2026 19:05

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cloud/1.54 Backport PRs for cloud 1.54 risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants