Repository navigation
[backport cloud/1.56] FE-3297 feat(auth): switch workspaces in the Desktop-hosted view - #20494
Conversation
) ## Summary In Desktop local, a user signed in through Desktop's account session (Continue with SSO) now gets the same workspace switcher as a Firebase user, and switching re-scopes Desktop's session. Fixes FE-3297. Needs Comfy-Org/Comfy-Desktop#1671 for the switch itself; an older Desktop shows a fixed workspace row. **Why:** SSO users sign in to the local view only through Desktop (#20383). On testcloud, `ssotest1` belongs to three workspaces, but the view showed the legacy account menu with no switcher, so credits and partner-node runs were stuck on whatever workspace Desktop was scoped to. **Root cause:** - `CurrentUserButton` shows the workspace menu only once `teamWorkspaceStore` is `ready`. - Off Cloud, that store initializes only for a Firebase user (`resolveLocalWorkspace` checks `currentUser`). A host session has no Firebase user, so the store never loaded. - The host credential is released only for Desktop's own workspace, so the view can't mint one for another workspace itself. **How:** - **Load:** when a Desktop account signs in (off Cloud), `authStore` starts `teamWorkspaceStore.initialize()`. Under host auth, init lists workspaces with the host credential and takes the workspace Desktop's session is scoped to. There is no session cookie, localStorage pick or token exchange. - **Switch:** under host auth, `executeWorkspaceSwitch` asks Desktop (`Auth.switchWorkspace`) and makes the workspace active only once Desktop reports it. The first switch to a workspace runs browser consent. It shares the local branch's existing failure path; nothing reloads. - **Follow:** a switch made in Desktop's chooser re-scopes the credential, so the store follows `desktopHostUser.workspaceId`. - **Older Desktop:** without `switchWorkspace` on the bridge, the menu shows a fixed workspace row, like an API-key session. Flag off (`desktop_embedded_oauth_session`) or no Desktop account: unchanged. ## Verification - **Unit tests:** each new test fails on `main` and passes here; the four suites below total 313 tests, all passing. | Suite | Covers | |---|---| | `teamWorkspaceStore` | host init and its error case, switch through Desktop, Desktop refusing, following a Desktop-side switch | | `authStore` | Desktop sign-in loads workspaces | | `desktopHostSession` | switch, refuse, failure, old bridge, signed out | | `CurrentUserPopoverWorkspace` | switcher vs fixed row | - **Manual:** Desktop dev on #1671 + this build, testcloud, `ssotest1@example.com`. Screenshots below. ### AS IS Desktop local, signed in through Desktop as `ssotest1@example.com`: the legacy account menu, no workspace switcher, and 0 credits. <img src="https://github.com/user-attachments/assets/60f2a663-07cc-4300-bdb5-84e21e2cd73d" width="700"> ### TO BE Same user, Desktop #1671 + this build against testcloud: the workspace switcher lists all three workspaces, and the active workspace shows its credits. <img src="https://github.com/user-attachments/assets/53dd4585-76e8-4cdd-afb1-cb21efa22b70" width="700">
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (15 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7d732f5e44d2707d967ba8540cb7e51632cbd7c5
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2200 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-08T01:26:09.567Z",
"gitSha": "6b60e1c131441500508effafdc48fba24db6c7ce",
"branch": "backport-20484-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.3540000000448,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.9379999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.413,
"heapDeltaBytes": 882076,
"heapUsedBytes": 69653936,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.822999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2011.556999999982,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.571,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.41900000000004,
"heapDeltaBytes": 575468,
"heapUsedBytes": 69375932,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.659,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1674.6880000000033,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.164000000000001,
"layouts": 12,
"layoutDurationMs": 3.2309999999999994,
"taskDurationMs": 566.8539999999999,
"heapDeltaBytes": -2255428,
"heapUsedBytes": 64868408,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 105.538,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.167999999967,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.2,
"layouts": 12,
"layoutDurationMs": 3.22,
"taskDurationMs": 567.941,
"heapDeltaBytes": -2072512,
"heapUsedBytes": 66750548,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 107.103,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.8100000000045,
"styleRecalcs": 31,
"styleRecalcDurationMs": 6.985,
"layouts": 6,
"layoutDurationMs": 0.9889999999999999,
"taskDurationMs": 262.063,
"heapDeltaBytes": 3790620,
"heapUsedBytes": 71529368,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.191000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.8310000000374,
"styleRecalcs": 31,
"styleRecalcDurationMs": 7.217999999999999,
"layouts": 6,
"layoutDurationMs": 0.9400000000000001,
"taskDurationMs": 256.38800000000003,
"heapDeltaBytes": 3764796,
"heapUsedBytes": 71420024,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.308000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 553.3760000000143,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.9829999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.306,
"heapDeltaBytes": -9124536,
"heapUsedBytes": 59708208,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 118.43599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 529.3910000000324,
"styleRecalcs": 16,
"styleRecalcDurationMs": 2.399000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.739,
"heapDeltaBytes": -7145852,
"heapUsedBytes": 61405992,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 111.995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000017,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 989.9690000000305,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.557,
"heapDeltaBytes": 16028272,
"heapUsedBytes": 86620688,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 39.669,
"eventListeners": 0,
"totalBlockingTimeMs": 389,
"frameDurationMs": 30.303030303030305,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1004.5619999999644,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.219,
"heapDeltaBytes": 15415228,
"heapUsedBytes": 86349952,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 40.126,
"eventListeners": 0,
"totalBlockingTimeMs": 388,
"frameDurationMs": 30.303030303030305,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 733.0620000000181,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.3419999999997,
"heapDeltaBytes": 17113200,
"heapUsedBytes": 96790264,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 103.92200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 118,
"frameDurationMs": 21.570588235294135,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 749.3670000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.96500000000026,
"heapDeltaBytes": 16939856,
"heapUsedBytes": 104625956,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 102.34800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 122,
"frameDurationMs": 22.058823529411764,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6517.641999999995,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6840000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5650.895,
"heapDeltaBytes": -13617556,
"heapUsedBytes": 71257212,
"domNodes": -171,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 4478.956999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 48,
"frameDurationMs": 24.314925373134326,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6498.47299999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5999999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5831.955,
"heapDeltaBytes": -3451360,
"heapUsedBytes": 82435272,
"domNodes": -171,
"jsHeapTotalBytes": -5640192,
"scriptDurationMs": 4677.442,
"eventListeners": -78,
"totalBlockingTimeMs": 43,
"frameDurationMs": 25.389453125000003,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6149.142999999981,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7270000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5326.955,
"heapDeltaBytes": -17331492,
"heapUsedBytes": 68314956,
"domNodes": -143,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 4184.762999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 52,
"frameDurationMs": 24.307114624505928,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6132.446000000016,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.6840000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5505.527,
"heapDeltaBytes": 19133444,
"heapUsedBytes": 88583148,
"domNodes": -142,
"jsHeapTotalBytes": -5378048,
"scriptDurationMs": 4408.41,
"eventListeners": -70,
"totalBlockingTimeMs": 32,
"frameDurationMs": 25.135245901639344,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2009.27200000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7370000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.0899999999999,
"heapDeltaBytes": -10063640,
"heapUsedBytes": 78646400,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 26.06,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.9790000000107,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.349,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.819,
"heapDeltaBytes": -9947368,
"heapUsedBytes": 78692552,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 21.138000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2100.500000000011,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.524,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1084.419,
"heapDeltaBytes": -19909140,
"heapUsedBytes": 69948172,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 547.708,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665599999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2098.1349999999566,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.525000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1091.812,
"heapDeltaBytes": -18961068,
"heapUsedBytes": 70449996,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 558.751,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3117.605000000026,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.908999999999999,
"layouts": 60,
"layoutDurationMs": 10.244,
"taskDurationMs": 1155.313,
"heapDeltaBytes": 1222740,
"heapUsedBytes": 69960516,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 531.933,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666310160427805,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3104.4709999999895,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.382,
"layouts": 60,
"layoutDurationMs": 9.473,
"taskDurationMs": 1150.2820000000002,
"heapDeltaBytes": 1291628,
"heapUsedBytes": 69993240,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 513.4680000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665591397849465,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2175.4210000000285,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1308.653,
"heapDeltaBytes": 5515136,
"heapUsedBytes": 74397772,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 648.3480000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79384615384616,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2175.8199999999306,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.461999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1279.8609999999999,
"heapDeltaBytes": 5863136,
"heapUsedBytes": 74770844,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 636.498,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7953488372093,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.439000000048,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2030000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.41800000000006,
"heapDeltaBytes": -9104584,
"heapUsedBytes": 81397632,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 24.789000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.9090000000506,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.544000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.433,
"heapDeltaBytes": -11592472,
"heapUsedBytes": 69722300,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 20.124999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 432.59899999998197,
"styleRecalcs": 48,
"styleRecalcDurationMs": 3.9660000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.348,
"heapDeltaBytes": -11645032,
"heapUsedBytes": 57979516,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 96.52699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 473.76799999995,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.07800000000003,
"heapDeltaBytes": -12291464,
"heapUsedBytes": 57686672,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 93.68799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2006.7229999999654,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.044,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.79400000000004,
"heapDeltaBytes": 1070596,
"heapUsedBytes": 72062124,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.609,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2005.5140000000051,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.876,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.85900000000004,
"heapDeltaBytes": 1012768,
"heapUsedBytes": 71396040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.694999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1681.3170000000355,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.008000000000001,
"layouts": 16,
"layoutDurationMs": 3.4330000000000003,
"taskDurationMs": 522.307,
"heapDeltaBytes": -5989808,
"heapUsedBytes": 64664744,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 67.939,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.1370000000402,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.557999999999998,
"layouts": 16,
"layoutDurationMs": 3.225,
"taskDurationMs": 531.417,
"heapDeltaBytes": -5992696,
"heapUsedBytes": 64455456,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 65.496,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 849.897999999996,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.101000000000003,
"layouts": 5,
"layoutDurationMs": 9.305000000000001,
"taskDurationMs": 662.9780000000001,
"heapDeltaBytes": 1247316,
"heapUsedBytes": 92024728,
"domNodes": 14227,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 17.263,
"eventListeners": 2463,
"totalBlockingTimeMs": 98,
"frameDurationMs": 20.233333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8142.236999999966,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.721,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3488.9090000000006,
"heapDeltaBytes": -18889680,
"heapUsedBytes": 70678360,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 1849.456,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618852459016,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8139.61699999993,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.701999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3870.3580000000006,
"heapDeltaBytes": 10200240,
"heapUsedBytes": 90126848,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 1849.019,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665983606557376,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10924.230999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10265.975,
"heapDeltaBytes": -18159604,
"heapUsedBytes": 181059388,
"domNodes": -3045,
"jsHeapTotalBytes": 8409088,
"scriptDurationMs": 124.56,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.285092127303184,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 10977.020000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10285.474,
"heapDeltaBytes": -17826756,
"heapUsedBytes": 181334940,
"domNodes": -3045,
"jsHeapTotalBytes": 8933376,
"scriptDurationMs": 114.38599999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.618505942275043,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 13742.523999999947,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.508000000000019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13131.345000000001,
"heapDeltaBytes": -46928544,
"heapUsedBytes": 177360476,
"domNodes": -3045,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 578.007,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.29240282685512,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 13760.425000000054,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.548999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13106.027000000002,
"heapDeltaBytes": -37334584,
"heapUsedBytes": 189685180,
"domNodes": -3045,
"jsHeapTotalBytes": 7028736,
"scriptDurationMs": 616.918,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.222847100175745,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4063.863000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.591,
"layouts": 20,
"layoutDurationMs": 17.826999999999995,
"taskDurationMs": 3908.7329999999997,
"heapDeltaBytes": 14992212,
"heapUsedBytes": 214302188,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 51.632,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.645454545454545,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4142.115999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.65899999999999,
"layouts": 20,
"layoutDurationMs": 18.134999999999998,
"taskDurationMs": 3950.59,
"heapDeltaBytes": 989340,
"heapUsedBytes": 217473520,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 55.51799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.998795180722887,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5707.970999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5321.373999999999,
"heapDeltaBytes": -16714536,
"heapUsedBytes": 185120184,
"domNodes": -3044,
"jsHeapTotalBytes": 21495808,
"scriptDurationMs": 64.39299999999997,
"eventListeners": -14906,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.12684563758389,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-zoom-out-idle",
"durationMs": 4341.632000000004,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.11400000000000299,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3873.5940000000005,
"heapDeltaBytes": -32068120,
"heapUsedBytes": 184392464,
"domNodes": -3045,
"jsHeapTotalBytes": 6955008,
"scriptDurationMs": 58.111999999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.686122448979585,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 466.31999999999607,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.112,
"layouts": 4,
"layoutDurationMs": 1.5370000000000001,
"taskDurationMs": 104.56000000000002,
"heapDeltaBytes": 5937988,
"heapUsedBytes": 71566636,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.416999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 82.20000000005712,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.795,
"layouts": 3,
"layoutDurationMs": 0.959,
"taskDurationMs": 54.529999999999994,
"heapDeltaBytes": 3714428,
"heapUsedBytes": 70153240,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.361999999999997,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 450.898000000052,
"styleRecalcs": 78,
"styleRecalcDurationMs": 74.672,
"layouts": 76,
"layoutDurationMs": 17.398,
"taskDurationMs": 405.69300000000004,
"heapDeltaBytes": 13487144,
"heapUsedBytes": 86355180,
"domNodes": 76,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 142.776,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 421.0679999999911,
"styleRecalcs": 78,
"styleRecalcDurationMs": 75.033,
"layouts": 76,
"layoutDurationMs": 17.132,
"taskDurationMs": 381.83,
"heapDeltaBytes": 12967400,
"heapUsedBytes": 86299264,
"domNodes": 76,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 131.80499999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 737.4770000000126,
"styleRecalcs": 78,
"styleRecalcDurationMs": 180.764,
"layouts": 76,
"layoutDurationMs": 15.886000000000001,
"taskDurationMs": 707.553,
"heapDeltaBytes": -22458008,
"heapUsedBytes": 106334520,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 200.142,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 721.0810000000265,
"styleRecalcs": 78,
"styleRecalcDurationMs": 176.552,
"layouts": 76,
"layoutDurationMs": 16.448999999999998,
"taskDurationMs": 687.28,
"heapDeltaBytes": -22505052,
"heapUsedBytes": 107068984,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 187.424,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.699999999999818
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.56 #20494 +/- ##
=============================================
Coverage ? 84.97%
=============================================
Files ? 3508
Lines ? 169287
Branches ? 44439
=============================================
Hits ? 143856
Misses ? 23449
Partials ? 1982
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Requesting changes on the shared API response type at b9c45a83f0b4a7720ddb7b24f3420b2bcbfc4f84. Published 0.4.0 supplies the existing auth response contract; the proposed 0.5.0 switch method is still unpublished and Comfy-Desktop #1671 is OPEN. A thin optional-method extension can preserve compatibility without copying the response.
Own verification in an isolated checkout with its own frozen install: 317 unit tests PASS; app/browser types, Cloud production build, changed-file type-aware oxlint, production ESLint, format and knip PASS. Restoring the three prior store/component implementations produced 11 FAIL / 306 PASS; original restoration returned 317 PASS. Four independent mutations failed as intended: result validation 2, host following 3, host initialization 3, older-host UI 1; restored 317 PASS. 1 actual Cloud production-browser case passed: the supplied Desktop bridge was ignored and the Cloud workspace remained authoritative. Its restoration repeat passed; this is not a native Desktop or live SSO test.
Workspace list responses use the generated ingest contract; the frontend follows the host's workspace and confirms membership in that list. No new server-state assembly or HTTP response type was found. Exact source and production output are restored; temporary diagnostics removed and owned backends stopped. Required contexts and matching workflow SHA are recorded separately; queued/in-progress whole workflows are not claimed complete. Native Desktop/browser consent/token exchange, real customer/account/rollout, other OS/browser, broad accessibility/performance and extension suites: NOT_RUN. Unit-test ESLint is ignored by repository configuration; type-aware oxlint executed.
| requestSignIn(): Promise<DesktopHostAuthState> | ||
| signOut(): Promise<DesktopHostAuthState> | ||
| /** Absent on Desktop builds before Comfy-Desktop #1671. */ | ||
| switchWorkspace?(workspaceId: string): Promise<DesktopHostAuthState> |
There was a problem hiding this comment.
issue: This new host API still returns the hand-declared DesktopHostAuthState above. Published 0.4.0 of @comfyorg/comfyui-desktop-bridge-types already publicly exports ComfyDesktop2AuthState and ComfyDesktop2AuthBridge; I downloaded its official tarball and verified the registry integrity digest. The current pin is 0.2.0, so its absence from that pin is a dependency-version limitation, rather than an unavailable shared contract. Could we update the pin and import the shared response/bridge types, extending only the optional switchWorkspace member until the 0.5.0 contract from Comfy-Desktop #1671 is available? Keeping that method optional for older Desktop builds makes sense. I am not claiming today's response fields differ; the blocking concern is maintaining a local API response copy that can drift.
… package Bumps @comfyorg/comfyui-desktop-bridge-types to 0.4.0 and drops the local copy of Desktop's auth response contract; only switchWorkspace stays as a local optional extension until 0.5.0. Same change as #20500.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
dante01yoon
left a comment
There was a problem hiding this comment.
The shared-host-type blocker is addressed on aa5bbc8d490e4eb1a87683cefc0063cf51ba4fdf: the frozen install resolves desktop-bridge-types 0.4.0, DesktopHostAuthState aliases its public ComfyDesktop2AuthState, and DesktopHostAuthBridge extends the public bridge with only optional switchWorkspace. The installed public declarations and official lockfile integrity match the contract previously verified. The incidental axios snapshot only adds its existing debug peer; no package version changed.
Own validation: 317 related unit tests, app/browser types, the respective production build, changed-file type-aware oxlint/ESLint/format, and knip PASS. No new server-state inference or API response copy remains. This increment changes type-only imports/declarations and dependency metadata; executable feature code and browser specs are unchanged, and the type package runtime entry is export {}. Fresh browser/functional mutations were NOT_RUN for that reason; earlier functional production-browser/mutation runs remain historical evidence, not new PASS. Native Desktop/live accounts/payment and unrelated suites were NOT_RUN.
Approval is BLOCKED while the current matching-head E2E run is queued / None; unfinished CI is not PASS. I have not resolved the existing review thread or rerun CI.
…ublished package (Comfy-Org#20500) ## Summary The Desktop host auth bridge no longer keeps a hand-declared copy of Desktop's auth response contract. It takes `ComfyDesktop2AuthState` and `ComfyDesktop2AuthBridge` from `@comfyorg/comfyui-desktop-bridge-types`, bumped from 0.3.0 to 0.4.0. Follow-up to Comfy-Org#20383 and Comfy-Org#20484 (FE-3297). **Why:** review on the 1.56 backports of Comfy-Org#20484 (Comfy-Org#20493, Comfy-Org#20494) flagged the local `DesktopHostAuthState` / `DesktopHostAuthBridge` as a copy of a published shared contract that can drift. Version 0.4.0, published Oct 7, exports both types; the pin was just behind. **How:** - Pin 0.4.0 in the catalog. It needs a `minimumReleaseAgeExclude` entry because 0.4.0 is under the release-age gate; the entry replaces the 0.3.0 one. - `DesktopHostAuthState` is now an alias of `ComfyDesktop2AuthState`. - `DesktopHostAuthBridge` extends `ComfyDesktop2AuthBridge` and adds only the optional `switchWorkspace`. That method ships in bridge types 0.5.0 with Comfy-Org/Comfy-Desktop#1671, which is not merged or published yet. It stays optional for Desktop builds without it. Types only, with no runtime or UI change, so there are no AS IS/TO BE screenshots. ## Verification - `pnpm typecheck:app` is clean. - The desktop host, auth store, workspace store and account popover suites pass (317 tests). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Backport of #20484 to
cloud/1.56Automatically created by backport workflow.