Repository navigation
[backport cloud/1.55] fix(agent): mint a promoted host write so prompt-node edits aren’t rejected (#20377) - #20471
Conversation
…jected (PM-1995) (#20377) *PR Created by the Glary-Bot Agent* --- With the agent panel open and a CRDT document bound, typing or pasting into a prompt node can be rejected and not saved. Closing the panel makes the failure disappear (PM-1995). A prompt node in modern templates is often a subgraph instance with a promoted widget. A subgraph instance's type is a definition UUID, so the pinned catalog does not describe it and the document stores promoted values as one opaque positional array. `docOpMinter` minted a named `set_widget`, which the applier rejects with `opaque_widgets`. This carrier is now intentionally limited to the PM-1995 promoted-write fix and its regression coverage. `promotedHostWrite()` mints schema Amendment A15's positional payload for a promoted widget on a top-level subgraph host. `value_index` comes from the live widget-backed input order. The bound document is consulted only as a fail-closed veto: its stored value count and declared promoted-name order must agree before the minter emits the write. A refused write is dropped before enqueue so it cannot poison unrelated operations in the same batch. The app-context/billing refactor and the user-facing promote/demote/reorder refusal policy previously carried in this PR have been removed. They require separate review and are not part of this hotfix. - 6 focused Vitest files: 204 tests passed. - Cloud Playwright: `browser_tests/tests/agent/agentSubgraphFollower.spec.ts`, 2 tests passed. The first case visibly edits a promoted text widget with the agent panel open and verifies the edit remains on canvas without changing its sibling value. - Targeted ESLint completed with zero errors; formatting passed for all 8 changed files. - Diff against current `main`: 8 files, +704/-18. The branch was rebuilt solely from commits already published on this PR; no unpublished Glary-session changes were copied. Fixes PM-1995 --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2155 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b602a8011e68bc9942f652ed0ea575c3081c4095
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-07T22:21:04.572Z",
"gitSha": "2114056bd743a96db78f824537500976a17dea83",
"branch": "christian/backport-20377-cloud-1.55-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1999.5099999999866,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.855,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.79400000000004,
"heapDeltaBytes": 8046068,
"heapUsedBytes": 76658220,
"domNodes": -258,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.416,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1990.3639999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.252000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.97599999999994,
"heapDeltaBytes": -6675976,
"heapUsedBytes": 56317464,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.980000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.6180000000245,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.019000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.21,
"heapDeltaBytes": 8473732,
"heapUsedBytes": 77542992,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 104.431,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1675.0010000000657,
"styleRecalcs": 44,
"styleRecalcDurationMs": 11.432999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.455,
"heapDeltaBytes": -5599704,
"heapUsedBytes": 57360568,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 105.988,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1690.9110000000283,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.220000000000002,
"layouts": 6,
"layoutDurationMs": 1.17,
"taskDurationMs": 268.74600000000004,
"heapDeltaBytes": 3352396,
"heapUsedBytes": 72439620,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.473,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.6269999999931,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.340000000000002,
"layouts": 6,
"layoutDurationMs": 1.0209999999999997,
"taskDurationMs": 246.14799999999997,
"heapDeltaBytes": 3218444,
"heapUsedBytes": 72156728,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.985000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 516.352999999981,
"styleRecalcs": 16,
"styleRecalcDurationMs": 6.6400000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.4,
"heapDeltaBytes": -7948576,
"heapUsedBytes": 61228956,
"domNodes": 23,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 118.18599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 516.2109999999984,
"styleRecalcs": 16,
"styleRecalcDurationMs": 6.917000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.079,
"heapDeltaBytes": -7976016,
"heapUsedBytes": 61308404,
"domNodes": 23,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 111.169,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1026.6839999999888,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.8430000000001,
"heapDeltaBytes": 26361804,
"heapUsedBytes": 97918276,
"domNodes": -293,
"jsHeapTotalBytes": 19288064,
"scriptDurationMs": 37.561,
"eventListeners": -217,
"totalBlockingTimeMs": 410,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1037.2360000000072,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.228,
"heapDeltaBytes": -18351140,
"heapUsedBytes": 73263128,
"domNodes": -294,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 42.68799999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 377,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 712.2249999999894,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.45999999999987,
"heapDeltaBytes": 13913140,
"heapUsedBytes": 91122412,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.62100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 104,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 716.3980000000265,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.54,
"heapDeltaBytes": 14874036,
"heapUsedBytes": 90556916,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 102.56800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 108,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6480.575999999985,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5429999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5597.632,
"heapDeltaBytes": 541672,
"heapUsedBytes": 82497968,
"domNodes": -16,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 4389.603,
"eventListeners": 0,
"totalBlockingTimeMs": 38,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5503.336999999988,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.2559999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4699.682,
"heapDeltaBytes": 18537260,
"heapUsedBytes": 98718876,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 3781.438,
"eventListeners": -174,
"totalBlockingTimeMs": 20,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6078.598,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.7750000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5164.096,
"heapDeltaBytes": 8622100,
"heapUsedBytes": 88195020,
"domNodes": -260,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 3992.9919999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5798.563000000002,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.305999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4999.733,
"heapDeltaBytes": 11973852,
"heapUsedBytes": 93681060,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 3954.158,
"eventListeners": 0,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.4220000000196,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.797,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.214,
"heapDeltaBytes": -23788948,
"heapUsedBytes": 65482256,
"domNodes": -255,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 31.345000000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.4329999999918,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.379999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.084,
"heapDeltaBytes": 3974460,
"heapUsedBytes": 87646548,
"domNodes": -259,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 28.391000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2139.004,
"styleRecalcs": 70,
"styleRecalcDurationMs": 21.554999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1267.8120000000001,
"heapDeltaBytes": 1067776,
"heapUsedBytes": 92087988,
"domNodes": -249,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 632.8459999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2137.418000000025,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.488000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1137.318,
"heapDeltaBytes": -59144,
"heapUsedBytes": 84164596,
"domNodes": -254,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 558.384,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3166.854999999998,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.437999999999999,
"layouts": 60,
"layoutDurationMs": 14.618,
"taskDurationMs": 1247.698,
"heapDeltaBytes": -957580,
"heapUsedBytes": 65485636,
"domNodes": 34,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 566.6179999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3222.689999999943,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.665,
"layouts": 60,
"layoutDurationMs": 15.487,
"taskDurationMs": 1372.321,
"heapDeltaBytes": -13711552,
"heapUsedBytes": 72316144,
"domNodes": -237,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 596.515,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2159.947000000045,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.754999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1319.124,
"heapDeltaBytes": -18691416,
"heapUsedBytes": 75110068,
"domNodes": 18,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 660.6740000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2174.870999999939,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.248000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1401.488,
"heapDeltaBytes": -27845208,
"heapUsedBytes": 66429868,
"domNodes": -222,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 688.0609999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2037.1429999999577,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.546999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.767,
"heapDeltaBytes": -23140520,
"heapUsedBytes": 68737388,
"domNodes": -246,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 32.54600000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2026.585999999952,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.106999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.19999999999993,
"heapDeltaBytes": -23121052,
"heapUsedBytes": 67969972,
"domNodes": -250,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 36.188,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 472.0659999999839,
"styleRecalcs": 50,
"styleRecalcDurationMs": 9.109,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 288.17900000000003,
"heapDeltaBytes": 13202052,
"heapUsedBytes": 77642564,
"domNodes": 25,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 96.829,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 464.698999999996,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.724,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.724,
"heapDeltaBytes": 13534168,
"heapUsedBytes": 84432600,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 99.596,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2021.5550000000349,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.431000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.629,
"heapDeltaBytes": -7252840,
"heapUsedBytes": 63297188,
"domNodes": -271,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.934,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.9240000001064,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.402999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.89000000000004,
"heapDeltaBytes": 9332284,
"heapUsedBytes": 80020908,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.018,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.3720000000344,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.541999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.449,
"heapDeltaBytes": -14386080,
"heapUsedBytes": 56553728,
"domNodes": -272,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 77.24700000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.1539999999595,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.623999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.3019999999999,
"heapDeltaBytes": 8762824,
"heapUsedBytes": 79731132,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 73.026,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 865.9210000000144,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.356999999999992,
"layouts": 5,
"layoutDurationMs": 7.936000000000002,
"taskDurationMs": 620.7990000000001,
"heapDeltaBytes": 20082368,
"heapUsedBytes": 104359152,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 23.092000000000002,
"eventListeners": 2383,
"totalBlockingTimeMs": 96,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8182.58400000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 45.927,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4450.05,
"heapDeltaBytes": 6036556,
"heapUsedBytes": 89972760,
"domNodes": -252,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 2184.741,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8140.435999999909,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.835,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4211.974999999999,
"heapDeltaBytes": -2958964,
"heapUsedBytes": 80584384,
"domNodes": -253,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 1994.0959999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12514.052000000049,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11875.214,
"heapDeltaBytes": -49666924,
"heapUsedBytes": 178448776,
"domNodes": -8062,
"jsHeapTotalBytes": -20250624,
"scriptDurationMs": 189.079,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 9719.847999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8856.25,
"heapDeltaBytes": -57282532,
"heapUsedBytes": 170912956,
"domNodes": -8062,
"jsHeapTotalBytes": -13832192,
"scriptDurationMs": 151.83,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14913.013999999976,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.021000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14470.977,
"heapDeltaBytes": -49522380,
"heapUsedBytes": 186590896,
"domNodes": -8062,
"jsHeapTotalBytes": -15134720,
"scriptDurationMs": 710.7,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14460.440999999946,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.85800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13885.799000000003,
"heapDeltaBytes": -45469512,
"heapUsedBytes": 193279664,
"domNodes": -8062,
"jsHeapTotalBytes": -17854464,
"scriptDurationMs": 694.424,
"eventListeners": -14928,
"totalBlockingTimeMs": 71,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4332.11799999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.473,
"layouts": 20,
"layoutDurationMs": 25.00100000000001,
"taskDurationMs": 4252.159000000001,
"heapDeltaBytes": -33560148,
"heapUsedBytes": 196846052,
"domNodes": -8062,
"jsHeapTotalBytes": 13398016,
"scriptDurationMs": 69.845,
"eventListeners": -14928,
"totalBlockingTimeMs": 106,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4075.584000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.21400000000001,
"layouts": 20,
"layoutDurationMs": 23.56,
"taskDurationMs": 3920.4660000000003,
"heapDeltaBytes": -35673584,
"heapUsedBytes": 192552196,
"domNodes": -8061,
"jsHeapTotalBytes": 8450048,
"scriptDurationMs": 64.09200000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 84,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6322.298999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5974.285999999999,
"heapDeltaBytes": -22251692,
"heapUsedBytes": 165911276,
"domNodes": 0,
"jsHeapTotalBytes": -28311552,
"scriptDurationMs": 92.34699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6068.000000000097,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5562.665000000001,
"heapDeltaBytes": 3099496,
"heapUsedBytes": 179146492,
"domNodes": 0,
"jsHeapTotalBytes": -20447232,
"scriptDurationMs": 81.44999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 86.1510000000294,
"styleRecalcs": 5,
"styleRecalcDurationMs": 10.735,
"layouts": 3,
"layoutDurationMs": 1.3780000000000001,
"taskDurationMs": 59.038999999999994,
"heapDeltaBytes": 3151468,
"heapUsedBytes": 69777144,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.771,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 99.22200000005432,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.627999999999998,
"layouts": 3,
"layoutDurationMs": 1.5259999999999998,
"taskDurationMs": 66.759,
"heapDeltaBytes": 3171872,
"heapUsedBytes": 70058008,
"domNodes": 107,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.820999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #20471 +/- ##
=============================================
Coverage ? 85.01%
=============================================
Files ? 2345
Lines ? 134668
Branches ? 34156
=============================================
Hits ? 114492
Misses ? 19813
Partials ? 363
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@thedatalife rotating the single review owner after the first two-hour window. This cloud/1.55 prompt-node repair is mergeable, and the current head has final required checks green with no pending aggregate. Please approve or leave one concrete finding; I will merge immediately if the head remains eligible. |
Summary
Backports #20377 so edits to promoted prompt widgets remain durable while Agent is open.
Changes
surfaceoption unavailable on this line.Review Focus
Please verify the target-line adaptation preserves the source contract without broadening behavior.
Verification: 99 focused Vitest cases pass across five files; formatting and ESLint pass; commit typecheck and pre-push knip pass.
Source: #20377