Skip to content

[backport cloud/1.54] fix(agent): hide credit warning before consent - #20406

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
christian/backport-20375-cloud-1.54
Oct 7, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
christian/backport-20375-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #20375 to cloud/1.54.

The affected standing credit-warning path exists on this release line. This preserves the inline send-time admission path while suppressing the proactive warning until Agent consent is accepted.

Verification: pnpm test:unit src/workbench/extensions/agent/AgentPanelRoot.test.ts (377 passed).

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) labels Oct 7, 2026
@vercel

vercel Bot commented Oct 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 7, 2026 7:36am UTC
billing-web-test Ignored Ignored Oct 7, 2026 7:36am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 182639b0-fee4-410b-bed5-8d8f67d4bd12

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne
christian-byrne enabled auto-merge (squash) October 7, 2026 07:36
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/07/2026, 07:38:35 AM UTC

Links

🎭 Playwright: ✅ 1989 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1968 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 148ms TBT · 100.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.2 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 177.5 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 88ms TBT · 173.7 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 445ms TBT · 176.3 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 504ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.6 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -194
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 929ms
canvas-mouse-sweep: script duration 172ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 70.0 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 354ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.4 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 438ms
dom-widget-clipping: script duration 161ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 74.0 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 560ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 68.2 MB
large-graph-idle: DOM nodes -275
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1571ms
large-graph-pan: script duration 820ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.5 MB
large-graph-pan: DOM nodes -143
large-graph-pan: event listeners -93
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 1685ms
large-graph-zoom: script duration 788ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 64.0 MB
large-graph-zoom: DOM nodes -121
large-graph-zoom: event listeners -95
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1867ms
legacy-node-drag: script duration 967ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 71.3 MB
legacy-node-drag: DOM nodes -142
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 558ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 68.2 MB
minimap-idle: DOM nodes -284
minimap-idle: event listeners -178
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 422ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 62.3 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 474ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 72.8 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 818ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 73.4 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 944ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 148ms
subgraph-transition-enter: heap used 100.0 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5591ms
viewport-pan-sweep: script duration 2704ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 88.2 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -178
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16601ms
vue-large-graph-idle: script duration 276ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 177.5 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 166
vue-large-graph-pan: task duration 20401ms
vue-large-graph-pan: script duration 944ms
vue-large-graph-pan: TBT 88ms
vue-large-graph-pan: heap used 173.7 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 90ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6022ms
vue-node-resize-workload: script duration 124ms
vue-node-resize-workload: TBT 445ms
vue-node-resize-workload: heap used 176.3 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8345ms
vue-zoom-out-idle: script duration 139ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -14
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 101ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 71.2 MB
workflow-execution: DOM nodes 139
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-10-07T07:47:55.323Z",
  "gitSha": "81a598e523009762ac217b50f1a325ce2073b517",
  "branch": "christian/backport-20375-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2029.6170000000302,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.849,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.68199999999996,
      "heapDeltaBytes": -3398844,
      "heapUsedBytes": 70359900,
      "domNodes": -281,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 7.907000000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.1200000000117,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.049000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.29,
      "heapDeltaBytes": -6658564,
      "heapUsedBytes": 67203252,
      "domNodes": -281,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 8.833,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2000.913999999966,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 33.747,
      "layouts": 14,
      "layoutDurationMs": 4.116,
      "taskDurationMs": 982.0150000000001,
      "heapDeltaBytes": 11261664,
      "heapUsedBytes": 82212880,
      "domNodes": -277,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 181.32999999999998,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1852.4429999999938,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 27.214,
      "layouts": 14,
      "layoutDurationMs": 3.8389999999999995,
      "taskDurationMs": 876.894,
      "heapDeltaBytes": -6913324,
      "heapUsedBytes": 64688980,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 161.676,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.8629999999807,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.687,
      "layouts": 6,
      "layoutDurationMs": 1.0830000000000002,
      "taskDurationMs": 349.63,
      "heapDeltaBytes": 4462676,
      "heapUsedBytes": 75622068,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.552,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.470000000044,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.204,
      "layouts": 6,
      "layoutDurationMs": 0.9349999999999998,
      "taskDurationMs": 357.602,
      "heapDeltaBytes": 4990176,
      "heapUsedBytes": 78236860,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.006000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 642.0499999999834,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.002999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 433.368,
      "heapDeltaBytes": 18269428,
      "heapUsedBytes": 88981384,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 159.49099999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 659.7130000000107,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.057,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.77700000000004,
      "heapDeltaBytes": -6891596,
      "heapUsedBytes": 66234312,
      "domNodes": 16,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 161.564,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.1529999999793,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.9079999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 571.304,
      "heapDeltaBytes": -10629404,
      "heapUsedBytes": 66456760,
      "domNodes": -281,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 37.64,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2035.421000000042,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 6.428999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 549.179,
      "heapDeltaBytes": -1280396,
      "heapUsedBytes": 76493092,
      "domNodes": -269,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 37.01700000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2211.806000000024,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.250999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1545.6450000000002,
      "heapDeltaBytes": 10136804,
      "heapUsedBytes": 76417504,
      "domNodes": 2,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 826.9479999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2269.2240000000083,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.032999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1596.41,
      "heapDeltaBytes": -1013140,
      "heapUsedBytes": 77684296,
      "domNodes": -287,
      "jsHeapTotalBytes": -929792,
      "scriptDurationMs": 814.018,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3587.919999999997,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.683,
      "layouts": 60,
      "layoutDurationMs": 12.411,
      "taskDurationMs": 1737.89,
      "heapDeltaBytes": -16112628,
      "heapUsedBytes": 66684644,
      "domNodes": -265,
      "jsHeapTotalBytes": 3178496,
      "scriptDurationMs": 804.3979999999999,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3513.3429999999635,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.706,
      "layouts": 60,
      "layoutDurationMs": 11.769,
      "taskDurationMs": 1632.558,
      "heapDeltaBytes": -291948,
      "heapUsedBytes": 67441524,
      "domNodes": 24,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 771.517,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3014.011000000039,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.752999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1842.701,
      "heapDeltaBytes": 4887912,
      "heapUsedBytes": 74711712,
      "domNodes": 0,
      "jsHeapTotalBytes": 454656,
      "scriptDurationMs": 973.682,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3086.7279999999937,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.665000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1890.622,
      "heapDeltaBytes": -10991144,
      "heapUsedBytes": 74843020,
      "domNodes": -284,
      "jsHeapTotalBytes": -1347584,
      "scriptDurationMs": 959.4,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.408999999987,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.402999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 560.2280000000001,
      "heapDeltaBytes": -12021488,
      "heapUsedBytes": 67673208,
      "domNodes": -285,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 33.592000000000006,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.7620000000434,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.007000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 555.066,
      "heapDeltaBytes": -4921084,
      "heapUsedBytes": 75406192,
      "domNodes": -282,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 39.684000000000005,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 588.4760000000142,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.303999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 411.923,
      "heapDeltaBytes": -10516552,
      "heapUsedBytes": 65195636,
      "domNodes": 16,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 147.254,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 624.7829999999794,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.463000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.62,
      "heapDeltaBytes": -10529924,
      "heapUsedBytes": 65492148,
      "domNodes": 20,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 149.44,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.0550000000035,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.207,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.84099999999995,
      "heapDeltaBytes": 7461600,
      "heapUsedBytes": 81057456,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.127000000000002,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.54899999995,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.023,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.993,
      "heapDeltaBytes": -4414392,
      "heapUsedBytes": 71705700,
      "domNodes": -297,
      "jsHeapTotalBytes": 4489216,
      "scriptDurationMs": 7.725999999999998,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1704.952999999989,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.544,
      "layouts": 18,
      "layoutDurationMs": 4.264,
      "taskDurationMs": 797.282,
      "heapDeltaBytes": 3765012,
      "heapUsedBytes": 79800284,
      "domNodes": -295,
      "jsHeapTotalBytes": 5013504,
      "scriptDurationMs": 107.45,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1731.2339999999722,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.718000000000004,
      "layouts": 18,
      "layoutDurationMs": 4.731,
      "taskDurationMs": 839.1359999999999,
      "heapDeltaBytes": 8327864,
      "heapUsedBytes": 74063616,
      "domNodes": -297,
      "jsHeapTotalBytes": 2654208,
      "scriptDurationMs": 116.237,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.3620000000296,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.278,
      "layouts": 15,
      "layoutDurationMs": 15.732000000000003,
      "taskDurationMs": 944.3090000000001,
      "heapDeltaBytes": 20158324,
      "heapUsedBytes": 104820036,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 31.35299999999999,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 148,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8370.536000000015,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.352999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5584.417,
      "heapDeltaBytes": 9864548,
      "heapUsedBytes": 90191068,
      "domNodes": -284,
      "jsHeapTotalBytes": 258048,
      "scriptDurationMs": 2712.742,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8280.260999999995,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 35.04,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5596.764,
      "heapDeltaBytes": 14519416,
      "heapUsedBytes": 94844848,
      "domNodes": -252,
      "jsHeapTotalBytes": 258048,
      "scriptDurationMs": 2695.793,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16900.615000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16452.550000000003,
      "heapDeltaBytes": -24291132,
      "heapUsedBytes": 193522516,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11517952,
      "scriptDurationMs": 271.182,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17294.555999999942,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16749.876,
      "heapDeltaBytes": -54580740,
      "heapUsedBytes": 178735436,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16232448,
      "scriptDurationMs": 280.416,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20667.839000000014,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 17.542999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20354.207000000002,
      "heapDeltaBytes": -38880340,
      "heapUsedBytes": 184070492,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18096128,
      "scriptDurationMs": 911.5790000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 47,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20800.252,
      "styleRecalcs": 163,
      "styleRecalcDurationMs": 18.683000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20448.277,
      "heapDeltaBytes": -42614236,
      "heapUsedBytes": 180255452,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14688256,
      "scriptDurationMs": 975.4540000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6086.675999999954,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 84.25299999999997,
      "layouts": 20,
      "layoutDurationMs": 24.03100000000001,
      "taskDurationMs": 5949.196999999999,
      "heapDeltaBytes": -34860496,
      "heapUsedBytes": 187974892,
      "domNodes": -8068,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 139.423,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 365,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6215.994000000023,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 95.40100000000001,
      "layouts": 20,
      "layoutDurationMs": 24.347999999999995,
      "taskDurationMs": 6093.852999999999,
      "heapDeltaBytes": -45519796,
      "heapUsedBytes": 181814948,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10350592,
      "scriptDurationMs": 108.47099999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 524,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8498.560999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8301.797,
      "heapDeltaBytes": 20032784,
      "heapUsedBytes": 179513752,
      "domNodes": 0,
      "jsHeapTotalBytes": -11272192,
      "scriptDurationMs": 133.75399999999993,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8547.285999999986,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8388.613000000001,
      "heapDeltaBytes": 1154836,
      "heapUsedBytes": 178981292,
      "domNodes": 0,
      "jsHeapTotalBytes": -27787264,
      "scriptDurationMs": 143.536,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 477.89900000003627,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 27.691999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.678,
      "taskDurationMs": 127.44800000000001,
      "heapDeltaBytes": 5027228,
      "heapUsedBytes": 77028240,
      "domNodes": 152,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.166000000000002,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 109.41200000002027,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.995000000000001,
      "layouts": 2,
      "layoutDurationMs": 1.1099999999999999,
      "taskDurationMs": 75.22400000000002,
      "heapDeltaBytes": 2989364,
      "heapUsedBytes": 72296596,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.388,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51176 76656 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/scripts/app.ts 72.7% 255
src/platform/workspace/stores/teamWorkspaceStore.ts 39.6% 253
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #20406   +/-   ##
=============================================
  Coverage              ?   84.15%           
=============================================
  Files                 ?     2132           
  Lines                 ?   128491           
  Branches              ?    32707           
=============================================
  Hits                  ?   108138           
  Misses                ?    20172           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.75% <ø> (?)
unit 79.61% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/AgentPanelRoot.vue 92.23% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne requested review from DrJKL and removed request for thedatalife October 7, 2026 09:49
@christian-byrne christian-byrne assigned DrJKL and ryan-di and unassigned thedatalife Oct 7, 2026
@christian-byrne
christian-byrne removed the request for review from DrJKL October 7, 2026 12:08

@ryan-di ryan-di left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport of #20375. Checked the consent gate and regression coverage; the inline send-time admission path is preserved. Required CI is passing.

@comfy-pr-bot
comfy-pr-bot merged commit 6ab74f7 into cloud/1.54 Oct 7, 2026
117 of 120 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the christian/backport-20375-cloud-1.54 branch October 7, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants