Skip to content

test(agent): cover media tray preview flow - #20404

Merged
DrJKL merged 11 commits into
codex/agent-asset-media-previewsfrom
christian-byrne/op514-fe20157-blackbox
Oct 7, 2026
Merged

DrJKL merged 11 commits into
codex/agent-asset-media-previewsfrom
christian-byrne/op514-fe20157-blackbox

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds a Playwright case to agentComposerAssetDrop.spec.ts, as requested in the #20157 review. It drops the real MP4 asset on the composer and checks that the chip poster is a decoded blob: image, Enter opens the visible native video with focus, and Escape closes it and returns focus to the chip. Test-only, targeting the #20157 branch.

Verification

  • Mutation control: deleting the ensureThumbnail(attachment) call made the case fail at the visible poster assertion; restoring it passed 5/5.
  • Focused cloud Playwright case: 5/5 passed; whole spec: 4/4 passed.
  • AttachmentChip.test.ts: 25/25 passed.
  • Targeted eslint, type-aware oxlint, oxfmt, browser/app typechecks, knip, and fallow passed.
  • ARIA mutation control: hard-coding the trigger to aria-expanded="false" failed both keyboard-open rows; restoring the binding passed 25/25.

@christian-byrne
christian-byrne requested review from a team as code owners October 7, 2026 07:21
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: b69879d9-49d4-4cdf-a375-959e22719dcc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 7eaa8684021572f7a61bad2616639001216e7546

Full docs: ADR-DEVEX-LINT-0015

🎭 Playwright: ✅ 2237 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2215 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
dom-widget-order-dense-n200-w200-i120: · 30.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 504ms TBT · 90.2 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 40.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 217ms TBT · 86.9 MB heap
extension-clean-combined-draw: · 34.8 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 225ms TBT · 69.0 MB heap
extension-rgthree-prototype-draw: · 35.9 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 105ms TBT · 80.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.5 MB heap
legacy-node-drag: · 59.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
subgraph-transition-enter: · 52.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 112ms TBT · 106.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
vue-large-graph-idle: · 31.0 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 1ms TBT · 173.9 MB heap
vue-large-graph-pan: · 23.0 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 12ms TBT · 178.9 MB heap
vue-node-resize-workload: · 29.6 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 9ms TBT · 212.1 MB heap
vue-zoom-out-idle: · 31.5 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 174.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
agent-composer-empty-conversation-typing: · 59.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
agent-composer-long-conversation-typing: · 57.1 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 110.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 418ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 73.1 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 762ms
canvas-mouse-sweep: script duration 136ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.6 MB
canvas-mouse-sweep: DOM nodes -105
canvas-mouse-sweep: event listeners -66
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 3
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 322ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 56.7 MB
canvas-zoom-sweep: DOM nodes -70
canvas-zoom-sweep: event listeners 39
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 434ms
dom-widget-clipping: script duration 160ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 68.6 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 33ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 790ms
dom-widget-order-dense-n200-w200-i120: script duration 59ms
dom-widget-order-dense-n200-w200-i120: TBT 504ms
dom-widget-order-dense-n200-w200-i120: heap used 90.2 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 468ms
dom-widget-order-sparse-n1000-w20-i120: script duration 142ms
dom-widget-order-sparse-n1000-w20-i120: TBT 217ms
dom-widget-order-sparse-n1000-w20-i120: heap used 86.9 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 29ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 2
extension-clean-combined-draw: task duration 7680ms
extension-clean-combined-draw: script duration 6376ms
extension-clean-combined-draw: TBT 225ms
extension-clean-combined-draw: heap used 69.0 MB
extension-clean-combined-draw: DOM nodes -157
extension-clean-combined-draw: event listeners -77
extension-rgthree-prototype-draw: avg frame time 28ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 7919ms
extension-rgthree-prototype-draw: script duration 6468ms
extension-rgthree-prototype-draw: TBT 105ms
extension-rgthree-prototype-draw: heap used 80.0 MB
extension-rgthree-prototype-draw: DOM nodes -141
extension-rgthree-prototype-draw: event listeners -73
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 458ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 72.6 MB
large-graph-idle: DOM nodes -164
large-graph-idle: event listeners -74
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1470ms
large-graph-pan: script duration 772ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 76.8 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 17ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1574ms
large-graph-zoom: script duration 748ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.5 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1812ms
legacy-node-drag: script duration 964ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 75.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 501ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 73.5 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 406ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 67.7 MB
subgraph-dom-widget-clipping: DOM nodes -114
subgraph-dom-widget-clipping: event listeners -89
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 405ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.1 MB
subgraph-idle: DOM nodes -126
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 16ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 702ms
subgraph-mouse-sweep: script duration 96ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.8 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 882ms
subgraph-transition-enter: script duration 27ms
subgraph-transition-enter: TBT 112ms
subgraph-transition-enter: heap used 106.6 MB
subgraph-transition-enter: DOM nodes 14570
subgraph-transition-enter: event listeners 2458
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 21ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5194ms
viewport-pan-sweep: script duration 2542ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 64.4 MB
viewport-pan-sweep: DOM nodes -154
viewport-pan-sweep: event listeners -63
vue-large-graph-idle: avg frame time 32ms
vue-large-graph-idle: p95 frame time 58ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17639ms
vue-large-graph-idle: script duration 301ms
vue-large-graph-idle: TBT 1ms
vue-large-graph-idle: heap used 173.9 MB
vue-large-graph-idle: DOM nodes -3047
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 43ms
vue-large-graph-pan: p95 frame time 83ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 182
vue-large-graph-pan: task duration 22868ms
vue-large-graph-pan: script duration 860ms
vue-large-graph-pan: TBT 12ms
vue-large-graph-pan: heap used 178.9 MB
vue-large-graph-pan: DOM nodes -3046
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 34ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 67ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5600ms
vue-node-resize-workload: script duration 101ms
vue-node-resize-workload: TBT 9ms
vue-node-resize-workload: heap used 212.1 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 32ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8878ms
vue-zoom-out-idle: script duration 141ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 174.6 MB
vue-zoom-out-idle: DOM nodes -3046
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 4
workflow-execution: style recalc count 18
workflow-execution: task duration 138ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.2 MB
workflow-execution: DOM nodes 14
workflow-execution: event listeners 4
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 25ms
agent-composer-empty-conversation-typing: style recalc duration 93ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 77
agent-composer-empty-conversation-typing: task duration 819ms
agent-composer-empty-conversation-typing: script duration 327ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 70.3 MB
agent-composer-empty-conversation-typing: DOM nodes 77
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 18ms
agent-composer-long-conversation-typing: p95 frame time 25ms
agent-composer-long-conversation-typing: layout duration 30ms
agent-composer-long-conversation-typing: style recalc duration 265ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 77
agent-composer-long-conversation-typing: task duration 1371ms
agent-composer-long-conversation-typing: script duration 474ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 110.3 MB
agent-composer-long-conversation-typing: DOM nodes 77
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-07T20:54:11.886Z",
  "gitSha": "4c373a6a7403168636dfef55d783e6253d6c507a",
  "branch": "christian-byrne/op514-fe20157-blackbox",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2017.5570000000107,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.5850000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 421.74499999999995,
      "heapDeltaBytes": 7328496,
      "heapUsedBytes": 76922328,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.147000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2009.396000000038,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.808,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 413.989,
      "heapDeltaBytes": 7423616,
      "heapUsedBytes": 76289544,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.99,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1722.1569999999815,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 13.956999999999999,
      "layouts": 12,
      "layoutDurationMs": 4.227999999999999,
      "taskDurationMs": 746.155,
      "heapDeltaBytes": 25445432,
      "heapUsedBytes": 80550500,
      "domNodes": -209,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 130.272,
      "eventListeners": -132,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66504854368932,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1740.5390000000125,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 14.793000000000001,
      "layouts": 12,
      "layoutDurationMs": 4.8580000000000005,
      "taskDurationMs": 778.4,
      "heapDeltaBytes": 3252304,
      "heapUsedBytes": 71731656,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 142.379,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1696.374999999989,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.522,
      "layouts": 3,
      "layoutDurationMs": 0.9169999999999998,
      "taskDurationMs": 322.547,
      "heapDeltaBytes": 4475212,
      "heapUsedBytes": 59408576,
      "domNodes": 45,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.371999999999998,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66568627450981,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1696.3450000000648,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.720999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.9730000000000001,
      "taskDurationMs": 321.782,
      "heapDeltaBytes": 4506452,
      "heapUsedBytes": 59406044,
      "domNodes": -185,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.708000000000002,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 630.4820000000291,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.332,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.067,
      "heapDeltaBytes": -4406516,
      "heapUsedBytes": 64923080,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 156.318,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66486486486485,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 628.5480000000234,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.5379999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.3020000000001,
      "heapDeltaBytes": 17895484,
      "heapUsedBytes": 78959052,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 163.249,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66842105263157,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1129.1400000000067,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 789.38,
      "heapDeltaBytes": 13106000,
      "heapUsedBytes": 94343944,
      "domNodes": 0,
      "jsHeapTotalBytes": 4358144,
      "scriptDurationMs": 57.718,
      "eventListeners": 0,
      "totalBlockingTimeMs": 503,
      "frameDurationMs": 33.332352941176474,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1129.0629999999737,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 791.336,
      "heapDeltaBytes": 11769088,
      "heapUsedBytes": 94810324,
      "domNodes": 0,
      "jsHeapTotalBytes": 1998848,
      "scriptDurationMs": 60.95,
      "eventListeners": 0,
      "totalBlockingTimeMs": 504,
      "frameDurationMs": 33.332352941176474,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 847.500000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 464.3550000000003,
      "heapDeltaBytes": 19656904,
      "heapUsedBytes": 101558580,
      "domNodes": 0,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 140.67800000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 217,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 845.792000000074,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.5390000000004,
      "heapDeltaBytes": -6914032,
      "heapUsedBytes": 80713948,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 142.93599999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 216,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 8678.311999999949,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.7620000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7749.390000000001,
      "heapDeltaBytes": -12628096,
      "heapUsedBytes": 73299036,
      "domNodes": -141,
      "jsHeapTotalBytes": -9048064,
      "scriptDurationMs": 6563.668,
      "eventListeners": -73,
      "totalBlockingTimeMs": 326,
      "frameDurationMs": 30.30174825174825,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 8591.41299999999,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.7119999999999991,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7610.492,
      "heapDeltaBytes": -14617580,
      "heapUsedBytes": 71308216,
      "domNodes": -172,
      "jsHeapTotalBytes": -11407360,
      "scriptDurationMs": 6187.446000000001,
      "eventListeners": -81,
      "totalBlockingTimeMs": 123,
      "frameDurationMs": 27.128075709779182,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 8969.614999999976,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8007.32,
      "heapDeltaBytes": -3622944,
      "heapUsedBytes": 82048416,
      "domNodes": -141,
      "jsHeapTotalBytes": -9572352,
      "scriptDurationMs": 6552.488,
      "eventListeners": -73,
      "totalBlockingTimeMs": 109,
      "frameDurationMs": 28.195911949685538,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 8880.321999999978,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.6650000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7830.651,
      "heapDeltaBytes": -224764,
      "heapUsedBytes": 85681216,
      "domNodes": -141,
      "jsHeapTotalBytes": -9572352,
      "scriptDurationMs": 6384.236000000001,
      "eventListeners": -73,
      "totalBlockingTimeMs": 100,
      "frameDurationMs": 27.58695652173913,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2009.7260000000006,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.1030000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 364.44,
      "heapDeltaBytes": -5110308,
      "heapUsedBytes": 71947504,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 32.269000000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2046.8329999999924,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.9460000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 551.5100000000001,
      "heapDeltaBytes": -50264248,
      "heapUsedBytes": 80297248,
      "domNodes": -328,
      "jsHeapTotalBytes": -4030464,
      "scriptDurationMs": 32.88,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2156.6990000000033,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 7.529000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1467.3310000000001,
      "heapDeltaBytes": -9881436,
      "heapUsedBytes": 80162404,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 773.0669999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665891472868214,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2169.439000000011,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 8.012000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1472.6739999999998,
      "heapDeltaBytes": -9646280,
      "heapUsedBytes": 80833624,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 770.097,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3378.2380000000103,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 7.113000000000001,
      "layouts": 60,
      "layoutDurationMs": 16.223000000000003,
      "taskDurationMs": 1544.648,
      "heapDeltaBytes": 4505144,
      "heapUsedBytes": 69389096,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 733.8169999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666009852216753,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3574.2179999999735,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 8.475999999999999,
      "layouts": 60,
      "layoutDurationMs": 16.948,
      "taskDurationMs": 1602.4509999999998,
      "heapDeltaBytes": 7292200,
      "heapUsedBytes": 86863584,
      "domNodes": 24,
      "jsHeapTotalBytes": 299008,
      "scriptDurationMs": 762.274,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66588785046729,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2748.9140000000134,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.747999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1825.269,
      "heapDeltaBytes": -9079744,
      "heapUsedBytes": 71559352,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 974.668,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.87116564417178,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2712.016999999946,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.716,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1799.287,
      "heapDeltaBytes": 17941312,
      "heapUsedBytes": 87293944,
      "domNodes": 0,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 953.7509999999999,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.76975308641975,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2014.1290000000254,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.119,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.55500000000006,
      "heapDeltaBytes": -4105252,
      "heapUsedBytes": 76909956,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 32.80400000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2015.0990000000775,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.5669999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.48099999999994,
      "heapDeltaBytes": -5182780,
      "heapUsedBytes": 77157532,
      "domNodes": 0,
      "jsHeapTotalBytes": 299008,
      "scriptDurationMs": 33.745,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 602.9859999999871,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.36,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.087,
      "heapDeltaBytes": -43331720,
      "heapUsedBytes": 66847448,
      "domNodes": -228,
      "jsHeapTotalBytes": -2883584,
      "scriptDurationMs": 145.44000000000003,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668571428571443,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 579.0950000000521,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 6.411999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 395.19300000000004,
      "heapDeltaBytes": 12804484,
      "heapUsedBytes": 75038960,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 144.54,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.7879999999723,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.9659999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.62199999999996,
      "heapDeltaBytes": 3889280,
      "heapUsedBytes": 68336436,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.021000000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.3069999999598,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.199000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.926,
      "heapDeltaBytes": 2288064,
      "heapUsedBytes": 57778108,
      "domNodes": -252,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.345000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.9250000000025,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 15.437,
      "layouts": 16,
      "layoutDurationMs": 6.099,
      "taskDurationMs": 693.241,
      "heapDeltaBytes": 139164,
      "heapUsedBytes": 71414096,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 91.44,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66568627450981,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.1969999999937,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 15.781999999999998,
      "layouts": 16,
      "layoutDurationMs": 6.014,
      "taskDurationMs": 709.997,
      "heapDeltaBytes": -4361800,
      "heapUsedBytes": 58217540,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 100.453,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1367.841999999996,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 26.052,
      "layouts": 5,
      "layoutDurationMs": 13.180999999999997,
      "taskDurationMs": 881.6389999999999,
      "heapDeltaBytes": 36299824,
      "heapUsedBytes": 111827676,
      "domNodes": 14570,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 27.130000000000003,
      "eventListeners": 2458,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 19.212500000000016,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8196.088999999973,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 20.159999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5171.273999999999,
      "heapDeltaBytes": -65443692,
      "heapUsedBytes": 65147076,
      "domNodes": -308,
      "jsHeapTotalBytes": -1409024,
      "scriptDurationMs": 2504.006,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536587,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8332.998999999973,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 21.818,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5217.182,
      "heapDeltaBytes": -19460272,
      "heapUsedBytes": 69911536,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 2580.796,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6662,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18555.705999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17691.145,
      "heapDeltaBytes": -41344936,
      "heapUsedBytes": 182704284,
      "domNodes": -3046,
      "jsHeapTotalBytes": 1941504,
      "scriptDurationMs": 272.896,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.37225130890052,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18475.025000000074,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17587.318,
      "heapDeltaBytes": -33275600,
      "heapUsedBytes": 182016320,
      "domNodes": -3047,
      "jsHeapTotalBytes": 6172672,
      "scriptDurationMs": 329.845,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 32.05885416666667,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23324.336999999956,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 16.175999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22867.479,
      "heapDeltaBytes": -31732664,
      "heapUsedBytes": 188151880,
      "domNodes": -3046,
      "jsHeapTotalBytes": 892928,
      "scriptDurationMs": 846.367,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 13,
      "frameDurationMs": 43.20796296296296,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23264.774999999987,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 17.13400000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22869.297,
      "heapDeltaBytes": -37196788,
      "heapUsedBytes": 186965096,
      "domNodes": -3046,
      "jsHeapTotalBytes": 892928,
      "scriptDurationMs": 874.5939999999999,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 11,
      "frameDurationMs": 43.619324577861164,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4924.581999999987,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 67.124,
      "layouts": 20,
      "layoutDurationMs": 24.789000000000005,
      "taskDurationMs": 4822.157,
      "heapDeltaBytes": 1082360,
      "heapUsedBytes": 226974720,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 90.363,
      "eventListeners": 0,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 30.26503067484663,
      "p95FrameDurationMs": 50.099999999998545
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6551.110999999992,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 67.39400000000003,
      "layouts": 20,
      "layoutDurationMs": 24.823999999999998,
      "taskDurationMs": 6378.788000000001,
      "heapDeltaBytes": 5196500,
      "heapUsedBytes": 217875144,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 112.07699999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 37.214772727272724,
      "p95FrameDurationMs": 83.30000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9212.077000000023,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8751.857000000002,
      "heapDeltaBytes": -33043088,
      "heapUsedBytes": 182974380,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7098368,
      "scriptDurationMs": 136.55800000000008,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.618936877076422,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9459.195000000022,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9004.279000000002,
      "heapDeltaBytes": -35917036,
      "heapUsedBytes": 183110968,
      "domNodes": -3046,
      "jsHeapTotalBytes": 5103616,
      "scriptDurationMs": 146.19200000000004,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.86909722222222,
      "p95FrameDurationMs": 66.69999999999709
    },
    {
      "name": "workflow-execution",
      "durationMs": 506.05400000006284,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 21.495000000000005,
      "layouts": 5,
      "layoutDurationMs": 2.3520000000000003,
      "taskDurationMs": 178.542,
      "heapDeltaBytes": -44880400,
      "heapUsedBytes": 60449620,
      "domNodes": -76,
      "jsHeapTotalBytes": -3145728,
      "scriptDurationMs": 15.326000000000002,
      "eventListeners": -58,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667741935483896,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 441.31399999992027,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 12.391000000000002,
      "layouts": 3,
      "layoutDurationMs": 0.9240000000000002,
      "taskDurationMs": 97.47500000000001,
      "heapDeltaBytes": 5914328,
      "heapUsedBytes": 72005076,
      "domNodes": 103,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.983999999999998,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 823.4759999999142,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 90.735,
      "layouts": 76,
      "layoutDurationMs": 24.363,
      "taskDurationMs": 791.495,
      "heapDeltaBytes": 17690596,
      "heapUsedBytes": 83782000,
      "domNodes": 77,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 315.073,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666000000000004,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 873.9369999999553,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 95.219,
      "layouts": 76,
      "layoutDurationMs": 24.754,
      "taskDurationMs": 846.599,
      "heapDeltaBytes": -13584688,
      "heapUsedBytes": 63552140,
      "domNodes": 77,
      "jsHeapTotalBytes": 17825792,
      "scriptDurationMs": 338.37300000000005,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.992156862745105,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1369.0770000000612,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 267.584,
      "layouts": 76,
      "layoutDurationMs": 29.557,
      "taskDurationMs": 1347.47,
      "heapDeltaBytes": 10336544,
      "heapUsedBytes": 115641052,
      "domNodes": 77,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 478.191,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.298734177215184,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1415.1110000000244,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 261.76899999999995,
      "layouts": 76,
      "layoutDurationMs": 29.682,
      "taskDurationMs": 1393.953,
      "heapDeltaBytes": 10483760,
      "heapUsedBytes": 115731104,
      "domNodes": 77,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 469.005,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.708749999999988,
      "p95FrameDurationMs": 33.29999999999927
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 54515 84194 64.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.8% 1167
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.8% 369
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 79.0% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 39.3% 258
src/scripts/app.ts 73.0% 255
src/core/webSessionIdentity.ts 3.3% 231
src/scripts/pnginfo.ts 20.7% 222

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/07/2026, 08:42:00 PM UTC

Links

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 7, 2026
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                         Coverage Diff                          @@
##           codex/agent-asset-media-previews   #20404      +/-   ##
====================================================================
- Coverage                             86.33%   86.26%   -0.07%     
====================================================================
  Files                                  2497     2497              
  Lines                                141829   141822       -7     
  Branches                              37097    39009    +1912     
====================================================================
- Hits                                 122442   122337     -105     
- Misses                                19006    19104      +98     
  Partials                                381      381              
Flag Coverage Δ
e2e 64.72% <ø> (-0.01%) ⬇️
unit 83.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: comment. The poster, keyboard-open, and Escape checks hold up, but the removal phase at the end cannot fail and should be cut.

The new case adds real signal that no lower level gives: Chromium actually decodes the served MP4 into a blob: poster, reka's focus scope moves focus into the portaled player, and the app's Escape handling returns focus to the trigger. The cleanup claim is the problem. Clicking Remove dismisses the popover as an outside interaction before removal runs, so expect(player).toHaveCount(0) passes whether or not removal cleans anything up. I reproduced that with the real component and reka wrapper. The other items are P3 trims and nits. CI is green on a2f320b.

Pre-merge blockers: none.

Findings without an anchorable line (6)
  1. P3, stale file header. Lines 12-21 say the cases here pin "that every view mode actually publishes that payload, and that the chip names the asset dragged". The new case covers neither. A reader looking for the chip's preview coverage won't look in this file, and the header misdescribes it. The lines are outside the diff hunk, so here is the replacement for lines 20-21:

    // view-agnostic by construction; what these cases pin is that every view mode
    // actually publishes that payload, that the chip names the asset dragged, and
    // that a dropped MP4's chip previews it with a generated poster.
  2. Nit (P3), optional test.step. The case has four phases (attach, poster, open, Escape) and no test.step, so a failure trace is one undivided body. After the trims in the inline comments the body is short enough that this is optional.

  3. P3, cross-PR note for #20157 rather than a defect here. Open PR #20246 changes startAssetDrag in src/platform/assets/utils/assetDragUtil.ts to publish the inline file URL as preview_url for video and audio. #20157 keeps preview_url for a real poster and puts the playable file in media_url. If that conflict is resolved toward #20246, ensureThumbnail skips generation (previewUrl is already set), the chip renders <img src=mp4>, and this test fails at line 91. That outcome is fine; this test guards the #20157 policy. Whoever merges second should know it will go red.

  4. P3, PR description. "The existing real-MP4 drag case now verifies..." doesn't match the diff. It is +45/-0, the grid/list case is unchanged, and a separate test was added.

  5. P3, PR description. "Requested on #20157" points at a 32-file PR. Linking the review that asked for this (#20157 (review)) lets a reader match this PR to the blocker it clears.

  6. Nit (P3), PR description length. The template and AGENTS.md ask for a concise body. The Verification section mixes the red/green result and checks with run narration ("4.3s", "carrier", the dev-server warmup story). A shorter version, assuming the removal phase is dropped:

    ## Summary
    
    Adds a Playwright case to `agentComposerAssetDrop.spec.ts`, as requested in the [#20157 review](https://github.com/Comfy-Org/ComfyUI_frontend/pull/20157#pullrequestreview-5438177369). It drops the real-MP4 asset on the composer and checks the chip's `blob:` poster, that Enter opens the native video with focus, and that Escape returns focus to the chip. Test-only, targeting the #20157 branch.
    
    ## Verification
    
    - Fails on 6181b6dd at the first poster assertion; passes on 7eaa868 + a2f320bee.
    - `pnpm typecheck:browser`, oxlint, oxfmt, knip, and fallow pass.
Existing findings

None. CodeRabbit skipped this PR because it targets a non-default base. The Fallow and Codecov reports raise nothing about this file.

Unverified

The removal-phase finding is reproduced in happy-dom with the real AttachmentChip, AssetHoverPreview, and reka popover. I rendered the chip with no parent that removes it, opened the preview with Enter, and clicked Remove: remove was emitted once, the chip stayed in the document, and the <video> still unmounted. I did not run it in Chromium. To settle it there, make the Remove click a no-op and drop line 114; line 115 should still pass.

Checked and cleared (9)
  • Line 90 poster toBeVisible is not redundant with line 91. A hidden or zero-size <img> with a blob src passes line 91 but fails line 90.
  • Line 99 player toBeVisible is not redundant with line 102. A focused but zero-size player passes toBeFocused but fails toBeVisible.
  • Asserting that the player poster equals the chip src is unnecessary. AttachmentChip.test.ts ("shows a video poster while keeping the playable file separate") pins poster to the chip's previewUrl.
  • Asserting the player src is unnecessary. The thumbnail is generated from the same mediaUrl the player receives (agentComposerStore.ts ensureThumbnail), so a wrong media URL already fails line 91, and the chip unit test pins the src pass-through.
  • Proving Tab reachability here is unnecessary. The first it.for in AttachmentChip.test.ts tabs to the trigger.
  • The attach recipe repeated three times in this file stays inline. testing-principles.md prefers some repetition to indirection, and the list-view row varies the drag source.
  • getByLabel(...).and(page.locator('video')) is needed. <video> has no ARIA role, and the label alone matches the chip group, the dialog, the region, and the video.
  • chip.hover() before Remove is needed. Remove is pointer-events-none until group hover, and focus sits in the portaled popover, so group-focus-within does not apply.
  • The @ui tag is documented in browser_tests/README.md (Test Tags).
Coverage
  • Depth: standard. Lanes run: correctness, tests, maintainability, idiomaticity, documentation. None skipped.
  • Lenses: blast-radius, idempotency, shared-state, designing-test-suites, reviewing-playwright-specs, hardening-flaky-e2e-tests, writing-playwright-tests, test-mock-quality-analysis, consolidating-test-setup, prove-it-works, ponytail, no-comments (0 added comment lines), minimize-reader-load, subtract-before-you-add, laziness-protocol, typescript-best-practices, type-system-discipline, technical-writing. regression-risk-reviewer did not apply because no pre-image lines changed.
  • Checks at a2f320b: pnpm exec playwright test --list on the spec (4 tests, exit 0), pnpm typecheck:browser (exit 0), type-aware oxlint and oxfmt on the spec (exit 0), pnpm fallow audit --base 7eaa868 (0 findings). I applied the inline suggestions together and re-ran oxfmt, oxlint, and typecheck:browser; all passed.
  • Other evidence: a Chromium codec probe (the bundled browser decodes the fixture MP4) and the happy-dom repro above. I did not run the spec itself because no backend was started; CI's playwright-video-new-tests (cloud) and cloud shards pass.
  • Open PRs touching the same files were checked; #20246 is the only policy overlap.

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ready for human review. Every actionable round-one finding is fixed at 27a1d3a, and one optional unit-test nit remains.

The browser case now proves only what needs a browser: a real decoded blob: poster, Enter opening the visible player with focus, and Escape closing it and returning focus to the trigger. The vacuous removal phase is gone. The player locator lives on AgentPanel, and the closed aria-expanded state moved into AttachmentChip.test.ts. The one new item is inline. That unit row asserts only the closed half of aria-expanded, so a trigger hard-coded to aria-expanded="false" still passes all 25 tests (I mutated it to check). A suggestion adds the open half.

The cross-PR note from round one still stands for whoever merges #20157 against #20246. #20246 is still open and still publishes the inline file URL as video preview_url. If that conflict resolves toward #20246, this case goes red at the poster assertion, which is the guard working as intended.

CI was still running at review time (23 passed, 12 in progress, none failed). This verdict assumes the remaining cloud Playwright jobs pass.

Checked and cleared this round (2)
  • attachmentPreviewPlayer matching video, audio although its one caller is a video. AssetMediaPreview.vue renders either element under the same aria-label, so the method name stays honest for both.
  • The /^blob:/ check beside the naturalWidth poll is not redundant. A decoded server thumbnail would pass naturalWidth but fail /^blob:/, and that is the "generation did not run" defect.
Review record

Round one: review at a2f320b.

  • P2, removal phase could not fail (outside pointerdown dismissed the popover first): fixed in c69255a, author reply.
  • P2, test title claimed cleanup: fixed in 9229a44, author reply.
  • P3, hand-copied Preview {name} template in the trigger query: fixed in d47e90b, author reply.
  • P3, poster src did not prove decode: fixed in 2dff9d9 with a naturalWidth poll, author reply.
  • Nit, focus() plus keyboard.press was one trigger.press: fixed in 1973e2a, author reply.
  • P3, inline player locator wiring: fixed in e82b395 (AgentPanel.attachmentPreviewPlayer), author reply.
  • P3, controls and poster assertions already covered by the component suite: fixed in df8d66a, author reply.
  • P3, aria-expanded belonged in the unit test: fixed in afd513d, author reply. This round's nit extends it with the open half.
  • P3, stale spec header: fixed in 27a1d3a.
  • Nit, optional test.step grouping: withdrawn, because the trimmed case has four short phases.
  • P3, #20246 publishes the opposite video preview_url policy from #20157: informational, still open, carried above.
  • P3, PR description said an existing case was extended: fixed in the rewritten description.
  • P3, PR description did not link the #20157 review: fixed, it now links it.
  • Nit, PR description length: fixed in the rewritten description.

Checks at 27a1d3a:

  • oxfmt and type-aware oxlint on the three changed files: pass.
  • pnpm typecheck:browser: exit 0.
  • pnpm test:unit AttachmentChip.test.ts: 25/25.
  • playwright test --list on the spec: 4 tests.
  • Mutation: :aria-expanded="true" fails the new assertion in both rows; :aria-expanded="false" passes all 25. The suggested open-half assertion passes at head and fails both rows under the static-false mutation.
  • I did not rerun the cloud Playwright case locally. The description's ensureThumbnail mutation control is the author's.

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ready for human review. The round-two nit is fixed at 15035b2, and no findings remain open.

15035b2 asserts aria-expanded="true" once the preview dialog opens in both keyboard rows of AttachmentChip.test.ts. That is the open half I asked for, placed at the first open instead of the re-open, which works just as well. I re-ran the mutation: hard-coding :aria-expanded="false" in AssetHoverPreview.vue now fails both rows, and the restored component passes 25/25.

One small thing outside the code. The author's reply links commit 15035b2862e5..., which GitHub can't find; the real commit is 15035b2.

CI on the previous head (27a1d3a) finished green, including all 26 Playwright jobs. This head changes only the unit test, and its CI was still running at review time (23 passed, 12 in progress, none failed).

Review record

Round one: review at a2f320b. Round two: review at 27a1d3a.

  • R1 P2, removal phase could not fail (outside pointerdown dismissed the popover first): fixed in c69255a, author reply.
  • R1 P2, test title claimed cleanup: fixed in 9229a44, author reply.
  • R1 P3, hand-copied Preview {name} template in the trigger query: fixed in d47e90b, author reply.
  • R1 P3, poster src did not prove decode: fixed in 2dff9d9, author reply.
  • R1 Nit, focus() plus keyboard.press was one trigger.press: fixed in 1973e2a, author reply.
  • R1 P3, inline player locator wiring: fixed in e82b395, author reply.
  • R1 P3, controls and poster assertions already covered by the component suite: fixed in df8d66a, author reply.
  • R1 P3, aria-expanded belonged in the unit test: fixed in afd513d, author reply.
  • R1 P3, stale spec header: fixed in 27a1d3a.
  • R1 Nit, optional test.step grouping: withdrawn in round two, because the trimmed case has four short phases.
  • R1 P3, #20246 publishes the opposite video preview_url policy from #20157: informational for whoever merges those two. #20246 is still open; if that conflict resolves toward it, this case goes red at the poster assertion, which is the guard working.
  • R1 P3, PR description said an existing case was extended: fixed in the rewritten description.
  • R1 P3, PR description did not link the #20157 review: fixed.
  • R1 Nit, PR description length: fixed.
  • R2 Nit, unit row asserted only the closed half of aria-expanded: fixed in 15035b2, author reply.

Checks at 15035b2:

  • oxfmt and type-aware oxlint on AttachmentChip.test.ts: pass.
  • pnpm test:unit AttachmentChip.test.ts: 25/25.
  • Mutation: :aria-expanded="false" fails both keyboard rows.
  • The browser spec and AgentPanel.ts are unchanged since 27a1d3a. At that head: typecheck:browser exit 0, playwright test --list showed 4 tests, and CI's cloud Playwright jobs passed.

@DrJKL
DrJKL merged commit 99e461c into codex/agent-asset-media-previews Oct 7, 2026
127 checks passed
@DrJKL
DrJKL deleted the christian-byrne/op514-fe20157-blackbox branch October 7, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants