Skip to content

feat(agent): add shared media thumbnails and hover playback - #20157

Merged
christian-byrne merged 8 commits into
codex/agent-asset-tray-upgradefrom
codex/agent-asset-media-previews
Oct 7, 2026
Merged

christian-byrne merged 8 commits into
codex/agent-asset-tray-upgradefrom
codex/agent-asset-media-previews

Conversation

@ryan-di

@ryan-di ryan-di commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Make attached video and audio usable throughout the asset tray and prompt, with consistent indicators and playback available from the tray.

Changes

  • Video previews across all three surfaces. Videos show the same thumbnail in the tray, @ menu and inline chips. While a thumbnail is unavailable, each surface shows a video icon. Existing server thumbnails appear immediately; generated thumbnails are reused across repeated references.
  • Recognizable audio assets. Audio uses the music icon in the tray, @ menu and inline chips, including files whose display names no longer contain an audio extension.
  • Playable tray hover previews. Hovering a video or audio asset opens native playback controls, with no autoplay. Closing the preview, replacing its source or removing the asset stops playback. Audio controls have spacing around the card's corners, and media surfaces follow the active theme. Inline hover continues to highlight the tray without opening a player.
  • Media stays usable after upload and drag/drop. Uploaded files and assets dragged from the in-app library keep their media type, playable source and thumbnail through inline insertion and Undo. A video thumbnail is distinct from the video used for playback.
  • Shared thumbnails without blocking typing or Send. Repeated mentions reuse one generated thumbnail. Thumbnail generation doesn't count as an upload or disable Send. Failed sends retain a completed thumbnail for the recovered asset; successful sends and removal release unused resources. Obsolete thumbnail work is cancelled when its asset or source changes.

Review Focus

Check upload/library metadata, thumbnail reuse across all three surfaces, playback stopping when the hover preview closes, and resource cleanup during cancellation or send recovery. A thumbnail failure leaves the type icon available.

Validation: 434 affected media/panel tests pass; the 39 media fixture cases also pass in shuffled single-worker runs. Earlier media regressions demonstrated failing without the implementation and real drag-producer wiring. Normal commit/push checks pass. Native browser decoding, playback and visual verification were not rerun locally in this pass.

Stacked on #20156 (codex/agent-asset-tray-upgrade). Merge the core PR first; this PR adds the media behavior above to its asset tray and independent inline references.

Linear tracking

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 3e4fc765-b0f9-420c-abcd-1b619bd645e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/07/2026, 09:26:49 PM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 6181b6dd0ffe775369788446618732e210da494b

Full docs: ADR-DEVEX-LINT-0015

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
dom-widget-order-dense-n200-w200-i120: · 36.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 325ms TBT · 92.2 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 47.4 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 103ms TBT · 86.2 MB heap
extension-clean-combined-draw: · 43.8 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 17ms TBT · 83.5 MB heap
extension-rgthree-prototype-draw: · 43.3 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 44ms TBT · 89.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
large-graph-zoom: · 59.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
legacy-node-drag: · 59.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.0 MB heap
subgraph-transition-enter: · 53.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 80ms TBT · 102.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.9 MB heap
vue-large-graph-idle: · 42.8 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 175.9 MB heap
vue-large-graph-pan: · 35.2 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 3ms TBT · 182.0 MB heap
vue-node-resize-workload: · 32.6 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 6ms TBT · 215.8 MB heap
vue-zoom-out-idle: · 41.7 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 178.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.1 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.6 MB heap
agent-composer-long-conversation-typing: · 59.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 117.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 372ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.6 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 17ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 71
canvas-mouse-sweep: task duration 646ms
canvas-mouse-sweep: script duration 128ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.8 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 7ms
canvas-zoom-sweep: layout count 3
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 297ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 60.8 MB
canvas-zoom-sweep: DOM nodes 45
canvas-zoom-sweep: event listeners 39
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 354ms
dom-widget-clipping: script duration 123ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 73.4 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 28ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 607ms
dom-widget-order-dense-n200-w200-i120: script duration 43ms
dom-widget-order-dense-n200-w200-i120: TBT 325ms
dom-widget-order-dense-n200-w200-i120: heap used 92.2 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 21ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 331ms
dom-widget-order-sparse-n1000-w20-i120: script duration 113ms
dom-widget-order-sparse-n1000-w20-i120: TBT 103ms
dom-widget-order-sparse-n1000-w20-i120: heap used 86.2 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 23ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 4
extension-clean-combined-draw: task duration 5626ms
extension-clean-combined-draw: script duration 4350ms
extension-clean-combined-draw: TBT 17ms
extension-clean-combined-draw: heap used 83.5 MB
extension-clean-combined-draw: DOM nodes -141
extension-clean-combined-draw: event listeners -65
extension-rgthree-prototype-draw: avg frame time 23ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 4
extension-rgthree-prototype-draw: task duration 5545ms
extension-rgthree-prototype-draw: script duration 4289ms
extension-rgthree-prototype-draw: TBT 44ms
extension-rgthree-prototype-draw: heap used 89.9 MB
extension-rgthree-prototype-draw: DOM nodes -141
extension-rgthree-prototype-draw: event listeners -56
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 450ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 77.1 MB
large-graph-idle: DOM nodes 0
large-graph-idle: event listeners 0
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1300ms
large-graph-pan: script duration 661ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 75.9 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 19ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1336ms
large-graph-zoom: script duration 599ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.4 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 48
legacy-node-drag: task duration 1554ms
legacy-node-drag: script duration 811ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 446ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.6 MB
minimap-idle: DOM nodes -154
minimap-idle: event listeners -74
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 319ms
subgraph-dom-widget-clipping: script duration 107ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 65.2 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 375ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 75.6 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 17ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 635ms
subgraph-mouse-sweep: script duration 101ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.0 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 21ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 734ms
subgraph-transition-enter: script duration 26ms
subgraph-transition-enter: TBT 80ms
subgraph-transition-enter: heap used 102.3 MB
subgraph-transition-enter: DOM nodes 14570
subgraph-transition-enter: event listeners 2458
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 27ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4567ms
viewport-pan-sweep: script duration 2196ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 77.9 MB
viewport-pan-sweep: DOM nodes 0
viewport-pan-sweep: event listeners 0
vue-large-graph-idle: avg frame time 23ms
vue-large-graph-idle: p95 frame time 50ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12991ms
vue-large-graph-idle: script duration 208ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 175.9 MB
vue-large-graph-idle: DOM nodes -3046
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 28ms
vue-large-graph-pan: p95 frame time 67ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 12ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 88
vue-large-graph-pan: task duration 15275ms
vue-large-graph-pan: script duration 671ms
vue-large-graph-pan: TBT 3ms
vue-large-graph-pan: heap used 182.0 MB
vue-large-graph-pan: DOM nodes -3046
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 31ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 52ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5008ms
vue-node-resize-workload: script duration 86ms
vue-node-resize-workload: TBT 6ms
vue-node-resize-workload: heap used 215.8 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 24ms
vue-zoom-out-idle: p95 frame time 42ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6737ms
vue-zoom-out-idle: script duration 111ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 178.3 MB
vue-zoom-out-idle: DOM nodes -3046
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 12ms
workflow-execution: layout count 4
workflow-execution: style recalc count 10
workflow-execution: task duration 87ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 57.1 MB
workflow-execution: DOM nodes 113
workflow-execution: event listeners 49
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 33ms
agent-composer-empty-conversation-typing: style recalc duration 102ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 77
agent-composer-empty-conversation-typing: task duration 686ms
agent-composer-empty-conversation-typing: script duration 235ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 78.6 MB
agent-composer-empty-conversation-typing: DOM nodes 77
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 34ms
agent-composer-long-conversation-typing: style recalc duration 361ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 77
agent-composer-long-conversation-typing: task duration 1334ms
agent-composer-long-conversation-typing: script duration 351ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 117.2 MB
agent-composer-long-conversation-typing: DOM nodes 77
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-07T21:36:12.692Z",
  "gitSha": "279f0eac6d1a89498bb1ccd95eaf66b56f4936f1",
  "branch": "codex/agent-asset-media-previews",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2008.7919999999713,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.549,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.619,
      "heapDeltaBytes": 3594268,
      "heapUsedBytes": 66337824,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.889000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2009.947000000011,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.7339999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 380.68800000000005,
      "heapDeltaBytes": 2944376,
      "heapUsedBytes": 62832448,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.873000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760334,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1674.9409999999898,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 16.877000000000002,
      "layouts": 12,
      "layoutDurationMs": 4.992,
      "taskDurationMs": 649.2719999999999,
      "heapDeltaBytes": -715364,
      "heapUsedBytes": 59667196,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 127.94599999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665346534653462,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1674.3730000000596,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 16.833000000000002,
      "layouts": 12,
      "layoutDurationMs": 5.1659999999999995,
      "taskDurationMs": 643.5120000000001,
      "heapDeltaBytes": 3348776,
      "heapUsedBytes": 71974724,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 127.09100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663363,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1711.2319999999954,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 6.921999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.9720000000000002,
      "taskDurationMs": 284.39,
      "heapDeltaBytes": 5619212,
      "heapUsedBytes": 68157644,
      "domNodes": 45,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.796000000000001,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.5649999999605,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 6.377000000000001,
      "layouts": 3,
      "layoutDurationMs": 1.065,
      "taskDurationMs": 310.01099999999997,
      "heapDeltaBytes": 4472592,
      "heapUsedBytes": 59281348,
      "domNodes": 45,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.723,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846153,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 534.0669999999932,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 4.215,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 347.603,
      "heapDeltaBytes": 16710320,
      "heapUsedBytes": 76511908,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 120.487,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 533.0290000000559,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 4.401000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 360.661,
      "heapDeltaBytes": 17318848,
      "heapUsedBytes": 77404500,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 124.831,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1000.6999999999948,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 660.1450000000001,
      "heapDeltaBytes": 12924848,
      "heapUsedBytes": 96553140,
      "domNodes": 0,
      "jsHeapTotalBytes": 2260992,
      "scriptDurationMs": 48.327,
      "eventListeners": 0,
      "totalBlockingTimeMs": 356,
      "frameDurationMs": 28.56857142857143,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 911.0339999999724,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 553.3809999999999,
      "heapDeltaBytes": 17221496,
      "heapUsedBytes": 96826944,
      "domNodes": 0,
      "jsHeapTotalBytes": 3833856,
      "scriptDurationMs": 38.149,
      "eventListeners": 0,
      "totalBlockingTimeMs": 293,
      "frameDurationMs": 26.958823529411774,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 717.8269999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 324.08400000000006,
      "heapDeltaBytes": -13261496,
      "heapUsedBytes": 82351980,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 110.73700000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 102,
      "frameDurationMs": 21.073529411764707,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 719.7959999999739,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 336.9519999999997,
      "heapDeltaBytes": 19733480,
      "heapUsedBytes": 98510432,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 114.779,
      "eventListeners": 0,
      "totalBlockingTimeMs": 104,
      "frameDurationMs": 21.079411764705878,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6729.408999999976,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.1459999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5733.267,
      "heapDeltaBytes": 9800088,
      "heapUsedBytes": 80530608,
      "domNodes": -141,
      "jsHeapTotalBytes": -9310208,
      "scriptDurationMs": 4423.397,
      "eventListeners": -65,
      "totalBlockingTimeMs": 28,
      "frameDurationMs": 23.137457044673535,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6515.3730000000105,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.491000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5518.052,
      "heapDeltaBytes": 25258144,
      "heapUsedBytes": 94540564,
      "domNodes": -141,
      "jsHeapTotalBytes": -9572352,
      "scriptDurationMs": 4277.019,
      "eventListeners": -65,
      "totalBlockingTimeMs": 6,
      "frameDurationMs": 22.548096885813152,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6589.967999999999,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.424,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5578.057,
      "heapDeltaBytes": 24557252,
      "heapUsedBytes": 94765424,
      "domNodes": -141,
      "jsHeapTotalBytes": -8785920,
      "scriptDurationMs": 4327.7390000000005,
      "eventListeners": -47,
      "totalBlockingTimeMs": 40,
      "frameDurationMs": 22.2402027027027,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6385.998000000029,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.0760000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5511.2699999999995,
      "heapDeltaBytes": 22751896,
      "heapUsedBytes": 93694864,
      "domNodes": -141,
      "jsHeapTotalBytes": -11669504,
      "scriptDurationMs": 4249.7119999999995,
      "eventListeners": -65,
      "totalBlockingTimeMs": 47,
      "frameDurationMs": 23.996992481203005,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.899000000034,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.8060000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.43499999999995,
      "heapDeltaBytes": -2817388,
      "heapUsedBytes": 87050620,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 38.992,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666664,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2006.4760000000206,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.8659999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 429.6700000000001,
      "heapDeltaBytes": -5103504,
      "heapUsedBytes": 74597892,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 33.013,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3002.5170000000116,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 9.208,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1312.1670000000001,
      "heapDeltaBytes": -11043588,
      "heapUsedBytes": 70161416,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 678.3600000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611111111111,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2939.8230000000467,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 9.190999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1287.692,
      "heapDeltaBytes": -1770156,
      "heapUsedBytes": 89103484,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 643.119,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666477272727267,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3662.111999999979,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 11.077000000000002,
      "layouts": 60,
      "layoutDurationMs": 18.793,
      "taskDurationMs": 1331.437,
      "heapDeltaBytes": 9007292,
      "heapUsedBytes": 78394188,
      "domNodes": 24,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 604.073,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66590909090909,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3857.984999999985,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 9.888,
      "layouts": 60,
      "layoutDurationMs": 19.165,
      "taskDurationMs": 1341.3650000000002,
      "heapDeltaBytes": 8593048,
      "heapUsedBytes": 73499976,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 593.168,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.73766233766234,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2925.5279999999857,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.8149999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1516.743,
      "heapDeltaBytes": -7076044,
      "heapUsedBytes": 71864856,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 787.2969999999999,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.761714285714287,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3034.3480000000227,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 7.507,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1592.082,
      "heapDeltaBytes": 25872984,
      "heapUsedBytes": 95256172,
      "domNodes": 0,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 834.317,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666483516483513,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.5199999999668,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.2949999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.056,
      "heapDeltaBytes": -1995772,
      "heapUsedBytes": 89274676,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 34.32,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.2779999999293,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.1009999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.695,
      "heapDeltaBytes": -23554188,
      "heapUsedBytes": 81860480,
      "domNodes": -308,
      "jsHeapTotalBytes": -3543040,
      "scriptDurationMs": 31.91700000000001,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 497.7880000000141,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 6.9769999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 319.69,
      "heapDeltaBytes": -9940304,
      "heapUsedBytes": 60791904,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 107.443,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 514.6760000000086,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.464,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 317.552,
      "heapDeltaBytes": 11846092,
      "heapUsedBytes": 76023764,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 107.084,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664516129032254,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.348999999986,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.177999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.692,
      "heapDeltaBytes": 8082708,
      "heapUsedBytes": 79752676,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.139,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.996999999932,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.692000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 379.72700000000003,
      "heapDeltaBytes": 8001276,
      "heapUsedBytes": 78872808,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.645000000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1674.0929999999707,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 18.265,
      "layouts": 16,
      "layoutDurationMs": 6.340999999999999,
      "taskDurationMs": 656.184,
      "heapDeltaBytes": 21200452,
      "heapUsedBytes": 76423128,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 103.897,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663366,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1677.0390000000361,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 16.411999999999995,
      "layouts": 16,
      "layoutDurationMs": 5.647,
      "taskDurationMs": 613.4879999999999,
      "heapDeltaBytes": -4288916,
      "heapUsedBytes": 59886956,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 97.43599999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665346534653462,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1033.2619999999793,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 21.475999999999996,
      "layouts": 5,
      "layoutDurationMs": 10.014999999999999,
      "taskDurationMs": 733.7740000000001,
      "heapDeltaBytes": 32243296,
      "heapUsedBytes": 107242120,
      "domNodes": 14570,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 26.049000000000003,
      "eventListeners": 2458,
      "totalBlockingTimeMs": 80,
      "frameDurationMs": 18.75,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10377.92300000001,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 26.304999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4528.104,
      "heapDeltaBytes": -16853436,
      "heapUsedBytes": 72333208,
      "domNodes": 0,
      "jsHeapTotalBytes": 1347584,
      "scriptDurationMs": 2157.469,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66581059390048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10693.34200000003,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 27.962,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4606.8369999999995,
      "heapDeltaBytes": 16282352,
      "heapUsedBytes": 91128448,
      "domNodes": 0,
      "jsHeapTotalBytes": 1503232,
      "scriptDurationMs": 2233.715,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666043613707163,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13798.005999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13153.683999999997,
      "heapDeltaBytes": -33420552,
      "heapUsedBytes": 183671988,
      "domNodes": -3046,
      "jsHeapTotalBytes": 8671232,
      "scriptDurationMs": 209.851,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.52013651877133,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13559.987000000092,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12828.12,
      "heapDeltaBytes": -36250872,
      "heapUsedBytes": 185192808,
      "domNodes": -3046,
      "jsHeapTotalBytes": 10571776,
      "scriptDurationMs": 205.92599999999996,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.189914529914528,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16113.854000000003,
      "styleRecalcs": 98,
      "styleRecalcDurationMs": 13.093999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15633.917,
      "heapDeltaBytes": -33080912,
      "heapUsedBytes": 189644824,
      "domNodes": -3046,
      "jsHeapTotalBytes": 8077312,
      "scriptDurationMs": 680.821,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 29.469708029197083,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15360.813000000007,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 10.05800000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14915.089000000002,
      "heapDeltaBytes": -10767808,
      "heapUsedBytes": 192112344,
      "domNodes": -3046,
      "jsHeapTotalBytes": 6914048,
      "scriptDurationMs": 661.755,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 27.32291296625222,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5165.847999999983,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 52.14000000000002,
      "layouts": 20,
      "layoutDurationMs": 27.407,
      "taskDurationMs": 5047.34,
      "heapDeltaBytes": 6356916,
      "heapUsedBytes": 230143868,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 88.418,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.21345029239766,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5043.724999999995,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 51.153000000000006,
      "layouts": 20,
      "layoutDurationMs": 26.74,
      "taskDurationMs": 4968.085999999999,
      "heapDeltaBytes": -7273928,
      "heapUsedBytes": 222363132,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 84.262,
      "eventListeners": 0,
      "totalBlockingTimeMs": 12,
      "frameDurationMs": 31.171604938271606,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6681.42499999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6427.212999999998,
      "heapDeltaBytes": -28565016,
      "heapUsedBytes": 183846776,
      "domNodes": -3046,
      "jsHeapTotalBytes": 8671232,
      "scriptDurationMs": 104.738,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 22.886986301369863,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7441.90900000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7046.930999999999,
      "heapDeltaBytes": -18573364,
      "heapUsedBytes": 189983500,
      "domNodes": -3046,
      "jsHeapTotalBytes": 14962688,
      "scriptDurationMs": 117.96200000000002,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.11182432432432,
      "p95FrameDurationMs": 50
    },
    {
      "name": "workflow-execution",
      "durationMs": 108.67899999999509,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 11.279,
      "layouts": 4,
      "layoutDurationMs": 2.162,
      "taskDurationMs": 73.19200000000001,
      "heapDeltaBytes": 4199680,
      "heapUsedBytes": 58873216,
      "domNodes": 121,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.513000000000002,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.671428571428546,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 442.5430000000006,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 13.181000000000001,
      "layouts": 3,
      "layoutDurationMs": 1.036,
      "taskDurationMs": 99.86900000000001,
      "heapDeltaBytes": 6114568,
      "heapUsedBytes": 60907500,
      "domNodes": 105,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.580000000000002,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670370370370367,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 747.524999999996,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 104.087,
      "layouts": 76,
      "layoutDurationMs": 33.831,
      "taskDurationMs": 713.167,
      "heapDeltaBytes": 16594040,
      "heapUsedBytes": 82023736,
      "domNodes": 77,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 245.77599999999998,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665217391304356,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 681.6769999999224,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 98.982,
      "layouts": 76,
      "layoutDurationMs": 32.648,
      "taskDurationMs": 658.054,
      "heapDeltaBytes": 16292912,
      "heapUsedBytes": 82755652,
      "domNodes": 77,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 224.041,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536566,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1345.2069999999594,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 367.31,
      "layouts": 76,
      "layoutDurationMs": 34.074,
      "taskDurationMs": 1333.1770000000001,
      "heapDeltaBytes": 10454412,
      "heapUsedBytes": 116080956,
      "domNodes": 77,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 350.273,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.87249999999999,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1357.6400000000604,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 355.03000000000003,
      "layouts": 76,
      "layoutDurationMs": 34.346000000000004,
      "taskDurationMs": 1335.763,
      "heapDeltaBytes": 14204608,
      "heapUsedBytes": 129626120,
      "domNodes": 77,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 351.674,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.873749999999994,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 54486 84194 64.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.8% 1167
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.8% 369
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 79.0% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 39.3% 258
src/scripts/app.ts 73.0% 255
src/core/webSessionIdentity.ts 3.3% 231
src/scripts/pnginfo.ts 20.7% 222

🎭 Playwright: ✅ 2237 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2215 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 5, 2026
@ryan-di
ryan-di force-pushed the codex/agent-asset-media-previews branch 5 times, most recently from b2cabae to 82c283a Compare October 5, 2026 07:23
@ryan-di
ryan-di force-pushed the codex/agent-asset-media-previews branch from 82c283a to ad7455d Compare October 5, 2026 07:26
@ryan-di
ryan-di marked this pull request as ready for review October 5, 2026 07:33
@ryan-di
ryan-di requested a review from a team October 5, 2026 07:35
@ryan-di ryan-di added preview-gpu Creates a preview ephemeral environment for this PR (GPU available) retain-preview Keep the ephemeral preview environment from being torn down for inactivity labels Oct 5, 2026 — with ChatGPT Codex Connector

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The media preview path has blocking accessibility, URL resolution, and resource-lifecycle regressions. Details are inline.

const posterUrl = asset.preview_id
? previewUrl
: asset.thumbnail_url && asset.thumbnail_url !== asset.preview_url
? URL.parse(api.apiURL(asset.thumbnail_url), location.href)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: thumbnail_url can already be an absolute CDN URL, but api.apiURL() prefixes every value not starting with /api. A value like https://cdn.example/thumb.webp becomes /apihttps://...; the composer then stores a broken poster and skips local generation because previewUrl is non-empty. Please preserve absolute URLs and only apply the API base to relative backend routes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c9869913: absolute and protocol-relative thumbnail URLs are preserved; only relative backend routes get the API base. Drag/drop regression tests pass for all three forms.

}
if (thumbnailJobs.get(id)?.source === mediaUrl) return
cancelThumbnail(id)
const job = { source: mediaUrl, controller: new AbortController() }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This new job can outlive submission invalidation. startSubmission() clears attachmentIds, while invalidateSubmission() only nulls the snapshot; the old settleSubmission() then returns before releaseUnusedAssets(). Switching chats during a pending video send can therefore retain the hidden asset, poster blob, and decoder job in the long-lived store. Please release no-longer-retained snapshot assets, including job cancellation, when invalidating.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in core e27178bc, included here: invalidation releases unretained assets and cancels their decoder jobs. Tests cover interrupted/repeated sends, stale completions, and retained draft assets.

:role="mediaUrl && playableKind ? 'region' : 'tooltip'"
:aria-label="name"
>
<AssetMediaPreview

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Reka's HoverCardContent removes all tabbable descendants from the tab order (tabindex="-1"), and this chip trigger is a non-focusable group. As a result, keyboard users cannot open or operate these native controls. Please use a focus/click-capable popover/dialog or explicit playback button; hover can remain an enhancement.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c9869913 with a focusable playback button and nonmodal popover. Component tests pass for Enter/Space, control focus, Escape focus return, and hover preserving typing focus.

<span class="flex items-center justify-center">
<img
v-if="previewUrl && kind === 'image'"
v-if="previewUrl && (kind === 'image' || kind === 'video')"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: (non-blocking) Once a video poster URL is non-empty, this always renders <img> and has no error fallback. A 404, expired, or revoked poster leaves broken-image UI across tray, menu, and inline surfaces instead of the video icon. Could the component track image load failure for the current URL and fall back to the media icon?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c9869913: failed posters fall back to the media icon. Tests cover all three surfaces, replacement URLs, and stale image errors.

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.15612% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/assets/utils/assetDragUtil.ts 95.65% 1 Missing ⚠️
...workbench/extensions/agent/utils/videoThumbnail.ts 97.56% 1 Missing ⚠️
@@                        Coverage Diff                         @@
##           codex/agent-asset-tray-upgrade   #20157      +/-   ##
==================================================================
- Coverage                           86.31%   86.25%   -0.06%     
==================================================================
  Files                                2495     2497       +2     
  Lines                              141620   141822     +202     
  Branches                            39002    37063    -1939     
==================================================================
+ Hits                               122236   122329      +93     
- Misses                              19003    19112     +109     
  Partials                              381      381              
Flag Coverage Δ
e2e 64.68% <72.72%> (-0.07%) ⬇️
unit 83.68% <99.57%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/assets/schemas/mediaAssetSchema.ts 100.00% <100.00%> (ø)
src/utils/eventUtils.ts 100.00% <ø> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 95.19% <ø> (ø)
...nt/components/agent/composer/AssetHoverPreview.vue 100.00% <100.00%> (ø)
...nt/components/agent/composer/AssetMediaPreview.vue 100.00% <100.00%> (ø)
...agent/components/agent/composer/AssetThumbnail.vue 100.00% <100.00%> (ø)
...ions/agent/components/agent/composer/AssetTray.vue 100.00% <ø> (ø)
...agent/components/agent/composer/AttachmentChip.vue 100.00% <100.00%> (ø)
...components/agent/composer/InlineAssetReference.vue 100.00% <ø> (ø)
...t/components/agent/composer/InlinePromptEditor.vue 97.77% <ø> (ø)
... and 6 more

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryan-di
ryan-di requested review from a team as code owners October 7, 2026 00:50

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for one verified blocker at exact head 7eaa8684021572f7a61bad2616639001216e7546.

The previous findings are fixed at this head: F1 now preserves absolute/protocol-relative poster URLs and prefixes only relative routes; F2 invalidation clears the held snapshot, then releases unretained assets and aborts their thumbnail jobs; F3 uses a focusable button plus nonmodal popover, with Enter/Space, native-control focus, Escape return, and hover-without-focus-steal coverage. The F4 broken-poster fallback is also present.

Blocker — the new user-visible media path has no black-box harness test. This PR changes 32 files / 1,795 lines but changes no browser_tests/ spec or recorded conversation. The existing browser_tests/tests/agent/agentComposerAssetDrop.spec.ts already routes a real MP4, but it stops after asserting that the chip is visible; it never opens playback or checks the poster, native controls, keyboard focus, Escape/close behavior, or cleanup. Those behaviors depend on real-browser media/CORS/canvas/focus semantics that the happy-dom tests mock or emulate. The repository’s harness-first contract requires at least one user-visible black-box case for every Agent PR. Please extend that MP4 case (or add an equivalent recorded/Playwright case) to exercise the media preview from the user surface and prove it red on the base and green here.

Evidence: all 13 changed Vitest suites pass locally at this exact head (570 tests, --retry=0); git diff --check passes; live GitHub state is MERGEABLE/CLEAN with 105 passing and 19 skipped checks. The missing browser assertion is the remaining reason I cannot approve.

role="region"
:aria-label="t('assetBrowser.assets')"
class="relative max-w-full min-w-0 shrink-0 overflow-hidden rounded-t-lg"
class="relative max-w-full min-w-0 overflow-hidden rounded-t-lg"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): This unrelated removal makes the overflow-hidden tray a shrinkable child of the composer’s capped flex column, so a tall prompt or short viewport can compress and clip the 80px media cards. The prior shrink-0 made the prompt scroller absorb that pressure. Please restore it unless the shrink is intentional; if intentional, the black-box case should assert a full tray card remains visible at the constrained height.

@christian-byrne

Copy link
Copy Markdown
Contributor

The requested test-only companion is #20404, targeting this carrier branch. It extends the existing real-MP4 composer-drag spec with browser assertions for the generated poster, keyboard activation, native video controls/focus, Escape focus restoration, and cleanup when the attachment is removed.

Regression proof: the existing grid-drag control passes at base 6181b6dd0ffe775369788446618732e210da494b, while the new case fails there at its first preview-trigger/poster assertion; the identical case passes at carrier head 7eaa8684021572f7a61bad2616639001216e7546 plus test commit a2f320beec (4.3s). Browser typecheck, type-aware lint, format, diff check, and push hooks pass.

I am leaving the changes-requested verdict in place until #20404 lands. After it merges, re-review #20157 at the resulting exact head.

## Summary

Adds a Playwright case to `agentComposerAssetDrop.spec.ts`, as requested
in the [#20157
review](#20157 (review)).
It drops the real MP4 asset on the composer and checks that the chip
poster is a decoded `blob:` image, Enter opens the visible native video
with focus, and Escape closes it and returns focus to the chip.
Test-only, targeting the #20157 branch.

## Verification

- Mutation control: deleting the `ensureThumbnail(attachment)` call made
the case fail at the visible poster assertion; restoring it passed 5/5.
- Focused cloud Playwright case: 5/5 passed; whole spec: 4/4 passed.
- `AttachmentChip.test.ts`: 25/25 passed.
- Targeted eslint, type-aware oxlint, oxfmt, browser/app typechecks,
knip, and fallow passed.
- ARIA mutation control: hard-coding the trigger to
`aria-expanded="false"` failed both keyboard-open rows; restoring the
binding passed 25/25.
@christian-byrne
christian-byrne dismissed their stale review October 7, 2026 21:47

Satisfied at exact head 99e461c. #20404 added the requested non-vacuous browser proof. Independent re-review confirmed F1-F4 remain fixed, all 13 changed unit/component suites pass (570/570), the focused Cloud browser case passes 5/5, and removing only ensureThumbnail(attachment) makes that case fail at the first poster assertion. Hosted CI completed with 108 pass, 16 intentional skips, and no pending/failing checks. Submitting a current-head approval.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head 99e461c6d2b012978babc9241235ad434d3e956e after re-reading the complete live diff, all five review threads, and the 7eaa8684…99e461c6 proof delta.

F1-F3 remain fixed: absolute/protocol-relative poster URLs are preserved; invalidation releases unretained media and cancels stale thumbnail work; and playable media uses a focusable trigger plus nonmodal playback with Escape focus return. F4 fallback remains covered. The earlier tray shrink-0 note remains non-blocking.

The added browser case is substantive: it requires a decoded nonzero-width blob: poster, opens native playback by keyboard with focus, and closes on Escape with focus restored. Removing only ensureThumbnail(attachment) failed at the first poster assertion; restoring it passed 5/5. The component suite asserts aria-expanded=true while open and false after Escape. The companion delta removed the vacuous attachment-removal phase, so no absence-only assertion stands in for cleanup.

Local evidence: 13 changed unit/component files, 570/570 passing; focused Cloud Playwright 5/5; git diff --check clean. Hosted evidence: 108 checks passed, 16 intentionally skipped, zero pending/failing; GitHub reports MERGEABLE/CLEAN. No blocking finding remains.

@christian-byrne
christian-byrne merged commit bd77fdf into codex/agent-asset-tray-upgrade Oct 7, 2026
125 checks passed
@christian-byrne
christian-byrne deleted the codex/agent-asset-media-previews branch October 7, 2026 22:06
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 8, 2026
…mfy-Org#20156)

## Summary

Separate attached assets from inline references so users can build a
prompt naturally while keeping their files in a visible asset tray.

## Changes

- **A separate asset tray.** Added assets appear above the prompt as
thumbnails or type icons, with transparent backgrounds and no borders.
Filenames appear on hover. The circular × appears on hover or keyboard
focus, and stays visible on touch devices. The extra node-reference row
is removed.
- **Assets referenced inline with `@`.** Users can search by asset name
and select with the mouse or keyboard to insert at the caret. The same
asset can be referenced unlimited times. Assets sit alongside the
existing node and workflow options.
- **Consistent, compact inline chips.** Asset, node and workflow chips
share the same appearance and removal interaction, with no left/right
padding. Chips fit within the compact composer line height. Removing a
chip deletes only that occurrence, supports Undo and returns focus for
continued typing.
- **Different hover behavior for tray and inline.** Tray hover shows the
filename and a large image or media preview. Click, keyboard and touch
can open an interactive preview. Activating another asset replaces the
current preview, so only one stays open. Inline hover/focus highlights
the corresponding tray asset without opening a preview, so inserting a
chip beneath the pointer doesn't interrupt typing.
- **Video and audio support.** Videos share one thumbnail across the
tray, `@` menu and inline chips. Audio uses the music icon throughout,
including renamed files. Tray previews provide native playback controls
with no autoplay. Closing, replacing or removing a preview stops and
resets playback, including quick close/reopen. Audio controls are inset
within the card’s corners.
- **Discoverable tray scrolling.** Many assets stay in one horizontally
scrollable row at a consistent size. Arrows and edge fades indicate
additional content. Controls reflect scroll boundaries and update as
assets or panel width change.
- **The whole chat panel accepts drops.** Users can drop supported files
or drag assets from the in-app library anywhere in the panel. Drop
feedback covers the panel while preserving composer layout and input.
Library drops work for unnamed assets and re-additions after removal or
sending; already included library assets remain deduplicated.
- **Duplicate additions stay clear.** Adding an included file or library
asset again keeps one tray item and shows a brief filename notice; a
batch reports the number skipped while unique files continue uploading.
Removing an asset and adding it again is allowed, and repeated inline
mentions remain unlimited.
- **Stable composer sizing.** Production-style compact text spacing is
retained. Inline chips don't expand the line height. Starting to type
doesn't shrink the composer when its placeholder wraps onto multiple
lines.
- **Clear attachment and removal rules.** Adding an asset doesn't
automatically mention it. Removing an inline occurrence keeps the asset
in the tray; removing the tray asset removes all its mentions. Sending
includes each tray asset once, even when unmentioned or referenced
repeatedly. Asset-only messages work. Failed sends restore an untouched
draft; newer input takes priority.
- **Visible upload feedback.** Pending-upload status stays visible
outside the horizontally scrolling tray. Users can see why Send is
unavailable, and pressing Enter preserves their draft while uploads are
pending.
- **Theme-aware styling and fresh node references.** Asset surfaces,
previews, highlights and controls follow the active theme. The `@` node
list follows the eligible viewed graph as nodes are added, renamed or
removed, and updates when switching graphs without another keystroke.

## Review Focus

Check the distinction between tray inclusion and inline occurrences,
draft recovery after a failed send, and preview cleanup after removal,
replacement or successful sending. Preserve the bulk-layout/action
guarantees from Comfy-Org#20110 and the upload-feedback behavior overlapping
Comfy-Org#20150/Comfy-Org#20152.

Validation: 553 tests pass across ten focused unit/component suites
after merging latest main. All 14 focused Chromium browser regressions
pass with retries disabled: exclusive previews, native media
close/reopen and replacement, single/plural duplicate notices, mixed
pending batches, grid/list null-name library re-addition, touch
disclosure/removal, node rename/delete/undo freshness, shared posters
and short-panel geometry. Touch was emulated; physical devices were not
exercised. Normal commit and Knip/Fallow push gates pass without added
suppressions or baseline changes. Remote CI is pending for this update.

Comfy-Org#20157 was squash-merged into this branch; its media work is included in
this PR. File deduplication uses browser file metadata (name, size,
lastModified and MIME type); library additions use stable source
identity. It does not hash local file bytes or retroactively remove
duplicates from an already-open draft.

## Linear tracking

- Upgrade and full related-ticket map:
[FE-3219](https://linear.app/comfyorg/issue/FE-3219/agent-composer-asset-tray-with-independent-inline-references).
- Fixes tracked within this PR:
[FE-3220](https://linear.app/comfyorg/issue/FE-3220/fix-stale-node-candidates-in-the-agent-picker)
(stale `@` node candidates) and
[FE-3221](https://linear.app/comfyorg/issue/FE-3221/fix-unnamed-and-re-added-library-asset-drops-into-agent-chat)
(unnamed/re-added library drops).
- QA:
[CQA-1080](https://linear.app/comfyorg/issue/CQA-1080/asset-tray-independent-inline-asset-references-in-agent-composer-20156).

Related product reports:
[PM-1230](https://linear.app/comfyorg/issue/PM-1230) /
[PM-1231](https://linear.app/comfyorg/issue/PM-1231) cover
attachment/reference confusion.
[PM-1126](https://linear.app/comfyorg/issue/PM-1126) /
[PM-1127](https://linear.app/comfyorg/issue/PM-1127) are partially
aligned: mentions become optional, but this PR uses a tray rather than
their proposed Reference-panel section.
[FE-2209](https://linear.app/comfyorg/issue/FE-2209) was reopened for
the approved composer rework and is In Review: show nodes once inline,
keep useful asset previews, and preserve sent-message rendering. This
upgrade also changes asset removal so deleting an inline occurrence
keeps the included file.

Upstream overlap: [PM-1954](https://linear.app/comfyorg/issue/PM-1954) /
[FE-3202](https://linear.app/comfyorg/issue/FE-3202) retain ownership of
bulk-layout/upload-feedback fixes (Comfy-Org#20110, Comfy-Org#20150, Comfy-Org#20152); their
guarantees are preserved here. These related links do not assert that
every older ticket is fully resolved.

Media scope from Comfy-Org#20157 is included here, with QA in
[CQA-1081](https://linear.app/comfyorg/issue/CQA-1081/shared-video-posters-and-hover-playback-for-agent-media-attachments).

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview-gpu Creates a preview ephemeral environment for this PR (GPU available) retain-preview Keep the ephemeral preview environment from being torn down for inactivity risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants