Skip to content

[backport cloud/1.54] test(agent): pin the empty canvas a displaced agent build leaves behind (PM-1535) - #20379

Merged
comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-18610-to-cloud-1.54
Oct 7, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-18610-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #18610 to cloud/1.54

Automatically created by backport workflow.

@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 7, 2026 8:20am UTC
billing-web-test Ignored Ignored Oct 7, 2026 8:20am UTC

Request Review

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1991 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1970 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 125ms TBT · 105.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.7 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 94ms TBT · 173.9 MB heap
vue-node-resize-workload: · 54.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 484ms TBT · 174.7 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 613ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 64.6 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 33ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 956ms
canvas-mouse-sweep: script duration 153ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 78.3 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -164
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 383ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 74.0 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 454ms
dom-widget-clipping: script duration 150ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 62.6 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 669ms
large-graph-idle: script duration 40ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 72.8 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1635ms
large-graph-pan: script duration 793ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 64.3 MB
large-graph-pan: DOM nodes -280
large-graph-pan: event listeners -79
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 68
large-graph-zoom: task duration 1692ms
large-graph-zoom: script duration 757ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 64.8 MB
large-graph-zoom: DOM nodes -255
large-graph-zoom: event listeners -91
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1925ms
legacy-node-drag: script duration 971ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.5 MB
legacy-node-drag: DOM nodes 4
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 631ms
minimap-idle: script duration 40ms
minimap-idle: TBT 0ms
minimap-idle: heap used 69.3 MB
minimap-idle: DOM nodes -279
minimap-idle: event listeners -193
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 404ms
subgraph-dom-widget-clipping: script duration 134ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.5 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 576ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 71.1 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 30ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 862ms
subgraph-mouse-sweep: script duration 111ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 59.6 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 998ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 125ms
subgraph-transition-enter: heap used 105.1 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 44ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5305ms
viewport-pan-sweep: script duration 2568ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 69.5 MB
viewport-pan-sweep: DOM nodes -277
viewport-pan-sweep: event listeners -162
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17296ms
vue-large-graph-idle: script duration 308ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.7 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14930
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 24ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 148
vue-large-graph-pan: task duration 21242ms
vue-large-graph-pan: script duration 950ms
vue-large-graph-pan: TBT 94ms
vue-large-graph-pan: heap used 173.9 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14929
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 73ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6368ms
vue-node-resize-workload: script duration 122ms
vue-node-resize-workload: TBT 484ms
vue-node-resize-workload: heap used 174.7 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8840ms
vue-zoom-out-idle: script duration 150ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 88ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.2 MB
workflow-execution: DOM nodes 114
workflow-execution: event listeners 51
Raw data
{
  "timestamp": "2026-10-07T08:37:31.965Z",
  "gitSha": "54c60b0ec18a00896d23c5effe4fa5e0497f1600",
  "branch": "backport-18610-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2096.6319999999996,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 9.384,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 641.673,
      "heapDeltaBytes": 7238032,
      "heapUsedBytes": 77838628,
      "domNodes": -281,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 12.815999999999997,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2071.3180000000193,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.667,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 583.8939999999999,
      "heapDeltaBytes": -15439308,
      "heapUsedBytes": 57731080,
      "domNodes": -281,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 13.947999999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1890.4129999999668,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 33.613,
      "layouts": 14,
      "layoutDurationMs": 4.623,
      "taskDurationMs": 932.188,
      "heapDeltaBytes": 9642040,
      "heapUsedBytes": 83772700,
      "domNodes": -283,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 150.785,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1924.1460000000643,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 32.624,
      "layouts": 14,
      "layoutDurationMs": 4.335,
      "taskDurationMs": 979.9890000000001,
      "heapDeltaBytes": 7063504,
      "heapUsedBytes": 80366240,
      "domNodes": -279,
      "jsHeapTotalBytes": 5013504,
      "scriptDurationMs": 155.05100000000002,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.8059999999582,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.723000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.1530000000000002,
      "taskDurationMs": 395.12800000000004,
      "heapDeltaBytes": 4935012,
      "heapUsedBytes": 78850160,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 14.498000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.7969999999905,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.997000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.132,
      "taskDurationMs": 371.62699999999995,
      "heapDeltaBytes": 4522852,
      "heapUsedBytes": 76283064,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 14.231,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 626.1549999999829,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.3980000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 440.612,
      "heapDeltaBytes": -6916008,
      "heapUsedBytes": 66402920,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 146.517,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 696.8069999999216,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.699,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 468.23799999999994,
      "heapDeltaBytes": -7051952,
      "heapUsedBytes": 64948340,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 153.12,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.9109999999896,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.111999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 703.1209999999999,
      "heapDeltaBytes": -3781664,
      "heapUsedBytes": 76637304,
      "domNodes": -268,
      "jsHeapTotalBytes": -2326528,
      "scriptDurationMs": 40.641,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2036.7200000000594,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.682000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 634.3620000000001,
      "heapDeltaBytes": -3947820,
      "heapUsedBytes": 76080332,
      "domNodes": -267,
      "jsHeapTotalBytes": -1802240,
      "scriptDurationMs": 39.53999999999999,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2257.2340000000395,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 15.245999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1712.6570000000002,
      "heapDeltaBytes": -9860208,
      "heapUsedBytes": 68098840,
      "domNodes": -285,
      "jsHeapTotalBytes": 3563520,
      "scriptDurationMs": 820.328,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2155.5150000000367,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 11.668000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1556.834,
      "heapDeltaBytes": 927076,
      "heapUsedBytes": 66749344,
      "domNodes": -275,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 766.3789999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3583.5689999999545,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 15.871,
      "layouts": 60,
      "layoutDurationMs": 14.218,
      "taskDurationMs": 1766.221,
      "heapDeltaBytes": -15420896,
      "heapUsedBytes": 67115632,
      "domNodes": -258,
      "jsHeapTotalBytes": -2588672,
      "scriptDurationMs": 779.3820000000001,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3381.4479999999776,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.146000000000003,
      "layouts": 60,
      "layoutDurationMs": 13.567,
      "taskDurationMs": 1617.857,
      "heapDeltaBytes": 1549816,
      "heapUsedBytes": 68722068,
      "domNodes": -252,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 735.063,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3081.735999999978,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 9.791,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1976.2630000000001,
      "heapDeltaBytes": 13467096,
      "heapUsedBytes": 96090100,
      "domNodes": 8,
      "jsHeapTotalBytes": 6447104,
      "scriptDurationMs": 1000.0169999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3106.490000000008,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.549999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1873.099,
      "heapDeltaBytes": 3524164,
      "heapUsedBytes": 70704100,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 942.803,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2057.829999999967,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.5,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 648.5139999999999,
      "heapDeltaBytes": -10545296,
      "heapUsedBytes": 71804840,
      "domNodes": -283,
      "jsHeapTotalBytes": -1015808,
      "scriptDurationMs": 41.715999999999994,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.8210000000463,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.182999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 613.475,
      "heapDeltaBytes": -8737076,
      "heapUsedBytes": 73497288,
      "domNodes": -275,
      "jsHeapTotalBytes": -2064384,
      "scriptDurationMs": 37.729,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 585.8929999999987,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.060999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 410.74100000000004,
      "heapDeltaBytes": 15138120,
      "heapUsedBytes": 88686100,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 133.355,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 595.1820000000225,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.703,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.54699999999997,
      "heapDeltaBytes": -10537632,
      "heapUsedBytes": 65413580,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 133.877,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.1679999999787,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.32,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 575.581,
      "heapDeltaBytes": -7093500,
      "heapUsedBytes": 65836068,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 11.486999999999998,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.0109999999831,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.286000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 576.798,
      "heapDeltaBytes": 8285316,
      "heapUsedBytes": 83363780,
      "domNodes": -295,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 13.007,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.5500000000025,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.697999999999997,
      "layouts": 18,
      "layoutDurationMs": 5.398,
      "taskDurationMs": 852.6289999999999,
      "heapDeltaBytes": -14225968,
      "heapUsedBytes": 61250656,
      "domNodes": -297,
      "jsHeapTotalBytes": 5275648,
      "scriptDurationMs": 110.15899999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1742.0080000000553,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 29.883,
      "layouts": 18,
      "layoutDurationMs": 5.378,
      "taskDurationMs": 871.6760000000002,
      "heapDeltaBytes": -9424140,
      "heapUsedBytes": 63797224,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 112.812,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.6950000000415,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 32.221000000000004,
      "layouts": 17,
      "layoutDurationMs": 15.235,
      "taskDurationMs": 997.5209999999998,
      "heapDeltaBytes": 21308340,
      "heapUsedBytes": 110200792,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 33.123,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 125,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8453.08300000005,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 43.356,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5709.990000000001,
      "heapDeltaBytes": -12623692,
      "heapUsedBytes": 67425540,
      "domNodes": -271,
      "jsHeapTotalBytes": -2588672,
      "scriptDurationMs": 2623.272,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8236.590000000091,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 44.524,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4900.312000000001,
      "heapDeltaBytes": 881256,
      "heapUsedBytes": 78288812,
      "domNodes": -283,
      "jsHeapTotalBytes": 380928,
      "scriptDurationMs": 2512.408,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17836.427999999956,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17597.765000000003,
      "heapDeltaBytes": -47135204,
      "heapUsedBytes": 182125212,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9187328,
      "scriptDurationMs": 325.383,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17165.170999999988,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16995.068,
      "heapDeltaBytes": -54501496,
      "heapUsedBytes": 175942532,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18116608,
      "scriptDurationMs": 289.672,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21731.689000000075,
      "styleRecalcs": 152,
      "styleRecalcDurationMs": 24.906999999999957,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21596.707000000002,
      "heapDeltaBytes": -36959984,
      "heapUsedBytes": 180023448,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19668992,
      "scriptDurationMs": 955.869,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 121,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20974.252999999975,
      "styleRecalcs": 143,
      "styleRecalcDurationMs": 23.58899999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20887.989,
      "heapDeltaBytes": -43274460,
      "heapUsedBytes": 184614348,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20193280,
      "scriptDurationMs": 943.7619999999998,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 67,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6507.000000000062,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.75500000000001,
      "layouts": 20,
      "layoutDurationMs": 26.992,
      "taskDurationMs": 6472.759999999999,
      "heapDeltaBytes": -39993264,
      "heapUsedBytes": 188844148,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13496320,
      "scriptDurationMs": 125.09400000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 523,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6311.365999999907,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 71.87699999999997,
      "layouts": 20,
      "layoutDurationMs": 27.384000000000004,
      "taskDurationMs": 6262.37,
      "heapDeltaBytes": -44158192,
      "heapUsedBytes": 177614884,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13234176,
      "scriptDurationMs": 119.606,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 445,
      "frameDurationMs": 18.889999999999965,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9089.196000000014,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9020.846,
      "heapDeltaBytes": 7814496,
      "heapUsedBytes": 186150484,
      "domNodes": 0,
      "jsHeapTotalBytes": -13369344,
      "scriptDurationMs": 149.968,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8739.192000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8659.096,
      "heapDeltaBytes": -7834044,
      "heapUsedBytes": 177624140,
      "domNodes": 0,
      "jsHeapTotalBytes": -23855104,
      "scriptDurationMs": 149.38399999999996,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 95.1909999999998,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 12.280000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.503,
      "taskDurationMs": 67.86699999999999,
      "heapDeltaBytes": 3129044,
      "heapUsedBytes": 72810144,
      "domNodes": 110,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.25,
      "eventListeners": 35,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 446.990000000028,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 19.357,
      "layouts": 3,
      "layoutDurationMs": 0.9160000000000001,
      "taskDurationMs": 108.77000000000001,
      "heapDeltaBytes": 4860100,
      "heapUsedBytes": 74438500,
      "domNodes": 117,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.698,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51176 76656 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from thedatalife October 7, 2026 02:30
@datadog-official

datadog-official Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d4413c6 | Docs | View more details | Give us feedback!

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 7, 2026
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #20379   +/-   ##
=============================================
  Coverage              ?   84.16%           
=============================================
  Files                 ?     2132           
  Lines                 ?   128490           
  Branches              ?    32706           
=============================================
  Hits                  ?   108139           
  Misses                ?    20170           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.75% <ø> (?)
unit 79.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

christian-byrne and others added 2 commits October 7, 2026 01:19
…nd (PM-1535) (#18610)

## Summary

Adds a black-box E2E pin for
[PM-1535](https://linear.app/comfyorg/issue/PM-1535): after two Agent
threads bind two workflow tabs, Alpha's build reaches Alpha's document
while Bravo remains active, but returning to Alpha leaves the selected
canvas empty.

The first case keeps an unconditional known-failure marker. An empty
canvas is the expected PM-1535 failure, a wrong or partial canvas fails
before the marker, and a fixed canvas becomes an unexpected pass that
tells the fixer to remove the marker and containment guard. The second
case is the positive control: a later turn rebinding Alpha materializes
the exact build already held by Alpha's document.

This carrier supersedes #18088 but intentionally does not carry its
three PM-1319 cases. Those pins and the shared-fixture consolidation are
tracked separately in #19663.

## Changes

- **What**: Adds `agentTwoSessionCrdtFixture.ts` and two focused cloud
Playwright cases for displaced-build return and recovery.
- **Dependencies**: None.

## Review Focus

- The unconditional `test.fail` must remain until PM-1535 is fixed.
- `expect([[], BUILT_NODE_IDS]).toContainEqual(canvas)` must reject
wrong or partial canvases before the known-failure marker.
- The exact-id positive control must continue proving that the stored
build is recoverable after rebinding.
- Scope is one of the two empty canvases in the report. This carrier
must not close PM-1535 by itself.

## Verification

```bash
PLAYWRIGHT_TEST_URL=http://127.0.0.1:6254 \
PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:6290 \
DEV_SERVER_COMFYUI_URL=http://127.0.0.1:6290 \
DISTRIBUTION=cloud NODE_OPTIONS=--no-experimental-webstorage \
pnpm exec playwright test \
  browser_tests/tests/agent/agentTwoSessionCrdtSubscription.spec.ts \
  --project=cloud --workers=1 --retries=0
```

Head `c61b3507f136c3c687833024af59a0fb8432aad7`: 2/2 focused tests
passed against a local backend. Mutation proof at that head makes a
canvas reader that always throws fail at that exact error instead of
passing as PM-1535. `6a40cf8` trims the harness (schema-parsed
`doc_subscribe`, private internals, catalog taken from the build
recording, comments moved into assertion and marker messages) without
changing either oracle; ESLint, type-aware oxlint, oxfmt, `pnpm
typecheck:browser`, and the hosted cloud Playwright shards cover it.

Related: PM-1535

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Approve. This is a faithful backport of #18610. The two adaptations account for helpers cloud/1.54 does not have.

I compared against #18610's merge commit b04d3395c0dae94a2cfb72695fb8b1fd98aa7796. browser_tests/tests/agent/agentTwoSessionCrdtSubscription.spec.ts carries identical hunks. browser_tests/fixtures/agentTwoSessionCrdtFixture.ts matches the source apart from d4413c6:

  • The source imports emptySeed from @e2e/fixtures/data/agent/agentRemoteApply. That module does not exist on cloud/1.54, so the fixture defines an identical local EMPTY_SEED: WorkflowJSON = { nodes: [], links: [] } (the same value as the source's emptySeed) and imports WorkflowJSON for it.
  • The source calls agentPanel.open(PANEL_MOUNT_TIMEOUT). AgentPanel.open() on cloud/1.54 takes no timeout parameter and uses its own retry loop, so the fixture calls open() and drops the unused constant.

Checks: pnpm typecheck:browser passes locally at this head. Hosted CI at d4413c6 is green, including lint-and-format, typecheck, test and e2e-status.

@DrJKL DrJKL assigned comfy-pr-bot and unassigned DrJKL Oct 7, 2026
@comfy-pr-bot
comfy-pr-bot merged commit 9276335 into cloud/1.54 Oct 7, 2026
123 of 125 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18610-to-cloud-1.54 branch October 7, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants