Repository navigation
fix(agent): recover stale schema on cloud/1.54 - #20312
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1991 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-06T20:00:19.768Z",
"gitSha": "4841fd42031902b292e7dfed9569cb6c104aa241",
"branch": "christian/stale-schema-recovery-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2049.6890000000008,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.044,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.106,
"heapDeltaBytes": -8262220,
"heapUsedBytes": 62868752,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.440999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2007.4389999999767,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.152000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.19899999999996,
"heapDeltaBytes": -5400244,
"heapUsedBytes": 65284072,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.706,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1943.994000000032,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.239,
"layouts": 14,
"layoutDurationMs": 3.743,
"taskDurationMs": 904.255,
"heapDeltaBytes": -8917708,
"heapUsedBytes": 64564712,
"domNodes": -281,
"jsHeapTotalBytes": 5275648,
"scriptDurationMs": 144.634,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1769.783000000018,
"styleRecalcs": 75,
"styleRecalcDurationMs": 25.49,
"layouts": 14,
"layoutDurationMs": 3.852,
"taskDurationMs": 755.712,
"heapDeltaBytes": 5804052,
"heapUsedBytes": 76914564,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 125.10100000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.8080000000127,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.465999999999998,
"layouts": 6,
"layoutDurationMs": 0.9359999999999999,
"taskDurationMs": 329.331,
"heapDeltaBytes": 4445872,
"heapUsedBytes": 75902820,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.885,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1675.1350000000684,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.21,
"layouts": 6,
"layoutDurationMs": 0.972,
"taskDurationMs": 327.24399999999997,
"heapDeltaBytes": 4828428,
"heapUsedBytes": 78937712,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.334,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 592.5090000000068,
"styleRecalcs": 15,
"styleRecalcDurationMs": 7.511,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.91,
"heapDeltaBytes": -7808476,
"heapUsedBytes": 63736476,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 138.282,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 575.3430000000321,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.014000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.47499999999997,
"heapDeltaBytes": -7203800,
"heapUsedBytes": 66170472,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 131.663,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2058.4690000000023,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.911999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.4989999999999,
"heapDeltaBytes": -7371096,
"heapUsedBytes": 70197080,
"domNodes": -274,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 33.223,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.3260000000973,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.481000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.6700000000001,
"heapDeltaBytes": -3633900,
"heapUsedBytes": 76629084,
"domNodes": -265,
"jsHeapTotalBytes": -2326528,
"scriptDurationMs": 31.712000000000003,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2183.490000000006,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.489,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1332.354,
"heapDeltaBytes": -10304308,
"heapUsedBytes": 68484072,
"domNodes": -284,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 656.6990000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2200.9050000000343,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.265000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1343.5529999999999,
"heapDeltaBytes": -883004,
"heapUsedBytes": 77646612,
"domNodes": -282,
"jsHeapTotalBytes": 4313088,
"scriptDurationMs": 663.346,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3248.0189999999993,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.203000000000001,
"layouts": 60,
"layoutDurationMs": 12.029,
"taskDurationMs": 1415.5480000000002,
"heapDeltaBytes": -772524,
"heapUsedBytes": 67120096,
"domNodes": 30,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 646.082,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3307.790000000068,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.861,
"layouts": 60,
"layoutDurationMs": 12.418999999999999,
"taskDurationMs": 1500.1470000000002,
"heapDeltaBytes": -643660,
"heapUsedBytes": 82349728,
"domNodes": -264,
"jsHeapTotalBytes": 2392064,
"scriptDurationMs": 655.509,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2347.846000000004,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.719,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1581.4149999999997,
"heapDeltaBytes": -12394336,
"heapUsedBytes": 73143064,
"domNodes": -279,
"jsHeapTotalBytes": -1277952,
"scriptDurationMs": 772.389,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2371.9839999999976,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.463999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.6919999999998,
"heapDeltaBytes": 9565956,
"heapUsedBytes": 92349556,
"domNodes": 8,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 804.617,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.1189999999756,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.572999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.8560000000001,
"heapDeltaBytes": -10418040,
"heapUsedBytes": 69554124,
"domNodes": -286,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 30.170999999999996,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.9559999999892,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.809,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.3829999999999,
"heapDeltaBytes": -9434928,
"heapUsedBytes": 72908876,
"domNodes": -274,
"jsHeapTotalBytes": -1802240,
"scriptDurationMs": 31.075000000000006,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 553.1839999999875,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.551,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.89300000000003,
"heapDeltaBytes": 14796096,
"heapUsedBytes": 89764192,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 120.44700000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.6609999999309,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.536999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.664,
"heapDeltaBytes": -10510828,
"heapUsedBytes": 65617848,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 119.27600000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.8429999999562,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.914,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.299,
"heapDeltaBytes": -12741152,
"heapUsedBytes": 59947048,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.479,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.970999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.133000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.61899999999997,
"heapDeltaBytes": -4348332,
"heapUsedBytes": 69250804,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.875000000000002,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1674.8850000000175,
"styleRecalcs": 78,
"styleRecalcDurationMs": 24.744999999999997,
"layouts": 18,
"layoutDurationMs": 4.193,
"taskDurationMs": 637.989,
"heapDeltaBytes": 20236860,
"heapUsedBytes": 87091208,
"domNodes": 38,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 91.98899999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.6140000000687,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.144,
"layouts": 18,
"layoutDurationMs": 4.287,
"taskDurationMs": 712.217,
"heapDeltaBytes": 4619800,
"heapUsedBytes": 78048056,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 92.283,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1252.3850000000039,
"styleRecalcs": 20,
"styleRecalcDurationMs": 26.547999999999995,
"layouts": 16,
"layoutDurationMs": 12.158999999999999,
"taskDurationMs": 806.5159999999997,
"heapDeltaBytes": -4991184,
"heapUsedBytes": 85095276,
"domNodes": 13831,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 26.744999999999997,
"eventListeners": 2385,
"totalBlockingTimeMs": 97,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8290.585000000021,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.86899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4798.709,
"heapDeltaBytes": -12555840,
"heapUsedBytes": 67755936,
"domNodes": -265,
"jsHeapTotalBytes": -2588672,
"scriptDurationMs": 2254.81,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8278.882000000067,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.588,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4704.9039999999995,
"heapDeltaBytes": -12779396,
"heapUsedBytes": 67728176,
"domNodes": -270,
"jsHeapTotalBytes": -1540096,
"scriptDurationMs": 2213.5559999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15066.390000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14714.113,
"heapDeltaBytes": -39026500,
"heapUsedBytes": 179434196,
"domNodes": -8068,
"jsHeapTotalBytes": -13090816,
"scriptDurationMs": 232.86599999999996,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15313.152999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14957.012999999999,
"heapDeltaBytes": -53093152,
"heapUsedBytes": 180767160,
"domNodes": -8068,
"jsHeapTotalBytes": -22261760,
"scriptDurationMs": 234.215,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17698.85000000005,
"styleRecalcs": 129,
"styleRecalcDurationMs": 16.716000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17438.667,
"heapDeltaBytes": -30028724,
"heapUsedBytes": 190140108,
"domNodes": -8068,
"jsHeapTotalBytes": -7659520,
"scriptDurationMs": 749.818,
"eventListeners": -14929,
"totalBlockingTimeMs": 80,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17777.226999999926,
"styleRecalcs": 127,
"styleRecalcDurationMs": 16.152,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17541.753999999997,
"heapDeltaBytes": -59349568,
"heapUsedBytes": 180251564,
"domNodes": -8068,
"jsHeapTotalBytes": -21135360,
"scriptDurationMs": 735.462,
"eventListeners": -14931,
"totalBlockingTimeMs": 22,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5426.810999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.98899999999999,
"layouts": 20,
"layoutDurationMs": 22.046999999999997,
"taskDurationMs": 5384.987000000001,
"heapDeltaBytes": -32400252,
"heapUsedBytes": 185407548,
"domNodes": -8068,
"jsHeapTotalBytes": 21192704,
"scriptDurationMs": 97.04599999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 254,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5515.312999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.034000000000034,
"layouts": 20,
"layoutDurationMs": 21.557000000000006,
"taskDurationMs": 5442.522999999999,
"heapDeltaBytes": -33146452,
"heapUsedBytes": 184417108,
"domNodes": -8068,
"jsHeapTotalBytes": 15425536,
"scriptDurationMs": 93.931,
"eventListeners": -14929,
"totalBlockingTimeMs": 220,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7503.6769999999815,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7357.992999999999,
"heapDeltaBytes": -14964320,
"heapUsedBytes": 166768072,
"domNodes": 0,
"jsHeapTotalBytes": -23855104,
"scriptDurationMs": 115.26499999999996,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7689.106999999922,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7412.735,
"heapDeltaBytes": 15617512,
"heapUsedBytes": 181077068,
"domNodes": 0,
"jsHeapTotalBytes": -19398656,
"scriptDurationMs": 117.69399999999996,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 447.47699999999213,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.346,
"layouts": 3,
"layoutDurationMs": 1.5399999999999998,
"taskDurationMs": 102.28800000000001,
"heapDeltaBytes": 5000340,
"heapUsedBytes": 74578900,
"domNodes": 147,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.959999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 86.69900000006692,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.924,
"layouts": 1,
"layoutDurationMs": 0.6930000000000001,
"taskDurationMs": 56.220000000000006,
"heapDeltaBytes": 2962612,
"heapUsedBytes": 74557764,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.368999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.54 #20312 +/- ##
=============================================
Coverage ? 84.24%
=============================================
Files ? 2132
Lines ? 128440
Branches ? 34893
=============================================
Hits ? 108198
Misses ? 20061
Partials ? 181
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 7 |
Panel: 8/8 reviewers contributed findings.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 10 prior finding(s) across 1 round(s) (2 never answered).
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 4 |
| 🟡 Medium | 3 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
Direct successor to #20312. Closes its post-merge Cursor findings before cloud/1.54 delivery is considered complete. - serializes the confirmed live canvas without mutating undo state - bounds reseed retries and makes permanent failures terminal - abandons ambiguous lineages on timeout, reconnect, and conflict - replays in-flight human edits after replacement - sizes the complete UTF-8 wire frame once and resets lineage node bookkeeping Verification: - 56 CRDT and Agent panel test files: 1,238 passed, 6 expected failures - typecheck, format, lint, and pre-commit knip passed Tracks PM-1793 and PM-1794. Review source: #20312 (review)
Summary
Adapt the merged stale-schema browser recovery for the older cloud/1.54 follower architecture without importing main-only lifecycle or projection code.
Human owner:
@christian-byrneChanges
Review Focus
expected_seqis consumed exactly once, so a stale tab cannot replay an old reseed authorization.Testing
vue-tsc --noEmit --skipLibCheckpasses.Closes the cloud/1.54 delivery gap for PM-1793 and PM-1794.
Mainline implementation: #19032
Server counterpart: Comfy-Org/cloud#10814