Skip to content

fix(agent): recover stale schema on cloud/1.54 - #20312

Merged
christian-byrne merged 2 commits into
cloud/1.54from
christian/stale-schema-recovery-cloud-1.54
Oct 6, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
christian/stale-schema-recovery-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Adapt the merged stale-schema browser recovery for the older cloud/1.54 follower architecture without importing main-only lifecycle or projection code.

Human owner: @christian-byrne

Changes

  • Advertise the server-supported reseed capability and parse the refusal sequence plus reseed results.
  • Bind one visible-canvas reseed to each stale-schema refusal, then reset and resubscribe after success or a concurrent-tab conflict.
  • Keep retryable failures inside the release branch's existing bounded subscribe backoff; stop probing after a final refusal.
  • Serialize the bound/open workflow currently shown by the tab, using the same save preparation as an Agent turn draft.

Review Focus

  • This is a release-compatible adaptation of frontend feat(agent): re-mint a stale-schema document from the canvas on subscribe #19032, not a cherry-pick. The cloud/1.54 branch has a monolithic follower and does not have main's AgentCrdtDocLifecycle/projection split.
  • The refusal's expected_seq is consumed exactly once, so a stale tab cannot replay an old reseed authorization.
  • A late reseed result is ignored after retargeting.

Testing

  • 131 focused CRDT tests pass, including new wire, refusal-token, lineage-reset, conflict, and late-result coverage.
  • vue-tsc --noEmit --skipLibCheck passes.
  • Oxfmt, type-aware oxlint, ESLint, stylelint, and knip pass through the commit hooks.

Closes the cloud/1.54 delivery gap for PM-1793 and PM-1794.
Mainline implementation: #19032
Server counterpart: Comfy-Org/cloud#10814

@vercel

vercel Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 6, 2026 7:49pm UTC
billing-web-test Ignored Ignored Oct 6, 2026 7:49pm UTC

Request Review

@christian-byrne christian-byrne added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations cloud/1.54 Backport PRs for cloud 1.54 cursor-review Trigger multi-model Cursor agent review on this PR greenlight labels Oct 6, 2026
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 8cbb8d9f-e60e-4ef2-9dac-96ff5001d990

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/06/2026, 07:51:24 PM UTC

Links

🎭 Playwright: ✅ 1991 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1970 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 97ms TBT · 81.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.6 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.8 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 51ms TBT · 176.6 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 237ms TBT · 176.3 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 165.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 431ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.1 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -196
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 27ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 830ms
canvas-mouse-sweep: script duration 135ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.5 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 328ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.8 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 399ms
dom-widget-clipping: script duration 135ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 61.9 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 537ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 70.0 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -193
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1338ms
large-graph-pan: script duration 660ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 69.7 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -191
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 70
large-graph-zoom: task duration 1458ms
large-graph-zoom: script duration 651ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.3 MB
large-graph-zoom: DOM nodes -117
large-graph-zoom: event listeners -94
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1591ms
legacy-node-drag: script duration 789ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 78.9 MB
legacy-node-drag: DOM nodes -136
legacy-node-drag: event listeners 87
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 508ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 67.9 MB
minimap-idle: DOM nodes -280
minimap-idle: event listeners -190
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 363ms
subgraph-dom-widget-clipping: script duration 120ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 74.1 MB
subgraph-dom-widget-clipping: DOM nodes 22
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 442ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.6 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -242
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 24ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 675ms
subgraph-mouse-sweep: script duration 92ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 78.7 MB
subgraph-mouse-sweep: DOM nodes -129
subgraph-mouse-sweep: event listeners -103
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 27ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 807ms
subgraph-transition-enter: script duration 27ms
subgraph-transition-enter: TBT 97ms
subgraph-transition-enter: heap used 81.2 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 42ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4752ms
viewport-pan-sweep: script duration 2234ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 64.6 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -159
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14836ms
vue-large-graph-idle: script duration 234ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.8 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14930
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 128
vue-large-graph-pan: task duration 17490ms
vue-large-graph-pan: script duration 743ms
vue-large-graph-pan: TBT 51ms
vue-large-graph-pan: heap used 176.6 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 61ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5414ms
vue-node-resize-workload: script duration 95ms
vue-node-resize-workload: TBT 237ms
vue-node-resize-workload: heap used 176.3 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7385ms
vue-zoom-out-idle: script duration 116ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 165.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -9
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 2
workflow-execution: style recalc count 13
workflow-execution: task duration 79ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 71.1 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-10-06T20:00:19.768Z",
  "gitSha": "4841fd42031902b292e7dfed9569cb6c104aa241",
  "branch": "christian/stale-schema-recovery-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2049.6890000000008,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.044,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.106,
      "heapDeltaBytes": -8262220,
      "heapUsedBytes": 62868752,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.440999999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2007.4389999999767,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.152000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.19899999999996,
      "heapDeltaBytes": -5400244,
      "heapUsedBytes": 65284072,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.706,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1943.994000000032,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 29.239,
      "layouts": 14,
      "layoutDurationMs": 3.743,
      "taskDurationMs": 904.255,
      "heapDeltaBytes": -8917708,
      "heapUsedBytes": 64564712,
      "domNodes": -281,
      "jsHeapTotalBytes": 5275648,
      "scriptDurationMs": 144.634,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1769.783000000018,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 25.49,
      "layouts": 14,
      "layoutDurationMs": 3.852,
      "taskDurationMs": 755.712,
      "heapDeltaBytes": 5804052,
      "heapUsedBytes": 76914564,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 125.10100000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1668.8080000000127,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.465999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.9359999999999999,
      "taskDurationMs": 329.331,
      "heapDeltaBytes": 4445872,
      "heapUsedBytes": 75902820,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.885,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1675.1350000000684,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 14.21,
      "layouts": 6,
      "layoutDurationMs": 0.972,
      "taskDurationMs": 327.24399999999997,
      "heapDeltaBytes": 4828428,
      "heapUsedBytes": 78937712,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.334,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 592.5090000000068,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 7.511,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.91,
      "heapDeltaBytes": -7808476,
      "heapUsedBytes": 63736476,
      "domNodes": 22,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 138.282,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 575.3430000000321,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 8.014000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.47499999999997,
      "heapDeltaBytes": -7203800,
      "heapUsedBytes": 66170472,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 131.663,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2058.4690000000023,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.911999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 555.4989999999999,
      "heapDeltaBytes": -7371096,
      "heapUsedBytes": 70197080,
      "domNodes": -274,
      "jsHeapTotalBytes": -892928,
      "scriptDurationMs": 33.223,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.3260000000973,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.481000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 517.6700000000001,
      "heapDeltaBytes": -3633900,
      "heapUsedBytes": 76629084,
      "domNodes": -265,
      "jsHeapTotalBytes": -2326528,
      "scriptDurationMs": 31.712000000000003,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2183.490000000006,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.489,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1332.354,
      "heapDeltaBytes": -10304308,
      "heapUsedBytes": 68484072,
      "domNodes": -284,
      "jsHeapTotalBytes": 4874240,
      "scriptDurationMs": 656.6990000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2200.9050000000343,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.265000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1343.5529999999999,
      "heapDeltaBytes": -883004,
      "heapUsedBytes": 77646612,
      "domNodes": -282,
      "jsHeapTotalBytes": 4313088,
      "scriptDurationMs": 663.346,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3248.0189999999993,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.203000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.029,
      "taskDurationMs": 1415.5480000000002,
      "heapDeltaBytes": -772524,
      "heapUsedBytes": 67120096,
      "domNodes": 30,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 646.082,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3307.790000000068,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 15.861,
      "layouts": 60,
      "layoutDurationMs": 12.418999999999999,
      "taskDurationMs": 1500.1470000000002,
      "heapDeltaBytes": -643660,
      "heapUsedBytes": 82349728,
      "domNodes": -264,
      "jsHeapTotalBytes": 2392064,
      "scriptDurationMs": 655.509,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2347.846000000004,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 11.719,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1581.4149999999997,
      "heapDeltaBytes": -12394336,
      "heapUsedBytes": 73143064,
      "domNodes": -279,
      "jsHeapTotalBytes": -1277952,
      "scriptDurationMs": 772.389,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2371.9839999999976,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.463999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1600.6919999999998,
      "heapDeltaBytes": 9565956,
      "heapUsedBytes": 92349556,
      "domNodes": 8,
      "jsHeapTotalBytes": 6184960,
      "scriptDurationMs": 804.617,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.1189999999756,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.572999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.8560000000001,
      "heapDeltaBytes": -10418040,
      "heapUsedBytes": 69554124,
      "domNodes": -286,
      "jsHeapTotalBytes": -630784,
      "scriptDurationMs": 30.170999999999996,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.9559999999892,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.809,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 510.3829999999999,
      "heapDeltaBytes": -9434928,
      "heapUsedBytes": 72908876,
      "domNodes": -274,
      "jsHeapTotalBytes": -1802240,
      "scriptDurationMs": 31.075000000000006,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 553.1839999999875,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 11.551,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 364.89300000000003,
      "heapDeltaBytes": 14796096,
      "heapUsedBytes": 89764192,
      "domNodes": 24,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 120.44700000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 591.6609999999309,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.536999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 360.664,
      "heapDeltaBytes": -10510828,
      "heapUsedBytes": 65617848,
      "domNodes": 20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 119.27600000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.8429999999562,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.914,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.299,
      "heapDeltaBytes": -12741152,
      "heapUsedBytes": 59947048,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.479,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.970999999974,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.133000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.61899999999997,
      "heapDeltaBytes": -4348332,
      "heapUsedBytes": 69250804,
      "domNodes": -298,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.875000000000002,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1674.8850000000175,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 24.744999999999997,
      "layouts": 18,
      "layoutDurationMs": 4.193,
      "taskDurationMs": 637.989,
      "heapDeltaBytes": 20236860,
      "heapUsedBytes": 87091208,
      "domNodes": 38,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 91.98899999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1720.6140000000687,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 24.144,
      "layouts": 18,
      "layoutDurationMs": 4.287,
      "taskDurationMs": 712.217,
      "heapDeltaBytes": 4619800,
      "heapUsedBytes": 78048056,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 92.283,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1252.3850000000039,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 26.547999999999995,
      "layouts": 16,
      "layoutDurationMs": 12.158999999999999,
      "taskDurationMs": 806.5159999999997,
      "heapDeltaBytes": -4991184,
      "heapUsedBytes": 85095276,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 26.744999999999997,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 97,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8290.585000000021,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 40.86899999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4798.709,
      "heapDeltaBytes": -12555840,
      "heapUsedBytes": 67755936,
      "domNodes": -265,
      "jsHeapTotalBytes": -2588672,
      "scriptDurationMs": 2254.81,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8278.882000000067,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 42.588,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4704.9039999999995,
      "heapDeltaBytes": -12779396,
      "heapUsedBytes": 67728176,
      "domNodes": -270,
      "jsHeapTotalBytes": -1540096,
      "scriptDurationMs": 2213.5559999999996,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15066.390000000012,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14714.113,
      "heapDeltaBytes": -39026500,
      "heapUsedBytes": 179434196,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13090816,
      "scriptDurationMs": 232.86599999999996,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15313.152999999944,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14957.012999999999,
      "heapDeltaBytes": -53093152,
      "heapUsedBytes": 180767160,
      "domNodes": -8068,
      "jsHeapTotalBytes": -22261760,
      "scriptDurationMs": 234.215,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17698.85000000005,
      "styleRecalcs": 129,
      "styleRecalcDurationMs": 16.716000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17438.667,
      "heapDeltaBytes": -30028724,
      "heapUsedBytes": 190140108,
      "domNodes": -8068,
      "jsHeapTotalBytes": -7659520,
      "scriptDurationMs": 749.818,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 80,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17777.226999999926,
      "styleRecalcs": 127,
      "styleRecalcDurationMs": 16.152,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17541.753999999997,
      "heapDeltaBytes": -59349568,
      "heapUsedBytes": 180251564,
      "domNodes": -8068,
      "jsHeapTotalBytes": -21135360,
      "scriptDurationMs": 735.462,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 22,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5426.810999999987,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 61.98899999999999,
      "layouts": 20,
      "layoutDurationMs": 22.046999999999997,
      "taskDurationMs": 5384.987000000001,
      "heapDeltaBytes": -32400252,
      "heapUsedBytes": 185407548,
      "domNodes": -8068,
      "jsHeapTotalBytes": 21192704,
      "scriptDurationMs": 97.04599999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 254,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5515.312999999992,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.034000000000034,
      "layouts": 20,
      "layoutDurationMs": 21.557000000000006,
      "taskDurationMs": 5442.522999999999,
      "heapDeltaBytes": -33146452,
      "heapUsedBytes": 184417108,
      "domNodes": -8068,
      "jsHeapTotalBytes": 15425536,
      "scriptDurationMs": 93.931,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 220,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7503.6769999999815,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7357.992999999999,
      "heapDeltaBytes": -14964320,
      "heapUsedBytes": 166768072,
      "domNodes": 0,
      "jsHeapTotalBytes": -23855104,
      "scriptDurationMs": 115.26499999999996,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7689.106999999922,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7412.735,
      "heapDeltaBytes": 15617512,
      "heapUsedBytes": 181077068,
      "domNodes": 0,
      "jsHeapTotalBytes": -19398656,
      "scriptDurationMs": 117.69399999999996,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 447.47699999999213,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 21.346,
      "layouts": 3,
      "layoutDurationMs": 1.5399999999999998,
      "taskDurationMs": 102.28800000000001,
      "heapDeltaBytes": 5000340,
      "heapUsedBytes": 74578900,
      "domNodes": 147,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.959999999999999,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 86.69900000006692,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 9.924,
      "layouts": 1,
      "layoutDurationMs": 0.6930000000000001,
      "taskDurationMs": 56.220000000000006,
      "heapDeltaBytes": 2962612,
      "heapUsedBytes": 74557764,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 3.368999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51142 76616 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation budget remaining for this pull request: 98 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@christian-byrne
christian-byrne removed the request for review from DrJKL October 6, 2026 09:20
@christian-byrne
christian-byrne enabled auto-merge (squash) October 6, 2026 09:24
@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.59055% with 31 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 51.35% 18 Missing ⚠️
...ench/extensions/agent/crdt/layoutFollowerBridge.ts 88.70% 7 Missing ⚠️
src/workbench/extensions/agent/AgentPanelRoot.vue 55.55% 4 Missing ⚠️
...c/workbench/extensions/agent/crdt/docFrameCodes.ts 60.00% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #20312   +/-   ##
=============================================
  Coverage              ?   84.24%           
=============================================
  Files                 ?     2132           
  Lines                 ?   128440           
  Branches              ?    34893           
=============================================
  Hits                  ?   108198           
  Misses                ?    20061           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.77% <ø> (?)
unit 79.61% <75.59%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/crdt/devPanelLog.ts 100.00% <ø> (ø)
.../workbench/extensions/agent/crdt/docFrameClient.ts 98.96% <100.00%> (ø)
...c/workbench/extensions/agent/crdt/docFrameCodes.ts 60.00% <60.00%> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 92.22% <55.55%> (ø)
...ench/extensions/agent/crdt/layoutFollowerBridge.ts 94.87% <88.70%> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 94.32% <51.35%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 3
🟡 Medium 7

Panel: 8/8 reviewers contributed findings.

@datadog-official

This comment has been minimized.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 6, 2026
@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 6, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Round 2 — ledger: 10 prior finding(s) across 1 round(s) (2 never answered).

Found 9 finding(s).

Severity Count
🟠 High 4
🟡 Medium 3
🟢 Low 2

Panel: 8/8 reviewers contributed findings.

@christian-byrne
christian-byrne merged commit 0bd97d8 into cloud/1.54 Oct 6, 2026
135 checks passed
@christian-byrne
christian-byrne deleted the christian/stale-schema-recovery-cloud-1.54 branch October 6, 2026 23:08
christian-byrne added a commit that referenced this pull request Oct 8, 2026
Direct successor to #20312. Closes its post-merge Cursor findings before
cloud/1.54 delivery is considered complete.

- serializes the confirmed live canvas without mutating undo state
- bounds reseed retries and makes permanent failures terminal
- abandons ambiguous lineages on timeout, reconnect, and conflict
- replays in-flight human edits after replacement
- sizes the complete UTF-8 wire frame once and resets lineage node
bookkeeping

Verification:
- 56 CRDT and Agent panel test files: 1,238 passed, 6 expected failures
- typecheck, format, lint, and pre-commit knip passed

Tracks PM-1793 and PM-1794.

Review source:
#20312 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations cloud/1.54 Backport PRs for cloud 1.54 cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants