Repository navigation
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2157 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (39 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c8195e1fa5570a4e4003cf8303eb55bcb2d490e4
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-06T04:41:37.774Z",
"gitSha": "6a5fef82adaa22ce2373f60a4bba4c9c26aafdb7",
"branch": "jaeone94/backport-dynamic-group-cloud-155",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.9679999999962,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.454,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.3139999999999,
"heapDeltaBytes": 8503392,
"heapUsedBytes": 78680332,
"domNodes": -264,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 13.932999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.8270000000539,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.075000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.134,
"heapDeltaBytes": 2378404,
"heapUsedBytes": 71837524,
"domNodes": -257,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.937999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1751.353999999992,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.535999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 903.3249999999999,
"heapDeltaBytes": 5101536,
"heapUsedBytes": 75095816,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 174.468,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.894999999925,
"styleRecalcs": 44,
"styleRecalcDurationMs": 16.322999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 886.961,
"heapDeltaBytes": 6518832,
"heapUsedBytes": 76489124,
"domNodes": -246,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 172.531,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.9189999999767,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.578000000000003,
"layouts": 6,
"layoutDurationMs": 1.2489999999999999,
"taskDurationMs": 395.602,
"heapDeltaBytes": 4053692,
"heapUsedBytes": 74405228,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 15.48,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.6270000000077,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.849999999999998,
"layouts": 6,
"layoutDurationMs": 1.1990000000000003,
"taskDurationMs": 335.09999999999997,
"heapDeltaBytes": 3765028,
"heapUsedBytes": 74436512,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 15.78,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 739.5020000000159,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.547999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.55300000000005,
"heapDeltaBytes": -6561172,
"heapUsedBytes": 63825948,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 178.74499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 676.4479999999367,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.324,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.2,
"heapDeltaBytes": -8182884,
"heapUsedBytes": 62164912,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 174.58499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1252.1859999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 926.2439999999999,
"heapDeltaBytes": 36502120,
"heapUsedBytes": 105111672,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 74.745,
"eventListeners": 0,
"totalBlockingTimeMs": 647,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1339.623999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1052.4260000000002,
"heapDeltaBytes": 27920380,
"heapUsedBytes": 100635388,
"domNodes": -293,
"jsHeapTotalBytes": 15880192,
"scriptDurationMs": 79.939,
"eventListeners": -217,
"totalBlockingTimeMs": 695,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.9629999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.6059999999992,
"heapDeltaBytes": 15351744,
"heapUsedBytes": 92102676,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.89499999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 855.2270000000135,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.75599999999986,
"heapDeltaBytes": 15485484,
"heapUsedBytes": 92285016,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.58200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11420.111999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10355.136,
"heapDeltaBytes": 11893276,
"heapUsedBytes": 93701836,
"domNodes": -16,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 8592.804999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 1528,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11741.849000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10708.589999999998,
"heapDeltaBytes": -6843020,
"heapUsedBytes": 74699196,
"domNodes": -14,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 9012.684,
"eventListeners": 0,
"totalBlockingTimeMs": 1845,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11083.79100000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10180.258,
"heapDeltaBytes": -7269000,
"heapUsedBytes": 69409948,
"domNodes": -12,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8459.538999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1453,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10882.146000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10024.288999999999,
"heapDeltaBytes": 18669692,
"heapUsedBytes": 95177944,
"domNodes": -10,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 8353.206,
"eventListeners": 0,
"totalBlockingTimeMs": 1347,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2037.5159999999823,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.773000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.9219999999999,
"heapDeltaBytes": -25599640,
"heapUsedBytes": 73280076,
"domNodes": -244,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 41.73800000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.4639999999008,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.813999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.679,
"heapDeltaBytes": -4022860,
"heapUsedBytes": 72801228,
"domNodes": -247,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 39.571999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2456.557000000032,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.56,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1689.5929999999998,
"heapDeltaBytes": 31316660,
"heapUsedBytes": 96022612,
"domNodes": -251,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 899.592,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2775.239000000056,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.120000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1792.2469999999998,
"heapDeltaBytes": -22323528,
"heapUsedBytes": 78111764,
"domNodes": -249,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 964.7869999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3620.3840000000014,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.866999999999999,
"layouts": 60,
"layoutDurationMs": 13.994,
"taskDurationMs": 1724.7730000000004,
"heapDeltaBytes": -696760,
"heapUsedBytes": 65627748,
"domNodes": 28,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 831.909,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3714.6719999999505,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.841999999999995,
"layouts": 60,
"layoutDurationMs": 14.05,
"taskDurationMs": 1774.016,
"heapDeltaBytes": -581212,
"heapUsedBytes": 65981452,
"domNodes": 28,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 844.8180000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3134.473000000014,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.850000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1975.226,
"heapDeltaBytes": 8729064,
"heapUsedBytes": 74670904,
"domNodes": -251,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 1076.7150000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3215.1300000000447,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.438999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1979.829,
"heapDeltaBytes": 17226800,
"heapUsedBytes": 83286908,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1066.194,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.1079999999693,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.221,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.32,
"heapDeltaBytes": 9924120,
"heapUsedBytes": 74545696,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.937,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2042.7859999999782,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.035000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.268,
"heapDeltaBytes": -26977420,
"heapUsedBytes": 74202408,
"domNodes": -243,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 37.196000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.5930000000321,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.160999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.718,
"heapDeltaBytes": 13958124,
"heapUsedBytes": 86420624,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 148.208,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.438999999923,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.419,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.497,
"heapDeltaBytes": 14280024,
"heapUsedBytes": 86819976,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 147.199,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.6699999999578,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.326000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.3969999999999,
"heapDeltaBytes": 7119040,
"heapUsedBytes": 79508616,
"domNodes": -276,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 13.070000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.8139999999921,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.040000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.594,
"heapDeltaBytes": 8778956,
"heapUsedBytes": 80919828,
"domNodes": -272,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.615,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.9149999999822,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.702999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 846.243,
"heapDeltaBytes": 5527568,
"heapUsedBytes": 77894256,
"domNodes": -263,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 120.24399999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.0339999999605,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.438,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 833.6819999999999,
"heapDeltaBytes": 4895036,
"heapUsedBytes": 77220472,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 119.249,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.9030000000002,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.468999999999998,
"layouts": 5,
"layoutDurationMs": 15.484000000000002,
"taskDurationMs": 1028.2779999999998,
"heapDeltaBytes": 3101664,
"heapUsedBytes": 99890784,
"domNodes": 14147,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 34.181999999999995,
"eventListeners": 2463,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8899.639000000036,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.183,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6156.755999999999,
"heapDeltaBytes": -33214440,
"heapUsedBytes": 66320576,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 3044.759,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8631.293000000027,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.84799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6002.23,
"heapDeltaBytes": -4159992,
"heapUsedBytes": 95221500,
"domNodes": -247,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 3004.7090000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18184.368000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17902.021,
"heapDeltaBytes": -12759944,
"heapUsedBytes": 200130336,
"domNodes": -8061,
"jsHeapTotalBytes": -10498048,
"scriptDurationMs": 296.14099999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18253.11099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17940.207000000002,
"heapDeltaBytes": -47713584,
"heapUsedBytes": 165941000,
"domNodes": -8061,
"jsHeapTotalBytes": -12333056,
"scriptDurationMs": 319.641,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22704.800999999974,
"styleRecalcs": 172,
"styleRecalcDurationMs": 24.787000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22579.007,
"heapDeltaBytes": 8656456,
"heapUsedBytes": 185389096,
"domNodes": -8061,
"jsHeapTotalBytes": -19922944,
"scriptDurationMs": 975.967,
"eventListeners": -14928,
"totalBlockingTimeMs": 151,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21926.558,
"styleRecalcs": 163,
"styleRecalcDurationMs": 19.92699999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21779.517000000003,
"heapDeltaBytes": -27499800,
"heapUsedBytes": 167094312,
"domNodes": -8061,
"jsHeapTotalBytes": -9175040,
"scriptDurationMs": 894.596,
"eventListeners": -14928,
"totalBlockingTimeMs": 175,
"frameDurationMs": 17.779999999999806,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-node-resize-workload",
"durationMs": 6657.8810000000885,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.16700000000004,
"layouts": 20,
"layoutDurationMs": 28.176000000000005,
"taskDurationMs": 6634.593,
"heapDeltaBytes": -39117528,
"heapUsedBytes": 185426404,
"domNodes": -8061,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 131.339,
"eventListeners": -14928,
"totalBlockingTimeMs": 569,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6320.583000000056,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.67600000000003,
"layouts": 20,
"layoutDurationMs": 26.045000000000012,
"taskDurationMs": 6258.018,
"heapDeltaBytes": 6460272,
"heapUsedBytes": 184103332,
"domNodes": -8061,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 114.88999999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 426,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9014.438999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8865.115000000002,
"heapDeltaBytes": -3117500,
"heapUsedBytes": 180241764,
"domNodes": 0,
"jsHeapTotalBytes": -27787264,
"scriptDurationMs": 138.741,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8938.557999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8802.019000000002,
"heapDeltaBytes": 24345396,
"heapUsedBytes": 184767812,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 138.48499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 134.44400000003043,
"styleRecalcs": 8,
"styleRecalcDurationMs": 19.202000000000005,
"layouts": 3,
"layoutDurationMs": 1.6070000000000002,
"taskDurationMs": 100.269,
"heapDeltaBytes": 3153528,
"heapUsedBytes": 70239172,
"domNodes": 133,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.427000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 102.18600000007427,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.696,
"layouts": 3,
"layoutDurationMs": 1.619,
"taskDurationMs": 75.551,
"heapDeltaBytes": 3004024,
"heapUsedBytes": 69845504,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.580000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.55 #20289 +/- ##
=============================================
Coverage ? 84.21%
=============================================
Files ? 3105
Lines ? 153707
Branches ? 39577
=============================================
Hits ? 129449
Misses ? 22847
Partials ? 1411
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
…le test The #20275 backport kept a main-only `surface` option in the expected reportError call. ReportErrorOptions on cloud/1.55 has no `surface`, so the 403/500 lifecycle cases failed on every PR against this branch.
…1.55 `cursor-review` #19979 reads the node's nested input specs through `@/schemas/nodeDef/inputSpecTree`, which does not exist on this release branch: that module needs `zDynamicGroupInputSpec`, `zDynamicComboOption`, `zDynamicComboSpecV2` and `isDynamicControlType`, none of which `object-info-parser` exports here, and carrying them would pull the DynamicGroup feature work that #20289 already carries separately. Walk the two dynamic containers cloud/1.55 can represent instead (`COMFY_DYNAMICCOMBO_V3` options and `COMFY_AUTOGROW_V3` templates), using the branch's own `zDynamicComboInputSpec` and `zAutogrowOptions`. The gate answers the same question for every node-def shape reachable here; a container whose options fail to parse yields nothing, matching `inputSpecTree`. Nothing else in #19979's diff is changed.
…lues (#19979) (#20561) ## Summary Backports [#19979](#19979) (`fix(agent): apply positional overflow widget values`, merged to `main` as `99c46fe15f974be23379dee6ed456836061db8b7`) onto `cloud/1.55`, so `_extra_N` document widget values resolve to the Nth serializable live widget during Agent graph apply instead of being dropped. `cloud/1.55` currently carries **no** positional-overflow resolution at all — `OVERFLOW_WIDGET_NAME_RE` has 0 occurrences in `liveGraphApplier.ts` on the base — while the detector this fix exists for (`agent_graph_widget_missing`, Linear [BE-16625](https://linear.app/comfyorg/issue/BE-16625/widget-catalog-arity-mismatch-extra-n-positional-overflow-is-a)) is firing in production on `1.55.16`/`1.55.17`/`1.55.18`. `#19979` is not an ancestor of `origin/cloud/1.55` (`git merge-base --is-ancestor` → exit 1) and no backport existed. ## Changes - **What**: two commits. 1. `be980c441e` — `git cherry-pick -x 99c46fe`, applied **clean**. The added/removed lines are byte-identical to the upstream commit (1,409 `+`/`-` lines diffed equal; only hunk offsets and blob indexes differ). 2. `7a6fddba1e` — the one release-branch resolution needed to make it compile, described below. - **Breaking**: none. - **Dependencies**: none added. Imports only modules `cloud/1.55` already ships. ### The one resolution, stated plainly `#19979`'s gate reads the node's nested input specs through `@/schemas/nodeDef/inputSpecTree`, **which does not exist on `cloud/1.55`**. That module needs `zDynamicGroupInputSpec`, `zDynamicComboOption`, `zDynamicComboSpecV2` and `isDynamicControlType`, none of which this branch's `object-info-parser` exports; carrying them would drag in the DynamicGroup feature work that [#20289](#20289) is already carrying to this branch separately. So the nested-spec walk is done locally in `liveGraphApplier.ts`, over the two dynamic containers `cloud/1.55` *can* represent, using the branch's own schemas: | Container | Schema used | Nested inputs | | --- | --- | --- | | `COMFY_DYNAMICCOMBO_V3` | `zDynamicComboInputSpec` | `options[].inputs` | | `COMFY_AUTOGROW_V3` | `zAutogrowOptions` | `template.input` | `COMFY_MATCHTYPE_V3` is a leaf and nests nothing. `COMFY_DYNAMICGROUP_V3` is not representable on this branch at all, so there is no shape the local walk misses that a node def here could produce. A container whose options fail to parse yields nothing — the same outcome as `inputSpecTree`, which returns `[]` on a parse failure. **Deliberately not used:** this branch's existing `flattenInputSpecs` (`src/schemas/nodeDef/inputSpecUtil.ts`) covers the same dynamic-combo nesting, but it `assert`s on a malformed combo spec — which throws in DEV and reports to Sentry in prod. Calling it per widget-name resolution on the remote-apply path would add a throwing assertion and Sentry noise that `#19979` does not have. Nothing else in `#19979`'s diff is touched. ### One message-only rewrite, after the first push `cloud/1.55` still runs `ci-check-ai-co-authors.yaml`, which `main` dropped in [#19393](#19393) — so the release branch rejects metadata that `main` accepted, and the cherry-pick carried #19979's own `Co-authored-by: … <noreply@anthropic.com>` trailer into a branch that forbids it. The check failed for that reason alone and the script's own remedy is to rewrite the message and force-push. Done as a message-only rewrite, `46664f77ec` → `7a6fddba1e`, with nothing else changed: | | | | --- | --- | | Removed | exactly one line — the AI co-author trailer. `diff` of the two commit-message streams is a single deletion. | | Preserved | `Co-authored-by: Alexander Brown <drjkl@comfy.org>`, the human trailer | | Tree equality | tip tree `bb4e5f39c265e0c3cfa6cc0ca6633d0bc9e98c2f` **before and after**; cherry-pick tree `5c36c501376a8e10588f4f94af94f0a348036f8a` before and after; `git diff 46664f7 7a6fddb` is empty | | Lease | `--force-with-lease=refs/heads/backport-19979-to-cloud-1.55:46664f77ec` | | Approvals spent | **none** — the PR had 0 reviews of any kind at the time of the push | `bash .github/scripts/check-ai-co-authors.sh d163f33 7a6fddb` passes locally, and the unit suite was re-run at the new head (45 passed) rather than inherited from the old commit identity. ## Review Focus - **The resolution is the only non-mechanical part of this PR.** It is confined to `supportsDynamicWidgetOverflow` and three new module-local helpers; the rest of the backport is a byte-identical cherry-pick. - **The gate is load-bearing in both directions, proven by mutation.** Forcing it to `false` fails 14 of the 45 `liveGraphApplier.test.ts` tests; forcing it to `true` fails 2 (including `rejects an initial positional alias on a node without a dynamic combo`). So the adapted walk is pinned on both arms rather than merely compiling. - **Scope**: `#19979` only. The schema-v5 cutover ([#20096](#20096) + [cloud#11864](Comfy-Org/cloud#11864)), the other remedy named on BE-16625, is **not** in this PR. - **The gate's own scope is unchanged from `main` and is narrower than BE-16625.** A node with no `COMFY_DYNAMICCOMBO_V3` input still drops the value and still reports `agent_graph_widget_missing`. That exclusion arrived in `#19979` itself and is test-pinned there; measured against production it covers ~12% of sampled overflow events, with ~88% (kijai `inputcount` grow nodes, multi-slot component widgets, frontend-built widgets) deliberately out of scope. Whether to widen it is an open ruling on BE-16625, not part of this backport. ## Validation Run on this branch, against `origin/cloud/1.55` at `d163f330b2`. Re-confirmed at the rewritten head `7a6fddba1e`; the tree is provably unchanged by the rewrite, so the browser evidence below is content-identical. ``` pnpm typecheck # all 5 projects pass pnpm typecheck:browser # pass pnpm exec oxfmt --check # pass (4 touched files) pnpm exec oxlint --type-aware # clean eslint (touched files) # clean vitest src/workbench/extensions/agent/crdt/liveGraphApplier.test.ts → 45 passed vitest src/workbench/extensions/agent/crdt → 60 files, 851 passed, 2 expected fail ``` Both browser specs pass on this head and **fail on the parent** with base `liveGraphApplier.ts` swapped in — the same `mode.b` symptom `#19979` recorded (`71` expected, `70` received, the node-def default): ``` # head browser_tests/tests/agent/agentOverflowWidgetOnNodeCreate.spec.ts 1 passed browser_tests/tests/agent/agentDynamicComboSetWidgetSilentlyDropped.spec.ts 1 passed # parent applier (d163f33:liveGraphApplier.ts), specs unchanged 2 failed Expected: "71" Received: "70" ``` ```bash COMFYUI_PORT=8197 bash scripts/start-comfyui-e2e.sh VITE_USE_LEGACY_DEFAULT_GRAPH=true DISTRIBUTION=cloud \ DEV_SERVER_COMFYUI_URL=http://127.0.0.1:8197 pnpm dev --port 6200 --strictPort PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_SETUP_API_URL=http://localhost:8197 \ PLAYWRIGHT_TEST_URL=http://localhost:6200 DISTRIBUTION=cloud \ pnpm exec playwright test \ browser_tests/tests/agent/agentOverflowWidgetOnNodeCreate.spec.ts \ browser_tests/tests/agent/agentDynamicComboSetWidgetSilentlyDropped.spec.ts \ --project=cloud --workers=1 --retries=0 ``` Linear: https://linear.app/comfyorg/issue/BE-16625/widget-catalog-arity-mismatch-extra-n-positional-overflow-is-a --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
ELI5
Bring the merged DynamicGroup controls to
cloud/1.55, so Node 2.0 can add, remove, and restore repeated widget rows.Summary
Manual backport of #17441 — feat: support DynamicGroup widget inputs, source commit
11bf7a4dada248e848dae56790f87e82444ca346.Changes
dynamicTypesresolver. Keep the positional-restoration guard with local nested-input traversal because 1.55 does not contain main'sinputSpecTreerefactor. Cover both adaptations with tests.Review focus
This backports the original implementation only. Stabilization remains separate: #20181 — fix: propagate DynamicGroup row changes through nested promotions and #20285 — Redo history is cleared after Undo normalizes node size.
Real-backend coverage remains in #17510 — test: verify DynamicGroup in a dedicated backend E2E job; this PR adds no backend SHA override or native LoRA nodes.
Provenance