Repository navigation
[backport core/1.54] fix(litegraph): recover graph ID allocation safely (#19239) - #20237
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance
🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built🎭 Playwright: ✅ 1987 passed, 0 failed📊 Browser Reports
|
|
🔗 Commit SHA: 559b379 | Docs | View more details | Give us feedback! |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #20237 +/- ##
=============================================
- Coverage 84.42% 81.87% -2.55%
=============================================
Files 2125 2124 -1
Lines 127665 127067 -598
Branches 32528 32515 -13
=============================================
- Hits 107784 104039 -3745
- Misses 19693 22840 +3147
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 423 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ely (#19239) (#20241) ## Summary Backports the graph-ID allocation repair from [#19239](#19239) to `cloud/1.54` without importing unrelated clipboard and teardown behavior from newer release lines. ## Changes - allocate through `Number.MAX_SAFE_INTEGER` and wrap to an unused positive ID - preserve collision checks for nodes, links, groups, and reroutes - retain the disjoint node-ID range used by collaborative graphs - add the high-range workflow fixture and property coverage from the source fix This is the same release-compatible patch as [`core/1.54` PR #20237](#20237). It applied cleanly to `cloud/1.54`. ## Verification - allocation, subgraph deduplication, graph configuration, and entity-ID tests: 5 files, 199 tests passed - application typecheck passed - pre-push Knip passed Tracked by [FE-3007](https://linear.app/comfyorg/issue/FE-3007/e15-node-id-space-exhausted-explains-the-intermittent-cloud-copy-paste). Justification: release backport of the reviewed safe-ID fix, adapted to preserve 1.54-specific clipboard and teardown semantics.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
Summary
Backports the graph-ID allocation repair from #19239 to
core/1.54without importing unrelated clipboard and teardown behavior from newer release lines.Changes
Number.MAX_SAFE_INTEGERand wrap to an unused positive IDThe full 1.55 carrier does not apply safely to 1.54 because graph teardown and clipboard transaction behavior diverged. This carrier is limited to the allocation defect and its direct call sites.
Verification
Tracked by FE-3007.
Justification: release backport of the reviewed safe-ID fix, adapted to preserve 1.54-specific clipboard and teardown semantics.