Skip to content

[backport core/1.54] fix(litegraph): recover graph ID allocation safely (#19239) - #20237

Merged
christian-byrne merged 2 commits into
core/1.54from
bp19239-core154-v2
Oct 6, 2026
Merged

christian-byrne merged 2 commits into
core/1.54from
bp19239-core154-v2

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports the graph-ID allocation repair from #19239 to core/1.54 without importing unrelated clipboard and teardown behavior from newer release lines.

Changes

  • allocate through Number.MAX_SAFE_INTEGER and wrap to an unused positive ID
  • preserve collision checks for nodes, links, groups, and reroutes
  • retain the disjoint node-ID range used by collaborative graphs
  • add the high-range workflow fixture and property coverage from the source fix

The full 1.55 carrier does not apply safely to 1.54 because graph teardown and clipboard transaction behavior diverged. This carrier is limited to the allocation defect and its direct call sites.

Verification

  • allocation, subgraph deduplication, graph configuration, and entity-ID tests: 5 files, 199 tests passed
  • application typecheck passed
  • changed-file formatting and lint passed
  • pre-push Knip passed

Tracked by FE-3007.

Justification: release backport of the reviewed safe-ID fix, adapted to preserve 1.54-specific clipboard and teardown semantics.

@vercel

vercel Bot commented Oct 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 5, 2026 8:26pm UTC
billing-web-test Ignored Ignored Oct 5, 2026 8:26pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 105ab1f7-3344-494a-b7a8-fbb8c45e20a6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 5, 2026
@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL October 5, 2026 20:26
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance

⚠️ Performance tests failed. Check the CI workflow logs.

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 38214 72299 52.9% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 58.9% 1462
src/LGraphNode.ts 61.4% 495
src/composables/useLoad3d.ts 3.1% 463
src/LGraph.ts 68.5% 386
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/composables/useLoad3dViewer.ts 0.9% 326
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/renderer/glsl/useGLSLRenderer.ts 1.0% 288
src/Reroute.ts 3.1% 283

🎨 Storybook: ✅ Built

Details

⏰ Completed at: 10/05/2026, 09:03:47 PM UTC

Links

🎭 Playwright: ✅ 1987 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1966 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@datadog-official

datadog-official Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 559b379 | Docs | View more details | Give us feedback!

@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.21053% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/litegraph/src/idAllocation.ts 52.83% 25 Missing ⚠️
...ib/litegraph/src/subgraph/subgraphDeduplication.ts 85.29% 5 Missing ⚠️
src/lib/litegraph/src/LGraph.ts 50.00% 3 Missing ⚠️
src/lib/litegraph/src/LGraphCanvas.ts 50.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##           core/1.54   #20237      +/-   ##
=============================================
- Coverage      84.42%   81.87%   -2.55%     
=============================================
  Files           2125     2124       -1     
  Lines         127665   127067     -598     
  Branches       32528    32515      -13     
=============================================
- Hits          107784   104039    -3745     
- Misses         19693    22840    +3147     
  Partials         188      188              
Flag Coverage Δ
e2e 52.88% <64.21%> (-14.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraphCanvas.ts 58.94% <50.00%> (-8.12%) ⬇️
src/lib/litegraph/src/LGraph.ts 68.54% <50.00%> (-9.28%) ⬇️
...ib/litegraph/src/subgraph/subgraphDeduplication.ts 97.07% <85.29%> (-1.76%) ⬇️
src/lib/litegraph/src/idAllocation.ts 59.09% <52.83%> (-30.20%) ⬇️

... and 423 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 4a8fb35 into core/1.54 Oct 6, 2026
145 of 183 checks passed
@christian-byrne
christian-byrne deleted the bp19239-core154-v2 branch October 6, 2026 09:13
christian-byrne added a commit that referenced this pull request Oct 6, 2026
…ely (#19239) (#20241)

## Summary

Backports the graph-ID allocation repair from
[#19239](#19239) to
`cloud/1.54` without importing unrelated clipboard and teardown behavior
from newer release lines.

## Changes

- allocate through `Number.MAX_SAFE_INTEGER` and wrap to an unused
positive ID
- preserve collision checks for nodes, links, groups, and reroutes
- retain the disjoint node-ID range used by collaborative graphs
- add the high-range workflow fixture and property coverage from the
source fix

This is the same release-compatible patch as [`core/1.54` PR
#20237](#20237). It
applied cleanly to `cloud/1.54`.

## Verification

- allocation, subgraph deduplication, graph configuration, and entity-ID
tests: 5 files, 199 tests passed
- application typecheck passed
- pre-push Knip passed

Tracked by
[FE-3007](https://linear.app/comfyorg/issue/FE-3007/e15-node-id-space-exhausted-explains-the-intermittent-cloud-copy-paste).

Justification: release backport of the reviewed safe-ID fix, adapted to
preserve 1.54-specific clipboard and teardown semantics.
@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation failed to run (abandoned).

Evaluation budget remaining for this pull request: 99 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants