Skip to content

[backport cloud/1.54] fix(litegraph): recover graph ID allocation safely (#19239) - #20241

Merged
christian-byrne merged 2 commits into
cloud/1.54from
bp19239-cloud154-v2
Oct 6, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
bp19239-cloud154-v2

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports the graph-ID allocation repair from #19239 to cloud/1.54 without importing unrelated clipboard and teardown behavior from newer release lines.

Changes

  • allocate through Number.MAX_SAFE_INTEGER and wrap to an unused positive ID
  • preserve collision checks for nodes, links, groups, and reroutes
  • retain the disjoint node-ID range used by collaborative graphs
  • add the high-range workflow fixture and property coverage from the source fix

This is the same release-compatible patch as core/1.54 PR #20237. It applied cleanly to cloud/1.54.

Verification

  • allocation, subgraph deduplication, graph configuration, and entity-ID tests: 5 files, 199 tests passed
  • application typecheck passed
  • pre-push Knip passed

Tracked by FE-3007.

Justification: release backport of the reviewed safe-ID fix, adapted to preserve 1.54-specific clipboard and teardown semantics.

@vercel

vercel Bot commented Oct 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 5, 2026 8:30pm UTC
billing-web-test Ignored Ignored Oct 5, 2026 8:30pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 255b0c8e-3cc7-4d94-95c4-419710cf6ff6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 5, 2026
@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL October 5, 2026 20:31
@datadog-official

datadog-official Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f6f0808 | Docs | View more details | Give us feedback!

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 63ms TBT · 101.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 175.1 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 177.5 MB heap
vue-node-resize-workload: · 59.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 3ms TBT · 175.6 MB heap
vue-zoom-out-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 174.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 5ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 279ms
canvas-idle: script duration 6ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.1 MB
canvas-idle: DOM nodes -131
canvas-idle: event listeners -94
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 22ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 533ms
canvas-mouse-sweep: script duration 92ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.5 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -177
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 11ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 216ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 75.0 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 276ms
dom-widget-clipping: script duration 96ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 73.4 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 357ms
large-graph-idle: script duration 24ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 76.7 MB
large-graph-idle: DOM nodes -283
large-graph-idle: event listeners -191
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1020ms
large-graph-pan: script duration 517ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 77.6 MB
large-graph-pan: DOM nodes -284
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1101ms
large-graph-zoom: script duration 495ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.8 MB
large-graph-zoom: DOM nodes -110
large-graph-zoom: event listeners -93
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1215ms
legacy-node-drag: script duration 625ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.7 MB
legacy-node-drag: DOM nodes 12
legacy-node-drag: event listeners 185
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 332ms
minimap-idle: script duration 24ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.3 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -192
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 256ms
subgraph-dom-widget-clipping: script duration 88ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.9 MB
subgraph-dom-widget-clipping: DOM nodes 22
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 283ms
subgraph-idle: script duration 5ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.4 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -223
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 23ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 561ms
subgraph-mouse-sweep: script duration 79ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.0 MB
subgraph-mouse-sweep: DOM nodes -281
subgraph-mouse-sweep: event listeners -209
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 591ms
subgraph-transition-enter: script duration 20ms
subgraph-transition-enter: TBT 63ms
subgraph-transition-enter: heap used 101.1 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 3849ms
viewport-pan-sweep: script duration 1946ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 72.2 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10961ms
vue-large-graph-idle: script duration 159ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 175.1 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 12ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 69
vue-large-graph-pan: task duration 13509ms
vue-large-graph-pan: script duration 599ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 177.5 MB
vue-large-graph-pan: DOM nodes -8070
vue-large-graph-pan: event listeners -14933
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 19ms
vue-node-resize-workload: style recalc duration 51ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 3930ms
vue-node-resize-workload: script duration 65ms
vue-node-resize-workload: TBT 3ms
vue-node-resize-workload: heap used 175.6 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5100ms
vue-zoom-out-idle: script duration 71ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 174.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -8
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 12ms
workflow-execution: layout count 3
workflow-execution: style recalc count 10
workflow-execution: task duration 61ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 72.3 MB
workflow-execution: DOM nodes 112
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-10-05T21:02:54.121Z",
  "gitSha": "4110e3cc1ed8e714f25688ee4a85d9bdc7656bc5",
  "branch": "bp19239-cloud154-v2",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2004.224000000022,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.150000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 307.72600000000006,
      "heapDeltaBytes": -10619024,
      "heapUsedBytes": 59942564,
      "domNodes": -280,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 5.640000000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 1997.965000000022,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.098,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 251.205,
      "heapDeltaBytes": -493952,
      "heapUsedBytes": 63996376,
      "domNodes": 18,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 6.370999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1677.5540000000433,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 19.658,
      "layouts": 14,
      "layoutDurationMs": 3.4189999999999996,
      "taskDurationMs": 496.171,
      "heapDeltaBytes": -10939624,
      "heapUsedBytes": 62968420,
      "domNodes": -281,
      "jsHeapTotalBytes": 3178496,
      "scriptDurationMs": 84.859,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1735.7660000000124,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 24.195999999999998,
      "layouts": 14,
      "layoutDurationMs": 3.6949999999999994,
      "taskDurationMs": 569.195,
      "heapDeltaBytes": -3061120,
      "heapUsedBytes": 70252780,
      "domNodes": -278,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 99.15099999999998,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.9479999999971,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 10.931000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.066,
      "taskDurationMs": 208.83400000000003,
      "heapDeltaBytes": 4972436,
      "heapUsedBytes": 78175480,
      "domNodes": 75,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 8.018,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1659.4400000000178,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 11.837,
      "layouts": 6,
      "layoutDurationMs": 1.0370000000000001,
      "taskDurationMs": 223.64000000000001,
      "heapDeltaBytes": 5003676,
      "heapUsedBytes": 79147360,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 8.899000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 426.23799999995526,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 6.777000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 269.24800000000005,
      "heapDeltaBytes": 18217916,
      "heapUsedBytes": 89544708,
      "domNodes": 22,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 93.262,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 427.8759999999693,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 7.5489999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 283.003,
      "heapDeltaBytes": -8855684,
      "heapUsedBytes": 64468136,
      "domNodes": 22,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 98.191,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.9490000000296,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.723999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 341.6310000000001,
      "heapDeltaBytes": 12714520,
      "heapUsedBytes": 90468084,
      "domNodes": -283,
      "jsHeapTotalBytes": -106496,
      "scriptDurationMs": 20.974,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2007.649000000015,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.269999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 372.04,
      "heapDeltaBytes": -10710224,
      "heapUsedBytes": 70359232,
      "domNodes": -282,
      "jsHeapTotalBytes": -1277952,
      "scriptDurationMs": 26.032000000000007,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2150.443999999993,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.59,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1025.934,
      "heapDeltaBytes": -2436272,
      "heapUsedBytes": 77512184,
      "domNodes": -282,
      "jsHeapTotalBytes": 3526656,
      "scriptDurationMs": 523.712,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2113.209999999981,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.982999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1013.531,
      "heapDeltaBytes": 6307524,
      "heapUsedBytes": 85184300,
      "domNodes": -285,
      "jsHeapTotalBytes": -1191936,
      "scriptDurationMs": 510.59900000000005,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3171.7409999999973,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 14.575000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.433,
      "taskDurationMs": 1121.301,
      "heapDeltaBytes": -9709612,
      "heapUsedBytes": 72091072,
      "domNodes": -260,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 501.772,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3106.262999999956,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 15.626000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.689,
      "taskDurationMs": 1081.1989999999998,
      "heapDeltaBytes": 1041804,
      "heapUsedBytes": 80494588,
      "domNodes": 40,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 488.606,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2184.1329999999743,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.195,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1164.8860000000002,
      "heapDeltaBytes": 4494796,
      "heapUsedBytes": 73860344,
      "domNodes": 10,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 611.567,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2283.2930000000147,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.449000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1264.8570000000002,
      "heapDeltaBytes": 14773520,
      "heapUsedBytes": 97410872,
      "domNodes": 14,
      "jsHeapTotalBytes": 5922816,
      "scriptDurationMs": 637.614,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.0740000000028,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.920999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 341.7129999999999,
      "heapDeltaBytes": -11575928,
      "heapUsedBytes": 70743992,
      "domNodes": -276,
      "jsHeapTotalBytes": -2588672,
      "scriptDurationMs": 23.619999999999997,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.105000000015,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.672999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 323.232,
      "heapDeltaBytes": -2971872,
      "heapUsedBytes": 76652572,
      "domNodes": -270,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 24.023999999999997,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 380.675999999994,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.591,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 251.14800000000002,
      "heapDeltaBytes": 14000880,
      "heapUsedBytes": 89542240,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 86.426,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 393.29799999995885,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 9.925,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 260.529,
      "heapDeltaBytes": 14882988,
      "heapUsedBytes": 88446960,
      "domNodes": 24,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 88.615,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1992.2070000000076,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.302,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 277.21799999999996,
      "heapDeltaBytes": -6780376,
      "heapUsedBytes": 69112500,
      "domNodes": -296,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 4.689,
      "eventListeners": -238,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2026.8179999999916,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.823,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 287.95,
      "heapDeltaBytes": -15342472,
      "heapUsedBytes": 59591172,
      "domNodes": -296,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 5.558999999999999,
      "eventListeners": -208,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.5000000000246,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 20.933,
      "layouts": 18,
      "layoutDurationMs": 4.36,
      "taskDurationMs": 501.43499999999995,
      "heapDeltaBytes": -12808320,
      "heapUsedBytes": 63118680,
      "domNodes": -297,
      "jsHeapTotalBytes": 3178496,
      "scriptDurationMs": 71.101,
      "eventListeners": -208,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1690.2499999999918,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 25.183,
      "layouts": 18,
      "layoutDurationMs": 4.7749999999999995,
      "taskDurationMs": 619.58,
      "heapDeltaBytes": -4157120,
      "heapUsedBytes": 68999776,
      "domNodes": -265,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 87.448,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 816.8040000000474,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 22.398999999999994,
      "layouts": 16,
      "layoutDurationMs": 10.696,
      "taskDurationMs": 591.264,
      "heapDeltaBytes": 22061936,
      "heapUsedBytes": 105976756,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 19.889999999999997,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 63,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8204.568999999992,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.119,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3770.976,
      "heapDeltaBytes": 5817516,
      "heapUsedBytes": 82856032,
      "domNodes": -284,
      "jsHeapTotalBytes": 643072,
      "scriptDurationMs": 1917.6840000000002,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8236.647999999946,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.614999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3927.602,
      "heapDeltaBytes": -12224592,
      "heapUsedBytes": 68496588,
      "domNodes": -267,
      "jsHeapTotalBytes": -1015808,
      "scriptDurationMs": 1973.663,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12086.792000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11464.939,
      "heapDeltaBytes": -32301072,
      "heapUsedBytes": 187275148,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13119488,
      "scriptDurationMs": 168.65800000000002,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11274.80700000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10456.932000000003,
      "heapDeltaBytes": -33575540,
      "heapUsedBytes": 179886024,
      "domNodes": -8068,
      "jsHeapTotalBytes": -22462464,
      "scriptDurationMs": 148.531,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14163.796999999988,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.900000000000022,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13640.921,
      "heapDeltaBytes": -20116412,
      "heapUsedBytes": 185797284,
      "domNodes": -8072,
      "jsHeapTotalBytes": -8663040,
      "scriptDurationMs": 605.983,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14155.801999999994,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 12.211,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13378.013,
      "heapDeltaBytes": -50195504,
      "heapUsedBytes": 186444312,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19689472,
      "scriptDurationMs": 592.971,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4122.010999999986,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 50.979,
      "layouts": 20,
      "layoutDurationMs": 19.935999999999996,
      "taskDurationMs": 4011.012000000001,
      "heapDeltaBytes": -53900036,
      "heapUsedBytes": 179629524,
      "domNodes": -8068,
      "jsHeapTotalBytes": 15302656,
      "scriptDurationMs": 66.105,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3984.1499999999996,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 50.83299999999999,
      "layouts": 20,
      "layoutDurationMs": 18.479000000000003,
      "taskDurationMs": 3849.2980000000007,
      "heapDeltaBytes": -24363336,
      "heapUsedBytes": 188581648,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12419072,
      "scriptDurationMs": 64.21199999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5561.937,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5257.902,
      "heapDeltaBytes": 7585420,
      "heapUsedBytes": 180538432,
      "domNodes": 0,
      "jsHeapTotalBytes": -24641536,
      "scriptDurationMs": 76.07999999999998,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5302.0930000000135,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4941.682,
      "heapDeltaBytes": 13673540,
      "heapUsedBytes": 185378620,
      "domNodes": 0,
      "jsHeapTotalBytes": -14417920,
      "scriptDurationMs": 65.61,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 422.3039999999969,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 16.011,
      "layouts": 3,
      "layoutDurationMs": 0.7310000000000001,
      "taskDurationMs": 79.971,
      "heapDeltaBytes": 4889248,
      "heapUsedBytes": 76652372,
      "domNodes": 122,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 7.376000000000002,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 65.07199999998647,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 8.205999999999998,
      "layouts": 2,
      "layoutDurationMs": 0.6330000000000001,
      "taskDurationMs": 42.681,
      "heapDeltaBytes": 2993456,
      "heapUsedBytes": 74927168,
      "domNodes": 102,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 3.039,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51128 76616 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

🎭 Playwright: ✅ 1989 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1968 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.23853% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/litegraph/src/idAllocation.ts 79.24% 11 Missing ⚠️
src/lib/litegraph/src/LGraph.ts 66.66% 2 Missing ⚠️
src/lib/litegraph/src/LGraphCanvas.ts 50.00% 1 Missing ⚠️
...ib/litegraph/src/subgraph/subgraphDeduplication.ts 97.91% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #20241   +/-   ##
=============================================
  Coverage              ?   84.28%           
=============================================
  Files                 ?     2131           
  Lines                 ?   128298           
  Branches              ?    32653           
=============================================
  Hits                  ?   108134           
  Misses                ?    19983           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.78% <80.00%> (?)
unit 79.61% <97.72%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraphCanvas.ts 67.05% <50.00%> (ø)
...ib/litegraph/src/subgraph/subgraphDeduplication.ts 98.81% <97.91%> (ø)
src/lib/litegraph/src/LGraph.ts 77.83% <66.66%> (ø)
src/lib/litegraph/src/idAllocation.ts 81.81% <79.24%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit b46b46d into cloud/1.54 Oct 6, 2026
118 of 141 checks passed
@christian-byrne
christian-byrne deleted the bp19239-cloud154-v2 branch October 6, 2026 09:13
@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation failed to run (abandoned).

Evaluation budget remaining for this pull request: 99 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants