Skip to content

[backport cloud/1.54] fix: close cancellation reconciliation review gaps (#20133) - #20162

Merged
christian-byrne merged 10 commits into
cloud/1.54from
backport-20133-cloud-1.54
Oct 5, 2026
Merged

christian-byrne merged 10 commits into
cloud/1.54from
backport-20133-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #20133 to this release branch.\n\nThis carries the reviewed cancellation/reconciliation hardening, bounded terminal markers, stale upload isolation, and export-download URL validation. Release-specific API imports and cloud URL behavior are preserved where applicable.\n\nValidation: the canonical change passed the focused 74-test suite (plus one expected failure), typecheck, and browser coverage. This PR is also running the target branch CI.

Follow-up to #20031 and its release backports. This closes the
post-merge review gaps by:

- tombstoning dismissed pending downloads so late WebSocket frames
cannot reopen the toast, while still refreshing model caches after a
hidden completion
- settling malformed authoritative completions instead of polling
forever
- confirming DELETE 404 outcomes without falsely presenting a
still-running task as cancelled
- bounding task-not-found reconciliation and stopping unconfirmed
cancellation polling
- preserving late export names, validating export URL schemes, and
retrying transient export 404s
- preventing async upload watchers from outliving reset/disposal

- Targeted Vitest: 74 passed, 1 expected failure
- App typecheck
- Targeted lint: 0 errors
- Diff whitespace check

Closes the actionable review findings raised on #20044, #20047, #20048,
and #20049.
@vercel

vercel Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 5, 2026 10:08am UTC
billing-web-test Ignored Ignored Oct 5, 2026 10:08am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 448c5f51-77ef-40cc-bfab-3217fa40beee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned) labels Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1991 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1970 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/05/2026, 10:10:03 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 97ms TBT · 101.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 187.3 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 7ms TBT · 172.1 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 231ms TBT · 173.4 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 417ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.0 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 25ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 746ms
canvas-mouse-sweep: script duration 128ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.8 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -164
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 289ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 74.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 375ms
dom-widget-clipping: script duration 132ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 61.6 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 429ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.4 MB
large-graph-idle: DOM nodes -137
large-graph-idle: event listeners -94
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1290ms
large-graph-pan: script duration 647ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 75.5 MB
large-graph-pan: DOM nodes -276
large-graph-pan: event listeners -175
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1420ms
large-graph-zoom: script duration 635ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.3 MB
large-graph-zoom: DOM nodes -262
large-graph-zoom: event listeners -196
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1507ms
legacy-node-drag: script duration 773ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.3 MB
legacy-node-drag: DOM nodes 9
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 468ms
minimap-idle: script duration 28ms
minimap-idle: TBT 0ms
minimap-idle: heap used 78.0 MB
minimap-idle: DOM nodes -287
minimap-idle: event listeners -190
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 328ms
subgraph-dom-widget-clipping: script duration 112ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.5 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 395ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.9 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -242
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 23ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 665ms
subgraph-mouse-sweep: script duration 88ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.8 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -241
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 727ms
subgraph-transition-enter: script duration 22ms
subgraph-transition-enter: TBT 97ms
subgraph-transition-enter: heap used 101.3 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4560ms
viewport-pan-sweep: script duration 2206ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.3 MB
viewport-pan-sweep: DOM nodes -275
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14551ms
vue-large-graph-idle: script duration 228ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 187.3 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 132
vue-large-graph-pan: task duration 17378ms
vue-large-graph-pan: script duration 749ms
vue-large-graph-pan: TBT 7ms
vue-large-graph-pan: heap used 172.1 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14931
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 59ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5319ms
vue-node-resize-workload: script duration 87ms
vue-node-resize-workload: TBT 231ms
vue-node-resize-workload: heap used 173.4 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7316ms
vue-zoom-out-idle: script duration 112ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 78ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 71.5 MB
workflow-execution: DOM nodes 138
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-10-05T10:18:34.325Z",
  "gitSha": "cc7b07bfb5b02d8b7495b5fc792a54b0f15f8b9e",
  "branch": "backport-20133-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2029.0860000000066,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.805999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.968,
      "heapDeltaBytes": -15723856,
      "heapUsedBytes": 58349244,
      "domNodes": -282,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 8.674000000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.8870000000688,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.476999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.28600000000006,
      "heapDeltaBytes": -5519032,
      "heapUsedBytes": 65358840,
      "domNodes": -279,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.220999999999998,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1776.0269999999991,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 25.908,
      "layouts": 14,
      "layoutDurationMs": 3.9090000000000003,
      "taskDurationMs": 797.644,
      "heapDeltaBytes": -14125956,
      "heapUsedBytes": 59153276,
      "domNodes": -283,
      "jsHeapTotalBytes": 5537792,
      "scriptDurationMs": 137.595,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1705.8279999999968,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 23.902,
      "layouts": 14,
      "layoutDurationMs": 3.5390000000000006,
      "taskDurationMs": 694.909,
      "heapDeltaBytes": 9184480,
      "heapUsedBytes": 82940908,
      "domNodes": -279,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 117.95100000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.6630000000914,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.481,
      "layouts": 6,
      "layoutDurationMs": 1.0119999999999998,
      "taskDurationMs": 283.93399999999997,
      "heapDeltaBytes": 4903144,
      "heapUsedBytes": 78106180,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.544999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.214999999972,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.385,
      "layouts": 6,
      "layoutDurationMs": 1.054,
      "taskDurationMs": 293.382,
      "heapDeltaBytes": 4873012,
      "heapUsedBytes": 77976520,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.991000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 525.4820000000109,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 7.682999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.45399999999995,
      "heapDeltaBytes": -7288164,
      "heapUsedBytes": 65823128,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 126.897,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 551.2929999999869,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 8.041999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 376.188,
      "heapDeltaBytes": -8419512,
      "heapUsedBytes": 63287340,
      "domNodes": 22,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 136.296,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2005.8500000000095,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.366,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.38599999999997,
      "heapDeltaBytes": 11534480,
      "heapUsedBytes": 89094756,
      "domNodes": -282,
      "jsHeapTotalBytes": 155648,
      "scriptDurationMs": 30.649,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 1994.4590000000062,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.893,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.74300000000005,
      "heapDeltaBytes": 11510640,
      "heapUsedBytes": 77491888,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.133999999999993,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2165.4930000000263,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.466,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1327.076,
      "heapDeltaBytes": 8391924,
      "heapUsedBytes": 89799708,
      "domNodes": -286,
      "jsHeapTotalBytes": -528384,
      "scriptDurationMs": 658.061,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2145.006999999964,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 11.931000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1252.054,
      "heapDeltaBytes": -10706284,
      "heapUsedBytes": 68619416,
      "domNodes": -266,
      "jsHeapTotalBytes": -892928,
      "scriptDurationMs": 636.5809999999999,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3240.0840000000244,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 15.420000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.171999999999999,
      "taskDurationMs": 1431.762,
      "heapDeltaBytes": -4259708,
      "heapUsedBytes": 75566168,
      "domNodes": -262,
      "jsHeapTotalBytes": 4087808,
      "scriptDurationMs": 638.1320000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3174.9730000000227,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 14.476,
      "layouts": 60,
      "layoutDurationMs": 11.687,
      "taskDurationMs": 1407.8240000000003,
      "heapDeltaBytes": -8709944,
      "heapUsedBytes": 74002648,
      "domNodes": -262,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 632.494,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2559.032000000002,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 6.888000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1531.011,
      "heapDeltaBytes": 3614028,
      "heapUsedBytes": 73528848,
      "domNodes": 6,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 798.7800000000001,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2258.9980000000196,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.086,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1483.898,
      "heapDeltaBytes": 10311696,
      "heapUsedBytes": 92792128,
      "domNodes": 12,
      "jsHeapTotalBytes": 6184960,
      "scriptDurationMs": 747.703,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2013.146000000006,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.361000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.239,
      "heapDeltaBytes": 12704800,
      "heapUsedBytes": 92813016,
      "domNodes": -286,
      "jsHeapTotalBytes": -892928,
      "scriptDurationMs": 28.176999999999992,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.1080000000693,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.048000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.581,
      "heapDeltaBytes": -11579872,
      "heapUsedBytes": 70718260,
      "domNodes": -287,
      "jsHeapTotalBytes": -2326528,
      "scriptDurationMs": 28.473000000000006,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 530.0550000000612,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.688999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 320.623,
      "heapDeltaBytes": 14971276,
      "heapUsedBytes": 88543876,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 110.383,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 538.964999999962,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.604000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 334.414,
      "heapDeltaBytes": -10517072,
      "heapUsedBytes": 65520012,
      "domNodes": 22,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 114.063,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.8440000000105,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.7940000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.844,
      "heapDeltaBytes": -11093784,
      "heapUsedBytes": 62343900,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.305000000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.9009999999844,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.334000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.16499999999996,
      "heapDeltaBytes": -4472336,
      "heapUsedBytes": 71606624,
      "domNodes": -299,
      "jsHeapTotalBytes": 4489216,
      "scriptDurationMs": 6.6469999999999985,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1691.9520000000148,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 23.657000000000004,
      "layouts": 18,
      "layoutDurationMs": 4.533,
      "taskDurationMs": 671.28,
      "heapDeltaBytes": -6107916,
      "heapUsedBytes": 69857880,
      "domNodes": -298,
      "jsHeapTotalBytes": 5275648,
      "scriptDurationMs": 89.585,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1688.9250000000402,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 22.271,
      "layouts": 18,
      "layoutDurationMs": 3.8910000000000005,
      "taskDurationMs": 658.687,
      "heapDeltaBytes": -9073952,
      "heapUsedBytes": 63847156,
      "domNodes": -293,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 86.149,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 900.3979999999956,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 25.895000000000007,
      "layouts": 16,
      "layoutDurationMs": 11.761000000000003,
      "taskDurationMs": 727.1109999999999,
      "heapDeltaBytes": 24645412,
      "heapUsedBytes": 106220648,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 21.95799999999999,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 97,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8222.988999999983,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.523,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4696.286000000001,
      "heapDeltaBytes": -9088236,
      "heapUsedBytes": 71272624,
      "domNodes": -268,
      "jsHeapTotalBytes": -1540096,
      "scriptDurationMs": 2296.442,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8191.26899999992,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.21099999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4423.478,
      "heapDeltaBytes": 4370984,
      "heapUsedBytes": 82345244,
      "domNodes": -282,
      "jsHeapTotalBytes": 380928,
      "scriptDurationMs": 2115.9,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14857.274999999958,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14469.571,
      "heapDeltaBytes": -20324860,
      "heapUsedBytes": 198393924,
      "domNodes": -8068,
      "jsHeapTotalBytes": -6115328,
      "scriptDurationMs": 221.605,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15068.114000000038,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14632.334,
      "heapDeltaBytes": -12781328,
      "heapUsedBytes": 194473428,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12333056,
      "scriptDurationMs": 234.844,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17462.81799999997,
      "styleRecalcs": 134,
      "styleRecalcDurationMs": 14.856999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17126.965000000004,
      "heapDeltaBytes": -27891856,
      "heapUsedBytes": 190544232,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13946880,
      "scriptDurationMs": 736.057,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 7,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17821.124000000054,
      "styleRecalcs": 129,
      "styleRecalcDurationMs": 17.49400000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17629.241,
      "heapDeltaBytes": -64280872,
      "heapUsedBytes": 170296012,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17498112,
      "scriptDurationMs": 761.579,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 7,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5273.570000000063,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 58.870000000000005,
      "layouts": 20,
      "layoutDurationMs": 20.103999999999996,
      "taskDurationMs": 5192.707999999999,
      "heapDeltaBytes": -51541836,
      "heapUsedBytes": 178518192,
      "domNodes": -8068,
      "jsHeapTotalBytes": 6115328,
      "scriptDurationMs": 85.491,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 217,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5506.481000000008,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.01999999999999,
      "layouts": 20,
      "layoutDurationMs": 22.287000000000003,
      "taskDurationMs": 5445.196,
      "heapDeltaBytes": -29326708,
      "heapUsedBytes": 185039784,
      "domNodes": -8068,
      "jsHeapTotalBytes": 20189184,
      "scriptDurationMs": 88.86999999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 245,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7392.592000000036,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7239.642,
      "heapDeltaBytes": 24716792,
      "heapUsedBytes": 194116388,
      "domNodes": 0,
      "jsHeapTotalBytes": -24641536,
      "scriptDurationMs": 109.89200000000004,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7526.652999999897,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7391.697000000001,
      "heapDeltaBytes": -3397452,
      "heapUsedBytes": 165922388,
      "domNodes": 0,
      "jsHeapTotalBytes": -27262976,
      "scriptDurationMs": 114.88899999999997,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 452.77600000008533,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 18.509999999999998,
      "layouts": 4,
      "layoutDurationMs": 1.6229999999999998,
      "taskDurationMs": 98.20300000000002,
      "heapDeltaBytes": 5170448,
      "heapUsedBytes": 74842448,
      "domNodes": 149,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.624,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 93.37100000004739,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 10.823,
      "layouts": 2,
      "layoutDurationMs": 0.9310000000000002,
      "taskDurationMs": 57.409,
      "heapDeltaBytes": 2987236,
      "heapUsedBytes": 75075864,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.092999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51110 76576 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 2
🟡 Medium 4
🟢 Low 4

Panel: 8/8 reviewers contributed findings.

Comment thread src/stores/assetExportStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetExportStore.ts Resolved
@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.29536% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/stores/assetExportStore.ts 86.30% 10 Missing ⚠️
...latform/assets/composables/useUploadModelWizard.ts 89.04% 8 Missing ⚠️
src/stores/assetDownloadStore.ts 94.50% 5 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #20162   +/-   ##
=============================================
  Coverage              ?   84.28%           
=============================================
  Files                 ?     2131           
  Lines                 ?   128261           
  Branches              ?    34834           
=============================================
  Hits                  ?   108109           
  Misses                ?    19971           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.79% <23.80%> (?)
unit 79.61% <93.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/stores/assetDownloadStore.ts 95.48% <94.50%> (ø)
...latform/assets/composables/useUploadModelWizard.ts 81.00% <89.04%> (ø)
src/stores/assetExportStore.ts 93.24% <86.30%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 79f04c8 into cloud/1.54 Oct 5, 2026
96 checks passed
@christian-byrne
christian-byrne deleted the backport-20133-cloud-1.54 branch October 5, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants