Skip to content

[backport cloud/1.54] fix: harden task cancellation reconciliation (#20031) - #20049

Merged
christian-byrne merged 3 commits into
cloud/1.54from
backport-20031-cloud-1.54
Oct 4, 2026
Merged

christian-byrne merged 3 commits into
cloud/1.54from
backport-20031-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #20031 to cloud/1.54.

This adapts the canonical cancellation hardening to the branch's validated WebSocket schemas and root-relative export URL behavior. It adds bounded and serialized reconciliation, terminal-state preservation, dismissible unconfirmed cancellations, upload-watcher isolation, and regression coverage.

Validation:

  • focused Vitest suite: 93 passed, 1 expected failure
  • pnpm typecheck:app

- bound cancelled-task reconciliation and validate task statuses/results
before restoring state
- keep download/export cancellation rendering and close behavior
consistent while polling is in flight
- stop upload-wizard watchers when their owning scope is disposed
- preserve export download URL behavior while adding regression coverage
for malformed, mixed-shape, cancelled, and stale task responses

This lands the hardening identified during the final review of #19858
(the `core/1.55` backport of #19281) on `main` first so release branches
can consume it through normal backports.

- `pnpm vitest run src/stores/assetDownloadStore.test.ts
src/stores/assetExportStore.test.ts
src/platform/tasks/services/taskService.test.ts
src/platform/assets/components/ModelImportProgressDialog.test.ts
src/platform/assets/components/AssetExportProgressDialog.test.ts
src/platform/assets/composables/useUploadModelWizard.test.ts` (85
passed, 1 expected failure)
- `pnpm typecheck:app`
- `pnpm typecheck:browser`
- targeted `oxfmt --check`
- pre-push `knip` and changed-file `fallow audit`
@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 3, 2026 11:30pm UTC
billing-web-test Ignored Ignored Oct 3, 2026 11:30pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: f2aec755-d5ac-40a6-9a10-f6f88822acd5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/03/2026, 11:32:20 PM UTC

Links

🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1969 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 96ms TBT · 81.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.7 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.6 MB heap
vue-large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 32ms TBT · 168.5 MB heap
vue-node-resize-workload: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 28ms TBT · 172.0 MB heap
vue-zoom-out-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 379ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.8 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -197
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 19ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 636ms
canvas-mouse-sweep: script duration 96ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 68.3 MB
canvas-mouse-sweep: DOM nodes -278
canvas-mouse-sweep: event listeners -193
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 11ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 250ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.3 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 314ms
dom-widget-clipping: script duration 104ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 62.0 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 376ms
large-graph-idle: script duration 24ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 73.3 MB
large-graph-idle: DOM nodes -266
large-graph-idle: event listeners -77
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1108ms
large-graph-pan: script duration 540ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 64.9 MB
large-graph-pan: DOM nodes -138
large-graph-pan: event listeners -92
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 70
large-graph-zoom: task duration 1137ms
large-graph-zoom: script duration 485ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 67.5 MB
large-graph-zoom: DOM nodes -117
large-graph-zoom: event listeners -79
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1235ms
legacy-node-drag: script duration 600ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 78.3 MB
legacy-node-drag: DOM nodes 10
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 409ms
minimap-idle: script duration 29ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.3 MB
minimap-idle: DOM nodes -277
minimap-idle: event listeners -191
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 273ms
subgraph-dom-widget-clipping: script duration 86ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.1 MB
subgraph-dom-widget-clipping: DOM nodes 22
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 5ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 368ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 73.9 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -226
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 18ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 596ms
subgraph-mouse-sweep: script duration 70ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.3 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -240
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 9ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 621ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 96ms
subgraph-transition-enter: heap used 81.6 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 31ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3762ms
viewport-pan-sweep: script duration 1733ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 75.7 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -176
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10322ms
vue-large-graph-idle: script duration 152ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 173.6 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14935
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 68
vue-large-graph-pan: task duration 13194ms
vue-large-graph-pan: script duration 709ms
vue-large-graph-pan: TBT 32ms
vue-large-graph-pan: heap used 168.5 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14932
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 53ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 3789ms
vue-node-resize-workload: script duration 62ms
vue-node-resize-workload: TBT 28ms
vue-node-resize-workload: heap used 172.0 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14932
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5064ms
vue-zoom-out-idle: script duration 87ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -9
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 17
workflow-execution: task duration 88ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.8 MB
workflow-execution: DOM nodes 135
workflow-execution: event listeners 65
Raw data
{
  "timestamp": "2026-10-03T23:40:20.474Z",
  "gitSha": "1344e740dabb5cd43a31fa8863c8597b5666297f",
  "branch": "backport-20031-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2041.6470000000118,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.1880000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 389.76500000000004,
      "heapDeltaBytes": -13761448,
      "heapUsedBytes": 59377940,
      "domNodes": -283,
      "jsHeapTotalBytes": 3706880,
      "scriptDurationMs": 7.247,
      "eventListeners": -197,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2026.495999999952,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.356000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.257,
      "heapDeltaBytes": -2917420,
      "heapUsedBytes": 68160372,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.454999999999998,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1771.282000000042,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 19.980999999999998,
      "layouts": 14,
      "layoutDurationMs": 3.1060000000000003,
      "taskDurationMs": 669.747,
      "heapDeltaBytes": -3731184,
      "heapUsedBytes": 69548932,
      "domNodes": -278,
      "jsHeapTotalBytes": 3706880,
      "scriptDurationMs": 97.40400000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1703.598999999997,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 17.133000000000003,
      "layouts": 14,
      "layoutDurationMs": 2.6879999999999997,
      "taskDurationMs": 601.579,
      "heapDeltaBytes": 2418292,
      "heapUsedBytes": 73760968,
      "domNodes": -278,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 94.331,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.3279999999713,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 10.959,
      "layouts": 6,
      "layoutDurationMs": 1.0839999999999999,
      "taskDurationMs": 248.83299999999997,
      "heapDeltaBytes": 3643480,
      "heapUsedBytes": 68263404,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 9.055999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.8749999999682,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 10.406,
      "layouts": 6,
      "layoutDurationMs": 0.9130000000000001,
      "taskDurationMs": 251.952,
      "heapDeltaBytes": 4769956,
      "heapUsedBytes": 79089912,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 8.948999999999998,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 517.3879999999826,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 5.474,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 319.036,
      "heapDeltaBytes": -7170928,
      "heapUsedBytes": 66489564,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 105.80999999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 510.91800000000376,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 5.6160000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 309.199,
      "heapDeltaBytes": -7820808,
      "heapUsedBytes": 63431068,
      "domNodes": 22,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 102.492,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2016.300000000001,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.2379999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.59700000000004,
      "heapDeltaBytes": 11211792,
      "heapUsedBytes": 76699712,
      "domNodes": -268,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 23.376999999999995,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2013.009000000011,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.820000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.508,
      "heapDeltaBytes": -344872,
      "heapUsedBytes": 76927992,
      "domNodes": -264,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 25.558999999999997,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2156.544999999994,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 11.499,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1139.526,
      "heapDeltaBytes": -9596140,
      "heapUsedBytes": 68394108,
      "domNodes": -284,
      "jsHeapTotalBytes": 3829760,
      "scriptDurationMs": 546.364,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2092.195000000004,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.687999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1076.819,
      "heapDeltaBytes": 1207280,
      "heapUsedBytes": 67608312,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 532.934,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3065.9560000000283,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 10.575000000000001,
      "layouts": 60,
      "layoutDurationMs": 9.478,
      "taskDurationMs": 1074.937,
      "heapDeltaBytes": 50176,
      "heapUsedBytes": 67754540,
      "domNodes": 32,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 468.058,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3185.8869999999797,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 13.225000000000001,
      "layouts": 60,
      "layoutDurationMs": 10.945,
      "taskDurationMs": 1198.309,
      "heapDeltaBytes": -5988672,
      "heapUsedBytes": 73733820,
      "domNodes": -265,
      "jsHeapTotalBytes": 4091904,
      "scriptDurationMs": 501.7969999999999,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2122.6970000000165,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 5.731999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1191.0850000000003,
      "heapDeltaBytes": 2455652,
      "heapUsedBytes": 69823988,
      "domNodes": 6,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 574.032,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2204.962999999964,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.193000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1279.8909999999998,
      "heapDeltaBytes": 9754444,
      "heapUsedBytes": 94298676,
      "domNodes": 14,
      "jsHeapTotalBytes": 5660672,
      "scriptDurationMs": 625.873,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.1930000000202,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 3.913,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.37600000000003,
      "heapDeltaBytes": 11663856,
      "heapUsedBytes": 91201272,
      "domNodes": -284,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 24.852,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2011.2779999999475,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.8020000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 395.563,
      "heapDeltaBytes": -2852056,
      "heapUsedBytes": 77168096,
      "domNodes": -270,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 32.611000000000004,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 455.10300000000825,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 7.128000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 275.23199999999997,
      "heapDeltaBytes": 14964320,
      "heapUsedBytes": 88210348,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 86.18999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 423.7239999999929,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 7.003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 271.437,
      "heapDeltaBytes": 14868864,
      "heapUsedBytes": 88115796,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 86.223,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.7370000000064,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.256,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 366.796,
      "heapDeltaBytes": -77460,
      "heapUsedBytes": 73090784,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.718,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.3869999999843,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.598999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 368.239,
      "heapDeltaBytes": 8644148,
      "heapUsedBytes": 81930584,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.620000000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.8330000000033,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 17.209000000000003,
      "layouts": 18,
      "layoutDurationMs": 3.1409999999999996,
      "taskDurationMs": 576.905,
      "heapDeltaBytes": -10291680,
      "heapUsedBytes": 63453084,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 67.766,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.1559999999877,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 18.916000000000004,
      "layouts": 18,
      "layoutDurationMs": 3.7199999999999998,
      "taskDurationMs": 615.383,
      "heapDeltaBytes": -4534344,
      "heapUsedBytes": 71497180,
      "domNodes": -296,
      "jsHeapTotalBytes": 4755456,
      "scriptDurationMs": 71.82000000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 832.0050000000379,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 21.718,
      "layouts": 16,
      "layoutDurationMs": 9.25,
      "taskDurationMs": 620.9250000000002,
      "heapDeltaBytes": -5132344,
      "heapUsedBytes": 85534324,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 20.939,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 96,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8125.899000000004,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 30.936,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3752.981,
      "heapDeltaBytes": 11775148,
      "heapUsedBytes": 90854848,
      "domNodes": -268,
      "jsHeapTotalBytes": 909312,
      "scriptDurationMs": 1723.5770000000002,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8153.204999999957,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 30.316000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3770.838,
      "heapDeltaBytes": -9836000,
      "heapUsedBytes": 67954636,
      "domNodes": -284,
      "jsHeapTotalBytes": 3305472,
      "scriptDurationMs": 1741.971,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10968.773999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10088.251,
      "heapDeltaBytes": -25706120,
      "heapUsedBytes": 179188368,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12595200,
      "scriptDurationMs": 148.19700000000003,
      "eventListeners": -14937,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11463.224000000082,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10554.859,
      "heapDeltaBytes": -22291940,
      "heapUsedBytes": 184795800,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13799424,
      "scriptDurationMs": 155.468,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13517.95199999998,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.434999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12920.979,
      "heapDeltaBytes": -39104268,
      "heapUsedBytes": 165768752,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14954496,
      "scriptDurationMs": 739.2909999999999,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 64,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14073.279000000071,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.661000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13466.748999999998,
      "heapDeltaBytes": -36869008,
      "heapUsedBytes": 187654644,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9105408,
      "scriptDurationMs": 678.531,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3701.4919999999734,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 53.836999999999996,
      "layouts": 20,
      "layoutDurationMs": 20.397000000000013,
      "taskDurationMs": 3541.6550000000007,
      "heapDeltaBytes": -40199448,
      "heapUsedBytes": 182461800,
      "domNodes": -8068,
      "jsHeapTotalBytes": 8904704,
      "scriptDurationMs": 55.353,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 55,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4200.358999999935,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 53.13900000000002,
      "layouts": 20,
      "layoutDurationMs": 21.996000000000002,
      "taskDurationMs": 4036.5409999999997,
      "heapDeltaBytes": -49077272,
      "heapUsedBytes": 178300976,
      "domNodes": -8068,
      "jsHeapTotalBytes": 6533120,
      "scriptDurationMs": 67.873,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5629.624000000035,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5174.690999999999,
      "heapDeltaBytes": 10668448,
      "heapUsedBytes": 177267388,
      "domNodes": 0,
      "jsHeapTotalBytes": -17563648,
      "scriptDurationMs": 109.99300000000001,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5303.08500000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4954.194000000001,
      "heapDeltaBytes": -598460,
      "heapUsedBytes": 178752248,
      "domNodes": 0,
      "jsHeapTotalBytes": -24903680,
      "scriptDurationMs": 64.05100000000003,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 421.69900000004645,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 13.501999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.82,
      "taskDurationMs": 83.904,
      "heapDeltaBytes": 4847948,
      "heapUsedBytes": 69793008,
      "domNodes": 124,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 6.486000000000001,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 448.6980000000358,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 16.892,
      "layouts": 3,
      "layoutDurationMs": 1.489,
      "taskDurationMs": 92.368,
      "heapDeltaBytes": 5012520,
      "heapUsedBytes": 76681776,
      "domNodes": 146,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.7090000000000005,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51062 76439 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from ryan-di October 3, 2026 23:31
@christian-byrne
christian-byrne enabled auto-merge (squash) October 3, 2026 23:32
@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.07407% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...latform/assets/composables/useUploadModelWizard.ts 76.19% 5 Missing ⚠️
src/stores/assetDownloadStore.ts 96.51% 3 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #20049   +/-   ##
=============================================
  Coverage              ?   84.25%           
=============================================
  Files                 ?     2131           
  Lines                 ?   128068           
  Branches              ?    32590           
=============================================
  Hits                  ?   107904           
  Misses                ?    19983           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.85% <32.74%> (?)
unit 79.55% <96.15%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rm/assets/components/ModelImportProgressDialog.vue 77.22% <100.00%> (ø)
src/stores/assetExportStore.ts 100.00% <100.00%> (ø)
src/stores/assetDownloadStore.ts 97.54% <96.51%> (ø)
...latform/assets/composables/useUploadModelWizard.ts 70.51% <76.19%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 2
🟡 Medium 4
🟢 Low 4

Panel: 8/8 reviewers contributed findings.

Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetExportStore.ts Resolved
Comment thread src/stores/assetExportStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetExportStore.test.ts Resolved
@christian-byrne christian-byrne assigned DrJKL and unassigned ryan-di Oct 4, 2026
@christian-byrne
christian-byrne requested review from DrJKL and removed request for ryan-di October 4, 2026 00:05

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Approve. This backport brings the files #20031 touches on cloud/1.54 to their content on main after #20031. The only differences are this branch's WebSocket type location, reportError options, and export URL handling.

I compared against #20031's merge commit d23d7802f5680f647a10d3620b61f63a7800ab01. cloud/1.54 already carried #19281 and part of the follow-up hardening through #19835 (da2ff4c427), so I compared end states rather than raw hunks. At this head, each file #20031 touches matches main after #20031, apart from the adaptations below. AssetExportProgressDialog.vue/.test.ts and taskService.ts already matched through #19835.

Adaptations, each accounted for by cloud/1.54:

  • AssetDownloadWsMessage and AssetExportWsMessage are imported from @/schemas/apiSchema, because src/platform/remote/comfyui/execution/types.ts does not exist on this branch. zAssetExportWsMessage here already accepts cancelled, so the source's status widening in that module is not needed.
  • ModelImportProgressDialog.vue and its test keep tags: { surface: 'assets' }, because ReportErrorOptions on cloud/1.54 has no surface field.
  • assetExportStore.ts keeps link.href = url, and d13b6e9 sets the server-relative triggerDownload expectation to match. The api.apiURL prefixing on main comes from #18944, which is not on cloud/1.54, so the branch keeps its existing root-relative behavior.
  • The remaining lines that go beyond the source hunks (test mock declarations, comment wording, and #19835's superseded reconciliation code and Close-button assertions) are where #19835's earlier carrier differed from main. They are resolved to main's content.

Checks: the six touched and adjacent Vitest files pass locally at this head (93 passed, 1 expected failure). vue-tsc --noEmit and pnpm typecheck:browser pass. Hosted CI at d13b6e9 passes lint-and-format, test and e2e-status. The only non-green runs are the two cancelled pr-risk jobs, which are not required.

@DrJKL DrJKL assigned christian-byrne and unassigned DrJKL Oct 4, 2026
@christian-byrne
christian-byrne merged commit df8b53e into cloud/1.54 Oct 4, 2026
124 of 126 checks passed
@christian-byrne
christian-byrne deleted the backport-20031-cloud-1.54 branch October 4, 2026 01:36
christian-byrne added a commit that referenced this pull request Oct 5, 2026
## Summary

Follow-up to #20031 and its release backports. This closes the
post-merge review gaps by:

- tombstoning dismissed pending downloads so late WebSocket frames
cannot reopen the toast, while still refreshing model caches after a
hidden completion
- settling malformed authoritative completions instead of polling
forever
- confirming DELETE 404 outcomes without falsely presenting a
still-running task as cancelled
- bounding task-not-found reconciliation and stopping unconfirmed
cancellation polling
- preserving late export names, validating export URL schemes, and
retrying transient export 404s
- preventing async upload watchers from outliving reset/disposal

## Validation

- Targeted Vitest: 74 passed, 1 expected failure
- App typecheck
- Targeted lint: 0 errors
- Diff whitespace check

Closes the actionable review findings raised on #20044, #20047, #20048,
and #20049.
@christian-byrne

Copy link
Copy Markdown
Contributor Author

For closure: the outstanding findings are addressed by #20166 (hardens cancellation and retry reconciliation) and #20162 (the merged release backport for this branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants