Repository navigation
[backport cloud/1.55] fix: close cancellation reconciliation review gaps (#20133) - #20161
Conversation
## Summary Follow-up to #20031 and its release backports. This closes the post-merge review gaps by: - tombstoning dismissed pending downloads so late WebSocket frames cannot reopen the toast, while still refreshing model caches after a hidden completion - settling malformed authoritative completions instead of polling forever - confirming DELETE 404 outcomes without falsely presenting a still-running task as cancelled - bounding task-not-found reconciliation and stopping unconfirmed cancellation polling - preserving late export names, validating export URL schemes, and retrying transient export 404s - preventing async upload watchers from outliving reset/disposal ## Validation - Targeted Vitest: 74 passed, 1 expected failure - App typecheck - Targeted lint: 0 errors - Diff whitespace check Closes the actionable review findings raised on #20044, #20047, #20048, and #20049.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2152 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6801769268f05edebb1228cae07c81ff94d62584
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-05T10:18:44.615Z",
"gitSha": "0c22d5750390ca4f83bea5cb1e93a620bb34b014",
"branch": "backport-20133-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2003.289000000052,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.899000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.832,
"heapDeltaBytes": -10729464,
"heapUsedBytes": 58509584,
"domNodes": -255,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.911000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1992.3110000000293,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.65,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.90600000000006,
"heapDeltaBytes": -1140072,
"heapUsedBytes": 61733348,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.807,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.5730000000149,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.396,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.899,
"heapDeltaBytes": 8851852,
"heapUsedBytes": 77449156,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 112.193,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1691.1029999999982,
"styleRecalcs": 48,
"styleRecalcDurationMs": 15.643999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.8159999999999,
"heapDeltaBytes": 3599700,
"heapUsedBytes": 72620176,
"domNodes": -256,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 109.97999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1687.6790000000028,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.040999999999999,
"layouts": 6,
"layoutDurationMs": 1.189,
"taskDurationMs": 252.44699999999997,
"heapDeltaBytes": 3030968,
"heapUsedBytes": 71723860,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.364000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.1420000000562,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.098000000000003,
"layouts": 6,
"layoutDurationMs": 1.233,
"taskDurationMs": 274.85499999999996,
"heapDeltaBytes": 2915280,
"heapUsedBytes": 72018128,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.306000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 515.9019999999828,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.086,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.595,
"heapDeltaBytes": -7945932,
"heapUsedBytes": 61040600,
"domNodes": 22,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 111.959,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 513.1999999999834,
"styleRecalcs": 15,
"styleRecalcDurationMs": 7.9670000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.256,
"heapDeltaBytes": 18532472,
"heapUsedBytes": 86763064,
"domNodes": 21,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 110.9,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 899.9640000000113,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.227,
"heapDeltaBytes": 13075544,
"heapUsedBytes": 104382336,
"domNodes": -263,
"jsHeapTotalBytes": 18501632,
"scriptDurationMs": 42.17199999999999,
"eventListeners": -195,
"totalBlockingTimeMs": 287,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 919.6900000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.45,
"heapDeltaBytes": -18644780,
"heapUsedBytes": 73166444,
"domNodes": -292,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 42.666,
"eventListeners": -195,
"totalBlockingTimeMs": 286,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 685.4940000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.34000000000015,
"heapDeltaBytes": 15114068,
"heapUsedBytes": 92364988,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 92.80699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 90,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.651000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 288.459,
"heapDeltaBytes": 14660452,
"heapUsedBytes": 91406700,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.355,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6440.424000000007,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.4359999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5130.844,
"heapDeltaBytes": 14026844,
"heapUsedBytes": 86809580,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 4095.453,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6576.8989999999685,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.2759999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5327.874,
"heapDeltaBytes": 12039228,
"heapUsedBytes": 93772052,
"domNodes": -16,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 4188.25,
"eventListeners": 0,
"totalBlockingTimeMs": 12,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6579.679999999997,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.6879999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5306.679,
"heapDeltaBytes": -5093908,
"heapUsedBytes": 73794316,
"domNodes": -263,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 4233.868,
"eventListeners": -174,
"totalBlockingTimeMs": 11,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6582.182999999986,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.269,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5287.6269999999995,
"heapDeltaBytes": 6551256,
"heapUsedBytes": 84628260,
"domNodes": -266,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 4196.196,
"eventListeners": -174,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2025.150999999994,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.744000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.848,
"heapDeltaBytes": -23397176,
"heapUsedBytes": 65188500,
"domNodes": -250,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 19.561,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.111000000038,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.550999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.576,
"heapDeltaBytes": -23627564,
"heapUsedBytes": 65155372,
"domNodes": -254,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 30.633999999999993,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2149.111000000005,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.625,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1062.631,
"heapDeltaBytes": -1007812,
"heapUsedBytes": 88631120,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 579.333,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2187.9560000000993,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.369,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1168.754,
"heapDeltaBytes": -1306416,
"heapUsedBytes": 88265380,
"domNodes": -248,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 577.9720000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3088.0319999999983,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.959,
"layouts": 60,
"layoutDurationMs": 14.115,
"taskDurationMs": 1042.479,
"heapDeltaBytes": -1105272,
"heapUsedBytes": 66510860,
"domNodes": 34,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 512.4190000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3106.4910000000054,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.334999999999999,
"layouts": 60,
"layoutDurationMs": 15.359,
"taskDurationMs": 1192.043,
"heapDeltaBytes": -332044,
"heapUsedBytes": 65351756,
"domNodes": 36,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 552.0860000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2153.32699999999,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.181,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1152.987,
"heapDeltaBytes": -17964276,
"heapUsedBytes": 74900824,
"domNodes": 18,
"jsHeapTotalBytes": 6590464,
"scriptDurationMs": 622.4179999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2323.3129999999846,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.691000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1327.046,
"heapDeltaBytes": 3491060,
"heapUsedBytes": 69494216,
"domNodes": 14,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 685.921,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2036.519999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.891,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.541,
"heapDeltaBytes": -23951656,
"heapUsedBytes": 66935036,
"domNodes": -255,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 29.676999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.9309999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.292000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.85900000000004,
"heapDeltaBytes": -23561452,
"heapUsedBytes": 67351684,
"domNodes": -249,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 27.733999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 392.6370000000361,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.058,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 257.155,
"heapDeltaBytes": 13436672,
"heapUsedBytes": 84242020,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 92.907,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.4160000000129,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.844,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.60600000000005,
"heapDeltaBytes": 13532052,
"heapUsedBytes": 84431980,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 100.453,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 1993.3469999999716,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.465000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 240.62800000000001,
"heapDeltaBytes": -8177308,
"heapUsedBytes": 62145244,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.605999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.2639999999774,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.574,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.682,
"heapDeltaBytes": -10183104,
"heapUsedBytes": 60952512,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.387,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.600000000023,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.366999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.9570000000001,
"heapDeltaBytes": 3519300,
"heapUsedBytes": 74210012,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 98.258,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.2240000000102,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.16,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.8380000000001,
"heapDeltaBytes": -13043308,
"heapUsedBytes": 58173728,
"domNodes": -272,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 86.409,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 801.0380000000055,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.369999999999997,
"layouts": 5,
"layoutDurationMs": 8.183,
"taskDurationMs": 586.098,
"heapDeltaBytes": 21644624,
"heapUsedBytes": 103458016,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 20.066,
"eventListeners": 2383,
"totalBlockingTimeMs": 66,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8153.423999999973,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.056,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3210.5769999999998,
"heapDeltaBytes": 1393800,
"heapUsedBytes": 90234496,
"domNodes": -248,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 1880.846,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8324.23700000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 46.013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4131.217,
"heapDeltaBytes": -7602216,
"heapUsedBytes": 80785096,
"domNodes": -248,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 1980.224,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12356.53400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12105.717,
"heapDeltaBytes": -49404492,
"heapUsedBytes": 191612840,
"domNodes": -8062,
"jsHeapTotalBytes": -17457152,
"scriptDurationMs": 194.44199999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12157.358999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11851.255,
"heapDeltaBytes": -33308168,
"heapUsedBytes": 193021932,
"domNodes": -8062,
"jsHeapTotalBytes": -17833984,
"scriptDurationMs": 202.548,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14341.228000000001,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.590999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14219.570000000002,
"heapDeltaBytes": -51544392,
"heapUsedBytes": 168160244,
"domNodes": -8061,
"jsHeapTotalBytes": -21241856,
"scriptDurationMs": 705.24,
"eventListeners": -14928,
"totalBlockingTimeMs": 64,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12104.623000000061,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.115999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11882.294,
"heapDeltaBytes": -39335416,
"heapUsedBytes": 180467104,
"domNodes": -8062,
"jsHeapTotalBytes": -12328960,
"scriptDurationMs": 608.666,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4454.612999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.583999999999996,
"layouts": 20,
"layoutDurationMs": 24.812,
"taskDurationMs": 4430.714999999999,
"heapDeltaBytes": -35014392,
"heapUsedBytes": 184432792,
"domNodes": -8066,
"jsHeapTotalBytes": 16437248,
"scriptDurationMs": 74.389,
"eventListeners": -14928,
"totalBlockingTimeMs": 106,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4359.397000000058,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.185999999999986,
"layouts": 20,
"layoutDurationMs": 23.138000000000005,
"taskDurationMs": 4334.296,
"heapDeltaBytes": -58081624,
"heapUsedBytes": 184507532,
"domNodes": -8062,
"jsHeapTotalBytes": 21688320,
"scriptDurationMs": 69.517,
"eventListeners": -14928,
"totalBlockingTimeMs": 77,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6102.823999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6036.748,
"heapDeltaBytes": 11280576,
"heapUsedBytes": 184739656,
"domNodes": 0,
"jsHeapTotalBytes": -23330816,
"scriptDurationMs": 82.94400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6064.360999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5868.33,
"heapDeltaBytes": 6226684,
"heapUsedBytes": 171412928,
"domNodes": 0,
"jsHeapTotalBytes": -25690112,
"scriptDurationMs": 80.55299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 82.15200000000777,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.441999999999998,
"layouts": 3,
"layoutDurationMs": 1.4510000000000003,
"taskDurationMs": 67.14699999999999,
"heapDeltaBytes": 3122868,
"heapUsedBytes": 69570096,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.341999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 420.6659999999829,
"styleRecalcs": 16,
"styleRecalcDurationMs": 17.237,
"layouts": 3,
"layoutDurationMs": 0.8310000000000002,
"taskDurationMs": 83.842,
"heapDeltaBytes": 4865852,
"heapUsedBytes": 71473088,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.304,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 5 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
This comment has been minimized.
This comment has been minimized.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.55 #20161 +/- ##
=============================================
Coverage ? 84.95%
=============================================
Files ? 2327
Lines ? 133649
Branches ? 33937
=============================================
Hits ? 113548
Misses ? 19739
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backports #20133 to this release branch.\n\nThis carries the reviewed cancellation/reconciliation hardening, bounded terminal markers, stale upload isolation, and export-download URL validation. Release-specific API imports and cloud URL behavior are preserved where applicable.\n\nValidation: the canonical change passed the focused 74-test suite (plus one expected failure), typecheck, and browser coverage. This PR is also running the target branch CI.