Repository navigation
[backport core/1.55] fix: close cancellation reconciliation review gaps (#20133) - #20160
Conversation
## Summary Follow-up to #20031 and its release backports. This closes the post-merge review gaps by: - tombstoning dismissed pending downloads so late WebSocket frames cannot reopen the toast, while still refreshing model caches after a hidden completion - settling malformed authoritative completions instead of polling forever - confirming DELETE 404 outcomes without falsely presenting a still-running task as cancelled - bounding task-not-found reconciliation and stopping unconfirmed cancellation polling - preserving late export names, validating export URL schemes, and retrying transient export 404s - preventing async upload watchers from outliving reset/disposal ## Validation - Targeted Vitest: 74 passed, 1 expected failure - App typecheck - Targeted lint: 0 errors - Diff whitespace check Closes the actionable review findings raised on #20044, #20047, #20048, and #20049.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2152 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ef87b5d06690e831eddf39f6d5762edaa46b1f0f
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-05T10:18:46.738Z",
"gitSha": "47ff21941ce9a7fb1061bad1e73abd2ec3ff59a6",
"branch": "backport-20133-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1990.4659999999694,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.908,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.18699999999995,
"heapDeltaBytes": 2906804,
"heapUsedBytes": 71617132,
"domNodes": -257,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.384000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2005.294000000049,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.331,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.77099999999996,
"heapDeltaBytes": -6929448,
"heapUsedBytes": 62097452,
"domNodes": -258,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 11.478,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.7889999999675,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.431,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.901,
"heapDeltaBytes": -7374324,
"heapUsedBytes": 61568224,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 121.79100000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1706.199999999967,
"styleRecalcs": 48,
"styleRecalcDurationMs": 16.194,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.276,
"heapDeltaBytes": -6378216,
"heapUsedBytes": 62282704,
"domNodes": -257,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 123.126,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.3439999999728,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.558,
"layouts": 6,
"layoutDurationMs": 1.4980000000000002,
"taskDurationMs": 284.21200000000005,
"heapDeltaBytes": 2968640,
"heapUsedBytes": 71429672,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 14.911000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.2239999999774,
"styleRecalcs": 29,
"styleRecalcDurationMs": 16.211999999999996,
"layouts": 6,
"layoutDurationMs": 1.156,
"taskDurationMs": 281.00199999999995,
"heapDeltaBytes": 2959392,
"heapUsedBytes": 71798108,
"domNodes": 80,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.722999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 515.0229999999851,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.616999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.989,
"heapDeltaBytes": 18183944,
"heapUsedBytes": 86966332,
"domNodes": 22,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 119.854,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 536.619000000087,
"styleRecalcs": 16,
"styleRecalcDurationMs": 11.128999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.274,
"heapDeltaBytes": 18155192,
"heapUsedBytes": 86409132,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 119.843,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 982.8340000000253,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.692,
"heapDeltaBytes": -18257912,
"heapUsedBytes": 73130912,
"domNodes": -292,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 44.613,
"eventListeners": -217,
"totalBlockingTimeMs": 319,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 934.4489999999723,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.3330000000001,
"heapDeltaBytes": -13148560,
"heapUsedBytes": 73353916,
"domNodes": -295,
"jsHeapTotalBytes": 19005440,
"scriptDurationMs": 39.87499999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 301,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 685.3199999999902,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.74199999999996,
"heapDeltaBytes": 14845568,
"heapUsedBytes": 90346512,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.18800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 87,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.3409999999803,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.774,
"heapDeltaBytes": 14587680,
"heapUsedBytes": 89915192,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.18400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6223.663000000044,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.11199999999999752,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5018.512,
"heapDeltaBytes": 1190724,
"heapUsedBytes": 83340940,
"domNodes": -18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 4088.4539999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 12,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6222.1510000000535,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8940000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5295.687999999999,
"heapDeltaBytes": -9579528,
"heapUsedBytes": 71883600,
"domNodes": -18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 4067.9829999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 19,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6201.864999999998,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.251000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5435.722,
"heapDeltaBytes": -8790332,
"heapUsedBytes": 72222420,
"domNodes": -14,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 4238.835,
"eventListeners": 0,
"totalBlockingTimeMs": 25,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6270.780999999943,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.7109999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5301.633,
"heapDeltaBytes": -742548,
"heapUsedBytes": 81340612,
"domNodes": -18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 4122.934,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2008.8820000000283,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.659,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.62399999999997,
"heapDeltaBytes": -23821096,
"heapUsedBytes": 64977972,
"domNodes": -253,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 29.878,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.636999999998,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.978000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.821,
"heapDeltaBytes": -23570176,
"heapUsedBytes": 65687624,
"domNodes": -247,
"jsHeapTotalBytes": 2650112,
"scriptDurationMs": 31.551000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2218.3860000000095,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1206.894,
"heapDeltaBytes": -63004,
"heapUsedBytes": 88818820,
"domNodes": -246,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 626.602,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2235.453000000007,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.878999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1285.193,
"heapDeltaBytes": -2482944,
"heapUsedBytes": 87970716,
"domNodes": -245,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 642.4949999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3184.708999999998,
"styleRecalcs": 72,
"styleRecalcDurationMs": 18.336000000000006,
"layouts": 60,
"layoutDurationMs": 16.077,
"taskDurationMs": 1330.6170000000002,
"heapDeltaBytes": -19080004,
"heapUsedBytes": 72049740,
"domNodes": -238,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 586.6589999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3192.222000000015,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.339,
"layouts": 60,
"layoutDurationMs": 15.490000000000002,
"taskDurationMs": 1252.2060000000001,
"heapDeltaBytes": 645972,
"heapUsedBytes": 66801524,
"domNodes": 30,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 593.7199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2308.131000000003,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.097000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1403.0420000000001,
"heapDeltaBytes": 3263168,
"heapUsedBytes": 69231420,
"domNodes": 10,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 729.941,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2421.0140000000138,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.223,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1445.6299999999999,
"heapDeltaBytes": -17862252,
"heapUsedBytes": 75398816,
"domNodes": 18,
"jsHeapTotalBytes": 7114752,
"scriptDurationMs": 752.409,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.6959999999867,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.853999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.874,
"heapDeltaBytes": -16220224,
"heapUsedBytes": 73879788,
"domNodes": -238,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 27.101,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1997.5939999999355,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.0169999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.78099999999995,
"heapDeltaBytes": 9882524,
"heapUsedBytes": 73827468,
"domNodes": -240,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.542999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 492.3149999999623,
"styleRecalcs": 50,
"styleRecalcDurationMs": 13.007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.69199999999995,
"heapDeltaBytes": 13527084,
"heapUsedBytes": 84119128,
"domNodes": 25,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 105.55799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 527.5060000000167,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.709000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.784,
"heapDeltaBytes": 13163836,
"heapUsedBytes": 83998416,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 110.387,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2005.7600000000093,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.883000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.70700000000005,
"heapDeltaBytes": 9156056,
"heapUsedBytes": 79697624,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.934000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.5440000000663,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.988999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.49899999999997,
"heapDeltaBytes": 9072712,
"heapUsedBytes": 79618264,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.706999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.0359999999678,
"styleRecalcs": 48,
"styleRecalcDurationMs": 16.527,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.8029999999999,
"heapDeltaBytes": -5126808,
"heapUsedBytes": 65631316,
"domNodes": -273,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 82.29899999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.0259999999316,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.968000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.687,
"heapDeltaBytes": -10395076,
"heapUsedBytes": 60238044,
"domNodes": -274,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 84.48400000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 883.1180000000245,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.225,
"layouts": 5,
"layoutDurationMs": 8.475999999999999,
"taskDurationMs": 666.83,
"heapDeltaBytes": -976488,
"heapUsedBytes": 96480268,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 22.605000000000008,
"eventListeners": 2383,
"totalBlockingTimeMs": 67,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8443.542000000036,
"styleRecalcs": 252,
"styleRecalcDurationMs": 48.997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4439.767000000001,
"heapDeltaBytes": -6072828,
"heapUsedBytes": 83639076,
"domNodes": -245,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 2171.016,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8456.327999999985,
"styleRecalcs": 251,
"styleRecalcDurationMs": 48.202,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4366.854,
"heapDeltaBytes": 3720576,
"heapUsedBytes": 92286176,
"domNodes": -234,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2134.878,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12001.500000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11369.829999999998,
"heapDeltaBytes": -41289992,
"heapUsedBytes": 184696296,
"domNodes": -8062,
"jsHeapTotalBytes": -16261120,
"scriptDurationMs": 158.57000000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12764.19999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12576.336000000001,
"heapDeltaBytes": -53109904,
"heapUsedBytes": 169974588,
"domNodes": -8062,
"jsHeapTotalBytes": -13185024,
"scriptDurationMs": 199.03899999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14895.847000000003,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.211000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14725.585000000003,
"heapDeltaBytes": -61778448,
"heapUsedBytes": 178869392,
"domNodes": -8062,
"jsHeapTotalBytes": -24272896,
"scriptDurationMs": 672.3280000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 36,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15223.854000000074,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.435000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15131.395,
"heapDeltaBytes": -44735656,
"heapUsedBytes": 181112152,
"domNodes": -8062,
"jsHeapTotalBytes": -18620416,
"scriptDurationMs": 722.616,
"eventListeners": -14928,
"totalBlockingTimeMs": 50,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4349.306000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.79499999999999,
"layouts": 20,
"layoutDurationMs": 22.820999999999994,
"taskDurationMs": 4335.368,
"heapDeltaBytes": -27656344,
"heapUsedBytes": 192462520,
"domNodes": -8062,
"jsHeapTotalBytes": 18866176,
"scriptDurationMs": 71.35900000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 102,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3672.2689999999147,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.38499999999999,
"layouts": 20,
"layoutDurationMs": 24.069000000000006,
"taskDurationMs": 3626.3039999999996,
"heapDeltaBytes": -33580184,
"heapUsedBytes": 207069452,
"domNodes": -8062,
"jsHeapTotalBytes": 16920576,
"scriptDurationMs": 63.91599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 6,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6122.689999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6031.321,
"heapDeltaBytes": 18274356,
"heapUsedBytes": 201824764,
"domNodes": 0,
"jsHeapTotalBytes": -20447232,
"scriptDurationMs": 84.85599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6349.968999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6288.209,
"heapDeltaBytes": 9247276,
"heapUsedBytes": 194284112,
"domNodes": 0,
"jsHeapTotalBytes": -25690112,
"scriptDurationMs": 116.96099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 438.02900000002865,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.853000000000005,
"layouts": 3,
"layoutDurationMs": 0.9870000000000002,
"taskDurationMs": 98.346,
"heapDeltaBytes": 4960156,
"heapUsedBytes": 71304724,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.894,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 87.52099999992424,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.138,
"layouts": 3,
"layoutDurationMs": 1.31,
"taskDurationMs": 64.423,
"heapDeltaBytes": 2988968,
"heapUsedBytes": 69719116,
"domNodes": 126,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.005000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 4 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
This comment has been minimized.
This comment has been minimized.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.55 #20160 +/- ##
============================================
Coverage 84.88% 84.89%
============================================
Files 2327 2327
Lines 132826 133102 +276
Branches 33622 35610 +1988
============================================
+ Hits 112755 112996 +241
- Misses 19709 19744 +35
Partials 362 362
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backports #20133 to this release branch.\n\nThis carries the reviewed cancellation/reconciliation hardening, bounded terminal markers, stale upload isolation, and export-download URL validation. Release-specific API imports and cloud URL behavior are preserved where applicable.\n\nValidation: the canonical change passed the focused 74-test suite (plus one expected failure), typecheck, and browser coverage. This PR is also running the target branch CI.