Repository navigation
test(agent): pin that capped attachment chips stay reachable - #20152
Conversation
The bulk-attachment cap from #20110 keeps Send on screen, but nothing pinned that the chips it hides remain reachable. Substituting overflow-hidden for overflow-y-auto strands 32 of the 36 chips and still passes every assertion in this spec, so scroll to the last chip instead of trusting the cap alone.
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-07T14:42:11.423Z",
"gitSha": "22f6dc4fdeac2072ae820c286049b38c5ea785fe",
"branch": "glary/pm1954-attachment-overflow-reachable",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2029.674,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.353999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.99899999999997,
"heapDeltaBytes": -51507664,
"heapUsedBytes": 58043392,
"domNodes": -212,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 12.332000000000003,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2028.3269999999902,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3819999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.90199999999993,
"heapDeltaBytes": -50809384,
"heapUsedBytes": 58870312,
"domNodes": -230,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 8.213000000000001,
"eventListeners": -122,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.0410000000206,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.939000000000002,
"layouts": 12,
"layoutDurationMs": 4.962,
"taskDurationMs": 816.406,
"heapDeltaBytes": -199200,
"heapUsedBytes": 63604872,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 163.581,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1698.8099999999804,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.129,
"layouts": 12,
"layoutDurationMs": 4.406000000000001,
"taskDurationMs": 781.323,
"heapDeltaBytes": 25966136,
"heapUsedBytes": 82397608,
"domNodes": -210,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.561,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.4349999999986,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.922999999999999,
"layouts": 3,
"layoutDurationMs": 0.9199999999999998,
"taskDurationMs": 331.1460000000001,
"heapDeltaBytes": 4469968,
"heapUsedBytes": 60986020,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.876,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.9340000000284,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.662,
"layouts": 3,
"layoutDurationMs": 0.949,
"taskDurationMs": 275.094,
"heapDeltaBytes": 9584864,
"heapUsedBytes": 78758784,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.028000000000004,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 641.8919999999844,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.9770000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.94599999999997,
"heapDeltaBytes": 17451760,
"heapUsedBytes": 73684888,
"domNodes": -210,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.265,
"eventListeners": -136,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 622.7259999999433,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8649999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.999,
"heapDeltaBytes": 17068924,
"heapUsedBytes": 73594276,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.11300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1208.1989999999792,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 858.949,
"heapDeltaBytes": 12646400,
"heapUsedBytes": 97237072,
"domNodes": 0,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 76.30400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 546,
"frameDurationMs": 34.285714285714285,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1156.7229999999427,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 812.493,
"heapDeltaBytes": 8880760,
"heapUsedBytes": 89415216,
"domNodes": 0,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 62.582999999999984,
"eventListeners": 0,
"totalBlockingTimeMs": 509,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 865.9120000000371,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.2089999999999,
"heapDeltaBytes": -6304384,
"heapUsedBytes": 83465452,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 169.20300000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.7339999999795,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.2550000000002,
"heapDeltaBytes": 19828936,
"heapUsedBytes": 97383004,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 167.83100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11411.037999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10457.243999999999,
"heapDeltaBytes": 12807648,
"heapUsedBytes": 82932020,
"domNodes": -141,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 8661.564,
"eventListeners": -65,
"totalBlockingTimeMs": 1617,
"frameDurationMs": 32.618,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9439.510999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8563.379,
"heapDeltaBytes": 8015716,
"heapUsedBytes": 95041844,
"domNodes": -141,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 7252.292,
"eventListeners": -73,
"totalBlockingTimeMs": 871,
"frameDurationMs": 32.08469387755102,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10131.63400000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.4659999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9232.391000000001,
"heapDeltaBytes": 6965164,
"heapUsedBytes": 93655944,
"domNodes": -141,
"jsHeapTotalBytes": -12455936,
"scriptDurationMs": 7628.572999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 980,
"frameDurationMs": 31.665312500000006,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9315.932999999972,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5269999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8554.733,
"heapDeltaBytes": 14508180,
"heapUsedBytes": 85088504,
"domNodes": -141,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 7019.888,
"eventListeners": -65,
"totalBlockingTimeMs": 679,
"frameDurationMs": 31.68843537414966,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2017.2769999999787,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.932,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.3770000000001,
"heapDeltaBytes": -4568648,
"heapUsedBytes": 76483760,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.410999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.839000000029,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5340000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.4209999999999,
"heapDeltaBytes": -49752212,
"heapUsedBytes": 82254984,
"domNodes": -308,
"jsHeapTotalBytes": -2195456,
"scriptDurationMs": 35.662,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2248.8950000000045,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.1259999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1599.281,
"heapDeltaBytes": 15777200,
"heapUsedBytes": 80767560,
"domNodes": -308,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 809.651,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2211.5360000000237,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.932000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1540.035,
"heapDeltaBytes": 11415440,
"heapUsedBytes": 76683292,
"domNodes": -308,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 795.396,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666165413533836,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3680.5329999999685,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.162999999999998,
"layouts": 60,
"layoutDurationMs": 16.926999999999996,
"taskDurationMs": 1730.9579999999999,
"heapDeltaBytes": 5309348,
"heapUsedBytes": 76172536,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 808.133,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3617.615999999998,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.688999999999999,
"layouts": 60,
"layoutDurationMs": 15.437999999999999,
"taskDurationMs": 1648.8489999999997,
"heapDeltaBytes": 4732948,
"heapUsedBytes": 71711196,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 786.0409999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3041.4260000000013,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.265999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1874.184,
"heapDeltaBytes": 17720360,
"heapUsedBytes": 84498296,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 952.9179999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75888888888889,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2928.634000000102,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.0470000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1877.9620000000002,
"heapDeltaBytes": 17927876,
"heapUsedBytes": 89259680,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 979.4289999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761494252873558,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.3179999999747,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.9110000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.1009999999999,
"heapDeltaBytes": 17859544,
"heapUsedBytes": 82726676,
"domNodes": -308,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.00500000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.8759999999584,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1649999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.117,
"heapDeltaBytes": -2244220,
"heapUsedBytes": 89673052,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.381999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.6399999999785,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.515,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.355,
"heapDeltaBytes": -10017772,
"heapUsedBytes": 61438028,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 147.93300000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.7579999999653,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.632999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.4429999999999,
"heapDeltaBytes": -9546208,
"heapUsedBytes": 62796428,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 139.32,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2008.2400000000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.17,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.09499999999997,
"heapDeltaBytes": 3853280,
"heapUsedBytes": 67474532,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.033999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.7730000000665,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.241,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.74600000000004,
"heapDeltaBytes": 3642792,
"heapUsedBytes": 67588480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.6000000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.4479999999758,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.199,
"layouts": 16,
"layoutDurationMs": 7.203,
"taskDurationMs": 675.333,
"heapDeltaBytes": 21190892,
"heapUsedBytes": 77238264,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.03999999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.3039999999792,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.840999999999998,
"layouts": 16,
"layoutDurationMs": 5.436,
"taskDurationMs": 738.5809999999999,
"heapDeltaBytes": -404540,
"heapUsedBytes": 71717716,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 103.64000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.8419999999269,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.868999999999996,
"layouts": 5,
"layoutDurationMs": 15.087,
"taskDurationMs": 1017.3510000000001,
"heapDeltaBytes": 32295928,
"heapUsedBytes": 108835856,
"domNodes": 14570,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 32.933,
"eventListeners": 2458,
"totalBlockingTimeMs": 136,
"frameDurationMs": 19.367567567567576,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8741.284000000007,
"styleRecalcs": 251,
"styleRecalcDurationMs": 19.520000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5622.043,
"heapDeltaBytes": -65119452,
"heapUsedBytes": 66708148,
"domNodes": -308,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 2664.2680000000005,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665904761904763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8545.211999999992,
"styleRecalcs": 251,
"styleRecalcDurationMs": 19.201000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5563.574,
"heapDeltaBytes": -61394252,
"heapUsedBytes": 66444452,
"domNodes": -308,
"jsHeapTotalBytes": -4292608,
"scriptDurationMs": 2633.1070000000004,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666144814090018,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19049.35599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18395.920000000002,
"heapDeltaBytes": -36099100,
"heapUsedBytes": 183880280,
"domNodes": -3046,
"jsHeapTotalBytes": 6430720,
"scriptDurationMs": 292.491,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.53435897435898,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 18307.596000000103,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17463.601,
"heapDeltaBytes": -19577140,
"heapUsedBytes": 199966396,
"domNodes": -3046,
"jsHeapTotalBytes": 4128768,
"scriptDurationMs": 272.964,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.202555366269166,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 23788.468000000023,
"styleRecalcs": 180,
"styleRecalcDurationMs": 18.69399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23395.178,
"heapDeltaBytes": -25521584,
"heapUsedBytes": 191185004,
"domNodes": -3046,
"jsHeapTotalBytes": 8962048,
"scriptDurationMs": 918.981,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.2360594795539,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23255.539999999997,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.473000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22890.769,
"heapDeltaBytes": -32354280,
"heapUsedBytes": 188989440,
"domNodes": -3046,
"jsHeapTotalBytes": -3825664,
"scriptDurationMs": 863.001,
"eventListeners": -14915,
"totalBlockingTimeMs": 27,
"frameDurationMs": 43.16456400742115,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6753.188000000023,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.302,
"layouts": 20,
"layoutDurationMs": 26.08999999999999,
"taskDurationMs": 6656.1849999999995,
"heapDeltaBytes": -2853016,
"heapUsedBytes": 215542132,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 120.392,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.70837988826816,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6634.760999999912,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.857,
"layouts": 20,
"layoutDurationMs": 23.66900000000001,
"taskDurationMs": 6493.533,
"heapDeltaBytes": 1031156,
"heapUsedBytes": 217799008,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 111.186,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.90342857142857,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9590.103,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9377.394,
"heapDeltaBytes": -34015760,
"heapUsedBytes": 183136416,
"domNodes": -3046,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 161.39800000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.407168458781356,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9227.941999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8941.217999999999,
"heapDeltaBytes": -31621572,
"heapUsedBytes": 183839944,
"domNodes": -3046,
"jsHeapTotalBytes": 9228288,
"scriptDurationMs": 137.037,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.297966101694907,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 486.16200000003573,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.786,
"layouts": 4,
"layoutDurationMs": 2.1470000000000007,
"taskDurationMs": 123.48100000000001,
"heapDeltaBytes": 6406356,
"heapUsedBytes": 62637100,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.263,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 168.93799999991188,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.459999999999999,
"layouts": 4,
"layoutDurationMs": 1.9729999999999999,
"taskDurationMs": 160.90699999999995,
"heapDeltaBytes": -51635724,
"heapUsedBytes": 55464820,
"domNodes": 124,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 7.344999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.5222222222222,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 830.8529999999337,
"styleRecalcs": 78,
"styleRecalcDurationMs": 86.837,
"layouts": 76,
"layoutDurationMs": 25.265,
"taskDurationMs": 807.2139999999999,
"heapDeltaBytes": 17867280,
"heapUsedBytes": 92820844,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 333.763,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 744.8849999999538,
"styleRecalcs": 78,
"styleRecalcDurationMs": 82.133,
"layouts": 76,
"layoutDurationMs": 23.976999999999997,
"taskDurationMs": 716.804,
"heapDeltaBytes": 16846284,
"heapUsedBytes": 88533680,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 288.106,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1334.797999999978,
"styleRecalcs": 78,
"styleRecalcDurationMs": 248.952,
"layouts": 76,
"layoutDurationMs": 28.048,
"taskDurationMs": 1306.853,
"heapDeltaBytes": 10467360,
"heapUsedBytes": 123383804,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 471.461,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.875949367088594,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1379.4639999999845,
"styleRecalcs": 78,
"styleRecalcDurationMs": 243.527,
"layouts": 76,
"layoutDurationMs": 28.385,
"taskDurationMs": 1356.8159999999998,
"heapDeltaBytes": -19384740,
"heapUsedBytes": 116529488,
"domNodes": 76,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 462.2869999999999,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.289999999999985,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 765c5fd0fe94c5eb3481f6f34b1bf9b01c11b499
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2240 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe bulk-attachment browser test now checks that the Send path is visible and that scrolling the asset section brings the last attachment chip fully into the viewport. ChangesBulk attachment composer test
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The added browser check detects when the attachment list can no longer be scrolled to its final chip. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
benceruleanlu
left a comment
There was a problem hiding this comment.
The scoped regression coverage looks good: it exercises real wheel scrolling, verifies the final attachment chip is fully visible, and retains the send/payload assertions for all 36 attachments. No blocking code issues found. CI still needs attention before merging: the failing cloud shard reports an unrelated agentConversationReplay.spec.ts PM-1135 asset-grid-fragmentation screenshot mismatch. Handing this back to Christian to handle CI.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20152 +/- ##
==========================================
+ Coverage 85.64% 86.46% +0.82%
==========================================
Files 3542 2493 -1049
Lines 169897 141827 -28070
Branches 44594 36613 -7981
==========================================
- Hits 145511 122633 -22878
+ Misses 22383 18809 -3574
+ Partials 2003 385 -1618
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…mfy-Org#20156) ## Summary Separate attached assets from inline references so users can build a prompt naturally while keeping their files in a visible asset tray. ## Changes - **A separate asset tray.** Added assets appear above the prompt as thumbnails or type icons, with transparent backgrounds and no borders. Filenames appear on hover. The circular × appears on hover or keyboard focus, and stays visible on touch devices. The extra node-reference row is removed. - **Assets referenced inline with `@`.** Users can search by asset name and select with the mouse or keyboard to insert at the caret. The same asset can be referenced unlimited times. Assets sit alongside the existing node and workflow options. - **Consistent, compact inline chips.** Asset, node and workflow chips share the same appearance and removal interaction, with no left/right padding. Chips fit within the compact composer line height. Removing a chip deletes only that occurrence, supports Undo and returns focus for continued typing. - **Different hover behavior for tray and inline.** Tray hover shows the filename and a large image or media preview. Click, keyboard and touch can open an interactive preview. Activating another asset replaces the current preview, so only one stays open. Inline hover/focus highlights the corresponding tray asset without opening a preview, so inserting a chip beneath the pointer doesn't interrupt typing. - **Video and audio support.** Videos share one thumbnail across the tray, `@` menu and inline chips. Audio uses the music icon throughout, including renamed files. Tray previews provide native playback controls with no autoplay. Closing, replacing or removing a preview stops and resets playback, including quick close/reopen. Audio controls are inset within the card’s corners. - **Discoverable tray scrolling.** Many assets stay in one horizontally scrollable row at a consistent size. Arrows and edge fades indicate additional content. Controls reflect scroll boundaries and update as assets or panel width change. - **The whole chat panel accepts drops.** Users can drop supported files or drag assets from the in-app library anywhere in the panel. Drop feedback covers the panel while preserving composer layout and input. Library drops work for unnamed assets and re-additions after removal or sending; already included library assets remain deduplicated. - **Duplicate additions stay clear.** Adding an included file or library asset again keeps one tray item and shows a brief filename notice; a batch reports the number skipped while unique files continue uploading. Removing an asset and adding it again is allowed, and repeated inline mentions remain unlimited. - **Stable composer sizing.** Production-style compact text spacing is retained. Inline chips don't expand the line height. Starting to type doesn't shrink the composer when its placeholder wraps onto multiple lines. - **Clear attachment and removal rules.** Adding an asset doesn't automatically mention it. Removing an inline occurrence keeps the asset in the tray; removing the tray asset removes all its mentions. Sending includes each tray asset once, even when unmentioned or referenced repeatedly. Asset-only messages work. Failed sends restore an untouched draft; newer input takes priority. - **Visible upload feedback.** Pending-upload status stays visible outside the horizontally scrolling tray. Users can see why Send is unavailable, and pressing Enter preserves their draft while uploads are pending. - **Theme-aware styling and fresh node references.** Asset surfaces, previews, highlights and controls follow the active theme. The `@` node list follows the eligible viewed graph as nodes are added, renamed or removed, and updates when switching graphs without another keystroke. ## Review Focus Check the distinction between tray inclusion and inline occurrences, draft recovery after a failed send, and preview cleanup after removal, replacement or successful sending. Preserve the bulk-layout/action guarantees from Comfy-Org#20110 and the upload-feedback behavior overlapping Comfy-Org#20150/Comfy-Org#20152. Validation: 553 tests pass across ten focused unit/component suites after merging latest main. All 14 focused Chromium browser regressions pass with retries disabled: exclusive previews, native media close/reopen and replacement, single/plural duplicate notices, mixed pending batches, grid/list null-name library re-addition, touch disclosure/removal, node rename/delete/undo freshness, shared posters and short-panel geometry. Touch was emulated; physical devices were not exercised. Normal commit and Knip/Fallow push gates pass without added suppressions or baseline changes. Remote CI is pending for this update. Comfy-Org#20157 was squash-merged into this branch; its media work is included in this PR. File deduplication uses browser file metadata (name, size, lastModified and MIME type); library additions use stable source identity. It does not hash local file bytes or retroactively remove duplicates from an already-open draft. ## Linear tracking - Upgrade and full related-ticket map: [FE-3219](https://linear.app/comfyorg/issue/FE-3219/agent-composer-asset-tray-with-independent-inline-references). - Fixes tracked within this PR: [FE-3220](https://linear.app/comfyorg/issue/FE-3220/fix-stale-node-candidates-in-the-agent-picker) (stale `@` node candidates) and [FE-3221](https://linear.app/comfyorg/issue/FE-3221/fix-unnamed-and-re-added-library-asset-drops-into-agent-chat) (unnamed/re-added library drops). - QA: [CQA-1080](https://linear.app/comfyorg/issue/CQA-1080/asset-tray-independent-inline-asset-references-in-agent-composer-20156). Related product reports: [PM-1230](https://linear.app/comfyorg/issue/PM-1230) / [PM-1231](https://linear.app/comfyorg/issue/PM-1231) cover attachment/reference confusion. [PM-1126](https://linear.app/comfyorg/issue/PM-1126) / [PM-1127](https://linear.app/comfyorg/issue/PM-1127) are partially aligned: mentions become optional, but this PR uses a tray rather than their proposed Reference-panel section. [FE-2209](https://linear.app/comfyorg/issue/FE-2209) was reopened for the approved composer rework and is In Review: show nodes once inline, keep useful asset previews, and preserve sent-message rendering. This upgrade also changes asset removal so deleting an inline occurrence keeps the included file. Upstream overlap: [PM-1954](https://linear.app/comfyorg/issue/PM-1954) / [FE-3202](https://linear.app/comfyorg/issue/FE-3202) retain ownership of bulk-layout/upload-feedback fixes (Comfy-Org#20110, Comfy-Org#20150, Comfy-Org#20152); their guarantees are preserved here. These related links do not assert that every older ticket is fully resolved. Media scope from Comfy-Org#20157 is included here, with QA in [CQA-1081](https://linear.app/comfyorg/issue/CQA-1081/shared-video-posters-and-hover-playback-for-agent-media-attachments). --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
PR Created by the Glary-Bot Agent
Closes a coverage gap in the FE-3202 / PM-1954 regression test that #20110 shipped.
The gap
#20110 capped the attachment chip list at
max-h-32 overflow-y-auto, which keeps Send on screen, andagentBulkAttachmentComposer.spec.tspins that. But nothing pinned the other half of the cap: that the chips it pushes out of sight stay reachable.Measured, not assumed — substituting
overflow-hiddenforoverflow-y-autooncomposer-asset-sectionstrands 32 of the 36 chips with no way to scroll to them, and the spec still passes:Every existing assertion survives that substitution: the chips still mount, Send is still enabled, and Send is still fully in viewport. A cap that hides attachments irretrievably would ship green.
The change
Scroll the list and assert the last chip actually becomes reachable, rather than trusting the cap or asserting a class name:
The
toBe(0)baseline keeps the wheel the only thing that can have moved the list — programmatic and focus-driven scrolling both work on anoverflow:hiddencontainer, so without it a futurescrollIntoViewon a chip would silently turn this into an assertion that always passes.Test title widened to name both guarantees, so a failure here points at the chip list rather than at the Send button.
mainas-isoverflow-y-auto→overflow-hiddenscrollTopstays0Test-only, 15 lines.
pnpm typecheck:browser,pnpm lint:unstaged,oxfmt --checkclean.Context
This is one of two PRs from a root-cause pass on PM-1954. The other, #20150, fixes the second and still-unfixed defect behind that report: the composer silently refuses to send while attachment uploads are in flight. #20129 proposed an alternative layout fix for the first defect and is superseded by #20110, which has already landed.
Relates to PM-1954, FE-3202.